Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/669
---
GitHub user ivmaykov reopened a pull request:
https://github.com/apache/zookeeper/pull/669
ZOOKEEPER-3152: Port ZK netty stack to netty4
Summary: Ported the client connection netty stack from netty3 to netty4.
This includes both the server side (NettyServerCnxn and friends) and the
Github user ivmaykov closed the pull request at:
https://github.com/apache/zookeeper/pull/669
---
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233664524
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233663529
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233663197
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233661987
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233659698
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233659921
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -316,16 +251,17 @@ public void
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233651445
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -316,16 +251,17 @@ public void
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233651730
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/test/TestByteBufAllocator.java
---
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233650367
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233652712
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +105,102 @@
boolean isConnected() {
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233653584
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +105,102 @@
boolean isConnected() {
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233649908
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233289109
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +105,102 @@
boolean isConnected() {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233288683
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +105,102 @@
boolean isConnected() {
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233279457
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233282137
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -316,16 +251,17 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233278670
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +116,104 @@ public void
Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r233286512
--- Diff:
zookeeper-server/src/test/java/org/apache/zookeeper/test/TestByteBufAllocator.java
---
@@ -0,0 +1,152 @@
+/*
+ * Licensed to the
GitHub user ivmaykov reopened a pull request:
https://github.com/apache/zookeeper/pull/669
ZOOKEEPER-3152: Port ZK netty stack to netty4
Summary: Ported the client connection netty stack from netty3 to netty4.
This includes both the server side (NettyServerCnxn and friends) and the
Github user ivmaykov closed the pull request at:
https://github.com/apache/zookeeper/pull/669
---
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226849723
--- Diff: ivy.xml ---
@@ -59,9 +59,11 @@
-
-
-
+
--- End diff --
I forgot about this.
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226845944
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226839154
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -267,7 +298,7 @@ private void sendPkt(Packet p) {
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226839114
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226838972
--- Diff:
zookeeper-common/src/test/java/org/apache/zookeeper/common/TestByteBufAllocator.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226836043
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -439,13 +466,34 @@ public void
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226835980
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -267,7 +298,7 @@ private void sendPkt(Packet p) {
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226835913
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +108,95 @@
boolean isConnected() {
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226835891
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -68,18 +70,21 @@
public class
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226757240
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -335,29 +260,34 @@ public void
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226757190
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226757057
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226756739
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java
---
@@ -200,24 +186,13 @@ public void setSessionId(long
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226756353
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -439,13 +466,34 @@ public void
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226756565
--- Diff:
zookeeper-common/src/test/java/org/apache/zookeeper/common/TestByteBufAllocator.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226756052
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -267,7 +298,7 @@ private void sendPkt(Packet p) {
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226755668
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -184,7 +213,9 @@ void cleanup() {
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226755419
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +108,95 @@
boolean isConnected() {
Github user ivmaykov commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226755285
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -68,18 +70,21 @@
public class
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226687650
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxn.java
---
@@ -200,24 +186,13 @@ public void setSessionId(long
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226684843
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -439,13 +466,34 @@ public void
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226685450
--- Diff:
zookeeper-common/src/test/java/org/apache/zookeeper/common/TestByteBufAllocator.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226690017
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226684209
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -267,7 +298,7 @@ private void sendPkt(Packet p) {
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226683922
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -184,7 +213,9 @@ void cleanup() {
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226681741
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -68,18 +70,21 @@
public class
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226690548
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -335,29 +260,34 @@ public void
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226682998
--- Diff:
zookeeper-common/src/main/java/org/apache/zookeeper/ClientCnxnSocketNetty.java
---
@@ -103,71 +108,95 @@
boolean isConnected() {
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r226689302
--- Diff:
zookeeper-server/src/main/java/org/apache/zookeeper/server/NettyServerCnxnFactory.java
---
@@ -116,170 +115,94 @@ public void
Github user dain commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/669#discussion_r225332620
--- Diff:
zookeeper-common/src/test/java/org/apache/zookeeper/common/TestByteBufAllocator.java
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to the Apache
GitHub user ivmaykov opened a pull request:
https://github.com/apache/zookeeper/pull/669
ZOOKEEPER-3152: Port ZK netty stack to netty4
Summary: Ported the client connection netty stack from netty3 to netty4.
This includes both the server side (NettyServerCnxn and friends) and the
54 matches
Mail list logo
