[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16832756#comment-16832756 ] Peter Szecsi commented on ZOOKEEPER-1407: - Hello guys, I have come up with a similar problem for getChildren, and created a Jira for that as well. ([ZOOKEEPER-3361|https://issues.apache.org/jira/browse/ZOOKEEPER-3361]) I hope you don't mind, I have added it as a subtask to this ticket when I found it. There is already a 2 open pull requests for supporting the "multi getChildren" operation in a way or another. ([pr-922|https://github.com/apache/zookeeper/pull/922/], [pr-929|https://github.com/apache/zookeeper/pull/929/]). I would be glad to work on this ticket and implement the multi version of getData as well. Would you be OK with it? Or [~zhi...@ebaysf.com], would you like to finish this yourself? > Support GetData and GetChildren in Multi > > > Key: ZOOKEEPER-1407 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, server >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.6.0, 3.5.6 > > Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407-v5.txt, > 1407.txt > > > There is use case where GetData and GetChildren would participate in Multi. > We should add support for this case. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807213#comment-16807213 ] Brian Gallew commented on ZOOKEEPER-1407: - My use case is "reading the Kafka state out of Zookeeper involves thousands of round trips." One to list all the topics. One per topic to list all the partitions. One per partition to get the state. My smallest clusters all have more than 1000 partitions on them, while my largest ones have ... more. It seems odd for a Priority:Major ticket to be ignored for 6 years (outside of one comment asking about use case). > Support GetData and GetChildren in Multi > > > Key: ZOOKEEPER-1407 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, server >Reporter: Ted Yu >Assignee: Ted Yu >Priority: Major > Fix For: 3.6.0, 3.5.5 > > Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407-v5.txt, > 1407.txt > > > There is use case where GetData and GetChildren would participate in Multi. > We should add support for this case. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522484#comment-15522484 ] Flavio Junqueira commented on ZOOKEEPER-1407: - [~Keerikkadan91] thanks for asking. I don't know your use case, but typically you don't need read operations as part of your multi call. Setting a watch with the znode for data or children changes when reading from zookeeper is typically sufficient, but again, I don't know your use case. > Support GetData and GetChildren in Multi > > > Key: ZOOKEEPER-1407 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, server >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 3.5.3, 3.6.0 > > Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407-v5.txt, > 1407.txt > > > There is use case where GetData and GetChildren would participate in Multi. > We should add support for this case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511389#comment-15511389 ] Roney Michael commented on ZOOKEEPER-1407: -- Is this feature still being worked on? Is there an efficient workaround? > Support GetData and GetChildren in Multi > > > Key: ZOOKEEPER-1407 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 > Project: ZooKeeper > Issue Type: Improvement > Components: java client, server >Reporter: Ted Yu >Assignee: Ted Yu > Fix For: 3.5.3, 3.6.0 > > Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407-v5.txt, > 1407.txt > > > There is use case where GetData and GetChildren would participate in Multi. > We should add support for this case. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13242049#comment-13242049 ] Hadoop QA commented on ZOOKEEPER-1407: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520560/1407-v4.txt against trunk revision 1307191. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The applied patch generated 6 javac compiler warnings (more than the trunk's current 5 warnings). -1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1020//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1020//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1020//console This message is automatically generated. Support GetData and GetChildren in Multi Key: ZOOKEEPER-1407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 Project: ZooKeeper Issue Type: Improvement Reporter: Zhihong Yu Fix For: 3.5.0 Attachments: 1407-v2.txt, 1407-v3.txt, 1407-v4.txt, 1407.txt There is use case where GetData and GetChildren would participate in Multi. We should add support for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234148#comment-13234148 ] Marshall McMullen commented on ZOOKEEPER-1407: -- This is probably related to changes that just went in for https://issues.apache.org/jira/browse/ZOOKEEPER-1344 Support GetData and GetChildren in Multi Key: ZOOKEEPER-1407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 Project: ZooKeeper Issue Type: Improvement Reporter: Zhihong Yu Fix For: 3.5.0 Attachments: 1407-v2.txt, 1407.txt There is use case where GetData and GetChildren would participate in Multi. We should add support for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234432#comment-13234432 ] Hadoop QA commented on ZOOKEEPER-1407: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12519238/1407-v3.txt against trunk revision 1302736. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1003//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1003//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1003//console This message is automatically generated. Support GetData and GetChildren in Multi Key: ZOOKEEPER-1407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 Project: ZooKeeper Issue Type: Improvement Reporter: Zhihong Yu Fix For: 3.5.0 Attachments: 1407-v2.txt, 1407-v3.txt, 1407.txt There is use case where GetData and GetChildren would participate in Multi. We should add support for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233631#comment-13233631 ] Camille Fournier commented on ZOOKEEPER-1407: - Zhihong, it's good if you change the state to Patch Available when you've got something for us to look at. We generally look at the patch available queue to determine what we need to review, etc. It will also trigger the automated build check. I've set this one to patch available. Support GetData and GetChildren in Multi Key: ZOOKEEPER-1407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 Project: ZooKeeper Issue Type: Improvement Reporter: Zhihong Yu Fix For: 3.5.0 Attachments: 1407-v2.txt, 1407.txt There is use case where GetData and GetChildren would participate in Multi. We should add support for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233634#comment-13233634 ] Zhihong Yu commented on ZOOKEEPER-1407: --- Thanks Camille. Without proper unit tests Ted Dunning requested, I didn't regard the patch to be available for full-scale review. Pardon my laziness. Support GetData and GetChildren in Multi Key: ZOOKEEPER-1407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 Project: ZooKeeper Issue Type: Improvement Reporter: Zhihong Yu Fix For: 3.5.0 Attachments: 1407-v2.txt, 1407.txt There is use case where GetData and GetChildren would participate in Multi. We should add support for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13233717#comment-13233717 ] Hadoop QA commented on ZOOKEEPER-1407: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12517718/1407-v2.txt against trunk revision 1302736. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause tar ant target to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1002//testReport/ Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1002//console This message is automatically generated. Support GetData and GetChildren in Multi Key: ZOOKEEPER-1407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 Project: ZooKeeper Issue Type: Improvement Reporter: Zhihong Yu Fix For: 3.5.0 Attachments: 1407-v2.txt, 1407.txt There is use case where GetData and GetChildren would participate in Multi. We should add support for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13234000#comment-13234000
]
Zhihong Yu commented on ZOOKEEPER-1407:
---
I see the following in build output:
{code}
[exec] [javac]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/java/main/org/apache/zookeeper/Op.java:293:
org.apache.zookeeper.Op.GetChildren is not abstract and does not override
abstract method withChroot(java.lang.String) in org.apache.zookeeper.Op
[exec] [javac] public static class GetChildren extends Op {
{code}
Looking at other classes (such as Delete) in Op.java, I don't see them having
withChroot() method.
I searched codebase and didn't find where withChroot() is defined.
For the following:
{code}
[exec] [javac]
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/trunk/src/java/main/org/apache/zookeeper/server/DataTree.java:758:
cannot find symbol
[exec] [javac] symbol : variable debug
[exec] [javac] location: class org.apache.zookeeper.server.DataTree
[exec] [javac] debug = Get children transaction for
{code}
debug is defined at line 732, outside the try loop.
Support GetData and GetChildren in Multi
Key: ZOOKEEPER-1407
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
Project: ZooKeeper
Issue Type: Improvement
Reporter: Zhihong Yu
Fix For: 3.5.0
Attachments: 1407-v2.txt, 1407.txt
There is use case where GetData and GetChildren would participate in Multi.
We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225717#comment-13225717 ] Zhihong Yu commented on ZOOKEEPER-1407: --- https://reviews.apache.org/r/4264/ has been created. Support GetData and GetChildren in Multi Key: ZOOKEEPER-1407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 Project: ZooKeeper Issue Type: Improvement Reporter: Zhihong Yu Attachments: 1407.txt There is use case where GetData and GetChildren would participate in Multi. We should add support for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225728#comment-13225728 ] Zhihong Yu commented on ZOOKEEPER-1407: --- I see SetDataTxn used in a private method, proposeSetData(), of Zab1_0Test. w.r.t. writing test for GetData, I would seek some advice. Support GetData and GetChildren in Multi Key: ZOOKEEPER-1407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 Project: ZooKeeper Issue Type: Improvement Reporter: Zhihong Yu Attachments: 1407.txt There is use case where GetData and GetChildren would participate in Multi. We should add support for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225859#comment-13225859
]
Zhihong Yu commented on ZOOKEEPER-1407:
---
Uploaded new version of patch which covers GetChildren.
I think we should produce better hash code compared to what we have now:
{code}
public int hashCode() {
return getType() + getPath().hashCode() + Arrays.hashCode(data) +
version;
}
{code}
Support GetData and GetChildren in Multi
Key: ZOOKEEPER-1407
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407
Project: ZooKeeper
Issue Type: Improvement
Reporter: Zhihong Yu
Attachments: 1407.txt
There is use case where GetData and GetChildren would participate in Multi.
We should add support for this case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1407) Support GetData and GetChildren in Multi
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13225912#comment-13225912 ] Marshall McMullen commented on ZOOKEEPER-1407: -- I don't see a new version of the patch to cover GetChildren... did you forget to upload new patch? I agree hashCode could be improved. Support GetData and GetChildren in Multi Key: ZOOKEEPER-1407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1407 Project: ZooKeeper Issue Type: Improvement Reporter: Zhihong Yu Attachments: 1407.txt There is use case where GetData and GetChildren would participate in Multi. We should add support for this case. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
