[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833877#comment-15833877
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user rakeshadr commented
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833876#comment-15833876
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user rakeshadr closed th
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833796#comment-15833796
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user hanm commented on t
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795648#comment-15795648
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user hanm commented on t
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795616#comment-15795616
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user rakeshadr commented
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15795574#comment-15795574
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user hanm commented on t
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15773279#comment-15773279
]
Rakesh R commented on ZOOKEEPER-2383:
-
[PR_135|https://github.com/apache/zookeeper
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15773276#comment-15773276
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
GitHub user rakeshadr opened a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770897#comment-15770897
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~hanm] for merging this to {{branch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768992#comment-15768992
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thank you [~fpj] for the help in resolving
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768490#comment-15768490
]
Hudson commented on ZOOKEEPER-2383:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768373#comment-15768373
]
Flavio Junqueira commented on ZOOKEEPER-2383:
-
[~rakesh_r] pull request #1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15768361#comment-15768361
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user asfgit closed the p
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754824#comment-15754824
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user rakeshadr commented
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754797#comment-15754797
]
Hadoop QA commented on ZOOKEEPER-2383:
--
+1 overall. GitHub Pull Request Build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754181#comment-15754181
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user fpj commented on th
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754062#comment-15754062
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. GitHub Pull Request Build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754060#comment-15754060
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. GitHub Pull Request Build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754024#comment-15754024
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user rakeshadr commented
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15752671#comment-15752671
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user fpj commented on a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15724255#comment-15724255
]
Rakesh R commented on ZOOKEEPER-2383:
-
Hi [~fpj], would be great to see your feedb
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15643583#comment-15643583
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. GitHub Pull Request Build
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15642088#comment-15642088
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15642086#comment-15642086
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15642047#comment-15642047
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
GitHub user rakeshadr opened a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636680#comment-15636680
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~fpj]. OK, I'll modify the test cas
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636584#comment-15636584
]
Flavio Junqueira commented on ZOOKEEPER-2383:
-
Moving the {{start()}} call
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636358#comment-15636358
]
Rakesh R commented on ZOOKEEPER-2383:
-
Will this proposed fix induce any other com
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15528370#comment-15528370
]
Rakesh R commented on ZOOKEEPER-2383:
-
[~fpj], any thoughts about the above points
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15507169#comment-15507169
]
Rakesh R commented on ZOOKEEPER-2383:
-
bq. The test case isn't covering the whole
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502832#comment-15502832
]
Flavio Junqueira commented on ZOOKEEPER-2383:
-
Actually, what prevents us
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502833#comment-15502833
]
Flavio Junqueira commented on ZOOKEEPER-2383:
-
Actually, what prevents us
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502828#comment-15502828
]
Flavio Junqueira commented on ZOOKEEPER-2383:
-
[~rakesh_r] the try/finally
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15499350#comment-15499350
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~fpj] for the comments.
bq. In Ne
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15499075#comment-15499075
]
Flavio Junqueira commented on ZOOKEEPER-2383:
-
[~rakesh_r] I have checked
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15470882#comment-15470882
]
Rakesh R commented on ZOOKEEPER-2383:
-
I've got +1(non-binding) from [~steve_rowe]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15422902#comment-15422902
]
Rakesh R commented on ZOOKEEPER-2383:
-
I am moving this out to 3.4.10 for now. Ple
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420205#comment-15420205
]
Patrick Hunt commented on ZOOKEEPER-2383:
-
[~rgs] possible for you take anothe
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410820#comment-15410820
]
Rakesh R commented on ZOOKEEPER-2383:
-
[~rgs], would you take another look at the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410424#comment-15410424
]
Hadoop QA commented on ZOOKEEPER-2383:
--
+1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409917#comment-15409917
]
Michael Han commented on ZOOKEEPER-2383:
Thanks Rakesh for quick reply - looks
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409886#comment-15409886
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409673#comment-15409673
]
Michael Han commented on ZOOKEEPER-2383:
One small suggestion - the condition
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409640#comment-15409640
]
Michael Han commented on ZOOKEEPER-2383:
ZOOKEEPER-2383-br-3-4.patch may also
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409316#comment-15409316
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408930#comment-15408930
]
Hadoop QA commented on ZOOKEEPER-2383:
--
+1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408906#comment-15408906
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~rgs]. Attached new patch addressin
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408826#comment-15408826
]
Raul Gutierrez Segales commented on ZOOKEEPER-2383:
---
[~rakeshr]: loo
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408810#comment-15408810
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks a lot [~steve_rowe] for the feedback
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408727#comment-15408727
]
Steve Rowe commented on ZOOKEEPER-2383:
---
[~rakeshr], I patched branch-3.4 at rev
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399789#comment-15399789
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399783#comment-15399783
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~steve_rowe]. I'm attaching another
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399680#comment-15399680
]
Steve Rowe commented on ZOOKEEPER-2383:
---
[~rakeshr], looks like your patch is ag
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399613#comment-15399613
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thank you [~suda] for the feedback.
> Star
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399042#comment-15399042
]
Akihiro Suda commented on ZOOKEEPER-2383:
-
+1 (non-binding).
Locally tested Z
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396992#comment-15396992
]
Hadoop QA commented on ZOOKEEPER-2383:
--
+1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392021#comment-15392021
]
Rakesh R commented on ZOOKEEPER-2383:
-
fyi: The patch got a green
[build_3284|htt
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391877#comment-15391877
]
Rakesh R commented on ZOOKEEPER-2383:
-
Attached initial patch where I've used {{zk
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391428#comment-15391428
]
Rakesh R commented on ZOOKEEPER-2383:
-
[~ozawa], thanks for the interest. I was bu
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15391420#comment-15391420
]
Tsuyoshi Ozawa commented on ZOOKEEPER-2383:
---
[~rakeshr] hi Rakesh, how is th
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206310#comment-15206310
]
Jason Rosenberg commented on ZOOKEEPER-2383:
Yes, agreed, you wouldn't use
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206169#comment-15206169
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~jbrosenb...@gmail.com]. Disbaling
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15198781#comment-15198781
]
Jason Rosenberg commented on ZOOKEEPER-2383:
I've run into similar issues,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15189157#comment-15189157
]
Rakesh R commented on ZOOKEEPER-2383:
-
I think I found the code changes which resu
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15186556#comment-15186556
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~steve_rowe] for reporting this iss
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185740#comment-15185740
]
Steve Rowe commented on ZOOKEEPER-2383:
---
Similarly to the subclassed ZooKeeperSe
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185412#comment-15185412
]
Steve Rowe commented on ZOOKEEPER-2383:
---
FWIW, I was able to work around the pro
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185323#comment-15185323
]
Flavio Junqueira commented on ZOOKEEPER-2383:
-
[~steve_rowe] Thanks for re
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185285#comment-15185285
]
Steve Rowe commented on ZOOKEEPER-2383:
---
This program triggers the problem for m
69 matches
Mail list logo