[jira] [Commented] (ZOOKEEPER-2593) Enforce the quota limit
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513486#comment-15513486
]
Edward Ribeiro commented on ZOOKEEPER-2593:
---
{quote}
1. enforce the quota limit at more granular level. can we add
enforce.number.quota and enforce.byte.quota ?
I think there is need to change the implementation as well.
{quote}
Agree.
{quote}
we should check the limit at centralized place like in {{
PrepRequestProcessor}}. If we check the limit in DataTree which is at every
server then the exceptions can not be passed to clients.
{quote}
Agree.
> Enforce the quota limit
> ---
>
> Key: ZOOKEEPER-2593
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2593
> Project: ZooKeeper
> Issue Type: New Feature
> Components: java client, server
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>
> Currently in ZooKeeper when quota limit exceeds, a warning is logged. There
> are many user scenarios where it is desired to throw exception in case quota
> limits exceed.
> We should make it configurable whether to throw exception or just log the
> warning when quota limits exceed.
> *Implementation:*
> add new properties
> {code}
> enforce.number.quota
> enforce.byte.quota
> {code}
> add new error codes
> {code}
> KeeperException.Code.NUMBERQUOTAEXCEED
> KeeperException.Code.BYTEQUOTAEXCEED
> {code}
> add new exception
> {code}
> KeeperException.NumberQuotaExceedException
> KeeperException.ByteQuotaExceedException
> {code}
>
> *Basic Scenarios:*
> # If enforce.number.quota=true and number quota exceed, then server should
> send NUMBERQUOTAEXCEED error code and client should throw
> NumberQuotaExceedException
> # If enforce.byte.quota=true and byte quota exceed, then server should send
> BYTEQUOTAEXCEED error code and client should throw ByteQuotaExceedException
> *Impacted APIs:*
> create
> setData
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2593) Enforce the quota limit
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513419#comment-15513419
]
Arshad Mohammad commented on ZOOKEEPER-2593:
Thanks [~eribeiro]
yes, this is same as ZOOKEEPER-451. But in that JIRA we needs few improvement
# enforce the quota limit at more granular level. can we add
enforce.number.quota and enforce.byte.quota ?
# I think there is need to change the implementation as well.
we should check the limit at centralized place like in {{
PrepRequestProcessor}}.
If we check the limit in DataTree which is at every server then the exceptions
can not be passed to clients.
> Enforce the quota limit
> ---
>
> Key: ZOOKEEPER-2593
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2593
> Project: ZooKeeper
> Issue Type: New Feature
> Components: java client, server
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>
> Currently in ZooKeeper when quota limit exceeds, a warning is logged. There
> are many user scenarios where it is desired to throw exception in case quota
> limits exceed.
> We should make it configurable whether to throw exception or just log the
> warning when quota limits exceed.
> *Implementation:*
> add new properties
> {code}
> enforce.number.quota
> enforce.byte.quota
> {code}
> add new error codes
> {code}
> KeeperException.Code.NUMBERQUOTAEXCEED
> KeeperException.Code.BYTEQUOTAEXCEED
> {code}
> add new exception
> {code}
> KeeperException.NumberQuotaExceedException
> KeeperException.ByteQuotaExceedException
> {code}
>
> *Basic Scenarios:*
> # If enforce.number.quota=true and number quota exceed, then server should
> send NUMBERQUOTAEXCEED error code and client should throw
> NumberQuotaExceedException
> # If enforce.byte.quota=true and byte quota exceed, then server should send
> BYTEQUOTAEXCEED error code and client should throw ByteQuotaExceedException
> *Impacted APIs:*
> create
> setData
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ZOOKEEPER-2593) Enforce the quota limit
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15503986#comment-15503986
]
Edward Ribeiro commented on ZOOKEEPER-2593:
---
Hey [~arshad.mohammad], this is a duplicate of ZOOKEEPER-451
> Enforce the quota limit
> ---
>
> Key: ZOOKEEPER-2593
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2593
> Project: ZooKeeper
> Issue Type: New Feature
> Components: java client, server
>Reporter: Arshad Mohammad
>Assignee: Arshad Mohammad
>
> Currently in ZooKeeper when quota limit exceeds, a warning is logged. There
> are many user scenarios where it is desired to throw exception in case quota
> limits exceed.
> We should make it configurable whether to throw exception or just log the
> warning when quota limits exceed.
> *Implementation:*
> add new properties
> {code}
> enforce.number.quota
> enforce.byte.quota
> {code}
> add new error codes
> {code}
> KeeperException.Code.NUMBERQUOTAEXCEED
> KeeperException.Code.BYTEQUOTAEXCEED
> {code}
> add new exception
> {code}
> KeeperException.NumberQuotaExceedException
> KeeperException.ByteQuotaExceedException
> {code}
>
> *Basic Scenarios:*
> # If enforce.number.quota=true and number quota exceed, then server should
> send NUMBERQUOTAEXCEED error code and client should throw
> NumberQuotaExceedException
> # If enforce.byte.quota=true and byte quota exceed, then server should send
> BYTEQUOTAEXCEED error code and client should throw ByteQuotaExceedException
> *Impacted APIs:*
> create
> setData
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
