[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855253#comment-15855253 ] Hudson commented on ZOOKEEPER-2682: --- FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3266 (See [https://builds.apache.org/job/ZooKeeper-trunk/3266/]) ZOOKEEPER-2682: Make it optional to fail build on test failure (rakeshr: rev ee5615d31ff4da2b2111f5a3b5d5b650f60bf936) * (edit) build.xml > Make it optional to fail build on test failure > -- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch, ZOOKEEPER-2682-02.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855189#comment-15855189 ] ASF GitHub Bot commented on ZOOKEEPER-2682: --- Github user arshadmohammad closed the pull request at: https://github.com/apache/zookeeper/pull/164 > Make it optional to fail build on test failure > -- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch, ZOOKEEPER-2682-02.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855188#comment-15855188 ] ASF GitHub Bot commented on ZOOKEEPER-2682: --- Github user arshadmohammad commented on the issue: https://github.com/apache/zookeeper/pull/164 Closing this PR as it is committed to branch-3.4. Commit id is 3ea68e7a99278daf4d7424ce825c6e8315c39198 Thanks @rakeshr for commiting this PR > Make it optional to fail build on test failure > -- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch, ZOOKEEPER-2682-02.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855182#comment-15855182 ] ASF GitHub Bot commented on ZOOKEEPER-2682: --- Github user rakeshadr commented on the issue: https://github.com/apache/zookeeper/pull/164 @arshadmohammad , its merged, could you close this PR. > Make it optional to fail build on test failure. > --- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch, ZOOKEEPER-2682-02.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855159#comment-15855159 ] ASF GitHub Bot commented on ZOOKEEPER-2682: --- Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/163 > Make it optional to fail build on test failure. > --- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch, ZOOKEEPER-2682-02.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854269#comment-15854269 ] ASF GitHub Bot commented on ZOOKEEPER-2682: --- Github user rakeshadr commented on the issue: https://github.com/apache/zookeeper/pull/163 +1 LGTM > Make it optional to fail build on test failure. > --- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch, ZOOKEEPER-2682-02.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854191#comment-15854191 ] ASF GitHub Bot commented on ZOOKEEPER-2682: --- GitHub user arshadmohammad opened a pull request: https://github.com/apache/zookeeper/pull/163 ZOOKEEPER-2682:Make it optional to fail build on test failure You can merge this pull request into a Git repository by running: $ git pull https://github.com/arshadmohammad/zookeeper ZOOKEEPER-2682-master-branch-3.5 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/163.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #163 commit 2662f584bd49a68b5917237c0fe3f4eb84d52b39 Author: Mohammad ArshadDate: 2017-02-06T14:56:54Z ZOOKEEPER-2682:Make it optional to fail build on test failure > Make it optional to fail build on test failure. > --- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch, ZOOKEEPER-2682-02.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854194#comment-15854194 ] ASF GitHub Bot commented on ZOOKEEPER-2682: --- GitHub user arshadmohammad opened a pull request: https://github.com/apache/zookeeper/pull/164 ZOOKEEPER-2682: Make it optional to fail build on test failure You can merge this pull request into a Git repository by running: $ git pull https://github.com/arshadmohammad/zookeeper ZOOKEEPER-2682-branch-3.4 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/164.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #164 commit 3ea68e7a99278daf4d7424ce825c6e8315c39198 Author: Mohammad ArshadDate: 2017-02-06T15:13:21Z ZOOKEEPER-2682: Make it optional to fail build on test failure > Make it optional to fail build on test failure. > --- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch, ZOOKEEPER-2682-02.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853605#comment-15853605 ] Rakesh R commented on ZOOKEEPER-2682: - Thanks [~arshad.mohammad] for the patch. Please create a PR for the same, I'll merge it. > Make it optional to fail build on test failure. > --- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch, ZOOKEEPER-2682-02.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853571#comment-15853571 ] Mohammad Arshad commented on ZOOKEEPER-2682: I verified the patch on my local CI. I run the test cases of master branch. It works fine. This patch applies on master and branch-3.5, I will submit separate patch for branch-3.4 > Make it optional to fail build on test failure. > --- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch, ZOOKEEPER-2682-02.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853568#comment-15853568 ] Mohammad Arshad commented on ZOOKEEPER-2682: test failure are not related to this patch. > Make it optional to fail build on test failure. > --- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch, ZOOKEEPER-2682-02.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853243#comment-15853243 ] Hadoop QA commented on ZOOKEEPER-2682: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12851082/ZOOKEEPER-2682-02.patch against trunk revision 26aee2228451257f3b0b5093bc0c101822e06bc8. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3574//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3574//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3574//console This message is automatically generated. > Make it optional to fail build on test failure. > --- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch, ZOOKEEPER-2682-02.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ZOOKEEPER-2682) Make it optional to fail build on test failure.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15853219#comment-15853219 ] Hadoop QA commented on ZOOKEEPER-2682: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12851072/ZOOKEEPER-2682-01.patch against trunk revision 26aee2228451257f3b0b5093bc0c101822e06bc8. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 1 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3573//console This message is automatically generated. > Make it optional to fail build on test failure. > --- > > Key: ZOOKEEPER-2682 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2682 > Project: ZooKeeper > Issue Type: Improvement > Components: build, tests >Reporter: Mohammad Arshad >Assignee: Mohammad Arshad >Priority: Minor > Fix For: 3.4.10, 3.5.3, 3.6.0 > > Attachments: ZOOKEEPER-2682-01.patch > > > Currently if there is a test failure, build is marked as failed and exits. > I want to rerun the failed test cases instead of exiting. -- This message was sent by Atlassian JIRA (v6.3.15#6346)