[jira] [Commented] (ZOOKEEPER-2980) Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449610#comment-16449610
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2980:
---

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/462
  
@phunt This PR is the dependency of 
https://github.com/apache/zookeeper/pull/466 
Previously we dropped this, because it's a new feature which we usually 
don't add to 3.4, but these new metrics would be crucial for monitoring. I'd 
like to revisit this and merge this patch before the other if it's acceptable.


> Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2980
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2980
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.4.13
>
>
> Backport ZOOKEEPER-2939 to branch-3.4.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2980) Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449611#comment-16449611
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2980:
---

GitHub user anmolnar reopened a pull request:

https://github.com/apache/zookeeper/pull/462

ZOOKEEPER-2980 Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to 
proposals - branch-3.4

Branch 3.4 version of https://github.com/apache/zookeeper/pull/415

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/anmolnar/zookeeper ZOOKEEPER-2939_34

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zookeeper/pull/462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #462


commit 4b70395eeb3f9a5591cf7d6b9aea91a77c350cf4
Author: Andor Molnar 
Date:   2018-02-12T14:17:12Z

ZOOKEEPER-2939. Deal with maxbuffer as it relates to proposals




> Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2980
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2980
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.4.13
>
>
> Backport ZOOKEEPER-2939 to branch-3.4.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2980) Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371258#comment-16371258
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2980:
---

Github user anmolnar commented on the issue:

https://github.com/apache/zookeeper/pull/462
  
@afine That's a valid point, I close this PR.


> Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2980
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2980
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.4.12
>
>
> Backport ZOOKEEPER-2939 to branch-3.4.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2980) Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371260#comment-16371260
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2980:
---

Github user anmolnar closed the pull request at:

https://github.com/apache/zookeeper/pull/462


> Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2980
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2980
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.4.12
>
>
> Backport ZOOKEEPER-2939 to branch-3.4.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2980) Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16366319#comment-16366319
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2980:
---

Github user afine commented on the issue:

https://github.com/apache/zookeeper/pull/462
  
The patch looks good. I'm just wondering why we need this in 3.4. As I 
believe we generally try not to add features to that branch at this point that 
don't improve security or stability.


> Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2980
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2980
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.4.12
>
>
> Backport ZOOKEEPER-2939 to branch-3.4.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2980) Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364587#comment-16364587
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2980:
---

Github user mfenes commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/462#discussion_r168271141
  
--- Diff: build.xml ---
@@ -220,7 +220,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle">
 
 
 
-
+
--- End diff --

Ok


> Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2980
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2980
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.4.12
>
>
> Backport ZOOKEEPER-2939 to branch-3.4.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2980) Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364150#comment-16364150
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2980:
---

Github user anmolnar commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/462#discussion_r168192201
  
--- Diff: build.xml ---
@@ -220,7 +220,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle">
 
 
 
-
+
--- End diff --

Yes, I need this to use assertNotEquals().


> Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2980
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2980
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.4.12
>
>
> Backport ZOOKEEPER-2939 to branch-3.4.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ZOOKEEPER-2980) Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16364064#comment-16364064
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2980:
---

Github user mfenes commented on a diff in the pull request:

https://github.com/apache/zookeeper/pull/462#discussion_r168179473
  
--- Diff: build.xml ---
@@ -220,7 +220,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle">
 
 
 
-
+
--- End diff --

This version change comes from master/3.5. Do we really intend to upgrade 
to JUnit version 4.12 in this PR?


> Backport ZOOKEEPER-2939 Deal with maxbuffer as it relates to proposals
> --
>
> Key: ZOOKEEPER-2980
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2980
> Project: ZooKeeper
>  Issue Type: Sub-task
>  Components: server
>Reporter: Andor Molnar
>Assignee: Andor Molnar
>Priority: Major
> Fix For: 3.4.12
>
>
> Backport ZOOKEEPER-2939 to branch-3.4.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)