Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Patrick,

The 'dummy commit' is a Github trick. In any commit message you can write
"closes #", like "closes #84" (by my own experience you can also
write "fixes #". You can put as many of those messages as you
like in the commit message even if the commit doesn't have relation with
the PRs. Then GH will close those PRs.

Edward

On Wed, Dec 7, 2016 at 3:21 PM, Edward Ribeiro 
wrote:

>
> On Wed, Dec 7, 2016 at 2:09 PM, Patrick Hunt  wrote:
>
>> Interesting, thanks for the update Edward.
>>
>> "close via a dummy commit" - I don't think that's possible, doesn't GH
>> match up a PR to a commit based on the hash?
>>
>
> ​Afaik, yes. I didn't understand what he meant by 'dummy commit', tbqh.
> Gonna ask him now. :)
>
> Edward
>
>

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

On Wed, Dec 7, 2016 at 2:09 PM, Patrick Hunt  wrote:

> Interesting, thanks for the update Edward.
>
> "close via a dummy commit" - I don't think that's possible, doesn't GH
> match up a PR to a commit based on the hash?
>

​Afaik, yes. I didn't understand what he meant by 'dummy commit', tbqh.
Gonna ask him now. :)

Edward

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

Interesting, thanks for the update Edward.

"close via a dummy commit" - I don't think that's possible, doesn't GH
match up a PR to a commit based on the hash?

Patrick


On Tue, Dec 6, 2016 at 6:17 AM, Edward Ribeiro 
wrote:

> Oh, Patrick (and Flavio, and Ben Reed),
>
> I asked some questions to one ASF committer that has been using the
> Github-JIRA-Apache combo for a while now. According to him, committers
> *cannot* manually close 3rd party PRs. :( He said this is a combination of
> Github limitations and INFRA policies, his explanations below:
>
> Question:  1) Do committers have to contact ASF INFRA to be able to close
> PR on Github mirror? Some people created bogus PR that we would like to
> close, but they don't have this option now. Can INFRA give committers the
> auth to close those 3rd party PRs?
>
> Answer: "You either have to ask INFRA, ask the author or close via a dummy
> commit. In our project, we first ask the author and occasionally we ask
> INFRA to close a bunch of them or a particularly bad one (someone had
> created a PR for merging trunk to a stable branch, for example. That would
> cause a PR build every time something was merged to trunk).
>
> Basically, if you have write access to the PRs, you also have write access
> to the GitHub repository. And INFRA believes it's essential for the GitHub
> repo to be read only. The writes flow from the Apache git repo. The Apache
> git repo has more safeguards (although protected branches in GitHub could
> help here, not sure if the Apache INFRA team has considered them)."
>
> Question: At Kafka, all the PR goes through GH? Or do you committers
> usually apply patches directly to Apache git repo?
>
> Answer: "We now always use GitHub, we don't use patches any more"
> Edward
>
> On Mon, Dec 5, 2016 at 9:07 PM, Patrick Hunt  wrote:
>
> > No problem Edward. Did you get any insight on what to do with the PR?
> >
> > Patrick
> >
> > On Thu, Nov 24, 2016 at 10:52 AM, Edward Ribeiro <
> edward.ribe...@gmail.com
> > >
> > wrote:
> >
> > > Hi, Patrick,
> > >
> > > Thanks for merging this change. :)
> > >
> > > Sincerely, I don't know why it didn't close the PR automatically. Nor
> why
> > > you can close it in the GH mirror. In any case, I manually closed it.
> > >
> > > I will ping folks from other Apache projects using similar tool to
> > inquire
> > > why it didn't close the PR and why it gave this 'write access' error
> > > message.
> > >
> > > Edward
> > >
> > >
> > >
> > > On Fri, Nov 18, 2016 at 8:13 PM, Patrick Hunt 
> wrote:
> > >
> > >> Thanks Edward, this should be very helpful for folks. I committed,
> > >> however I notice the PR is still open. I followed the steps here:
> > >> https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> > Committing+changes
> > >> however I don't see a way to close the PR? https://github.com/apache/
> > >> zookeeper/pull/103 says I don't have "write access".
> > >>
> > >> Patrick
> > >>
> > >> On Thu, Nov 10, 2016 at 10:23 AM, Edward Ribeiro <
> > >> edward.ribe...@gmail.com> wrote:
> > >>
> > >>> Hi Patrick,
> > >>>
> > >>> I've just opened a PR  https://github.com/apache/zookeeper/pull/103/
> > PR
> > >>>
> > >>> It asks for JIRA_PASSWORD at CLI prompt *IF* it's absent but
> > >>> JIRA_USERNAME
> > >>> is already set. Please, when you have time, see if it fits what you
> > need
> > >>> and then I can open a JIRA, rename the feature branch, etc.
> > >>>
> > >>> Let me know if you have other ideas. I am open to other ways of
> > >>> incorporating the passing of JIRA_PASSWORD too.
> > >>>
> > >>> Edward
> > >>>
> > >>> On Wed, Nov 9, 2016 at 5:03 PM, Edward Ribeiro <
> > edward.ribe...@gmail.com
> > >>> >
> > >>> wrote:
> > >>>
> > >>> > Hi Patrick,
> > >>> >
> > >>> > We can change the script so that it asks for jira password input on
> > CLI
> > >>> > prompt if the JIRA username is set, for example. The change should
> be
> > >>> > straigthforward.
> > >>> >
> > >>> > Alternatively, the python systems I have dealt with put credentials
> > for
> > >>> > database access, etc, in configuration -- sometimes hidden -- files
> > >>> (say,
> > >>> > .env), but yet it is clear text stored.
> > >>> >
> > >>> > Anyone has other suggestions?
> > >>> >
> > >>> > Eddie
> > >>> >
> > >>> > Em 9 de nov de 2016 4:18 PM, "Patrick Hunt" 
> > >>> escreveu:
> > >>> >
> > >>> >> Is there any alternative to step 4 as documented here?
> > >>> >> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Mergin
> > >>> >> g+Github+Pull+Requests
> > >>> >>
> > >>> >> specifically it's asking to "export JIRA_PASSWORD=mypassword"
> which
> > I
> > >>> feel
> > >>> >> very uncomfortable doing.
> > >>> >>
> > >>> >> Patrick
> > >>> >>
> > >>> >> On Wed, Oct 26, 2016 at 11:12 AM, Edward Ribeiro <
> > >>> >> edward.ribe...@gmail.com>
> > >>> >> wrote:
> > >>> >>
> > >>> >> > AFAIK, yes. I say, if you mean to run unit tests and other CI
> > tasks
> > >>> on
> > 

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Oh, Patrick (and Flavio, and Ben Reed),

I asked some questions to one ASF committer that has been using the
Github-JIRA-Apache combo for a while now. According to him, committers
*cannot* manually close 3rd party PRs. :( He said this is a combination of
Github limitations and INFRA policies, his explanations below:

Question:  1) Do committers have to contact ASF INFRA to be able to close
PR on Github mirror? Some people created bogus PR that we would like to
close, but they don't have this option now. Can INFRA give committers the
auth to close those 3rd party PRs?

Answer: "You either have to ask INFRA, ask the author or close via a dummy
commit. In our project, we first ask the author and occasionally we ask
INFRA to close a bunch of them or a particularly bad one (someone had
created a PR for merging trunk to a stable branch, for example. That would
cause a PR build every time something was merged to trunk).

Basically, if you have write access to the PRs, you also have write access
to the GitHub repository. And INFRA believes it's essential for the GitHub
repo to be read only. The writes flow from the Apache git repo. The Apache
git repo has more safeguards (although protected branches in GitHub could
help here, not sure if the Apache INFRA team has considered them)."

Question: At Kafka, all the PR goes through GH? Or do you committers
usually apply patches directly to Apache git repo?

Answer: "We now always use GitHub, we don't use patches any more"
Edward

On Mon, Dec 5, 2016 at 9:07 PM, Patrick Hunt  wrote:

> No problem Edward. Did you get any insight on what to do with the PR?
>
> Patrick
>
> On Thu, Nov 24, 2016 at 10:52 AM, Edward Ribeiro  >
> wrote:
>
> > Hi, Patrick,
> >
> > Thanks for merging this change. :)
> >
> > Sincerely, I don't know why it didn't close the PR automatically. Nor why
> > you can close it in the GH mirror. In any case, I manually closed it.
> >
> > I will ping folks from other Apache projects using similar tool to
> inquire
> > why it didn't close the PR and why it gave this 'write access' error
> > message.
> >
> > Edward
> >
> >
> >
> > On Fri, Nov 18, 2016 at 8:13 PM, Patrick Hunt  wrote:
> >
> >> Thanks Edward, this should be very helpful for folks. I committed,
> >> however I notice the PR is still open. I followed the steps here:
> >> https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> Committing+changes
> >> however I don't see a way to close the PR? https://github.com/apache/
> >> zookeeper/pull/103 says I don't have "write access".
> >>
> >> Patrick
> >>
> >> On Thu, Nov 10, 2016 at 10:23 AM, Edward Ribeiro <
> >> edward.ribe...@gmail.com> wrote:
> >>
> >>> Hi Patrick,
> >>>
> >>> I've just opened a PR  https://github.com/apache/zookeeper/pull/103/
> PR
> >>>
> >>> It asks for JIRA_PASSWORD at CLI prompt *IF* it's absent but
> >>> JIRA_USERNAME
> >>> is already set. Please, when you have time, see if it fits what you
> need
> >>> and then I can open a JIRA, rename the feature branch, etc.
> >>>
> >>> Let me know if you have other ideas. I am open to other ways of
> >>> incorporating the passing of JIRA_PASSWORD too.
> >>>
> >>> Edward
> >>>
> >>> On Wed, Nov 9, 2016 at 5:03 PM, Edward Ribeiro <
> edward.ribe...@gmail.com
> >>> >
> >>> wrote:
> >>>
> >>> > Hi Patrick,
> >>> >
> >>> > We can change the script so that it asks for jira password input on
> CLI
> >>> > prompt if the JIRA username is set, for example. The change should be
> >>> > straigthforward.
> >>> >
> >>> > Alternatively, the python systems I have dealt with put credentials
> for
> >>> > database access, etc, in configuration -- sometimes hidden -- files
> >>> (say,
> >>> > .env), but yet it is clear text stored.
> >>> >
> >>> > Anyone has other suggestions?
> >>> >
> >>> > Eddie
> >>> >
> >>> > Em 9 de nov de 2016 4:18 PM, "Patrick Hunt" 
> >>> escreveu:
> >>> >
> >>> >> Is there any alternative to step 4 as documented here?
> >>> >> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Mergin
> >>> >> g+Github+Pull+Requests
> >>> >>
> >>> >> specifically it's asking to "export JIRA_PASSWORD=mypassword" which
> I
> >>> feel
> >>> >> very uncomfortable doing.
> >>> >>
> >>> >> Patrick
> >>> >>
> >>> >> On Wed, Oct 26, 2016 at 11:12 AM, Edward Ribeiro <
> >>> >> edward.ribe...@gmail.com>
> >>> >> wrote:
> >>> >>
> >>> >> > AFAIK, yes. I say, if you mean to run unit tests and other CI
> tasks
> >>> on
> >>> >> PR.
> >>> >> >
> >>> >> > PS: I have just created a simple script HowTo at
> >>> >> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> >>> >> > Merging+Github+Pull+Requests
> >>> >> > and linked from https://cwiki.apache.org/confl
> >>> uence/display/ZOOKEEPER/
> >>> >> > Index
> >>> >> >
> >>> >> > On Wed, Oct 26, 2016 at 3:59 PM, Flavio Junqueira  >
> >>> >> wrote:
> >>> >> >
> >>> >> > > What about QA, are we still missing a github pre-commit queue?
> >>> >> > >
> >>> >> > > 

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

No problem Edward. Did you get any insight on what to do with the PR?

Patrick

On Thu, Nov 24, 2016 at 10:52 AM, Edward Ribeiro 
wrote:

> Hi, Patrick,
>
> Thanks for merging this change. :)
>
> Sincerely, I don't know why it didn't close the PR automatically. Nor why
> you can close it in the GH mirror. In any case, I manually closed it.
>
> I will ping folks from other Apache projects using similar tool to inquire
> why it didn't close the PR and why it gave this 'write access' error
> message.
>
> Edward
>
>
>
> On Fri, Nov 18, 2016 at 8:13 PM, Patrick Hunt  wrote:
>
>> Thanks Edward, this should be very helpful for folks. I committed,
>> however I notice the PR is still open. I followed the steps here:
>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes
>> however I don't see a way to close the PR? https://github.com/apache/
>> zookeeper/pull/103 says I don't have "write access".
>>
>> Patrick
>>
>> On Thu, Nov 10, 2016 at 10:23 AM, Edward Ribeiro <
>> edward.ribe...@gmail.com> wrote:
>>
>>> Hi Patrick,
>>>
>>> I've just opened a PR  https://github.com/apache/zookeeper/pull/103/ PR
>>>
>>> It asks for JIRA_PASSWORD at CLI prompt *IF* it's absent but
>>> JIRA_USERNAME
>>> is already set. Please, when you have time, see if it fits what you need
>>> and then I can open a JIRA, rename the feature branch, etc.
>>>
>>> Let me know if you have other ideas. I am open to other ways of
>>> incorporating the passing of JIRA_PASSWORD too.
>>>
>>> Edward
>>>
>>> On Wed, Nov 9, 2016 at 5:03 PM, Edward Ribeiro >> >
>>> wrote:
>>>
>>> > Hi Patrick,
>>> >
>>> > We can change the script so that it asks for jira password input on CLI
>>> > prompt if the JIRA username is set, for example. The change should be
>>> > straigthforward.
>>> >
>>> > Alternatively, the python systems I have dealt with put credentials for
>>> > database access, etc, in configuration -- sometimes hidden -- files
>>> (say,
>>> > .env), but yet it is clear text stored.
>>> >
>>> > Anyone has other suggestions?
>>> >
>>> > Eddie
>>> >
>>> > Em 9 de nov de 2016 4:18 PM, "Patrick Hunt" 
>>> escreveu:
>>> >
>>> >> Is there any alternative to step 4 as documented here?
>>> >> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Mergin
>>> >> g+Github+Pull+Requests
>>> >>
>>> >> specifically it's asking to "export JIRA_PASSWORD=mypassword" which I
>>> feel
>>> >> very uncomfortable doing.
>>> >>
>>> >> Patrick
>>> >>
>>> >> On Wed, Oct 26, 2016 at 11:12 AM, Edward Ribeiro <
>>> >> edward.ribe...@gmail.com>
>>> >> wrote:
>>> >>
>>> >> > AFAIK, yes. I say, if you mean to run unit tests and other CI tasks
>>> on
>>> >> PR.
>>> >> >
>>> >> > PS: I have just created a simple script HowTo at
>>> >> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/
>>> >> > Merging+Github+Pull+Requests
>>> >> > and linked from https://cwiki.apache.org/confl
>>> uence/display/ZOOKEEPER/
>>> >> > Index
>>> >> >
>>> >> > On Wed, Oct 26, 2016 at 3:59 PM, Flavio Junqueira 
>>> >> wrote:
>>> >> >
>>> >> > > What about QA, are we still missing a github pre-commit queue?
>>> >> > >
>>> >> > > -Flavio
>>> >> > >
>>> >> > > > On 26 Oct 2016, at 18:53, Michael Han 
>>> wrote:
>>> >> > > >
>>> >> > > > The comment bridging should be fixed now - see INFRA-12752 for
>>> more
>>> >> > > > details.
>>> >> > > >
>>> >> > > > On Wed, Oct 26, 2016 at 10:03 AM, Michael Han <
>>> h...@cloudera.com>
>>> >> > wrote:
>>> >> > > >
>>> >> > >  The git PR *review* comments for ZOOKEEPER-2597 didn't show
>>> up on
>>> >> > > JIRA.
>>> >> > > >>
>>> >> > > >> The bridge was working the day Infra made the change - see the
>>> >> > previous
>>> >> > > >> comments made by git bot on ZOOKEEPER-761. Now it seems stop
>>> >> working.
>>> >> > I
>>> >> > > am
>>> >> > > >> reopening INFRA-12752 and building a case.
>>> >> > > >>
>>> >> > > >> On Wed, Oct 26, 2016 at 9:45 AM, Edward Ribeiro <
>>> >> > > edward.ribe...@gmail.com>
>>> >> > > >> wrote:
>>> >> > > >>
>>> >> > > >>> Dear community,
>>> >> > > >>>
>>> >> > > >>> The zk-merger-pr.py script has been merged into master
>>> (thanks a
>>> >> LOT
>>> >> > > Ben
>>> >> > > >>> Reed for reviewing/discussing/testing and commiting):
>>> >> > > >>> https://issues.apache.org/jira/browse/ZOOKEEPER-2597
>>> >> > > >>>
>>> >> > > >>> As stated in the issue and on GH, this tool is a modified
>>> version
>>> >> of
>>> >> > > >>> similar tools from Kafka, that is a copy of a Spark's one. It
>>> has
>>> >> > some
>>> >> > > >>> rough edges so we will certainly benefit from further
>>> enhancements
>>> >> > and
>>> >> > > >>> fixes. I changed the smallest possible pieces of code, just to
>>> >> make
>>> >> > it
>>> >> > > >>> work
>>> >> > > >>> on a ZK repo so the credits go to the original authors.
>>> >> > > >>>
>>> >> > > >>> Some notes:
>>> >> > > >>>
>>> >> > > >>> 1. The git PR *review* comments for 

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Hi, Patrick,

Thanks for merging this change. :)

Sincerely, I don't know why it didn't close the PR automatically. Nor why
you can close it in the GH mirror. In any case, I manually closed it.

I will ping folks from other Apache projects using similar tool to inquire
why it didn't close the PR and why it gave this 'write access' error
message.

Edward



On Fri, Nov 18, 2016 at 8:13 PM, Patrick Hunt  wrote:

> Thanks Edward, this should be very helpful for folks. I committed, however
> I notice the PR is still open. I followed the steps here:
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes
> however I don't see a way to close the PR? https://github.com/apache/
> zookeeper/pull/103 says I don't have "write access".
>
> Patrick
>
> On Thu, Nov 10, 2016 at 10:23 AM, Edward Ribeiro  > wrote:
>
>> Hi Patrick,
>>
>> I've just opened a PR  https://github.com/apache/zookeeper/pull/103/ PR
>>
>> It asks for JIRA_PASSWORD at CLI prompt *IF* it's absent but JIRA_USERNAME
>> is already set. Please, when you have time, see if it fits what you need
>> and then I can open a JIRA, rename the feature branch, etc.
>>
>> Let me know if you have other ideas. I am open to other ways of
>> incorporating the passing of JIRA_PASSWORD too.
>>
>> Edward
>>
>> On Wed, Nov 9, 2016 at 5:03 PM, Edward Ribeiro 
>> wrote:
>>
>> > Hi Patrick,
>> >
>> > We can change the script so that it asks for jira password input on CLI
>> > prompt if the JIRA username is set, for example. The change should be
>> > straigthforward.
>> >
>> > Alternatively, the python systems I have dealt with put credentials for
>> > database access, etc, in configuration -- sometimes hidden -- files
>> (say,
>> > .env), but yet it is clear text stored.
>> >
>> > Anyone has other suggestions?
>> >
>> > Eddie
>> >
>> > Em 9 de nov de 2016 4:18 PM, "Patrick Hunt" 
>> escreveu:
>> >
>> >> Is there any alternative to step 4 as documented here?
>> >> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Mergin
>> >> g+Github+Pull+Requests
>> >>
>> >> specifically it's asking to "export JIRA_PASSWORD=mypassword" which I
>> feel
>> >> very uncomfortable doing.
>> >>
>> >> Patrick
>> >>
>> >> On Wed, Oct 26, 2016 at 11:12 AM, Edward Ribeiro <
>> >> edward.ribe...@gmail.com>
>> >> wrote:
>> >>
>> >> > AFAIK, yes. I say, if you mean to run unit tests and other CI tasks
>> on
>> >> PR.
>> >> >
>> >> > PS: I have just created a simple script HowTo at
>> >> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/
>> >> > Merging+Github+Pull+Requests
>> >> > and linked from https://cwiki.apache.org/confl
>> uence/display/ZOOKEEPER/
>> >> > Index
>> >> >
>> >> > On Wed, Oct 26, 2016 at 3:59 PM, Flavio Junqueira 
>> >> wrote:
>> >> >
>> >> > > What about QA, are we still missing a github pre-commit queue?
>> >> > >
>> >> > > -Flavio
>> >> > >
>> >> > > > On 26 Oct 2016, at 18:53, Michael Han  wrote:
>> >> > > >
>> >> > > > The comment bridging should be fixed now - see INFRA-12752 for
>> more
>> >> > > > details.
>> >> > > >
>> >> > > > On Wed, Oct 26, 2016 at 10:03 AM, Michael Han > >
>> >> > wrote:
>> >> > > >
>> >> > >  The git PR *review* comments for ZOOKEEPER-2597 didn't show
>> up on
>> >> > > JIRA.
>> >> > > >>
>> >> > > >> The bridge was working the day Infra made the change - see the
>> >> > previous
>> >> > > >> comments made by git bot on ZOOKEEPER-761. Now it seems stop
>> >> working.
>> >> > I
>> >> > > am
>> >> > > >> reopening INFRA-12752 and building a case.
>> >> > > >>
>> >> > > >> On Wed, Oct 26, 2016 at 9:45 AM, Edward Ribeiro <
>> >> > > edward.ribe...@gmail.com>
>> >> > > >> wrote:
>> >> > > >>
>> >> > > >>> Dear community,
>> >> > > >>>
>> >> > > >>> The zk-merger-pr.py script has been merged into master (thanks
>> a
>> >> LOT
>> >> > > Ben
>> >> > > >>> Reed for reviewing/discussing/testing and commiting):
>> >> > > >>> https://issues.apache.org/jira/browse/ZOOKEEPER-2597
>> >> > > >>>
>> >> > > >>> As stated in the issue and on GH, this tool is a modified
>> version
>> >> of
>> >> > > >>> similar tools from Kafka, that is a copy of a Spark's one. It
>> has
>> >> > some
>> >> > > >>> rough edges so we will certainly benefit from further
>> enhancements
>> >> > and
>> >> > > >>> fixes. I changed the smallest possible pieces of code, just to
>> >> make
>> >> > it
>> >> > > >>> work
>> >> > > >>> on a ZK repo so the credits go to the original authors.
>> >> > > >>>
>> >> > > >>> Some notes:
>> >> > > >>>
>> >> > > >>> 1. The git PR *review* comments for ZOOKEEPER-2597 didn't show
>> up
>> >> on
>> >> > > JIRA.
>> >> > > >>> Only the opening and closing of the issue. Can we double check
>> >> this
>> >> > as
>> >> > > >>> INFRA-12752 is closed, Michael Han?
>> >> > > >>>
>> >> > > >>> 2. I scribbled a draft on how use the tool at
>> >> > > >>> 

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

Thanks Edward, this should be very helpful for folks. I committed, however
I notice the PR is still open. I followed the steps here:
https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes
however I don't see a way to close the PR?
https://github.com/apache/zookeeper/pull/103 says I don't have "write
access".

Patrick

On Thu, Nov 10, 2016 at 10:23 AM, Edward Ribeiro 
wrote:

> Hi Patrick,
>
> I've just opened a PR  https://github.com/apache/zookeeper/pull/103/ PR
>
> It asks for JIRA_PASSWORD at CLI prompt *IF* it's absent but JIRA_USERNAME
> is already set. Please, when you have time, see if it fits what you need
> and then I can open a JIRA, rename the feature branch, etc.
>
> Let me know if you have other ideas. I am open to other ways of
> incorporating the passing of JIRA_PASSWORD too.
>
> Edward
>
> On Wed, Nov 9, 2016 at 5:03 PM, Edward Ribeiro 
> wrote:
>
> > Hi Patrick,
> >
> > We can change the script so that it asks for jira password input on CLI
> > prompt if the JIRA username is set, for example. The change should be
> > straigthforward.
> >
> > Alternatively, the python systems I have dealt with put credentials for
> > database access, etc, in configuration -- sometimes hidden -- files (say,
> > .env), but yet it is clear text stored.
> >
> > Anyone has other suggestions?
> >
> > Eddie
> >
> > Em 9 de nov de 2016 4:18 PM, "Patrick Hunt"  escreveu:
> >
> >> Is there any alternative to step 4 as documented here?
> >> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Mergin
> >> g+Github+Pull+Requests
> >>
> >> specifically it's asking to "export JIRA_PASSWORD=mypassword" which I
> feel
> >> very uncomfortable doing.
> >>
> >> Patrick
> >>
> >> On Wed, Oct 26, 2016 at 11:12 AM, Edward Ribeiro <
> >> edward.ribe...@gmail.com>
> >> wrote:
> >>
> >> > AFAIK, yes. I say, if you mean to run unit tests and other CI tasks on
> >> PR.
> >> >
> >> > PS: I have just created a simple script HowTo at
> >> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> >> > Merging+Github+Pull+Requests
> >> > and linked from https://cwiki.apache.org/
> confluence/display/ZOOKEEPER/
> >> > Index
> >> >
> >> > On Wed, Oct 26, 2016 at 3:59 PM, Flavio Junqueira 
> >> wrote:
> >> >
> >> > > What about QA, are we still missing a github pre-commit queue?
> >> > >
> >> > > -Flavio
> >> > >
> >> > > > On 26 Oct 2016, at 18:53, Michael Han  wrote:
> >> > > >
> >> > > > The comment bridging should be fixed now - see INFRA-12752 for
> more
> >> > > > details.
> >> > > >
> >> > > > On Wed, Oct 26, 2016 at 10:03 AM, Michael Han 
> >> > wrote:
> >> > > >
> >> > >  The git PR *review* comments for ZOOKEEPER-2597 didn't show up
> on
> >> > > JIRA.
> >> > > >>
> >> > > >> The bridge was working the day Infra made the change - see the
> >> > previous
> >> > > >> comments made by git bot on ZOOKEEPER-761. Now it seems stop
> >> working.
> >> > I
> >> > > am
> >> > > >> reopening INFRA-12752 and building a case.
> >> > > >>
> >> > > >> On Wed, Oct 26, 2016 at 9:45 AM, Edward Ribeiro <
> >> > > edward.ribe...@gmail.com>
> >> > > >> wrote:
> >> > > >>
> >> > > >>> Dear community,
> >> > > >>>
> >> > > >>> The zk-merger-pr.py script has been merged into master (thanks a
> >> LOT
> >> > > Ben
> >> > > >>> Reed for reviewing/discussing/testing and commiting):
> >> > > >>> https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> >> > > >>>
> >> > > >>> As stated in the issue and on GH, this tool is a modified
> version
> >> of
> >> > > >>> similar tools from Kafka, that is a copy of a Spark's one. It
> has
> >> > some
> >> > > >>> rough edges so we will certainly benefit from further
> enhancements
> >> > and
> >> > > >>> fixes. I changed the smallest possible pieces of code, just to
> >> make
> >> > it
> >> > > >>> work
> >> > > >>> on a ZK repo so the credits go to the original authors.
> >> > > >>>
> >> > > >>> Some notes:
> >> > > >>>
> >> > > >>> 1. The git PR *review* comments for ZOOKEEPER-2597 didn't show
> up
> >> on
> >> > > JIRA.
> >> > > >>> Only the opening and closing of the issue. Can we double check
> >> this
> >> > as
> >> > > >>> INFRA-12752 is closed, Michael Han?
> >> > > >>>
> >> > > >>> 2. I scribbled a draft on how use the tool at
> >> > > >>> https://docs.google.com/document/d/1i00ZXjrW2fu17vr_h7F1bUrq
> >> > > >>> Xg3urw4Hm7KirQDpPIU/edit
> >> > > >>> (still very crude, but feel free to improve it). I would like to
> >> move
> >> > > >>> this
> >> > > >>> text to https://cwiki.apache.org/confl
> >> uence/display/ZOOKEEPER/Index
> >> > > but
> >> > > >>> looks like I don't have permission to create a page there yet.
> Any
> >> > > help?
> >> > > >>>
> >> > > >>> Best regards,
> >> > > >>> Eddie
> >> > > >>>
> >> > > >>> On Sat, Oct 22, 2016 at 7:08 PM, Michael Han  >
> >> > > wrote:
> >> > > >>>
> >> > >  FYI infra did some work in INFRA-12752 

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Hi Patrick,

I've just opened a PR  https://github.com/apache/zookeeper/pull/103/ PR

It asks for JIRA_PASSWORD at CLI prompt *IF* it's absent but JIRA_USERNAME
is already set. Please, when you have time, see if it fits what you need
and then I can open a JIRA, rename the feature branch, etc.

Let me know if you have other ideas. I am open to other ways of
incorporating the passing of JIRA_PASSWORD too.

Edward

On Wed, Nov 9, 2016 at 5:03 PM, Edward Ribeiro 
wrote:

> Hi Patrick,
>
> We can change the script so that it asks for jira password input on CLI
> prompt if the JIRA username is set, for example. The change should be
> straigthforward.
>
> Alternatively, the python systems I have dealt with put credentials for
> database access, etc, in configuration -- sometimes hidden -- files (say,
> .env), but yet it is clear text stored.
>
> Anyone has other suggestions?
>
> Eddie
>
> Em 9 de nov de 2016 4:18 PM, "Patrick Hunt"  escreveu:
>
>> Is there any alternative to step 4 as documented here?
>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Mergin
>> g+Github+Pull+Requests
>>
>> specifically it's asking to "export JIRA_PASSWORD=mypassword" which I feel
>> very uncomfortable doing.
>>
>> Patrick
>>
>> On Wed, Oct 26, 2016 at 11:12 AM, Edward Ribeiro <
>> edward.ribe...@gmail.com>
>> wrote:
>>
>> > AFAIK, yes. I say, if you mean to run unit tests and other CI tasks on
>> PR.
>> >
>> > PS: I have just created a simple script HowTo at
>> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/
>> > Merging+Github+Pull+Requests
>> > and linked from https://cwiki.apache.org/confluence/display/ZOOKEEPER/
>> > Index
>> >
>> > On Wed, Oct 26, 2016 at 3:59 PM, Flavio Junqueira 
>> wrote:
>> >
>> > > What about QA, are we still missing a github pre-commit queue?
>> > >
>> > > -Flavio
>> > >
>> > > > On 26 Oct 2016, at 18:53, Michael Han  wrote:
>> > > >
>> > > > The comment bridging should be fixed now - see INFRA-12752 for more
>> > > > details.
>> > > >
>> > > > On Wed, Oct 26, 2016 at 10:03 AM, Michael Han 
>> > wrote:
>> > > >
>> > >  The git PR *review* comments for ZOOKEEPER-2597 didn't show up on
>> > > JIRA.
>> > > >>
>> > > >> The bridge was working the day Infra made the change - see the
>> > previous
>> > > >> comments made by git bot on ZOOKEEPER-761. Now it seems stop
>> working.
>> > I
>> > > am
>> > > >> reopening INFRA-12752 and building a case.
>> > > >>
>> > > >> On Wed, Oct 26, 2016 at 9:45 AM, Edward Ribeiro <
>> > > edward.ribe...@gmail.com>
>> > > >> wrote:
>> > > >>
>> > > >>> Dear community,
>> > > >>>
>> > > >>> The zk-merger-pr.py script has been merged into master (thanks a
>> LOT
>> > > Ben
>> > > >>> Reed for reviewing/discussing/testing and commiting):
>> > > >>> https://issues.apache.org/jira/browse/ZOOKEEPER-2597
>> > > >>>
>> > > >>> As stated in the issue and on GH, this tool is a modified version
>> of
>> > > >>> similar tools from Kafka, that is a copy of a Spark's one. It has
>> > some
>> > > >>> rough edges so we will certainly benefit from further enhancements
>> > and
>> > > >>> fixes. I changed the smallest possible pieces of code, just to
>> make
>> > it
>> > > >>> work
>> > > >>> on a ZK repo so the credits go to the original authors.
>> > > >>>
>> > > >>> Some notes:
>> > > >>>
>> > > >>> 1. The git PR *review* comments for ZOOKEEPER-2597 didn't show up
>> on
>> > > JIRA.
>> > > >>> Only the opening and closing of the issue. Can we double check
>> this
>> > as
>> > > >>> INFRA-12752 is closed, Michael Han?
>> > > >>>
>> > > >>> 2. I scribbled a draft on how use the tool at
>> > > >>> https://docs.google.com/document/d/1i00ZXjrW2fu17vr_h7F1bUrq
>> > > >>> Xg3urw4Hm7KirQDpPIU/edit
>> > > >>> (still very crude, but feel free to improve it). I would like to
>> move
>> > > >>> this
>> > > >>> text to https://cwiki.apache.org/confl
>> uence/display/ZOOKEEPER/Index
>> > > but
>> > > >>> looks like I don't have permission to create a page there yet. Any
>> > > help?
>> > > >>>
>> > > >>> Best regards,
>> > > >>> Eddie
>> > > >>>
>> > > >>> On Sat, Oct 22, 2016 at 7:08 PM, Michael Han 
>> > > wrote:
>> > > >>>
>> > >  FYI infra did some work in INFRA-12752 and the git PR comments
>> can
>> > be
>> > >  pushed to Apache JIRA.
>> > > 
>> > >  On Sat, Oct 8, 2016 at 8:01 AM, Flavio Junqueira > >
>> > > >>> wrote:
>> > > 
>> > > > This is not supported at the moment if nothing has changed:
>> > > >
>> > > > https://issues.apache.org/jira/browse/INFRA-11000 <
>> > > > https://issues.apache.org/jira/browse/INFRA-11000>
>> > > >
>> > > > -Flavio
>> > > >
>> > > >> On 08 Oct 2016, at 00:54, Benjamin Reed 
>> wrote:
>> > > >>
>> > > >> it doesn't look like we need to setup keys. this seems to work
>> for
>> > > >>> me:
>> > > >>
>> > > >> 

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Hi Patrick,

We can change the script so that it asks for jira password input on CLI
prompt if the JIRA username is set, for example. The change should be
straigthforward.

Alternatively, the python systems I have dealt with put credentials for
database access, etc, in configuration -- sometimes hidden -- files (say,
.env), but yet it is clear text stored.

Anyone has other suggestions?

Eddie

Em 9 de nov de 2016 4:18 PM, "Patrick Hunt"  escreveu:

> Is there any alternative to step 4 as documented here?
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> Merging+Github+Pull+Requests
>
> specifically it's asking to "export JIRA_PASSWORD=mypassword" which I feel
> very uncomfortable doing.
>
> Patrick
>
> On Wed, Oct 26, 2016 at 11:12 AM, Edward Ribeiro  >
> wrote:
>
> > AFAIK, yes. I say, if you mean to run unit tests and other CI tasks on
> PR.
> >
> > PS: I have just created a simple script HowTo at
> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> > Merging+Github+Pull+Requests
> > and linked from https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> > Index
> >
> > On Wed, Oct 26, 2016 at 3:59 PM, Flavio Junqueira 
> wrote:
> >
> > > What about QA, are we still missing a github pre-commit queue?
> > >
> > > -Flavio
> > >
> > > > On 26 Oct 2016, at 18:53, Michael Han  wrote:
> > > >
> > > > The comment bridging should be fixed now - see INFRA-12752 for more
> > > > details.
> > > >
> > > > On Wed, Oct 26, 2016 at 10:03 AM, Michael Han 
> > wrote:
> > > >
> > >  The git PR *review* comments for ZOOKEEPER-2597 didn't show up on
> > > JIRA.
> > > >>
> > > >> The bridge was working the day Infra made the change - see the
> > previous
> > > >> comments made by git bot on ZOOKEEPER-761. Now it seems stop
> working.
> > I
> > > am
> > > >> reopening INFRA-12752 and building a case.
> > > >>
> > > >> On Wed, Oct 26, 2016 at 9:45 AM, Edward Ribeiro <
> > > edward.ribe...@gmail.com>
> > > >> wrote:
> > > >>
> > > >>> Dear community,
> > > >>>
> > > >>> The zk-merger-pr.py script has been merged into master (thanks a
> LOT
> > > Ben
> > > >>> Reed for reviewing/discussing/testing and commiting):
> > > >>> https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> > > >>>
> > > >>> As stated in the issue and on GH, this tool is a modified version
> of
> > > >>> similar tools from Kafka, that is a copy of a Spark's one. It has
> > some
> > > >>> rough edges so we will certainly benefit from further enhancements
> > and
> > > >>> fixes. I changed the smallest possible pieces of code, just to make
> > it
> > > >>> work
> > > >>> on a ZK repo so the credits go to the original authors.
> > > >>>
> > > >>> Some notes:
> > > >>>
> > > >>> 1. The git PR *review* comments for ZOOKEEPER-2597 didn't show up
> on
> > > JIRA.
> > > >>> Only the opening and closing of the issue. Can we double check this
> > as
> > > >>> INFRA-12752 is closed, Michael Han?
> > > >>>
> > > >>> 2. I scribbled a draft on how use the tool at
> > > >>> https://docs.google.com/document/d/1i00ZXjrW2fu17vr_h7F1bUrq
> > > >>> Xg3urw4Hm7KirQDpPIU/edit
> > > >>> (still very crude, but feel free to improve it). I would like to
> move
> > > >>> this
> > > >>> text to https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> Index
> > > but
> > > >>> looks like I don't have permission to create a page there yet. Any
> > > help?
> > > >>>
> > > >>> Best regards,
> > > >>> Eddie
> > > >>>
> > > >>> On Sat, Oct 22, 2016 at 7:08 PM, Michael Han 
> > > wrote:
> > > >>>
> > >  FYI infra did some work in INFRA-12752 and the git PR comments can
> > be
> > >  pushed to Apache JIRA.
> > > 
> > >  On Sat, Oct 8, 2016 at 8:01 AM, Flavio Junqueira 
> > > >>> wrote:
> > > 
> > > > This is not supported at the moment if nothing has changed:
> > > >
> > > > https://issues.apache.org/jira/browse/INFRA-11000 <
> > > > https://issues.apache.org/jira/browse/INFRA-11000>
> > > >
> > > > -Flavio
> > > >
> > > >> On 08 Oct 2016, at 00:54, Benjamin Reed 
> wrote:
> > > >>
> > > >> it doesn't look like we need to setup keys. this seems to work
> for
> > > >>> me:
> > > >>
> > > >> https://git-wip-us.apache.org/#committers-getting-started
> > > >>
> > > >> it does seem strange that we aren't using public keys and that
> i'm
> > > > sticking
> > > >> a password in .netrc :P i'm wondering if other projects were
> able
> > to
> > >  get
> > > >> this going over ssh.
> > > >>
> > > >> i'll take a whack at cleaning up the svn and subversion
> > references.
> > > >>
> > > >> ben
> > > >>
> > > >> On Fri, Oct 7, 2016 at 12:59 PM, Camille Fournier <
> > > >>> cami...@apache.org>
> > > >> wrote:
> > > >>
> > > >>> Hey folks,
> > > >>>
> > > >>> So I'm trying to get in a patch but this has 

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

AFAIK, yes. I say, if you mean to run unit tests and other CI tasks on PR.

PS: I have just created a simple script HowTo at
https://cwiki.apache.org/confluence/display/ZOOKEEPER/Merging+Github+Pull+Requests
and linked from https://cwiki.apache.org/confluence/display/ZOOKEEPER/Index

On Wed, Oct 26, 2016 at 3:59 PM, Flavio Junqueira  wrote:

> What about QA, are we still missing a github pre-commit queue?
>
> -Flavio
>
> > On 26 Oct 2016, at 18:53, Michael Han  wrote:
> >
> > The comment bridging should be fixed now - see INFRA-12752 for more
> > details.
> >
> > On Wed, Oct 26, 2016 at 10:03 AM, Michael Han  wrote:
> >
>  The git PR *review* comments for ZOOKEEPER-2597 didn't show up on
> JIRA.
> >>
> >> The bridge was working the day Infra made the change - see the previous
> >> comments made by git bot on ZOOKEEPER-761. Now it seems stop working. I
> am
> >> reopening INFRA-12752 and building a case.
> >>
> >> On Wed, Oct 26, 2016 at 9:45 AM, Edward Ribeiro <
> edward.ribe...@gmail.com>
> >> wrote:
> >>
> >>> Dear community,
> >>>
> >>> The zk-merger-pr.py script has been merged into master (thanks a LOT
> Ben
> >>> Reed for reviewing/discussing/testing and commiting):
> >>> https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> >>>
> >>> As stated in the issue and on GH, this tool is a modified version of
> >>> similar tools from Kafka, that is a copy of a Spark's one. It has some
> >>> rough edges so we will certainly benefit from further enhancements and
> >>> fixes. I changed the smallest possible pieces of code, just to make it
> >>> work
> >>> on a ZK repo so the credits go to the original authors.
> >>>
> >>> Some notes:
> >>>
> >>> 1. The git PR *review* comments for ZOOKEEPER-2597 didn't show up on
> JIRA.
> >>> Only the opening and closing of the issue. Can we double check this as
> >>> INFRA-12752 is closed, Michael Han?
> >>>
> >>> 2. I scribbled a draft on how use the tool at
> >>> https://docs.google.com/document/d/1i00ZXjrW2fu17vr_h7F1bUrq
> >>> Xg3urw4Hm7KirQDpPIU/edit
> >>> (still very crude, but feel free to improve it). I would like to move
> >>> this
> >>> text to https://cwiki.apache.org/confluence/display/ZOOKEEPER/Index
> but
> >>> looks like I don't have permission to create a page there yet. Any
> help?
> >>>
> >>> Best regards,
> >>> Eddie
> >>>
> >>> On Sat, Oct 22, 2016 at 7:08 PM, Michael Han 
> wrote:
> >>>
>  FYI infra did some work in INFRA-12752 and the git PR comments can be
>  pushed to Apache JIRA.
> 
>  On Sat, Oct 8, 2016 at 8:01 AM, Flavio Junqueira 
> >>> wrote:
> 
> > This is not supported at the moment if nothing has changed:
> >
> > https://issues.apache.org/jira/browse/INFRA-11000 <
> > https://issues.apache.org/jira/browse/INFRA-11000>
> >
> > -Flavio
> >
> >> On 08 Oct 2016, at 00:54, Benjamin Reed  wrote:
> >>
> >> it doesn't look like we need to setup keys. this seems to work for
> >>> me:
> >>
> >> https://git-wip-us.apache.org/#committers-getting-started
> >>
> >> it does seem strange that we aren't using public keys and that i'm
> > sticking
> >> a password in .netrc :P i'm wondering if other projects were able to
>  get
> >> this going over ssh.
> >>
> >> i'll take a whack at cleaning up the svn and subversion references.
> >>
> >> ben
> >>
> >> On Fri, Oct 7, 2016 at 12:59 PM, Camille Fournier <
> >>> cami...@apache.org>
> >> wrote:
> >>
> >>> Hey folks,
> >>>
> >>> So I'm trying to get in a patch but this has not been updated to
> >>> tell
> >>> committers how to actually get the git keys set up:
> >>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> > Committing+changes
> >>>
> >>> Can someone float me a link that says how to do this?
> >>>
> >>> Also a bunch of our documentation still discusses SVN and not git,
>  which
> >>> means we are not done with this migration. If you were pushing for
>  this
> >>> change can you please do some due diligence on the wikis and
> >>> correct
>  the
> >>> stuff that refers to SVN?
> >>>
> >>> Thanks,
> >>> C
> >>>
> >>> On Wed, Oct 5, 2016 at 1:02 PM, Edward Ribeiro <
> > edward.ribe...@gmail.com>
> >>> wrote:
> >>>
>  Excuse me guys!
> 
>  I've written on Macbook Pro. No idea why GMail messed it up. I was
>  only
>  able to see the strange characters when I pasted on a gist text
> >>> area.
> > The
>  previous message is below, but if anyone is still having trouble
> >>> (I
> > tried
>  to remove the weird character), I left a copy at:
>  https://gist.github.com/eribeiro/da2a6a6c9a508610d52d0755fae8352d
> 
>  "Hi,
> 
>  The patch attached on ZOOKEEPER-2597 is a straightforward

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

What about QA, are we still missing a github pre-commit queue?

-Flavio

> On 26 Oct 2016, at 18:53, Michael Han  wrote:
> 
> The comment bridging should be fixed now - see INFRA-12752 for more
> details.
> 
> On Wed, Oct 26, 2016 at 10:03 AM, Michael Han  wrote:
> 
 The git PR *review* comments for ZOOKEEPER-2597 didn't show up on JIRA.
>> 
>> The bridge was working the day Infra made the change - see the previous
>> comments made by git bot on ZOOKEEPER-761. Now it seems stop working. I am
>> reopening INFRA-12752 and building a case.
>> 
>> On Wed, Oct 26, 2016 at 9:45 AM, Edward Ribeiro 
>> wrote:
>> 
>>> Dear community,
>>> 
>>> The zk-merger-pr.py script has been merged into master (thanks a LOT Ben
>>> Reed for reviewing/discussing/testing and commiting):
>>> https://issues.apache.org/jira/browse/ZOOKEEPER-2597
>>> 
>>> As stated in the issue and on GH, this tool is a modified version of
>>> similar tools from Kafka, that is a copy of a Spark's one. It has some
>>> rough edges so we will certainly benefit from further enhancements and
>>> fixes. I changed the smallest possible pieces of code, just to make it
>>> work
>>> on a ZK repo so the credits go to the original authors.
>>> 
>>> Some notes:
>>> 
>>> 1. The git PR *review* comments for ZOOKEEPER-2597 didn't show up on JIRA.
>>> Only the opening and closing of the issue. Can we double check this as
>>> INFRA-12752 is closed, Michael Han?
>>> 
>>> 2. I scribbled a draft on how use the tool at
>>> https://docs.google.com/document/d/1i00ZXjrW2fu17vr_h7F1bUrq
>>> Xg3urw4Hm7KirQDpPIU/edit
>>> (still very crude, but feel free to improve it). I would like to move
>>> this
>>> text to https://cwiki.apache.org/confluence/display/ZOOKEEPER/Index but
>>> looks like I don't have permission to create a page there yet. Any help?
>>> 
>>> Best regards,
>>> Eddie
>>> 
>>> On Sat, Oct 22, 2016 at 7:08 PM, Michael Han  wrote:
>>> 
 FYI infra did some work in INFRA-12752 and the git PR comments can be
 pushed to Apache JIRA.
 
 On Sat, Oct 8, 2016 at 8:01 AM, Flavio Junqueira 
>>> wrote:
 
> This is not supported at the moment if nothing has changed:
> 
> https://issues.apache.org/jira/browse/INFRA-11000 <
> https://issues.apache.org/jira/browse/INFRA-11000>
> 
> -Flavio
> 
>> On 08 Oct 2016, at 00:54, Benjamin Reed  wrote:
>> 
>> it doesn't look like we need to setup keys. this seems to work for
>>> me:
>> 
>> https://git-wip-us.apache.org/#committers-getting-started
>> 
>> it does seem strange that we aren't using public keys and that i'm
> sticking
>> a password in .netrc :P i'm wondering if other projects were able to
 get
>> this going over ssh.
>> 
>> i'll take a whack at cleaning up the svn and subversion references.
>> 
>> ben
>> 
>> On Fri, Oct 7, 2016 at 12:59 PM, Camille Fournier <
>>> cami...@apache.org>
>> wrote:
>> 
>>> Hey folks,
>>> 
>>> So I'm trying to get in a patch but this has not been updated to
>>> tell
>>> committers how to actually get the git keys set up:
>>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> Committing+changes
>>> 
>>> Can someone float me a link that says how to do this?
>>> 
>>> Also a bunch of our documentation still discusses SVN and not git,
 which
>>> means we are not done with this migration. If you were pushing for
 this
>>> change can you please do some due diligence on the wikis and
>>> correct
 the
>>> stuff that refers to SVN?
>>> 
>>> Thanks,
>>> C
>>> 
>>> On Wed, Oct 5, 2016 at 1:02 PM, Edward Ribeiro <
> edward.ribe...@gmail.com>
>>> wrote:
>>> 
 Excuse me guys!
 
 I've written on Macbook Pro. No idea why GMail messed it up. I was
 only
 able to see the strange characters when I pasted on a gist text
>>> area.
> The
 previous message is below, but if anyone is still having trouble
>>> (I
> tried
 to remove the weird character), I left a copy at:
 https://gist.github.com/eribeiro/da2a6a6c9a508610d52d0755fae8352d
 
 "Hi,
 
 The patch attached on ZOOKEEPER-2597 is a straightforward
>>> adaptation
 of
 Kafka's one. It takes care of merging Github PR into Apache git
>>> repo
> and
>>> a
 subsequent closing of the PR on the GH side, among other things
>>> (rewriting
 of commit messages, etc). The current status is: the script needs
>>> to
 be
 reviewed/validated by a committer. It has been some time since I
> uploaded
 the patch, so I gonna do another pass through it in the meantime.
 
 There are some workflow issues beyond the scope of ZOOKEEPER-2597
 that
>>> need
 to be 

Re: [VOTE] move Apache Zookeeper to git

[Michael Han]

The comment bridging should be fixed now - see INFRA-12752 for more
details.

On Wed, Oct 26, 2016 at 10:03 AM, Michael Han  wrote:

> >> The git PR *review* comments for ZOOKEEPER-2597 didn't show up on JIRA.
>
> The bridge was working the day Infra made the change - see the previous
> comments made by git bot on ZOOKEEPER-761. Now it seems stop working. I am
> reopening INFRA-12752 and building a case.
>
> On Wed, Oct 26, 2016 at 9:45 AM, Edward Ribeiro 
> wrote:
>
>> Dear community,
>>
>> The zk-merger-pr.py script has been merged into master (thanks a LOT Ben
>> Reed for reviewing/discussing/testing and commiting):
>> https://issues.apache.org/jira/browse/ZOOKEEPER-2597
>>
>> As stated in the issue and on GH, this tool is a modified version of
>> similar tools from Kafka, that is a copy of a Spark's one. It has some
>> rough edges so we will certainly benefit from further enhancements and
>> fixes. I changed the smallest possible pieces of code, just to make it
>> work
>> on a ZK repo so the credits go to the original authors.
>>
>> Some notes:
>>
>> 1. The git PR *review* comments for ZOOKEEPER-2597 didn't show up on JIRA.
>> Only the opening and closing of the issue. Can we double check this as
>> INFRA-12752 is closed, Michael Han?
>>
>> 2. I scribbled a draft on how use the tool at
>> https://docs.google.com/document/d/1i00ZXjrW2fu17vr_h7F1bUrq
>> Xg3urw4Hm7KirQDpPIU/edit
>>  (still very crude, but feel free to improve it). I would like to move
>> this
>> text to https://cwiki.apache.org/confluence/display/ZOOKEEPER/Index but
>> looks like I don't have permission to create a page there yet. Any help?
>>
>> Best regards,
>> Eddie
>>
>> On Sat, Oct 22, 2016 at 7:08 PM, Michael Han  wrote:
>>
>> > FYI infra did some work in INFRA-12752 and the git PR comments can be
>> > pushed to Apache JIRA.
>> >
>> > On Sat, Oct 8, 2016 at 8:01 AM, Flavio Junqueira 
>> wrote:
>> >
>> > > This is not supported at the moment if nothing has changed:
>> > >
>> > > https://issues.apache.org/jira/browse/INFRA-11000 <
>> > > https://issues.apache.org/jira/browse/INFRA-11000>
>> > >
>> > > -Flavio
>> > >
>> > > > On 08 Oct 2016, at 00:54, Benjamin Reed  wrote:
>> > > >
>> > > > it doesn't look like we need to setup keys. this seems to work for
>> me:
>> > > >
>> > > > https://git-wip-us.apache.org/#committers-getting-started
>> > > >
>> > > > it does seem strange that we aren't using public keys and that i'm
>> > > sticking
>> > > > a password in .netrc :P i'm wondering if other projects were able to
>> > get
>> > > > this going over ssh.
>> > > >
>> > > > i'll take a whack at cleaning up the svn and subversion references.
>> > > >
>> > > > ben
>> > > >
>> > > > On Fri, Oct 7, 2016 at 12:59 PM, Camille Fournier <
>> cami...@apache.org>
>> > > > wrote:
>> > > >
>> > > >> Hey folks,
>> > > >>
>> > > >> So I'm trying to get in a patch but this has not been updated to
>> tell
>> > > >> committers how to actually get the git keys set up:
>> > > >> https://cwiki.apache.org/confluence/display/ZOOKEEPER/
>> > > Committing+changes
>> > > >>
>> > > >> Can someone float me a link that says how to do this?
>> > > >>
>> > > >> Also a bunch of our documentation still discusses SVN and not git,
>> > which
>> > > >> means we are not done with this migration. If you were pushing for
>> > this
>> > > >> change can you please do some due diligence on the wikis and
>> correct
>> > the
>> > > >> stuff that refers to SVN?
>> > > >>
>> > > >> Thanks,
>> > > >> C
>> > > >>
>> > > >> On Wed, Oct 5, 2016 at 1:02 PM, Edward Ribeiro <
>> > > edward.ribe...@gmail.com>
>> > > >> wrote:
>> > > >>
>> > > >>> Excuse me guys!
>> > > >>>
>> > > >>> I've written on Macbook Pro. No idea why GMail messed it up. I was
>> > only
>> > > >>> able to see the strange characters when I pasted on a gist text
>> area.
>> > > The
>> > > >>> previous message is below, but if anyone is still having trouble
>> (I
>> > > tried
>> > > >>> to remove the weird character), I left a copy at:
>> > > >>> https://gist.github.com/eribeiro/da2a6a6c9a508610d52d0755fae8352d
>> > > >>>
>> > > >>> "Hi,
>> > > >>>
>> > > >>> The patch attached on ZOOKEEPER-2597 is a straightforward
>> adaptation
>> > of
>> > > >>> Kafka's one. It takes care of merging Github PR into Apache git
>> repo
>> > > and
>> > > >> a
>> > > >>> subsequent closing of the PR on the GH side, among other things
>> > > >> (rewriting
>> > > >>> of commit messages, etc). The current status is: the script needs
>> to
>> > be
>> > > >>> reviewed/validated by a committer. It has been some time since I
>> > > uploaded
>> > > >>> the patch, so I gonna do another pass through it in the meantime.
>> > > >>>
>> > > >>> There are some workflow issues beyond the scope of ZOOKEEPER-2597
>> > that
>> > > >> need
>> > > >>> to be sorted out (IMO):
>> > > >>>
>> > > >>> 1. The normal workflow is to open a JIRA ticket before doing any
>> 

Re: [VOTE] move Apache Zookeeper to git

[Michael Han]

>> The git PR *review* comments for ZOOKEEPER-2597 didn't show up on JIRA.

The bridge was working the day Infra made the change - see the previous
comments made by git bot on ZOOKEEPER-761. Now it seems stop working. I am
reopening INFRA-12752 and building a case.

On Wed, Oct 26, 2016 at 9:45 AM, Edward Ribeiro 
wrote:

> Dear community,
>
> The zk-merger-pr.py script has been merged into master (thanks a LOT Ben
> Reed for reviewing/discussing/testing and commiting):
> https://issues.apache.org/jira/browse/ZOOKEEPER-2597
>
> As stated in the issue and on GH, this tool is a modified version of
> similar tools from Kafka, that is a copy of a Spark's one. It has some
> rough edges so we will certainly benefit from further enhancements and
> fixes. I changed the smallest possible pieces of code, just to make it work
> on a ZK repo so the credits go to the original authors.
>
> Some notes:
>
> 1. The git PR *review* comments for ZOOKEEPER-2597 didn't show up on JIRA.
> Only the opening and closing of the issue. Can we double check this as
> INFRA-12752 is closed, Michael Han?
>
> 2. I scribbled a draft on how use the tool at
> https://docs.google.com/document/d/1i00ZXjrW2fu17vr_
> h7F1bUrqXg3urw4Hm7KirQDpPIU/edit
>  (still very crude, but feel free to improve it). I would like to move this
> text to https://cwiki.apache.org/confluence/display/ZOOKEEPER/Index but
> looks like I don't have permission to create a page there yet. Any help?
>
> Best regards,
> Eddie
>
> On Sat, Oct 22, 2016 at 7:08 PM, Michael Han  wrote:
>
> > FYI infra did some work in INFRA-12752 and the git PR comments can be
> > pushed to Apache JIRA.
> >
> > On Sat, Oct 8, 2016 at 8:01 AM, Flavio Junqueira  wrote:
> >
> > > This is not supported at the moment if nothing has changed:
> > >
> > > https://issues.apache.org/jira/browse/INFRA-11000 <
> > > https://issues.apache.org/jira/browse/INFRA-11000>
> > >
> > > -Flavio
> > >
> > > > On 08 Oct 2016, at 00:54, Benjamin Reed  wrote:
> > > >
> > > > it doesn't look like we need to setup keys. this seems to work for
> me:
> > > >
> > > > https://git-wip-us.apache.org/#committers-getting-started
> > > >
> > > > it does seem strange that we aren't using public keys and that i'm
> > > sticking
> > > > a password in .netrc :P i'm wondering if other projects were able to
> > get
> > > > this going over ssh.
> > > >
> > > > i'll take a whack at cleaning up the svn and subversion references.
> > > >
> > > > ben
> > > >
> > > > On Fri, Oct 7, 2016 at 12:59 PM, Camille Fournier <
> cami...@apache.org>
> > > > wrote:
> > > >
> > > >> Hey folks,
> > > >>
> > > >> So I'm trying to get in a patch but this has not been updated to
> tell
> > > >> committers how to actually get the git keys set up:
> > > >> https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> > > Committing+changes
> > > >>
> > > >> Can someone float me a link that says how to do this?
> > > >>
> > > >> Also a bunch of our documentation still discusses SVN and not git,
> > which
> > > >> means we are not done with this migration. If you were pushing for
> > this
> > > >> change can you please do some due diligence on the wikis and correct
> > the
> > > >> stuff that refers to SVN?
> > > >>
> > > >> Thanks,
> > > >> C
> > > >>
> > > >> On Wed, Oct 5, 2016 at 1:02 PM, Edward Ribeiro <
> > > edward.ribe...@gmail.com>
> > > >> wrote:
> > > >>
> > > >>> Excuse me guys!
> > > >>>
> > > >>> I've written on Macbook Pro. No idea why GMail messed it up. I was
> > only
> > > >>> able to see the strange characters when I pasted on a gist text
> area.
> > > The
> > > >>> previous message is below, but if anyone is still having trouble (I
> > > tried
> > > >>> to remove the weird character), I left a copy at:
> > > >>> https://gist.github.com/eribeiro/da2a6a6c9a508610d52d0755fae8352d
> > > >>>
> > > >>> "Hi,
> > > >>>
> > > >>> The patch attached on ZOOKEEPER-2597 is a straightforward
> adaptation
> > of
> > > >>> Kafka's one. It takes care of merging Github PR into Apache git
> repo
> > > and
> > > >> a
> > > >>> subsequent closing of the PR on the GH side, among other things
> > > >> (rewriting
> > > >>> of commit messages, etc). The current status is: the script needs
> to
> > be
> > > >>> reviewed/validated by a committer. It has been some time since I
> > > uploaded
> > > >>> the patch, so I gonna do another pass through it in the meantime.
> > > >>>
> > > >>> There are some workflow issues beyond the scope of ZOOKEEPER-2597
> > that
> > > >> need
> > > >>> to be sorted out (IMO):
> > > >>>
> > > >>> 1. The normal workflow is to open a JIRA ticket before doing any GH
> > PR,
> > > >>> that is, no JIRA-less PRs. The PR should have a title of the form
> > > >>> "ZOOKEEPER-: Title". This will trigger the Apache JIRA-Github
> > > >>> integration and it's opening show up in the JIRA ticket.
> > > >>>
> > > >>> 2. OTOH, not every Kafka PR needs a corresponding JIRA 

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

Thanks, Eddie. This is great.

> On 26 Oct 2016, at 17:45, Edward Ribeiro  wrote:
> (still very crude, but feel free to improve it). I would like to move this
> text to https://cwiki.apache.org/confluence/display/ZOOKEEPER/Index but
> looks like I don't have permission to create a page there yet. Any help?
> 

Done.

-Flavio

> 
> On Sat, Oct 22, 2016 at 7:08 PM, Michael Han  wrote:
> 
>> FYI infra did some work in INFRA-12752 and the git PR comments can be
>> pushed to Apache JIRA.
>> 
>> On Sat, Oct 8, 2016 at 8:01 AM, Flavio Junqueira  wrote:
>> 
>>> This is not supported at the moment if nothing has changed:
>>> 
>>> https://issues.apache.org/jira/browse/INFRA-11000 <
>>> https://issues.apache.org/jira/browse/INFRA-11000>
>>> 
>>> -Flavio
>>> 
 On 08 Oct 2016, at 00:54, Benjamin Reed  wrote:
 
 it doesn't look like we need to setup keys. this seems to work for me:
 
 https://git-wip-us.apache.org/#committers-getting-started
 
 it does seem strange that we aren't using public keys and that i'm
>>> sticking
 a password in .netrc :P i'm wondering if other projects were able to
>> get
 this going over ssh.
 
 i'll take a whack at cleaning up the svn and subversion references.
 
 ben
 
 On Fri, Oct 7, 2016 at 12:59 PM, Camille Fournier 
 wrote:
 
> Hey folks,
> 
> So I'm trying to get in a patch but this has not been updated to tell
> committers how to actually get the git keys set up:
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/
>>> Committing+changes
> 
> Can someone float me a link that says how to do this?
> 
> Also a bunch of our documentation still discusses SVN and not git,
>> which
> means we are not done with this migration. If you were pushing for
>> this
> change can you please do some due diligence on the wikis and correct
>> the
> stuff that refers to SVN?
> 
> Thanks,
> C
> 
> On Wed, Oct 5, 2016 at 1:02 PM, Edward Ribeiro <
>>> edward.ribe...@gmail.com>
> wrote:
> 
>> Excuse me guys!
>> 
>> I've written on Macbook Pro. No idea why GMail messed it up. I was
>> only
>> able to see the strange characters when I pasted on a gist text area.
>>> The
>> previous message is below, but if anyone is still having trouble (I
>>> tried
>> to remove the weird character), I left a copy at:
>> https://gist.github.com/eribeiro/da2a6a6c9a508610d52d0755fae8352d
>> 
>> "Hi,
>> 
>> The patch attached on ZOOKEEPER-2597 is a straightforward adaptation
>> of
>> Kafka's one. It takes care of merging Github PR into Apache git repo
>>> and
> a
>> subsequent closing of the PR on the GH side, among other things
> (rewriting
>> of commit messages, etc). The current status is: the script needs to
>> be
>> reviewed/validated by a committer. It has been some time since I
>>> uploaded
>> the patch, so I gonna do another pass through it in the meantime.
>> 
>> There are some workflow issues beyond the scope of ZOOKEEPER-2597
>> that
> need
>> to be sorted out (IMO):
>> 
>> 1. The normal workflow is to open a JIRA ticket before doing any GH
>> PR,
>> that is, no JIRA-less PRs. The PR should have a title of the form
>> "ZOOKEEPER-: Title". This will trigger the Apache JIRA-Github
>> integration and it's opening show up in the JIRA ticket.
>> 
>> 2. OTOH, not every Kafka PR needs a corresponding JIRA ticket. There
>>> are
> a
>> class of PRs with "MINOR" title that represent trivial code changes
>> and
>> "HOT-FIX" title that fix urgent, but simple bugs. Both bypass the
>> JIRA
>> creation step, even tough they are still subject to review. It's
>> worth
>> adopting a similar approach for ZK project?
>> 
>> 3. IIRC (didn't find any page to confirm), Cassandra project
>>> encourages,
>> but not demands, that contributors also upload a patch file to JIRA
>>> even
> in
>> the case of a GH PR (as to leave a audit trail, I guess). Or, at
>>> least,
> C*
>> project leaves up to the contributors to either open a GH PR or
>> upload
> the
>> patch file to JIRA.
>> 
>> 
>> +1 about having a 'paper trail' of review comments on JIRA and/or
>>> mailing
>> list (I would prefer the mailing list tbh). But as Michael and Flavio
>> pointed out, I never seen GH PR review **comments** being written
>> back
>>> to
>> JIRA, at least not in Kafka, Cassandra or Solr projects, that I have
>> followed more closely.
>> 
>> Eddie"
>> 
>> 
>> On Wed, Oct 5, 2016 at 1:35 PM, Michael Han 
>> wrote:
>> 
>>> Eddie's mail contains lots of '=E2=80=8B'' which is unicode
>> character
>>> zero-width space, which might cause parsing trouble for some mail
>> 

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Dear community,

The zk-merger-pr.py script has been merged into master (thanks a LOT Ben
Reed for reviewing/discussing/testing and commiting):
https://issues.apache.org/jira/browse/ZOOKEEPER-2597

As stated in the issue and on GH, this tool is a modified version of
similar tools from Kafka, that is a copy of a Spark's one. It has some
rough edges so we will certainly benefit from further enhancements and
fixes. I changed the smallest possible pieces of code, just to make it work
on a ZK repo so the credits go to the original authors.

Some notes:

1. The git PR *review* comments for ZOOKEEPER-2597 didn't show up on JIRA.
Only the opening and closing of the issue. Can we double check this as
INFRA-12752 is closed, Michael Han?

2. I scribbled a draft on how use the tool at
https://docs.google.com/document/d/1i00ZXjrW2fu17vr_h7F1bUrqXg3urw4Hm7KirQDpPIU/edit
 (still very crude, but feel free to improve it). I would like to move this
text to https://cwiki.apache.org/confluence/display/ZOOKEEPER/Index but
looks like I don't have permission to create a page there yet. Any help?

Best regards,
Eddie

On Sat, Oct 22, 2016 at 7:08 PM, Michael Han  wrote:

> FYI infra did some work in INFRA-12752 and the git PR comments can be
> pushed to Apache JIRA.
>
> On Sat, Oct 8, 2016 at 8:01 AM, Flavio Junqueira  wrote:
>
> > This is not supported at the moment if nothing has changed:
> >
> > https://issues.apache.org/jira/browse/INFRA-11000 <
> > https://issues.apache.org/jira/browse/INFRA-11000>
> >
> > -Flavio
> >
> > > On 08 Oct 2016, at 00:54, Benjamin Reed  wrote:
> > >
> > > it doesn't look like we need to setup keys. this seems to work for me:
> > >
> > > https://git-wip-us.apache.org/#committers-getting-started
> > >
> > > it does seem strange that we aren't using public keys and that i'm
> > sticking
> > > a password in .netrc :P i'm wondering if other projects were able to
> get
> > > this going over ssh.
> > >
> > > i'll take a whack at cleaning up the svn and subversion references.
> > >
> > > ben
> > >
> > > On Fri, Oct 7, 2016 at 12:59 PM, Camille Fournier 
> > > wrote:
> > >
> > >> Hey folks,
> > >>
> > >> So I'm trying to get in a patch but this has not been updated to tell
> > >> committers how to actually get the git keys set up:
> > >> https://cwiki.apache.org/confluence/display/ZOOKEEPER/
> > Committing+changes
> > >>
> > >> Can someone float me a link that says how to do this?
> > >>
> > >> Also a bunch of our documentation still discusses SVN and not git,
> which
> > >> means we are not done with this migration. If you were pushing for
> this
> > >> change can you please do some due diligence on the wikis and correct
> the
> > >> stuff that refers to SVN?
> > >>
> > >> Thanks,
> > >> C
> > >>
> > >> On Wed, Oct 5, 2016 at 1:02 PM, Edward Ribeiro <
> > edward.ribe...@gmail.com>
> > >> wrote:
> > >>
> > >>> Excuse me guys!
> > >>>
> > >>> I've written on Macbook Pro. No idea why GMail messed it up. I was
> only
> > >>> able to see the strange characters when I pasted on a gist text area.
> > The
> > >>> previous message is below, but if anyone is still having trouble (I
> > tried
> > >>> to remove the weird character), I left a copy at:
> > >>> https://gist.github.com/eribeiro/da2a6a6c9a508610d52d0755fae8352d
> > >>>
> > >>> "Hi,
> > >>>
> > >>> The patch attached on ZOOKEEPER-2597 is a straightforward adaptation
> of
> > >>> Kafka's one. It takes care of merging Github PR into Apache git repo
> > and
> > >> a
> > >>> subsequent closing of the PR on the GH side, among other things
> > >> (rewriting
> > >>> of commit messages, etc). The current status is: the script needs to
> be
> > >>> reviewed/validated by a committer. It has been some time since I
> > uploaded
> > >>> the patch, so I gonna do another pass through it in the meantime.
> > >>>
> > >>> There are some workflow issues beyond the scope of ZOOKEEPER-2597
> that
> > >> need
> > >>> to be sorted out (IMO):
> > >>>
> > >>> 1. The normal workflow is to open a JIRA ticket before doing any GH
> PR,
> > >>> that is, no JIRA-less PRs. The PR should have a title of the form
> > >>> "ZOOKEEPER-: Title". This will trigger the Apache JIRA-Github
> > >>> integration and it's opening show up in the JIRA ticket.
> > >>>
> > >>> 2. OTOH, not every Kafka PR needs a corresponding JIRA ticket. There
> > are
> > >> a
> > >>> class of PRs with "MINOR" title that represent trivial code changes
> and
> > >>> "HOT-FIX" title that fix urgent, but simple bugs. Both bypass the
> JIRA
> > >>> creation step, even tough they are still subject to review. It's
> worth
> > >>> adopting a similar approach for ZK project?
> > >>>
> > >>> 3. IIRC (didn't find any page to confirm), Cassandra project
> > encourages,
> > >>> but not demands, that contributors also upload a patch file to JIRA
> > even
> > >> in
> > >>> the case of a GH PR (as to leave a audit trail, I guess). Or, at
> > least,
> > >> C*

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

This is not supported at the moment if nothing has changed:

https://issues.apache.org/jira/browse/INFRA-11000 


-Flavio

> On 08 Oct 2016, at 00:54, Benjamin Reed  wrote:
> 
> it doesn't look like we need to setup keys. this seems to work for me:
> 
> https://git-wip-us.apache.org/#committers-getting-started
> 
> it does seem strange that we aren't using public keys and that i'm sticking
> a password in .netrc :P i'm wondering if other projects were able to get
> this going over ssh.
> 
> i'll take a whack at cleaning up the svn and subversion references.
> 
> ben
> 
> On Fri, Oct 7, 2016 at 12:59 PM, Camille Fournier 
> wrote:
> 
>> Hey folks,
>> 
>> So I'm trying to get in a patch but this has not been updated to tell
>> committers how to actually get the git keys set up:
>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes
>> 
>> Can someone float me a link that says how to do this?
>> 
>> Also a bunch of our documentation still discusses SVN and not git, which
>> means we are not done with this migration. If you were pushing for this
>> change can you please do some due diligence on the wikis and correct the
>> stuff that refers to SVN?
>> 
>> Thanks,
>> C
>> 
>> On Wed, Oct 5, 2016 at 1:02 PM, Edward Ribeiro 
>> wrote:
>> 
>>> Excuse me guys!
>>> 
>>> I've written on Macbook Pro. No idea why GMail messed it up. I was only
>>> able to see the strange characters when I pasted on a gist text area. The
>>> previous message is below, but if anyone is still having trouble (I tried
>>> to remove the weird character), I left a copy at:
>>> https://gist.github.com/eribeiro/da2a6a6c9a508610d52d0755fae8352d
>>> 
>>> "Hi,
>>> 
>>> The patch attached on ZOOKEEPER-2597 is a straightforward adaptation of
>>> Kafka's one. It takes care of merging Github PR into Apache git repo and
>> a
>>> subsequent closing of the PR on the GH side, among other things
>> (rewriting
>>> of commit messages, etc). The current status is: the script needs to be
>>> reviewed/validated by a committer. It has been some time since I uploaded
>>> the patch, so I gonna do another pass through it in the meantime.
>>> 
>>> There are some workflow issues beyond the scope of ZOOKEEPER-2597 that
>> need
>>> to be sorted out (IMO):
>>> 
>>> 1. The normal workflow is to open a JIRA ticket before doing any GH PR,
>>> that is, no JIRA-less PRs. The PR should have a title of the form
>>> "ZOOKEEPER-: Title". This will trigger the Apache JIRA-Github
>>> integration and it's opening show up in the JIRA ticket.
>>> 
>>> 2. OTOH, not every Kafka PR needs a corresponding JIRA ticket. There are
>> a
>>> class of PRs with "MINOR" title that represent trivial code changes and
>>> "HOT-FIX" title that fix urgent, but simple bugs. Both bypass the JIRA
>>> creation step, even tough they are still subject to review. It's worth
>>> adopting a similar approach for ZK project?
>>> 
>>> 3. IIRC (didn't find any page to confirm), Cassandra project encourages,
>>> but not demands, that contributors also upload a patch file to JIRA even
>> in
>>> the case of a GH PR (as to leave a audit trail, I guess). Or, at  least,
>> C*
>>> project leaves up to the contributors to either open a GH PR or upload
>> the
>>> patch file to JIRA.
>>> 
>>> 
>>> +1 about having a 'paper trail' of review comments on JIRA and/or mailing
>>> list (I would prefer the mailing list tbh). But as Michael and Flavio
>>> pointed out, I never seen GH PR review **comments** being written back to
>>> JIRA, at least not in Kafka, Cassandra or Solr projects, that I have
>>> followed more closely.
>>> 
>>> Eddie"
>>> 
>>> 
>>> On Wed, Oct 5, 2016 at 1:35 PM, Michael Han  wrote:
>>> 
 Eddie's mail contains lots of '=E2=80=8B'' which is unicode character
 zero-width space, which might cause parsing trouble for some mail
>>> clients.
 
 On Wed, Oct 5, 2016 at 6:42 AM, Flavio Junqueira 
>> wrote:
 
> Dude, I'm just not able to parse your e-mail, did you write that on a
> phone or something?
> 
> -Flavio
> 
>> On 05 Oct 2016, at 03:54, Edward Ribeiro >> 
> wrote:
>> 
>> Hi,
>> 
>> The patch attached on ZOOKEEPER-2597 is a
>> ​straightforward adaptation of
>> Kafka's one. It takes care of merging Github PR into Apache git
>> repo
 and
>> ​ a​
>> subsequent closing of the PR on the GH side
>> ​ among other things (rewriting of commit messages, etc)​
>> . The current status is: the script needs to be reviewed/validated
>>> by a
>> committer.
>> ​It has been some time since I uploaded the patch, so I gonna do
 another
>> pass through it in the meantime.​
>> 
>> 
>> ​T
>> here are some workflow issues beyond the scope of ZOOKEEPER-2597
>> ​ that need to be sorted out (IMO)​
>> :

Re: [VOTE] move Apache Zookeeper to git

[Benjamin Reed]

it doesn't look like we need to setup keys. this seems to work for me:

https://git-wip-us.apache.org/#committers-getting-started

it does seem strange that we aren't using public keys and that i'm sticking
a password in .netrc :P i'm wondering if other projects were able to get
this going over ssh.

i'll take a whack at cleaning up the svn and subversion references.

ben

On Fri, Oct 7, 2016 at 12:59 PM, Camille Fournier 
wrote:

> Hey folks,
>
> So I'm trying to get in a patch but this has not been updated to tell
> committers how to actually get the git keys set up:
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes
>
> Can someone float me a link that says how to do this?
>
> Also a bunch of our documentation still discusses SVN and not git, which
> means we are not done with this migration. If you were pushing for this
> change can you please do some due diligence on the wikis and correct the
> stuff that refers to SVN?
>
> Thanks,
> C
>
> On Wed, Oct 5, 2016 at 1:02 PM, Edward Ribeiro 
> wrote:
>
> > Excuse me guys!
> >
> > I've written on Macbook Pro. No idea why GMail messed it up. I was only
> > able to see the strange characters when I pasted on a gist text area. The
> > previous message is below, but if anyone is still having trouble (I tried
> > to remove the weird character), I left a copy at:
> > https://gist.github.com/eribeiro/da2a6a6c9a508610d52d0755fae8352d
> >
> > "Hi,
> >
> > The patch attached on ZOOKEEPER-2597 is a straightforward adaptation of
> > Kafka's one. It takes care of merging Github PR into Apache git repo and
> a
> > subsequent closing of the PR on the GH side, among other things
> (rewriting
> > of commit messages, etc). The current status is: the script needs to be
> > reviewed/validated by a committer. It has been some time since I uploaded
> > the patch, so I gonna do another pass through it in the meantime.
> >
> > There are some workflow issues beyond the scope of ZOOKEEPER-2597 that
> need
> > to be sorted out (IMO):
> >
> > 1. The normal workflow is to open a JIRA ticket before doing any GH PR,
> > that is, no JIRA-less PRs. The PR should have a title of the form
> > "ZOOKEEPER-: Title". This will trigger the Apache JIRA-Github
> > integration and it's opening show up in the JIRA ticket.
> >
> > 2. OTOH, not every Kafka PR needs a corresponding JIRA ticket. There are
> a
> > class of PRs with "MINOR" title that represent trivial code changes and
> > "HOT-FIX" title that fix urgent, but simple bugs. Both bypass the JIRA
> > creation step, even tough they are still subject to review. It's worth
> > adopting a similar approach for ZK project?
> >
> > 3. IIRC (didn't find any page to confirm), Cassandra project encourages,
> > but not demands, that contributors also upload a patch file to JIRA even
> in
> > the case of a GH PR (as to leave a audit trail, I guess). Or, at  least,
> C*
> > project leaves up to the contributors to either open a GH PR or upload
> the
> > patch file to JIRA.
> >
> >
> > +1 about having a 'paper trail' of review comments on JIRA and/or mailing
> > list (I would prefer the mailing list tbh). But as Michael and Flavio
> > pointed out, I never seen GH PR review **comments** being written back to
> > JIRA, at least not in Kafka, Cassandra or Solr projects, that I have
> > followed more closely.
> >
> > Eddie"
> >
> >
> > On Wed, Oct 5, 2016 at 1:35 PM, Michael Han  wrote:
> >
> > > Eddie's mail contains lots of '=E2=80=8B'' which is unicode character
> > > zero-width space, which might cause parsing trouble for some mail
> > clients.
> > >
> > > On Wed, Oct 5, 2016 at 6:42 AM, Flavio Junqueira 
> wrote:
> > >
> > > > Dude, I'm just not able to parse your e-mail, did you write that on a
> > > > phone or something?
> > > >
> > > > -Flavio
> > > >
> > > > > On 05 Oct 2016, at 03:54, Edward Ribeiro  >
> > > > wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > The patch attached on ZOOKEEPER-2597 is a
> > > > > ​straightforward adaptation of
> > > > > Kafka's one. It takes care of merging Github PR into Apache git
> repo
> > > and
> > > > > ​ a​
> > > > > subsequent closing of the PR on the GH side
> > > > > ​ among other things (rewriting of commit messages, etc)​
> > > > > . The current status is: the script needs to be reviewed/validated
> > by a
> > > > > committer.
> > > > > ​It has been some time since I uploaded the patch, so I gonna do
> > > another
> > > > > pass through it in the meantime.​
> > > > >
> > > > >
> > > > > ​T
> > > > > here are some workflow issues beyond the scope of ZOOKEEPER-2597
> > > > > ​ that need to be sorted out (IMO)​
> > > > > :
> > > > >
> > > > > 1. The normal workflow is to open a JIRA ticket before doing any GH
> > PR
> > > > > ​, that is, no JIRA-less PRs.​
> > > > > The PR should have a title of the form "ZOOKEEPER-: Title".
> This
> > > will
> > > > > trigger the Apache 

Re: [VOTE] move Apache Zookeeper to git

[Camille Fournier]

Hey folks,

So I'm trying to get in a patch but this has not been updated to tell
committers how to actually get the git keys set up:
https://cwiki.apache.org/confluence/display/ZOOKEEPER/Committing+changes

Can someone float me a link that says how to do this?

Also a bunch of our documentation still discusses SVN and not git, which
means we are not done with this migration. If you were pushing for this
change can you please do some due diligence on the wikis and correct the
stuff that refers to SVN?

Thanks,
C

On Wed, Oct 5, 2016 at 1:02 PM, Edward Ribeiro 
wrote:

> Excuse me guys!
>
> I've written on Macbook Pro. No idea why GMail messed it up. I was only
> able to see the strange characters when I pasted on a gist text area. The
> previous message is below, but if anyone is still having trouble (I tried
> to remove the weird character), I left a copy at:
> https://gist.github.com/eribeiro/da2a6a6c9a508610d52d0755fae8352d
>
> "Hi,
>
> The patch attached on ZOOKEEPER-2597 is a straightforward adaptation of
> Kafka's one. It takes care of merging Github PR into Apache git repo and a
> subsequent closing of the PR on the GH side, among other things (rewriting
> of commit messages, etc). The current status is: the script needs to be
> reviewed/validated by a committer. It has been some time since I uploaded
> the patch, so I gonna do another pass through it in the meantime.
>
> There are some workflow issues beyond the scope of ZOOKEEPER-2597 that need
> to be sorted out (IMO):
>
> 1. The normal workflow is to open a JIRA ticket before doing any GH PR,
> that is, no JIRA-less PRs. The PR should have a title of the form
> "ZOOKEEPER-: Title". This will trigger the Apache JIRA-Github
> integration and it's opening show up in the JIRA ticket.
>
> 2. OTOH, not every Kafka PR needs a corresponding JIRA ticket. There are a
> class of PRs with "MINOR" title that represent trivial code changes and
> "HOT-FIX" title that fix urgent, but simple bugs. Both bypass the JIRA
> creation step, even tough they are still subject to review. It's worth
> adopting a similar approach for ZK project?
>
> 3. IIRC (didn't find any page to confirm), Cassandra project encourages,
> but not demands, that contributors also upload a patch file to JIRA even in
> the case of a GH PR (as to leave a audit trail, I guess). Or, at  least, C*
> project leaves up to the contributors to either open a GH PR or upload the
> patch file to JIRA.
>
>
> +1 about having a 'paper trail' of review comments on JIRA and/or mailing
> list (I would prefer the mailing list tbh). But as Michael and Flavio
> pointed out, I never seen GH PR review **comments** being written back to
> JIRA, at least not in Kafka, Cassandra or Solr projects, that I have
> followed more closely.
>
> Eddie"
>
>
> On Wed, Oct 5, 2016 at 1:35 PM, Michael Han  wrote:
>
> > Eddie's mail contains lots of '=E2=80=8B'' which is unicode character
> > zero-width space, which might cause parsing trouble for some mail
> clients.
> >
> > On Wed, Oct 5, 2016 at 6:42 AM, Flavio Junqueira  wrote:
> >
> > > Dude, I'm just not able to parse your e-mail, did you write that on a
> > > phone or something?
> > >
> > > -Flavio
> > >
> > > > On 05 Oct 2016, at 03:54, Edward Ribeiro 
> > > wrote:
> > > >
> > > > Hi,
> > > >
> > > > The patch attached on ZOOKEEPER-2597 is a
> > > > ​straightforward adaptation of
> > > > Kafka's one. It takes care of merging Github PR into Apache git repo
> > and
> > > > ​ a​
> > > > subsequent closing of the PR on the GH side
> > > > ​ among other things (rewriting of commit messages, etc)​
> > > > . The current status is: the script needs to be reviewed/validated
> by a
> > > > committer.
> > > > ​It has been some time since I uploaded the patch, so I gonna do
> > another
> > > > pass through it in the meantime.​
> > > >
> > > >
> > > > ​T
> > > > here are some workflow issues beyond the scope of ZOOKEEPER-2597
> > > > ​ that need to be sorted out (IMO)​
> > > > :
> > > >
> > > > 1. The normal workflow is to open a JIRA ticket before doing any GH
> PR
> > > > ​, that is, no JIRA-less PRs.​
> > > > The PR should have a title of the form "ZOOKEEPER-: Title". This
> > will
> > > > trigger the Apache JIRA-Github integration and it's opening show up
> in
> > > the
> > > > JIRA ticket.
> > > >
> > > > 2.
> > > > ​OTOH, ​n
> > > > ot every Kafka PR needs a corresponding JIRA ticket
> > > > ​. ​
> > > > There are a class of PR
> > > > ​s​
> > > > with "MINOR"
> > > > ​ title​
> > > > that represent trivial code changes
> > > > ​ and "HOT-FIX" title that fix urgent, but simple bugs. Both​
> > > > bypass the JIRA creation step
> > > > ​, even tough they are still ​
> > > > subject to review
> > > > ​.​
> > > > It's worth adopting a similar approach for ZK project?
> > > >
> > > > 3. IIRC
> > > > ​ (didn't find any page to confirm)​
> > > > , Cassandra project encourages, but not 

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Excuse me guys!

I've written on Macbook Pro. No idea why GMail messed it up. I was only
able to see the strange characters when I pasted on a gist text area. The
previous message is below, but if anyone is still having trouble (I tried
to remove the weird character), I left a copy at:
https://gist.github.com/eribeiro/da2a6a6c9a508610d52d0755fae8352d

"Hi,

The patch attached on ZOOKEEPER-2597 is a straightforward adaptation of
Kafka's one. It takes care of merging Github PR into Apache git repo and a
subsequent closing of the PR on the GH side, among other things (rewriting
of commit messages, etc). The current status is: the script needs to be
reviewed/validated by a committer. It has been some time since I uploaded
the patch, so I gonna do another pass through it in the meantime.

There are some workflow issues beyond the scope of ZOOKEEPER-2597 that need
to be sorted out (IMO):

1. The normal workflow is to open a JIRA ticket before doing any GH PR,
that is, no JIRA-less PRs. The PR should have a title of the form
"ZOOKEEPER-: Title". This will trigger the Apache JIRA-Github
integration and it's opening show up in the JIRA ticket.

2. OTOH, not every Kafka PR needs a corresponding JIRA ticket. There are a
class of PRs with "MINOR" title that represent trivial code changes and
"HOT-FIX" title that fix urgent, but simple bugs. Both bypass the JIRA
creation step, even tough they are still subject to review. It's worth
adopting a similar approach for ZK project?

3. IIRC (didn't find any page to confirm), Cassandra project encourages,
but not demands, that contributors also upload a patch file to JIRA even in
the case of a GH PR (as to leave a audit trail, I guess). Or, at  least, C*
project leaves up to the contributors to either open a GH PR or upload the
patch file to JIRA.


+1 about having a 'paper trail' of review comments on JIRA and/or mailing
list (I would prefer the mailing list tbh). But as Michael and Flavio
pointed out, I never seen GH PR review **comments** being written back to
JIRA, at least not in Kafka, Cassandra or Solr projects, that I have
followed more closely.

Eddie"


On Wed, Oct 5, 2016 at 1:35 PM, Michael Han  wrote:

> Eddie's mail contains lots of '=E2=80=8B'' which is unicode character
> zero-width space, which might cause parsing trouble for some mail clients.
>
> On Wed, Oct 5, 2016 at 6:42 AM, Flavio Junqueira  wrote:
>
> > Dude, I'm just not able to parse your e-mail, did you write that on a
> > phone or something?
> >
> > -Flavio
> >
> > > On 05 Oct 2016, at 03:54, Edward Ribeiro 
> > wrote:
> > >
> > > Hi,
> > >
> > > The patch attached on ZOOKEEPER-2597 is a
> > > ​straightforward adaptation of
> > > Kafka's one. It takes care of merging Github PR into Apache git repo
> and
> > > ​ a​
> > > subsequent closing of the PR on the GH side
> > > ​ among other things (rewriting of commit messages, etc)​
> > > . The current status is: the script needs to be reviewed/validated by a
> > > committer.
> > > ​It has been some time since I uploaded the patch, so I gonna do
> another
> > > pass through it in the meantime.​
> > >
> > >
> > > ​T
> > > here are some workflow issues beyond the scope of ZOOKEEPER-2597
> > > ​ that need to be sorted out (IMO)​
> > > :
> > >
> > > 1. The normal workflow is to open a JIRA ticket before doing any GH PR
> > > ​, that is, no JIRA-less PRs.​
> > > The PR should have a title of the form "ZOOKEEPER-: Title". This
> will
> > > trigger the Apache JIRA-Github integration and it's opening show up in
> > the
> > > JIRA ticket.
> > >
> > > 2.
> > > ​OTOH, ​n
> > > ot every Kafka PR needs a corresponding JIRA ticket
> > > ​. ​
> > > There are a class of PR
> > > ​s​
> > > with "MINOR"
> > > ​ title​
> > > that represent trivial code changes
> > > ​ and "HOT-FIX" title that fix urgent, but simple bugs. Both​
> > > bypass the JIRA creation step
> > > ​, even tough they are still ​
> > > subject to review
> > > ​.​
> > > It's worth adopting a similar approach for ZK project?
> > >
> > > 3. IIRC
> > > ​ (didn't find any page to confirm)​
> > > , Cassandra project encourages, but not demands, that contributors also
> > > upload a patch file to JIRA even in the case of a GH PR
> > > ​ (as to leave a audit trail, I guess)​
> > > ​.​
> > > Or
> > > ​,​
> > > at
> > > ​ ​
> > > least
> > > ​,​
> > > ​C* project ​
> > > leave
> > > ​s​
> > > up to the contributor
> > > ​s​
> > > to either open a GH PR or upload the patch file
> > > ​ to JIRA. In fact, Github allows the access to a raw patch or diff,
> it's
> > > just a matter of adding the ".patch" or ".diff" suffix to the end of
> the
> > > Pull Request URL.
> > > ​
> > >
> > >
> > > +1 about having a 'paper trail'
> > > ​ of review comments​
> > >
> > > ​o​
> > > n JIRA and
> > > ​/or​
> > > mailing list (I
> > > ​ would​
> > > prefer the mailing list tbh). But as Michael and Flavio pointed out, I
> > > never seen
> > > ​GH ​
> > > PR review
> 

Re: [VOTE] move Apache Zookeeper to git

[Michael Han]

Eddie's mail contains lots of '=E2=80=8B'' which is unicode character
zero-width space, which might cause parsing trouble for some mail clients.

On Wed, Oct 5, 2016 at 6:42 AM, Flavio Junqueira  wrote:

> Dude, I'm just not able to parse your e-mail, did you write that on a
> phone or something?
>
> -Flavio
>
> > On 05 Oct 2016, at 03:54, Edward Ribeiro 
> wrote:
> >
> > Hi,
> >
> > The patch attached on ZOOKEEPER-2597 is a
> > ​straightforward adaptation of
> > Kafka's one. It takes care of merging Github PR into Apache git repo and
> > ​ a​
> > subsequent closing of the PR on the GH side
> > ​ among other things (rewriting of commit messages, etc)​
> > . The current status is: the script needs to be reviewed/validated by a
> > committer.
> > ​It has been some time since I uploaded the patch, so I gonna do another
> > pass through it in the meantime.​
> >
> >
> > ​T
> > here are some workflow issues beyond the scope of ZOOKEEPER-2597
> > ​ that need to be sorted out (IMO)​
> > :
> >
> > 1. The normal workflow is to open a JIRA ticket before doing any GH PR
> > ​, that is, no JIRA-less PRs.​
> > The PR should have a title of the form "ZOOKEEPER-: Title". This will
> > trigger the Apache JIRA-Github integration and it's opening show up in
> the
> > JIRA ticket.
> >
> > 2.
> > ​OTOH, ​n
> > ot every Kafka PR needs a corresponding JIRA ticket
> > ​. ​
> > There are a class of PR
> > ​s​
> > with "MINOR"
> > ​ title​
> > that represent trivial code changes
> > ​ and "HOT-FIX" title that fix urgent, but simple bugs. Both​
> > bypass the JIRA creation step
> > ​, even tough they are still ​
> > subject to review
> > ​.​
> > It's worth adopting a similar approach for ZK project?
> >
> > 3. IIRC
> > ​ (didn't find any page to confirm)​
> > , Cassandra project encourages, but not demands, that contributors also
> > upload a patch file to JIRA even in the case of a GH PR
> > ​ (as to leave a audit trail, I guess)​
> > ​.​
> > Or
> > ​,​
> > at
> > ​ ​
> > least
> > ​,​
> > ​C* project ​
> > leave
> > ​s​
> > up to the contributor
> > ​s​
> > to either open a GH PR or upload the patch file
> > ​ to JIRA. In fact, Github allows the access to a raw patch or diff, it's
> > just a matter of adding the ".patch" or ".diff" suffix to the end of the
> > Pull Request URL.
> > ​
> >
> >
> > +1 about having a 'paper trail'
> > ​ of review comments​
> >
> > ​o​
> > n JIRA and
> > ​/or​
> > mailing list (I
> > ​ would​
> > prefer the mailing list tbh). But as Michael and Flavio pointed out, I
> > never seen
> > ​GH ​
> > PR review
> > ​**​
> > comments
> > ​**​
> > being written back to JIRA, at least not in Kafka, Cassandra
> > ​or​
> > Solr projects
> > ​, that I have followed more closely.​
> >
> > Eddie
> >
> >
> > On Tue, Oct 4, 2016 at 6:40 PM, Michael Han  wrote:
> >
>  as long as the opening/closing/commenting all get sent to the mailing
> >> list or recorded in jira
> >> Yeah, this is my impression as well, that we need to keep certain paper
> >> trail regarding activities and comments on ASF side (JIRA or mail list).
> >> Infra page said:
> >>
> >>   - Any Pull Request that gets opened, closed, reopened or **commented**
> >>   on now gets recorded on the project's mailing list
> >>   - If a project has a JIRA instance, any PRs or *comments* on PRs that
> >>   include a JIRA ticket ID will trigger an update on that specific
> ticket
> >>
> >> I checked a couple Kafka and Spark JIRAs but I don't see any of the
> >> comments made in github PR were posted on JIRA, except the activities
> (open
> >> a PR, close a PR). Since both projects have been using github for a
> while I
> >> assume such practice of NOT integrating comments between github and ASF
> >> JIRA is acceptable? Though I feel it would be really useful if comments
> >> could converge in a single place as well, that will provide a clear
> history
> >> for a given technical issue.
> >>
> >> On Tue, Oct 4, 2016 at 12:06 PM, Flavio Junqueira 
> wrote:
> >>
> >>> Until ZOOKEEPER-2597  >> jira/browse/ZOOKEEPER-2597>
> >>> is fixed, we can't merge via github.
> >>>
> >>> For code reviews, we can use GH as long as the
> opening/closing/commenting
> >>> all get sent to the mailing list or recorded in jira. I don't think we
> >> have
> >>> that yet, but it is possible according to this:
> >>>
> >>> https://blogs.apache.org/infra/entry/improved_
> >>> integration_between_apache_and  >>> infra/entry/improved_integration_between_apache_and>
> >>>
> >>> For now, we do need to upload patches and converge using jira.
> >>>
> >>> I think Eddie has been looking at this process trying to replicate the
> >>> Kafka setup, so perhaps he can give an update if I'm right. Kafka
> doesn't
> >>> send every comment to the mailing list, though, but I'm not sure if
> >> that's
> >>> acceptable according to the ASF, I need to double-check.
> >>>
> 

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

Dude, I'm just not able to parse your e-mail, did you write that on a phone or 
something?

-Flavio

> On 05 Oct 2016, at 03:54, Edward Ribeiro  wrote:
> 
> Hi,
> 
> The patch attached on ZOOKEEPER-2597 is a
> ​straightforward adaptation of
> Kafka's one. It takes care of merging Github PR into Apache git repo and
> ​ a​
> subsequent closing of the PR on the GH side
> ​ among other things (rewriting of commit messages, etc)​
> . The current status is: the script needs to be reviewed/validated by a
> committer.
> ​It has been some time since I uploaded the patch, so I gonna do another
> pass through it in the meantime.​
> 
> 
> ​T
> here are some workflow issues beyond the scope of ZOOKEEPER-2597
> ​ that need to be sorted out (IMO)​
> :
> 
> 1. The normal workflow is to open a JIRA ticket before doing any GH PR
> ​, that is, no JIRA-less PRs.​
> The PR should have a title of the form "ZOOKEEPER-: Title". This will
> trigger the Apache JIRA-Github integration and it's opening show up in the
> JIRA ticket.
> 
> 2.
> ​OTOH, ​n
> ot every Kafka PR needs a corresponding JIRA ticket
> ​. ​
> There are a class of PR
> ​s​
> with "MINOR"
> ​ title​
> that represent trivial code changes
> ​ and "HOT-FIX" title that fix urgent, but simple bugs. Both​
> bypass the JIRA creation step
> ​, even tough they are still ​
> subject to review
> ​.​
> It's worth adopting a similar approach for ZK project?
> 
> 3. IIRC
> ​ (didn't find any page to confirm)​
> , Cassandra project encourages, but not demands, that contributors also
> upload a patch file to JIRA even in the case of a GH PR
> ​ (as to leave a audit trail, I guess)​
> ​.​
> Or
> ​,​
> at
> ​ ​
> least
> ​,​
> ​C* project ​
> leave
> ​s​
> up to the contributor
> ​s​
> to either open a GH PR or upload the patch file
> ​ to JIRA. In fact, Github allows the access to a raw patch or diff, it's
> just a matter of adding the ".patch" or ".diff" suffix to the end of the
> Pull Request URL.
> ​
> 
> 
> +1 about having a 'paper trail'
> ​ of review comments​
> 
> ​o​
> n JIRA and
> ​/or​
> mailing list (I
> ​ would​
> prefer the mailing list tbh). But as Michael and Flavio pointed out, I
> never seen
> ​GH ​
> PR review
> ​**​
> comments
> ​**​
> being written back to JIRA, at least not in Kafka, Cassandra
> ​or​
> Solr projects
> ​, that I have followed more closely.​
> 
> Eddie
> 
> 
> On Tue, Oct 4, 2016 at 6:40 PM, Michael Han  wrote:
> 
 as long as the opening/closing/commenting all get sent to the mailing
>> list or recorded in jira
>> Yeah, this is my impression as well, that we need to keep certain paper
>> trail regarding activities and comments on ASF side (JIRA or mail list).
>> Infra page said:
>> 
>>   - Any Pull Request that gets opened, closed, reopened or **commented**
>>   on now gets recorded on the project's mailing list
>>   - If a project has a JIRA instance, any PRs or *comments* on PRs that
>>   include a JIRA ticket ID will trigger an update on that specific ticket
>> 
>> I checked a couple Kafka and Spark JIRAs but I don't see any of the
>> comments made in github PR were posted on JIRA, except the activities (open
>> a PR, close a PR). Since both projects have been using github for a while I
>> assume such practice of NOT integrating comments between github and ASF
>> JIRA is acceptable? Though I feel it would be really useful if comments
>> could converge in a single place as well, that will provide a clear history
>> for a given technical issue.
>> 
>> On Tue, Oct 4, 2016 at 12:06 PM, Flavio Junqueira  wrote:
>> 
>>> Until ZOOKEEPER-2597 > jira/browse/ZOOKEEPER-2597>
>>> is fixed, we can't merge via github.
>>> 
>>> For code reviews, we can use GH as long as the opening/closing/commenting
>>> all get sent to the mailing list or recorded in jira. I don't think we
>> have
>>> that yet, but it is possible according to this:
>>> 
>>> https://blogs.apache.org/infra/entry/improved_
>>> integration_between_apache_and >> infra/entry/improved_integration_between_apache_and>
>>> 
>>> For now, we do need to upload patches and converge using jira.
>>> 
>>> I think Eddie has been looking at this process trying to replicate the
>>> Kafka setup, so perhaps he can give an update if I'm right. Kafka doesn't
>>> send every comment to the mailing list, though, but I'm not sure if
>> that's
>>> acceptable according to the ASF, I need to double-check.
>>> 
>>> -Flavio
>>> 
 On 04 Oct 2016, at 19:42, Michael Han  wrote:
 
 Hi,
 
 Now we've moved to git, what is the policy for uploading patches and
>>> doing
 code reviews? I am asking because I've seen recently there are git pull
 requests coming in without associated patch file uploaded to JIRA. I've
 checked
 https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute,
 looks like there is not much change regarding patch 

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

Apparently, infra allowed Kafka to not have comments written to the dev list or 
jira. There is a thread discussing whether that decision should be reverted or 
not. Not sure how much value it adds to this discussion, but it is good to have 
another reference:

http://mail-archives.apache.org/mod_mbox/kafka-dev/201510.mbox/%3cCAD5tkZaEmmpvS9-6w6KsubhW1ddrowgOYvLs=dhcvl2p2ky...@mail.gmail.com%3e
 


-Flavio

> On 04 Oct 2016, at 22:40, Michael Han  wrote:
> 
>>> as long as the opening/closing/commenting all get sent to the mailing
> list or recorded in jira
> Yeah, this is my impression as well, that we need to keep certain paper
> trail regarding activities and comments on ASF side (JIRA or mail list).
> Infra page said:
> 
>   - Any Pull Request that gets opened, closed, reopened or **commented**
>   on now gets recorded on the project's mailing list
>   - If a project has a JIRA instance, any PRs or *comments* on PRs that
>   include a JIRA ticket ID will trigger an update on that specific ticket
> 
> I checked a couple Kafka and Spark JIRAs but I don't see any of the
> comments made in github PR were posted on JIRA, except the activities (open
> a PR, close a PR). Since both projects have been using github for a while I
> assume such practice of NOT integrating comments between github and ASF
> JIRA is acceptable? Though I feel it would be really useful if comments
> could converge in a single place as well, that will provide a clear history
> for a given technical issue.
> 
> On Tue, Oct 4, 2016 at 12:06 PM, Flavio Junqueira  > wrote:
> 
>> Until ZOOKEEPER-2597 > >
>> is fixed, we can't merge via github.
>> 
>> For code reviews, we can use GH as long as the opening/closing/commenting
>> all get sent to the mailing list or recorded in jira. I don't think we have
>> that yet, but it is possible according to this:
>> 
>> https://blogs.apache.org/infra/entry/improved_ 
>> 
>> integration_between_apache_and > 
>> infra/entry/improved_integration_between_apache_and>
>> 
>> For now, we do need to upload patches and converge using jira.
>> 
>> I think Eddie has been looking at this process trying to replicate the
>> Kafka setup, so perhaps he can give an update if I'm right. Kafka doesn't
>> send every comment to the mailing list, though, but I'm not sure if that's
>> acceptable according to the ASF, I need to double-check.
>> 
>> -Flavio
>> 
>>> On 04 Oct 2016, at 19:42, Michael Han  wrote:
>>> 
>>> Hi,
>>> 
>>> Now we've moved to git, what is the policy for uploading patches and
>> doing
>>> code reviews? I am asking because I've seen recently there are git pull
>>> requests coming in without associated patch file uploaded to JIRA. I've
>>> checked
>>> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute,
>>> looks like there is not much change regarding patch process - so
>> presumably
>>> we still need to generate and upload patch file to JIRA for the record,
>>> while using github (maybe in addition of review board, or in the future
>>> with gerrit) to do code reviews?
>>> 
>>> 
>>> On Wed, Sep 21, 2016 at 6:05 AM, Edward Ribeiro <
>> edward.ribe...@gmail.com>
>>> wrote:
>>> 
 Cool, just open https://issues.apache.org/jira/browse/ZOOKEEPER-2597
 
 PS: I removed the REPO_HOME global variable.
 
 On Wed, Sep 21, 2016 at 6:53 AM, Flavio Junqueira 
>> wrote:
 
> Better to have that in the form of a pull request or diff.
> 
> REPO_HOME does seem to be unused.
> 
> -Flavio
> 
>> On 20 Sep 2016, at 18:57, Edward Ribeiro 
> wrote:
>> 
>> Hey, I have started porting the kafka-merge.py to work on ZK repos. I
> would
>> need someone to review it and help me test it now.
>> 
>> The files were uploaded below, but I will create a github repo yet
 today.
>> 
>> https://www.dropbox.com/sh/od8bet2574jttm3/
> AADv1DXTb8vfyVCmelFbYCEha?dl=0
>> 
>> I uploaded the kafka version script so that you can use diff or Meld
>> to
>> spot my changes, but feel free to grasp the original file here:
>> https://github.com/apache/kafka/blob/trunk/kafka-merge-pr.py
>> 
>> PS: It's just me or REPO_HOME env variable is not used anywhere in the
>> merge script???
>> 
>> Cheers,
>> Eddie
>> 
>> On Tue, Sep 20, 2016 at 12:19 PM, Patrick Hunt 
 wrote:
>> 
>>> On Mon, Sep 19, 2016 at 4:11 PM, Benjamin Reed 
> wrote:
>>> 
 what you are suggesting sounds good, 

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Hi,

The patch attached on ZOOKEEPER-2597 is a
​straightforward adaptation of
 Kafka's one. It takes care of merging Github PR into Apache git repo and
​ a​
subsequent closing of the PR on the GH side
​ among other things (rewriting of commit messages, etc)​
. The current status is: the script needs to be reviewed/validated by a
committer.
​It has been some time since I uploaded the patch, so I gonna do another
pass through it in the meantime.​


​T
here are some workflow issues beyond the scope of ZOOKEEPER-2597
​ that need to be sorted out (IMO)​
:

1. The normal workflow is to open a JIRA ticket before doing any GH PR
​, that is, no JIRA-less PRs.​
The PR should have a title of the form "ZOOKEEPER-: Title". This will
trigger the Apache JIRA-Github integration and it's opening show up in the
JIRA ticket.

2.
​OTOH, ​n
ot every Kafka PR needs a corresponding JIRA ticket
​. ​
There are a class of PR
​s​
with "MINOR"
​ title​
that represent trivial code changes
​ and "HOT-FIX" title that fix urgent, but simple bugs. Both​
 bypass the JIRA creation step
​, even tough they are still ​
subject to review
​.​
It's worth adopting a similar approach for ZK project?

3. IIRC
​ (didn't find any page to confirm)​
, Cassandra project encourages, but not demands, that contributors also
upload a patch file to JIRA even in the case of a GH PR
​ (as to leave a audit trail, I guess)​
​.​
Or
​,​
at
​ ​
least
​,​
​C* project ​
leave
​s​
 up to the contributor
​s​
to either open a GH PR or upload the patch file
​ to JIRA. In fact, Github allows the access to a raw patch or diff, it's
just a matter of adding the ".patch" or ".diff" suffix to the end of the
Pull Request URL.
​


+1 about having a 'paper trail'
​ of review comments​

​o​
n JIRA and
​/or​
mailing list (I
​ would​
prefer the mailing list tbh). But as Michael and Flavio pointed out, I
never seen
​GH ​
PR review
​**​
comments
​**​
being written back to JIRA, at least not in Kafka, Cassandra
​or​
 Solr projects
​, that I have followed more closely.​

Eddie


On Tue, Oct 4, 2016 at 6:40 PM, Michael Han  wrote:

> >> as long as the opening/closing/commenting all get sent to the mailing
> list or recorded in jira
> Yeah, this is my impression as well, that we need to keep certain paper
> trail regarding activities and comments on ASF side (JIRA or mail list).
> Infra page said:
>
>- Any Pull Request that gets opened, closed, reopened or **commented**
>on now gets recorded on the project's mailing list
>- If a project has a JIRA instance, any PRs or *comments* on PRs that
>include a JIRA ticket ID will trigger an update on that specific ticket
>
> I checked a couple Kafka and Spark JIRAs but I don't see any of the
> comments made in github PR were posted on JIRA, except the activities (open
> a PR, close a PR). Since both projects have been using github for a while I
> assume such practice of NOT integrating comments between github and ASF
> JIRA is acceptable? Though I feel it would be really useful if comments
> could converge in a single place as well, that will provide a clear history
> for a given technical issue.
>
> On Tue, Oct 4, 2016 at 12:06 PM, Flavio Junqueira  wrote:
>
> > Until ZOOKEEPER-2597  jira/browse/ZOOKEEPER-2597>
> > is fixed, we can't merge via github.
> >
> > For code reviews, we can use GH as long as the opening/closing/commenting
> > all get sent to the mailing list or recorded in jira. I don't think we
> have
> > that yet, but it is possible according to this:
> >
> > https://blogs.apache.org/infra/entry/improved_
> > integration_between_apache_and  > infra/entry/improved_integration_between_apache_and>
> >
> > For now, we do need to upload patches and converge using jira.
> >
> > I think Eddie has been looking at this process trying to replicate the
> > Kafka setup, so perhaps he can give an update if I'm right. Kafka doesn't
> > send every comment to the mailing list, though, but I'm not sure if
> that's
> > acceptable according to the ASF, I need to double-check.
> >
> > -Flavio
> >
> > > On 04 Oct 2016, at 19:42, Michael Han  wrote:
> > >
> > > Hi,
> > >
> > > Now we've moved to git, what is the policy for uploading patches and
> > doing
> > > code reviews? I am asking because I've seen recently there are git pull
> > > requests coming in without associated patch file uploaded to JIRA. I've
> > > checked
> > > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute,
> > > looks like there is not much change regarding patch process - so
> > presumably
> > > we still need to generate and upload patch file to JIRA for the record,
> > > while using github (maybe in addition of review board, or in the future
> > > with gerrit) to do code reviews?
> > >
> > >
> > > On Wed, Sep 21, 2016 at 6:05 AM, Edward Ribeiro <
> > edward.ribe...@gmail.com>
> > > wrote:
> > >
> > >> Cool, just open 

Re: [VOTE] move Apache Zookeeper to git

[Michael Han]

>> as long as the opening/closing/commenting all get sent to the mailing
list or recorded in jira
Yeah, this is my impression as well, that we need to keep certain paper
trail regarding activities and comments on ASF side (JIRA or mail list).
Infra page said:

   - Any Pull Request that gets opened, closed, reopened or **commented**
   on now gets recorded on the project's mailing list
   - If a project has a JIRA instance, any PRs or *comments* on PRs that
   include a JIRA ticket ID will trigger an update on that specific ticket

I checked a couple Kafka and Spark JIRAs but I don't see any of the
comments made in github PR were posted on JIRA, except the activities (open
a PR, close a PR). Since both projects have been using github for a while I
assume such practice of NOT integrating comments between github and ASF
JIRA is acceptable? Though I feel it would be really useful if comments
could converge in a single place as well, that will provide a clear history
for a given technical issue.

On Tue, Oct 4, 2016 at 12:06 PM, Flavio Junqueira  wrote:

> Until ZOOKEEPER-2597 
> is fixed, we can't merge via github.
>
> For code reviews, we can use GH as long as the opening/closing/commenting
> all get sent to the mailing list or recorded in jira. I don't think we have
> that yet, but it is possible according to this:
>
> https://blogs.apache.org/infra/entry/improved_
> integration_between_apache_and  infra/entry/improved_integration_between_apache_and>
>
> For now, we do need to upload patches and converge using jira.
>
> I think Eddie has been looking at this process trying to replicate the
> Kafka setup, so perhaps he can give an update if I'm right. Kafka doesn't
> send every comment to the mailing list, though, but I'm not sure if that's
> acceptable according to the ASF, I need to double-check.
>
> -Flavio
>
> > On 04 Oct 2016, at 19:42, Michael Han  wrote:
> >
> > Hi,
> >
> > Now we've moved to git, what is the policy for uploading patches and
> doing
> > code reviews? I am asking because I've seen recently there are git pull
> > requests coming in without associated patch file uploaded to JIRA. I've
> > checked
> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute,
> > looks like there is not much change regarding patch process - so
> presumably
> > we still need to generate and upload patch file to JIRA for the record,
> > while using github (maybe in addition of review board, or in the future
> > with gerrit) to do code reviews?
> >
> >
> > On Wed, Sep 21, 2016 at 6:05 AM, Edward Ribeiro <
> edward.ribe...@gmail.com>
> > wrote:
> >
> >> Cool, just open https://issues.apache.org/jira/browse/ZOOKEEPER-2597
> >>
> >> PS: I removed the REPO_HOME global variable.
> >>
> >> On Wed, Sep 21, 2016 at 6:53 AM, Flavio Junqueira 
> wrote:
> >>
> >>> Better to have that in the form of a pull request or diff.
> >>>
> >>> REPO_HOME does seem to be unused.
> >>>
> >>> -Flavio
> >>>
>  On 20 Sep 2016, at 18:57, Edward Ribeiro 
> >>> wrote:
> 
>  Hey, I have started porting the kafka-merge.py to work on ZK repos. I
> >>> would
>  need someone to review it and help me test it now.
> 
>  The files were uploaded below, but I will create a github repo yet
> >> today.
> 
>  https://www.dropbox.com/sh/od8bet2574jttm3/
> >>> AADv1DXTb8vfyVCmelFbYCEha?dl=0
> 
>  I uploaded the kafka version script so that you can use diff or Meld
> to
>  spot my changes, but feel free to grasp the original file here:
>  https://github.com/apache/kafka/blob/trunk/kafka-merge-pr.py
> 
>  PS: It's just me or REPO_HOME env variable is not used anywhere in the
>  merge script???
> 
>  Cheers,
>  Eddie
> 
>  On Tue, Sep 20, 2016 at 12:19 PM, Patrick Hunt 
> >> wrote:
> 
> > On Mon, Sep 19, 2016 at 4:11 PM, Benjamin Reed 
> >>> wrote:
> >
> >> what you are suggesting sounds good, but i don't know how to do it?
> >>> since
> >> in the end we are still just accepting diffs on patches, the only
> >> thing
> >> that changes is that we use svn rather than git right?
> >>
> >>
> > Notice the workflow Kafka uses - which includes "git apply" and
> >>> specifying
> > the author tag when committers commit (so that the OP gets proper
> > attribution in the commit itself)
> >
> > https://cwiki.apache.org/confluence/display/KAFKA/
> >>> Manual+Commit+Workflow
> >
> > Patrick
> >
> >
> >
> >> i LOVE chris's idea! lets do it!
> >>
> >> ben
> >>
> >> On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt 
> >>> wrote:
> >>
> >>> Ben, do you also want to update the "Applying a patch" section to
> >> make
> > it
> >>> git specific?
> >>>
> >>> We 

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

Until ZOOKEEPER-2597  is 
fixed, we can't merge via github.

For code reviews, we can use GH as long as the opening/closing/commenting all 
get sent to the mailing list or recorded in jira. I don't think we have that 
yet, but it is possible according to this:

https://blogs.apache.org/infra/entry/improved_integration_between_apache_and 


For now, we do need to upload patches and converge using jira.

I think Eddie has been looking at this process trying to replicate the Kafka 
setup, so perhaps he can give an update if I'm right. Kafka doesn't send every 
comment to the mailing list, though, but I'm not sure if that's acceptable 
according to the ASF, I need to double-check.

-Flavio

> On 04 Oct 2016, at 19:42, Michael Han  wrote:
> 
> Hi,
> 
> Now we've moved to git, what is the policy for uploading patches and doing
> code reviews? I am asking because I've seen recently there are git pull
> requests coming in without associated patch file uploaded to JIRA. I've
> checked
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute,
> looks like there is not much change regarding patch process - so presumably
> we still need to generate and upload patch file to JIRA for the record,
> while using github (maybe in addition of review board, or in the future
> with gerrit) to do code reviews?
> 
> 
> On Wed, Sep 21, 2016 at 6:05 AM, Edward Ribeiro 
> wrote:
> 
>> Cool, just open https://issues.apache.org/jira/browse/ZOOKEEPER-2597
>> 
>> PS: I removed the REPO_HOME global variable.
>> 
>> On Wed, Sep 21, 2016 at 6:53 AM, Flavio Junqueira  wrote:
>> 
>>> Better to have that in the form of a pull request or diff.
>>> 
>>> REPO_HOME does seem to be unused.
>>> 
>>> -Flavio
>>> 
 On 20 Sep 2016, at 18:57, Edward Ribeiro 
>>> wrote:
 
 Hey, I have started porting the kafka-merge.py to work on ZK repos. I
>>> would
 need someone to review it and help me test it now.
 
 The files were uploaded below, but I will create a github repo yet
>> today.
 
 https://www.dropbox.com/sh/od8bet2574jttm3/
>>> AADv1DXTb8vfyVCmelFbYCEha?dl=0
 
 I uploaded the kafka version script so that you can use diff or Meld to
 spot my changes, but feel free to grasp the original file here:
 https://github.com/apache/kafka/blob/trunk/kafka-merge-pr.py
 
 PS: It's just me or REPO_HOME env variable is not used anywhere in the
 merge script???
 
 Cheers,
 Eddie
 
 On Tue, Sep 20, 2016 at 12:19 PM, Patrick Hunt 
>> wrote:
 
> On Mon, Sep 19, 2016 at 4:11 PM, Benjamin Reed 
>>> wrote:
> 
>> what you are suggesting sounds good, but i don't know how to do it?
>>> since
>> in the end we are still just accepting diffs on patches, the only
>> thing
>> that changes is that we use svn rather than git right?
>> 
>> 
> Notice the workflow Kafka uses - which includes "git apply" and
>>> specifying
> the author tag when committers commit (so that the OP gets proper
> attribution in the commit itself)
> 
> https://cwiki.apache.org/confluence/display/KAFKA/
>>> Manual+Commit+Workflow
> 
> Patrick
> 
> 
> 
>> i LOVE chris's idea! lets do it!
>> 
>> ben
>> 
>> On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt 
>>> wrote:
>> 
>>> Ben, do you also want to update the "Applying a patch" section to
>> make
> it
>>> git specific?
>>> 
>>> We (committers) should move to a model where authors get proper
>> credit
> in
>>> git. Our old workflow in svn resulted in only the committer being
> listed
>>> (except that we listed the patch author in the commit message). We
> should
>>> move to a model where the author of the patch gets proper credit in
> git.
>> I
>>> believe we will get that if we use git for patch
>> creation/application?
>>> 
>>> Chris brought up getting rid of CHANGES.txt recently on the dev list
> in a
>>> separate thread - Chris do you want to implement that change now
>> that
>> we've
>>> moved to git?
>>> 
>>> Patrick
>>> 
>>> On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed 
> wrote:
>>> 
> 1) actually in the previous step that was just adding new files.
>> you
> still
>> need the commit -a for the rest of the changes. that's my normal
> workflow.
> 
> I think that will be confusing for most folks. They typically
>> stage
> all the changes and then commit or don't stage and use -a.
> 
 
 do you mind fixing it with your workflow. commit -a doesn't get new
 files, which is why you need to do the 

Re: [VOTE] move Apache Zookeeper to git

[Michael Han]

Hi,

Now we've moved to git, what is the policy for uploading patches and doing
code reviews? I am asking because I've seen recently there are git pull
requests coming in without associated patch file uploaded to JIRA. I've
checked
https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute,
looks like there is not much change regarding patch process - so presumably
we still need to generate and upload patch file to JIRA for the record,
while using github (maybe in addition of review board, or in the future
with gerrit) to do code reviews?


On Wed, Sep 21, 2016 at 6:05 AM, Edward Ribeiro 
wrote:

> Cool, just open https://issues.apache.org/jira/browse/ZOOKEEPER-2597
>
> PS: I removed the REPO_HOME global variable.
>
> On Wed, Sep 21, 2016 at 6:53 AM, Flavio Junqueira  wrote:
>
> > Better to have that in the form of a pull request or diff.
> >
> > REPO_HOME does seem to be unused.
> >
> > -Flavio
> >
> > > On 20 Sep 2016, at 18:57, Edward Ribeiro 
> > wrote:
> > >
> > > Hey, I have started porting the kafka-merge.py to work on ZK repos. I
> > would
> > > need someone to review it and help me test it now.
> > >
> > > The files were uploaded below, but I will create a github repo yet
> today.
> > >
> > > https://www.dropbox.com/sh/od8bet2574jttm3/
> > AADv1DXTb8vfyVCmelFbYCEha?dl=0
> > >
> > > I uploaded the kafka version script so that you can use diff or Meld to
> > > spot my changes, but feel free to grasp the original file here:
> > > https://github.com/apache/kafka/blob/trunk/kafka-merge-pr.py
> > >
> > > PS: It's just me or REPO_HOME env variable is not used anywhere in the
> > > merge script???
> > >
> > > Cheers,
> > > Eddie
> > >
> > > On Tue, Sep 20, 2016 at 12:19 PM, Patrick Hunt 
> wrote:
> > >
> > >> On Mon, Sep 19, 2016 at 4:11 PM, Benjamin Reed 
> > wrote:
> > >>
> > >>> what you are suggesting sounds good, but i don't know how to do it?
> > since
> > >>> in the end we are still just accepting diffs on patches, the only
> thing
> > >>> that changes is that we use svn rather than git right?
> > >>>
> > >>>
> > >> Notice the workflow Kafka uses - which includes "git apply" and
> > specifying
> > >> the author tag when committers commit (so that the OP gets proper
> > >> attribution in the commit itself)
> > >>
> > >> https://cwiki.apache.org/confluence/display/KAFKA/
> > Manual+Commit+Workflow
> > >>
> > >> Patrick
> > >>
> > >>
> > >>
> > >>> i LOVE chris's idea! lets do it!
> > >>>
> > >>> ben
> > >>>
> > >>> On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt 
> > wrote:
> > >>>
> >  Ben, do you also want to update the "Applying a patch" section to
> make
> > >> it
> >  git specific?
> > 
> >  We (committers) should move to a model where authors get proper
> credit
> > >> in
> >  git. Our old workflow in svn resulted in only the committer being
> > >> listed
> >  (except that we listed the patch author in the commit message). We
> > >> should
> >  move to a model where the author of the patch gets proper credit in
> > >> git.
> > >>> I
> >  believe we will get that if we use git for patch
> creation/application?
> > 
> >  Chris brought up getting rid of CHANGES.txt recently on the dev list
> > >> in a
> >  separate thread - Chris do you want to implement that change now
> that
> > >>> we've
> >  moved to git?
> > 
> >  Patrick
> > 
> >  On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed 
> > >> wrote:
> > 
> > >> 1) actually in the previous step that was just adding new files.
> you
> > >> still
> > >>> need the commit -a for the rest of the changes. that's my normal
> > >> workflow.
> > >>
> > >> I think that will be confusing for most folks. They typically
> stage
> > >> all the changes and then commit or don't stage and use -a.
> > >>
> > >
> > > do you mind fixing it with your workflow. commit -a doesn't get new
> > > files, which is why you need to do the add, but i'm not the most
> > > sophisticated git user, so
> > >
> > >
> > >>
> > >>> 2) i figured since we are using git now that we should use git's
> > >> default.
> > >>> the patch should work (by default it seems to strip the first
> path
> > >> element).
> > >>> does it not work for you?
> > >>>
> > >>
> > >> It will fail precommit in it's current state.
> > >>
> > >
> > > fixed
> > >
> > 
> > 
> > >>>
> > >>
> >
> >
>



-- 
Cheers
Michael.

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Cool, just open https://issues.apache.org/jira/browse/ZOOKEEPER-2597

PS: I removed the REPO_HOME global variable.

On Wed, Sep 21, 2016 at 6:53 AM, Flavio Junqueira  wrote:

> Better to have that in the form of a pull request or diff.
>
> REPO_HOME does seem to be unused.
>
> -Flavio
>
> > On 20 Sep 2016, at 18:57, Edward Ribeiro 
> wrote:
> >
> > Hey, I have started porting the kafka-merge.py to work on ZK repos. I
> would
> > need someone to review it and help me test it now.
> >
> > The files were uploaded below, but I will create a github repo yet today.
> >
> > https://www.dropbox.com/sh/od8bet2574jttm3/
> AADv1DXTb8vfyVCmelFbYCEha?dl=0
> >
> > I uploaded the kafka version script so that you can use diff or Meld to
> > spot my changes, but feel free to grasp the original file here:
> > https://github.com/apache/kafka/blob/trunk/kafka-merge-pr.py
> >
> > PS: It's just me or REPO_HOME env variable is not used anywhere in the
> > merge script???
> >
> > Cheers,
> > Eddie
> >
> > On Tue, Sep 20, 2016 at 12:19 PM, Patrick Hunt  wrote:
> >
> >> On Mon, Sep 19, 2016 at 4:11 PM, Benjamin Reed 
> wrote:
> >>
> >>> what you are suggesting sounds good, but i don't know how to do it?
> since
> >>> in the end we are still just accepting diffs on patches, the only thing
> >>> that changes is that we use svn rather than git right?
> >>>
> >>>
> >> Notice the workflow Kafka uses - which includes "git apply" and
> specifying
> >> the author tag when committers commit (so that the OP gets proper
> >> attribution in the commit itself)
> >>
> >> https://cwiki.apache.org/confluence/display/KAFKA/
> Manual+Commit+Workflow
> >>
> >> Patrick
> >>
> >>
> >>
> >>> i LOVE chris's idea! lets do it!
> >>>
> >>> ben
> >>>
> >>> On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt 
> wrote:
> >>>
>  Ben, do you also want to update the "Applying a patch" section to make
> >> it
>  git specific?
> 
>  We (committers) should move to a model where authors get proper credit
> >> in
>  git. Our old workflow in svn resulted in only the committer being
> >> listed
>  (except that we listed the patch author in the commit message). We
> >> should
>  move to a model where the author of the patch gets proper credit in
> >> git.
> >>> I
>  believe we will get that if we use git for patch creation/application?
> 
>  Chris brought up getting rid of CHANGES.txt recently on the dev list
> >> in a
>  separate thread - Chris do you want to implement that change now that
> >>> we've
>  moved to git?
> 
>  Patrick
> 
>  On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed 
> >> wrote:
> 
> >> 1) actually in the previous step that was just adding new files. you
> >> still
> >>> need the commit -a for the rest of the changes. that's my normal
> >> workflow.
> >>
> >> I think that will be confusing for most folks. They typically stage
> >> all the changes and then commit or don't stage and use -a.
> >>
> >
> > do you mind fixing it with your workflow. commit -a doesn't get new
> > files, which is why you need to do the add, but i'm not the most
> > sophisticated git user, so
> >
> >
> >>
> >>> 2) i figured since we are using git now that we should use git's
> >> default.
> >>> the patch should work (by default it seems to strip the first path
> >> element).
> >>> does it not work for you?
> >>>
> >>
> >> It will fail precommit in it's current state.
> >>
> >
> > fixed
> >
> 
> 
> >>>
> >>
>
>

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

Better to have that in the form of a pull request or diff. 

REPO_HOME does seem to be unused.

-Flavio

> On 20 Sep 2016, at 18:57, Edward Ribeiro  wrote:
> 
> Hey, I have started porting the kafka-merge.py to work on ZK repos. I would
> need someone to review it and help me test it now.
> 
> The files were uploaded below, but I will create a github repo yet today.
> 
> https://www.dropbox.com/sh/od8bet2574jttm3/AADv1DXTb8vfyVCmelFbYCEha?dl=0
> 
> I uploaded the kafka version script so that you can use diff or Meld to
> spot my changes, but feel free to grasp the original file here:
> https://github.com/apache/kafka/blob/trunk/kafka-merge-pr.py
> 
> PS: It's just me or REPO_HOME env variable is not used anywhere in the
> merge script???
> 
> Cheers,
> Eddie
> 
> On Tue, Sep 20, 2016 at 12:19 PM, Patrick Hunt  wrote:
> 
>> On Mon, Sep 19, 2016 at 4:11 PM, Benjamin Reed  wrote:
>> 
>>> what you are suggesting sounds good, but i don't know how to do it? since
>>> in the end we are still just accepting diffs on patches, the only thing
>>> that changes is that we use svn rather than git right?
>>> 
>>> 
>> Notice the workflow Kafka uses - which includes "git apply" and specifying
>> the author tag when committers commit (so that the OP gets proper
>> attribution in the commit itself)
>> 
>> https://cwiki.apache.org/confluence/display/KAFKA/Manual+Commit+Workflow
>> 
>> Patrick
>> 
>> 
>> 
>>> i LOVE chris's idea! lets do it!
>>> 
>>> ben
>>> 
>>> On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt  wrote:
>>> 
 Ben, do you also want to update the "Applying a patch" section to make
>> it
 git specific?
 
 We (committers) should move to a model where authors get proper credit
>> in
 git. Our old workflow in svn resulted in only the committer being
>> listed
 (except that we listed the patch author in the commit message). We
>> should
 move to a model where the author of the patch gets proper credit in
>> git.
>>> I
 believe we will get that if we use git for patch creation/application?
 
 Chris brought up getting rid of CHANGES.txt recently on the dev list
>> in a
 separate thread - Chris do you want to implement that change now that
>>> we've
 moved to git?
 
 Patrick
 
 On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed 
>> wrote:
 
>> 1) actually in the previous step that was just adding new files. you
>> still
>>> need the commit -a for the rest of the changes. that's my normal
>> workflow.
>> 
>> I think that will be confusing for most folks. They typically stage
>> all the changes and then commit or don't stage and use -a.
>> 
> 
> do you mind fixing it with your workflow. commit -a doesn't get new
> files, which is why you need to do the add, but i'm not the most
> sophisticated git user, so
> 
> 
>> 
>>> 2) i figured since we are using git now that we should use git's
>> default.
>>> the patch should work (by default it seems to strip the first path
>> element).
>>> does it not work for you?
>>> 
>> 
>> It will fail precommit in it's current state.
>> 
> 
> fixed
> 
 
 
>>> 
>> 

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Hey, I have started porting the kafka-merge.py to work on ZK repos. I would
need someone to review it and help me test it now.

The files were uploaded below, but I will create a github repo yet today.

https://www.dropbox.com/sh/od8bet2574jttm3/AADv1DXTb8vfyVCmelFbYCEha?dl=0

I uploaded the kafka version script so that you can use diff or Meld to
spot my changes, but feel free to grasp the original file here:
https://github.com/apache/kafka/blob/trunk/kafka-merge-pr.py

PS: It's just me or REPO_HOME env variable is not used anywhere in the
merge script???

Cheers,
Eddie

On Tue, Sep 20, 2016 at 12:19 PM, Patrick Hunt  wrote:

> On Mon, Sep 19, 2016 at 4:11 PM, Benjamin Reed  wrote:
>
> > what you are suggesting sounds good, but i don't know how to do it? since
> > in the end we are still just accepting diffs on patches, the only thing
> > that changes is that we use svn rather than git right?
> >
> >
> Notice the workflow Kafka uses - which includes "git apply" and specifying
> the author tag when committers commit (so that the OP gets proper
> attribution in the commit itself)
>
> https://cwiki.apache.org/confluence/display/KAFKA/Manual+Commit+Workflow
>
> Patrick
>
>
>
> > i LOVE chris's idea! lets do it!
> >
> > ben
> >
> > On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt  wrote:
> >
> > > Ben, do you also want to update the "Applying a patch" section to make
> it
> > > git specific?
> > >
> > > We (committers) should move to a model where authors get proper credit
> in
> > > git. Our old workflow in svn resulted in only the committer being
> listed
> > > (except that we listed the patch author in the commit message). We
> should
> > > move to a model where the author of the patch gets proper credit in
> git.
> > I
> > > believe we will get that if we use git for patch creation/application?
> > >
> > > Chris brought up getting rid of CHANGES.txt recently on the dev list
> in a
> > > separate thread - Chris do you want to implement that change now that
> > we've
> > > moved to git?
> > >
> > > Patrick
> > >
> > > On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed 
> wrote:
> > >
> > >> > 1) actually in the previous step that was just adding new files. you
> > >>> still
> > >>> > need the commit -a for the rest of the changes. that's my normal
> > >>> workflow.
> > >>>
> > >>> I think that will be confusing for most folks. They typically stage
> > >>> all the changes and then commit or don't stage and use -a.
> > >>>
> > >>
> > >> do you mind fixing it with your workflow. commit -a doesn't get new
> > >> files, which is why you need to do the add, but i'm not the most
> > >> sophisticated git user, so
> > >>
> > >>
> > >>>
> > >>> > 2) i figured since we are using git now that we should use git's
> > >>> default.
> > >>> > the patch should work (by default it seems to strip the first path
> > >>> element).
> > >>> > does it not work for you?
> > >>> >
> > >>>
> > >>> It will fail precommit in it's current state.
> > >>>
> > >>
> > >> fixed
> > >>
> > >
> > >
> >
>

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

On Mon, Sep 19, 2016 at 4:11 PM, Benjamin Reed  wrote:

> what you are suggesting sounds good, but i don't know how to do it? since
> in the end we are still just accepting diffs on patches, the only thing
> that changes is that we use svn rather than git right?
>
>
Notice the workflow Kafka uses - which includes "git apply" and specifying
the author tag when committers commit (so that the OP gets proper
attribution in the commit itself)

https://cwiki.apache.org/confluence/display/KAFKA/Manual+Commit+Workflow

Patrick



> i LOVE chris's idea! lets do it!
>
> ben
>
> On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt  wrote:
>
> > Ben, do you also want to update the "Applying a patch" section to make it
> > git specific?
> >
> > We (committers) should move to a model where authors get proper credit in
> > git. Our old workflow in svn resulted in only the committer being listed
> > (except that we listed the patch author in the commit message). We should
> > move to a model where the author of the patch gets proper credit in git.
> I
> > believe we will get that if we use git for patch creation/application?
> >
> > Chris brought up getting rid of CHANGES.txt recently on the dev list in a
> > separate thread - Chris do you want to implement that change now that
> we've
> > moved to git?
> >
> > Patrick
> >
> > On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed  wrote:
> >
> >> > 1) actually in the previous step that was just adding new files. you
> >>> still
> >>> > need the commit -a for the rest of the changes. that's my normal
> >>> workflow.
> >>>
> >>> I think that will be confusing for most folks. They typically stage
> >>> all the changes and then commit or don't stage and use -a.
> >>>
> >>
> >> do you mind fixing it with your workflow. commit -a doesn't get new
> >> files, which is why you need to do the add, but i'm not the most
> >> sophisticated git user, so
> >>
> >>
> >>>
> >>> > 2) i figured since we are using git now that we should use git's
> >>> default.
> >>> > the patch should work (by default it seems to strip the first path
> >>> element).
> >>> > does it not work for you?
> >>> >
> >>>
> >>> It will fail precommit in it's current state.
> >>>
> >>
> >> fixed
> >>
> >
> >
>

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

Interesting, still works for me copying and pasting from the message.

-Flavio

> On 20 Sep 2016, at 16:11, Patrick Hunt  wrote:
> 
> I'm afraid that link doesn't work for me, updated link:
> http://markmail.org/message/4engzfzfpjd42smp
> 
> Patrick
> 
> On Tue, Sep 20, 2016 at 5:51 AM, Flavio Junqueira  wrote:
> 
>> This is the mail thread where Chris raised it:
>> 
>> http://mail-archives.apache.org/mod_mbox//zookeeper-dev/
>> 201607.mbox/%3cd3b6a1e8.4977a%25cnaur...@hortonworks.com%3e
>> 
>> -Flavio
>> 
>> On 20 Sep 2016, at 13:13, Edward Ribeiro  wrote:
>> 
>> Just out of curiosity, what's the motivation behind getting rid of
>> CHANGES.txt?
>> 
>> Eddie
>> 
>> On Mon, Sep 19, 2016 at 8:11 PM, Benjamin Reed  wrote:
>> 
>> what you are suggesting sounds good, but i don't know how to do it? since
>> in the end we are still just accepting diffs on patches, the only thing
>> that changes is that we use svn rather than git right?
>> 
>> i LOVE chris's idea! lets do it!
>> 
>> ben
>> 
>> On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt  wrote:
>> 
>> Ben, do you also want to update the "Applying a patch" section to make it
>> git specific?
>> 
>> We (committers) should move to a model where authors get proper credit in
>> git. Our old workflow in svn resulted in only the committer being listed
>> (except that we listed the patch author in the commit message). We should
>> move to a model where the author of the patch gets proper credit in git.
>> 
>> I
>> 
>> believe we will get that if we use git for patch creation/application?
>> 
>> Chris brought up getting rid of CHANGES.txt recently on the dev list in a
>> separate thread - Chris do you want to implement that change now that
>> 
>> we've
>> 
>> moved to git?
>> 
>> Patrick
>> 
>> On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed  wrote:
>> 
>> 1) actually in the previous step that was just adding new files. you
>> still
>> 
>> need the commit -a for the rest of the changes. that's my normal
>> 
>> workflow.
>> 
>> I think that will be confusing for most folks. They typically stage
>> all the changes and then commit or don't stage and use -a.
>> 
>> 
>> do you mind fixing it with your workflow. commit -a doesn't get new
>> files, which is why you need to do the add, but i'm not the most
>> sophisticated git user, so
>> 
>> 
>> 
>> 2) i figured since we are using git now that we should use git's
>> 
>> default.
>> 
>> the patch should work (by default it seems to strip the first path
>> 
>> element).
>> 
>> does it not work for you?
>> 
>> 
>> It will fail precommit in it's current state.
>> 
>> 
>> fixed
>> 
>> 
>> 
>> 
>> 
>> 

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

I'm afraid that link doesn't work for me, updated link:
http://markmail.org/message/4engzfzfpjd42smp

Patrick

On Tue, Sep 20, 2016 at 5:51 AM, Flavio Junqueira  wrote:

> This is the mail thread where Chris raised it:
>
> http://mail-archives.apache.org/mod_mbox//zookeeper-dev/
> 201607.mbox/%3cd3b6a1e8.4977a%25cnaur...@hortonworks.com%3e
>
> -Flavio
>
> On 20 Sep 2016, at 13:13, Edward Ribeiro  wrote:
>
> Just out of curiosity, what's the motivation behind getting rid of
> CHANGES.txt?
>
> Eddie
>
> On Mon, Sep 19, 2016 at 8:11 PM, Benjamin Reed  wrote:
>
> what you are suggesting sounds good, but i don't know how to do it? since
> in the end we are still just accepting diffs on patches, the only thing
> that changes is that we use svn rather than git right?
>
> i LOVE chris's idea! lets do it!
>
> ben
>
> On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt  wrote:
>
> Ben, do you also want to update the "Applying a patch" section to make it
> git specific?
>
> We (committers) should move to a model where authors get proper credit in
> git. Our old workflow in svn resulted in only the committer being listed
> (except that we listed the patch author in the commit message). We should
> move to a model where the author of the patch gets proper credit in git.
>
> I
>
> believe we will get that if we use git for patch creation/application?
>
> Chris brought up getting rid of CHANGES.txt recently on the dev list in a
> separate thread - Chris do you want to implement that change now that
>
> we've
>
> moved to git?
>
> Patrick
>
> On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed  wrote:
>
> 1) actually in the previous step that was just adding new files. you
> still
>
> need the commit -a for the rest of the changes. that's my normal
>
> workflow.
>
> I think that will be confusing for most folks. They typically stage
> all the changes and then commit or don't stage and use -a.
>
>
> do you mind fixing it with your workflow. commit -a doesn't get new
> files, which is why you need to do the add, but i'm not the most
> sophisticated git user, so
>
>
>
> 2) i figured since we are using git now that we should use git's
>
> default.
>
> the patch should work (by default it seems to strip the first path
>
> element).
>
> does it not work for you?
>
>
> It will fail precommit in it's current state.
>
>
> fixed
>
>
>
>
>
>

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

This is the mail thread where Chris raised it:

http://mail-archives.apache.org/mod_mbox//zookeeper-dev/201607.mbox/%3cd3b6a1e8.4977a%25cnaur...@hortonworks.com%3e
 


-Flavio

> On 20 Sep 2016, at 13:13, Edward Ribeiro  wrote:
> 
> Just out of curiosity, what's the motivation behind getting rid of
> CHANGES.txt?
> 
> Eddie
> 
> On Mon, Sep 19, 2016 at 8:11 PM, Benjamin Reed  wrote:
> 
>> what you are suggesting sounds good, but i don't know how to do it? since
>> in the end we are still just accepting diffs on patches, the only thing
>> that changes is that we use svn rather than git right?
>> 
>> i LOVE chris's idea! lets do it!
>> 
>> ben
>> 
>> On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt  wrote:
>> 
>>> Ben, do you also want to update the "Applying a patch" section to make it
>>> git specific?
>>> 
>>> We (committers) should move to a model where authors get proper credit in
>>> git. Our old workflow in svn resulted in only the committer being listed
>>> (except that we listed the patch author in the commit message). We should
>>> move to a model where the author of the patch gets proper credit in git.
>> I
>>> believe we will get that if we use git for patch creation/application?
>>> 
>>> Chris brought up getting rid of CHANGES.txt recently on the dev list in a
>>> separate thread - Chris do you want to implement that change now that
>> we've
>>> moved to git?
>>> 
>>> Patrick
>>> 
>>> On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed  wrote:
>>> 
> 1) actually in the previous step that was just adding new files. you
> still
>> need the commit -a for the rest of the changes. that's my normal
> workflow.
> 
> I think that will be confusing for most folks. They typically stage
> all the changes and then commit or don't stage and use -a.
> 
 
 do you mind fixing it with your workflow. commit -a doesn't get new
 files, which is why you need to do the add, but i'm not the most
 sophisticated git user, so
 
 
> 
>> 2) i figured since we are using git now that we should use git's
> default.
>> the patch should work (by default it seems to strip the first path
> element).
>> does it not work for you?
>> 
> 
> It will fail precommit in it's current state.
> 
 
 fixed
 
>>> 
>>> 
>> 

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Just out of curiosity, what's the motivation behind getting rid of
CHANGES.txt?

Eddie

On Mon, Sep 19, 2016 at 8:11 PM, Benjamin Reed  wrote:

> what you are suggesting sounds good, but i don't know how to do it? since
> in the end we are still just accepting diffs on patches, the only thing
> that changes is that we use svn rather than git right?
>
> i LOVE chris's idea! lets do it!
>
> ben
>
> On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt  wrote:
>
> > Ben, do you also want to update the "Applying a patch" section to make it
> > git specific?
> >
> > We (committers) should move to a model where authors get proper credit in
> > git. Our old workflow in svn resulted in only the committer being listed
> > (except that we listed the patch author in the commit message). We should
> > move to a model where the author of the patch gets proper credit in git.
> I
> > believe we will get that if we use git for patch creation/application?
> >
> > Chris brought up getting rid of CHANGES.txt recently on the dev list in a
> > separate thread - Chris do you want to implement that change now that
> we've
> > moved to git?
> >
> > Patrick
> >
> > On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed  wrote:
> >
> >> > 1) actually in the previous step that was just adding new files. you
> >>> still
> >>> > need the commit -a for the rest of the changes. that's my normal
> >>> workflow.
> >>>
> >>> I think that will be confusing for most folks. They typically stage
> >>> all the changes and then commit or don't stage and use -a.
> >>>
> >>
> >> do you mind fixing it with your workflow. commit -a doesn't get new
> >> files, which is why you need to do the add, but i'm not the most
> >> sophisticated git user, so
> >>
> >>
> >>>
> >>> > 2) i figured since we are using git now that we should use git's
> >>> default.
> >>> > the patch should work (by default it seems to strip the first path
> >>> element).
> >>> > does it not work for you?
> >>> >
> >>>
> >>> It will fail precommit in it's current state.
> >>>
> >>
> >> fixed
> >>
> >
> >
>

Re: [VOTE] move Apache Zookeeper to git

[Benjamin Reed]

what you are suggesting sounds good, but i don't know how to do it? since
in the end we are still just accepting diffs on patches, the only thing
that changes is that we use svn rather than git right?

i LOVE chris's idea! lets do it!

ben

On Sun, Sep 18, 2016 at 3:22 PM, Patrick Hunt  wrote:

> Ben, do you also want to update the "Applying a patch" section to make it
> git specific?
>
> We (committers) should move to a model where authors get proper credit in
> git. Our old workflow in svn resulted in only the committer being listed
> (except that we listed the patch author in the commit message). We should
> move to a model where the author of the patch gets proper credit in git. I
> believe we will get that if we use git for patch creation/application?
>
> Chris brought up getting rid of CHANGES.txt recently on the dev list in a
> separate thread - Chris do you want to implement that change now that we've
> moved to git?
>
> Patrick
>
> On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed  wrote:
>
>> > 1) actually in the previous step that was just adding new files. you
>>> still
>>> > need the commit -a for the rest of the changes. that's my normal
>>> workflow.
>>>
>>> I think that will be confusing for most folks. They typically stage
>>> all the changes and then commit or don't stage and use -a.
>>>
>>
>> do you mind fixing it with your workflow. commit -a doesn't get new
>> files, which is why you need to do the add, but i'm not the most
>> sophisticated git user, so
>>
>>
>>>
>>> > 2) i figured since we are using git now that we should use git's
>>> default.
>>> > the patch should work (by default it seems to strip the first path
>>> element).
>>> > does it not work for you?
>>> >
>>>
>>> It will fail precommit in it's current state.
>>>
>>
>> fixed
>>
>
>

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

Ben, do you also want to update the "Applying a patch" section to make it
git specific?

We (committers) should move to a model where authors get proper credit in
git. Our old workflow in svn resulted in only the committer being listed
(except that we listed the patch author in the commit message). We should
move to a model where the author of the patch gets proper credit in git. I
believe we will get that if we use git for patch creation/application?

Chris brought up getting rid of CHANGES.txt recently on the dev list in a
separate thread - Chris do you want to implement that change now that we've
moved to git?

Patrick

On Wed, Sep 14, 2016 at 9:01 PM, Benjamin Reed  wrote:

> > 1) actually in the previous step that was just adding new files. you
>> still
>> > need the commit -a for the rest of the changes. that's my normal
>> workflow.
>>
>> I think that will be confusing for most folks. They typically stage
>> all the changes and then commit or don't stage and use -a.
>>
>
> do you mind fixing it with your workflow. commit -a doesn't get new files,
> which is why you need to do the add, but i'm not the most sophisticated git
> user, so
>
>
>>
>> > 2) i figured since we are using git now that we should use git's
>> default.
>> > the patch should work (by default it seems to strip the first path
>> element).
>> > does it not work for you?
>> >
>>
>> It will fail precommit in it's current state.
>>
>
> fixed
>

Re: [VOTE] move Apache Zookeeper to git

[Benjamin Reed]

>
> > 1) actually in the previous step that was just adding new files. you
> still
> > need the commit -a for the rest of the changes. that's my normal
> workflow.
>
> I think that will be confusing for most folks. They typically stage
> all the changes and then commit or don't stage and use -a.
>

do you mind fixing it with your workflow. commit -a doesn't get new files,
which is why you need to do the add, but i'm not the most sophisticated git
user, so


>
> > 2) i figured since we are using git now that we should use git's default.
> > the patch should work (by default it seems to strip the first path
> element).
> > does it not work for you?
> >
>
> It will fail precommit in it's current state.
>

fixed

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

On Wed, Sep 14, 2016 at 9:35 AM, Benjamin Reed  wrote:
> 1) actually in the previous step that was just adding new files. you still
> need the commit -a for the rest of the changes. that's my normal workflow.

I think that will be confusing for most folks. They typically stage
all the changes and then commit or don't stage and use -a.

> 2) i figured since we are using git now that we should use git's default.
> the patch should work (by default it seems to strip the first path element).
> does it not work for you?
>

It will fail precommit in it's current state.

Patrick

> On Tue, Sep 13, 2016 at 2:02 PM, Patrick Hunt  wrote:
>>
>> Hi Ben. I didn't review it fully, but it looks like there are at least
>> two issues:
>>
>> 1) you shouldn't have the person "git commit -a" given the previous
>> commands added the files the user is interested in submitting. I think
>> you just mean to "git commit" ?
>>
>> 2) you dropped the "--no-prefix" from the git diff - this will break
>> existing tooling. It's also not consistent with the section "Applying
>> a patch" from that same wiki page. I recommend you add back the
>> --no-prefix until we are able to address (also impacts any pending
>> patches created using the old style)
>>
>> Patrick
>>
>> On Mon, Sep 12, 2016 at 10:13 PM, Benjamin Reed  wrote:
>> > i've updated the contributing to zookeeper wiki:
>> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
>> >
>> > there are many ways to do things in git, so if others feel that there is
>> > a
>> > better way please updated.
>> >
>> > i think it would be cool to adopt a github based submission like other
>> > projects have, but i'll leave that up to someone else that has used one
>> > of
>> > those work flows to propose something.
>> >
>> > thanx
>> > ben
>> >
>> > ps - i have a small change to the site to fix some svn references, but
>> > i'm
>> > still trying to figure out if the site is on git or svn...
>> >
>> > On Mon, Sep 12, 2016 at 8:28 PM, Patrick Hunt  wrote:
>> >>
>> >> Cool, thanks.
>> >>
>> >> I've re-enabled the precommit job, reconfigured it, and it seems to be
>> >> working again. LMK if you notice any issues.
>> >>
>> >> Patrick
>> >>
>> >> On Mon, Sep 12, 2016 at 8:22 PM, Raúl Gutiérrez Segalés
>> >> 
>> >> wrote:
>> >> > On 12 September 2016 at 17:48, Patrick Hunt  wrote:
>> >> >
>> >> >> On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés
>> >> >>  wrote:
>> >> >> > On 12 September 2016 at 09:58, Patrick Hunt 
>> >> >> > wrote:
>> >> >> >
>> >> >> >> Here it is, please take a look, review, and commit it to master
>> >> >> >> (remember, needs to be git now :-) )
>> >> >> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2576
>> >> >> >
>> >> >> >
>> >> >> > Merged:
>> >> >> >
>> >> >> >
>> >> >> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=
>> >> >> 8c4082647f89b0a92fa00a2af8de84b3c7314e23
>> >> >> >
>> >> >> > This is only needed in master?
>> >> >> >
>> >> >>
>> >> >> Only on master. Our current pre-commit is only for master. If we
>> >> >> move
>> >> >> to something like Yetus I believe they will also check branches.
>> >> >>
>> >> >> Raul/Ben/et.al. can you commit the second part of the patch? I
>> >> >> attached it to ZOOKEEPER-2576. Bit of a cleanup on the command
>> >> >> naming
>> >> >> (missed build.xml changes). Thanks.
>> >> >>
>> >> >
>> >> > Merged:
>> >> >
>> >> >
>> >> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=b2a484cfe743116d2531fe5d1e1d78b3960c511e
>> >> >
>> >> >
>> >> > -rgs
>> >
>> >
>
>

Re: [VOTE] move Apache Zookeeper to git

[Benjamin Reed]

1) actually in the previous step that was just adding new files. you still
need the commit -a for the rest of the changes. that's my normal workflow.
2) i figured since we are using git now that we should use git's default.
the patch should work (by default it seems to strip the first path
element). does it not work for you?

On Tue, Sep 13, 2016 at 2:02 PM, Patrick Hunt  wrote:

> Hi Ben. I didn't review it fully, but it looks like there are at least
> two issues:
>
> 1) you shouldn't have the person "git commit -a" given the previous
> commands added the files the user is interested in submitting. I think
> you just mean to "git commit" ?
>
> 2) you dropped the "--no-prefix" from the git diff - this will break
> existing tooling. It's also not consistent with the section "Applying
> a patch" from that same wiki page. I recommend you add back the
> --no-prefix until we are able to address (also impacts any pending
> patches created using the old style)
>
> Patrick
>
> On Mon, Sep 12, 2016 at 10:13 PM, Benjamin Reed  wrote:
> > i've updated the contributing to zookeeper wiki:
> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
> >
> > there are many ways to do things in git, so if others feel that there is
> a
> > better way please updated.
> >
> > i think it would be cool to adopt a github based submission like other
> > projects have, but i'll leave that up to someone else that has used one
> of
> > those work flows to propose something.
> >
> > thanx
> > ben
> >
> > ps - i have a small change to the site to fix some svn references, but
> i'm
> > still trying to figure out if the site is on git or svn...
> >
> > On Mon, Sep 12, 2016 at 8:28 PM, Patrick Hunt  wrote:
> >>
> >> Cool, thanks.
> >>
> >> I've re-enabled the precommit job, reconfigured it, and it seems to be
> >> working again. LMK if you notice any issues.
> >>
> >> Patrick
> >>
> >> On Mon, Sep 12, 2016 at 8:22 PM, Raúl Gutiérrez Segalés  >
> >> wrote:
> >> > On 12 September 2016 at 17:48, Patrick Hunt  wrote:
> >> >
> >> >> On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés
> >> >>  wrote:
> >> >> > On 12 September 2016 at 09:58, Patrick Hunt 
> wrote:
> >> >> >
> >> >> >> Here it is, please take a look, review, and commit it to master
> >> >> >> (remember, needs to be git now :-) )
> >> >> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2576
> >> >> >
> >> >> >
> >> >> > Merged:
> >> >> >
> >> >> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
> commitdiff;h=
> >> >> 8c4082647f89b0a92fa00a2af8de84b3c7314e23
> >> >> >
> >> >> > This is only needed in master?
> >> >> >
> >> >>
> >> >> Only on master. Our current pre-commit is only for master. If we move
> >> >> to something like Yetus I believe they will also check branches.
> >> >>
> >> >> Raul/Ben/et.al. can you commit the second part of the patch? I
> >> >> attached it to ZOOKEEPER-2576. Bit of a cleanup on the command naming
> >> >> (missed build.xml changes). Thanks.
> >> >>
> >> >
> >> > Merged:
> >> >
> >> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
> commitdiff;h=b2a484cfe743116d2531fe5d1e1d78b3960c511e
> >> >
> >> >
> >> > -rgs
> >
> >
>

Re: [VOTE] move Apache Zookeeper to git

[Benjamin Reed]

btw, there is an INFRA jira to get gerritt, but the status of it is very
unclear: https://issues.apache.org/jira/browse/INFRA-2205

On Tue, Sep 13, 2016 at 1:30 AM, Flavio Junqueira  wrote:

> Thanks, Ben and Pat. Is there anyone wiling to pick this up? I believe
> there are some scripts involved to do the workflow integration with github.
> I'd look at projects like Kafka and BookKeeper, which I know have done it,
> and replicate it.
>
> You don't have to be a committer to work on this, but you'd have to work
> with a committer. It is a good opportunity to learn a bit more about the
> moving parts of an Apache project if you consider becoming a ZK committer
> eventually.
>
> -Flavio
>
> > On 13 Sep 2016, at 06:13, Benjamin Reed  wrote:
> >
> > i've updated the contributing to zookeeper wiki:
> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
> >
> > there are many ways to do things in git, so if others feel that there is
> a
> > better way please updated.
> >
> > i think it would be cool to adopt a github based submission like other
> > projects have, but i'll leave that up to someone else that has used one
> of
> > those work flows to propose something.
> >
> > thanx
> > ben
> >
> > ps - i have a small change to the site to fix some svn references, but
> i'm
> > still trying to figure out if the site is on git or svn...
> >
> > On Mon, Sep 12, 2016 at 8:28 PM, Patrick Hunt  wrote:
> >
> >> Cool, thanks.
> >>
> >> I've re-enabled the precommit job, reconfigured it, and it seems to be
> >> working again. LMK if you notice any issues.
> >>
> >> Patrick
> >>
> >> On Mon, Sep 12, 2016 at 8:22 PM, Raúl Gutiérrez Segalés  >
> >> wrote:
> >>> On 12 September 2016 at 17:48, Patrick Hunt  wrote:
> >>>
>  On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés
>   wrote:
> > On 12 September 2016 at 09:58, Patrick Hunt 
> wrote:
> >
> >> Here it is, please take a look, review, and commit it to master
> >> (remember, needs to be git now :-) )
> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2576
> >
> >
> > Merged:
> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
> >> commitdiff;h=
>  8c4082647f89b0a92fa00a2af8de84b3c7314e23
> >
> > This is only needed in master?
> >
> 
>  Only on master. Our current pre-commit is only for master. If we move
>  to something like Yetus I believe they will also check branches.
> 
>  Raul/Ben/et.al. can you commit the second part of the patch? I
>  attached it to ZOOKEEPER-2576. Bit of a cleanup on the command naming
>  (missed build.xml changes). Thanks.
> 
> >>>
> >>> Merged:
> >>> https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
> commitdiff;h=
> >> b2a484cfe743116d2531fe5d1e1d78b3960c511e
> >>>
> >>>
> >>> -rgs
> >>
>
>

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

A few references that Ismael Juma kindly passed to me with respect to the 
github integration
and might be helpful here:

Blogs from Infra:
https://blogs.apache.org/infra/entry/github_pull_request_builds_now
https://blogs.apache.org/infra/entry/improved_integration_between_apache_and

Kafka merge script:
merge script: https://github.com/apache/kafka/blob/trunk/kafka-merge-pr.py
 
Wiki page for contributors:
 https://cwiki.apache.org/confluence/display/KAFKA/Contributing+Code+Changes

Wiki page for committers:
 https://cwiki.apache.org/confluence/display/KAFKA/Merging+Github+Pull+Requests 


> On 14 Sep 2016, at 06:10, Patrick Hunt  wrote:
> 
> Infra doesn't allow projects to admin their own gh.com mirrors (I just
> checked). Michael - can you comment on
> https://issues.apache.org/jira/browse/INFRA-12573 and point this out?
> I agree that the default should be master.
> 
> Thanks Michael.
> 
> Patrick
> 
> On Tue, Sep 13, 2016 at 10:03 PM, Michael Han  wrote:
>> I noticed that in https://github.com/apache/zookeeper, the default branch
>> is set to ZOOKEEPER-823. Not sure if that is intended, but I remembered the
>> old mirror (before git-svn migration) was set to trunk. Probably we should
>> set the default branch to master.
>> 
>> On Tue, Sep 13, 2016 at 2:02 PM, Patrick Hunt  wrote:
>> 
>>> Hi Ben. I didn't review it fully, but it looks like there are at least
>>> two issues:
>>> 
>>> 1) you shouldn't have the person "git commit -a" given the previous
>>> commands added the files the user is interested in submitting. I think
>>> you just mean to "git commit" ?
>>> 
>>> 2) you dropped the "--no-prefix" from the git diff - this will break
>>> existing tooling. It's also not consistent with the section "Applying
>>> a patch" from that same wiki page. I recommend you add back the
>>> --no-prefix until we are able to address (also impacts any pending
>>> patches created using the old style)
>>> 
>>> Patrick
>>> 
>>> On Mon, Sep 12, 2016 at 10:13 PM, Benjamin Reed  wrote:
 i've updated the contributing to zookeeper wiki:
 https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
 
 there are many ways to do things in git, so if others feel that there is
>>> a
 better way please updated.
 
 i think it would be cool to adopt a github based submission like other
 projects have, but i'll leave that up to someone else that has used one
>>> of
 those work flows to propose something.
 
 thanx
 ben
 
 ps - i have a small change to the site to fix some svn references, but
>>> i'm
 still trying to figure out if the site is on git or svn...
 
 On Mon, Sep 12, 2016 at 8:28 PM, Patrick Hunt  wrote:
> 
> Cool, thanks.
> 
> I've re-enabled the precommit job, reconfigured it, and it seems to be
> working again. LMK if you notice any issues.
> 
> Patrick
> 
> On Mon, Sep 12, 2016 at 8:22 PM, Raúl Gutiérrez Segalés  wrote:
>> On 12 September 2016 at 17:48, Patrick Hunt  wrote:
>> 
>>> On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés
>>>  wrote:
 On 12 September 2016 at 09:58, Patrick Hunt 
>>> wrote:
 
> Here it is, please take a look, review, and commit it to master
> (remember, needs to be git now :-) )
> https://issues.apache.org/jira/browse/ZOOKEEPER-2576
 
 
 Merged:
 
 https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
>>> commitdiff;h=
>>> 8c4082647f89b0a92fa00a2af8de84b3c7314e23
 
 This is only needed in master?
 
>>> 
>>> Only on master. Our current pre-commit is only for master. If we move
>>> to something like Yetus I believe they will also check branches.
>>> 
>>> Raul/Ben/et.al. can you commit the second part of the patch? I
>>> attached it to ZOOKEEPER-2576. Bit of a cleanup on the command naming
>>> (missed build.xml changes). Thanks.
>>> 
>> 
>> Merged:
>> 
>> https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
>>> commitdiff;h=b2a484cfe743116d2531fe5d1e1d78b3960c511e
>> 
>> 
>> -rgs
 
 
>>> 
>> 
>> 
>> 
>> --
>> Cheers
>> Michael.

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

Infra doesn't allow projects to admin their own gh.com mirrors (I just
checked). Michael - can you comment on
https://issues.apache.org/jira/browse/INFRA-12573 and point this out?
I agree that the default should be master.

Thanks Michael.

Patrick

On Tue, Sep 13, 2016 at 10:03 PM, Michael Han  wrote:
> I noticed that in https://github.com/apache/zookeeper, the default branch
> is set to ZOOKEEPER-823. Not sure if that is intended, but I remembered the
> old mirror (before git-svn migration) was set to trunk. Probably we should
> set the default branch to master.
>
> On Tue, Sep 13, 2016 at 2:02 PM, Patrick Hunt  wrote:
>
>> Hi Ben. I didn't review it fully, but it looks like there are at least
>> two issues:
>>
>> 1) you shouldn't have the person "git commit -a" given the previous
>> commands added the files the user is interested in submitting. I think
>> you just mean to "git commit" ?
>>
>> 2) you dropped the "--no-prefix" from the git diff - this will break
>> existing tooling. It's also not consistent with the section "Applying
>> a patch" from that same wiki page. I recommend you add back the
>> --no-prefix until we are able to address (also impacts any pending
>> patches created using the old style)
>>
>> Patrick
>>
>> On Mon, Sep 12, 2016 at 10:13 PM, Benjamin Reed  wrote:
>> > i've updated the contributing to zookeeper wiki:
>> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
>> >
>> > there are many ways to do things in git, so if others feel that there is
>> a
>> > better way please updated.
>> >
>> > i think it would be cool to adopt a github based submission like other
>> > projects have, but i'll leave that up to someone else that has used one
>> of
>> > those work flows to propose something.
>> >
>> > thanx
>> > ben
>> >
>> > ps - i have a small change to the site to fix some svn references, but
>> i'm
>> > still trying to figure out if the site is on git or svn...
>> >
>> > On Mon, Sep 12, 2016 at 8:28 PM, Patrick Hunt  wrote:
>> >>
>> >> Cool, thanks.
>> >>
>> >> I've re-enabled the precommit job, reconfigured it, and it seems to be
>> >> working again. LMK if you notice any issues.
>> >>
>> >> Patrick
>> >>
>> >> On Mon, Sep 12, 2016 at 8:22 PM, Raúl Gutiérrez Segalés > >
>> >> wrote:
>> >> > On 12 September 2016 at 17:48, Patrick Hunt  wrote:
>> >> >
>> >> >> On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés
>> >> >>  wrote:
>> >> >> > On 12 September 2016 at 09:58, Patrick Hunt 
>> wrote:
>> >> >> >
>> >> >> >> Here it is, please take a look, review, and commit it to master
>> >> >> >> (remember, needs to be git now :-) )
>> >> >> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2576
>> >> >> >
>> >> >> >
>> >> >> > Merged:
>> >> >> >
>> >> >> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
>> commitdiff;h=
>> >> >> 8c4082647f89b0a92fa00a2af8de84b3c7314e23
>> >> >> >
>> >> >> > This is only needed in master?
>> >> >> >
>> >> >>
>> >> >> Only on master. Our current pre-commit is only for master. If we move
>> >> >> to something like Yetus I believe they will also check branches.
>> >> >>
>> >> >> Raul/Ben/et.al. can you commit the second part of the patch? I
>> >> >> attached it to ZOOKEEPER-2576. Bit of a cleanup on the command naming
>> >> >> (missed build.xml changes). Thanks.
>> >> >>
>> >> >
>> >> > Merged:
>> >> >
>> >> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
>> commitdiff;h=b2a484cfe743116d2531fe5d1e1d78b3960c511e
>> >> >
>> >> >
>> >> > -rgs
>> >
>> >
>>
>
>
>
> --
> Cheers
> Michael.

Re: [VOTE] move Apache Zookeeper to git

[Michael Han]

I noticed that in https://github.com/apache/zookeeper, the default branch
is set to ZOOKEEPER-823. Not sure if that is intended, but I remembered the
old mirror (before git-svn migration) was set to trunk. Probably we should
set the default branch to master.

On Tue, Sep 13, 2016 at 2:02 PM, Patrick Hunt  wrote:

> Hi Ben. I didn't review it fully, but it looks like there are at least
> two issues:
>
> 1) you shouldn't have the person "git commit -a" given the previous
> commands added the files the user is interested in submitting. I think
> you just mean to "git commit" ?
>
> 2) you dropped the "--no-prefix" from the git diff - this will break
> existing tooling. It's also not consistent with the section "Applying
> a patch" from that same wiki page. I recommend you add back the
> --no-prefix until we are able to address (also impacts any pending
> patches created using the old style)
>
> Patrick
>
> On Mon, Sep 12, 2016 at 10:13 PM, Benjamin Reed  wrote:
> > i've updated the contributing to zookeeper wiki:
> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
> >
> > there are many ways to do things in git, so if others feel that there is
> a
> > better way please updated.
> >
> > i think it would be cool to adopt a github based submission like other
> > projects have, but i'll leave that up to someone else that has used one
> of
> > those work flows to propose something.
> >
> > thanx
> > ben
> >
> > ps - i have a small change to the site to fix some svn references, but
> i'm
> > still trying to figure out if the site is on git or svn...
> >
> > On Mon, Sep 12, 2016 at 8:28 PM, Patrick Hunt  wrote:
> >>
> >> Cool, thanks.
> >>
> >> I've re-enabled the precommit job, reconfigured it, and it seems to be
> >> working again. LMK if you notice any issues.
> >>
> >> Patrick
> >>
> >> On Mon, Sep 12, 2016 at 8:22 PM, Raúl Gutiérrez Segalés  >
> >> wrote:
> >> > On 12 September 2016 at 17:48, Patrick Hunt  wrote:
> >> >
> >> >> On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés
> >> >>  wrote:
> >> >> > On 12 September 2016 at 09:58, Patrick Hunt 
> wrote:
> >> >> >
> >> >> >> Here it is, please take a look, review, and commit it to master
> >> >> >> (remember, needs to be git now :-) )
> >> >> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2576
> >> >> >
> >> >> >
> >> >> > Merged:
> >> >> >
> >> >> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
> commitdiff;h=
> >> >> 8c4082647f89b0a92fa00a2af8de84b3c7314e23
> >> >> >
> >> >> > This is only needed in master?
> >> >> >
> >> >>
> >> >> Only on master. Our current pre-commit is only for master. If we move
> >> >> to something like Yetus I believe they will also check branches.
> >> >>
> >> >> Raul/Ben/et.al. can you commit the second part of the patch? I
> >> >> attached it to ZOOKEEPER-2576. Bit of a cleanup on the command naming
> >> >> (missed build.xml changes). Thanks.
> >> >>
> >> >
> >> > Merged:
> >> >
> >> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
> commitdiff;h=b2a484cfe743116d2531fe5d1e1d78b3960c511e
> >> >
> >> >
> >> > -rgs
> >
> >
>



-- 
Cheers
Michael.

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

Hi Ben. I didn't review it fully, but it looks like there are at least
two issues:

1) you shouldn't have the person "git commit -a" given the previous
commands added the files the user is interested in submitting. I think
you just mean to "git commit" ?

2) you dropped the "--no-prefix" from the git diff - this will break
existing tooling. It's also not consistent with the section "Applying
a patch" from that same wiki page. I recommend you add back the
--no-prefix until we are able to address (also impacts any pending
patches created using the old style)

Patrick

On Mon, Sep 12, 2016 at 10:13 PM, Benjamin Reed  wrote:
> i've updated the contributing to zookeeper wiki:
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
>
> there are many ways to do things in git, so if others feel that there is a
> better way please updated.
>
> i think it would be cool to adopt a github based submission like other
> projects have, but i'll leave that up to someone else that has used one of
> those work flows to propose something.
>
> thanx
> ben
>
> ps - i have a small change to the site to fix some svn references, but i'm
> still trying to figure out if the site is on git or svn...
>
> On Mon, Sep 12, 2016 at 8:28 PM, Patrick Hunt  wrote:
>>
>> Cool, thanks.
>>
>> I've re-enabled the precommit job, reconfigured it, and it seems to be
>> working again. LMK if you notice any issues.
>>
>> Patrick
>>
>> On Mon, Sep 12, 2016 at 8:22 PM, Raúl Gutiérrez Segalés 
>> wrote:
>> > On 12 September 2016 at 17:48, Patrick Hunt  wrote:
>> >
>> >> On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés
>> >>  wrote:
>> >> > On 12 September 2016 at 09:58, Patrick Hunt  wrote:
>> >> >
>> >> >> Here it is, please take a look, review, and commit it to master
>> >> >> (remember, needs to be git now :-) )
>> >> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2576
>> >> >
>> >> >
>> >> > Merged:
>> >> >
>> >> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=
>> >> 8c4082647f89b0a92fa00a2af8de84b3c7314e23
>> >> >
>> >> > This is only needed in master?
>> >> >
>> >>
>> >> Only on master. Our current pre-commit is only for master. If we move
>> >> to something like Yetus I believe they will also check branches.
>> >>
>> >> Raul/Ben/et.al. can you commit the second part of the patch? I
>> >> attached it to ZOOKEEPER-2576. Bit of a cleanup on the command naming
>> >> (missed build.xml changes). Thanks.
>> >>
>> >
>> > Merged:
>> >
>> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=b2a484cfe743116d2531fe5d1e1d78b3960c511e
>> >
>> >
>> > -rgs
>
>

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Hey, Flavio,

I am with some sparing cycles this week (and genuinely curious about this
integration between ASF git repo and Github's), so I can volunteer to pick
up this. Could you or another committer guide me, please? :)

Thanks,
Edward

On Tue, Sep 13, 2016 at 5:30 AM, Flavio Junqueira  wrote:

> Thanks, Ben and Pat. Is there anyone wiling to pick this up? I believe
> there are some scripts involved to do the workflow integration with github.
> I'd look at projects like Kafka and BookKeeper, which I know have done it,
> and replicate it.
>
> You don't have to be a committer to work on this, but you'd have to work
> with a committer. It is a good opportunity to learn a bit more about the
> moving parts of an Apache project if you consider becoming a ZK committer
> eventually.
>
> -Flavio
>
> > On 13 Sep 2016, at 06:13, Benjamin Reed  wrote:
> >
> > i've updated the contributing to zookeeper wiki:
> > https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
> >
> > there are many ways to do things in git, so if others feel that there is
> a
> > better way please updated.
> >
> > i think it would be cool to adopt a github based submission like other
> > projects have, but i'll leave that up to someone else that has used one
> of
> > those work flows to propose something.
> >
> > thanx
> > ben
> >
> > ps - i have a small change to the site to fix some svn references, but
> i'm
> > still trying to figure out if the site is on git or svn...
> >
> > On Mon, Sep 12, 2016 at 8:28 PM, Patrick Hunt  wrote:
> >
> >> Cool, thanks.
> >>
> >> I've re-enabled the precommit job, reconfigured it, and it seems to be
> >> working again. LMK if you notice any issues.
> >>
> >> Patrick
> >>
> >> On Mon, Sep 12, 2016 at 8:22 PM, Raúl Gutiérrez Segalés  >
> >> wrote:
> >>> On 12 September 2016 at 17:48, Patrick Hunt  wrote:
> >>>
>  On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés
>   wrote:
> > On 12 September 2016 at 09:58, Patrick Hunt 
> wrote:
> >
> >> Here it is, please take a look, review, and commit it to master
> >> (remember, needs to be git now :-) )
> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2576
> >
> >
> > Merged:
> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
> >> commitdiff;h=
>  8c4082647f89b0a92fa00a2af8de84b3c7314e23
> >
> > This is only needed in master?
> >
> 
>  Only on master. Our current pre-commit is only for master. If we move
>  to something like Yetus I believe they will also check branches.
> 
>  Raul/Ben/et.al. can you commit the second part of the patch? I
>  attached it to ZOOKEEPER-2576. Bit of a cleanup on the command naming
>  (missed build.xml changes). Thanks.
> 
> >>>
> >>> Merged:
> >>> https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
> commitdiff;h=
> >> b2a484cfe743116d2531fe5d1e1d78b3960c511e
> >>>
> >>>
> >>> -rgs
> >>
>
>

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

Thanks, Ben and Pat. Is there anyone wiling to pick this up? I believe there 
are some scripts involved to do the workflow integration with github. I'd look 
at projects like Kafka and BookKeeper, which I know have done it, and replicate 
it. 

You don't have to be a committer to work on this, but you'd have to work with a 
committer. It is a good opportunity to learn a bit more about the moving parts 
of an Apache project if you consider becoming a ZK committer eventually.

-Flavio

> On 13 Sep 2016, at 06:13, Benjamin Reed  wrote:
> 
> i've updated the contributing to zookeeper wiki:
> https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute
> 
> there are many ways to do things in git, so if others feel that there is a
> better way please updated.
> 
> i think it would be cool to adopt a github based submission like other
> projects have, but i'll leave that up to someone else that has used one of
> those work flows to propose something.
> 
> thanx
> ben
> 
> ps - i have a small change to the site to fix some svn references, but i'm
> still trying to figure out if the site is on git or svn...
> 
> On Mon, Sep 12, 2016 at 8:28 PM, Patrick Hunt  wrote:
> 
>> Cool, thanks.
>> 
>> I've re-enabled the precommit job, reconfigured it, and it seems to be
>> working again. LMK if you notice any issues.
>> 
>> Patrick
>> 
>> On Mon, Sep 12, 2016 at 8:22 PM, Raúl Gutiérrez Segalés 
>> wrote:
>>> On 12 September 2016 at 17:48, Patrick Hunt  wrote:
>>> 
 On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés
  wrote:
> On 12 September 2016 at 09:58, Patrick Hunt  wrote:
> 
>> Here it is, please take a look, review, and commit it to master
>> (remember, needs to be git now :-) )
>> https://issues.apache.org/jira/browse/ZOOKEEPER-2576
> 
> 
> Merged:
> https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=
>> commitdiff;h=
 8c4082647f89b0a92fa00a2af8de84b3c7314e23
> 
> This is only needed in master?
> 
 
 Only on master. Our current pre-commit is only for master. If we move
 to something like Yetus I believe they will also check branches.
 
 Raul/Ben/et.al. can you commit the second part of the patch? I
 attached it to ZOOKEEPER-2576. Bit of a cleanup on the command naming
 (missed build.xml changes). Thanks.
 
>>> 
>>> Merged:
>>> https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=
>> b2a484cfe743116d2531fe5d1e1d78b3960c511e
>>> 
>>> 
>>> -rgs
>> 

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

Cool, thanks.

I've re-enabled the precommit job, reconfigured it, and it seems to be
working again. LMK if you notice any issues.

Patrick

On Mon, Sep 12, 2016 at 8:22 PM, Raúl Gutiérrez Segalés  wrote:
> On 12 September 2016 at 17:48, Patrick Hunt  wrote:
>
>> On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés
>>  wrote:
>> > On 12 September 2016 at 09:58, Patrick Hunt  wrote:
>> >
>> >> Here it is, please take a look, review, and commit it to master
>> >> (remember, needs to be git now :-) )
>> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2576
>> >
>> >
>> > Merged:
>> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=
>> 8c4082647f89b0a92fa00a2af8de84b3c7314e23
>> >
>> > This is only needed in master?
>> >
>>
>> Only on master. Our current pre-commit is only for master. If we move
>> to something like Yetus I believe they will also check branches.
>>
>> Raul/Ben/et.al. can you commit the second part of the patch? I
>> attached it to ZOOKEEPER-2576. Bit of a cleanup on the command naming
>> (missed build.xml changes). Thanks.
>>
>
> Merged:
> https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=b2a484cfe743116d2531fe5d1e1d78b3960c511e
>
>
> -rgs

Re: [VOTE] move Apache Zookeeper to git

[Raúl Gutiérrez Segalés]

On 12 September 2016 at 17:48, Patrick Hunt  wrote:

> On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés
>  wrote:
> > On 12 September 2016 at 09:58, Patrick Hunt  wrote:
> >
> >> Here it is, please take a look, review, and commit it to master
> >> (remember, needs to be git now :-) )
> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2576
> >
> >
> > Merged:
> > https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=
> 8c4082647f89b0a92fa00a2af8de84b3c7314e23
> >
> > This is only needed in master?
> >
>
> Only on master. Our current pre-commit is only for master. If we move
> to something like Yetus I believe they will also check branches.
>
> Raul/Ben/et.al. can you commit the second part of the patch? I
> attached it to ZOOKEEPER-2576. Bit of a cleanup on the command naming
> (missed build.xml changes). Thanks.
>

Merged:
https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=b2a484cfe743116d2531fe5d1e1d78b3960c511e


-rgs

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

On Mon, Sep 12, 2016 at 10:15 AM, Raúl Gutiérrez Segalés
 wrote:
> On 12 September 2016 at 09:58, Patrick Hunt  wrote:
>
>> Here it is, please take a look, review, and commit it to master
>> (remember, needs to be git now :-) )
>> https://issues.apache.org/jira/browse/ZOOKEEPER-2576
>
>
> Merged:
> https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=8c4082647f89b0a92fa00a2af8de84b3c7314e23
>
> This is only needed in master?
>

Only on master. Our current pre-commit is only for master. If we move
to something like Yetus I believe they will also check branches.

Raul/Ben/et.al. can you commit the second part of the patch? I
attached it to ZOOKEEPER-2576. Bit of a cleanup on the command naming
(missed build.xml changes). Thanks.

Patrick

>
> -rgs
>
> p.s.: this feels so good! thanks Pat & Ben :-)
>
>
>>
>> Patrick
>>
>> On Mon, Sep 12, 2016 at 9:10 AM, Patrick Hunt  wrote:
>> > I worked up a patch last night, I'll create the jira and attach the
>> > patch later today when I get a few.
>> >
>> > Patrick
>> >
>> > On Mon, Sep 12, 2016 at 7:29 AM, Flavio Junqueira 
>> wrote:
>> >>
>> >>> On 12 Sep 2016, at 06:42, Patrick Hunt  wrote:
>> >>>
>> >>> afaik there has never been github integration for anything with ZK.
>> >>> QAbot only runs against jira/svn.
>> >>
>> >> I'm not sure what you're trying to say here. Both Apache Kafka and
>> Apache BookKeeper use ZK and currently use github.
>> >>
>> >>>
>> >>> FYI: I've gone through all the jenkins jobs (3.4/3.5/trunk) and gotten
>> >>> them working again. There was a ton of cruft in there which I
>> >>> attempted to cleanup. I think things should be ok, but I will be
>> >>> monitoring over the next few days. If you notice obvious issues please
>> >>> lmk (vs say flakey tests).
>> >>>
>> >>
>> >> Thanks for doing this, Pat.
>> >>
>> >>> Additionally - qabot (precommit job) is broken. The zookeeper script
>> >>> ./src/java/test/bin/test-patch.sh is used by QAbot, and it uses svn
>> >>> directly. We'll need to patch this script in order to get qabot
>> >>> functional again - replace svn with git usage. There's only a few
>> >>> lines but I'm not familiar with this script. If anyone wants to take a
>> >>> stab please submit a jira/patch. I've turned off precommit job on
>> >>> jenkins until we get this straightened out.
>> >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/
>> PreCommit-ZOOKEEPER-Build/
>> >>>
>> >>
>> >> If we don't have a jira yet, we should create one. It is important to
>> turn pre-commit back on.
>> >>
>> >> -Flavio
>> >>
>> >>> Patrick
>> >>>
>> >>> On Sun, Sep 11, 2016 at 9:32 PM, Benjamin Reed 
>> wrote:
>>  sure. i'll update it to reference git rather than svn.
>> 
>>  if i understand correctly pull requests that were submitted via
>> github were
>>  reviewed by the qa bot (or something like that) in the past, but it
>> was
>>  turned off. we should turn that back on i think.
>> 
>>  thanx
>>  ben
>> 
>>  On Sun, Sep 11, 2016 at 8:49 PM, Patrick Hunt 
>> wrote:
>> >
>> > FYI Apache INFRA has made the cutover -
>> > https://issues.apache.org/jira/browse/INFRA-12573
>> >
>> > At this point we need to update the "how to contribute" etc... Ben do
>> > you want to take a stab at that? I can update the respective Jenkins
>> > jobs.
>> >
>> > What else is there?
>> >
>> > Patrick
>> >
>> > On Wed, Sep 7, 2016 at 9:59 AM, Chris Nauroth <
>> cnaur...@hortonworks.com>
>> > wrote:
>> >> Thank you for doing this, Eddie.  I just picked up the code review.
>> >>
>> >> --Chris Nauroth
>> >>
>> >> On 9/7/16, 9:49 AM, "Edward Ribeiro" 
>> wrote:
>> >>
>> >>Hey folks, as part of this major change, I took a look at the
>> >> gitignore and
>> >>it already lacks a lot of file extensions for a modern Java
>> project.
>> >>Therefore, I created a trivial patch (shameless plug) that
>> updates
>> >> for more
>> >>commonly extensions:
>> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2557
>> >>
>> >>Could you please review it and (the committers) this incorporated
>> >> into
>> >>branches before the transition if everything is alright, whenever
>> >> you have
>> >>time? The final gitignore doesn't look particularly big and cover
>> >> only
>> >>mostly the common IDE extensions and temporary files.
>> >>
>> >>Cheers,
>> >>Eddie
>> >>
>> >>
>> >>On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira > >
>> >> wrote:
>> >>
>> >>> +1
>> >>>
>>  On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:
>> 
>>  Quick update (more details on the INFRA jira). It might take
>> >> upwards of

Re: [VOTE] move Apache Zookeeper to git

[Raúl Gutiérrez Segalés]

On 12 September 2016 at 09:58, Patrick Hunt  wrote:

> Here it is, please take a look, review, and commit it to master
> (remember, needs to be git now :-) )
> https://issues.apache.org/jira/browse/ZOOKEEPER-2576


Merged:
https://git-wip-us.apache.org/repos/asf?p=zookeeper.git;a=commitdiff;h=8c4082647f89b0a92fa00a2af8de84b3c7314e23

This is only needed in master?


-rgs

p.s.: this feels so good! thanks Pat & Ben :-)


>
> Patrick
>
> On Mon, Sep 12, 2016 at 9:10 AM, Patrick Hunt  wrote:
> > I worked up a patch last night, I'll create the jira and attach the
> > patch later today when I get a few.
> >
> > Patrick
> >
> > On Mon, Sep 12, 2016 at 7:29 AM, Flavio Junqueira 
> wrote:
> >>
> >>> On 12 Sep 2016, at 06:42, Patrick Hunt  wrote:
> >>>
> >>> afaik there has never been github integration for anything with ZK.
> >>> QAbot only runs against jira/svn.
> >>
> >> I'm not sure what you're trying to say here. Both Apache Kafka and
> Apache BookKeeper use ZK and currently use github.
> >>
> >>>
> >>> FYI: I've gone through all the jenkins jobs (3.4/3.5/trunk) and gotten
> >>> them working again. There was a ton of cruft in there which I
> >>> attempted to cleanup. I think things should be ok, but I will be
> >>> monitoring over the next few days. If you notice obvious issues please
> >>> lmk (vs say flakey tests).
> >>>
> >>
> >> Thanks for doing this, Pat.
> >>
> >>> Additionally - qabot (precommit job) is broken. The zookeeper script
> >>> ./src/java/test/bin/test-patch.sh is used by QAbot, and it uses svn
> >>> directly. We'll need to patch this script in order to get qabot
> >>> functional again - replace svn with git usage. There's only a few
> >>> lines but I'm not familiar with this script. If anyone wants to take a
> >>> stab please submit a jira/patch. I've turned off precommit job on
> >>> jenkins until we get this straightened out.
> >>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/
> PreCommit-ZOOKEEPER-Build/
> >>>
> >>
> >> If we don't have a jira yet, we should create one. It is important to
> turn pre-commit back on.
> >>
> >> -Flavio
> >>
> >>> Patrick
> >>>
> >>> On Sun, Sep 11, 2016 at 9:32 PM, Benjamin Reed 
> wrote:
>  sure. i'll update it to reference git rather than svn.
> 
>  if i understand correctly pull requests that were submitted via
> github were
>  reviewed by the qa bot (or something like that) in the past, but it
> was
>  turned off. we should turn that back on i think.
> 
>  thanx
>  ben
> 
>  On Sun, Sep 11, 2016 at 8:49 PM, Patrick Hunt 
> wrote:
> >
> > FYI Apache INFRA has made the cutover -
> > https://issues.apache.org/jira/browse/INFRA-12573
> >
> > At this point we need to update the "how to contribute" etc... Ben do
> > you want to take a stab at that? I can update the respective Jenkins
> > jobs.
> >
> > What else is there?
> >
> > Patrick
> >
> > On Wed, Sep 7, 2016 at 9:59 AM, Chris Nauroth <
> cnaur...@hortonworks.com>
> > wrote:
> >> Thank you for doing this, Eddie.  I just picked up the code review.
> >>
> >> --Chris Nauroth
> >>
> >> On 9/7/16, 9:49 AM, "Edward Ribeiro" 
> wrote:
> >>
> >>Hey folks, as part of this major change, I took a look at the
> >> gitignore and
> >>it already lacks a lot of file extensions for a modern Java
> project.
> >>Therefore, I created a trivial patch (shameless plug) that
> updates
> >> for more
> >>commonly extensions:
> >> https://issues.apache.org/jira/browse/ZOOKEEPER-2557
> >>
> >>Could you please review it and (the committers) this incorporated
> >> into
> >>branches before the transition if everything is alright, whenever
> >> you have
> >>time? The final gitignore doesn't look particularly big and cover
> >> only
> >>mostly the common IDE extensions and temporary files.
> >>
> >>Cheers,
> >>Eddie
> >>
> >>
> >>On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira  >
> >> wrote:
> >>
> >>> +1
> >>>
>  On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:
> 
>  Quick update (more details on the INFRA jira). It might take
> >> upwards of
> >>> 24
>  hours to do the svn->git migration although our repo isn't that
> >> large,
>  likely less. INFRA can do it, for example, on Saturday around
> >> 18:00 UTC.
>  Any concerns with such an approach?
> 
>  Patrick
> 
>  On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt 
> >> wrote:
> 
> > Follow along here:
> >> https://issues.apache.org/jira/browse/INFRA-12573
> >
> > Patrick
> >
> > On Sun, Sep 

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

Here it is, please take a look, review, and commit it to master
(remember, needs to be git now :-) )
https://issues.apache.org/jira/browse/ZOOKEEPER-2576

Patrick

On Mon, Sep 12, 2016 at 9:10 AM, Patrick Hunt  wrote:
> I worked up a patch last night, I'll create the jira and attach the
> patch later today when I get a few.
>
> Patrick
>
> On Mon, Sep 12, 2016 at 7:29 AM, Flavio Junqueira  wrote:
>>
>>> On 12 Sep 2016, at 06:42, Patrick Hunt  wrote:
>>>
>>> afaik there has never been github integration for anything with ZK.
>>> QAbot only runs against jira/svn.
>>
>> I'm not sure what you're trying to say here. Both Apache Kafka and Apache 
>> BookKeeper use ZK and currently use github.
>>
>>>
>>> FYI: I've gone through all the jenkins jobs (3.4/3.5/trunk) and gotten
>>> them working again. There was a ton of cruft in there which I
>>> attempted to cleanup. I think things should be ok, but I will be
>>> monitoring over the next few days. If you notice obvious issues please
>>> lmk (vs say flakey tests).
>>>
>>
>> Thanks for doing this, Pat.
>>
>>> Additionally - qabot (precommit job) is broken. The zookeeper script
>>> ./src/java/test/bin/test-patch.sh is used by QAbot, and it uses svn
>>> directly. We'll need to patch this script in order to get qabot
>>> functional again - replace svn with git usage. There's only a few
>>> lines but I'm not familiar with this script. If anyone wants to take a
>>> stab please submit a jira/patch. I've turned off precommit job on
>>> jenkins until we get this straightened out.
>>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/PreCommit-ZOOKEEPER-Build/
>>>
>>
>> If we don't have a jira yet, we should create one. It is important to turn 
>> pre-commit back on.
>>
>> -Flavio
>>
>>> Patrick
>>>
>>> On Sun, Sep 11, 2016 at 9:32 PM, Benjamin Reed  wrote:
 sure. i'll update it to reference git rather than svn.

 if i understand correctly pull requests that were submitted via github were
 reviewed by the qa bot (or something like that) in the past, but it was
 turned off. we should turn that back on i think.

 thanx
 ben

 On Sun, Sep 11, 2016 at 8:49 PM, Patrick Hunt  wrote:
>
> FYI Apache INFRA has made the cutover -
> https://issues.apache.org/jira/browse/INFRA-12573
>
> At this point we need to update the "how to contribute" etc... Ben do
> you want to take a stab at that? I can update the respective Jenkins
> jobs.
>
> What else is there?
>
> Patrick
>
> On Wed, Sep 7, 2016 at 9:59 AM, Chris Nauroth 
> wrote:
>> Thank you for doing this, Eddie.  I just picked up the code review.
>>
>> --Chris Nauroth
>>
>> On 9/7/16, 9:49 AM, "Edward Ribeiro"  wrote:
>>
>>Hey folks, as part of this major change, I took a look at the
>> gitignore and
>>it already lacks a lot of file extensions for a modern Java project.
>>Therefore, I created a trivial patch (shameless plug) that updates
>> for more
>>commonly extensions:
>> https://issues.apache.org/jira/browse/ZOOKEEPER-2557
>>
>>Could you please review it and (the committers) this incorporated
>> into
>>branches before the transition if everything is alright, whenever
>> you have
>>time? The final gitignore doesn't look particularly big and cover
>> only
>>mostly the common IDE extensions and temporary files.
>>
>>Cheers,
>>Eddie
>>
>>
>>On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira 
>> wrote:
>>
>>> +1
>>>
 On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:

 Quick update (more details on the INFRA jira). It might take
>> upwards of
>>> 24
 hours to do the svn->git migration although our repo isn't that
>> large,
 likely less. INFRA can do it, for example, on Saturday around
>> 18:00 UTC.
 Any concerns with such an approach?

 Patrick

 On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt 
>> wrote:

> Follow along here:
>> https://issues.apache.org/jira/browse/INFRA-12573
>
> Patrick
>
> On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed
>>  wrote:
>
>> with 10 votes for (5 of which are from the PMC) on no votes
>> against.
>>> the
>> vote passes.
>>
>> pat please make git happen! :)
>>
>> thanx for voting!
>>
>> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han
>>  wrote:
>>
>>> +1
>>>
>>> On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan
>> 
>> wrote:
>>>

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

I worked up a patch last night, I'll create the jira and attach the
patch later today when I get a few.

Patrick

On Mon, Sep 12, 2016 at 7:29 AM, Flavio Junqueira  wrote:
>
>> On 12 Sep 2016, at 06:42, Patrick Hunt  wrote:
>>
>> afaik there has never been github integration for anything with ZK.
>> QAbot only runs against jira/svn.
>
> I'm not sure what you're trying to say here. Both Apache Kafka and Apache 
> BookKeeper use ZK and currently use github.
>
>>
>> FYI: I've gone through all the jenkins jobs (3.4/3.5/trunk) and gotten
>> them working again. There was a ton of cruft in there which I
>> attempted to cleanup. I think things should be ok, but I will be
>> monitoring over the next few days. If you notice obvious issues please
>> lmk (vs say flakey tests).
>>
>
> Thanks for doing this, Pat.
>
>> Additionally - qabot (precommit job) is broken. The zookeeper script
>> ./src/java/test/bin/test-patch.sh is used by QAbot, and it uses svn
>> directly. We'll need to patch this script in order to get qabot
>> functional again - replace svn with git usage. There's only a few
>> lines but I'm not familiar with this script. If anyone wants to take a
>> stab please submit a jira/patch. I've turned off precommit job on
>> jenkins until we get this straightened out.
>> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/PreCommit-ZOOKEEPER-Build/
>>
>
> If we don't have a jira yet, we should create one. It is important to turn 
> pre-commit back on.
>
> -Flavio
>
>> Patrick
>>
>> On Sun, Sep 11, 2016 at 9:32 PM, Benjamin Reed  wrote:
>>> sure. i'll update it to reference git rather than svn.
>>>
>>> if i understand correctly pull requests that were submitted via github were
>>> reviewed by the qa bot (or something like that) in the past, but it was
>>> turned off. we should turn that back on i think.
>>>
>>> thanx
>>> ben
>>>
>>> On Sun, Sep 11, 2016 at 8:49 PM, Patrick Hunt  wrote:

 FYI Apache INFRA has made the cutover -
 https://issues.apache.org/jira/browse/INFRA-12573

 At this point we need to update the "how to contribute" etc... Ben do
 you want to take a stab at that? I can update the respective Jenkins
 jobs.

 What else is there?

 Patrick

 On Wed, Sep 7, 2016 at 9:59 AM, Chris Nauroth 
 wrote:
> Thank you for doing this, Eddie.  I just picked up the code review.
>
> --Chris Nauroth
>
> On 9/7/16, 9:49 AM, "Edward Ribeiro"  wrote:
>
>Hey folks, as part of this major change, I took a look at the
> gitignore and
>it already lacks a lot of file extensions for a modern Java project.
>Therefore, I created a trivial patch (shameless plug) that updates
> for more
>commonly extensions:
> https://issues.apache.org/jira/browse/ZOOKEEPER-2557
>
>Could you please review it and (the committers) this incorporated
> into
>branches before the transition if everything is alright, whenever
> you have
>time? The final gitignore doesn't look particularly big and cover
> only
>mostly the common IDE extensions and temporary files.
>
>Cheers,
>Eddie
>
>
>On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira 
> wrote:
>
>> +1
>>
>>> On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:
>>>
>>> Quick update (more details on the INFRA jira). It might take
> upwards of
>> 24
>>> hours to do the svn->git migration although our repo isn't that
> large,
>>> likely less. INFRA can do it, for example, on Saturday around
> 18:00 UTC.
>>> Any concerns with such an approach?
>>>
>>> Patrick
>>>
>>> On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt 
> wrote:
>>>
 Follow along here:
> https://issues.apache.org/jira/browse/INFRA-12573

 Patrick

 On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed
>  wrote:

> with 10 votes for (5 of which are from the PMC) on no votes
> against.
>> the
> vote passes.
>
> pat please make git happen! :)
>
> thanx for voting!
>
> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han
>  wrote:
>
>> +1
>>
>> On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan
> 
> wrote:
>>
>>> +1
>>>
>>> On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira
> 
> wrote:
>>>
 +1

> On 01 Sep 2016, at 13:28, Edward Ribeiro <
> edward.ribe...@gmail.com>
 wrote:
>
> +1 (non binding)
>
> On Thu, Sep 1, 2016 at 

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

> On 12 Sep 2016, at 06:42, Patrick Hunt  wrote:
> 
> afaik there has never been github integration for anything with ZK.
> QAbot only runs against jira/svn.

I'm not sure what you're trying to say here. Both Apache Kafka and Apache 
BookKeeper use ZK and currently use github. 

> 
> FYI: I've gone through all the jenkins jobs (3.4/3.5/trunk) and gotten
> them working again. There was a ton of cruft in there which I
> attempted to cleanup. I think things should be ok, but I will be
> monitoring over the next few days. If you notice obvious issues please
> lmk (vs say flakey tests).
> 

Thanks for doing this, Pat.

> Additionally - qabot (precommit job) is broken. The zookeeper script
> ./src/java/test/bin/test-patch.sh is used by QAbot, and it uses svn
> directly. We'll need to patch this script in order to get qabot
> functional again - replace svn with git usage. There's only a few
> lines but I'm not familiar with this script. If anyone wants to take a
> stab please submit a jira/patch. I've turned off precommit job on
> jenkins until we get this straightened out.
> https://builds.apache.org/view/S-Z/view/ZooKeeper/job/PreCommit-ZOOKEEPER-Build/
> 

If we don't have a jira yet, we should create one. It is important to turn 
pre-commit back on.

-Flavio

> Patrick
> 
> On Sun, Sep 11, 2016 at 9:32 PM, Benjamin Reed  wrote:
>> sure. i'll update it to reference git rather than svn.
>> 
>> if i understand correctly pull requests that were submitted via github were
>> reviewed by the qa bot (or something like that) in the past, but it was
>> turned off. we should turn that back on i think.
>> 
>> thanx
>> ben
>> 
>> On Sun, Sep 11, 2016 at 8:49 PM, Patrick Hunt  wrote:
>>> 
>>> FYI Apache INFRA has made the cutover -
>>> https://issues.apache.org/jira/browse/INFRA-12573
>>> 
>>> At this point we need to update the "how to contribute" etc... Ben do
>>> you want to take a stab at that? I can update the respective Jenkins
>>> jobs.
>>> 
>>> What else is there?
>>> 
>>> Patrick
>>> 
>>> On Wed, Sep 7, 2016 at 9:59 AM, Chris Nauroth 
>>> wrote:
 Thank you for doing this, Eddie.  I just picked up the code review.
 
 --Chris Nauroth
 
 On 9/7/16, 9:49 AM, "Edward Ribeiro"  wrote:
 
Hey folks, as part of this major change, I took a look at the
 gitignore and
it already lacks a lot of file extensions for a modern Java project.
Therefore, I created a trivial patch (shameless plug) that updates
 for more
commonly extensions:
 https://issues.apache.org/jira/browse/ZOOKEEPER-2557
 
Could you please review it and (the committers) this incorporated
 into
branches before the transition if everything is alright, whenever
 you have
time? The final gitignore doesn't look particularly big and cover
 only
mostly the common IDE extensions and temporary files.
 
Cheers,
Eddie
 
 
On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira 
 wrote:
 
> +1
> 
>> On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:
>> 
>> Quick update (more details on the INFRA jira). It might take
 upwards of
> 24
>> hours to do the svn->git migration although our repo isn't that
 large,
>> likely less. INFRA can do it, for example, on Saturday around
 18:00 UTC.
>> Any concerns with such an approach?
>> 
>> Patrick
>> 
>> On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt 
 wrote:
>> 
>>> Follow along here:
 https://issues.apache.org/jira/browse/INFRA-12573
>>> 
>>> Patrick
>>> 
>>> On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed
  wrote:
>>> 
 with 10 votes for (5 of which are from the PMC) on no votes
 against.
> the
 vote passes.
 
 pat please make git happen! :)
 
 thanx for voting!
 
 On Thu, Sep 1, 2016 at 9:25 AM, Michael Han
  wrote:
 
> +1
> 
> On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan
 
 wrote:
> 
>> +1
>> 
>> On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira
 
 wrote:
>> 
>>> +1
>>> 
 On 01 Sep 2016, at 13:28, Edward Ribeiro <
 edward.ribe...@gmail.com>
>>> wrote:
 
 +1 (non binding)
 
 On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
>>> jor...@jordanzimmerman.com
> wrote:
 
> +1 (non binding)
> 
>> On Aug 31, 2016, at 8:29 PM, Benjamin Reed
 
> wrote:
>> 
>> flip the switch to git and 

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

afaik there has never been github integration for anything with ZK.
QAbot only runs against jira/svn.

FYI: I've gone through all the jenkins jobs (3.4/3.5/trunk) and gotten
them working again. There was a ton of cruft in there which I
attempted to cleanup. I think things should be ok, but I will be
monitoring over the next few days. If you notice obvious issues please
lmk (vs say flakey tests).

Additionally - qabot (precommit job) is broken. The zookeeper script
./src/java/test/bin/test-patch.sh is used by QAbot, and it uses svn
directly. We'll need to patch this script in order to get qabot
functional again - replace svn with git usage. There's only a few
lines but I'm not familiar with this script. If anyone wants to take a
stab please submit a jira/patch. I've turned off precommit job on
jenkins until we get this straightened out.
https://builds.apache.org/view/S-Z/view/ZooKeeper/job/PreCommit-ZOOKEEPER-Build/

Patrick

On Sun, Sep 11, 2016 at 9:32 PM, Benjamin Reed  wrote:
> sure. i'll update it to reference git rather than svn.
>
> if i understand correctly pull requests that were submitted via github were
> reviewed by the qa bot (or something like that) in the past, but it was
> turned off. we should turn that back on i think.
>
> thanx
> ben
>
> On Sun, Sep 11, 2016 at 8:49 PM, Patrick Hunt  wrote:
>>
>> FYI Apache INFRA has made the cutover -
>> https://issues.apache.org/jira/browse/INFRA-12573
>>
>> At this point we need to update the "how to contribute" etc... Ben do
>> you want to take a stab at that? I can update the respective Jenkins
>> jobs.
>>
>> What else is there?
>>
>> Patrick
>>
>> On Wed, Sep 7, 2016 at 9:59 AM, Chris Nauroth 
>> wrote:
>> > Thank you for doing this, Eddie.  I just picked up the code review.
>> >
>> > --Chris Nauroth
>> >
>> > On 9/7/16, 9:49 AM, "Edward Ribeiro"  wrote:
>> >
>> > Hey folks, as part of this major change, I took a look at the
>> > gitignore and
>> > it already lacks a lot of file extensions for a modern Java project.
>> > Therefore, I created a trivial patch (shameless plug) that updates
>> > for more
>> > commonly extensions:
>> > https://issues.apache.org/jira/browse/ZOOKEEPER-2557
>> >
>> > Could you please review it and (the committers) this incorporated
>> > into
>> > branches before the transition if everything is alright, whenever
>> > you have
>> > time? The final gitignore doesn't look particularly big and cover
>> > only
>> > mostly the common IDE extensions and temporary files.
>> >
>> > Cheers,
>> > Eddie
>> >
>> >
>> > On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira 
>> > wrote:
>> >
>> > > +1
>> > >
>> > > > On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:
>> > > >
>> > > > Quick update (more details on the INFRA jira). It might take
>> > upwards of
>> > > 24
>> > > > hours to do the svn->git migration although our repo isn't that
>> > large,
>> > > > likely less. INFRA can do it, for example, on Saturday around
>> > 18:00 UTC.
>> > > > Any concerns with such an approach?
>> > > >
>> > > > Patrick
>> > > >
>> > > > On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt 
>> > wrote:
>> > > >
>> > > >> Follow along here:
>> > https://issues.apache.org/jira/browse/INFRA-12573
>> > > >>
>> > > >> Patrick
>> > > >>
>> > > >> On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed
>> >  wrote:
>> > > >>
>> > > >>> with 10 votes for (5 of which are from the PMC) on no votes
>> > against.
>> > > the
>> > > >>> vote passes.
>> > > >>>
>> > > >>> pat please make git happen! :)
>> > > >>>
>> > > >>> thanx for voting!
>> > > >>>
>> > > >>> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han
>> >  wrote:
>> > > >>>
>> > >  +1
>> > > 
>> > >  On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan
>> > 
>> > > >>> wrote:
>> > > 
>> > > > +1
>> > > >
>> > > > On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira
>> > 
>> > > >>> wrote:
>> > > >
>> > > >> +1
>> > > >>
>> > > >>> On 01 Sep 2016, at 13:28, Edward Ribeiro <
>> > > >>> edward.ribe...@gmail.com>
>> > > >> wrote:
>> > > >>>
>> > > >>> +1 (non binding)
>> > > >>>
>> > > >>> On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
>> > > >> jor...@jordanzimmerman.com
>> > >  wrote:
>> > > >>>
>> > >  +1 (non binding)
>> > > 
>> > > > On Aug 31, 2016, at 8:29 PM, Benjamin Reed
>> > 
>> > >  wrote:
>> > > >
>> > > > flip the switch to git and update the relevant scripts
>> > and docs.
>> > > >
>> > > 

Re: [VOTE] move Apache Zookeeper to git

[Benjamin Reed]

sure. i'll update it to reference git rather than svn.

if i understand correctly pull requests that were submitted via github were
reviewed by the qa bot (or something like that) in the past, but it was
turned off. we should turn that back on i think.

thanx
ben

On Sun, Sep 11, 2016 at 8:49 PM, Patrick Hunt  wrote:

> FYI Apache INFRA has made the cutover -
> https://issues.apache.org/jira/browse/INFRA-12573
>
> At this point we need to update the "how to contribute" etc... Ben do
> you want to take a stab at that? I can update the respective Jenkins
> jobs.
>
> What else is there?
>
> Patrick
>
> On Wed, Sep 7, 2016 at 9:59 AM, Chris Nauroth 
> wrote:
> > Thank you for doing this, Eddie.  I just picked up the code review.
> >
> > --Chris Nauroth
> >
> > On 9/7/16, 9:49 AM, "Edward Ribeiro"  wrote:
> >
> > Hey folks, as part of this major change, I took a look at the
> gitignore and
> > it already lacks a lot of file extensions for a modern Java project.
> > Therefore, I created a trivial patch (shameless plug) that updates
> for more
> > commonly extensions:  https://issues.apache.org/
> jira/browse/ZOOKEEPER-2557
> >
> > Could you please review it and (the committers) this incorporated
> into
> > branches before the transition if everything is alright, whenever
> you have
> > time? The final gitignore doesn't look particularly big and cover
> only
> > mostly the common IDE extensions and temporary files.
> >
> > Cheers,
> > Eddie
> >
> >
> > On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira 
> wrote:
> >
> > > +1
> > >
> > > > On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:
> > > >
> > > > Quick update (more details on the INFRA jira). It might take
> upwards of
> > > 24
> > > > hours to do the svn->git migration although our repo isn't that
> large,
> > > > likely less. INFRA can do it, for example, on Saturday around
> 18:00 UTC.
> > > > Any concerns with such an approach?
> > > >
> > > > Patrick
> > > >
> > > > On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt 
> wrote:
> > > >
> > > >> Follow along here: https://issues.apache.org/
> jira/browse/INFRA-12573
> > > >>
> > > >> Patrick
> > > >>
> > > >> On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed 
> wrote:
> > > >>
> > > >>> with 10 votes for (5 of which are from the PMC) on no votes
> against.
> > > the
> > > >>> vote passes.
> > > >>>
> > > >>> pat please make git happen! :)
> > > >>>
> > > >>> thanx for voting!
> > > >>>
> > > >>> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han 
> wrote:
> > > >>>
> > >  +1
> > > 
> > >  On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan <
> pheyyin...@gmail.com>
> > > >>> wrote:
> > > 
> > > > +1
> > > >
> > > > On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira <
> f...@apache.org>
> > > >>> wrote:
> > > >
> > > >> +1
> > > >>
> > > >>> On 01 Sep 2016, at 13:28, Edward Ribeiro <
> > > >>> edward.ribe...@gmail.com>
> > > >> wrote:
> > > >>>
> > > >>> +1 (non binding)
> > > >>>
> > > >>> On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
> > > >> jor...@jordanzimmerman.com
> > >  wrote:
> > > >>>
> > >  +1 (non binding)
> > > 
> > > > On Aug 31, 2016, at 8:29 PM, Benjamin Reed <
> br...@apache.org>
> > >  wrote:
> > > >
> > > > flip the switch to git and update the relevant scripts
> and docs.
> > > >
> > > > i couldn't figure out which timeframe this falls under
> in the
> > >  voting
> > > > procedure table, but i think it's safe to go with 3
> days, so the
> > >  vote
> > >  will
> > > > close on Saturday, September 3 at 6:30pm pdt.
> > > >
> > > > +1 from me
> > > 
> > > 
> > > >>
> > > >>
> > > >
> > > 
> > > 
> > > 
> > >  --
> > >  Cheers
> > >  Michael.
> > > 
> > > >>>
> > > >>
> > > >>
> > >
> > >
> >
> >
>

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

FYI Apache INFRA has made the cutover -
https://issues.apache.org/jira/browse/INFRA-12573

At this point we need to update the "how to contribute" etc... Ben do
you want to take a stab at that? I can update the respective Jenkins
jobs.

What else is there?

Patrick

On Wed, Sep 7, 2016 at 9:59 AM, Chris Nauroth  wrote:
> Thank you for doing this, Eddie.  I just picked up the code review.
>
> --Chris Nauroth
>
> On 9/7/16, 9:49 AM, "Edward Ribeiro"  wrote:
>
> Hey folks, as part of this major change, I took a look at the gitignore 
> and
> it already lacks a lot of file extensions for a modern Java project.
> Therefore, I created a trivial patch (shameless plug) that updates for 
> more
> commonly extensions:  https://issues.apache.org/jira/browse/ZOOKEEPER-2557
>
> Could you please review it and (the committers) this incorporated into
> branches before the transition if everything is alright, whenever you have
> time? The final gitignore doesn't look particularly big and cover only
> mostly the common IDE extensions and temporary files.
>
> Cheers,
> Eddie
>
>
> On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira  wrote:
>
> > +1
> >
> > > On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:
> > >
> > > Quick update (more details on the INFRA jira). It might take upwards 
> of
> > 24
> > > hours to do the svn->git migration although our repo isn't that large,
> > > likely less. INFRA can do it, for example, on Saturday around 18:00 
> UTC.
> > > Any concerns with such an approach?
> > >
> > > Patrick
> > >
> > > On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt  wrote:
> > >
> > >> Follow along here: https://issues.apache.org/jira/browse/INFRA-12573
> > >>
> > >> Patrick
> > >>
> > >> On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed  
> wrote:
> > >>
> > >>> with 10 votes for (5 of which are from the PMC) on no votes against.
> > the
> > >>> vote passes.
> > >>>
> > >>> pat please make git happen! :)
> > >>>
> > >>> thanx for voting!
> > >>>
> > >>> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han  
> wrote:
> > >>>
> >  +1
> > 
> >  On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan 
> > >>> wrote:
> > 
> > > +1
> > >
> > > On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira 
> > >>> wrote:
> > >
> > >> +1
> > >>
> > >>> On 01 Sep 2016, at 13:28, Edward Ribeiro <
> > >>> edward.ribe...@gmail.com>
> > >> wrote:
> > >>>
> > >>> +1 (non binding)
> > >>>
> > >>> On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
> > >> jor...@jordanzimmerman.com
> >  wrote:
> > >>>
> >  +1 (non binding)
> > 
> > > On Aug 31, 2016, at 8:29 PM, Benjamin Reed 
> >  wrote:
> > >
> > > flip the switch to git and update the relevant scripts and 
> docs.
> > >
> > > i couldn't figure out which timeframe this falls under in the
> >  voting
> > > procedure table, but i think it's safe to go with 3 days, so 
> the
> >  vote
> >  will
> > > close on Saturday, September 3 at 6:30pm pdt.
> > >
> > > +1 from me
> > 
> > 
> > >>
> > >>
> > >
> > 
> > 
> > 
> >  --
> >  Cheers
> >  Michael.
> > 
> > >>>
> > >>
> > >>
> >
> >
>
>

Re: [VOTE] move Apache Zookeeper to git

[Chris Nauroth]

Thank you for doing this, Eddie.  I just picked up the code review.

--Chris Nauroth

On 9/7/16, 9:49 AM, "Edward Ribeiro"  wrote:

Hey folks, as part of this major change, I took a look at the gitignore and
it already lacks a lot of file extensions for a modern Java project.
Therefore, I created a trivial patch (shameless plug) that updates for more
commonly extensions:  https://issues.apache.org/jira/browse/ZOOKEEPER-2557

Could you please review it and (the committers) this incorporated into
branches before the transition if everything is alright, whenever you have
time? The final gitignore doesn't look particularly big and cover only
mostly the common IDE extensions and temporary files.

Cheers,
Eddie


On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira  wrote:

> +1
>
> > On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:
> >
> > Quick update (more details on the INFRA jira). It might take upwards of
> 24
> > hours to do the svn->git migration although our repo isn't that large,
> > likely less. INFRA can do it, for example, on Saturday around 18:00 UTC.
> > Any concerns with such an approach?
> >
> > Patrick
> >
> > On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt  wrote:
> >
> >> Follow along here: https://issues.apache.org/jira/browse/INFRA-12573
> >>
> >> Patrick
> >>
> >> On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed  wrote:
> >>
> >>> with 10 votes for (5 of which are from the PMC) on no votes against.
> the
> >>> vote passes.
> >>>
> >>> pat please make git happen! :)
> >>>
> >>> thanx for voting!
> >>>
> >>> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han  wrote:
> >>>
>  +1
> 
>  On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan 
> >>> wrote:
> 
> > +1
> >
> > On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira 
> >>> wrote:
> >
> >> +1
> >>
> >>> On 01 Sep 2016, at 13:28, Edward Ribeiro <
> >>> edward.ribe...@gmail.com>
> >> wrote:
> >>>
> >>> +1 (non binding)
> >>>
> >>> On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
> >> jor...@jordanzimmerman.com
>  wrote:
> >>>
>  +1 (non binding)
> 
> > On Aug 31, 2016, at 8:29 PM, Benjamin Reed 
>  wrote:
> >
> > flip the switch to git and update the relevant scripts and docs.
> >
> > i couldn't figure out which timeframe this falls under in the
>  voting
> > procedure table, but i think it's safe to go with 3 days, so the
>  vote
>  will
> > close on Saturday, September 3 at 6:30pm pdt.
> >
> > +1 from me
> 
> 
> >>
> >>
> >
> 
> 
> 
>  --
>  Cheers
>  Michael.
> 
> >>>
> >>
> >>
>
>

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

Hey folks, as part of this major change, I took a look at the gitignore and
it already lacks a lot of file extensions for a modern Java project.
Therefore, I created a trivial patch (shameless plug) that updates for more
commonly extensions:  https://issues.apache.org/jira/browse/ZOOKEEPER-2557

Could you please review it and (the committers) this incorporated into
branches before the transition if everything is alright, whenever you have
time? The final gitignore doesn't look particularly big and cover only
mostly the common IDE extensions and temporary files.

Cheers,
Eddie


On Wed, Sep 7, 2016 at 7:31 AM, Flavio Junqueira  wrote:

> +1
>
> > On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:
> >
> > Quick update (more details on the INFRA jira). It might take upwards of
> 24
> > hours to do the svn->git migration although our repo isn't that large,
> > likely less. INFRA can do it, for example, on Saturday around 18:00 UTC.
> > Any concerns with such an approach?
> >
> > Patrick
> >
> > On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt  wrote:
> >
> >> Follow along here: https://issues.apache.org/jira/browse/INFRA-12573
> >>
> >> Patrick
> >>
> >> On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed  wrote:
> >>
> >>> with 10 votes for (5 of which are from the PMC) on no votes against.
> the
> >>> vote passes.
> >>>
> >>> pat please make git happen! :)
> >>>
> >>> thanx for voting!
> >>>
> >>> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han  wrote:
> >>>
>  +1
> 
>  On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan 
> >>> wrote:
> 
> > +1
> >
> > On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira 
> >>> wrote:
> >
> >> +1
> >>
> >>> On 01 Sep 2016, at 13:28, Edward Ribeiro <
> >>> edward.ribe...@gmail.com>
> >> wrote:
> >>>
> >>> +1 (non binding)
> >>>
> >>> On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
> >> jor...@jordanzimmerman.com
>  wrote:
> >>>
>  +1 (non binding)
> 
> > On Aug 31, 2016, at 8:29 PM, Benjamin Reed 
>  wrote:
> >
> > flip the switch to git and update the relevant scripts and docs.
> >
> > i couldn't figure out which timeframe this falls under in the
>  voting
> > procedure table, but i think it's safe to go with 3 days, so the
>  vote
>  will
> > close on Saturday, September 3 at 6:30pm pdt.
> >
> > +1 from me
> 
> 
> >>
> >>
> >
> 
> 
> 
>  --
>  Cheers
>  Michael.
> 
> >>>
> >>
> >>
>
>

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

+1

> On 07 Sep 2016, at 06:10, Patrick Hunt  wrote:
> 
> Quick update (more details on the INFRA jira). It might take upwards of 24
> hours to do the svn->git migration although our repo isn't that large,
> likely less. INFRA can do it, for example, on Saturday around 18:00 UTC.
> Any concerns with such an approach?
> 
> Patrick
> 
> On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt  wrote:
> 
>> Follow along here: https://issues.apache.org/jira/browse/INFRA-12573
>> 
>> Patrick
>> 
>> On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed  wrote:
>> 
>>> with 10 votes for (5 of which are from the PMC) on no votes against. the
>>> vote passes.
>>> 
>>> pat please make git happen! :)
>>> 
>>> thanx for voting!
>>> 
>>> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han  wrote:
>>> 
 +1
 
 On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan 
>>> wrote:
 
> +1
> 
> On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira 
>>> wrote:
> 
>> +1
>> 
>>> On 01 Sep 2016, at 13:28, Edward Ribeiro <
>>> edward.ribe...@gmail.com>
>> wrote:
>>> 
>>> +1 (non binding)
>>> 
>>> On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
>> jor...@jordanzimmerman.com
 wrote:
>>> 
 +1 (non binding)
 
> On Aug 31, 2016, at 8:29 PM, Benjamin Reed 
 wrote:
> 
> flip the switch to git and update the relevant scripts and docs.
> 
> i couldn't figure out which timeframe this falls under in the
 voting
> procedure table, but i think it's safe to go with 3 days, so the
 vote
 will
> close on Saturday, September 3 at 6:30pm pdt.
> 
> +1 from me
 
 
>> 
>> 
> 
 
 
 
 --
 Cheers
 Michael.
 
>>> 
>> 
>> 

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

Quick update (more details on the INFRA jira). It might take upwards of 24
hours to do the svn->git migration although our repo isn't that large,
likely less. INFRA can do it, for example, on Saturday around 18:00 UTC.
Any concerns with such an approach?

Patrick

On Sun, Sep 4, 2016 at 9:20 PM, Patrick Hunt  wrote:

> Follow along here: https://issues.apache.org/jira/browse/INFRA-12573
>
> Patrick
>
> On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed  wrote:
>
>> with 10 votes for (5 of which are from the PMC) on no votes against. the
>> vote passes.
>>
>> pat please make git happen! :)
>>
>> thanx for voting!
>>
>> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han  wrote:
>>
>> > +1
>> >
>> > On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan 
>> wrote:
>> >
>> > > +1
>> > >
>> > > On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira 
>> wrote:
>> > >
>> > > > +1
>> > > >
>> > > > > On 01 Sep 2016, at 13:28, Edward Ribeiro <
>> edward.ribe...@gmail.com>
>> > > > wrote:
>> > > > >
>> > > > > +1 (non binding)
>> > > > >
>> > > > > On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
>> > > > jor...@jordanzimmerman.com
>> > > > >> wrote:
>> > > > >
>> > > > >> +1 (non binding)
>> > > > >>
>> > > > >>> On Aug 31, 2016, at 8:29 PM, Benjamin Reed 
>> > wrote:
>> > > > >>>
>> > > > >>> flip the switch to git and update the relevant scripts and docs.
>> > > > >>>
>> > > > >>> i couldn't figure out which timeframe this falls under in the
>> > voting
>> > > > >>> procedure table, but i think it's safe to go with 3 days, so the
>> > vote
>> > > > >> will
>> > > > >>> close on Saturday, September 3 at 6:30pm pdt.
>> > > > >>>
>> > > > >>> +1 from me
>> > > > >>
>> > > > >>
>> > > >
>> > > >
>> > >
>> >
>> >
>> >
>> > --
>> > Cheers
>> > Michael.
>> >
>>
>
>

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

Follow along here: https://issues.apache.org/jira/browse/INFRA-12573

Patrick

On Sun, Sep 4, 2016 at 8:33 AM, Benjamin Reed  wrote:

> with 10 votes for (5 of which are from the PMC) on no votes against. the
> vote passes.
>
> pat please make git happen! :)
>
> thanx for voting!
>
> On Thu, Sep 1, 2016 at 9:25 AM, Michael Han  wrote:
>
> > +1
> >
> > On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan 
> wrote:
> >
> > > +1
> > >
> > > On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira 
> wrote:
> > >
> > > > +1
> > > >
> > > > > On 01 Sep 2016, at 13:28, Edward Ribeiro  >
> > > > wrote:
> > > > >
> > > > > +1 (non binding)
> > > > >
> > > > > On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
> > > > jor...@jordanzimmerman.com
> > > > >> wrote:
> > > > >
> > > > >> +1 (non binding)
> > > > >>
> > > > >>> On Aug 31, 2016, at 8:29 PM, Benjamin Reed 
> > wrote:
> > > > >>>
> > > > >>> flip the switch to git and update the relevant scripts and docs.
> > > > >>>
> > > > >>> i couldn't figure out which timeframe this falls under in the
> > voting
> > > > >>> procedure table, but i think it's safe to go with 3 days, so the
> > vote
> > > > >> will
> > > > >>> close on Saturday, September 3 at 6:30pm pdt.
> > > > >>>
> > > > >>> +1 from me
> > > > >>
> > > > >>
> > > >
> > > >
> > >
> >
> >
> >
> > --
> > Cheers
> > Michael.
> >
>

Re: [VOTE] move Apache Zookeeper to git

[Benjamin Reed]

with 10 votes for (5 of which are from the PMC) on no votes against. the
vote passes.

pat please make git happen! :)

thanx for voting!

On Thu, Sep 1, 2016 at 9:25 AM, Michael Han  wrote:

> +1
>
> On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan  wrote:
>
> > +1
> >
> > On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira  wrote:
> >
> > > +1
> > >
> > > > On 01 Sep 2016, at 13:28, Edward Ribeiro 
> > > wrote:
> > > >
> > > > +1 (non binding)
> > > >
> > > > On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
> > > jor...@jordanzimmerman.com
> > > >> wrote:
> > > >
> > > >> +1 (non binding)
> > > >>
> > > >>> On Aug 31, 2016, at 8:29 PM, Benjamin Reed 
> wrote:
> > > >>>
> > > >>> flip the switch to git and update the relevant scripts and docs.
> > > >>>
> > > >>> i couldn't figure out which timeframe this falls under in the
> voting
> > > >>> procedure table, but i think it's safe to go with 3 days, so the
> vote
> > > >> will
> > > >>> close on Saturday, September 3 at 6:30pm pdt.
> > > >>>
> > > >>> +1 from me
> > > >>
> > > >>
> > >
> > >
> >
>
>
>
> --
> Cheers
> Michael.
>

Re: [VOTE] move Apache Zookeeper to git

[Michael Han]

+1

On Thu, Sep 1, 2016 at 6:08 AM, Michelle Tan  wrote:

> +1
>
> On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira  wrote:
>
> > +1
> >
> > > On 01 Sep 2016, at 13:28, Edward Ribeiro 
> > wrote:
> > >
> > > +1 (non binding)
> > >
> > > On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
> > jor...@jordanzimmerman.com
> > >> wrote:
> > >
> > >> +1 (non binding)
> > >>
> > >>> On Aug 31, 2016, at 8:29 PM, Benjamin Reed  wrote:
> > >>>
> > >>> flip the switch to git and update the relevant scripts and docs.
> > >>>
> > >>> i couldn't figure out which timeframe this falls under in the voting
> > >>> procedure table, but i think it's safe to go with 3 days, so the vote
> > >> will
> > >>> close on Saturday, September 3 at 6:30pm pdt.
> > >>>
> > >>> +1 from me
> > >>
> > >>
> >
> >
>



-- 
Cheers
Michael.

Voting procedure (was: Re: [VOTE] move Apache Zookeeper to git)

[Flavio Junqueira]

We say in the bylaws that for technical decisions, the votes of active 
committers are binding, so some of the votes I see here are actually binding 
(e.g., Rakesh's vote). As for length, 72 hours sounds appropriate and lazy 
consensus is my preference, even though so far all votes are +1, so it might 
not matter.

We want to emphasize that the even though non-committer votes aren't binding, 
it is really important that the members of the community at large vote so that 
we understand how the community perceives this change.

-Flavio  

> On 01 Sep 2016, at 02:29, Benjamin Reed  wrote:
> 
> flip the switch to git and update the relevant scripts and docs.
> 
> i couldn't figure out which timeframe this falls under in the voting
> procedure table, but i think it's safe to go with 3 days, so the vote will
> close on Saturday, September 3 at 6:30pm pdt.
> 
> +1 from me

Re: [VOTE] move Apache Zookeeper to git

[Michelle Tan]

+1

On Thu, Sep 1, 2016 at 2:01 PM, Flavio Junqueira  wrote:

> +1
>
> > On 01 Sep 2016, at 13:28, Edward Ribeiro 
> wrote:
> >
> > +1 (non binding)
> >
> > On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman <
> jor...@jordanzimmerman.com
> >> wrote:
> >
> >> +1 (non binding)
> >>
> >>> On Aug 31, 2016, at 8:29 PM, Benjamin Reed  wrote:
> >>>
> >>> flip the switch to git and update the relevant scripts and docs.
> >>>
> >>> i couldn't figure out which timeframe this falls under in the voting
> >>> procedure table, but i think it's safe to go with 3 days, so the vote
> >> will
> >>> close on Saturday, September 3 at 6:30pm pdt.
> >>>
> >>> +1 from me
> >>
> >>
>
>

Re: [VOTE] move Apache Zookeeper to git

[Flavio Junqueira]

+1

> On 01 Sep 2016, at 13:28, Edward Ribeiro  wrote:
> 
> +1 (non binding)
> 
> On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman > wrote:
> 
>> +1 (non binding)
>> 
>>> On Aug 31, 2016, at 8:29 PM, Benjamin Reed  wrote:
>>> 
>>> flip the switch to git and update the relevant scripts and docs.
>>> 
>>> i couldn't figure out which timeframe this falls under in the voting
>>> procedure table, but i think it's safe to go with 3 days, so the vote
>> will
>>> close on Saturday, September 3 at 6:30pm pdt.
>>> 
>>> +1 from me
>> 
>> 

Re: [VOTE] move Apache Zookeeper to git

[Edward Ribeiro]

+1 (non binding)

On Thu, Sep 1, 2016 at 3:44 AM, Jordan Zimmerman  wrote:

> +1 (non binding)
>
> > On Aug 31, 2016, at 8:29 PM, Benjamin Reed  wrote:
> >
> > flip the switch to git and update the relevant scripts and docs.
> >
> > i couldn't figure out which timeframe this falls under in the voting
> > procedure table, but i think it's safe to go with 3 days, so the vote
> will
> > close on Saturday, September 3 at 6:30pm pdt.
> >
> > +1 from me
>
>

Re: [VOTE] move Apache Zookeeper to git

[Rakesh Radhakrishnan]

+1 (non-binding)

Rakesh

On Thu, Sep 1, 2016 at 10:40 AM, Raúl Gutiérrez Segalés  wrote:

> +1
>
> -rgs
>
> On Aug 31, 2016 3:29 PM, "Benjamin Reed"  wrote:
>
> > flip the switch to git and update the relevant scripts and docs.
> >
> > i couldn't figure out which timeframe this falls under in the voting
> > procedure table, but i think it's safe to go with 3 days, so the vote
> will
> > close on Saturday, September 3 at 6:30pm pdt.
> >
> > +1 from me
> >
>

Re: [VOTE] move Apache Zookeeper to git

[Raúl Gutiérrez Segalés]

+1

-rgs

On Aug 31, 2016 3:29 PM, "Benjamin Reed"  wrote:

> flip the switch to git and update the relevant scripts and docs.
>
> i couldn't figure out which timeframe this falls under in the voting
> procedure table, but i think it's safe to go with 3 days, so the vote will
> close on Saturday, September 3 at 6:30pm pdt.
>
> +1 from me
>

Re: [VOTE] move Apache Zookeeper to git

[Patrick Hunt]

+1.

Patrick

On Wed, Aug 31, 2016 at 9:48 PM, Chris Nauroth 
wrote:

> +1
>
> --Chris Nauroth
>
> On 8/31/16, 6:29 PM, "Benjamin Reed"  wrote:
>
> flip the switch to git and update the relevant scripts and docs.
>
> i couldn't figure out which timeframe this falls under in the voting
> procedure table, but i think it's safe to go with 3 days, so the vote
> will
> close on Saturday, September 3 at 6:30pm pdt.
>
> +1 from me
>
>
>

Re: [VOTE] move Apache Zookeeper to git

[Chris Nauroth]

+1

--Chris Nauroth

On 8/31/16, 6:29 PM, "Benjamin Reed"  wrote:

flip the switch to git and update the relevant scripts and docs.

i couldn't figure out which timeframe this falls under in the voting
procedure table, but i think it's safe to go with 3 days, so the vote will
close on Saturday, September 3 at 6:30pm pdt.

+1 from me