> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, April 23, 2019 4:20 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Dong, Eric; Wang, Jian J
> Subject: RE: [PATCH v2 0/2] Add PEI BlockIO support for ATA AHCI mode
> devices
>
> Comments:
> 1. Can we add
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1737
User may add other commands before CC command from build_rule.txt
for specific purpose. It worked fine before commit 05217d210e.
This patch is going to fix the bug in commit 05217d210e to
support customized CC command.
Signed-off-by: Bob
Reviewed-by: Liming Gao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao,
> Zhichao
> Sent: Tuesday, April 23, 2019 10:35 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Bi, Dandan
> Subject: [edk2-devel] [PATCH
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
The DebugLib instances of DebugPortProtocol use a global
variable "mExitBootServicesEvent" which is in conflict with
the same variable in StatusCodeHandlerRuntimeDxe.inf.
That would cause a build error through GCC5. So change the
name to
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
The DebugLib instances of StdErr use a global variable
"mExitBootServicesEvent" which is in conflict with the
same variable in StatusCodeHandlerRuntimeDxe.inf.
That would cause a build error through GCC5. So change the
name to the
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
The DebugLib instances of DebugPortProtocol, ConOut and StdErr
use a global variable "mExitBootServicesEvent" which is in
conflict with the same variable in StatusCodeHandlerRuntimeDxe.inf.
That would cause a build error through GCC5. So
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740
The DebugLib instances of ConOut use a global variable
"mExitBootServicesEvent" which is in conflict with
the same variable in StatusCodeHandlerRuntimeDxe.inf.
That would cause a build error through GCC5. So change the
name to the
Reviewed-by: Jian J Wang
> -Original Message-
> From: Ye, Ting
> Sent: Tuesday, April 23, 2019 10:18 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Ye, Ting
> Subject: FW: [PATCH] Change package maintainer and reviewer of CryptoPkg.
>
> Fwd to new EDKII development mailing list.
>
Fwd to new EDKII development mailing list.
-Original Message-
From: Ye, Ting
Sent: Monday, April 22, 2019 5:36 PM
To: edk2-de...@lists.01.org
Cc: Wang, Jian J ; Ye, Ting
Subject: [PATCH] Change package maintainer and reviewer of CryptoPkg.
Removed Gang Wei from reviewer as he already
Assuming Laszlo's comment is addressed.
Reviewed-by: Jaben Carsey
> -Original Message-
> From: Bi, Dandan
> Sent: Wednesday, April 17, 2019 6:12 PM
> To: Laszlo Ersek ; Ard Biesheuvel
>
> Cc: edk2-devel-groups-io ; Carsey, Jaben
> ; Ni, Ray ; Leif Lindholm
> ; Gao, Liming
> Subject:
Dandan:
I have no other comments. Reviewed-by: Liming Gao
> -Original Message-
> From: Bi, Dandan
> Sent: Thursday, April 18, 2019 9:12 AM
> To: Laszlo Ersek ; Ard Biesheuvel
>
> Cc: edk2-devel-groups-io ; Carsey, Jaben
> ; Ni, Ray ; Leif Lindholm
> ; Gao, Liming
> Subject: RE:
> On Apr 22, 2019, at 3:02 PM, Ard Biesheuvel wrote:
>
> On Mon, 22 Apr 2019 at 23:53, Michael D Kinney
> wrote:
>>
>> Ard,
>>
>> This seems to be a common limitation seen in some
>> static analyzers. We have not found a workaround
>> that does not involve code changes to quiet the
>>
On Tue, 23 Apr 2019 at 00:37, Michael D Kinney
wrote:
>
> Ard,
>
> I only see one potential issue.
>
> The size of the buffer copied is based on the FwResourceCount field.
> The actual size of based on the FwResourceCountMax field. Your patch
> does not set FwResourceCountMax to FwResourceCount,
On Mon, 22 Apr 2019 at 09:14, Wu, Hao A wrote:
>
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard
> > Biesheuvel
> > Sent: Saturday, April 20, 2019 6:35 PM
> > To: devel@edk2.groups.io
> > Cc: Wu, Hao A; Wang, Jian J; Kinney, Michael D;
On Mon, 22 Apr 2019 at 23:53, Michael D Kinney
wrote:
>
> Ard,
>
> This seems to be a common limitation seen in some
> static analyzers. We have not found a workaround
> that does not involve code changes to quiet the
> false positives.
>
> For this specific case, I think the code change I
>
Ard,
This seems to be a common limitation seen in some
static analyzers. We have not found a workaround
that does not involve code changes to quiet the
false positives.
For this specific case, I think the code change I
suggest is correct.
Best regards,
Mike
> -Original Message-
>
On Mon, 22 Apr 2019 at 16:41, Kinney, Michael D
wrote:
>
> Hi Hao,
>
> I think a cleaner fix to this issues is replace both
> ASSERT() statements with the following:
>
> if (EFI_ERROR (Status) || Entry->Emulator == NULL) {
> FreePool (Entry);
> continue;
> }
>
> We do
Comments:
1. Can we add EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST to
mAhciAtaPassThruPpiListTemplate/mAhciBlkIoPpiListTemplate as well? I understand
that requires calling PeiServicesInstallPpi() 3 times instead of once. But I
see the benefit of change is the code is more understandable and
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Jin, Eric
> Sent: Sunday, April 21, 2019 10:48 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D
> Subject:
> [Staging/Bug_1525_FmpDevicePkg_MultipleControllers][PAT
> CH] MdeModulePkg/EsrtFmpDxe: Detect duplicate
>
Hi Hao,
I think a cleaner fix to this issues is replace both
ASSERT() statements with the following:
if (EFI_ERROR (Status) || Entry->Emulator == NULL) {
FreePool (Entry);
continue;
}
We do not expect the emulator protocol to disappear between
finding the handle and
crypto/uid.c is needed by VS201x toolchain on Windows. Let's still keep it in
inf.
That means we need this patch for build on FreeBSD.
Reviewed-by: Jian J Wang
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> rebecca via Groups.Io
>
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Monday, April 22, 2019 6:12 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Zeng, Star
Subject: [PATCH] IntelFsp2WrapperPkg/FspsWrapperPeim: Fix coding style.
REF:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730
Internal code quality check failed after this commit:
68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those
coding style issues.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
Yes, Please.
BestRegards
Fu Siyuan
From: Gao, Liming
Sent: Monday, April 22, 2019 2:13 PM
To: Fu, Siyuan ; devel@edk2.groups.io
Cc: Wu, Jiaxin
Subject: RE: [RFC] Propose to remove IpSecDxe
Siyuan:
Is this change for edk2 Q2 stable tag? If yes, I will add it into edk2
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, April 22, 2019 9:56 AM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Ni, Ray; Gao, Liming
> Subject: [patch] MdeModulePkg/HiiDatabaseDxe: Release lock on all error
> return path
>
> REF:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard
> Biesheuvel
> Sent: Saturday, April 20, 2019 6:35 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A; Wang, Jian J; Kinney, Michael D; Ard Biesheuvel
> Subject: [edk2-devel] [PATCH v2]
From: "Tien Hock, Loh"
Some busses doesn't allow 8 bit MMIO read/write, this adds support for
32 bits read/write
Signed-off-by: "Tien Hock, Loh"
Cc: Jian J Wang
Cc: Hao Wu
---
MdeModulePkg/MdeModulePkg.dec | 6
++
Siyuan:
Is this change for edk2 Q2 stable tag? If yes, I will add it into edk2
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning.
Thanks
Liming
From: Fu, Siyuan
Sent: Thursday, April 11, 2019 6:58 PM
To: devel@edk2.groups.io; Fu, Siyuan
Cc: Wu, Jiaxin ; Gao, Liming
28 matches
Mail list logo
