[edk2-devel] [PATCH] BaseTools/tools_def.template: Remove tools chain with ASL tool

2019-04-23 Thread Zhang, Shenglei
Microsoft ASL is not verified now. So remove tool chain with ASL tool. They are: VS2008xASL, VS2008x86xASL, VS2010xASL, VS2010x86xASL, VS2012xASL, VS2012x86xASL, VS2013xASL, VS2013x86xASL, VS2015xASL, VS2015x86xASL and CYGGCCxASL. https://bugzilla.tianocore.org/show_bug.cgi?id=1667 v2:Remove

Re: [edk2-devel] [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease the name collisions

2019-04-23 Thread Nate DeSimone
Update copyright year from 2016 to 2019. After that is done... Reviewed-by: Nate DeSimone -Original Message- From: Gao, Zhichao Sent: Tuesday, April 23, 2019 9:58 PM To: devel@edk2.groups.io Cc: Laszlo Ersek ; Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star ; Gao, Liming ; Bi,

Re: [edk2-devel] [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease the name collisions

2019-04-23 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Wednesday, April 24, 2019 12:58 PM > To: devel@edk2.groups.io > Cc: Laszlo Ersek ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > ; Gao, Liming ; Bi, Dandan > > Subject: [PATCH V2 6/8]

[edk2-devel] [PATCH v2] MdeModulePkg/DxeCore: Please static checker for false report

2019-04-23 Thread Wu, Hao A
After commit 57df17fe26, some static check reports suspicous NULL pointer deference at line: Entry->MachineType = Entry->Emulator->MachineType; ^^^ within function PeCoffEmuProtocolNotify(). However, 'Entry->Emulator' is guaranteed to have a non-NULL value

[edk2-devel] [PATCH V2 4/8] IntelFrameworkModulePkg: Decrease the name collisions

2019-04-23 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' descriptor to the global variables that only used in a single file to minimize the name collisions. This is only for the varable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Liming Gao Cc: Dandan Bi Signed-off-by:

[edk2-devel] [PATCH V2 2/8] MdePkg/UefiDebugLibDebugPortProtocol: Decrease the name collisions

2019-04-23 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' descriptor to the global variables that only used in a single file to minimize the name collisions. This is only for the varable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Michael D Kinney Cc: Liming Gao Cc:

[edk2-devel] [PATCH V2 8/8] MdeModulePkg/StatusCodeHandlerRuntimeDxe: Decrease the name collisions

2019-04-23 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' descriptor to the global variables that only used in a single file to minimize the name collisions. This is only for the varable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc:

[edk2-devel] [PATCH V2 6/8] IntelFsp2WrapperPkg/FspWrapperNotifyDxe: Decrease the name collisions

2019-04-23 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' descriptor to the global variables that only used in a single file to minimize the name collisions. This is only for the varable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Chasel Chiu Cc: Nate DeSimone Cc: Star

[edk2-devel] [PATCH V2 7/8] IntelFrameworkModulePkg: Decrease the name collisions

2019-04-23 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' descriptor to the global variables that only used in a single file to minimize the name collisions. This is only for the varable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Liming Gao Cc: Dandan Bi Signed-off-by:

[edk2-devel] [PATCH V2 1/8] MdePkg/UefiDebugLibConOut: Decrease the name collisions

2019-04-23 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' descriptor to the global variables that only used in a single file to minimize the name collisions. This is only for the varable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Michael D Kinney Cc: Liming Gao Cc:

[edk2-devel] [PATCH V2 5/8] MdeModulePkg/FirmwarePerformanceDxe: Decrease the name collisions

2019-04-23 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 Add a 'static' descriptor to the global variables that only used in a single file to minimize the name collisions. This is only for the varable named 'mExitBootServicesEvent'. Cc: Laszlo Ersek Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc:

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 support

2019-04-23 Thread Michael D Kinney
One issue I see is using a FeatureFlag PCD. These PCDs can only be TRUE or FALSE, so they can not be extended later. A FixedAtBuild PCD of type BOOL has the same issue. It would be better to use a UINTx FixedAtBuild PCD, and define a bit or a value for 32-bit access. That way, if there is a

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 support

2019-04-23 Thread Wu, Hao A
> -Original Message- > From: Loh, Tien Hock > Sent: Wednesday, April 24, 2019 11:05 AM > To: devel@edk2.groups.io; thlo...@gmail.com > Cc: Loh, Tien Hock; Wang, Jian J; Wu, Hao A > Subject: [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 > support > > From: "Tien Hock, Loh"

[edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Add Mmio32 support

2019-04-23 Thread tien . hock . loh
From: "Tien Hock, Loh" Some busses doesn't allow 8 bit MMIO read/write, this adds support for 32 bits read/write Signed-off-by: "Tien Hock, Loh" Cc: Jian J Wang Cc: Hao Wu -- v2: - Updates the Pcd name to PcdSerialMmio32BitAccess and access 32 bits register if PcdSerialUseMmio and

Re: [edk2-devel] [PATCH 0/3] MdePkg/DebugLib: Change the global variable name

2019-04-23 Thread Gao, Zhichao
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 23, 2019 10:08 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Kinney, Michael D ; Gao, Liming > ; Bi, Dandan > Subject: Re: [edk2-devel] [PATCH 0/3] MdePkg/DebugLib: Change the global >

[edk2-devel] [staging/HBFA][PATCH] Announce to create "HBFA" branch in edk2-staging.

2019-04-23 Thread Sun, Tengfen
I have created a branch for evaluation version of Host-based Firmware Analyzer (HBFA) in my fork edk2-staging repo: https://github.com/tengfens/edk2-staging/tree/HBFA Please refer to the Readme.md in above link to get the detail feature introduction and refer to wiki page in my fork repo to get

[edk2-devel] [edk2-platforms/master] [patch 3/5] Platform/RaspberryPi: Update to use UefiDecompressLib in MdeModulePkg

2019-04-23 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683 We have moved the BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg, so update the consumer accordingly. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Contributed-under: TianoCore Contribution

[edk2-devel] [edk2-platforms/master] [patch 4/5] Platform/SoftIron: Update to use UefiDecompressLib in MdeModulePkg

2019-04-23 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683 We have moved the BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg, so update the consumer accordingly. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Contributed-under: TianoCore Contribution

[edk2-devel] [edk2-platforms/master] [patch 0/5] Update platforms to use UefiDecompressLib in MdeModulePkg

2019-04-23 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1683 We have moved the BaseUefiTianoCustomDecompressLib from IntelFrameworkModulePkg to MdeModulePkg, so update consumers accordingly. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Dandan Bi (5): Platform/AMD: Update to use

Re: [edk2-devel] [edk2] Request to add new edk2-libc repository

2019-04-23 Thread Michael D Kinney
Hi Laszlo, Many topics in here. Please let me know if I missed anything. 1) I did use git filter-branch to extract the history of these packages. The script I ran is shown below. It results in a local repo in the directory edk2-filter that contains the 3 packages with complete

Re: [edk2-devel] [PATCH] Emulator: update binary AARCH64 build of X64 PE/COFF emulator

2019-04-23 Thread Ard Biesheuvel
On Tue, 23 Apr 2019 at 22:33, Leif Lindholm wrote: > > On Tue, Apr 23, 2019 at 10:21:46PM +0200, Ard Biesheuvel wrote: > > Update the binary RELEASE build targeting AARCH64 systems, created > > with Ubuntu's gcc 7.3.0 using the GCC5 profile. This fixes an issue > > in the previous build which was

Re: [edk2-devel] TianoCore Community Design Meeting Minutes

2019-04-23 Thread Brian J. Johnson
On 4/23/19 1:22 PM, Laszlo Ersek wrote: On 04/19/19 07:55, Ni, Ray wrote: Hi everyone, In the first design meeting, Matthew and Sean from Microsoft presented the Mu tools. Below are some notes Mike and I captured from the meeting. Please reply to this mail for any questions and comments.

Re: [edk2-devel] [PATCH] Emulator: update binary AARCH64 build of X64 PE/COFF emulator

2019-04-23 Thread Leif Lindholm
On Tue, Apr 23, 2019 at 10:21:46PM +0200, Ard Biesheuvel wrote: > Update the binary RELEASE build targeting AARCH64 systems, created > with Ubuntu's gcc 7.3.0 using the GCC5 profile. This fixes an issue > in the previous build which was built against the wrong version of > CacheMaintenanceLib. >

Re: [edk2-devel] TianoCore Community Design Meeting Minutes

2019-04-23 Thread Laszlo Ersek
On 04/19/19 07:55, Ni, Ray wrote: > Hi everyone, > > In the first design meeting, Matthew and Sean from Microsoft presented the Mu > tools. > > Below are some notes Mike and I captured from the meeting. > > Please reply to this mail for any questions and comments. > > > > Matthew Carlson /

Re: [edk2-devel] [PATCH v3 2/2] MdeModulePkg/AhciPei: Add PEI BlockIO support

2019-04-23 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Tuesday, April 23, 2019 1:07 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Dong, > Eric ; Wang, Jian J > Subject: [edk2-devel] [PATCH v3 2/2]

Re: [edk2-devel] [PATCH v3 1/2] MdeModulePkg/AhciPei: Limit max transfer blocknum for 48-bit address

2019-04-23 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Tuesday, April 23, 2019 1:06 AM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Ni, Ray ; Dong, > Eric ; Wang, Jian J > Subject: [edk2-devel] [PATCH v3 1/2]

Re: [edk2-devel] Requestion for LTS version on EDK2

2019-04-23 Thread rebecca via Groups.Io
On 2019-04-18 17:26, Laszlo Ersek wrote: > > (1) Introduce stable *branches* to the development model. Those would be > forked off at the stable tags (well, at some of them). Would this be _re_ introducing stable branches? As explained in https://github.com/tianocore/tianocore.github.io/wiki/UDK

Re: [edk2-devel] [PATCH v2] MdeModulePkg/DxeCapsuleLibFmp: avoid ESRT accesses at runtime

2019-04-23 Thread Ard Biesheuvel
On Tue, 23 Apr 2019 at 01:02, Michael D Kinney wrote: > > Ard, > > I agree. Only consumer is only the DxeCapsuleLibFmp > itself. > > I see I had a typo on the second option. The > statement to add after the copy and ASSERT() > would be: > > mEsrtTable->FwResourceCountMax = FwResourceCount; >

答复: [edk2-devel] Requestion for LTS version on EDK2

2019-04-23 Thread liyi 00215672
Hi Laszlo, Glad to get your detailed advices, it's useful for us. We can give a label like "New feature" or "Bug fixed" to state the patch or BZ, then the LTS maintainer can easy to distinguish whether put them(patch or BZ) into LTS version. Yes, I agree we can publish

Re: [edk2-devel] [Patch] edk2: Remove AppPkg, StdLib, StdLibPrivateInternalFiles

2019-04-23 Thread Laszlo Ersek
Hi Mike, On 04/20/19 02:17, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1734 > > Remove the following packages and move them to the new > edk2-libc repository > > * AppPkg > * StdLib > * StdLibPrivateInternalFiles > > Cc: Jaben Carsey > Cc: Daryl McDaniel >

Re: [edk2-devel] [PATCH 0/3] MdePkg/DebugLib: Change the global variable name

2019-04-23 Thread Laszlo Ersek
On 04/23/19 04:35, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 > > The DebugLib instances of DebugPortProtocol, ConOut and StdErr > use a global variable "mExitBootServicesEvent" which is in > conflict with the same variable in StatusCodeHandlerRuntimeDxe.inf. >

Re: [edk2-devel] [PATCH V2 2/2] MdeModulePkg/GraphicsConsoleDxe: Do not clean the screen

2019-04-23 Thread Laszlo Ersek
On 04/23/19 09:04, Zhichao Gao wrote: > From: Aaron Antone > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1412 > > For now, most platform support to display during PEIM. It means the logo > can show at PEI phase. But the screen would be cleared at BDS connect > console phase. That may

Re: [edk2-devel] [staging/about Patch] Remove reference to Tiano Contributor's Agreement

2019-04-23 Thread Laszlo Ersek
On 04/20/19 00:54, Michael D Kinney wrote: > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README b/README > index b640a482f9..60f14a654a 100644 > --- a/README >

Re: [edk2-devel] [edk2] Request to add new edk2-libc repository

2019-04-23 Thread Laszlo Ersek
Hello Mike, On 04/20/19 02:07, Kinney, Michael D wrote: > Hello, > > There were no objections to the following RFC to add > a new edk2-libc repository. > > https://edk2.groups.io/g/devel/message/35211 > > I have entered the following Feature Request Bugzilla > >

Re: [edk2-devel] [PATCH v2 3/5] BaseTools/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-23 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo Ersek Sent: Friday, April 19, 2019 1:47 AM To: edk2-devel-groups-io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [edk2-devel] [PATCH v2 3/5]

Re: [edk2-devel] [PATCH v2 3/5] BaseTools/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-23 Thread Liming Gao
Reviewed-by: Liming Gao Sorry for the missing. > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, April 23, 2019 6:31 PM > To: Feng, Bob C ; Gao, Liming ; > Zhu, Yonghong > Cc: edk2-devel-groups-io > Subject: Re: [edk2-devel] [PATCH v2 3/5]

Re: [edk2-devel] Requestion for LTS version on EDK2

2019-04-23 Thread Laszlo Ersek
On 04/19/19 13:11, liyi 00215672 wrote: > Hi Laszlo, > > 1. If we could put some human resources into stable-branch(LTS), so could you > give us an rough assessment, how many people should we put them into that? :) Honestly: no idea. Maybe this could be estimated if all of the commits / BZs

[edk2-devel] [PATCH v3 2/2] MdeModulePkg/AhciPei: Add PEI BlockIO support

2019-04-23 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1483 This commit will add the PEI BlockIO (2) PPIs support for AHCI mode ATA devices. More specifically, the driver will consume the ATA AHCI host controller PPI for ATA controllers working under AHCI code within the system. And then produces

[edk2-devel] [PATCH v3 0/2] Add PEI BlockIO support for ATA AHCI mode devices

2019-04-23 Thread Wu, Hao A
The series is also available at: https://github.com/hwu25/edk2/tree/ahci_pei_blockio_v3 V3 changes: A. Update the comment for definition 'MAX_48BIT_TRANSFER_BLOCK_NUM'. B. Add 'EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST' attribute for mAhciAtaPassThruPpiListTemplate/mAhciBlkIoPpiListTemplate. This

[edk2-devel] [PATCH v3 1/2] MdeModulePkg/AhciPei: Limit max transfer blocknum for 48-bit address

2019-04-23 Thread Wu, Hao A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1483 Due to the limited resource on the VTd DMA buffer size in the PEI phase, the driver will limit the maximum transfer block number for 48-bit addressing. According to PCDs: gIntelSiliconPkgTokenSpaceGuid.PcdVTdPeiDmaBufferSize|0x0040

Re: [edk2-devel] [staging/about Patch] Remove reference to Tiano Contributor's Agreement

2019-04-23 Thread Philippe Mathieu-Daudé
On 4/20/19 12:54 AM, Michael D Kinney wrote: > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > --- > README | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/README b/README > index b640a482f9..60f14a654a 100644 > --- a/README

Re: [edk2-devel] [PATCH v2 4/5] MdePkg/PiFirmwareFile: fix undefined behavior in FFS_FILE_SIZE

2019-04-23 Thread Philippe Mathieu-Daudé
On 4/18/19 7:47 PM, Laszlo Ersek wrote: > Accessing "EFI_FFS_FILE_HEADER.Size", which is of type UINT8[3], through a > (UINT32*), is undefined behavior. Fix it by accessing the array elements > individually. > > Cc: Liming Gao > Cc: Michael D Kinney > Bugzilla:

Re: [edk2-devel] [PATCH v2 2/5] MdePkg/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-23 Thread Philippe Mathieu-Daudé
On 4/18/19 7:47 PM, Laszlo Ersek wrote: > RH covscan justifiedly reports that accessing > "EFI_COMMON_SECTION_HEADER.Size", which is of type UINT8[3], through a > (UINT32*), is undefined behavior: > >> Error: OVERRUN (CWE-119): >> edk2-89910a39dcfd/OvmfPkg/Sec/SecMain.c:178: overrun-local:

Re: [edk2-devel] [PATCH v2 3/5] BaseTools/PiFirmwareFile: fix undefined behavior in SECTION_SIZE

2019-04-23 Thread Philippe Mathieu-Daudé
On 4/18/19 7:47 PM, Laszlo Ersek wrote: > Sync SECTION_SIZE() from MdePkg to BaseTools, from an earlier patch in > this series. > > Cc: Bob Feng > Cc: Liming Gao > Cc: Yonghong Zhu > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1710 > Signed-off-by: Laszlo Ersek > --- > > Notes:

Re: [edk2-devel] [PATCH 0/3] MdePkg/DebugLib: Change the global variable name

2019-04-23 Thread Philippe Mathieu-Daudé
On 4/23/19 4:35 AM, Gao, Zhichao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1740 > > The DebugLib instances of DebugPortProtocol, ConOut and StdErr > use a global variable "mExitBootServicesEvent" which is in > conflict with the same variable in StatusCodeHandlerRuntimeDxe.inf.

Re: [edk2-devel] [PATCH 0/3] Remove ICC tool chain

2019-04-23 Thread Liming Gao
The change is good. And, please update the patch based on the latest trunk. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Zhang, > Shenglei > Sent: Tuesday, April 9, 2019 11:21 AM > To:

[edk2-devel] [PATCH V2 1/2] MdeModulePkg/ConSplitterDxe: Optimize the ConSplitterTextOutSetMode

2019-04-23 Thread Gao, Zhichao
From: Aaron Antone REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1412 For Console Out device, it would always set all present devices' text out mode again through ConSplitterTextOutSetMode while adding devices. That may cause the screen cleared for serval times. So add a BOOLEAN to judge

[edk2-devel] [PATCH V2 2/2] MdeModulePkg/GraphicsConsoleDxe: Do not clean the screen

2019-04-23 Thread Gao, Zhichao
From: Aaron Antone REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1412 For now, most platform support to display during PEIM. It means the logo can show at PEI phase. But the screen would be cleared at BDS connect console phase. That may make the screen flush and turn into black screen. So

[edk2-devel] [PATCH V2 0/2] MdeModulePkg: Make the screen seamless

2019-04-23 Thread Gao, Zhichao
For now most platforms support display function at PEI phase. But the conspliter and graphics console driver would clear the screen at BDS connect console phase. Maybe some platforms would show logo in the next or maybe not. For consumers, it looks like the screen flashed. So change the behavior

[edk2-devel] [patch 0/2] Fix Emulator ASSERT issue when re-enter setup

2019-04-23 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1728 Currently Emulator meets ASSERT when enter setup->Continue->enter setup. When re-enter setup, in the Constructor functions of some Libs linked by UiApp, the handle is not NULL which cause InstallMultipleProtocolInterfaces failure then

[edk2-devel] [patch 2/2] MdeModulePkg/FileExplorer: Set Handle to NULL after uninstall protocol

2019-04-23 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1728 Currently Emulator meets ASSERT when enter setup->Continue->enter setup. When re-enter setup, the FeDriverHandle in FileExplorerLib Constructor is not NULL which cause InstallMultipleProtocolInterfaces failure, then ASSERT. So here set

Re: [edk2-devel] [PATCH v2 0/2] Add PEI BlockIO support for ATA AHCI mode devices

2019-04-23 Thread Ni, Ray
> -Original Message- > From: Wu, Hao A > Sent: Monday, April 22, 2019 10:18 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Dong, Eric ; Wang, Jian J > Subject: RE: [PATCH v2 0/2] Add PEI BlockIO support for ATA AHCI mode > devices > > > -Original Message- > > From: Ni, Ray > >

Re: [edk2-devel] [PATCH] BaseTools/tools_def.template: Remove tools chain with ASL tool

2019-04-23 Thread Liming Gao
Shenglei: Please also remove MS_ASL_ or WIN_ASL_ definitions in tools_def.template. After ASL tool chain is removed, those definitions will not be required. Thanks Liming > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, April 16, 2019 11:54 AM > To: devel@edk2.groups.io >

Re: [edk2-devel] [PATCH 3/3] BaseTools: Remove ICC tool chain in tools_def.template

2019-04-23 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Zhang, > Shenglei > Sent: Tuesday, April 9, 2019 11:21 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming ; > Zhu, Yonghong > Subject: [edk2-devel] [PATCH