[edk2-devel] [patch] BaseTools/VfrCompile: clean Framework Vfr support

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1464 This commit is to do the cleanup which are missing in previous commit 1b72fd5121b5b31918be0a9a0868a39070d4c8d4 BaseTools/VfrCompile: Remove framework VFR support Cc: Bob Feng Cc: Liming Gao Signed-off-by: Dandan Bi ---

Re: [edk2-devel] [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: Extend build to support Binary Cache

Reviewed-by: Chasel Chiu > -Original Message- > From: Shi, Steven > Sent: Thursday, May 9, 2019 11:21 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Lu, Shifei A > ; > Gao, Liming ; Bi, Dandan ; > Kubacki, Michael A > Subject: [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: Extend

[edk2-devel] [PATCH] UefiCpuPkg PiSmmCpuDxeSmm: Only support IN/OUT IO save state read (CVE-2018-12182)

From: Star Zeng BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1136 CVE: CVE-2018-12182 Customer met system hang-up during serial port loopback test in OS. It is a corner case happened with one CPU core doing "out dx,al" and another CPU core(s) doing "rep outs dx,byte ptr [rsi]". Detailed

[edk2-devel] [Patch 1/2] edk2: Remove packages moved to edk2-platforms

https://bugzilla.tianocore.org/show_bug.cgi?id=1467 https://bugzilla.tianocore.org/show_bug.cgi?id=1374 https://bugzilla.tianocore.org/show_bug.cgi?id=1793 Remove the following packages that have been imported to edk2-platforms/master * Omap35xxPkg * BeagleBoardPkg * QuarkSocPkg *

[edk2-devel] [Patch 2/2] edk2: Update Maintainers.txt for packages moved to edk2-platforms

https://bugzilla.tianocore.org/show_bug.cgi?id=1467 https://bugzilla.tianocore.org/show_bug.cgi?id=1374 https://bugzilla.tianocore.org/show_bug.cgi?id=1793 Remove maintainers for ththe following packages that have been imported to edk2-platforms/master * Omap35xxPkg * BeagleBoardPkg *

[edk2-devel] [edk2-platforms: Patch 8/8] edk2-platforms: Update Maintainers.txt/Readme.md for imported packages

https://bugzilla.tianocore.org/show_bug.cgi?id=1467 https://bugzilla.tianocore.org/show_bug.cgi?id=1374 https://bugzilla.tianocore.org/show_bug.cgi?id=1793 Update Maintainers.txt for the following packages: * Drivers/OptionRomPkg * Platform/BeagleBoard/BeagleBoardPkg *

[edk2-devel] [PATCH v3 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak

Since TianoCore EDK2 commit d65f2cea36d1 ("ShellPkg/CommandLib: Locate proper UnicodeCollation instance") in edk2 the UEFI Shell crashes if EFI variable PlatformLang is not defined due to dereferencing gUnicodeCollation gUnicodeCollation (= NULL) in ShellCommandRegisterCommandName(). Furthermore

Re: [edk2-devel] [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch

Yes. Sorry for this mistake. I will keep original owner in the commit. Thanks Liming >-Original Message- >From: Kubacki, Michael A >Sent: Friday, May 10, 2019 10:47 AM >To: Gao, Liming ; Leif Lindholm > >Cc: edk2-devel-groups-io ; >ard.biesheu...@linaro.org; Kinney, Michael D >Subject:

Re: [edk2-devel] RFC for Edk2-Library

1. Agree on the name but not sure whats better.  i don't think it should be edk2-tools because the idea of this is to be a library of support code but not the tools themselves.  This limits dependencies and keeps the library free of business specific logic.  The second RFC will be for a new

Re: [edk2-devel] [Patch][edk2-platform] Migrate devel-MinPlatform branch to master branch

Liming, I have no concern with the plan. I've noticed authors change In a few recent commits on master_minplatform, I'd prefer they stay consistent if possible. Thanks, Michael > -Original Message- > From: Gao, Liming > Sent: Wednesday, May 8, 2019 8:31 PM > To: Leif Lindholm > Cc:

Re: [edk2-devel] [PATCH] Maintainers.txt: Update the name of 'Hao Wu' to 'Hao A Wu'

> -Original Message- > From: Gao, Liming > Sent: Wednesday, May 08, 2019 1:40 PM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Wang, Jian J; Ni, Ray > Subject: RE: [PATCH] Maintainers.txt: Update the name of 'Hao Wu' to 'Hao A > Wu' > > Reviewed-by: Liming Gao Thanks, pushed via commit

[edk2-devel] [PATCH v2 1/1] EmbeddedPkg: Fix DwEmmc read/write size in preparing DMA size

From: "Tien Hock, Loh" Add support for reading data that is less than DWEMMC_BLOCK_SIZE, otherwise it would read bigger data than requested and cause errors Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel -- v2: - Fix white space issue ---

Re: [edk2-devel] RFC for Edk2-Library

Laszlo, I forgot to mention that pip supports virtual environments. https://packaging.python.org/guides/installing-using-pip-and-virtual-environments/ This means that a virtual environment can be created for EDK II builds and pip install operations can be performed in that EDK II specific

[edk2-devel] Upcoming Event: TianoCore Community Meeting - APAC/NAMO - Thu, 05/09/2019 7:30pm-8:00pm #cal-reminder

*Reminder:* TianoCore Community Meeting - APAC/NAMO *When:* Thursday, 9 May 2019, 7:30pm to 8:00pm, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/769108409 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=456841 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com

[edk2-devel] [PATCH] BaseTools: Check the fread function and avoid dead loop

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1789 If the input file is not a valid file, it may cause dead loop, because the return of fread function is not checked. Signed-off-by: Zhiguang Liu Cc: Bob Feng Cc: Liming Gao --- BaseTools/Source/C/VolInfo/VolInfo.c | 11 +-- 1

Re: [edk2-devel] [Patch V2] Vlv2TbltDevicePkg: Update Readme.md

Reviewed-by: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Friday, May 10, 2019 12:04 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch V2] Vlv2TbltDevicePkg: Update Readme.md > > Cc: Zailiang Sun > Cc: Yi Qian > Signed-off-by:

[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Thu, 05/09/2019 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Thursday, 9 May 2019, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/969264410 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=456811 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com (

Re: [edk2-devel] RFC for Edk2-Library

Laszlo, 1) We also use OpenSSL command line tool to locally sign capsules and recovery images for local testing. So both tool dependency and source dependency apply to the OpenSSL content. 2) If a dev submits a PR, and there are many review comments that require code changes, then

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

Hello Christian, On 05/09/19 23:27, Christian Rodriguez wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1787 > > Get a list of local header files that are not present in the > MetaFile for this module. Add those local header files into > the hashing algorithm for a module. If a local

Re: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

Some questions inline. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Christian Rodriguez > Sent: Thursday, May 09, 2019 2:27 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Zhu, Yonghong > Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [Patch] OvmfPkg/QemuVideoDxe: Remove dependency on OptionRomPkg

Hello Mike, On 05/09/19 19:39, Michael D Kinney wrote: > Update the QemuVideoDxe driver to not depend on the > OptionRomPkg to support moving OptionRomPkg to the > edk2-platforms repository. > > The only dependency on the OptionRomPkg is the use of > PcdDriverSupportedEfiVersion to set the

Re: [edk2-devel] RFC for Edk2-Library

On 05/09/19 20:06, Kinney, Michael D wrote: > Hello, > > It is difficult to tell if the repo name edk2-library is for firmware > or tools, so I recommend we work on a name that clearly identifies > that this repo is related to tools. Good idea. > For the pip dependencies, is the concern that a

Re: [edk2-devel] [PATCH v2 6/6] CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible

On 05/09/19 16:20, Wang, Jian J wrote: > Laszlo, > > >> -Original Message- >> From: Laszlo Ersek [mailto:ler...@redhat.com] >> Sent: Thursday, May 09, 2019 10:02 PM >> To: devel@edk2.groups.io; Lu, XiaoyuX >> Cc: Wang, Jian J ; Ye, Ting >> Subject: Re: [edk2-devel] [PATCH v2 6/6]

[edk2-devel] [PATCH] BaseTools: Include headers not mentioned in inf are not hashed

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1787 Get a list of local header files that are not present in the MetaFile for this module. Add those local header files into the hashing algorithm for a module. If a local header file is not present in the MetaFile, the module will still build

Re: [edk2-devel] RFC for Edk2-Library

Hello, It is difficult to tell if the repo name edk2-library is for firmware or tools, so I recommend we work on a name that clearly identifies that this repo is related to tools. For the pip dependencies, is the concern that a platform that depends on these tools will not be buildable without

[edk2-devel] [Patch] OvmfPkg/QemuVideoDxe: Remove dependency on OptionRomPkg

Update the QemuVideoDxe driver to not depend on the OptionRomPkg to support moving OptionRomPkg to the edk2-platforms repository. The only dependency on the OptionRomPkg is the use of PcdDriverSupportedEfiVersion to set the version value in the EFI Driver Supported EFI Version Protocol. This

Re: [edk2-devel] [PATCH v2 5/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

On 05/09/19 19:15, Laszlo Ersek wrote: > How about the following: > > - It seems like we cannot convince OpenSSL to *never* call these > functions, under UEFI. > > - We also cannot provide an implementation that is *guaranteed* to be > secure enough, IMO. > > - It seems like these

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform] [PATCH] Added an optional SplitFspBin.py path argument

Reviewed-by: Michael Kubacki Tested-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Agyeman, Prince > Sent: Tuesday, April 30, 2019 4:29 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Desimone, > Nathaniel L ;

[edk2-devel] [Patch V2] Vlv2TbltDevicePkg: Update Readme.md

Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- Vlv2TbltDevicePkg/Readme.md | 242 +--- 1 file changed, 200 insertions(+), 42 deletions(-) diff --git a/Vlv2TbltDevicePkg/Readme.md b/Vlv2TbltDevicePkg/Readme.md index 139aa4ea61..cbbb465b69

[edk2-devel] Upcoming Event: TianoCore Community Meeting - EMEA/NAMO - Thu, 05/09/2019 9:00am-10:00am #cal-reminder

*Reminder:* TianoCore Community Meeting - EMEA/NAMO *When:* Thursday, 9 May 2019, 9:00am to 10:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/188375690 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=456814 ) *Organizer:* Stephano Cetola

[edk2-devel] Upcoming Event: TianoCore Design Meeting - EMEA/NAMO - Thu, 05/09/2019 8:00am-9:00am #cal-reminder

*Reminder:* TianoCore Design Meeting - EMEA/NAMO *When:* Thursday, 9 May 2019, 8:00am to 9:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/571317753 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=456808 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com (

Re: [edk2-devel] [PATCH] BaseTools: Skip .mcb file module in Binary Cache

Cool. Thanks! Then I would like to see a patch to remove INC check. :) > -Original Message- > From: Gao, Liming > Sent: Thursday, May 9, 2019 7:05 AM > To: Yao, Jiewen ; Shi, Steven > ; devel@edk2.groups.io > Cc: Feng, Bob C ; Rodriguez, Christian > ; Johnson, Michael > > Subject: RE:

Re: [edk2-devel] [PATCH v2 6/6] CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible

Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, May 09, 2019 10:02 PM > To: devel@edk2.groups.io; Lu, XiaoyuX > Cc: Wang, Jian J ; Ye, Ting > Subject: Re: [edk2-devel] [PATCH v2 6/6] CryptoPkg/BaseCryptLib: Make > HMAC_CTX size backward

Re: [edk2-devel] [Patch V3] BaseTools: Correct the value assignment for StructurePcd

I think the test case is enough. I have no comments on the code logic. Reviewed-by: Liming Gao > -Original Message- > From: Fan, ZhijuX > Sent: Thursday, May 9, 2019 5:20 PM > To: devel@edk2.groups.io > Cc: Gao, Liming > Subject: [Patch V3] BaseTools: Correct the value assignment for

Re: [edk2-devel] [PATCH V2] BaseTools:Enables FFS to support the GUID value format

Reviewed-by: Liming Gao > -Original Message- > From: Fan, ZhijuX > Sent: Thursday, May 9, 2019 7:59 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [PATCH V2] BaseTools:Enables FFS to support the GUID value format > >

Re: [edk2-devel] [PATCH v2 6/6] CryptoPkg/BaseCryptLib: Make HMAC_CTX size backward compatible

On 05/09/19 07:23, Xiaoyu lu wrote: > From: Xiaoyu Lu > > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 > > OpenSSL internally redefines the size of HMAC_CTX at > crypto/hmac/hmac_lcl.h(OpenSSL commit e0810e35). In my review at , I

Re: [edk2-devel] [PATCH] BaseTools: Skip .mcb file module in Binary Cache

Jiewen: Yes. This is current tool design to leave the configuration instead of hard code. I would like to let tool owner to check this logic. Thanks Liming > -Original Message- > From: Yao, Jiewen > Sent: Thursday, May 9, 2019 8:35 PM > To: Shi, Steven ; Gao, Liming ; >

Re: [edk2-devel] [PATCH v2 4/6] CryptoPkg/OpensslLib: Prepare for upgrading OpenSSL

On 05/09/19 07:23, Xiaoyu lu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 > > Disable warning for building OpenSSL_1_1_1b > > add /wd4132 /wd4700 /wd4310 for Visual Studio in OpensslLib[Crypto].inf > > add -Wno-error=unused-but-set-variable for GCC in OpensslLib[Crypto].inf

Re: [edk2-devel] [PATCH v2 2/6] CryptoPkg/OpensslLib: Exclude unnecessary files in process_files.pl

On 05/09/19 07:23, Xiaoyu lu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 > > When running process_files.py to configure OpenSSL, we can exclude > some unnecessary files. This can reduce porting time, compiling > time and library size. Indeed. > OpenSSL_1_1_1(1708e3e85b4a8)

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 31 January 2019 01:30 PM To: edk2-de...@lists.01.org Cc: jaben.car...@intel.com; ray...@intel.com; Matteo Carlini ; Stephanie Hughes-Fitt ; Sami Mujawar ; nd Subject: [PATCH v1 1/1]

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: Add GT Frame Number validation to GTDT parser

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 08 May 2019 02:44 PM To: devel@edk2.groups.io Cc: jaben.car...@intel.com; ray...@intel.com; Sami Mujawar ; Girish Pathak ; Pierre Gondois ; Matteo Carlini ; Stephanie Hughes-Fitt ; nd

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Display VENDOR_ID in ASCII when parsing PPTT

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 08 May 2019 02:14 PM To: devel@edk2.groups.io Cc: jaben.car...@intel.com; ray...@intel.com; Sami Mujawar ; Girish Pathak ; Pierre Gondois ; Matteo Carlini ; Stephanie Hughes-Fitt ; nd

Re: [edk2-devel] [patch] ShellBinPkg: Remove ShellBinPkg

Hi Mike, thank you for that information. >From my point of view there should always be public access to a trusted shell >binary. The UEFI Shell as a successor of MSDOS, that is booted instantly, has full HW access shall be usable for production, quality assurance, provisioning in the PC

Re: [edk2-devel] [Patch 15/16] Vlv2TbltDevicePkg/Capsule: Add Linux/LVFS generation scripts

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 15/16] Vlv2TbltDevicePkg/Capsule: Add Linux/LVFS generation scripts Add batch scripts to generate

Re: [edk2-devel] [Patch 12/16] Vlv2TbltDevicePkg: Remove directory assumptions from build scripts

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 12/16] Vlv2TbltDevicePkg: Remove directory assumptions from build scripts In preparation for

Re: [edk2-devel] [Patch 13/16] Vlv2TbltDevicePkg/Capsule: Do not clear UEFI varstore

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 13/16] Vlv2TbltDevicePkg/Capsule: Do not clear UEFI varstore Preserve the UEFI Variable store when

Re: [edk2-devel] [Patch 14/16] Vlv2TbltDevicePkg/Capsule: Remove path to openssl tools

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 14/16] Vlv2TbltDevicePkg/Capsule: Remove path to openssl tools Remove path to openssl tools from

Re: [edk2-devel] [Patch 09/16] Vlv2TbltDevicePkg: Add PchInitSmm module

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 09/16] Vlv2TbltDevicePkg: Add PchInitSmm module Add the PcdInitSmm module that should not have been

Re: [edk2-devel] [Patch 11/16] Vlv2TbltDevicePkg/Stitch/Gcc: Update default setting binary

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 11/16] Vlv2TbltDevicePkg/Stitch/Gcc: Update default setting binary Update the binary file that

Re: [edk2-devel] [Patch 05/16] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix GCC build issue

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Michael D Kinney ; Sun, Zailiang ; Qian, Yi Subject: [Patch 05/16] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix GCC build issue From: Michael D

Re: [edk2-devel] [Patch 10/16] Vlv2TbltDevicePkg: Always enable QuietBoot to produce BGRT

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 10/16] Vlv2TbltDevicePkg: Always enable QuietBoot to produce BGRT Cc: Zailiang Sun Cc: Yi Qian

Re: [edk2-devel] [Patch 06/16] Vlv2TbltDevicePkg: Find UEFI Shell using gUefiShellFileGuid

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 06/16] Vlv2TbltDevicePkg: Find UEFI Shell using gUefiShellFileGuid Remove use of PCD PcdShellFile

Re: [edk2-devel] [Patch 07/16] Vlv2TbltDevicePkg: Build full UEFI Shell from sources

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 07/16] Vlv2TbltDevicePkg: Build full UEFI Shell from sources Update DSC files to build full UEFI

Re: [edk2-devel] [Patch 02/16] Vlv2TbltDevicePkg/AcpiPlatform: Change Size type to UINTN

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 02/16] Vlv2TbltDevicePkg/AcpiPlatform: Change Size type to UINTN Change the type of the local

Re: [edk2-devel] [Patch 04/16] Vlv2TbltDevicePkg/PpmPolicy: Fix call to MP Services Protocol

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 04/16] Vlv2TbltDevicePkg/PpmPolicy: Fix call to MP Services Protocol The NumberOfEnabledProcessors

Re: [edk2-devel] [Patch 08/16] Vlv2TbltDevicePkg: Use CpuDxe from UefiCpuPkg

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 08/16] Vlv2TbltDevicePkg: Use CpuDxe from UefiCpuPkg Use CpuDxe module from UefiCPuPkg instead of

Re: [edk2-devel] [Patch 00/16] Vlv2TbltDevicePkg: Sync with edk2/master

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 00/16] Vlv2TbltDevicePkg: Sync with edk2/master Fix a number of small issues for MinnowMax to build

Re: [edk2-devel] [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable protocols to depex

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable protocols to depex Add the arch protocols

Re: [edk2-devel] [Patch 01/16] Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add error return

Reviewed by Qian, Yi Thanks QianYi -Original Message- From: Kinney, Michael D Sent: Thursday, May 9, 2019 12:31 PM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [Patch 01/16] Vlv2TbltDevicePkg/PlatformFlashAccessLib: Add error return If the FLASH device cannot be

Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.

Hey When I read https://bugzilla.tianocore.org/show_bug.cgi?id=1782, it says: "Current opal driver send blockSid command at ReadyToBoot event, it should been update to EndOfDxe point. Submit this bz to update the code." But this patch is to update the default value. I am very confused. May I

Re: [edk2-devel] [PATCH] Marvell/Drivers: MvFvbDxe: Fix compilation error

On Thu, May 09, 2019 at 01:24:21AM +0200, Marcin Wojtas wrote: > Commit cee103d37d6b ("Marvell/Drivers: MvFvbDxe: Introduce non-mmio mode) > introduced a compilation error, visible with certain toolchains. > Fix that. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by:

Re: [edk2-devel] [PATCH] BaseTools: Skip .mcb file module in Binary Cache

Thanks to explain that. I think my general concern is: why we hardcode file suffix "INC" or "MCB" in the tool source code. > > > > -if '.inc' in str(f_ext): > > > > +if '.inc' in str(f_ext) or '.mcb' in str(f_ext): > > > > return False What happen if we

[edk2-devel] [PATCH V2] BaseTools:Enables FFS to support the GUID value format

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1768 Per FDF spec, FFS Rule can specify the hard code FILE Guid value. But,BaseTools reports the build failure.It should be fixed. This patch is going to fix that issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan ---

Re: [edk2-devel] [edk2-platforms] [patch v2 0/7] Update UefiDecompressLib instance

On Thu, May 09, 2019 at 12:43:15AM +, Dandan Bi wrote: > > > Cc: Ard Biesheuvel > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > > For the series: > > Reviewed-by: Leif Lindholm > > > > Are you happy to push these yourself? > > Could you help to push them? Since I don't have the

Re: [edk2-devel] [PATCH v2 1/6] CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL

On 05/09/19 07:23, Xiaoyu lu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 > > OpenSSL configure mechanism use --with-rand-seed=xxx option to configure > random number generation. > > OpenSSL_1_1_0j(74f2d9c1ec5f5510e1d3da5a9f03c28df0977762) > we use default

Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.

On 05/09/19 05:03, Wu, Hao A wrote: >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dong, >> Eric >> Sent: Wednesday, May 08, 2019 11:02 AM >> To: devel@edk2.groups.io >> Cc: Wu, Hao A >> Subject: [edk2-devel] [Patch v2 1/3]

Re: [edk2-devel] [edk2-platforms: PATCH 04/14] Marvell/Armada7k8k: Extend board description libraries with PCIE

czw., 9 maj 2019 o 11:53 Marcin Wojtas napisał(a): > > This patch extends ArmadaBoardDescLib libraries for all > existing Armada7k8k-based platforms with PCIE. > It introduces ArmadaBoardPcieControllerGet routine with > per-board PCIE controllers description. > > Contributed-under: TianoCore

[edk2-devel] [edk2-platforms: PATCH 13/14] Marvell/Armada7k8k: Remove duplication in .dsc files

Mistakenly in all Marvell Armada7k8k .dsc files '[LibraryClasses.common]' section was split. Merge entries into one for each platform. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc| 4 +---

Re: [edk2-devel] [Patch v2 1/3] SecurityPkg/SecurityPkg.dec: Change default value.

On 05/08/19 05:01, Dong, Eric wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1782 > > Change BlockSID default policy, default enable BlockSid. > > Signed-off-by: Eric Dong > Cc: Hao Wu > --- > SecurityPkg/Include/Library/Tcg2PhysicalPresenceLib.h | 3 ++- >

[edk2-devel] [edk2-platforms: PATCH 07/14] Marvell/Armada7k8k: Implement PciHostBridgeLib

Add an implementation of the PciHostBridgeLib glue library that describes the PCIe RC on this SoC so that the generic PCI host bridge driver can attach to it. This includes a constructor which performs the SoC specific init and training sequences. This patch is based on work of Ard Biesheuvel

[edk2-devel] [edk2-platforms: PATCH 05/14] Marvell/Armada7k8k: MvBoardDesc: Extend protocol with PCIE support

Introduce new callback that can provide information about PCIE controllers, which are used on the platform. According ArmadaSoCDescLib ArmadaBoardDescLib routines are used for obtaining required data. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2-devel] [edk2-platforms: PATCH 01/14] Marvell/Library: MvGpioLib: Extend GPIO pin description

In order to avoid hardcoding the controller type when using MV_GPIO_PIN, extend this structure with new according field. This patch is required to properly handle PCIE slot reset with the GPIO pin. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2-devel] [edk2-platforms: PATCH 09/14] Marvell/Armada80x0McBin: Enable ACPI PCIE support

This patch adds description of the PCIE controller in ACPI tables of MacchiatoBin community board. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/AcpiTables/Armada80x0McBin.inf | 1 +

[edk2-devel] [edk2-platforms: PATCH 03/14] Marvell/Library: ArmadaBoardDescLib: Add PCIE information

Introduce new callback that can provide information about PCIE controller per-board description. A new structure is defined containing base addresses, windows/bus configuration and reset GPIO usage indication. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas

[edk2-devel] [edk2-platforms: PATCH 11/14] Marvell/Armada70x0Db: Enable ACPI PCIE support

This patch adds description of the PCIE controller in ACPI tables of Armada 7040 DB board. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db.inf | 1 +

[edk2-devel] [edk2-platforms: PATCH 04/14] Marvell/Armada7k8k: Extend board description libraries with PCIE

This patch extends ArmadaBoardDescLib libraries for all existing Armada7k8k-based platforms with PCIE. It introduces ArmadaBoardPcieControllerGet routine with per-board PCIE controllers description. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2-devel] [edk2-platforms: PATCH 00/14] Armada7k8k PCIE support

Hi, Hereby I submit Armada7k8k PCIE support. The commits allow to use single controller on each of currently supported boards (MacchiatoBin, A7040/A8040-DB) both in firmware and in OS with ACPI boot. Multiple slots, using custom PciSegmentLib, will be added later. Current patchset can be grouped

[edk2-devel] [edk2-platforms: PATCH 06/14] Marvell/Armada7k8k: Add PciExpressLib implementation

From: Ard Biesheuvel Implement a special version of PciExpressLib that takes the quirky nature of the Synopsys Designware PCIe IP into account. In particular, we need to ignores config space accesses to all devices on the first bus except device 0, because the broadcast nature of type 0

[edk2-devel] [edk2-platforms: PATCH 12/14] Marvell/Armada80x0McBin: DeviceTree: Use pci-host-generic driver

Now as the OS clock configuration is inherited from the firmware, and PCIE is also configured, switch safely MacchiatoBin board to use the pci-host-generic driver. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2-devel] [edk2-platforms: PATCH 14/14] Marvell/Armada7k8: Add 'acpiview' shell command to build

To help diagnose ACPI related boot problems, include the 'acpiview' builtin shell command to Armada7k8k build of the UEFI Shell. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + 1 file changed, 1

[edk2-devel] [edk2-platforms: PATCH 08/14] Marvell/Armada7k8k: Enable PCIE support

Wire up the platform libraries to the generic drivers so that we can use PCI devices and UEFI, and leave the controller initialized so that the OS can boot it using a generic driver of its own. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas ---

[edk2-devel] [edk2-platforms: PATCH 02/14] Marvell/Library: ArmadaSoCDescLib: Add PCIE information

This patch introduces new library callback (ArmadaSoCPcieGet ()), which dynamically allocates and fills array with all available PCIE controllers' base addresses. It is needed for the configuration of PCIE, whose support will be added in the upcoming patches. Contributed-under: TianoCore

[edk2-devel] [PATCH] BaseTools:Enables FFS to support the GUID value format

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1768 Per FDF spec, FFS Rule can specify the hard code FILE Guid value. But,BaseTools reports the build failure.It should be fixed. This patch is going to fix that issue. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Zhiju.Fan ---

[edk2-devel] [Patch V3] BaseTools: Correct the value assignment for StructurePcd

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1752 This patch is to fix the code bug in StructurePcd overall value assignment logic. If a Pcd Array size is fixed but the size of actual value in Dsc or Dec is bigger than the Pcd array size, the tool will report error about such setting and

[edk2-devel] [PATCH v2 1/1] MdeModulePkg: BaseSerialPortLib16550: Add missing Pcd to UNI

From: "Tien Hock, Loh" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1771 Some busses doesn't allow 8 bit MMIO read/write, this adds support for 32 bits read/write. This patch adds the UNI information on the new Pcd introduced - PcdSerialRegisterAccessWidth Signed-off-by: "Tien Hock, Loh"

[edk2-devel] [PATCH v2 0/6] CryptoPkg: Upgrade OpenSSL to 1.1.1b

(1) CryptoPkg/OpensslLib: Modify process_files.pl for upgrading OpenSSL OpenSSL_1_1_1b(50eaac9f3337667259de725451f201e784599687) only support seeding NONE for UEFI(rand_unix.c line 93). So add --with-rand-seed=none to process_files.pl. (2) CryptoPkg/OpensslLib: Exclude unnecessary files in

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: BaseSerialPortLib16550: Update Mmio32 to UNI

> -Original Message- > From: Wu, Hao A > Sent: Thursday, May 9, 2019 2:37 PM > To: devel@edk2.groups.io; Loh, Tien Hock ; > thlo...@gmail.com > Cc: tien.hock.loh ; Wang, Jian J > ; Zhu, Yonghong > Subject: RE: [edk2-devel] [PATCH 1/1] MdeModulePkg: > BaseSerialPortLib16550: Update Mmio32

[edk2-devel] [[edk2-platforms]PATCH v4 1/1] Platform: Intel: Add Stratix 10 platform support

From: "Tien Hock, Loh" Adds support for Intel Stratix 10 Platform. Signed-off-by: "Tien Hock, Loh" Contributed-under: TianoCore Contribution Agreement 1.1 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney -- v4 - Removed LibC - Added NOOPT to BUILD_TARGETS - Removed ARM from

Re: [edk2-devel] [Patch 02/16] Vlv2TbltDevicePkg/AcpiPlatform: Change Size type to UINTN

Reviewed-by: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch 02/16] Vlv2TbltDevicePkg/AcpiPlatform: Change Size type to > UINTN > > Change the type of the

[edk2-devel] [PATCH v2] EmbeddedPkg: Fix DwEmmc SendCommand polling

From: "Tien Hock, Loh" Change SendCommand polling mode to remove unnecessary delay, and check for transfer done only when block data is to be read/write. This would also increase performance slightly. Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel ---

[edk2-devel] [PATCH v2] EmbeddedPkg: Clear CTYPE on initialization

From: "Tien Hock, Loh" Clear CTYPE on initialization. This is important if previous bootloader changes the CTYPE can cause the controller to not initialize correctly if CTYPE is not reset to 0 Signed-off-by: "Tien Hock, Loh" Cc: Leif Lindholm Cc: Ard Biesheuvel ---

Re: [edk2-devel] [Patch 16/16] Vlv2TbltDevicePkg: Update Readme.md

Hi Michael, It seems that GCC build instructions does not work. Tried adding a line "cd .." before the line "mkdir Conf" then it worked. > -Original Message- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi >

Re: [edk2-devel] [Patch 12/16] Vlv2TbltDevicePkg: Remove directory assumptions from build scripts

Reviewed-by: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch 12/16] Vlv2TbltDevicePkg: Remove directory assumptions > from build scripts > > In preparation for

Re: [edk2-devel] [Patch 14/16] Vlv2TbltDevicePkg/Capsule: Remove path to openssl tools

Reviewed-by: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch 14/16] Vlv2TbltDevicePkg/Capsule: Remove path to openssl > tools > > Remove path to openssl tools

Re: [edk2-devel] [Patch 13/16] Vlv2TbltDevicePkg/Capsule: Do not clear UEFI varstore

Reviewed-by: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch 13/16] Vlv2TbltDevicePkg/Capsule: Do not clear UEFI varstore > > Preserve the UEFI Variable store

Re: [edk2-devel] [Patch 11/16] Vlv2TbltDevicePkg/Stitch/Gcc: Update default setting binary

Reviewed-by: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch 11/16] Vlv2TbltDevicePkg/Stitch/Gcc: Update default setting > binary > > Update the binary file

Re: [edk2-devel] [Patch 10/16] Vlv2TbltDevicePkg: Always enable QuietBoot to produce BGRT

Reviewed-by: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch 10/16] Vlv2TbltDevicePkg: Always enable QuietBoot to > produce BGRT > > Cc: Zailiang Sun > Cc: Yi

Re: [edk2-devel] [Patch 05/16] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix GCC build issue

Reviewed-by: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Michael D Kinney ; Sun, > Zailiang ; Qian, Yi > Subject: [Patch 05/16] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix GCC build > issue > > From:

Re: [edk2-devel] [Patch 04/16] Vlv2TbltDevicePkg/PpmPolicy: Fix call to MP Services Protocol

Reviewed-by: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch 04/16] Vlv2TbltDevicePkg/PpmPolicy: Fix call to MP Services > Protocol > > The

Re: [edk2-devel] [Patch 08/16] Vlv2TbltDevicePkg: Use CpuDxe from UefiCpuPkg

Reviewed-by: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch 08/16] Vlv2TbltDevicePkg: Use CpuDxe from UefiCpuPkg > > Use CpuDxe module from UefiCPuPkg instead

  1   2   >