Three text files have invalid ASCII bytes, this can mess up tooling
that trys to operate on the repository, which will accidentally
classify them as binary data.
https://github.com/josephlr/edk2/tree/format
Cc: Bob Feng
Cc: Liming Gao
Cc: Yonghong Zhu
Signed-off-by: Joe Richey
---
BaseTools/
Hi,
I've come across what to me looks like a bug, but is probably a
misunderstanding of how to use the EFI_TCP4_PROTOCOL.
Under OVMF (I've not tried anything else), I've found that when I call
tcp4->Close(), tcp4->Configure() with NULL to reset it, then
tcp4->Connect() the TCP stack reports in t
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Friday, May 10, 2019 11:46 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang ; Qian, Yi ;
> Steele, Kelly ; Ni, Ray ; Kubacki,
> Michael A ; Leif Lin
Similarly, once the packages are moved to edk2-platforms.
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Friday, May 10, 2019 11:09 AM
> To: Kinney, Michael D
> Cc: devel@edk2.groups.io; Sun, Zailiang ; Qian, Yi
> ; Stee
Hi Mike,
If you explicitly didn't change any of the files, then I'm totally
happy with the typo fixed. For Omap35xxPkg and BeagleBoardPkg:
Reviewed-by: Leif Lindholm
Regards,
Leif
On Fri, May 10, 2019 at 07:16:47PM +, Kinney, Michael D wrote:
> Leif,
>
> Thanks. I will fix the typo.
>
>
Hashing is not changing file format requirements as Basetools has no
requirement on this even though the spec does have file requirements. That's
why the initial patch was a workaround of sorts because it is allowed by
Basetools to have local headers not in the sources section of the meta file.
My suggestion would be to always break a build (no matter what the hashing
settings are).
Hashing is just an optimization technique, usage of which should not be
changing source file formatting requirements.
> -Original Message-
> From: Rodriguez, Christian [mailto:christian.rodrig...@in
Leif,
Thanks. I will fix the typo.
I did not change any of the .dec or .dsc files with this series.
I tested builds by using PACKAGES_PATH.
Do you approve the change with the typo fixed or do you want
me to send a V2?
Thanks,
Mike
> -Original Message-
> From: Leif Lindholm [mailto:
After talking to my colleagues about this, the direction seems to be to
fundamentally change this BZ. Instead of building this sort of workaround
feature, we should use the information gathered from this feature to cause the
build to break when the hash feature is enabled. This would force users
Hi Mike,
Over all, looks good. One consistency comment below:
On Thu, May 09, 2019 at 08:34:35PM -0700, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1467
> https://bugzilla.tianocore.org/show_bug.cgi?id=1374
> https://bugzilla.tianocore.org/show_bug.cgi?id=1793
>
> Up
On Thu, May 09, 2019 at 08:46:12PM -0700, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1467
> https://bugzilla.tianocore.org/show_bug.cgi?id=1374
> https://bugzilla.tianocore.org/show_bug.cgi?id=1793
>
> Remove maintainers for ththe following packages that have been
> i
On Thu, May 09, 2019 at 08:46:11PM -0700, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1467
> https://bugzilla.tianocore.org/show_bug.cgi?id=1374
> https://bugzilla.tianocore.org/show_bug.cgi?id=1793
>
> Remove the following packages that have been imported to
> edk2-pl
Hi Mike,
I'm afraid a typo has snuck in below:
On Thu, May 09, 2019 at 08:34:28PM -0700, Michael D Kinney wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1467
>
> Import Omap35xxPkg from edk2/master.
>
> Cc: Leif Lindholm
> Cc: Ard Biesheuvel
> Signed-off-by: Michael D Kinney
> ---
>
Hi Steven,
We have Python build scripts now and those need to be
updated with this change. The batch scripts will be deleted
soon and only exist at the moment for a brief grace period.
Please update the Python scripts.
Also, update the Python build section in Readme.md to
describe this change inc
Inline.
tldr: good answers.
If change list to set in name of set object:
Reviewed-by: jaben carsey
> -Original Message-
> From: Rodriguez, Christian
> Sent: Friday, May 10, 2019 8:28 AM
> To: Carsey, Jaben ; devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Zhu, Yonghong
> Subj
On Thu, May 09, 2019 at 11:53:28AM +0200, Marcin Wojtas wrote:
> Hi,
>
> Hereby I submit Armada7k8k PCIE support. The commits
> allow to use single controller on each of currently
> supported boards (MacchiatoBin, A7040/A8040-DB) both in
> firmware and in OS with ACPI boot. Multiple slots,
> using
On Thu, May 09, 2019 at 11:53:37AM +0200, Marcin Wojtas wrote:
> This patch adds description of the PCIE controller in
> ACPI tables of MacchiatoBin community board.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas
> ---
> Silicon/Marvell/Armada7k8k/Acpi
On Thu, May 09, 2019 at 11:53:35AM +0200, Marcin Wojtas wrote:
> Add an implementation of the PciHostBridgeLib glue library that
> describes the PCIe RC on this SoC so that the generic PCI host bridge
> driver can attach to it.
>
> This includes a constructor which performs the SoC specific init a
Replies inline.
>-Original Message-
>From: Carsey, Jaben
>Sent: Thursday, May 9, 2019 4:39 PM
>To: devel@edk2.groups.io; Rodriguez, Christian
>
>Cc: Feng, Bob C ; Gao, Liming
>; Zhu, Yonghong
>Subject: RE: [edk2-devel] [PATCH] BaseTools: Include headers not mentioned
>in inf are not hashe
Hi Leif,
pt., 10 maj 2019 o 17:25 Leif Lindholm napisał(a):
>
> On Thu, May 09, 2019 at 11:53:34AM +0200, Marcin Wojtas wrote:
> > From: Ard Biesheuvel
> >
> > Implement a special version of PciExpressLib that takes the quirky
> > nature of the Synopsys Designware PCIe IP into account. In partic
On Thu, May 09, 2019 at 11:53:34AM +0200, Marcin Wojtas wrote:
> From: Ard Biesheuvel
>
> Implement a special version of PciExpressLib that takes the quirky
> nature of the Synopsys Designware PCIe IP into account. In particular,
> we need to ignores config space accesses to all devices on the fi
pt., 10 maj 2019 o 16:59 Leif Lindholm napisał(a):
>
> On Thu, May 09, 2019 at 11:53:30AM +0200, Marcin Wojtas wrote:
> > This patch introduces new library callback (ArmadaSoCPcieGet ()),
> > which dynamically allocates and fills array with all available PCIE
> > controllers' base addresses. It is
On Thu, May 09, 2019 at 11:53:30AM +0200, Marcin Wojtas wrote:
> This patch introduces new library callback (ArmadaSoCPcieGet ()),
> which dynamically allocates and fills array with all available PCIE
> controllers' base addresses. It is needed for the configuration of PCIE,
> whose support will be
Reviewed-by: Jaben Carsey
Code change looks good visually.
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Heinrich Schuchardt
> Sent: Thursday, May 09, 2019 8:24 PM
> To: Gao, Zhichao
> Cc: devel @ edk2 . groups . io ; Carsey, Jaben
> ; N
Reviewed-by : Chao Zhang
-Original Message-
From: Joe Richey [mailto:joeric...@google.com]
Sent: Friday, May 10, 2019 5:37 PM
To: devel@edk2.groups.io
Cc: Zhang, Chao B ; Yao, Jiewen ;
Wang, Jian J
Subject: [PATCH v3 1/3] SecurityPkg: Remove double \r
Cc: Chao Zhang
Cc: Jiewen Yao
C
From: Joe Richey
All files in EDK2 have either \n or \r\n line endings. However, a few
files have formatting errors, leading to lines ending in \r\r\n. This
causes certain tools (like git) to complain or break.
https://github.com/josephlr/edk2/tree/line-ending
Cc: Zailiang Sun
Cc: Yi Qian
Cc:
Reviewed-by: Lu, shifei
> -Original Message-
> From: Shi, Steven
> Sent: Thursday, May 9, 2019 11:21 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Lu, Shifei A
> ; Gao, Liming ; Bi, Dandan
> ; Kubacki, Michael A
> Subject: [PATCH 2/2] PurleyOpenBoardPkg/BoardMtOlympus: Extend build
Hi Team,
I am looking for pointers in enabling UEFI boot loader to the existing (KVM)VM
template. I am trying to enable it for CentOS 6.5(64-bit) no GUI 64-bit (KVM)
template.
I found some images available over https://www.kraxel.org/repos/images/ with
fedora os, but I am looking for uefi
Cc: Chao Zhang
Cc: Jiewen Yao
Cc: Jian Wang
Signed-off-by: Joe Richey
---
SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
b/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
index f101ca1
These files have \r\n line endings, but a few lines use \r\r\n which
is not a valid line ending. These lines were causing problems for git
and other tools.
Signed-off-by: Joe Richey
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
These files have \r\n line endings, but a few lines use \r\r\n which
is not a valid line ending. These lines were causing problems for git
and other tools.
Signed-off-by: Joe Richey
---
SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Joe Richey
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
b/UefiCpuPkg/Library/CpuCommonFeatu
From: Joe Richey
Cc: Chao Zhang
Cc: Jiewen Yao
Cc: Jian Wang
Signed-off-by: Joe Richey
---
SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/SecurityPkg/Tcg/Opal/OpalPassword/OpalHii.c
b/SecurityPkg/Tcg/Opal/OpalPassword/Opal
All files in EDK2 have either \n or \r\n line endings. However, a few
files have formatting errors, leading to lines ending in \r\r\n. This
causes certain tools (like git) to complain or break.
Sorry for all of the mailing list spew. EDK2's settings are just
different enough from the kernel to mes
From: Joe Richey
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Joe Richey
---
UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/LimitCpuIdMaxval.c
b/UefiCpuPkg/Lib
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
> Ersek
> Sent: Thursday, May 09, 2019 7:53 PM
>
> Hello Christian,
>
> On 05/09/19 23:27, Christian Rodriguez wrote:
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1787
> >
> > Ge
Reviewed-by: Jian J Wang
> -Original Message-
> From: Joe Richey [mailto:joeric...@google.com]
> Sent: Friday, May 10, 2019 5:37 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Chao B ; Yao, Jiewen
> ; Wang, Jian J
> Subject: [PATCH v3 1/3] SecurityPkg: Remove double \r
>
> Cc: Chao Zhang
>
Hi Laszlo,
rand_* is needed by openssl itself. BaseCryptLib also provide RandomSeed()
and RandomBytes() interface to wrap openssl rand functionality. We can't
just drop them. From platform independent perspective, using performance
counter is the best choice we have. If we want to achieve the utte
Reviewed-by: Ray Ni
> -Original Message-
> From: Joe Richey
> Sent: Friday, May 10, 2019 4:07 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Joe Richey
> Subject: [PATCH 2/3] UefiCpuPkg: Remove double \r
>
> These files have \r\n line endings, but a few lin
Thank you. Lersek.
This is a big mistake. I haven't test it.
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
Ersek
Sent: Friday, May 10, 2019 4:58 AM
To: devel@edk2.groups.io; Lu, XiaoyuX
Cc: Wang, Jian J ; Ye, Ting
Subject: Re: [edk2-dev
Hi, Laszlo:
Thank you for your time.
I try the method you mentioned.
> (1) Therefore, the right thing to do here is to add "no-store" to the above
> list, in my opinion. Can you try that, please?
>
> And, this change should be a standalone patch, similarly to patch v2 1/6 in
> this series.
(
> -Original Message-
> From: Loh, Tien Hock
> Sent: Thursday, May 09, 2019 5:20 PM
> To: devel@edk2.groups.io; thlo...@gmail.com
> Cc: Loh, Tien Hock; Wang, Jian J; Wu, Hao A; Zhu, Yonghong
> Subject: [PATCH v2 1/1] MdeModulePkg: BaseSerialPortLib16550: Add missing
> Pcd to UNI
>
> From: "
Reviewed-by: Bob Feng
-Original Message-
From: Liu, Zhiguang
Sent: Friday, May 10, 2019 9:51 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH] BaseTools: Check the fread function and avoid dead loop
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1789
If th
This change is good. Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Dandan Bi
>Sent: Friday, May 10, 2019 1:44 PM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [edk2-devel] [patch] BaseTools/VfrComp
I think NT32Pkg need a POSTBUILD scripts to execute its run command.
-Original Message-
From: Gao, Liming
Sent: Friday, May 10, 2019 3:26 PM
To: Feng, Bob C ; devel@edk2.groups.io
Cc: Kinney, Michael D
Subject: RE: [Patch] BaseTools: Remove './SecMain' from 'run' target
Bob:
Please m
Bob:
Please make sure run command still works on NT32 platform.
>-Original Message-
>From: Feng, Bob C
>Sent: Friday, May 10, 2019 2:34 PM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>; Kinney, Michael D
>Subject: [Patch] BaseTools: Remove './SecMain' from 'run' target
>
>
46 matches
Mail list logo
