[edk2-devel] [PATCH V5] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-28 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1765 If RAW FFS File Rule has no section for its data.For RAW FFS File, directly call GenFfs tool to generate FFS file. Ffs Rule: [Rule.Common.USER_DEFINED.MicroCode] FILE RAW = $(NAMED_GUID) { $(INF_OUTPUT)/$(MODULE_NAME).bin }

[edk2-devel] [PATCH] MdeModulePkg: Clarify the lib supported ARCH

2019-05-28 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1856 SmmLockBoxPeiLib only support IA32 and X64 ARCH. So put this lib to a specific [LibraryClasses.IA32.PEIM, LibraryClasses.X64.PEIM] section. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc:

Re: [edk2-devel] [Patch v3 0/3] [edk2-platform] Add modules to BoardModulePkg.

2019-05-28 Thread Dong, Eric
Liming, Thanks for your comments. Will update them when I push the changes. Thanks, Eric > -Original Message- > From: Gao, Liming > Sent: Wednesday, May 29, 2019 1:23 PM > To: devel@edk2.groups.io; Dong, Eric > Subject: RE: [edk2-devel] [Patch v3 0/3] [edk2-platform] Add modules to >

Re: [edk2-devel] [Patch v3 0/3] [edk2-platform] Add modules to BoardModulePkg.

2019-05-28 Thread Liming Gao
Eric: 1. Don't need to include version change message in the commit message. Change version is in cover letter only. 2. BoardModulePkg DEC/DSC still describe AdvancedFeaturePkg. Please fix them. With those changes, Reviewed-by: Liming Gao Thanks Liming >-Original Message-

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

2019-05-28 Thread Liming Gao
TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf is required to be added into [LibraryClasses] of edk2-platforms\Silicon\Marvell\Armada7k8k\Armada7k8k.dsc.inc >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >rebe...@bluestop.org >Sent: Wednesday, May

Re: [edk2-devel] [PATCH] Marvell/Armada80x0McBin: Enable usb keyboard, nvme boot

2019-05-28 Thread Marcin Wojtas
Hi Jeremy, śr., 29 maj 2019 o 01:43 Jeremy Linton napisał(a): > > Add a USB keyboard flag, which is needed when a graphical console > is enabled. Also add a nvme boot option for users that choose > that instead of sata or mmc. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

2019-05-28 Thread rebecca
On 2019-05-28 03:47, Marcin Wojtas wrote: > Please use the Tianocore repo only. With the latest changes, there is > no point to use old MarvellEmbededProcessors branch, I do not maintain > it. I also plan to update MacchiatoBin wiki with the reference to the > mainline repositories. I can

[edk2-devel] [PATCH v2] BaseTools:Extend the binary cache to support library cache

2019-05-28 Thread Steven Shi
V2 change: Simplify the library cache implementation and remove CacheRestored flag based filter. Use the current CanSkipbyHash() filter in AddDependency() instead. V1 change: https://bugzilla.tianocore.org/show_bug.cgi?id=1797 Current binary cache doesn't support to save and restore the library

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

2019-05-28 Thread rebecca
On 2019-05-28 02:39, Leif Lindholm wrote: > > This was actually enabled in the upstream edk2-platforms repository as > part of the "use fragment config files for network config" set: > 205d5621a35eb6251481526039d24b17374efdf0 > > Since the PCIe updates just went in, that should now be a valid >

Re: [edk2-devel] [PATCH 1/2] KabylakeSiliconPkg: Add FSP Dispatch switch.

2019-05-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Wednesday, May 22, 2019 1:35 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [edk2-devel] [PATCH 1/2] KabylakeSiliconPkg: Add

Re: [edk2-devel] [PATCH 2/2] KabylakeOpenBoardPkg: Add FSP Dispatch switch.

2019-05-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Wednesday, May 22, 2019 1:35 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [PATCH 2/2] KabylakeOpenBoardPkg: Add FSP Dispatch switch. From: "Chasel, Chiu"

Re: [edk2-devel] [PATCH v2 00/10] Duplicate required CSM components for OVMF

2019-05-28 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Tuesday, May 28, 2019 7:48 PM > To: devel@edk2.groups.io; Wu, Hao A > Cc: David Woodhouse; Ni, Ray; Justen, Jordan L; Ard Biesheuvel > Subject: Re: [edk2-devel] [PATCH v2

Re: [edk2-devel] [PATCH] BaseTools:Extend the binary cache to support library cache

2019-05-28 Thread Steven Shi
OK, will send the new version patch to simplify it. Thanks Steven Shi Intel\SSG\FID\Firmware Infrastructure > -Original Message- > From: Rodriguez, Christian > Sent: Tuesday, May 28, 2019 11:16 PM > To: devel@edk2.groups.io; Shi, Steven > Cc: Gao, Liming ; Feng, Bob C ; > Fan, ZhijuX

Re: [edk2-devel] [PATCH] BaseTools:Fix the library dependency missing in Binary Cache

2019-05-28 Thread Steven Shi
OK, will solve this issue through the fix patch of BZ 1797. Thanks Steven Shi Intel\SSG\FID\Firmware Infrastructure > -Original Message- > From: Rodriguez, Christian > Sent: Tuesday, May 28, 2019 11:06 PM > To: devel@edk2.groups.io; Shi, Steven > Cc: Gao, Liming ; Feng, Bob C >

[edk2-devel] [Patch 3/3] [edk2-platforms] Platform/Intel/DebugFeaturePkg/AcpiDebug: Change AcpiDebug module location.

2019-05-28 Thread Dong, Eric
Move AcpiDebug module from AdvancedFeaturePkg to DebugFeaturePkg. Signed-off-by: Eric Dong Cc: Liming Gao --- .../AdvancedFeaturePkg/AdvancedFeaturePkg.dec | 6 -- .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 3 --- .../AcpiDebug/AcpiDebug.asl | 0

[edk2-devel] [Patch 1/3] [edk2-platforms] Platform/Intel/DebugFeaturePkg: Add DebugFeaturePkg

2019-05-28 Thread Dong, Eric
Add new package DebugFeaturePkg in Platform/Intel/ folder. It will keep debug related features in this package. Signed-off-by: Eric Dong --- Maintainers.txt | 4 .../Intel/DebugFeaturePkg/DebugFeaturePkg.dec | 19 +++

[edk2-devel] [Patch 0/3] [edk2-platforms] Add DebugFeaturePkg to keep debug related modules.

2019-05-28 Thread Dong, Eric
Add new package in Platform/Intel/ folder to keep debug related modules. Eric Dong (3): Platform/Intel/DebugFeaturePkg: Add DebugFeaturePkg Platform/Intel/DebugFeaturePkg: Add USB3DebugPort related modules. Platform/Intel/DebugFeaturePkg/AcpiDebug: Change AcpiDebug module location.

[edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei

2019-05-28 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853 Sperate the capsule check function from GetCapsuleDescriptors and name it to AreCapsulesStaged. Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries. And optimize its to remove the duplicated code. Cc: Jian J

Re: [edk2-devel] [PATCH] Platform/Intel: Add fspapi build parameter

2019-05-28 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Tuesday, May 28, 2019 12:52 AM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Desimone, Nathaniel L ; Kubacki, Michael A Subject: [PATCH] Platform/Intel: Add fspapi build parameter REF:

Re: [edk2-devel][Patch 0/7] Implement Capsule On Disk.

2019-05-28 Thread Zhang, Chao B
Yes, will check in after Q2 tag From: Gao, Liming Sent: Wednesday, May 29, 2019 8:34 AM To: Xu, Wei6 ; devel@edk2.groups.io Cc: Wang, Jian J ; Wu, Hao A ; Kinney, Michael D ; Zhang, Chao B Subject: RE: [edk2-devel][Patch 0/7] Implement Capsule On Disk. So, this feature is for next Q3 stable

Re: [edk2-devel][Patch 0/7] Implement Capsule On Disk.

2019-05-28 Thread Liming Gao
So, this feature is for next Q3 stable tag. Right? > -Original Message- > From: Xu, Wei6 > Sent: Wednesday, May 29, 2019 1:06 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Kinney, Michael D ; Gao, > Liming ; Zhang, Chao B > Subject: [edk2-devel][Patch 0/7] Implement

Re: [edk2-devel] [patch] ShellPkg/Debug1CommandsLib: Fix bugs in func DisplaySysEventLogData

2019-05-28 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao > -Original Message- > From: Bi, Dandan > Sent: Tuesday, May 28, 2019 10:25 AM > To: devel@edk2.groups.io; oleks...@ami.com > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Subject: [patch] ShellPkg/Debug1CommandsLib: Fix bugs in func > DisplaySysEventLogData >

Re: [edk2-devel] [Patch 3/3] SignedCapsulePkg: Update Package DSC to remove unused network libs

2019-05-28 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: Gao, Liming Sent: Tuesday, May 28, 2019 7:42 PM To: devel@edk2.groups.io Cc: Yao, Jiewen ; Zhang, Chao B Subject: [Patch 3/3] SignedCapsulePkg: Update Package DSC to remove unused network libs Signed-off-by: Liming Gao Cc: Jiewen Yao

[edk2-devel] [PATCH] Marvell/Armada80x0McBin: Enable usb keyboard, nvme boot

2019-05-28 Thread Jeremy Linton
Add a USB keyboard flag, which is needed when a graphical console is enabled. Also add a nvme boot option for users that choose that instead of sata or mmc. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeremy Linton --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 3

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

2019-05-28 Thread rebecca
On 2019-05-28 03:47, Marcin Wojtas wrote: > Please use the Tianocore repo only. With the latest changes, there is > no point to use old MarvellEmbededProcessors branch, I do not maintain > it. I also plan to update MacchiatoBin wiki with the reference to the > mainline repositories. Thank you!

[edk2-devel] [PATCH v2 5/5] OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe

2019-05-28 Thread Imran Desai
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. This patch

[edk2-devel] [PATCH v2 0/5] Implement SM3 measured boot

2019-05-28 Thread Imran Desai
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. Cc: Michael D

[edk2-devel] [PATCH v2 2/5] SecurityPkg: introduce the SM3 digest algorithm

2019-05-28 Thread Imran Desai
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. This patch

[edk2-devel] [PATCH v2 3/5] SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest algorithm

2019-05-28 Thread Imran Desai
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. This patch

[edk2-devel] [PATCH v2 1/5] MdePkg/Protocol/Hash: introduce GUID for SM3

2019-05-28 Thread Imran Desai
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. This patch adds

[edk2-devel] [PATCH v2 4/5] SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default

2019-05-28 Thread Imran Desai
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. This patch

Re: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

2019-05-28 Thread Leif Lindholm
+Haojian, Haojian - since you are the original author, can you comment on the delays? Are these silicon bug workarounds (so we need to add a Pcd), or does these changes work on your platforms too? Regards, Leif On Mon, May 27, 2019 at 05:30:27PM +0800, tien.hock@intel.com wrote: > From:

Re: [edk2-devel] [PATCH v2 5/7] EmbeddedPkg: Clear CTYPE on initialization

2019-05-28 Thread Leif Lindholm
On Mon, May 27, 2019 at 05:30:26PM +0800, tien.hock@intel.com wrote: > From: "Tien Hock, Loh" > > Clear CTYPE on initialization. This is important if previous bootloader > changes the CTYPE can cause the controller to not initialize correctly > if CTYPE is not reset to 0 > > Signed-off-by:

Re: [edk2-devel] [PATCH v2 4/7] EmbeddedPkg: Fix response check flag

2019-05-28 Thread Leif Lindholm
On Mon, May 27, 2019 at 05:30:25PM +0800, tien.hock@intel.com wrote: > From: "Tien Hock, Loh" > > Do not send CRC response check if the MMC command does not support CRC > response > > Signed-off-by: Tien Hock, Loh > Cc: Leif Lindholm > Cc: Ard Biesheuvel Reviewed-by: Leif Lindholm >

Re: [edk2-devel] [PATCH v2 3/7] EmbeddedPkg: Send command when MMC ask for response

2019-05-28 Thread Leif Lindholm
On Mon, May 27, 2019 at 05:30:24PM +0800, tien.hock@intel.com wrote: > From: "Tien Hock, Loh" > > Send command when MMC ask for response in DwEmmcReceiveResponse, and > command is a pending command (eg. DMA needs to be set up first) > > Signed-off-by: "Tien Hock, Loh" > Cc: Leif Lindholm

Re: [edk2-devel] [PATCH v2 7/7] EmbeddedPkg: Fix DwEmmc read/write size in preparing DMA size

2019-05-28 Thread Leif Lindholm
On Mon, May 27, 2019 at 05:30:28PM +0800, tien.hock@intel.com wrote: > From: "Tien Hock, Loh" > > Add support for reading data that is less than DWEMMC_BLOCK_SIZE, > otherwise it would read bigger data than requested and cause errors > > Signed-off-by: "Tien Hock, Loh" > Cc: Leif Lindholm

Re: [edk2-devel] [PATCH v2 2/7] EmbeddedPkg: Fix DwEmmc CMD8 support for SD

2019-05-28 Thread Leif Lindholm
On Mon, May 27, 2019 at 05:30:23PM +0800, tien.hock@intel.com wrote: > From: "Tien Hock, Loh" > > On CMD8, for SD, the controller should not expect data as this is a > SEND_IF_COND command to verify SD operating condition, and does not have > data. > > Signed-off-by: Tien Hock, Loh > Cc:

Re: [edk2-devel] [PATCH v2 1/7] EmbeddedPkg: Add SD command support for DwEmmc

2019-05-28 Thread Leif Lindholm
Hi Tien Hock, Thanks for resubmitting this. On Mon, May 27, 2019 at 05:30:22PM +0800, tien.hock@intel.com wrote: > From: "TIen Hock, Loh" > > Added ACMD6 for SD support. For SD, after CMD55 is sent, the next > command should be an application command, which should not expect > data > >

Re: Linux Kernel soft hangs if 8259 PIC is not configured by BIOS: was (RE: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules)

2019-05-28 Thread Kirkendall, Garrett
See below -Original Message- From: Kinney, Michael D Sent: Tuesday, May 28, 2019 12:07 PM To: Kirkendall, Garrett ; devel@edk2.groups.io; Wu, Hao A ; Kinney, Michael D Cc: Ni, Ray ; Andrew Fish ; Laszlo Ersek ; Leif Lindholm Subject: RE: Linux Kernel soft hangs if 8259 PIC is not

Re: Linux Kernel soft hangs if 8259 PIC is not configured by BIOS: was (RE: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules)

2019-05-28 Thread Leif Lindholm
Hi Garrett, Presumably you mean https://lkml.org/lkml/2019/5/9/304? I'm not familiar enough with the PC platform to stick my oar in, but Gleixner's counterquestion is an honest one - he does not see an obvious solution to the problem. And unless someone finds the problem interesting, this is

Re: Linux Kernel soft hangs if 8259 PIC is not configured by BIOS: was (RE: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules)

2019-05-28 Thread Michael D Kinney
Hi Garrett, Two thoughts on this issue: 1) Just because 8259 is not used by UEFI FW does not mean the 8259 HW should not be initialized into an OS compatible state. This init code could be part of the chipset/si init code without requiring the 8259 driver/protocol. 2) The HPET driver in

Re: [edk2-devel] OVMF and SMBIOS

2019-05-28 Thread Laszlo Ersek
On 05/28/19 17:18, Tomas Pilar (tpilar) wrote: > Hi, > > I am trying to create kvm instance using libvirt and Qemu and OVMF that also > has SMBIOS included. My current version of Qemu only supports type 0 and type > 1 SMBIOS tables so I specify those. However, when I use smbiosview in the >

[edk2-devel][Patch 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.

2019-05-28 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 CoDCheckCapsuleOnDiskFlag() is to check if CapsuleOnDisk flag in "OsIndications" Variable is enabled. It is used to indicate whether capsule on disk is provisioned in normal boot path. CoDClearCapsuleOnDiskFlag() is to to clear

[edk2-devel][Patch 6/7] MdeModulePkg/DxeIpl: Support Capsule On Disk.

2019-05-28 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 If Capsule On Disk mode, call Capsule On Disk Load PPI to load capsules. When it fails, still goes to Firmware Update boot path. BDS will clear corresponding indicator and reboot later on. Cc: Jian J Wang Cc: Hao A Wu Cc: Chao B Zhang

[edk2-devel][Patch 4/7] MdeModulePkg/BdsDxe: Support Capsule On Disk.

2019-05-28 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 Set EFI_OS_INDICATIONS_FILE_CAPSULE_DELIVERY_SUPPORTED bit of "OsIndicationsSupported" variable to indicate the Capsule On Disk is supported or not, according to PcdCapsuleOnDiskSupport. Cc: Jian J Wang Cc: Hao A Wu Cc: Chao B Zhang

[edk2-devel][Patch 2/7] MdeModulePkg: Add Capsule On Disk related definition.

2019-05-28 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 This patch will add Capsule On Disk related definition, including GUID, PPI and PCDs: The Capsule On Disk Name GUID indicates the capsule is to store Capsule On Disk file names. The Pei Capsule On Disk PPI provides service to retrieve

[edk2-devel][Patch 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition.

2019-05-28 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 This PPI indicates current boot mode is capsule on disk mode. Cc: Michael D Kinney Cc: Liming Gao Cc: Chao B Zhang Signed-off-by: Wei6 Xu --- MdePkg/Include/Ppi/BootInRecoveryMode.h | 9 - MdePkg/MdePkg.dec

[edk2-devel][Patch 3/7] MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM.

2019-05-28 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 This module provides PPI to load Capsule On Disk temp relocation file from Root Directory file system, retrieve the capsules from the temp file and create capsule hobs for these capsules. Cc: Jian J Wang Cc: Hao A Wu Cc: Chao B Zhang

Re: [edk2-devel] [PATCH] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-05-28 Thread Michael D Kinney
Could this tools be ported to Python using the python struct module to access C structures? The implementation may be much simpler if python was used for command line parsing. And this capability could also be provided as a python module to support direct access from pre/post build steps

Linux Kernel soft hangs if 8259 PIC is not configured by BIOS: was (RE: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules)

2019-05-28 Thread Kirkendall, Garrett
Since this change will be removing the 8259 PIC driver, I'll mention a quirk I ran into in the Linux Kernel up through at least 5.0 (and I am sure later, I just didn't verify): Does anyone have pull in the Linux Kernel world to get them to take this seriously? Hopefully someday soon end users

Re: [edk2-devel] [PATCH v2 0/7] update ArmSoftFloatLib to latest upstream version

2019-05-28 Thread Leif Lindholm
Hi Ard, Many thanks for this. Two comments: - First, just the note I made on the -std=c99 patch - we're diverging behaviour between CLANG and modern GCC. I don't think we're really promoting use of c11 features anyway, but it could be worth considering adding an explicit flag to GCC5 as

[edk2-devel] contribution of code licensed other than bsd+patent

2019-05-28 Thread Leif Lindholm
Hi stewards, and other interested people. Readme.md lists a few licenses acceptable but not preferred (this text used to live in Contributions.txt before the bsd+patent relicensing effort). However, it does not explicitly state anything about the gap that was left by the dropping of the TianoCore

[edk2-devel] [FdfSpecification Patch] FDF spec: Fix the issue in Rule section for RAW Type File

2019-05-28 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1765 FV File Statement clarifies RAW File type with file name only. But, FFS Rule section doesn't support this syntax. This is an issue in FDF spec. Per PI spec, RAW File has no section. It directly includes file data. So, FFS Rule section should

[edk2-devel] OVMF and SMBIOS

2019-05-28 Thread Tomas Pilar (tpilar)
Hi, I am trying to create kvm instance using libvirt and Qemu and OVMF that also has SMBIOS included. My current version of Qemu only supports type 0 and type 1 SMBIOS tables so I specify those. However, when I use smbiosview in the UEFI shell, I get back "SMBIOS not found". I attach my

Re: [edk2-devel] [PATCH] BaseTools:Extend the binary cache to support library cache

2019-05-28 Thread Christian Rodriguez
Hi Steven, After testing the bug reported, it seems that the dependency problem isn't the root cause. We don't need to change the way it skips having to rebuild libraries. The cache is missing the library build artifacts as you mentioned before and this is the root cause of the rebuild

Re: [edk2-devel] [PATCH] BaseTools:Fix the library dependency missing in Binary Cache

2019-05-28 Thread Christian Rodriguez
Hi Steven, The problem isn't that the library dependency is missing. We are missing library artifacts and therefore cannot build the library. This can be fixed with a snippet of your next patch that adds the libraries artifacts, but without the extra tracking information. Thanks, Christian

Re: [edk2-devel] [Patch 0/3] Update Package DSC for Network module movement

2019-05-28 Thread Guo Dong
Reviewed-by: Guo Dong > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Tuesday, May 28, 2019 4:42 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch 0/3] Update Package DSC for Network module > movement > >

[edk2-devel] Upcoming Event: TianoCore Design / Bug Triage - EMEA - Wed, 05/29/2019 8:00am-9:00am #cal-reminder

2019-05-28 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design / Bug Triage - EMEA *When:* Wednesday, 29 May 2019, 8:00am to 9:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/695893389 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=488404 ) *Organizer:* Stephano Cetola

Re: [edk2-devel] [PATCH v2 0/7] update ArmSoftFloatLib to latest upstream version

2019-05-28 Thread Ard Biesheuvel
On Tue, 28 May 2019 at 13:39, Laszlo Ersek wrote: > > On 05/27/19 22:51, Ard Biesheuvel wrote: > > Currently, our move to OpenSSL 1.1.1b is being blocked by an issue in > > the ARM software floating point library, which lacks some intrinsics > > that the ARM EABI spec defines. > > > > Since the

Re: [edk2-devel] [PATCH v2 5/7] ArmPkg/ArmSoftFloatLib: add SPDX identifiers

2019-05-28 Thread Leif Lindholm
On Tue, May 28, 2019 at 01:28:21PM +0200, Ard Biesheuvel wrote: > > > diff --git > > > a/ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/build/Linux-ARM-VFPv2-GCC/platform.h > > > > > > b/ArmPkg/Library/ArmSoftFloatLib/SoftFloat-3e/build/Linux-ARM-VFPv2-GCC/platform.h > > > index

Re: [edk2-devel] [EXT] Re: [[edk2-platforms][PATCH V2] 27/30] Silicon/Marvell: Replace BSD License with BSD+Patent License

2019-05-28 Thread Nadav Haklai
Marvell approves this change. Thanks, Nadav -Original Message- From: Marcin Wojtas Sent: Tuesday, May 28, 2019 1:23 PM To: Leif Lindholm ; Nadav Haklai Cc: Michael D Kinney ; edk2-devel-groups-io ; Ard Biesheuvel Subject: [EXT] Re: [[edk2-platforms][PATCH V2] 27/30] Silicon/Marvell:

Re: [edk2-devel] [PATCH] Maintainers.txt: update mailing list information

2019-05-28 Thread Laszlo Ersek
On 05/28/19 12:22, Leif Lindholm wrote: > The devel mailing list has moved from 01.org to groups.io - update > the mailing list information to reflect this. > > Signed-off-by: Leif Lindholm > --- > Maintainers.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [edk2-devel] [PATCH v2 00/10] Duplicate required CSM components for OVMF

2019-05-28 Thread Laszlo Ersek
On 05/27/19 05:03, Wu, Hao A wrote: > ''' > Please note that this series will be hold until the edk2-stable201905 is > created. > ''' > > The series is also available at: > https://github.com/hwu25/edk2/tree/ovmf_csm_v2 > > V2 changes: > > Discussion with David Woodhouse for him to take the

Re: [edk2-devel] [Patch 0/3] Update Package DSC for Network module movement

2019-05-28 Thread Ard Biesheuvel
On Tue, 28 May 2019 at 13:42, Liming Gao wrote: > > Network modules have been moved to NetworkPkg. Some package dsc files > are required to be updated. > > 1. Remove unused NetLib > 2. Update Package DSC to refer to NetworkLibs.dsc.inc > > Liming Gao (3): > UefiPayloadPkg: Update Package DSC

Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg

2019-05-28 Thread Liming Gao
Ard: > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, May 28, 2019 7:12 PM > To: Gao, Liming > Cc: edk2-devel-groups-io ; Kinney, Michael D > ; Laszlo Ersek ; > Leif Lindholm > Subject: Re: [edk2-devel] [edk2-platform patch 0/7] Clean up

Re: [edk2-devel] [Patch 2/3] ArmPkg: Update Package DSC to remove unused NetLib

2019-05-28 Thread Ard Biesheuvel
On Tue, 28 May 2019 at 13:42, Liming Gao wrote: > > Signed-off-by: Liming Gao > Cc: Leif Lindholm > Cc: Ard Biesheuvel Thanks Liming Reviewed-by: Ard Biesheuvel I spotted these as well, in case you weren't aware: SignedCapsulePkg/SignedCapsulePkg.dsc:

[edk2-devel] [Patch 0/3] Update Package DSC for Network module movement

2019-05-28 Thread Liming Gao
Network modules have been moved to NetworkPkg. Some package dsc files are required to be updated. 1. Remove unused NetLib 2. Update Package DSC to refer to NetworkLibs.dsc.inc Liming Gao (3): UefiPayloadPkg: Update Package DSC files to refer to NetworkLibs.dsc.inc ArmPkg: Update Package

[edk2-devel] [Patch 2/3] ArmPkg: Update Package DSC to remove unused NetLib

2019-05-28 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Leif Lindholm Cc: Ard Biesheuvel --- ArmPkg/ArmPkg.dsc | 1 - 1 file changed, 1 deletion(-) diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc index 25c6ccaeb6..5f090d3087 100644 --- a/ArmPkg/ArmPkg.dsc +++ b/ArmPkg/ArmPkg.dsc @@ -47,7 +47,6 @@

[edk2-devel] [Patch 3/3] SignedCapsulePkg: Update Package DSC to remove unused network libs

2019-05-28 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Jiewen Yao Cc: Chao Zhang --- SignedCapsulePkg/SignedCapsulePkg.dsc | 5 - 1 file changed, 5 deletions(-) diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc b/SignedCapsulePkg/SignedCapsulePkg.dsc index 0da445503b..4d4232d6e0 100644 ---

[edk2-devel] [Patch 1/3] UefiPayloadPkg: Update Package DSC files to refer to NetworkLibs.dsc.inc

2019-05-28 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Guo Dong --- UefiPayloadPkg/UefiPayloadPkgIa32.dsc| 2 +- UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/UefiPayloadPkg/UefiPayloadPkgIa32.dsc b/UefiPayloadPkg/UefiPayloadPkgIa32.dsc index

Re: [edk2-devel] [PATCH v2 0/7] update ArmSoftFloatLib to latest upstream version

2019-05-28 Thread Laszlo Ersek
On 05/27/19 22:51, Ard Biesheuvel wrote: > Currently, our move to OpenSSL 1.1.1b is being blocked by an issue in > the ARM software floating point library, which lacks some intrinsics > that the ARM EABI spec defines. > > Since the code was in pretty sorry state, let's fix this by upgrading > to

Re: [edk2-devel] [PATCH v2 5/7] ArmPkg/ArmSoftFloatLib: add SPDX identifiers

2019-05-28 Thread Ard Biesheuvel
On Tue, 28 May 2019 at 13:27, Laszlo Ersek wrote: > > On 05/27/19 22:51, Ard Biesheuvel wrote: > > Add the appropriate SPDX identifiers to all files taken from the > > 3-clause BSD licensed SoftFloat library. > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1845 > > Acked-by: Jian J

Re: [edk2-devel] [PATCH v2 0/7] update ArmSoftFloatLib to latest upstream version

2019-05-28 Thread Laszlo Ersek
On 05/27/19 22:51, Ard Biesheuvel wrote: > Currently, our move to OpenSSL 1.1.1b is being blocked by an issue in > the ARM software floating point library, which lacks some intrinsics > that the ARM EABI spec defines. > > Since the code was in pretty sorry state, let's fix this by upgrading > to

Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg

2019-05-28 Thread Ard Biesheuvel
On Tue, 28 May 2019 at 13:03, Gao, Liming wrote: > > > -Original Message- > > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > > Sent: Tuesday, May 28, 2019 6:06 PM > > To: edk2-devel-groups-io ; Gao, Liming > > ; Kinney, Michael D > > ; Laszlo Ersek ; Leif > > Lindholm > >

Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg

2019-05-28 Thread Liming Gao
> -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, May 28, 2019 6:06 PM > To: edk2-devel-groups-io ; Gao, Liming > ; Kinney, Michael D > ; Laszlo Ersek ; Leif Lindholm > > Subject: Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform

Re: [edk2-devel] [PATCH edk2-platforms 3/3] Maintainers.txt: add reviewer for Marvell platforms

2019-05-28 Thread Marcin Wojtas
Hi Leif, wt., 28 maj 2019 o 12:20 Leif Lindholm napisał(a): > > Marcin is the author of the majority of the Marvell platform support in > the tree, so clarify that he should be cc:d on patches to Marvell Armada > SoC/Boards and MacchiatoBIN. > > Cc: Marcin Wojtas > Signed-off-by: Leif Lindholm

Re: [edk2-devel] [[edk2-platforms][PATCH V2] 27/30] Silicon/Marvell: Replace BSD License with BSD+Patent License

2019-05-28 Thread Marcin Wojtas
Adding Nadav Haklai from Marvell. wt., 28 maj 2019 o 11:50 Leif Lindholm napisał(a): > > On Fri, May 17, 2019 at 11:50:06AM +0100, Leif Lindholm wrote: > > On Wed, May 15, 2019 at 04:10:08PM -0700, Michael D Kinney wrote: > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1373 > > > > > >

Re: [edk2-devel] [PATCH edk2-platforms 1/3] Maintainers.txt: add Reviewer role to description of section entries

2019-05-28 Thread Ard Biesheuvel
On Tue, 28 May 2019 at 12:20, Leif Lindholm wrote: > > This file was based on an old version of the edk2 Maintainers.txt, > predating both d75b8ac278b and c9e1e28b619. Bring this up to date. > > Signed-off-by: Leif Lindholm > --- > Maintainers.txt | 5 + > 1 file changed, 5 insertions(+) >

[edk2-devel] [PATCH] Maintainers.txt: update mailing list information

2019-05-28 Thread Leif Lindholm
The devel mailing list has moved from 01.org to groups.io - update the mailing list information to reflect this. Signed-off-by: Leif Lindholm --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index aaabe2b52d..f3ce5edd8a

[edk2-devel] [PATCH edk2-platforms 2/3] Maintainers.txt: update mailing list information

2019-05-28 Thread Leif Lindholm
The devel mailing list has moved from 01.org to groups.io - update the mailing list information to reflect this. Signed-off-by: Leif Lindholm --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index 85e8dc7fd4..778eec6fed

[edk2-devel] [PATCH edk2-platforms 3/3] Maintainers.txt: add reviewer for Marvell platforms

2019-05-28 Thread Leif Lindholm
Marcin is the author of the majority of the Marvell platform support in the tree, so clarify that he should be cc:d on patches to Marvell Armada SoC/Boards and MacchiatoBIN. Cc: Marcin Wojtas Signed-off-by: Leif Lindholm --- Maintainers.txt | 9 + 1 file changed, 9 insertions(+) diff

[edk2-devel] [PATCH edk2-platforms 1/3] Maintainers.txt: add Reviewer role to description of section entries

2019-05-28 Thread Leif Lindholm
This file was based on an old version of the edk2 Maintainers.txt, predating both d75b8ac278b and c9e1e28b619. Bring this up to date. Signed-off-by: Leif Lindholm --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index

Re: [edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg

2019-05-28 Thread Ard Biesheuvel
On Tue, 28 May 2019 at 12:00, Liming Gao wrote: > > 1. Remove unnecessary Network libs, because NetworkPkg segment DSC/FDF have > included them. > 2. Update Update RPi3 DSC/FDF to refer to Network package segment files > > These changes are required, because Network modules have been moved into

Re: [edk2-devel] [edk2-platform patch 5/7] Vlv2TbltDevicePkg: Update Platform dsc to remove unnecessary Network libs

2019-05-28 Thread Sun, Zailiang
Reviewed-by: Zailiang Sun > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Tuesday, May 28, 2019 5:59 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [edk2-devel] [edk2-platform patch 5/7]

[edk2-devel] [edk2-platform patch 7/7] SoftIron: Update Overdrive1000Board.dsc to refer to new Network module path

2019-05-28 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Ard Biesheuvel Cc: Leif Lindholm --- Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc

[edk2-devel] [edk2-platform patch 3/7] Hisilicon: Update D06.dsc to remove unnecessary Network libs

2019-05-28 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Ard Biesheuvel Cc: Leif Lindholm --- Platform/Hisilicon/D06/D06.dsc | 5 - 1 file changed, 5 deletions(-) diff --git a/Platform/Hisilicon/D06/D06.dsc b/Platform/Hisilicon/D06/D06.dsc index 269515c7a5..26b79adba0 100644 --- a/Platform/Hisilicon/D06/D06.dsc +++

[edk2-devel] [edk2-platform patch 5/7] Vlv2TbltDevicePkg: Update Platform dsc to remove unnecessary Network libs

2019-05-28 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Zailiang Sun Cc: Yi Qian --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 -- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 4 Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgX64.dsc| 2 -- 3 files changed, 8 deletions(-) diff --git

[edk2-devel] [edk2-platform patch 1/7] BeagleBoardPkg: Update BeagleBoardPkg.dsc to remove unnecessary Network libs

2019-05-28 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Ard Biesheuvel Cc: Leif Lindholm --- Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc

[edk2-devel] [edk2-platform patch 4/7] QuarkPlatform: Update Quark dsc to remove unnecessary Network libs

2019-05-28 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Michael D Kinney Cc: Kelly Steele --- Platform/Intel/QuarkPlatformPkg/Quark.dsc| 4 Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 4 2 files changed, 8 deletions(-) diff --git a/Platform/Intel/QuarkPlatformPkg/Quark.dsc

[edk2-devel] [edk2-platform patch 0/7] Clean up Platform DSC/FDF to refer to NetworkPkg

2019-05-28 Thread Liming Gao
1. Remove unnecessary Network libs, because NetworkPkg segment DSC/FDF have included them. 2. Update Update RPi3 DSC/FDF to refer to Network package segment files These changes are required, because Network modules have been moved into NetworkPkg. Liming Gao (7): BeagleBoardPkg: Update

[edk2-devel] [edk2-platform patch 2/7] RDKQemu: Update RDKQemu.dsc to remove unnecessary Network libs

2019-05-28 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Ard Biesheuvel Cc: Leif Lindholm --- Platform/Comcast/RDKQemu/RDKQemu.dsc | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc b/Platform/Comcast/RDKQemu/RDKQemu.dsc index 64b6699ae7..e73a907891 100644 ---

[edk2-devel] [edk2-platform patch 6/7] RaspberryPi: Update RPi3 DSC/FDF to refer to Network package segment files

2019-05-28 Thread Liming Gao
Signed-off-by: Liming Gao Cc: Ard Biesheuvel Cc: Leif Lindholm --- Platform/RaspberryPi/RPi3/RPi3.dsc | 30 ++ Platform/RaspberryPi/RPi3/RPi3.fdf | 11 +-- 2 files changed, 15 insertions(+), 26 deletions(-) diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc

Re: [edk2-devel] [[edk2-platforms][PATCH V2] 27/30] Silicon/Marvell: Replace BSD License with BSD+Patent License

2019-05-28 Thread Leif Lindholm
On Fri, May 17, 2019 at 11:50:06AM +0100, Leif Lindholm wrote: > On Wed, May 15, 2019 at 04:10:08PM -0700, Michael D Kinney wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=1373 > > > > Replace BSD 2-Clause License with BSD+Patent License. This change is > > based on the following

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

2019-05-28 Thread Marcin Wojtas
Hi Rebecca, wt., 28 maj 2019 o 10:39 Leif Lindholm napisał(a): > > Hi Rebecca, > > On Mon, May 27, 2019 at 05:34:08PM -0600, rebe...@bluestop.org wrote: > > I've been working with the MACCHIATObin board, and noticed settings for > > HTTP and TLS in

[edk2-devel] [PATCH] BaseTools:Add DetectNotUsedItem.py to Edk2\BaseTools\Scripts

2019-05-28 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1850

This script is used to Detect unreferenced PCD and GUID/Protocols/PPIs.
The input parameters are Dec file and package directory.

This script can be run in 

Re: [edk2-devel] Adding HTTP and TLS support to Armada80x0McBin (from the MarvellEmbeddedProcessors edk2-open-platforms repo)

2019-05-28 Thread Leif Lindholm
Hi Rebecca, On Mon, May 27, 2019 at 05:34:08PM -0600, rebe...@bluestop.org wrote: > I've been working with the MACCHIATObin board, and noticed settings for > HTTP and TLS in Platform/SolidRun/Armada80x0McBin/Armada80x0McBin.dsc in > the repo >

[edk2-devel] [PATCH] BaseTools:Update binary cache restore time to current time

2019-05-28 Thread Steven Shi
https://bugzilla.tianocore.org/show_bug.cgi?id=1742 Current Binary Cache doesn't update the restored file creation and modification times to the current time. Preserve the new restored file creation time as old cached time might has potential issue to block the make to build updated files based

Re: [edk2-devel] [PATCH V4] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

2019-05-28 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Fan, ZhijuX Sent: Tuesday, May 28, 2019 2:29 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [PATCH V4] BaseTools:Make BaseTools support new rules to generate RAW FFS FILE

Re: [edk2-devel] [PATCH v2 6/7] BaseTools/tools_def CLANG3x ARM AARCH64: force use of C99 standard

2019-05-28 Thread Leif Lindholm
On Tue, May 28, 2019 at 08:10:44AM +0200, Ard Biesheuvel wrote: > On Tue, 28 May 2019 at 02:17, Liming Gao wrote: > > > > Ard: > > Is there any impact with new option? If no behavior change, I am OK for > > this patch. Reviewed-by: Liming Gao > > > > We don't rely on anything provided by the

[edk2-devel] [PATCH] BaseTools:Fix the library dependency missing in Binary Cache

2019-05-28 Thread Steven Shi
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1788 The library dependency of a module is wrongly filtered out by binary cache implementation which cause all dependent libraries will not been built prior to the module in the build scheduler and the module build fails if cache miss happen. Cc:

  1   2   >