Re: [edk2-devel] [PATCH V2] MdeModulePkg/CapsulePei: Optimize the CapsulePei

> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Friday, May 31, 2019 9:48 AM > To: devel@edk2.groups.io > Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; > Sean Brogan; Michael Turner; Gao,

Re: [edk2-devel] edk2-stable201905 features and soft/hard freeze and release date

Hi, all Now, we are still in soft feature freeze. 201905 stable tag depends on openssl 1.1.1 update, openssl 1.1.1 depends on ArmSoftFloatLib update, ArmSoftFloatLib depends on the discussion of contribution of code licensed. Once the conclusion is made, I will send the mail to announce the

Re: [edk2-devel] [Patch v2 0/3] [edk2-platforms] Add DebugFeaturePkg to keep debug related modules.

This version is good. Reviewed-by: Liming Gao >-Original Message- >From: Dong, Eric >Sent: Wednesday, May 29, 2019 3:34 PM >To: devel@edk2.groups.io >Cc: Gao, Liming >Subject: [Patch v2 0/3] [edk2-platforms] Add DebugFeaturePkg to keep >debug related modules. > >Add new package in

Re: [edk2-devel] Edk2 BaseTools Patches.

Thanks for your comments. I’ll push the below 2 patches. [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache [PATCH] BaseTools:Update binary cache restore time to current time I have no strong justification to push this patch in this stable tag. I’ll push it after the

Re: [edk2-devel] [PATCH 2/4] Platform/Intel:Add build parameter to support Binary Cache

Reviewed-by: Chasel Chiu > -Original Message- > From: Fan, ZhijuX > Sent: Friday, May 31, 2019 9:38 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C ; > Shi, Steven ; Lu, Shifei A ; > Zhou, > Bowen ; Oram, Isaac W ; > Chiu, Chasel ; Kubacki, Michael A > ; Desimone,

Re: [edk2-devel] [PATCH 1/4] Intel/Readme.md:Add instructions about Binary Cache in Readme.md

Reviewed-by: Chasel Chiu > -Original Message- > From: Fan, ZhijuX > Sent: Friday, May 31, 2019 9:37 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C ; > Shi, Steven ; Lu, Shifei A ; > Zhou, > Bowen ; Oram, Isaac W ; > Chiu, Chasel ; Kubacki, Michael A > ; Desimone,

[edk2-devel] [PATCH V2] MdeModulePkg/CapsulePei: Optimize the CapsulePei

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853 Optimize some function in CapsulePei to make it easier to maintian. 1. Separate the capsule check function form GetCapsuleDescriptors to AreCapsulesStaged. The original logic is unclear. 2. Avoid querying the capsule

Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei

> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Wednesday, May 29, 2019 11:09 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Bret Barkelew ; Wang, Jian J > ; Wu, Hao A ; Ni, Ray > ; Zeng, Star ; Gao, Liming > ; Sean Brogan ; > Michael Turner >

[edk2-devel] [PATCH 4/4] PurleyOpenBoardPkg:Extend options in bld.bat to support Binary Cache

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1785 Need extend the options in the Kabylake build bld.bat file to support Binary Cache. BINARY_CACHE_PATH: if BINARY_CACHE_PATH is empty, use BinCache as default path Add "cache-produce" and "cache-consume" to command line, Used to generate and

[edk2-devel] [PATCH 3/4] KabylakeOpenBoardPkg:Extend options in bld.bat to support Binary Cache

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1784 Need extend the options in the Kabylake build bld.bat file to support Binary Cache. BINARY_CACHE_PATH: if BINARY_CACHE_PATH is empty, use BinCache as default path Add "cache-produce" and "cache-consume" to command line, Used to generate and

[edk2-devel] [PATCH 2/4] Platform/Intel:Add build parameter to support Binary Cache

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1784 BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1785 Need extend the options in the Intel/build_bios.py file to support Binary Cache. --hash: Enable hash-based caching during build process. --binary-destination: Generate a cache of

[edk2-devel] [PATCH 1/4] Intel/Readme.md:Add instructions about Binary Cache in Readme.md

BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1784 BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1785 Add detailed instructions about Binary Cache in Readme.md, Extend options to support Binary Cache in the Kabylake build bld.bat file, Purley build bld.bat file, build_bios.py Cc: Liming

[edk2-devel] [PATCH 0/4] Makes binary cache available in Platform/Intel

Add detailed instructions about Binary Cache in Readme.md, Extend options to support Binary Cache in the Kabylake build bld.bat file, Purley build bld.bat file, build_bios.py Cc: Liming Gao Cc: Bob Feng Cc: Steven Shi Cc: Shifei A Lu Cc: Xiaohu Zhou Cc: Isaac W Oram Cc: Chasel Chiu Cc:

Re: [edk2-devel] Edk2 BaseTools Patches.

Andrew, What about the force include of AutoGen.h? AutoGen.h (and .c) have contents which are determined by various metadata like PCD values or items listed in the INF. The sources and dependencies can’t be involved, since those aren’t known until after the autogen files are already

Re: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 05/30/2019 5:00pm-5:30pm #cal-reminder

On 5/30/19 5:45 PM, devel@edk2.groups.io Calendar wrote: *Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 30 May 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los Angeles *Where:*https://zoom.us/j/769108409 View Event

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Thursday, 30 May 2019 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.14...@groups.io DTSTAMP:20190530T234747Z ORGANIZER;CN=Stephano Cetola:mailto:stephano.cet...@intel.com

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 05/30/2019 5:00pm-5:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 30 May 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/769108409 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=458023 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com (

Re: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver

Reviewed-by: Maurice Ma Regards, Maurice > -Original Message- > From: Dong, Guo > Sent: Thursday, May 30, 2019 2:52 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > ; Dong, Guo > Subject: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver > > Since legacy PIC

Re: [edk2-devel] Maintainers.txt: update UEFI payload information

Reviewed-by: Maurice Ma Regards, Maurice > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Guo > Dong > Sent: Thursday, May 30, 2019 3:07 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > ; Dong, Guo ; Agyeman, > Prince > Subject:

Re: [edk2-devel] Edk2 BaseTools Patches.

> On May 30, 2019, at 2:31 PM, Johnson, Michael > wrote: > > All, > > These patches are not required for the stable tag. They’re improvements > needed to enable relatively new build options that are not yet widely used. > > That said, let me try to clear the air here about what is happening

Re: [edk2-devel] Edk2 BaseTools Patches.

All, These patches are not required for the stable tag. They're improvements needed to enable relatively new build options that are not yet widely used. That said, let me try to clear the air here about what is happening regarding the sources/includes and what changes with these patches. The

Re: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

On Tue, May 28, 2019 at 07:04:09PM +0100, Leif Lindholm wrote: > +Haojian, > > Haojian - since you are the original author, can you comment on the > delays? Are these silicon bug workarounds (so we need to add a Pcd), > or does these changes work on your platforms too? I'm not in the loop, so I

Re: [edk2-devel] Edk2 BaseTools Patches.

> On May 30, 2019, at 9:37 AM, Leif Lindholm wrote: > > Thanks Bob, Christian, > > On Thu, May 30, 2019 at 03:06:48PM +, Feng, Bob C wrote: >> Thanks Christian. I add some short description for the patches. >> >> These 5 patches are all for binary cache feature. >> >> [Patch V4 2/2]

Re: [edk2-devel] [PATCH v2] Marvell/Armada80x0McBin: Enable USB keyboard, NVMe boot

On Thu, May 30, 2019 at 12:39:13PM -0500, Jeremy Linton wrote: > Add the USB keyboard driver, which is needed when a graphical > console is used. Also add a NVMe boot option for users that > choose that instead of SATA or MMC. > > Contributed-under: TianoCore Contribution Agreement 1.1 >

Re: [edk2-devel] Edk2 BaseTools Patches.

See below. >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Thursday, May 30, 2019 9:38 AM >To: Feng, Bob C >Cc: Rodriguez, Christian ; Andrew Fish >; Laszlo Ersek ; Kinney, Michael D >; devel@edk2.groups.io; Gao, Liming >; Shi, Steven ; Fan, ZhijuX >

[edk2-devel] [PATCH v2] Marvell/Armada80x0McBin: Enable USB keyboard, NVMe boot

Add the USB keyboard driver, which is needed when a graphical console is used. Also add a NVMe boot option for users that choose that instead of SATA or MMC. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Jeremy Linton Reviewed-by: Marcin Wojtas ---

Re: [edk2-devel] [PATCH] Marvell/Armada80x0McBin: Enable usb keyboard, nvme boot

Hi, On 5/29/19 6:09 AM, Leif Lindholm wrote: On Tue, May 28, 2019 at 06:43:13PM -0500, Jeremy Linton wrote: Add a USB keyboard flag, which is needed when a graphical console is enabled. Also add a nvme boot option for users that choose that instead of sata or mmc. Contributed-under:

Re: [edk2-devel] Edk2 BaseTools Patches.

Thanks Bob, Christian, On Thu, May 30, 2019 at 03:06:48PM +, Feng, Bob C wrote: > Thanks Christian. I add some short description for the patches. > > These 5 patches are all for binary cache feature. > > [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources > section

[edk2-devel] [RFC PATCH 2/2] BaseTools: add script to configure local git options

Patch contribution and review is greatly simplified by following the steps described in "Laszlo's unkempt guide": https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers but there are a lot of tedious manual steps in there, so here is

[edk2-devel] [RFC PATCH 1/2] BaseTools: add centralized location for git config files

Before adding the git environment initialization script, add the following files that will be pointed to after running said script: - BaseTools/Conf/diff.order - BaseTools/Conf/gitattributes Signed-off-by: Leif Lindholm --- BaseTools/Conf/diff.order| 8

[edk2-devel] [RFC PATCH 0/2] BaseTools: add script to set up git environment

https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers is a great resource, but it's a lot of manual steps to go through for each repository (especially as the number seems to grow). Script works with python2/3 under both Posix and

Re: [edk2-devel] Edk2 BaseTools Patches.

Thanks Christian. I add some short description for the patches. These 5 patches are all for binary cache feature. [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources section [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file The above 2 patches

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg/SplitFspBin.py: Support rebasing 1.x binary.

Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Thursday, May 30, 2019 12:58 PM To: devel@edk2.groups.io Cc: Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH v2] IntelFsp2Pkg/SplitFspBin.py: Support rebasing 1.x binary. REF:

Re: [edk2-devel] Edk2 BaseTools Patches.

Hey Leif, I thought I'd help Bob and gather those BZs for each thread: [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources section BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1804 [PATCH v3

[edk2-devel] [PATCH v2 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

The ACPI 6.3 specification introduces a 'SPE overflow Interrupt' field as part of the GICC structure. Update the MADT parser to decode this field and validate the interrupt ID used. References: - ACPI 6.3 Specification - January 2019 - Arm Generic Interrupt Controller Architecture Specification,

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

Hi Zhichao, Thanks for the review. My responses are added inline as [Krzysztof]. Kind regards, Krzysztof -Original Message- From: devel@edk2.groups.io On Behalf Of Gao, Zhichao via Groups.Io Sent: Thursday, May 30, 2019 9:55 To: devel@edk2.groups.io; Krzysztof Koch Cc: Sami Mujawar

Re: [edk2-devel] Edk2 BaseTools Patches.

Hi Bob, On Thu, May 30, 2019 at 06:39:59AM +, Feng, Bob C wrote: > Hi, > > Currently, we have 5 Basetools patches which are ready to > push. Since we are in the soft-freeze phase, I'd like to ask for > your opinions if those patches can be pushed to edk2 master. To save me the time of

Re: [edk2-devel] [PATCH v2 7/7] ArmPkg/ArmLib ARM: set .fpu to let Clang 7 assemble ArmV7Support.S

Hi Ard, On 5/27/19 10:51 PM, Ard Biesheuvel wrote: > Clang 7 complains about the vmsr instruction in ArmV7Support.S, > which is only available on cores that implement some flavour of > VFP. So set the .fpu to NEON like we do in some other places. > > Signed-off-by: Ard Biesheuvel > --- > Note

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: acpiview: ACPI 6.3 update for MADT parser

Sorry for late update. Some minor comments below. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Friday, May 17, 2019 12:06 AM > To: devel@edk2.groups.io > Cc: sami.muja...@arm.com; Carsey, Jaben ; Ni, > Ray ;

[edk2-devel] [PATCH v1 1/1] CryptoPkg/BaseCryptLib: Wrap OpenSSL SM3 algorithm

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1861 1. Implement OpenSSL SM3 wrapped functions in CryptSm3.c file. 2. Add wrapped SM3 functions declaration to BaseCryptLib.h file. 3. Add CryptSm3.c to each module information file. Cc: Jian J Wang Signed-off-by: Xiaoyu Lu ---

[edk2-devel] [PATCH v1] MdeModulePkg/AhciPei: Fix device cannot be found in non-S3 path

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1862 Current implementation of function AhciModeInitialization() has an incorrect assumption that the value in the CAP (offset 00h) register will always be greater than the highest bit set for the value in the PI (offset 0Ch) register. This will

Re: [edk2-devel] [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand polling

> -Original Message- > From: Haojian Zhuang > Sent: Thursday, May 30, 2019 3:06 PM > To: Leif Lindholm > Cc: Loh, Tien Hock ; devel@edk2.groups.io; > thlo...@gmail.com; Ard Biesheuvel > Subject: Re: [PATCH v2 6/7] EmbeddedPkg: Fix DwEmmc SendCommand > polling > > On Tue, May 28, 2019

[edk2-devel] Edk2 BaseTools Patches.

Hi, Currently, we have 5 Basetools patches which are ready to push. Since we are in the soft-freeze phase, I'd like to ask for your opinions if those patches can be pushed to edk2 master. These 5 patches are to fix the issues for the build cache feature. [Patch V4 2/2] BaseTools: Refactor

Re: [edk2-devel] [PATCH v3 1/1] BaseTools:Extend the binary cache to support library cache

Yes. The "entend" should be "extend", please help to fix it when pushing. Thanks! Steven Shi > -Original Message- > From: Feng, Bob C > Sent: Thursday, May 30, 2019 10:44 AM > To: devel@edk2.groups.io; Shi, Steven > Cc: Gao, Liming ; Rodriguez, Christian > ; Fan, ZhijuX > Subject:

Re: [edk2-devel] [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources section

Reviewed-by: Bob Feng -Original Message- From: Rodriguez, Christian Sent: Thursday, May 30, 2019 12:27 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [Patch V4 2/2] BaseTools: Refactor hash tracking after checking for Sources section BZ:

Re: [edk2-devel] [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file

Reviewed-by: Bob Feng -Original Message- From: Rodriguez, Christian Sent: Thursday, May 30, 2019 12:27 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Zhu, Yonghong Subject: [Patch V4 1/2] BaseTools: Add a checking for Sources section in INF file BZ: