Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices
Hello Ravi Kumar, From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ravi Kumar Siadri Sent: Thursday, June 13, 2019 4:18 PM To: Wu, Hao A Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices Hi Wu Hao A, Thanks for the response.
Re: [edk2-devel] [PATCH v1 2/6] OvmfPkg/OvmfPkg.dec: Add PcdShellFile in OVMF DEC file
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Thursday, June 13, 2019 10:42 PM > To: devel@edk2.groups.io; Wu, Hao A > Cc: Ni, Ray; Justen, Jordan L; Ard Biesheuvel > Subject: Re: [edk2-devel] [PATCH v1 2/6]
[edk2-devel] [PATCH v3 2/4] OvmfPkg/IncompatiblePciDeviceSupportDxe: Drop framework pkg dependency
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843 This commit will drop the driver's dependency on the IntelFrameworkPkg: gEfiLegacyBiosProtocolGuid Such dependency has already been addressed by the duplication of the above definition from IntelFrameworkPkg into the OvmfPkg. Cc: Ray Ni
[edk2-devel] [PATCH v3 4/4] OvmfPkg: Refer to Shell app via its declared GUID
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843 Currently, the file GUID reference of the UEFI Shell app is indirected via the PCD gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile, which is set to a fixed value for OvmfPkg. So instead, use the symbolic GUID in ShellPkg for this
[edk2-devel] [PATCH v3 1/4] OvmfPkg/PlatformPei: Remove redundant reference of framework pkg DEC
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843 For the driver's INF file, this commit will remove the redundant reference to 'IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec'. Cc: Ray Ni Cc: Jordan Justen Cc: Ard Biesheuvel Signed-off-by: Hao A Wu Reviewed-by: Laszlo Ersek ---
[edk2-devel] [PATCH v3 3/4] OvmfPkg/Csm/CsmSupportLib: Drop IntelFrameworkPkg dependency
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843 This commit will update the INF file of the CsmSupportLib to drop its dependency on IntelFrameworkPkg: gEfiLegacyBiosPlatformProtocolGuid gEfiLegacyBiosProtocolGuid gEfiLegacyInterruptProtocolGuid The above dependencies have already been
Re: [edk2-devel] [PATCH v2 0/3] Common OBB verification feature
Forgot to mention test: 1. Unit test and security test based on HBFA test framework 2. System test on three real platforms Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang, > Jian J > Sent: Friday, June 14, 2019 8:30 AM >
Re: [edk2-devel] [PATCH v2 00/10] Duplicate required CSM components for OVMF
Thanks all. Series pushed via commits 0a35997643..b0663641c9. Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > David Woodhouse > Sent: Thursday, June 13, 2019 5:40 AM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Ni, Ray;
Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol
> -Original Message- > From: Albecki, Mateusz > Sent: Thursday, June 13, 2019 10:39 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A > Subject: RE: [PATCH 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision > 3 of SdMmcOverrideProtocol > > Resending to group. Inline reply to some of the
[edk2-devel] [PATCH V2] BaseTools:Add DetectNotUsedItem.py to Edk2\BaseTools\Scripts
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1850 This script is used to Detect unreferenced PCD and GUID/Protocols/PPIs. The input parameters are Dec file and package directory. This script can be run in
Re: [edk2-devel] [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol
Loop in Ard and Marcin. Hello Ard and Marcin, We are proposing to make an extension to the SDMMC Override protocol to more customization for platforms during the SD/eMMC device/controller initialization process. For convenience, the series is available at:
[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Thu, 06/13/2019 6:30pm-7:30pm #cal-reminder
*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Thursday, 13 June 2019, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/969264410 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=458028 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com
Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory]
Yes, ok for me. Good idea to add the overview of the package content. Thank you Yao Jiewen From: Oram, Isaac W Sent: Friday, June 14, 2019 8:55 AM To: Gao, Liming ; Yao, Jiewen ; Dong, Eric ; devel@edk2.groups.io; Kinney, Michael D Subject: RE: [RFC][edk2-platform][Add new packages in
Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory]
This looks good to me. I would suggest that we also capture an overview of the organization and the targeted contents of the different packages in the Platform/Intel/Readme.md or maybe a wiki page. Thanks, Isaac From: Gao, Liming Sent: Wednesday, June 12, 2019 6:27 AM To: Oram, Isaac W ; Yao,
Re: [edk2-devel] [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol
> -Original Message- > From: Yao, Jiewen > Sent: Friday, June 14, 2019 6:32 AM > To: Zurcher, Christopher J; Gao, Liming; devel@edk2.groups.io > Cc: Kinney, Michael D; Wang, Jian J; Ni, Ray; Wu, Hao A > Subject: RE: [PATCH v4 0/2] Add SCSI Support for Storage Security Command > Protocol >
[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 06/13/2019 5:00pm-5:30pm #cal-reminder
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 13 June 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/769108409 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=458031 ) *Organizer:* Stephano Cetola stephano.cet...@intel.com (
Re: [edk2-devel] [PATCH] CryptoPkg: define DSO_NONE in the OpenSSL build
On 2019-06-13 17:32, Rebecca Cran wrote: > This fixes the build on FreeBSD, where DSO_METHOD_openssl is undefined > since dso_openssl.c only compiles the function if DSO_NONE is defined. Sorry, I just realized this isn't applicable to the OpenSSL we currently pull in: I was testing against
[edk2-devel] [PATCH] CryptoPkg: define DSO_NONE in the OpenSSL build
This fixes the build on FreeBSD, where DSO_METHOD_openssl is undefined since dso_openssl.c only compiles the function if DSO_NONE is defined. Signed-off-by: Rebecca Cran --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +- CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 2 +- 2
Re: [edk2-devel] [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol
Thank you Christopher. Your code looks good to me. I also recommend MdeModulePkg/SCSI owner take a look and give r-b. Ray or Hao Can you help on that? Thank you Yao Jiewen > -Original Message- > From: Zurcher, Christopher J > Sent: Friday, June 14, 2019 6:26 AM > To: Gao, Liming ;
Re: [edk2-devel] [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol
A unit test has been run which provisions RPMB key, writes data, and verifies it after reading on the following boot. Further, this code is being exercised for secure storage on multiple platforms as part of standard boot flow. Unit test files emailed separately. Thanks, Christopher Zurcher
Re: [edk2-devel] [PATCH v4 1/2] MdePkg: Implement SCSI commands for Security Protocol In/Out
> Why remove ASCIT8_1 & ASCIT8_2? Can we keep them for compatibility? If that's preferred, I can add them back in. They were only removed as they are marked obsolete in SPC-5. -- Christopher Zurcher -Original Message- From: Gao, Liming Sent: Thursday, June 13, 2019 05:54 To: Zurcher,
Re: [edk2-devel] [PATCH 0/6] Fix race condition and add event protocol
Felix: Sorry for the late response. > -Original Message- > From: Felix Polyudov [mailto:fel...@ami.com] > Sent: Friday, May 24, 2019 8:53 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Wang, Jian J ; Wu, Hao A ; Ni, > Ray ; Zeng, Star > ; Gao, Liming ; Sean Brogan > ; Michael
Re: [edk2-devel] [PATCH 0/2] EmbeddedPkg,ArmPlatformPkg: fix VS2017 TimeBaseLib build errors
On 6/13/19 6:18 PM, Leif Lindholm wrote: > TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs > between architectures. This upsets VS2017 when building for 32-bit ARM > (and likely would if building for IA32 too). Similarly, some internal > calculations used UINTN for
Re: [edk2-devel] [PATCH 0/2] EmbeddedPkg,ArmPlatformPkg: fix VS2017 TimeBaseLib build errors
On Thu, 13 Jun 2019 at 18:18, Leif Lindholm wrote: > > TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs > between architectures. This upsets VS2017 when building for 32-bit ARM > (and likely would if building for IA32 too). Similarly, some internal > calculations used
[edk2-devel] [PATCH 2/2] EmbeddedPkg: improve TimeBaseLib type safety
EfiTimeToEpoch currently returns a UINTN. Also, some internal calculations was using UINTN for fixed-width. Both of these lead to warnings/errors with VS2017. Replace with appropriate fixed-size types. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=997 Cc: Alexei Fedorov Signed-off-by:
[edk2-devel] [PATCH 1/2] ArmPlatformPkg: use UINT32 epoch second counter
The comments describes the device as being 32-bit: "the maximum time span is just over 136 years" then uses a UINTN to hold the value. Change to UINT32 so we don't get different behaviour for different architectures. Signed-off-by: Leif Lindholm ---
Re: [edk2-devel] [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID
Hi, Laszlo Thank you for the reminder. Reviewed patch #4 just now. Regards, Maurice > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, June 13, 2019 8:32 > To: Ard Biesheuvel ; Leif Lindholm > ; Ma, Maurice ; Dong, > Guo ; You, Benjamin > Cc: Wang,
Re: [edk2-devel] [PATCH v2 4/4] UefiPayloadPkg/PlatformBootManagerLib: Use EDKII_SERIAL_PORT_LIB_VENDOR_GUID from MdeModulePkg
Reviewed-by: Maurice Ma Regards, Maurice > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Anthony PERARD > Sent: Thursday, June 6, 2019 6:15 > To: devel@edk2.groups.io > Cc: Ni, Ray ; Julien Grall ; Ard > Biesheuvel ; Leif Lindholm > ;
Re: [edk2-devel] [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID
On 06/13/19 17:32, Laszlo Ersek wrote: > On 06/06/19 15:14, Anthony PERARD wrote: >> The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been >> used >> once without defining the macro. This patch series define a macro in >> MdeModulePkg where the SerialDxe is, and replace all
Re: [edk2-devel] [PATCH v2 0/4] Define EDKII_SERIAL_PORT_LIB_VENDOR_GUID
On 06/06/19 15:14, Anthony PERARD wrote: > The macro SERIAL_DXE_FILE_GUID is been defined twice and the GUID is been used > once without defining the macro. This patch series define a macro in > MdeModulePkg where the SerialDxe is, and replace all other use by this new > one, >
Re: [edk2-devel] [RFC][PATCH v1 0/3] Remove IntelFramework[Module]Pkg
On 05/27/19 08:48, Wu, Hao A wrote: > ''' > Please note that this series will be hold until all the below requirements > are met: > > A. edk2-stable201905 is created; > B. OvmfPkg has been updated to drop its dependency on >IntelFramework[Module]Pkg; (Patches already been sent) > C. Platforms
Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework modules
Hello Hao, On 05/27/19 08:36, Wu, Hao A wrote: > ''' > Please note that this patch will be hold until all the below requirements > are met: > > A. edk2-stable201905 is created; > B. OvmfPkg has drop its usage of the legacy ISA stack (which includes >the IsaAcpiDxe driver); > C.
Re: [edk2-devel] [PATCH v1 6/6] OvmfPkg/Csm/CsmSupportLib: Drop IntelFrameworkPkg dependency
On 05/27/19 07:19, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843 > > This commit will update the INF file of the CsmSupportLib to drop its > dependency on IntelFrameworkPkg: > > gEfiLegacyBiosPlatformProtocolGuid > gEfiLegacyBiosProtocolGuid >
Re: [edk2-devel] [PATCH v1 5/6] OvmfPkg/IncompatiblePciDeviceSupportDxe: Drop framework pkg dependency
On 05/27/19 07:19, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843 > > This commit will drop the driver's dependency on the IntelFrameworkPkg: > gEfiLegacyBiosProtocolGuid > > Such dependency has already been addressed by the duplication of the above > definition from
Re: [edk2-devel] [PATCH v1 2/6] OvmfPkg/OvmfPkg.dec: Add PcdShellFile in OVMF DEC file
Hi Hao, On 05/27/19 07:19, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843 > > OVMF is currently using the PCD 'PcdShellFile' defined in > IntelFrameworkModulePkg. > > This commit will add this PCD into the OVMF DEC file in order to drop > OVMF's dependency on
Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol
Resending to group. Inline reply to some of the comments. As for the mapping between eMMC driver strength and SD controller driver strength should we use this one: SD controller -> eMMC card B-> Type 0 A -> Type 1 C -> Type 2 D
Re: [edk2-devel] [PATCH v1 1/6] OvmfPkg/PlatformPei: Remove redundant reference of framework pkg DEC
On 05/27/19 07:19, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843 > > For the driver's INF file, this commit will remove the redundant reference > to 'IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec'. > > Cc: Ray Ni > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc:
Re: [edk2-devel] [PATCH v2 11/10] OvmfPkg/Csm/LegacyBiosDxe: Fix Legacy16GetTableAddress call for E820 data
On 06/13/19 10:40, David Woodhouse wrote: > The DX register is supposed to contain the required alignment for the > allocation. It was zero, and SeaBIOS doesn't (well, didn't) cope well > with that. Set it appropriately. > > Also set BX to indicate the regions it's OK to allocate in too. That >
Re: [edk2-devel] [PATCH v2 10/10] OvmfPkg: Update DSC/FDF files to consume CSM components in OvmfPkg
On 05/27/19 05:03, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > > This commit updates the OVMF DSC/FDF files to consume the copied CSM > components within OvmfPkg. > > Cc: David Woodhouse > Cc: Ray Ni > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel
Re: [edk2-devel] [PATCH v2 09/10] OvmfPkg/Csm/LegacyBootManagerLib: Update to make it build for OVMF
On 05/27/19 05:03, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > > This commit will update the library's INF file to: > > A) Assign a new file GUID; > B) Remove the IntelFramework[Module]Pkg DEC file dependency. > > Please note that a subsequent commit (final
Re: [edk2-devel] [PATCH v2 08/10] OvmfPkg/Csm/LegacyBootMaintUiLib: Update to make it build for OVMF
On 05/27/19 05:03, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > > This commit will update the library's INF file to: > > A) Assign a new file GUID; > B) Remove the IntelFramework[Module]Pkg DEC file dependency. > > Please note that a subsequent commit (final
Re: [edk2-devel] [PATCH v2 07/10] OvmfPkg/Csm/LegacyBiosDxe: Update to make it build for OVMF
On 05/27/19 05:03, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > > This commit will update the driver's INF file to: > > A) Assign a new file GUID; > B) Consume the PCDs duplicated in OvmfPkg DEC file; > C) Remove the IntelFramework[Module]Pkg DEC file dependency.
Re: [edk2-devel] [PATCH v2 06/10] OvmfPkg/Csm/VideoDxe: Update to make it build for OVMF
On 05/27/19 05:03, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > > This commit will update the driver's INF file to: > > A) Assign a new file GUID; > B) Consume the PCDs duplicated in OvmfPkg DEC file; > C) Remove the IntelFramework[Module]Pkg DEC file dependency.
Re: [edk2-devel] [PATCH v2 05/10] OvmfPkg/OvmfPkg.dec: Add PCD definitions used by copied CSM modules
On 05/27/19 05:03, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > > This commit will add the PCD definitions consumed by the duplicated > drivers: > > * VideoDxe > * LegacyBiosDxe > > into the OvmfPkg DEC file. > > Please note that, instead of adding these PCDs
Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/SdMmcOverride: Add GetOperatingParam notify phase
Resending to group. > -Original Message- > From: Wu, Hao A > Sent: Monday, June 10, 2019 5:19 AM > To: Albecki, Mateusz > Subject: RE: [PATCH 1/2] MdeModulePkg/SdMmcOverride: Add > GetOperatingParam notify phase > > Thanks Mateusz, > > Please refer to the comments in patch 2/2 for the
Re: [edk2-devel] [PATCH v2 04/10] OvmfPkg/OvmfPkg.dec: Add the new include folder for CSM header files
On 05/27/19 05:03, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > > The previous file-duplication commit has put all the CSM related header > files within folder: OvmfPkg/Csm/Inclue. > > This commit will update the DEC file to add that folder under the > '[Include]'
Re: [edk2-devel] [PATCH v2 03/10] OvmfPkg/OvmfPkg.dec: Add definitions for CSM-related Guid & Protocol
On 05/27/19 05:03, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > > This commit will add the Guid definitions of the duplicated CSM-related > Guids and Protocols from IntelFramework[Module]Pkg. > > Cc: David Woodhouse > Cc: Ray Ni > Cc: Jordan Justen > Cc: Laszlo
Re: [edk2-devel] [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol
Resending to group. From: Wu, Hao A Sent: Monday, June 10, 2019 5:18 AM To: Albecki, Mateusz Subject: RE: [PATCH 0/2] Add GetOperatingParam notify phase to SdMmcOverride protocol Hello Mateusz, Thanks for the patch series and sorry for the delayed response. One question first, I did not
Re: [edk2-devel] [PATCH v2 02/10] OvmfPkg: Copy the required CSM components from framework packages
On 05/27/19 05:03, Wu, Hao A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1811 > > This commit copies the exact: > > Drivers: > * VideoDxe > * LegacyBiosDxe > > Libraries: > * LegacyBootMaintUiLib > * LegacyBootManagerLib > > Guid header files: > * Legacy Bios Guid > *
Re: [edk2-devel] [PATCH v2 01/10] Maintainers.txt: Add maintainer for CSM components in OvmfPkg
On 05/27/19 05:03, Wu, Hao A wrote: > According to the discussion at: > > https://edk2.groups.io/g/devel/topic/31627718#40659 > (Request by Laszlo to find proper maintainer for to-be-duplicated CSM > components in OvmfPkg.) > > and: > > https://edk2.groups.io/g/devel/topic/31682287#40996 >
Re: [edk2-devel] [PATCH v4 0/2] Add SCSI Support for Storage Security Command Protocol
Zurcher: Can you share what test has been done for this feature? Thanks Liming > -Original Message- > From: Zurcher, Christopher J > Sent: Thursday, June 13, 2019 10:05 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Yao, Jiewen > ; Wang, Jian J ; Gao, > Liming > Subject:
Re: [edk2-devel] [PATCH v4 1/2] MdePkg: Implement SCSI commands for Security Protocol In/Out
> -Original Message- > From: Zurcher, Christopher J > Sent: Thursday, June 13, 2019 10:05 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Gao, Liming > Subject: [PATCH v4 1/2] MdePkg: Implement SCSI commands for Security Protocol > In/Out > > This patch implements
Re: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data
On 06/13/19 10:34, David Woodhouse wrote: > On Thu, 2019-06-13 at 06:28 +, Wu, Hao A wrote: >> Hello Ray, >> >> Do you have comment on this? >> >> Some inline comments below: >> >>> -Original Message- >>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >>> David
Re: [edk2-devel] [PATCH v1 1/2] MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Wednesday, June 12, 2019 10:11 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; Gao, > Zhichao ; Kinney, Michael D > ; Gao, Liming
Re: [edk2-devel] [PATCH v1 2/2] ShellPkg: acpiview: Update SRAT parser to ACPI 6.3
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42358): https://edk2.groups.io/g/devel/message/42358 Mute This Topic: https://groups.io/mt/32042587/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:
Re: [edk2-devel] [PATCH v1 0/2] Update the SRAT Acpiview parser to ACPI 6.3
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42357): https://edk2.groups.io/g/devel/message/42357 Mute This Topic: https://groups.io/mt/32042460/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:
Re: [edk2-devel] [PATCH edk2-platforms] Platforms/Hisilicon: update OptionRomPkg path for HiKey
On Thu, Jun 13, 2019 at 01:42:29PM +0200, Ard Biesheuvel wrote: > On Thu, 13 Jun 2019 at 13:41, Leif Lindholm wrote: > > > > The migration of OptionRomPkg to edk2-platforms broke the HiKey build. > > Update the paths in .dsc/.fdf to restore. > > > > Signed-off-by: Leif Lindholm > > Acked-by:
Re: [edk2-devel] [PATCH v1 1/2] MdePkg: Add Generic Initiator Affinity Structure definitions to SRAT
Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42355): https://edk2.groups.io/g/devel/message/42355 Mute This Topic: https://groups.io/mt/32043797/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:
Re: [edk2-devel] [PATCH edk2-platforms] Platforms/Hisilicon: update OptionRomPkg path for HiKey
On Thu, 13 Jun 2019 at 13:41, Leif Lindholm wrote: > > The migration of OptionRomPkg to edk2-platforms broke the HiKey build. > Update the paths in .dsc/.fdf to restore. > > Signed-off-by: Leif Lindholm Acked-by: Ard Biesheuvel > --- > Platform/Hisilicon/HiKey/HiKey.dsc | 2 +- >
[edk2-devel] [PATCH edk2-platforms] Platforms/Hisilicon: update OptionRomPkg path for HiKey
The migration of OptionRomPkg to edk2-platforms broke the HiKey build. Update the paths in .dsc/.fdf to restore. Signed-off-by: Leif Lindholm --- Platform/Hisilicon/HiKey/HiKey.dsc | 2 +- Platform/Hisilicon/HiKey/HiKey.fdf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git
Re: [edk2-devel] [PATCH V4 0/2] MdeModulePkg: Make the screen seamless
On 06/13/19 08:58, Wu, Hao A wrote: >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Wu, Hao A >> Sent: Monday, May 27, 2019 10:15 AM >> To: Gao, Zhichao; devel@edk2.groups.io >> Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean
Re: [edk2-devel] [PATCH v2] Platform/Intel: Dynamic NUMBER_OF_PROCESSORS in build.
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu, Chasel Sent: Thursday, June 13, 2019 4:32 PM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L ; Gao, Liming ; Feng, Bob C Subject: [edk2-devel]
[edk2-devel] [PATCH v2 11/10] OvmfPkg/Csm/LegacyBiosDxe: Fix Legacy16GetTableAddress call for E820 data
The DX register is supposed to contain the required alignment for the allocation. It was zero, and SeaBIOS doesn't (well, didn't) cope well with that. Set it appropriately. Also set BX to indicate the regions it's OK to allocate in too. That wasn't being initialised and was just using whatever
Re: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data
On Thu, 2019-06-13 at 06:28 +, Wu, Hao A wrote: > Hello Ray, > > Do you have comment on this? > > Some inline comments below: > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > David Woodhouse > > Sent: Thursday, June 13, 2019 5:43
Re: [edk2-devel] [PATCH] Platform/Intel: Dynamic NUMBER_OF_PROCESSORS in build.
Thanks Bob! I was not aware that BaseTools already handled this. I just verified and it works so I will update code review which will only touch build.cfg. Thanks! Chasel > -Original Message- > From: Feng, Bob C > Sent: Thursday, June 13, 2019 3:39 PM > To: devel@edk2.groups.io;
[edk2-devel] [PATCH v2] Platform/Intel: Dynamic NUMBER_OF_PROCESSORS in build.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1913 To improve build performance by default the maximum processors should be used for building. NUMBER_OF_PROCESSORS in build.cfg is set to 0 so BaseTools can utilize maximum processors for build. Test: tried NUMBER_OF_PROCESSORS 0 and 1 cases
[edk2-devel] [PATCH] Platform/Intel: Dynamic NUMBER_OF_PROCESSORS in build.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1913 To improve build performance by default the maximum processors should be used for building. NUMBER_OF_PROCESSORS in build.cfg is set to 0 so BaseTools can utilize maximum processors for build. Test: tried NUMBER_OF_PROCESSORS 0 and 1 cases
Re: [edk2-devel] [PATCH] MdeModulePkg: Add lacking instances for build only
> -Original Message- > From: Gao, Zhichao > Sent: Wednesday, June 12, 2019 10:40 AM > To: devel@edk2.groups.io > Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; > Sean Brogan; Michael Turner > Subject: [PATCH] MdeModulePkg: Add lacking instances for build only
Re: [edk2-devel] [PATCH] Platform/Intel: Dynamic NUMBER_OF_PROCESSORS in build.
Reviewed-by: Nate DeSimone On 6/12/19, 11:17 PM, "Chiu, Chasel" wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1913 To improve build performance by default the maximum processors should be used for building. To support this, NUMBER_OF_PROCESSORS in build.cfg
Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices
Hi Wu Hao A, Thanks for the response. I have added my comments in line. Thanks, Ravi Kumar On Wed, Jun 12, 2019 at 1:26 PM Wu, Hao A wrote: > Hello Ravi Kumar, > > > > Inline comments below: > > > > *From:* devel@edk2.groups.io [mailto:devel@edk2.groups.io] *On Behalf Of *Ravi > Kumar
Re: [edk2-devel] UEFI SCT Build Broken
Ashish, Supreeth already sent out the patch yesterday, we will let you know if the patches are committed to repo. Thanks. Best Regards Eric From: Jin, Eric Sent: Wednesday, June 12, 2019 5:19 PM To: Ashish Singhal ; Supreeth Venkatesh ; devel@edk2.groups.io Cc: Jin, Eric Subject: RE: UEFI
Re: [edk2-devel] [edk2-test][PATCH v1 5/5] EasLib: Remove files required for building Ipf
Hello Supreeth, The serial patch 1- 5 is good to me. Could you add one patch to remove source and header files required for building library from SctPkg/Library/SctLib/SctLib.inf ? [sources.ipf] Ipf/SctLibPlat.h Ipf/initplat.c Ipf/salpal.c Ipf/libsalpal.h Math.c Best Regards Eric
Re: [edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking instances for build only
> -Original Message- > From: Gao, Zhichao > Sent: Wednesday, June 12, 2019 10:40 AM > To: devel@edk2.groups.io > Cc: Bret Barkelew; Wu, Hao A; Gao, Liming; Sean Brogan; Michael Turner; Leif > Lindholm; Gao, Zhichao > Subject: [PATCH] SourceLevelDebugPkg: Add lacking instances for build
Re: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data
On Thu, 2019-06-13 at 00:40 -0700, Jordan Justen wrote: > On 2019-06-12 23:28:12, Wu, Hao A wrote: > > > > > -Original Message- > > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > > David Woodhouse > > > Sent: Thursday, June 13, 2019 5:43 AM > > > > > > The DX
Re: [edk2-devel] [PATCH V3 2/2] MdeModulePkg/BdsDxe: Use a pcd to control PlatformRecovery
> -Original Message- > From: Wu, Hao A > Sent: Thursday, June 13, 2019 3:39 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Wang, Jian J ; Ni, Ray ; Zeng, > Star ; Gao, Liming ; Sean > Brogan ; Michael Turner > ; Bret Barkelew > > Subject: RE: [edk2-devel] [PATCH V3 2/2]
Re: [edk2-devel] [PATCH v5 0/5] MdeModulePkg/CapsulePei: Optimize the CapsulePei
> -Original Message- > From: Gao, Zhichao > Sent: Monday, June 10, 2019 1:21 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; > Michael Turner; Bret Barkelew; Leif Lindholm > Subject: [PATCH v5 0/5] MdeModulePkg/CapsulePei:
Re: [edk2-devel] [Patch V3] EmulatorPkg: don't display the cpu current speed
On 2019-06-11 22:42:13, Liu, Zhiguang wrote: > Thanks for the comments. > I will change the commit message in the next version. > But I don't think this is a issue worth making a major change. > Given that the change is consistent with NT32, will you agree with this > change? Hmm. You are right
Re: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data
On 2019-06-12 23:28:12, Wu, Hao A wrote: > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > David Woodhouse > > Sent: Thursday, June 13, 2019 5:43 AM > > > > The DX register is supposed to contain the required alignment for the > >
Re: [edk2-devel] [PATCH V3 1/2] MdeModulePkg: Add a pcd to set the OS indications bit
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Tuesday, June 04, 2019 9:05 AM > To: devel@edk2.groups.io > Cc: Bret Barkelew; Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; > Sean Brogan; Michael Turner >
Re: [edk2-devel] [PATCH] Platform/Intel: Dynamic NUMBER_OF_PROCESSORS in build.
Hi Chasel, Patch looks good. For the process number, build.py does the same thing as this patch. If pass -n 0 to build.py, build.py will set the processor number to multiprocessing.cpu_count() Thanks, Bob -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On
Re: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data
> -Original Message- > From: Wu, Hao A > Sent: Thursday, June 13, 2019 2:28 PM > To: devel@edk2.groups.io; dw...@infradead.org; Ni, Ray > > Cc: Justen, Jordan L ; Laszlo Ersek > ; Ard Biesheuvel > Subject: RE: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: > Correct
Re: [edk2-devel] [PATCH V4 0/2] MdeModulePkg: Make the screen seamless
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Monday, May 27, 2019 10:15 AM > To: Gao, Zhichao; devel@edk2.groups.io > Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; Michael > Turner; Bret Barkelew; Laszlo
Re: [edk2-devel] [PATCH v2 1/4] MdeModulePkg: Introduce EDKII_SERIAL_PORT_LIB_VENDOR_GUID
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, June 07, 2019 1:13 AM > To: Anthony PERARD; devel@edk2.groups.io > Cc: Ni, Ray; Julien Grall; Ard Biesheuvel; Leif Lindholm; Wang, Jian J; Wu, > Hao > A; Zeng, Star
Re: [EXT] Re: [edk2-devel] Printing git commit in build
Thanks Laszlo > -Original Message- > From: Laszlo Ersek > Sent: Thursday, June 6, 2019 1:55 PM > To: devel@edk2.groups.io; Udit Kumar > Subject: [EXT] Re: [edk2-devel] Printing git commit in build > > Caution: EXT Email > > On 06/06/19 07:38, Udit Kumar wrote: > > Dear Community, > >
Re: [edk2-devel] [PATCH 11/10] OvmfPkg/Csm/LegacyBiosDxe: Correct Legacy16GetTableAddress call for E820 data
Hello Ray, Do you have comment on this? Some inline comments below: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > David Woodhouse > Sent: Thursday, June 13, 2019 5:43 AM > To: Wu, Hao A > Cc: devel@edk2.groups.io; Ni, Ray; Justen, Jordan
[edk2-devel] [PATCH] Platform/Intel: Dynamic NUMBER_OF_PROCESSORS in build.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1913 To improve build performance by default the maximum processors should be used for building. To support this, NUMBER_OF_PROCESSORS in build.cfg has new definition: 0 = AUTO. Maximum of processors will be used. non-zero = limit or force
