Re: [edk2-devel] [Patch 0/2] Remove IntelSiliconPkg that has been moved to edk2-platform repo

2019-06-17 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Gao, Liming Sent: Monday, June 10, 2019 8:45 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [Patch 0/2] Remove IntelSiliconPkg that has been moved to edk2-platform repo BZ:

Re: [edk2-devel] [PATCH 3/6] MdeModulePkg/UefiBootManagerLib: Change performance code

2019-06-17 Thread Liming Gao
>-Original Message- >From: Bi, Dandan >Sent: Monday, June 17, 2019 12:47 PM >To: Wu, Hao A ; Gao, Zhichao >; devel@edk2.groups.io; Gao, Liming >; Ni, Ray >Cc: Bret Barkelew ; Wang, Jian J >; Zeng, Star >Subject: RE: [PATCH 3/6] MdeModulePkg/UefiBootManagerLib: Change >performance code

Re: [edk2-devel] [Patch 0/2] Remove IntelSiliconPkg that has been moved to edk2-platform repo

2019-06-17 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gao, Liming > Sent: Tuesday, June 18, 2019 1:21 PM > To: Ni, Ray ; Chaganty, Rangasai V > > Subject: RE: [edk2-devel] [Patch 0/2] Remove IntelSiliconPkg that has been > moved to edk2-platform repo > > Could you help review it? Now, I

Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions

2019-06-17 Thread Ni, Ray
Even the five people claims to be the maintainers of all TPM2 modules, I still think the maintainers.txt is not very human readable. I suggest a txt file as below: MdePkg .. F: MdePkg/Include/IndustryStandard/Tpm2* R: Marc-André Lureau R: Stefan Berger SecurityPkg .. F:

Re: [edk2-devel] [edk2-platforms] [patch] Platform/Intel/DebugFeaturePkg: Update PCD type

2019-06-17 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Dong, Eric >Sent: Tuesday, June 18, 2019 9:40 AM >To: devel@edk2.groups.io; Bi, Dandan >Cc: Gao, Liming >Subject: RE: [edk2-devel] [edk2-platforms] [patch] >Platform/Intel/DebugFeaturePkg: Update PCD type > >Reviewed-by: Eric Dong >

Re: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial change for PeiAllocatePool

2019-06-17 Thread Liming Gao
>-Original Message- >From: Wu, Hao A >Sent: Tuesday, June 18, 2019 1:15 PM >To: devel@edk2.groups.io; ler...@redhat.com; Gao, Zhichao >; Gao, Liming >Cc: Bret Barkelew ; Wang, Jian J >; Ni, Ray ; Zeng, Star >; Sean Brogan ; Michael >Turner >Subject: RE: [edk2-devel] [PATCH]

Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions

2019-06-17 Thread Ni, Ray
> + > +OvmfPkg (TPM2 modules) How about just say "TPM2 modules"? > +F: MdePkg/Include/IndustryStandard/Tpm2* > +F: SecurityPkg/*/Tpm2* > +M: Jordan Justen > +M: Laszlo Ersek > +M: Ard Biesheuvel > R: Marc-André Lureau > - (TPM2 modules) > R: Stefan Berger > - (TPM2 modules) > S:

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol

2019-06-17 Thread Wu, Hao A
> -Original Message- > From: Albecki, Mateusz > Sent: Monday, June 17, 2019 11:12 PM > To: devel@edk2.groups.io; Albecki, Mateusz > Cc: Wu, Hao A > Subject: RE: [edk2-devel] [PATCH 2/2] MdeModulePkg/SdMmcHcDxe: > Implement revision 3 of SdMmcOverrideProtocol > > Actually I would like to

Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system

2019-06-17 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Tuesday, June 18, 2019 10:24 AM > To: devel@edk2.groups.io; Ni, Ray; Javeed, Ashraf > Cc: Wang, Jian J > Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion

Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system

2019-06-17 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, > Ray > Sent: Monday, June 17, 2019 5:49 PM > To: Javeed, Ashraf; devel@edk2.groups.io > Cc: Wang, Jian J > Subject: Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for > every PPB

Re: [edk2-devel] [PATCH v4 1/2] MdePkg: Implement SCSI commands for Security Protocol In/Out

2019-06-17 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zurcher, Christopher J > Sent: Friday, June 14, 2019 5:39 AM > To: Gao, Liming; devel@edk2.groups.io > Cc: Yao, Jiewen; Wang, Jian J > Subject: Re: [edk2-devel] [PATCH v4 1/2] MdePkg: Implement

Re: [edk2-devel] [PATCH v4 2/2] MdeModulePkg/ScsiDiskDxe: Support Storage Security Command Protocol

2019-06-17 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zurcher, Christopher J > Sent: Thursday, June 13, 2019 10:05 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming > Subject: [edk2-devel] [PATCH v4 2/2]

[edk2-devel] [PATCH] BaseTools:Change build cache option name from --binary- to --cache-

2019-06-17 Thread Steven Shi
https://bugzilla.tianocore.org/show_bug.cgi?id=1896 Current build cache is enabled by the below two options: --binary-destination, which is to produce the cache. --binary-source, which is to consume the cache. Since current build cache does not only support to store the binary file (e.g.

Re: [edk2-devel] [edk2-platforms] [patch] Platform/Intel/DebugFeaturePkg: Update PCD type

2019-06-17 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Dandan Bi > Sent: Monday, June 17, 2019 1:45 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [edk2-devel] [edk2-platforms] [patch] >

Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol

2019-06-17 Thread rebecca
On 2019-06-17 16:14, rebe...@bluestop.org wrote: > I'm having problems using HTTPS boot in OVMF: Http->Request can't find > the EFI_TLS_SERVICE_BINDING_PROTOCOL. > It appears the OpenSSL update broke it. Revision b739678918 works, but f03859ea6c doesn't. -- Rebecca Cran

Re: [edk2-devel] [edk2-platforms] [patch v2 1/2] Platform/Intel: Add UserInterfaceFeaturePkg

2019-06-17 Thread Liming Gao
Ard: >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard >Biesheuvel >Sent: Tuesday, June 18, 2019 1:07 AM >To: Leif Lindholm >Cc: edk2-devel-groups-io ; Bi, Dandan >; Dong, Eric ; Gao, Liming >; Kinney, Michael D >Subject: Re: [edk2-devel]

[edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol

2019-06-17 Thread rebecca
I'm having problems using HTTPS boot in OVMF: Http->Request can't find the EFI_TLS_SERVICE_BINDING_PROTOCOL. I've built OVMF with NETWORK_TLS_ENABLE, so I don't know why it's not working. The debug log (with additional lines I've added) contains:   Station IP address is 192.168.0.88   

Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-06-17 Thread rebecca
On 2019-06-17 04:54, Fan, ZhijuX wrote: > +_ConfigSectionNotDefine = "Not support the config file format, need config > section" This might be better worded as: "Invalid config file format: need a config section" Or maybe: "Unsupported config file format: need a config section" --

Re: [edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-06-17 Thread rebecca
On 2019-06-17 04:54, Fan, ZhijuX wrote: > GenBiosId is a tool to generate the BIOS ID binary file which uses > the data from the configuration file. > https://bugzilla.tianocore.org/show_bug.cgi?id=1846 pylama (https://github.com/klen/pylama) reports the following issues:

Re: [edk2-devel] [edk2-platforms] [patch v2 1/2] Platform/Intel: Add UserInterfaceFeaturePkg

2019-06-17 Thread Ard Biesheuvel
On Mon, 17 Jun 2019 at 18:48, Leif Lindholm wrote: > > Hi Dandan, > > On Mon, Jun 17, 2019 at 02:51:45PM +0800, Dandan Bi wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1545 > > > > Add new package UserInterfaceFeaturePkg in Platform/Intel/ > > folder. It will keep UI related

Re: [edk2-devel] [edk2-platforms] [patch v2 1/2] Platform/Intel: Add UserInterfaceFeaturePkg

2019-06-17 Thread Leif Lindholm
Hi Dandan, On Mon, Jun 17, 2019 at 02:51:45PM +0800, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1545 > > Add new package UserInterfaceFeaturePkg in Platform/Intel/ > folder. It will keep UI related modules in this package. > > We plan add UserAuthentication modules

Re: [edk2-devel] [edk2-discuss] WriteSections64()

2019-06-17 Thread Russell Peterson
Hi, Ard. I compared this output to my previous edk2 build (uses gcc 7.3) and noticed that the .eh_frame sections seem to be new with the gcc 8.3 compiler. I added -fno-exceptions and -fno-unwind-tables to the aarch64 compiler options and everything builds. I'll need to run it and see if

Re: [edk2-devel] [PATCH 0/2] EmbeddedPkg,ArmPlatformPkg: fix VS2017 TimeBaseLib build errors

2019-06-17 Thread Leif Lindholm
On Thu, Jun 13, 2019 at 06:21:31PM +0200, Philippe Mathieu-Daudé wrote: > On 6/13/19 6:18 PM, Leif Lindholm wrote: > > TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs > > between architectures. This upsets VS2017 when building for 32-bit ARM > > (and likely would if

[edk2-devel] [PATCH V2] BaseTools/GenBiosId: Add a new tool GenBiosId

2019-06-17 Thread Fan, ZhijuX
GenBiosId is a tool to generate the BIOS ID binary file which uses the data from the configuration file. https://bugzilla.tianocore.org/show_bug.cgi?id=1846 v2:v1 is a tool of C type and v2 is python type. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Shenglei Zhang ---

Re: [edk2-devel] [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2019-06-17 Thread David Woodhouse
On Mon, 2014-05-12 at 20:21 +0400, Mike Maslenkin wrote: > > > > > > + Segment0 = 0; > > > > + Segment0Pages = 1; > > > > + Status = gBS->AllocatePages (AllocateAddress, EfiReservedMemoryType, > > > > + Segment0Pages, ); > > > > + if (EFI_ERROR (Status)) { > > > > +

Re: [edk2-devel] [PATCH] PciBusDxe: duplicate node insertion for every PPB device in the system

2019-06-17 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Javeed, Ashraf > Sent: Monday, May 27, 2019 6:24 PM > To: devel@edk2.groups.io > Cc: Javeed, Ashraf ; Wang, Jian J > ; Ni, Ray > Subject: [PATCH] PciBusDxe: duplicate node insertion for every PPB device in > the system > >

Re: [edk2-devel] [edk2-discuss] WriteSections64()

2019-06-17 Thread Ard Biesheuvel
On Sat, 15 Jun 2019 at 02:17, Russell Peterson wrote: > > Here is a sample of the gcc command line: > > "/x/sdk/sysroots/x86_64-pokysdk-linux/usr/bin/aarch64-poky-linux/aarch64-poky-linux-gcc" > -I/x/edk2/edk2/MlxPlatformPkg/Include -march=armv8-a+crc -g -fshort-wchar > -fno-builtin

Re: [edk2-devel] [PATCH 0/3] BaseTools: Move FCE & FMMT tools to edk2 repo

2019-06-17 Thread Bob Feng
Adding FMMT, FCE to BaseTools is fine for me. The patch is good to me. Reviewed-by: Bob Feng -Original Message- From: Zhang, Shenglei Sent: Tuesday, June 11, 2019 1:23 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH 0/3] BaseTools: Move FCE & FMMT tools to

Re: [edk2-devel] [PATCH v2 1/1] BaseTools:Introduce CopyFileOnChange() function to copy cache files

2019-06-17 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Shi, Steven Sent: Monday, June 17, 2019 4:44 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Rodriguez, Christian Subject: [PATCH v2 1/1] BaseTools:Introduce CopyFileOnChange() function to copy cache files

Re: [edk2-devel] [PATCH v3 1/1] BaseTools: Cannot store library cache of different arch together

2019-06-17 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Shi, Steven Sent: Monday, June 17, 2019 4:16 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Rodriguez, Christian Subject: [PATCH v3 1/1] BaseTools: Cannot store library cache of different arch together

[edk2-devel] [edk2-platforms] [patch v3 0/2] Add UserInterfaceFeaturePkg and UserAuthentication modules

2019-06-17 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1545 Patch 1 add a new package UserInterfaceFeaturePkg where put the UserAuthentication modules into. Package name follows the discussion in: https://edk2.groups.io/g/devel/message/42286 Patch 2 add password based user authentication modules.

[edk2-devel] [edk2-platforms] [patch v3 1/2] Platform/Intel: Add UserInterfaceFeaturePkg

2019-06-17 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1545 Add new package UserInterfaceFeaturePkg in Platform/Intel/ folder. It will keep UI related modules in this package. We plan add UserAuthentication modules in Platform/Intel. Firstly we add a new package UserInterfaceFeaturePkg where add

[edk2-devel] [PATCH v2 0/1] BaseTools:Introduce CopyFileOnChange() function to copy cache files

2019-06-17 Thread Steven Shi
V2: set shallow=False in filecmp.cmp() to compare the src and dsc files content use shutil.copy() replace the shutil.copyfile() to do the file copy, which is better to reserve the dsc file metadata V1: Initial fix Steven Shi (1): BaseTools:Introduce CopyFileOnChange() function to copy cache

[edk2-devel] [PATCH v3 0/1] BaseTools: Cannot store library cache of different arch together

2019-06-17 Thread Steven Shi
V3: WorkspaceAutoGen does not have the Arch attribute and current Meta-file of active platform already can make sure the __hash__ value is unique for WorkspaceAutoGen object. So, only add adds the arch string into the PlatformAutoGen and ModuleAutoGen __hash_ definitions. V2: Follow the Christian

[edk2-devel] [PATCH v3 1/1] BaseTools: Cannot store library cache of different arch together

2019-06-17 Thread Steven Shi
https://bugzilla.tianocore.org/show_bug.cgi?id=1895 Build cache cannot store cache for the same library modules in different arch together. E.g. Both the below IA32 and X64 arch BaseLib caches should exist after build Ovmf3264, but now only the one in X64 arch exist. The reason is the current

Re: [edk2-devel] [PATCH v2] SecurityPkg: Add missing instances for build only

2019-06-17 Thread Gao, Zhichao
Added: https://bugzilla.tianocore.org/show_bug.cgi?id=1919 Thanks, Zhichao > -Original Message- > From: Ni, Ray > Sent: Friday, June 14, 2019 4:50 PM > To: devel@edk2.groups.io; Yao, Jiewen ; Gao, > Zhichao > Cc: Bret Barkelew ; Zhang, Chao B > ; Wang, Jian J ; Gao, > Liming ; Sean

Re: [edk2-devel] [PATCH] EmulatorPkg/Win: support running multiple WinHost.exe

2019-06-17 Thread Ni, Ray
I withdraw this patch because multiple instances of WinHost.exe may change the same FV_RECOVERY.FD file for NV variable modification. Supporting multiple instances of WinHost.exe is not proper and may introduce potential issues. > -Original Message- > From: devel@edk2.groups.io On

[edk2-devel] [edk2-platforms] [patch v2 0/2] Add UserInterfaceFeaturePkg and UserAuthentication modules

2019-06-17 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1545 Patch 1 add a new package UserInterfaceFeaturePkg where put the UserAuthentication modules into. Package name follows the discussion in: https://edk2.groups.io/g/devel/message/42286 Patch 2 add password based user authentication modules.

[edk2-devel] [edk2-platforms] [patch v2 1/2] Platform/Intel: Add UserInterfaceFeaturePkg

2019-06-17 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1545 Add new package UserInterfaceFeaturePkg in Platform/Intel/ folder. It will keep UI related modules in this package. We plan add UserAuthentication modules in Platform/Intel. Firstly we add a new package UserInterfaceFeaturePkg where add