[edk2-devel] [PATCH v2 1/1] CryptoPkg/OpensslLib: disable autoload-config for OpenSSL
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1926 This problem was found by Rebecca Cran . REF: https://edk2.groups.io/g/devel/topic/32100684 OpenSSL will automatically load a system config file which configures default ssl options. In UEFI, It will cause TlsInitialize failed without
Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h.
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Sunday, June 16, 2019 7:42 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1883 Add
Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h.
Hi All, The decision to use FSP_TEMP_RAM_EXIT_PPI for both FSP and non-FSP builds is a platform level decision. There are several EDK2 based UEFI implementations that do not use FSP_TEMP_RAM_EXIT_PPI, OvmfPkg, Minnow, and Quark are some of many examples. There is nothing in the UEFI PI spec or
[edk2-devel] [PATCH v5 2/2] MdeModulePkg/BdsDxe: Use a pcd to control PlatformRecovery
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1678 Use the PcdPlatformRecoverySupport to control the function of platform recovery in BDS. First, set the variable's ("OsIndicationsSupported") EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY bit base on the pcd. It would affect the variable
[edk2-devel] [PATCH v5 0/2] Use a pcd to control Platform Recovery behavior
V1: Add a pcd PcdPlatformRecoverySupport to control the variable PlatformRecovery and the EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY bit of variable "OsIndicationsSupported". V2: While PcdPlatformRecoverySupport is FALSE, do not set a PlatformRecovery Variable. But remain boot from a
[edk2-devel] [PATCH v5 1/2] MdeModulePkg: Add a pcd to set the OS indications bit
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1678 Add a pcd PcdPlatformRecoverySupport to conditionally set an OS indications bit and set the 'PlatformRecovery' variable. This pcd would also control whether the BDS support platform recovery or not. Update the uni
Re: [edk2-devel] [PATCH] KabylakeOpenBoardPkg: Remove PeiMain for Dispatch mode.
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Friday, June 14, 2019 1:25 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH] KabylakeOpenBoardPkg: Remove PeiMain for Dispatch mode. REF:
Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h.
Hi Ray, Currently we prefer to duplicate header files so we do not have IntelFsp2Pkg dependency for non-FSP build. We will review for how to support FSP/non-FSP builds better. Thanks! Chasel > -Original Message- > From: Ni, Ray > Sent: Monday, June 17, 2019 11:27 AM > To:
Re: [edk2-devel] [PATCH v2] Platform/Intel: Dynamic NUMBER_OF_PROCESSORS in build.
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Thursday, June 13, 2019 1:32 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L ; Gao, Liming ; Feng, Bob C Subject: [edk2-devel] [PATCH v2]
Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h.
Hi Chasel, Please update the comments for the TempRamExit() function declaration to include all of the FSP specification allowed return values: EFI_SUCCESS - FSP execution environment was initialized successfully. EFI_INVALID_PARAMETER - Input parameters are invalid. EFI_UNSUPPORTED - The FSP
Re: [edk2-devel] [PATCH] UefiCpuPkg/MpService: GetProcessorInfo returns 6-level topology
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Wednesday, June 19, 2019 4:58 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Dong, Eric > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg/MpService: GetProcessorInfo > returns 6-level topology > > This change will be
Re: [edk2-devel] [PATCH V4 1/2] MdeModulePkg: Add a pcd to set the OS indications bit
I am so sorry for my mistake. There are still ECC errors in the change of uni file. The additional string should be STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_PROMPT STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_HELP I would update the patch. Thanks, Zhichao
[edk2-devel] [PATCH v4 3/3] SecurityPkg: add FvReportPei.inf in dsc for build validation
https://bugzilla.tianocore.org/show_bug.cgi?id=1617 Cc: Chao Zhang Cc: Jiewen Yao Cc: "Hernandez Beltran, Jorge" Cc: Harry Han Signed-off-by: Jian J Wang --- SecurityPkg/SecurityPkg.dsc | 5 + 1 file changed, 5 insertions(+) diff --git a/SecurityPkg/SecurityPkg.dsc
[edk2-devel] [PATCH v4 1/3] SecurityPkg: add definitions for OBB verification
> v4: change FV_HASH_FLAG_BOOT_MODE to align with > HASHED_FV_FLAG_SKIP_BOOT_MODE > v3: update per Jiewen's comments > - remove HASHED_FV_MAX_NUMBER > - update _EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI to > be more flexible > - update HASHED_FV_INFO to use UINT64 for Base
[edk2-devel] [PATCH v4 0/3] Common OBB verification feature
>V4: change FV_HASH_FLAG_BOOT_MODE definition >V3: update per Jiewen's comments >V2: fix parameter description error found by ECC https://bugzilla.tianocore.org/show_bug.cgi?id=1617 Cc: Chao Zhang Cc: Jiewen Yao Cc: "Hernandez Beltran, Jorge" Cc: Harry Han Jian J Wang (3): SecurityPkg:
[edk2-devel] [PATCH v4 2/3] SecurityPkg/FvReportPei: implement a common FV verifier and reporter
>v3: > - shrink mHashAlgInfo and add FindHashAlgInfo() to find matched algorithm > - add ASSERT for illegal use cases > - add DEBUG print for skipped FV > - update code to use new definition of HASHED_FV_INFO and >_EDKII_PEI_FIRMWARE_VOLUME_INFO_STORED_HASH_FV_PPI > - some small code
[edk2-devel] [PATCH] SecurityPkg/DxeDeferImageLoadLib: Remove DxeDeferImageLoadLib
The library DxeDeferImageLoadLib supports UID feature and it is conflicted with the driver SecurityStubDxe (Defer3rdPartyImageLoad.c). And the UID feature is dropped. So it should be removed from SecurityPkg. https://bugzilla.tianocore.org/show_bug.cgi?id=1919 Cc: Chao Zhang Cc: Jiewen Yao Cc:
Re: [edk2-devel] [edk2-platforms] [patch v3 0/2] Add UserInterfaceFeaturePkg and UserAuthentication modules
Hi Dandan, Please update the copyright date to 2019 before you check in the code, others are good to me. Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: Bi, Dandan > Sent: Monday, June 17, 2019 4:49 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming >
Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: disable autoload-config for OpenSSL
Agree with Laszlo's comment. With it's addressed, Reviewed-by: Jian J Wang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Thursday, June 20, 2019 6:20 AM > To: devel@edk2.groups.io; Lu, XiaoyuX ; Rebecca Cran > > Cc:
Re: [edk2-devel][Patch v2 3/7] MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM.
> -Original Message- > From: Ni, Ray > Sent: Wednesday, June 19, 2019 5:00 PM > To: devel@edk2.groups.io; Xu, Wei6; Wu, Hao A > Cc: Wang, Jian J; Zhang, Chao B > Subject: RE: [edk2-devel][Patch v2 3/7] MdeModulePkg: Add > CapsuleOnDiskLoadPei PEIM. > > > -Original Message- > >
Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py
Reviewed-by: Jian J Wang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Xiaoyu Lu > Sent: Wednesday, June 19, 2019 3:19 PM > To: devel@edk2.groups.io > Cc: Lu, XiaoyuX ; Laszlo Ersek ; > Wang, Jian J ; Ye, Ting > Subject: [edk2-devel]
Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Fix CR/LF issue
Reviewed-by: Jian J Wang > -Original Message- > From: Lu, XiaoyuX > Sent: Wednesday, June 19, 2019 3:21 PM > To: devel@edk2.groups.io > Cc: Lu, XiaoyuX ; Wang, Jian J > Subject: [PATCH 1/1] CryptoPkg/OpensslLib: Fix CR/LF issue > > Re-run process_files.py to generate
[edk2-devel] [PATCH V3] BaseTools:Add DetectNotUsedItem.py to Edk2\BaseTools\Scripts
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1850 This script is used to Detect unreferenced PCD and GUID/Protocols/PPIs. The input parameters are Dec file and package directory. This script can be run in
[edk2-devel] [PATCH V3] BaseTools:add UniTool.py to Edk2\BaseTools\Scripts
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 UniTool is one python script to generate UQI (Universal Question Identifier) unicode string for HII question PROMPT string. UQI string can be used to identify each HII question. The scripts function will sync up UQI definitions with uni files
Re: [edk2-devel] [PATCH 0/2] BaseTools: add script to set up git environment
On 06/15/19 10:47, Philippe Mathieu-Daudé wrote: > On 6/10/19 1:54 PM, Leif Lindholm wrote: >> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers >> is a great resource, but it's a lot of manual steps to go through for >> each
Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py
On 06/19/19 09:19, Xiaoyu Lu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1881 > > Commit(0a1b13fd4d2210e2c3) fix VS2017 build failure > remove useless file in OpensslLib[Crypto].inf, > but we use process_files.py to generate files. > So exclude err_all.c file in process_files.py
Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: disable autoload-config for OpenSSL
Hi, On 06/19/19 09:22, Xiaoyu Lu wrote: > This problem was found by Rebecca Cran . > REF: https://edk2.groups.io/g/devel/topic/32100684 > > OpenSSL will automatically load a system config file which configures > default ssl options. In UEFI, It will cause TlsInitialize failed > without
Re: [edk2-devel] [edk2] [PATCH] OvmfPkg: prevent 64-bit MMIO BAR degradation if there is no CSM
> the driver is thoroughly commented. See especially the > DriverInitialize() function. Can you determine which one(s) of those > statements doesn't / don't hold any longer? > > Or maybe IncompatiblePciDeviceSupportDxe works as before, but commit > 065ae7d717f9 ("MdeModulePkg/PciBusDxe: make
Re: [edk2-devel] [edk2] [PATCH] OvmfPkg: prevent 64-bit MMIO BAR degradation if there is no CSM
Hi David, On 06/19/19 14:50, David Woodhouse wrote: > On Thu, 2016-05-19 at 00:12 +0200, Laszlo Ersek wrote: >> According to edk2 commit >> >> "MdeModulePkg/PciBus: do not improperly degrade resource" >> >> and to the EFI_INCOMPATIBLE_PCI_DEVICE_SUPPORT_PROTOCOL definition in the >> Platform
Re: [edk2-devel] [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)
Hi David, On 06/17/19 12:52, David Woodhouse wrote: > On Mon, 2014-05-12 at 20:21 +0400, Mike Maslenkin wrote: >>> > + Segment0 = 0; > + Segment0Pages = 1; > + Status = gBS->AllocatePages (AllocateAddress, EfiReservedMemoryType, > + Segment0Pages, ); >
[edk2-devel] [PATCH] EmulatorPkg: update HOST_TOOLS to xcode5
The last compiler flag change was for Xcode 5.0, not Xcode 3.2. As such the HOST_TOOLS should be set to XCODE5. Also, fix a small typo. This fixes bug 447: https://bugzilla.tianocore.org/show_bug.cgi?id=447 Signed-off-by: Stephano Cetola --- EmulatorPkg/build.sh | 4 ++-- 1 file changed, 2
Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol
On 2019-06-19 02:07, Lu, XiaoyuX wrote: > > Thanks for your information. I checked the NOOPT OVMF in linux environment, > it failed too. > I think compiler optimization hides this problem. > By default, OpenSSL will auto load config file. But UEFI don't use it. > And OpenSSL commit (25eb9299)
Re: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: disable autoload-config for OpenSSL
On 2019-06-19 01:22, Xiaoyu Lu wrote: > This problem was found by Rebecca Cran . > REF: https://edk2.groups.io/g/devel/topic/32100684 > > OpenSSL will automatically load a system config file which configures > default ssl options. In UEFI, It will cause TlsInitialize failed > without
Re: [edk2-devel] [edk2] [PATCH] OvmfPkg: prevent 64-bit MMIO BAR degradation if there is no CSM
On Thu, 2016-05-19 at 00:12 +0200, Laszlo Ersek wrote: > According to edk2 commit > > "MdeModulePkg/PciBus: do not improperly degrade resource" > > and to the EFI_INCOMPATIBLE_PCI_DEVICE_SUPPORT_PROTOCOL definition in the > Platform Init 1.4a specification, a platform can provide such a
[edk2-devel] [PATCH 1/2] LegacyBios: set NumberBbsEntries to the size of BbsTable
Signed-off-by: David Woodhouse --- OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c index 05e3ffd2bb..69abd06c40 100644 ---
[edk2-devel] [PATCH 2/2] LegacyBbs: Add boot entries for VirtIO and NVME devices
Signed-off-by: David Woodhouse --- They still end up all just called 'Harddisk', but I absolutely do not want to reproduce all the special cases in BmBootDescription.c. I'm not even sure I want to export that and use it; it's horrid. Why don't the disk objects themselves have a protocol which
[edk2-devel] [PATCH v3 2/5] SecurityPkg: introduce the SM3 digest algorithm
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. This patch add
[edk2-devel] [PATCH v3 2/5] SecurityPkg: introduce the SM3 digest algorithm
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has dependency on the openssl_1_1_1b integration into edk2. This patch add
[edk2-devel] reg: Adding Entry for Initiator Name in the ISCSI Config Structure
Hello : Right now the structure _ISCSI_ATTEMPT_CONFIG_NVDATA does not have the entry for Initiator Name. It uses the NV Variable I_NAME for maintain the Initiator Name since the setup supports single initiator name for all the attempts getting created. When we have the attempts from the
Re: [edk2-devel] reg: Multiple Host Name Certificate
Can you please help to confirm the behavior From: Sivaraman Nainar Sent: Friday, June 7, 2019 2:48 PM To: devel@edk2.groups.io Subject: reg: Multiple Host Name Certificate Hello: Can someone help to confirm if EDK2 supports multiple Host Name support. We need to have an environment where the
Re: [edk2-devel] [PATCH v4 edk2-platforms 1/1] Silicon/DesignWare/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver
On Wed, 19 Jun 2019 at 12:09, Ooi, Tzy Way wrote: > > Hi Bieshuevel, > > In the DmaMap function, there is one line where my code look like this: > > "Status = DmaMap (MapOperationBusMasterCommonBuffer, > Snp->MacDriver.TxdescRing[0], , >MacDriver.TxdescRingMap[0], > >MappingTxdesc);" > > You
Re: [edk2-devel] [PATCH v4 edk2-platforms 1/1] Silicon/DesignWare/Driver: DwEmacSnpDxe: Add DesignWare EMAC driver
Hi Bieshuevel, In the DmaMap function, there is one line where my code look like this: "Status = DmaMap (MapOperationBusMasterCommonBuffer, Snp->MacDriver.TxdescRing[0], , >MacDriver.TxdescRingMap[0], >MappingTxdesc);" You asked me why the [0] and how many descriptor I am mapping. In my code,
Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg
On Wed, Jun 19, 2019 at 05:09:40AM +, Wu, Hao A wrote: > Hello all, > > As suggested by Ray and Leif, modules (with wildcard) in MdeModulePkg are > classified to a list of features. > > Please note that: > * The below list is a draft at this moment, please help to provide >
Re: [edk2-devel][Patch v2 3/7] MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM.
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Xu, > Wei6 > Sent: Wednesday, June 19, 2019 4:41 PM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Wang, Jian J ; Zhang, Chao B > > Subject: Re: [edk2-devel][Patch v2 3/7] MdeModulePkg: Add > CapsuleOnDiskLoadPei PEIM. > > > >
[edk2-devel] [PATCH] UefiCpuPkg/MpService: GetProcessorInfo returns 6-level topology
Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ray Ni Cc: Eric Dong --- MdePkg/Include/Protocol/MpService.h | 50 +--- UefiCpuPkg/Library/MpInitLib/MpLib.c | 19 +++ 2 files changed, 64 insertions(+), 5 deletions(-) diff --git
Re: [edk2-devel][Patch v2 3/7] MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM.
> > + ASSERT_EFI_ERROR (Status); > > + > > + FileNameSize = PcdGetSize (PcdCoDRelocationFileName); Status = > > + PcdSetPtrS (PcdRecoveryFileName, , (VOID *) > > PcdGetPtr(PcdCoDRelocationFileName)); > > > Buffer for 'PcdRecoveryFileName' may not be big enough to hold the content > in
Re: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.
Thank you very much. Of course, I will follow up all the other comments. BR, Wei > -Original Message- > From: Wu, Hao A > Sent: Wednesday, June 19, 2019 4:20 PM > To: devel@edk2.groups.io; Wu, Hao A ; Xu, Wei6 > > Cc: Wang, Jian J ; Zhang, Chao B > > Subject: RE: [edk2-devel][Patch v2
Re: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.
Forgot to mention, please help to handle other comments in the first reply to the patch. Thanks in advance. Best Regards, Hao Wu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Wednesday, June 19, 2019 4:17 PM > To: Xu,
Re: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.
> > No, that's how it is designed. > PcdCodRelocationDevPath is used by platform to specify a device to store > temp Cod relocation file. > If this PCD is not available, it means that platform doesn't have a > requirement > to store the file to a specific place. > Then save the file to the
Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't find TLS Service Binding Protocol
Hi bcran, > -Original Message- > From: Rebecca Cran [mailto:rebe...@bluestop.org] > Sent: Wednesday, June 19, 2019 5:27 AM > To: Lu, XiaoyuX ; devel@edk2.groups.io > Cc: Wang, Jian J ; Laszlo Ersek > Subject: Re: [edk2-devel] Problems using HTTPS boot: Http->Request can't > find TLS
Re: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.
Thanks a lot for the comments. Please find my answer bellow. > -Original Message- > From: Wu, Hao A > Sent: Wednesday, June 12, 2019 3:50 PM > To: devel@edk2.groups.io; Xu, Wei6 > Cc: Wang, Jian J ; Zhang, Chao B > > Subject: RE: [edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On
[edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: disable autoload-config for OpenSSL
This problem was found by Rebecca Cran . REF: https://edk2.groups.io/g/devel/topic/32100684 OpenSSL will automatically load a system config file which configures default ssl options. In UEFI, It will cause TlsInitialize failed without OPENSSL_INIT_NO_LOAD_CONFIG flag. we don't use this feature,
[edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Fix CR/LF issue
Re-run process_files.py to generate OpensslLib[Crypto].inf. CryptoPkg/Library/Include/openssl/opensslconf.h is coped from OpenSSL, So keep the CR/LF style like OpenSSL source file. Cc: Jian J Wang Signed-off-by: Xiaoyu Lu --- CryptoPkg/Library/Include/openssl/opensslconf.h | 80
[edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1881 Commit(0a1b13fd4d2210e2c3) fix VS2017 build failure remove useless file in OpensslLib[Crypto].inf, but we use process_files.py to generate files. So exclude err_all.c file in process_files.py Cc: Jian J Wang Cc: Ting Ye Signed-off-by:
