Patch looks good.
Reviewed-by: Bob Feng
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42973): https://edk2.groups.io/g/devel/message/42973
Mute This Topic: https://groups.io/mt/32192703/21656
Group Owner: devel+ow...@edk2.groups.io
On Mon, Jun 24, 2019 at 09:13:36PM +0200, Laszlo Ersek wrote:
> Port the [LibraryClasses], [PcdsFixedAtBuild] and [Components] settings
> that are related to NETWORK_TLS_ENABLE from OvmfPkg to ArmVirtPkg.
> ArmVirtXen is not modified because it doesn't include the edk2 network
> stack.
>
> (This
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1891
While the convertion Base64 ascii string is null string (the
string only contain white space would be regard as null string),
there would be no decodeable data. Set *DestinationSize to zero
and return RETURN_SUCCESS. But it is not mention
Fix various typos in EmbeddedPkg.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Coeur
---
.../AndroidFastboot/AndroidBootImg.c | 2 +-
.../AndroidFastboot/AndroidFastbootApp.c | 2 +-
.../Drivers/ConsolePrefDxe/ConsolePrefDxe.c | 2 +-
>From 0fdb05b34e5bfdcbd92d21cdf446eec06cf9035f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Antoine=20C=C5=93ur?=
Date: Wed, 6 Feb 2019 23:40:38 +0800
Subject: [PATCH] ArmPlatformPkg: Fix various typos
Fix various typos in ArmPlatformPkg.
Contributed-under: TianoCore Contribution Agreement 1.1
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1921
Add TOOLS_DEF.ARCH file to all workspace meta files list.
TOOLS_DEF.ARCH include the evaluated Tool definition information
which is filtered by current tool_chain.
With this change, when the environment variable which
is used in ToolDef.txt
Fix various typos in ArmPkg.
Same as https://github.com/tianocore/edk2/pull/143/files
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42964): https://edk2.groups.io/g/devel/message/42964
Mute This Topic:
Reviewed-by: Jian J Wang
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, June 20, 2019 9:31 AM
> To: devel@edk2.groups.io
> Cc: Zhang, Chao B ; Yao, Jiewen
> ; Wang, Jian J
> Subject: [PATCH] SecurityPkg/DxeDeferImageLoadLib: Remove
> DxeDeferImageLoadLib
>
> The library
Yes. It works! I will update patch.
Thanks!
Chasel
> -Original Message-
> From: Zeng, Star
> Sent: Friday, June 28, 2019 10:28 AM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Ma, Maurice ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: RE: [edk2-devel] [PATCH] IntelFsp2Pkg: FSP
Dandan:
Don't need to add version info in the commit log. And, please also remove
pushd %WORKSPACE% & popd. They are not used after nmake is removed. With those
changes, Reviewed-by: Liming Gao
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io
V2: Remove nmake -f %BASE_TOOLS_PATH%\Makefile, since it
has been covered by edksetup.bat Rebuild option.
Since Nt32Pkg has been removed from edk2 repo, and
we will also remove the --nt32 flag in edksetup.bat.
So here update platform to pass build.
Cc: Shifei A Lu
Cc: Xiaohu Zhou
Cc: Isaac W
It is ok to directly use below code without python version check?
+for loop in range(int(unit)):
+bytearray.append("0x%02X" % (value & 0xFF))
+value = value >> 8
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io
If use Rebuild option, below nmake is not required.
@if defined PYTHON_HOME (
nmake -f %BASE_TOOLS_PATH%\Makefile
)
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Dandan Bi
>Sent: Friday, June 28, 2019 10:03 AM
>To: devel@edk2.groups.io
Since Nt32Pkg has been removed from edk2 repo, and
we will also remove the --nt32 flag in edksetup.bat.
So here update platform to pass build.
Cc: Shifei A Lu
Cc: Xiaohu Zhou
Cc: Isaac W Oram
Signed-off-by: Dandan Bi
---
.../PurleyOpenBoardPkg/BoardMtOlympus/GitEdk2MinMtOlympus.bat | 2 +-
*Reminder:* TianoCore Design Meeting - APAC/NAMO
*When:* Thursday, 27 June 2019, 6:30pm to 7:30pm, (GMT-07:00) America/Los
Angeles
*Where:* https://zoom.us/j/969264410
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=458029 )
*Organizer:* Stephano Cetola stephano.cet...@intel.com
Hi Liming and Bob,
Thanks for the review. So we reach the agreement that remove the --nt32 flag,
right? If so, I will address Liming's comments and then push these two patches.
Thanks,
Dandan
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, June 27, 2019 11:17 PM
> To: Feng,
HI Hao:
I think the patch is to complete the security check both in info and code
logic to ValidateCapsuleNameCapsuleIntegrity .
It is OK to keep it in one patch.
From: Wu, Hao A
Sent: Friday, June 28, 2019 8:54 AM
To: Xu, Wei6 ; devel@edk2.groups.io
Cc: Wang, Jian J ; Zhang, Chao B
> -Original Message-
> From: Sumit Garg [mailto:sumit.g...@linaro.org]
> Sent: Thursday, June 27, 2019 9:39 PM
> To: Ard Biesheuvel
> Cc: edk2-devel-groups-io; Wu, Hao A; Marcin Wojtas; Albecki, Mateusz
> Subject: Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/SdMmcHcDxe:
> Implement
> -Original Message-
> From: Xu, Wei6
> Sent: Friday, June 28, 2019 12:26 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J; Wu, Hao A; Zhang, Chao B
> Subject: [edk2-devel][Patch] MdeModulePkg/DxeCapsuleLibFmp: Add
> missing NULL pointer check.
>
> Add missing NULL pointer check for
*Reminder:* TianoCore Bug Triage - APAC / NAMO
*When:* Thursday, 27 June 2019, 5:00pm to 5:30pm, (GMT-07:00) America/Los
Angeles
*Where:* https://zoom.us/j/251103409
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=458032 )
*Organizer:* Stephano Cetola stephano.cet...@intel.com
Reviewed-by: Chao Zhang
-Original Message-
From: Xu, Wei6
Sent: Friday, June 28, 2019 12:26 AM
To: devel@edk2.groups.io
Cc: Wang, Jian J ; Wu, Hao A ;
Zhang, Chao B
Subject: [edk2-devel][Patch] MdeModulePkg/DxeCapsuleLibFmp: Add missing NULL
pointer check.
Add missing NULL pointer
On Thu, 2019-06-27 at 21:01 +0200, Laszlo Ersek wrote:
>
> To clarify -- this is by no means to say that *SeaBIOS* is a relic. I
> absolutely don't imply that. Users should use the firmware they need,
> especially in the virtual world, where choosing is really easy.
Choosing is easy if you're
On 06/27/19 20:43, Laszlo Ersek wrote:
> On 06/27/19 18:36, Alexander Graf wrote:
>> That way we could have CSM enabled OVMF for everyone ;)
>
> Well, as long as we're discussing "everyone": we should forget about the
> CSM altogether, in the long term. The CSM is a concession towards OSes
>
On 06/27/19 13:31, co...@gmx.fr wrote:
> About a year ago, I changed 8000+ lines of text in edk2 to fix various typos.
> But I didn't split it all and I didn't create a hundred of patches by email
> to get it all applied (except for a few folders of them).
>
> As it's still a lot of work to
On 06/27/19 18:36, Alexander Graf wrote:
> Hi David and Laszlo,
>
> (with broken threading because gmane still mirrors the old ML ...)
>
>> Mostly, this is only necessary for devices that the CSM might have
>> native support for, such as VirtIO and NVMe; PciBusDxe will already
>> degrade devices
Hi David and Laszlo,
(with broken threading because gmane still mirrors the old ML ...)
Mostly, this is only necessary for devices that the CSM might have
native support for, such as VirtIO and NVMe; PciBusDxe will already
degrade devices to 32-bit if they have an OpROM.
However, there
Add missing NULL pointer check for CapsuleNameBufStart.
Also add comments to notice that capsule name integrity check assumes
the capsule has been validated by IsValidCapsuleHeader().
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Chao B Zhang
Signed-off-by: Wei6 Xu
---
About a year ago, I changed 8000+ lines of text in edk2 to fix various typos.
But I didn't split it all and I didn't create a hundred of patches by email to
get it all applied (except for a few folders of them).
As it's still a lot of work to rebase it, split it, patch it and get it
reviewed, I
Yes. Those script needs to be updated together.
> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, June 27, 2019 11:14 PM
> To: Gao, Liming ; Bi, Dandan ;
> devel@edk2.groups.io
> Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch files
>
> OK. I think it may break
OK. I think it may break some pre-build script if the pre-build script have
"edksetup --nt32"...
-Original Message-
From: Gao, Liming
Sent: Thursday, June 27, 2019 10:48 PM
To: Feng, Bob C ; Bi, Dandan ;
devel@edk2.groups.io
Subject: RE: [patch 0/2] Edk2Setup: Enahnce edk2setup batch
Bob:
--nt32 option is added for Nt32Pkg. Now, Nt32Pkg has been removed. So, I
think it is fine to remove --nt32 option.
> -Original Message-
> From: Feng, Bob C
> Sent: Thursday, June 27, 2019 7:56 PM
> To: Bi, Dandan ; devel@edk2.groups.io
> Cc: Gao, Liming
> Subject: RE: [patch
On Thu, 27 Jun 2019 at 13:40, Ard Biesheuvel wrote:
>
> (+ Sumit)
>
> On Thu, 27 Jun 2019 at 08:29, Wu, Hao A wrote:
> >
> > > -Original Message-
> > > From: Marcin Wojtas [mailto:m...@semihalf.com]
> > > Sent: Thursday, June 27, 2019 2:25 PM
> > > To: Albecki, Mateusz
> > > Cc:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42936): https://edk2.groups.io/g/devel/message/42936
Mute This Topic: https://groups.io/mt/32230896/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42934): https://edk2.groups.io/g/devel/message/42934
Mute This Topic: https://groups.io/mt/32230898/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed-by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42935): https://edk2.groups.io/g/devel/message/42935
Mute This Topic: https://groups.io/mt/32230897/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Add DISABLE_NEW_DEPRECATED_INTERFACES macro to the Arm platform
build flags to disable the use of deprecated APIs.
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Disable the use of deprecated APIs for Arm Platforms. [SAMI]
Platform/ARM/VExpressPkg/ArmVExpress.dsc.inc | 5 -
edk2 implements the DISABLE_NEW_DEPRECATED_INTERFACES macro that prevents the
usage of unsafe/deprecated APIs/macros by reporting errors at build time.
This patch series:
- defines DISABLE_NEW_DEPRECATED_INTERFACES macro as part of the build
options for Arm platforms so that the
Replaced the use of unsafe/deprecated macros with alternate safe
options.
Signed-off-by: Sami Mujawar
---
Notes:
v1:
- Replace unsafe/deprecated macros with alternate safe options. [SAMI]
Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 12 +++-
1 file changed, 7
+Jordan
On 06/27/19 07:50, Hao A Wu wrote:
> The commit will remove the deprecated edk2 SVN mirror at:
> https://svn.code.sf.net/p/edk2/code/trunk/edk2
>
> After this commit, the above minnor will not be synced with the changes
(1) s/minnor/mirror/
> made in the GitHub upstream.
>
> Cc:
The patches look good.
I think removing --nt32 option is incompatible change. What about keep the
--nt32 ?
For the Patch 2 setup for different VS tool chains.
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: Bi, Dandan
Sent: Sunday, June 23, 2019 9:59 PM
To:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1922
The Type4 Voltage field may be various.
So this patch adds it into the blacklist.
Signed-off-by: Star Zeng
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Cc: Donald Kuo
Cc: Chasel Chiu
---
Dandan:
One minor comment. Help message shows two ForceRebuild options. Please remove
one. And, this change retire --nt32 option. Please update wiki page on edksetup
usage in
https://github.com/tianocore/tianocore.github.io/wiki/Getting-Started-Writing-Simple-Application.
With those change,
On Thu, Jun 27, 2019 at 01:50:43PM +0800, Hao A Wu wrote:
> The patch proposes to:
>
> A. Remove the information on the SourceForge SVN mirror repository from
>the Maintainers.txt file.
> B. Stop the sync of the SourceForge SVN mirror from the upstream Github
>Git repository. (At this
(+ Sumit)
On Thu, 27 Jun 2019 at 08:29, Wu, Hao A wrote:
>
> > -Original Message-
> > From: Marcin Wojtas [mailto:m...@semihalf.com]
> > Sent: Thursday, June 27, 2019 2:25 PM
> > To: Albecki, Mateusz
> > Cc: edk2-devel-groups-io; Wu, Hao A
> > Subject: Re: [edk2-devel] [PATCH v4 0/2]
So, this is just indentation update. There is no functionality impact. What
test have you done?
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> rebe...@bluestop.org
> Sent: Thursday, June 27, 2019 12:55 AM
> To:
> -Original Message-
> From: Marcin Wojtas [mailto:m...@semihalf.com]
> Sent: Thursday, June 27, 2019 2:25 PM
> To: Albecki, Mateusz
> Cc: edk2-devel-groups-io; Wu, Hao A
> Subject: Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/SdMmcHcDxe:
> Implement revision 3 of SdMmcOverrideProtocol
>
Hi Mateusz,
Can you please push those patches somewhere (github?) so that I can
easily do a quick check for regression?
Thanks,
Marcin
śr., 26 cze 2019 o 15:10 Albecki, Mateusz
napisał(a):
>
> To allow platform greater control over the bus settings for SD card and eMMC
> card we have added a
Reviewed-By: Zailiang Sun
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42919): https://edk2.groups.io/g/devel/message/42919
Mute This Topic: https://groups.io/mt/32201140/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
48 matches
Mail list logo
