Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices

2019-07-07 Thread Wu, Hao A
Hello Ravi Kumar, May I know the specific issue you met when 2 ExtScsiPassThru instances are provided for the device? For some of your previous questions: · “Any background why EFI_EXT_SCSI_PASS_THRU_PROTOCOL needed 2 instances ?” The logical protocol instance is used to produce media

Re: [edk2-devel] [PATCH 0/3] BaseTools: Change FMMT,BfmLib and FCE script type in PosixLike

2019-07-07 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Zhang, Shenglei Sent: Friday, July 5, 2019 10:40 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH 0/3] BaseTools: Change FMMT,BfmLib and FCE script type in PosixLike The existing scripts are PC type, which cause

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module type.

2019-07-07 Thread Yao, Jiewen
Right. So far we just duplicate what USER_DEFINED does. With more and more example, we will see if and how we enhance that. But it is good enough now. Thank you Yao Jiewen > -Original Message- > From: Gao, Liming > Sent: Monday, July 8, 2019 9:15 AM > To: Yao, Jiewen ; Lu, XiaoyuX > ;

Re: [edk2-devel] [Patch 1/1] BaseTools: Fixed the issue of the CFlag for compile PcdValueInit.c

2019-07-07 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Feng, Bob C > Sent: Monday, July 1, 2019 5:49 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [Patch 1/1] BaseTools: Fixed the issue of the CFlag for compile > PcdValueInit.c > > This issue happens when

Re: [edk2-devel] [PATCH 0/3] BaseTools: Change FMMT,BfmLib and FCE script type in PosixLike

2019-07-07 Thread Liming Gao
Shenglei: One minor comments, please update title BaseTools/FMMT to BaseTools. > > BaseTools/FMMT: Change FMMT script type in PosixLike > > BaseTools/FMMT: Change BfmLib script type in PosixLike > > BaseTools/FMMT: Change FCE script type in PosixLike Thanks Liming > -Original

Re: [edk2-devel] [PATCH] FmpDevicePkg: Fix various typos

2019-07-07 Thread Liming Gao
Please add Signed-off-by: your name. The change is good to me. Reviewed-by: Liming Gao >-Original Message- >From: Antoine Cœur [mailto:co...@gmx.fr] >Sent: Friday, July 05, 2019 10:18 PM >To: devel@edk2.groups.io; Gao, Liming ; Kinney, >Michael D >Cc: Antoine Cœur >Subject: [PATCH]

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module type.

2019-07-07 Thread Liming Gao
I see the change in build_rule.txt. I understand its output file is decided by this rule. Right? [Static-Library-File.USER_DEFINED, Static-Library-File.HOST_APPLICATION] *.lib $(MAKE_FILE) $(DEBUG_DIR)(+)$(MODULE_NAME) "$(DLINK)"

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module type.

2019-07-07 Thread Yao, Jiewen
Currently, it is xxx.efi. Thank you Yao Jiewen > -Original Message- > From: Gao, Liming > Sent: Monday, July 8, 2019 8:43 AM > To: Lu, XiaoyuX ; devel@edk2.groups.io > Cc: Feng, Bob C ; Yao, Jiewen > > Subject: RE: [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module > type. > >

Re: [edk2-devel] [PATCH V2] BaseTools:Add the Judgment Method of "--exclude"

2019-07-07 Thread Liming Gao
Zhiju: Thanks for your fix. Can you list your test case? Thanks Liming >-Original Message- >From: Fan, ZhijuX >Sent: Friday, June 28, 2019 3:01 PM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [PATCH V2] BaseTools:Add the Judgment Method of "--exclude" > >BZ:

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module type.

2019-07-07 Thread Liming Gao
Xiaoyu: I want to confirm what output for HOST_APPLICATION module will be used. Xxx.dll or xxx.efi? Thanks Liming >-Original Message- >From: Lu, XiaoyuX >Sent: Monday, July 01, 2019 6:13 PM >To: devel@edk2.groups.io >Cc: Lu, XiaoyuX ; Feng, Bob C ; >Gao, Liming ; Yao, Jiewen

Re: [edk2-devel] [edk2-InfSpecification PATCH v2] Document: Add new MODULE_TYPE HOST_APPLICATION

2019-07-07 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Lu, XiaoyuX >Sent: Friday, July 05, 2019 3:43 PM >To: devel@edk2.groups.io >Cc: Lu, XiaoyuX ; Gao, Liming ; >Yao, Jiewen >Subject: [edk2-InfSpecification PATCH v2] Document: Add new >MODULE_TYPE HOST_APPLICATION > >BZ:

Re: [edk2-devel] [edk2-BuildSpecification PATCH] Document: Support HOST_APPLICATION ModuleType

2019-07-07 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Xiaoyu Lu >Sent: Wednesday, July 03, 2019 4:24 PM >To: devel@edk2.groups.io >Cc: Lu, XiaoyuX ; Gao, Liming ; >Yao, Jiewen >Subject: [edk2-devel] [edk2-BuildSpecification

Re: [edk2-devel] [PATCH 0/3] BaseTools: Change FMMT,BfmLib and FCE script type in PosixLike

2019-07-07 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Zhang, Shenglei >Sent: Friday, July 05, 2019 10:40 PM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Gao, Liming >Subject: [PATCH 0/3] BaseTools: Change FMMT,BfmLib and FCE script type in >PosixLike > >The existing scripts are PC type,

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix various typos

2019-07-07 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks!! > -Original Message- > From: Antoine Cœur [mailto:co...@gmx.fr] > Sent: Friday, July 5, 2019 10:17 PM > To: devel@edk2.groups.io; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > Chasel > Cc: Antoine Cœur > Subject: [PATCH] IntelFsp2Pkg: Fix various

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix various typos

2019-07-07 Thread Zeng, Star
Reviewed-by: Star Zeng > -Original Message- > From: Antoine Cœur [mailto:co...@gmx.fr] > Sent: Friday, July 5, 2019 10:17 PM > To: devel@edk2.groups.io; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > Chasel > Cc: Antoine Cœur > Subject: [PATCH] IntelFsp2Pkg: Fix various typos > > Fix

Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices

2019-07-07 Thread Ravi Kumar Siadri
Hi All, *Can somebody, comment on this.?* Have anyone tried supporting *ExtScsiPassThru *for both Logical and Physical devices ?? *To avoid 2 instances and creation of 2 device paths here, my proposal is* *1. To filter the Logical and Physical devices, we can add a parameter in