Re: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies

2019-07-09 Thread Michael D Kinney
Hi Gary, I have added 2 more patches. One to disable capsule generation for IA32 builds. There are several places the output directory is hard coded for X64. Will require converting the POST_BUILD scripts to python to make this much better. The second patch is for the Readme.md. Please

Re: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies

2019-07-09 Thread Gary Lin
On Wed, Jul 10, 2019 at 03:38:01AM +, Michael D Kinney wrote: > Hi Gary, > > I have pushed 2 more patches to my branch. One fixes the > ASL issue without removing the code. The second is a clean > up to all the DSC files and build scripts to make everything > more consistent and remove

Re: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies

2019-07-09 Thread Michael D Kinney
Hi Gary, I have pushed 2 more patches to my branch. One fixes the ASL issue without removing the code. The second is a clean up to all the DSC files and build scripts to make everything more consistent and remove more unused content.

Re: [edk2-devel] [PATCH] MdeModulePkg/Setup: Check ConfigAccess protocol in case it's destroyed

2019-07-09 Thread Wang, Jian J
Patch was pushed at 034a3b4f555c6844673a5ee6b7aa4faa74e90a6e Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Dandan Bi > Sent: Wednesday, July 10, 2019 8:42 AM > To: devel@edk2.groups.io; Yeh, GregX > Cc: Ni, Ray ; Kuo, Ted

Re: [edk2-devel] [PATCH 1/2] Readme.md: add submodule policy and clone commands

2019-07-09 Thread Wang, Jian J
Leif, > -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, July 09, 2019 5:27 PM > To: Wang, Jian J > Cc: devel@edk2.groups.io; Kinney, Michael D > ; Gao, Liming > Subject: Re: [PATCH 1/2] Readme.md: add submodule policy and clone > commands > >

Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo

2019-07-09 Thread Wang, Jian J
Pushed at 369c177357312c3e66721f1ea6216ce06c90f569 Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wang, Jian J > Sent: Tuesday, July 09, 2019 5:55 PM > To: devel@edk2.groups.io; leif.lindh...@linaro.org > Cc: Ard Biesheuvel ;

Re: [edk2-devel] [PATCH] MdeModulePkg/Setup: Check ConfigAccess protocol in case it's destroyed

2019-07-09 Thread Dandan Bi
Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GregX Yeh > Sent: Tuesday, July 9, 2019 11:47 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Ni, Ray ; Kuo, Ted > > Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [PATCH V2 4/4] MdeModulePkg/DxeMain: Implement common event protocol

2019-07-09 Thread Gao, Zhichao
> -Original Message- > From: Wang, Jian J > Sent: Tuesday, July 9, 2019 5:24 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Sean Brogan ; Wu, Hao A > ; Ni, Ray ; Zeng, Star > ; Gao, Liming ; Michael Turner > ; Bret Barkelew > > Subject: RE: [PATCH V2 4/4] MdeModulePkg/DxeMain:

Re: [edk2-devel] [Patch v3] BaseTools: Fix GCC compiler failure in new added tools.

2019-07-09 Thread Leif Lindholm
Hi Liming, On Tue, Jul 09, 2019 at 05:53:33PM +0800, Liming Gao wrote: > From: gaozhic > > GCC 7 or 8 reports some warnings in new added FCE/FMMT/BlmLib. Please list the specific warnings addressed. (But also see my comments below - I think this utility needs ripping out and rewriting.) >

[edk2-devel] [PATCH edk2-platforms 0/3] Rectify licensing on various files

2019-07-09 Thread Leif Lindholm
When the change from 2-Clause BSD + CLA to only BSD+Patent happened, a small number of files in the tree were left untouched because the licensing situation was unclear; two files had accidental 3-Clause BSD licenses so could not simply be changed, and some others accidentally lacked explicit

[edk2-devel] [PATCH edk2-platforms 3/3] Silicon/Hisilicon: add SPDX license tags to IORT .asl files

2019-07-09 Thread Leif Lindholm
These files were generated using iasl as a disassembler, which adds a (questionable) copyright Intel statement (which I don't actually care about), but leaves out any sort of license message. As per https://edk2.groups.io/g/devel/message/41048, these were always intended to be contributed as

[edk2-devel] [PATCH edk2-platforms 2/3] Platform/RaspberryPi: add license header to PlatformUiAppLib.inf

2019-07-09 Thread Leif Lindholm
PlatformUiAppLib.inf was accidentally merged without an explicit license header. Add one that matches the actuakl source code (BSD+Patent, after the general relicensing earlier this year. (This has been OK:d with Andrei off-list.) Signed-off-by: Leif Lindholm Cc: Michael D Kinney ---

[edk2-devel] [PATCH edk2-platforms 1/3] Platform,Silicon RPi3: update license headers to BSD+Patent

2019-07-09 Thread Leif Lindholm
RpiMbox.h and Bcm2836.h originate from Ard's original efforts, and were always intended to be 2-clause BSD licensed, but due to a copy/paste error, they ended up with a 3-clause BSD license instead - which meant they were left out in Mike's major relicensing set. (This is explained/confirmed in

Re: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in setup mode

2019-07-09 Thread Zhang, Chao B
Hi Derek: The patch is good to me. Reviewed-by : Chao Zhang From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of derek.l...@hpe.com Sent: Tuesday, July 2, 2019 1:25 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] SecurityPkg: Don't Verify the enrolled PK in

[edk2-devel] Upcoming Event: TianoCore Design / Bug Triage - EMEA - Wed, 07/10/2019 8:00am-9:00am #cal-reminder

2019-07-09 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design / Bug Triage - EMEA *When:* Wednesday, 10 July 2019, 8:00am to 9:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/695893389 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=500773 ) *Organizer:* Stephano Cetola

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Fix various typos

2019-07-09 Thread Chiu, Chasel
Patch pushed: f527942e6bdd9f198db90f2de99a0482e9be5b1b Thanks! Chasel > -Original Message- > From: Antoine Cœur [mailto:co...@gmx.fr] > Sent: Friday, July 5, 2019 10:17 PM > To: devel@edk2.groups.io; Desimone, Nathaniel L > ; Zeng, Star ; Chiu, > Chasel > Cc: Antoine Cœur > Subject:

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when CPU supports

2019-07-09 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Ni, Ray > Sent: Wednesday, July 3, 2019 2:54 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek > Subject: [PATCH v2 3/3] UefiCpuPkg/PiSmmCpu: Enable 5 level paging when > CPU supports > >

Re: [edk2-devel] [Patch v3] BaseTools: Fix GCC compiler failure in new added tools.

2019-07-09 Thread Gary Lin
On Tue, Jul 09, 2019 at 05:53:33PM +0800, Liming Gao wrote: > From: gaozhic > > GCC 7 or 8 reports some warnings in new added FCE/FMMT/BlmLib. > > Signed-off-by: Liming Gao > Cc: Bob Feng > --- > In V2: > Fix GCC8 compiler issue. > > In V3: > Fix snprintf wrong replacement. > >

Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo

2019-07-09 Thread Wang, Jian J
Leif, I'll try push first (not sure I have write access right). If I can't, please do it for me. Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Tuesday, July 09, 2019 5:28 PM > To: Wang, Jian J > Cc:

[edk2-devel] [edk2-DecSpecification PATCH v1] DEC document: Add HOST_APPLICATION ModuleType

2019-07-09 Thread Xiaoyu Lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1952 INF spec add a new ModuleType HOST_APPLICATION. DEC spec also need to be updated. Cc: Liming Gao Cc: Jiewen Yao Signed-off-by: Xiaoyu Lu --- 1_introduction/12_terms.md | 5 +++--

[edk2-devel] [Patch v3] BaseTools: Fix GCC compiler failure in new added tools.

2019-07-09 Thread Liming Gao
From: gaozhic GCC 7 or 8 reports some warnings in new added FCE/FMMT/BlmLib. Signed-off-by: Liming Gao Cc: Bob Feng --- In V2: Fix GCC8 compiler issue. In V3: Fix snprintf wrong replacement. BaseTools/Source/C/BfmLib/BfmLib.c | 117 +++--

Re: [edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo

2019-07-09 Thread Leif Lindholm
On Tue, Jul 09, 2019 at 03:21:42PM +0800, Jian J Wang wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1910 > > '--recursive' in cloning edk2 repo might cause failure on machine > behind proxy. It's not actually necessary for edk2. This patch removed > it from git command. A separate

Re: [edk2-devel] [PATCH 2/2] CryptoPkg/OpensslLib: remove clone commands

2019-07-09 Thread Leif Lindholm
On Tue, Jul 09, 2019 at 02:36:01PM +0800, Jian J Wang wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1910 > > edk2/Readme.md has added a section to explain the correct clone > commands for submodules. Detailed steps in the OpenSSL-HOWTO.txt > are removed to avoid any inconsistency. > >

Re: [edk2-devel] [PATCH 1/2] Readme.md: add submodule policy and clone commands

2019-07-09 Thread Leif Lindholm
Hi Jian, Many thanks for this. A few comments on the text. On Tue, Jul 09, 2019 at 02:36:00PM +0800, Jian J Wang wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=1910 > > A section 'Submodules' is added to clarify the submodule policy > in edk2 repo. Git commands are also added to show

Re: [edk2-devel] [PATCH V2 4/4] MdeModulePkg/DxeMain: Implement common event protocol

2019-07-09 Thread Wang, Jian J
Hi Zhichao, One common comment: please update copy right year. See another comment at the almost the end of the email. > -Original Message- > From: Gao, Zhichao > Sent: Tuesday, July 09, 2019 4:40 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Wang, Jian J > ; Wu, Hao A ; Ni, Ray > ;

[edk2-devel] [PATCH V2 1/4] MdeModulePkg: Add gEdkiiCpu2ProtocolGuid and header file

2019-07-09 Thread Gao, Zhichao
From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1400 Add gEdkiiCpu2ProtocolGuid to MdeMdeModulePkg.dec. Add the header file of Cpu2 protocol: it has one interface to enable interrupt and put cpu to sleep to wait for an interrupt. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni

[edk2-devel] [PATCH V2 4/4] MdeModulePkg/DxeMain: Implement common event protocol

2019-07-09 Thread Gao, Zhichao
From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1400 If an interrupt happens between CheckEvent and gIdleLoopEvent, there would be a event pending during cpu sleep. So it is required to check the gEventPending with the interrupt disabled. Implement a protocol

[edk2-devel] [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol

2019-07-09 Thread Gao, Zhichao
From: Sean Brogan REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1400 Implement Cp2 protocol: it has one interface to enable the interrupt and put cpu to sleep and wait for an interrupt. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc:

[edk2-devel] [PATCH V2 3/4] MdeModulePkg: Add gEdkiiCommonEventProtocolGuid for creating event

2019-07-09 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1400 Add common event protocol to support all TPL event: Add the guid and header file of it. Cc: Jian J Wang Cc: Hao A Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by:

[edk2-devel] [PATCH V2 0/4] Fix race condition and add event protocol

2019-07-09 Thread Gao, Zhichao
V1: There is a race condition in CoreWaitForEvent function: If an interrupt happens between CheckEvent and gIdleLoopEvent, there would be a event pending during cpu sleep. So it is required to check the gEventPending with the interrupt disabled. Implement a gEfiCpu2ProtocolGuid to fix that. The

[edk2-devel] [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo

2019-07-09 Thread Wang, Jian J
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1910 '--recursive' in cloning edk2 repo might cause failure on machine behind proxy. It's not actually necessary for edk2. This patch removed it from git command. A separate command $ git submodule update --init is added to retrieve repo

[edk2-devel] [PATCH 2/2] CryptoPkg/OpensslLib: remove clone commands

2019-07-09 Thread Wang, Jian J
https://bugzilla.tianocore.org/show_bug.cgi?id=1910 edk2/Readme.md has added a section to explain the correct clone commands for submodules. Detailed steps in the OpenSSL-HOWTO.txt are removed to avoid any inconsistency. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by:

[edk2-devel] [PATCH 0/2] Add edk2 submodule policy

2019-07-09 Thread Wang, Jian J
https://bugzilla.tianocore.org/show_bug.cgi?id=1910 Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Jian J Wang (2): Readme.md: add submodule policy and clone commands CryptoPkg/OpensslLib: remove clone commands .../Library/OpensslLib/OpenSSL-HOWTO.txt | 18 ++

[edk2-devel] [PATCH 1/2] Readme.md: add submodule policy and clone commands

2019-07-09 Thread Wang, Jian J
https://bugzilla.tianocore.org/show_bug.cgi?id=1910 A section 'Submodules' is added to clarify the submodule policy in edk2 repo. Git commands are also added to show the correct way to clone submodule repos, in which '--recursive' is removed because it's not needed but recommended in other

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION module type.

2019-07-09 Thread Liming Gao
OK. I have no other comments. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: Yao, Jiewen > Sent: Monday, July 8, 2019 10:10 AM > To: Gao, Liming ; Lu, XiaoyuX ; > devel@edk2.groups.io > Cc: Feng, Bob C > Subject: RE: [PATCH v1 1/1] BaseTools: Add HOST_APPLICATION

Re: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies

2019-07-09 Thread Gary Lin
On Tue, Jul 09, 2019 at 03:52:37AM +, Michael D Kinney wrote: > Hi Gary, > Hi Mike, > I picked up the changes on your branch. I re-enabled the BIOS ID > Feature and added support for IA32 GCC builds, so the builds > available from Windows and Linux are matched now. > > I have posted my