Re: [edk2-devel] [PATCH v1 11/11] ShellPkg: acpiview: DBG2: Add error-checking in the parsing logic

Two comments with this patch. > -Original Message- > From: Krzysztof Koch [mailto:krzysztof.k...@arm.com] > Sent: Friday, July 12, 2019 2:53 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; sami.muja...@arm.com; > matteo.carl...@arm.com; n...@arm.com >

Re: [edk2-devel] [Patch 1/1 V2] BaseTools: Create ".cache" folder when initialize Build object

Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Bob Feng >Sent: Friday, July 19, 2019 10:24 AM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Kinney, Michael D >; Gao, Liming >Subject: [edk2-devel] [Patch 1/1 V2]

Re: [edk2-devel] [Patch 1/1 V2] BaseTools: Create ".cache" folder when initialize Build object

Bob, Thanks for the quick fix. I have tested this change with the Vlv2TbltDevicePkg updates that are under review that include the use of a PREBUILD script. It works when the .cache dir is not present. Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Feng, Bob C >

Re: [edk2-devel] [edk2-platforms Patch 4/5] Vlv2TbltDevicePkg: Convert BAT/sh Capsule scripts to Python

Reviewed-By: Zailiang Sun > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Friday, July 19, 2019 7:00 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-devel] [edk2-platforms

Re: [edk2-devel] [edk2-platforms Patch 1/5] Vlv2TbltDevicePkg/PlatformPei: Add boot mode detection

Reviewed-By: Zailiang Sun > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Friday, July 19, 2019 7:00 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Gary Lin > Subject: [edk2-devel] [edk2-platforms

Re: [edk2-devel] [PATCH v7 0/4] Implement SM3 measured boot

For patch1-3, Reviewed-by: Jian J Wang > -Original Message- > From: Desai, Imran > Sent: Friday, July 19, 2019 6:53 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Zhang, Chao B ; Yao, > Jiewen ; Wang, Jian J ; > Justen, Jordan L ; Laszlo Ersek > ; Ard

Re: [edk2-devel] [Patch 1/1] BaseTools: Create ".cache" folder when initialize Build object

Yes. I only see ".cache" folder is created in one place, in "Misc.py". Thanks, Bob -Original Message- From: Kinney, Michael D Sent: Friday, July 19, 2019 9:32 AM To: Feng, Bob C ; devel@edk2.groups.io; Kinney, Michael D Cc: Gao, Liming Subject: RE: [Patch 1/1] BaseTools: Create

[edk2-devel] [Patch 1/1 V2] BaseTools: Create ".cache" folder when initialize Build object

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1986 Create "Conf/.cache" folder as early as possible so that the later code do need to check if it exits and then create it. Signed-off-by: Bob Feng Cc: Michael D Kinney Cc: Liming Gao --- V2: Remove the ".cache" creation action in other

Re: [edk2-devel] [Patch 1/1] BaseTools: Create ".cache" folder when initialize Build object

Hi Bob, If you create the .cache dir here, can you remove the .cache dir creation in other places, such as Misc.py? Mike > -Original Message- > From: Feng, Bob C > Sent: Thursday, July 18, 2019 6:13 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Kinney, Michael > D ; Gao, Liming >

Re: [edk2-devel] [PATCH v1 01/11] ShellPkg: acpiview: FADT: Validate global pointers before use

Sorry for late review. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Friday, July 12, 2019 2:53 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; sami.muja...@arm.com; >

Re: [edk2-devel] [PATCH v1 1/6] ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct()

> -Original Message- > From: Krzysztof Koch [mailto:krzysztof.k...@arm.com] > Sent: Thursday, July 18, 2019 8:32 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; sami.muja...@arm.com; > matteo.carl...@arm.com; n...@arm.com > Subject: [PATCH v1 1/6]

[edk2-devel] [Patch 1/1] BaseTools: Create ".cache" folder when initialize Build object

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1986 Create "Conf/.cache" folder as early as possible so that the later code do need to check if it exits and then create it. Signed-off-by: Bob Feng Cc: Michael D Kinney Cc: Liming Gao --- BaseTools/Source/Python/build/build.py | 3 ++- 1

Re: [edk2-devel] [PATCH v1 0/6] Acpiview table parsers code style enhancements and refactoring

One comment on 1/6. Others are good for me. For 2-6, Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Thursday, July 18, 2019 8:32 PM > To: devel@edk2.groups.io > Cc: Carsey,

Re: [edk2-devel] [PATCH v1 0/8] Remove redundant forward declarations in acpiview

I am reviewing your previous patch "Add security checks in the Acpiview table parsers". That takes times and I didn't finish reviewing them yet. You do a pretty good separation. That makes the review more easier. I would give some comments on your previous one 10/10 patches to help your further

Re: [edk2-devel] [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

> -Original Message- > From: David Woodhouse [mailto:dw...@infradead.org] > Sent: Thursday, July 18, 2019 12:31 AM > To: devel@edk2.groups.io; ler...@redhat.com; Philippe Mathieu-Daudé > ; Cetola, Stephano > Cc: Andrew Fish ; Ard Biesheuvel > ; Justen, Jordan L ; > Leif Lindholm ; Kinney,

Re: [edk2-devel] [PATCH v7 0/4] Implement SM3 measured boot

Patch 1~3, reviewed-by: jiewen@intel.com Patch 4, acked-by: jiewen@intel.com > -Original Message- > From: Desai, Imran > Sent: Friday, July 19, 2019 6:53 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Zhang, Chao B ; Yao, > Jiewen ; Wang, Jian J ; >

Re: [edk2-devel] [edk2-platforms Patch 0/5] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences

I have also posted a branch with these changes for review at: https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Remove_FCE_BAT_sh Mike > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Michael D Kinney > Sent: Thursday, July 18,

[edk2-devel] [edk2-platforms Patch 0/5] Vlv2Tbl2DevicePkg: Remove Linux/Windows differences

Remove all BAT/sh scripts and use OS independent python scripts for PREBULD and POSTBUILD operations and use standard EDK II build command to build MinnowMax FW images and capsules. The use of FCE has also been removed and replaced with a Structured PCD. The default values for Setup forms are

[edk2-devel] [edk2-platforms Patch 1/5] Vlv2TbltDevicePkg/PlatformPei: Add boot mode detection

Add boot mode detection back into PlatformPei that was inadvertently removed in the following commit: https://github.com/tianocore/edk2-platforms/commit/d6211390793fbd0a89b14001c43e0ef942c85425 Boot mode detection at this point is required to detect the boot mode of BOOT_ON_FLASH_UPDATE that is

[edk2-devel] [edk2-platforms Patch 5/5] Vlv2Tbl2DevicePkg: Convert BAT/sh Build scripts to Python

Convert Build_IFWI and bld_vlv BAT/sh scripts to OS independent python script PeBuild.py. This script generates the BiosId file. Standard EDK II build commands are used to build FW images and capsules. * Sample VS2015x86 commands for IA32/X64 and DEBUG/RELEASE build -a IA32 -a X64 -t

[edk2-devel] [edk2-platforms Patch 4/5] Vlv2TbltDevicePkg: Convert BAT/sh Capsule scripts to Python

Convert all the BAT/sh files used to generate capsules to OS independent Python script. Cc: Zailiang Sun Cc: Yi Qian Cc: Gary Lin Signed-off-by: Michael D Kinney --- .../Capsule/GenerateCapsule/GenCapsuleAll.bat | 35 -- .../Capsule/GenerateCapsule/GenCapsuleAll.py | 397 ++

[edk2-devel] [PATCH v7 2/4] SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest algorithm

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v6 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration

[edk2-devel] [PATCH v7 1/4] SecurityPkg: introduce the SM3 digest algorithm

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v6 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has

[edk2-devel] [PATCH v7 3/4] SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v6 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration

[edk2-devel] [PATCH v7 0/4] Implement SM3 measured boot

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v7 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has

[edk2-devel] [PATCH v7 4/4] OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v6 EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR banks. This digest algorithm is part of the China Crypto algorithm suite. This integration has

Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script

On Thu, Jul 18, 2019 at 11:17:30PM +0200, Laszlo Ersek wrote: > On 07/18/19 18:27, Leif Lindholm wrote: > > Laszlo, Hao - I have prepared a set for pushing as below. > > > > (Reviewed-by: Leif Lindholm for all of your > > patches.) > > *But*, I need a review from Bob and/or Liming before I push

Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script

On 07/18/19 18:27, Leif Lindholm wrote: > Laszlo, Hao - I have prepared a set for pushing as below. > > (Reviewed-by: Leif Lindholm for all of your > patches.) > *But*, I need a review from Bob and/or Liming before I push the final one: > "BaseTools: add GetMaintainer.py script" - >

Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices

On 07/18/19 18:02, Ravi Kumar Siadri wrote: > Hi Laszlo Ersek / Hao Wu, > > I have gone through the Guide, i can see some points which are not > very clear.. > > [...] Perhaps some examples will help. In advance, I should mention a few things: - This is just my interpretation of the spec, and

Re: [edk2-devel] [PATCH 3/4] Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related modules"

On 7/18/19 4:56 AM, Marc-André Lureau wrote: Hi On Mon, Jul 15, 2019 at 9:04 PM Laszlo Ersek wrote: We ask contributors to copy Marc-André and Stefan on patches that affect "TPM2 modules" under OvmfPkg. With the "GetMaintainer.py" script being introduced later, express this expectation in

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

On Thu, Jul 18, 2019 at 04:48:18PM +, Gao, Liming wrote: > > > Find the high version python. When we enable Python3, we find > > > Python37 does great performance optimization. > > > So, we think high version python can bring more benefit. > > > > This is where I disagree. > > As a

Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script

On 7/18/19 7:40 PM, Leif Lindholm wrote: > On Thu, Jul 18, 2019 at 07:01:40PM +0200, Philippe Mathieu-Daudé wrote: >> Hi Leif, >> >> On 7/18/19 6:27 PM, Leif Lindholm wrote: >>> Laszlo, Hao - I have prepared a set for pushing as below. >>> >>> (Reviewed-by: Leif Lindholm >>

Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script

On Thu, Jul 18, 2019 at 07:01:40PM +0200, Philippe Mathieu-Daudé wrote: > Hi Leif, > > On 7/18/19 6:27 PM, Leif Lindholm wrote: > > Laszlo, Hao - I have prepared a set for pushing as below. > > > > (Reviewed-by: Leif Lindholm > > for all of your patches.) > >

Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script

Hi Leif, On 7/18/19 6:27 PM, Leif Lindholm wrote: > Laszlo, Hao - I have prepared a set for pushing as below. > > (Reviewed-by: Leif Lindholm > for all of your patches.) > *But*, I need a review from  Bob and/or Liming before I push the final one: > "BaseTools:

Re: [edk2-devel] [edk2-platforms] [PATCH v2] KabylakeSiliconPkg: Possible out-of-bounds memory writes

Reviewed-by: Sai Chaganty -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, July 17, 2019 11:49 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Kubacki, Michael A ; Chaganty, Rangasai V Subject: [edk2-platforms] [PATCH v2] KabylakeSiliconPkg: Possible out-of-bounds

Re: [edk2-devel] [PATCH 1/1] edksetup.sh: rework python executable scanning

Leif: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Leif > Lindholm > Sent: Thursday, July 18, 2019 6:37 AM > To: Gao, Liming > Cc: Laszlo Ersek ; devel@edk2.groups.io; Rebecca Cran > ; Feng, Bob C ; > Kinney, Michael D ; af...@apple.com >

Re: [edk2-devel] [PATCH 0/3] add GetMaintainer.py helper script

Laszlo, Hao - I have prepared a set for pushing as below. (Reviewed-by: Leif Lindholm for all of your patches.) *But*, I need a review from Bob and/or Liming before I push the final one: "BaseTools: add GetMaintainer.py script" - https://edk2.groups.io/g/devel/message/43666 I have verified

Re: [edk2-devel] ExtScsiPassThru support for Logical SCSI devices

Hi Laszlo Ersek / Hao Wu, I have gone through the Guide, i can see some points which are not very clear.. *1. * *Single-Channel SCSI Adapters* *If the SCSI adapter supports one channel, then the SCSI host controller driver* *performs the following:* *• Install Extended SCSI Pass Thru Protocol

Re: [edk2-devel] [PATCH v1 1/8] ShellPkg: acpiview: RSDP: Remove redundant forward declarations

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43961): https://edk2.groups.io/g/devel/message/43961 Mute This Topic: https://groups.io/mt/32513485/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 4/8] ShellPkg: acpiview: SRAT: Remove redundant forward declarations

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43960): https://edk2.groups.io/g/devel/message/43960 Mute This Topic: https://groups.io/mt/32513484/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 5/8] ShellPkg: acpiview: MADT: Remove redundant forward declarations

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43959): https://edk2.groups.io/g/devel/message/43959 Mute This Topic: https://groups.io/mt/32513483/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 7/8] ShellPkg: acpiview: GTDT: Remove redundant forward declarations

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43957): https://edk2.groups.io/g/devel/message/43957 Mute This Topic: https://groups.io/mt/32513486/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 3/8] ShellPkg: acpiview: SPCR: Remove redundant forward declaration

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43958): https://edk2.groups.io/g/devel/message/43958 Mute This Topic: https://groups.io/mt/32513489/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 8/8] ShellPkg: acpiview: DBG2: Remove redundant forward declarations

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43956): https://edk2.groups.io/g/devel/message/43956 Mute This Topic: https://groups.io/mt/32513492/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 2/8] ShellPkg: acpiview: FADT: Remove redundant forward declarations

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43955): https://edk2.groups.io/g/devel/message/43955 Mute This Topic: https://groups.io/mt/32513493/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 6/8] ShellPkg: acpiview: IORT: Remove redundant forward declarations

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43954): https://edk2.groups.io/g/devel/message/43954 Mute This Topic: https://groups.io/mt/32513494/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 1/6] ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct()

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43953): https://edk2.groups.io/g/devel/message/43953 Mute This Topic: https://groups.io/mt/32514379/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 4/6] ShellPkg: acpiview: SRAT: Minor code style enhancements

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43950): https://edk2.groups.io/g/devel/message/43950 Mute This Topic: https://groups.io/mt/32514385/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 3/6] ShellPkg: acpiview: RSDP: Make code consistent with other parsers

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43951): https://edk2.groups.io/g/devel/message/43951 Mute This Topic: https://groups.io/mt/32514381/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 2/6] ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43952): https://edk2.groups.io/g/devel/message/43952 Mute This Topic: https://groups.io/mt/32514380/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 5/6] ShellPkg: acpiview: MADT: Split structure length validation

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43949): https://edk2.groups.io/g/devel/message/43949 Mute This Topic: https://groups.io/mt/32514386/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH v1 6/6] ShellPkg: acpiview: IORT: Refactor PMCG node mapping count validation

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43948): https://edk2.groups.io/g/devel/message/43948 Mute This Topic: https://groups.io/mt/32514387/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Allow SMM access-out when static paging is OFF

On 07/18/19 08:58, Ni, Ray wrote: > Commit c60d36b4d1ee1f69b7cca897d3621dfa951895c2 > * UefiCpuPkg/SmmCpu: Block access-out only when static paging is used > > updated page fault handler to treat SMM access-out as allowed > address when static paging is not used. > > But that commit is not

Re: [edk2-devel] [PATCH v1 0/6] Acpiview table parsers code style enhancements and refactoring

Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Thursday, July 18, 2019 5:32 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ;

Re: [edk2-devel] [PATCH v1 0/8] Remove redundant forward declarations in acpiview

Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Krzysztof Koch [mailto:krzysztof.k...@arm.com] > Sent: Thursday, July 18, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; sami.muja...@arm.com; > matteo.carl...@arm.com;

Re: [edk2-devel] [edk2-platforms] [PATCH v2] KabylakeSiliconPkg: Possible out-of-bounds memory writes

Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Nate > DeSimone > Sent: Thursday, July 18, 2019 2:49 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject:

Re: [edk2-devel] [PATCH v1 0/6] Acpiview table parsers code style enhancements and refactoring

Reviewed-by: Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 18 July 2019 01:32 PM To: devel@edk2.groups.io Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami Mujawar ; Matteo Carlini ; nd Subject: [PATCH v1 0/6] Acpiview table parsers code style

Re: [edk2-devel] [PATCH 0/4] Maintainers.txt: formalize ArmVirtPkg and OvmfPkg subsystem pathnames

On 07/18/19 06:54, Philippe Mathieu-Daudé wrote: > On 7/15/19 7:04 PM, Laszlo Ersek wrote: >> Repo: https://github.com/lersek/edk2.git >> Branch: ovmfpkg_maintainers >> >> The patches in this series should be inserted between Leif's patches >> >> * [edk2-devel] [PATCH 2/3] Maintainers.txt: add

Re: [edk2-devel] [PATCH v2 0/1] Maintainers.txt: Review ownership for MdeModulePkg

On 07/18/19 03:19, Hao A Wu wrote: > This patch is also available at: > https://github.com/hwu25/edk2/tree/mdemodulepkg_reviewers_v2 > > Also, please note that on the above branch, the proposed patch > (MdeModulePkg reviewers) is inserted between: > > * [edk2-devel] [PATCH 4/4] Maintainers.txt:

[edk2-devel] [PATCH v1 5/6] ShellPkg: acpiview: MADT: Split structure length validation

Split the Interrupt Controller Structure length validation in the acpiview UEFI shell tool into two logical parts: 1. Ensuring MADT table parser forward progress. 2. Preventing MADT table buffer overruns. Also, make the condition for infinite loop detection applicable to all types of Interrupt

[edk2-devel] [PATCH v1 4/6] ShellPkg: acpiview: SRAT: Minor code style enhancements

Minor changes to the SRAT parser code to conform with the EDKII coding style and to make it consistent with other ACPI table parsers. Signed-off-by: Krzysztof Koch --- Notes: v1: - minor code style enhancements [Krzysztof]

[edk2-devel] [PATCH v1 6/6] ShellPkg: acpiview: IORT: Refactor PMCG node mapping count validation

Move Performance Monitoring Counter Group (PMCG) node ID mapping count validation from the core IORT acpiview parser logic to a dedicated function. Now, the pointer to the validation function is passed to the IortNodePmcgParser[] ACPI_PARSER array. This check does not affect the flow of IORT

[edk2-devel] [PATCH v1 3/6] ShellPkg: acpiview: RSDP: Make code consistent with other parsers

List ParseAcpi() function arguments one per line in order to make this function call consistent with ParseAcpi() calls in other ACPI table parsers. Also, notify the user that XsdtAddress value of 0 results in RSDP parsing being terminated and that the XSDT table will not be processed. This

[edk2-devel] [PATCH v1 2/6] ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call

Remove a call to ParseAcpi() responsible for getting the XSDT table length. This call is not needed because the ACPI table buffer length is provided as an input argument to the ParseAcpiXsdt() function. Modify remaining code to use the AcpiTableLength argument of the ParseAcpiXsdt() function

[edk2-devel] [PATCH v1 1/6] ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct()

Modify the signature of the DumpGasStruct() function to include the buffer length parameter and to return the number of bytes parsed by the function. This way it becomes possible to prevent buffer overruns when dumping Generic Address Structure's (GAS) fields in the acpiview table parsers.

[edk2-devel] [PATCH v1 0/6] Acpiview table parsers code style enhancements and refactoring

This set of patches consists of a number of changes which make the code structure consistent across the existing ACPI table parsers. These are all refactoring changes which do not modify the existing functionality of the acpiview UEFI shell tool. Changes can be seen at:

Re: [edk2-devel] [PATCH v1 0/8] Remove redundant forward declarations in acpiview

Reviewed-by: Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 18 July 2019 11:05 AM To: devel@edk2.groups.io Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami Mujawar ; Matteo Carlini ; nd Subject: [PATCH v1 0/8] Remove redundant forward

[edk2-devel] [PATCH v1 8/8] ShellPkg: acpiview: DBG2: Remove redundant forward declarations

Remove redundant forward function declarations by repositioning blocks of code. This way the code structure is consistent across ACPI table parsers and the code becomes more concise. Signed-off-by: Krzysztof Koch --- Notes: v1: - remove redundant forward function declarations

[edk2-devel] [PATCH v1 2/8] ShellPkg: acpiview: FADT: Remove redundant forward declarations

Remove redundant forward function declarations by repositioning blocks of code. This way the code structure is consistent across ACPI table parsers and the code becomes more concise. Signed-off-by: Krzysztof Koch --- Notes: v1: - remove redundant forward function declarations

[edk2-devel] [PATCH v1 6/8] ShellPkg: acpiview: IORT: Remove redundant forward declarations

Remove redundant forward function declarations by repositioning blocks of code. This way the code structure is consistent across ACPI table parsers and the code becomes more concise. Signed-off-by: Krzysztof Koch --- Notes: v1: - remove redundant forward function declarations

[edk2-devel] [PATCH v1 0/8] Remove redundant forward declarations in acpiview

This patch series removes forward static function declarations in the acpiview table parsers. After repositioning blocks of code, these forward declarations are no longer needed and they increase the code size. What is more, some of the existing ACPI table parsers don't have these duplicate

[edk2-devel] [PATCH v1 3/8] ShellPkg: acpiview: SPCR: Remove redundant forward declaration

Reposition blocks of code to remove redundant forward function declarations in order to reduce the code size. Signed-off-by: Krzysztof Koch --- Notes: v1: - remove redundant forward function declarations [Krzysztof]

[edk2-devel] [PATCH v1 4/8] ShellPkg: acpiview: SRAT: Remove redundant forward declarations

Remove redundant forward function declarations by repositioning blocks of code. This way the code structure is consistent across ACPI table parsers and the code becomes more concise. Signed-off-by: Krzysztof Koch --- Notes: v1: - remove redundant forward function declarations

[edk2-devel] [PATCH v1 1/8] ShellPkg: acpiview: RSDP: Remove redundant forward declarations

Remove redundant forward function declarations by repositioning blocks of code. This way the code structure is consistent across ACPI table parsers and the code becomes more concise. Signed-off-by: Krzysztof Koch --- Notes: v1: - remove redundant forward function declarations

[edk2-devel] [PATCH v1 5/8] ShellPkg: acpiview: MADT: Remove redundant forward declarations

Remove redundant forward function declarations by repositioning blocks of code. This way the code structure is consistent across ACPI table parsers and the code becomes more concise. Signed-off-by: Krzysztof Koch --- Notes: v1: - remove redundant forward function declarations

[edk2-devel] [PATCH v1 7/8] ShellPkg: acpiview: GTDT: Remove redundant forward declarations

Remove redundant forward function declarations by repositioning blocks of code. This way the code structure is consistent across ACPI table parsers and the code becomes more concise. Replace multple use of literal values for GT Block Timer Frame count/number validation with a macro definition.

Re: [edk2-devel] [PATCH 3/4] Maintainers.txt: split out section "OvmfPkg: TCG- and TPM2-related modules"

Hi On Mon, Jul 15, 2019 at 9:04 PM Laszlo Ersek wrote: > > We ask contributors to copy Marc-André and Stefan on patches that affect > "TPM2 modules" under OvmfPkg. With the "GetMaintainer.py" script being > introduced later, express this expectation in "Maintainers.txt" in > machine-readable

[edk2-devel] [Patch] BaseTools: Sort file list in Makefile

This patch is going to sort the file list in generated Makefile. This change make the autogen makefile easy to compare. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/GenMake.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [edk2-devel] [PATCH 4/4] Maintainers.txt: split out section "OvmfPkg: CSM modules"

On Wed, 2019-07-17 at 11:38 +0200, Laszlo Ersek wrote: > Stephano, > > On 07/17/19 00:05, David Woodhouse wrote: > > On Tue, 2019-07-16 at 22:55 +0200, Laszlo Ersek wrote: > > > something must have gone wrong -- I don't see your message in my list > > > folder, and I haven't received a moderation

[edk2-devel] [edk2-platforms] [PATCH v2] KabylakeSiliconPkg: Possible out-of-bounds memory writes

- Add check for the DSDT not existing. - Fixed logic errors in loop boundary check. Cc: Chasel Chiu Cc: Michael A Kubacki Cc: Sai Chaganty Co-authored-by: John Mathews Signed-off-by: Nate DeSimone --- .../Library/DxeAslUpdateLib/DxeAslUpdateLib.c | 10 -- 1 file changed, 8

Re: [edk2-devel] [PATCH] ClevoOpenBoardPkg: Added NVMe boot support

Committed: https://github.com/tianocore/edk2-platforms/commit/ff90342886b01de2faf606122c273eef99d446ba -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Wednesday, July 17, 2019 11:32 PM To: Agyeman, Prince ; devel@edk2.groups.io Cc: Gao, Liming ; Sinha,

Re: [edk2-devel] [PATCH] ClevoOpenBoardPkg: Added NVMe boot support

Reviewed-by: Nate DeSimone -Original Message- From: Agyeman, Prince Sent: Monday, July 15, 2019 3:24 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Sinha, Ankit ; Kubacki, Michael A ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH] ClevoOpenBoardPkg: Added NVMe boot support

[edk2-devel] [Patch 7/9] BaseTools: Add LogAgent to support multiple process Autogen

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 AutoGen processes race the logfile. To resolve this issue, this patch create a LogAgent thread in main process to write the log content to console or file, Other process will send the log content to the LogAgent. Cc: Liming Gao

[edk2-devel] [Patch 8/9] BaseTools: Move BuildOption parser out of build.py

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Build tool supports user to specify the conf folder. To make the build options be evaluated at the beginning of launching build, extract the buildoption function from build.py to a new .py file. Signed-off-by: Bob Feng Cc: Liming Gao ---

[edk2-devel] [Patch 9/9] BaseTools: Add the support for python 2

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 python3 change the module name of Queue to queue. python3 add a new log handler of QueueHandler. This patch is to make Multiple process AutoGen feature work for python2 Cc: Liming Gao Signed-off-by: Bob Feng ---

[edk2-devel] [Patch 0/9] Enable multiple process AutoGen

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 In order to improve the build performance, we implemented multiple-processes AutoGen. This change will reduce 20% time for AutoGen phase. The design document can be got from:

[edk2-devel] [Patch 1/9] BaseTools: Singleton the object to handle build conf file

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The build config files are target.txt, build rule, tooldef During a build, the config is not changed, so the object to handle them need to be singleton. Cc: Liming Gao Signed-off-by: Bob Feng ---

[edk2-devel] [Patch 6/9] BaseTools: Add shared data for processes

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Add shared data for autogen processes. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ++- BaseTools/Source/Python/build/build.py | 10 ++ 2 files changed, 8

[edk2-devel] [Patch 2/9] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The WorkspaceAutoGen.__InitWorker function is too long, it's hard to read and understand. This patch is to separate the __InitWorker into multiple small ones. Cc: Liming Gao Signed-off-by: Bob Feng ---

[edk2-devel] [Patch 5/9] BaseTools: Enable Multiple Process AutoGen

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Assign the Module AutoGen tasks into multiple sub process. Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 160 ++ BaseTools/Source/Python/AutoGen/DataPipe.py | 6 +

[edk2-devel] [Patch 3/9] BaseTools: Add functions to get platform scope build options

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 These functions are used for get platform scope build options. They will be used in later patches. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGen.py| 10 +-