[edk2-devel] [Patch 08/10 V5] BaseTools: Move BuildOption parser out of build.py

2019-07-30 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Build tool supports user to specify the conf folder. To make the build options be evaluated at the beginning of launching build, extract the buildoption function from build.py to a new .py file. Signed-off-by: Bob Feng Cc: Liming Gao ---

[edk2-devel] [Patch 06/10 V5] BaseTools: Add shared data for processes

2019-07-30 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Add shared data for autogen processes. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ++- BaseTools/Source/Python/build/build.py | 10 ++ 2 files changed, 8

[edk2-devel] [Patch 05/10 V5] BaseTools: Enable Multiple Process AutoGen

2019-07-30 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 Assign the Module AutoGen tasks into multiple sub process. Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 192 ++ BaseTools/Source/Python/AutoGen/DataPipe.py | 17 +-

[edk2-devel] [Patch 10/10 V5] BaseTools: Enable block queue log agent.

2019-07-30 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 To support Ctrl+S and Ctrl+Q, we enable block queue for log. Cc: Liming Gao Signed-off-by: Bob Feng --- .../Source/Python/AutoGen/AutoGenWorker.py| 6 ++- BaseTools/Source/Python/Common/EdkLogger.py | 10 +++--

[edk2-devel] [Patch 03/10 V5] BaseTools: Add functions to get platform scope build options

2019-07-30 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 These functions are used for get platform scope build options. They will be used in later patches. Cc: Liming Gao Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/AutoGen.py| 10 +-

[edk2-devel] [Patch 01/10 V5] BaseTools: Singleton the object to handle build conf file

2019-07-30 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The build config files are target.txt, build rule, tooldef During a build, the config is not changed, so the object to handle them need to be singleton. Cc: Liming Gao Signed-off-by: Bob Feng ---

[edk2-devel] [Patch 00/10 V5] Enable multiple process AutoGen

2019-07-30 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 In order to improve the build performance, we implemented multiple-processes AutoGen. This change will reduce 20% time for AutoGen phase. The design document can be got from:

[edk2-devel] [Patch 07/10 V5] BaseTools: Add LogAgent to support multiple process Autogen

2019-07-30 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 AutoGen processes race the logfile. To resolve this issue, this patch create a LogAgent thread in main process to write the log content to console or file, Other process will send the log content to the LogAgent. Cc: Liming Gao

[edk2-devel] [Patch 09/10 V5] BaseTools: Add the support for python 2

2019-07-30 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 python3 change the module name of Queue to queue. python3 add a new log handler of QueueHandler. This patch is to make Multiple process AutoGen feature work for python2 Cc: Liming Gao Signed-off-by: Bob Feng ---

[edk2-devel] [Patch 02/10 V5] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

2019-07-30 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875 The WorkspaceAutoGen.__InitWorker function is too long, it's hard to read and understand. This patch is to separate the __InitWorker into multiple small ones. Cc: Liming Gao Signed-off-by: Bob Feng ---

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V3] MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol

2019-07-30 Thread Javeed, Ashraf
Remote repository:- https://github.com/ashrafj/edk2-staging This commit:- https://github.com/ashrafj/edk2-staging/commit/d6739d988f6e43b26f7417e2cdb8fe9103607623 Regards Ashraf > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Wednesday, July 31,

[edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V3] MdePkg/Protocols: New interface, EFI encodings to PCI Plat protocol

2019-07-30 Thread Javeed, Ashraf
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1954 New interface added to PCI Platform Protocol / PCI Override Protocol to retrieve device-specific platform policy for the following PCI standard features, like Maximum Payload Size (MPS), Maximum Read Request Size (MRRS),Extended Tags, Relax

[edk2-devel] [PATCH v2 1/1] UefiCpuPkg/PiSmmCpuDxeSmm: Make code consistent with comments

2019-07-30 Thread Zhang, Shenglei
From: shenglei 1.Remove "out" attribute for " Buffer" parameter in function header. 2.Add "out" attribute for " Token" parameter in function header. 3.Update ProcedureArgument to ProcedureArguments. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang --- v2:In v1 update

[edk2-devel] Cancelled Event: TianoCore Design / Bug Triage - EMEA - Wednesday, 31 July 2019 #cal-cancelled

2019-07-30 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.15...@groups.io DTSTAMP:20190731T031743Z ORGANIZER;CN=Stephano Cetola:mailto:stephano.cet...@linux.intel.com

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments consistent with code

2019-07-30 Thread Dong, Eric
Hi Shenglei, > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, July 30, 2019 2:40 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek ; Zhang, Shenglei > Subject: [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments > consistent with code > > Cc: Eric Dong

Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Use cmp-operator for non-Boolean comparisons

2019-07-30 Thread Wang, Jian J
Pushed at b3d00df69c78fa0e12986a7ff334689a76f4578a Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wang, Jian J > Sent: Tuesday, July 30, 2019 9:55 AM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Ye, Ting > Subject: Re:

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add periods

2019-07-30 Thread Dandan Bi
Hi Shenglei, How about refine the commit message like below before push the patch? 1. Update @parm to @param in function comments in Presentation.c. 2. Add missing period (.) in some function comments. With this update Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- >

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h

2019-07-30 Thread Dong, Eric
Agree with Laszlo's comments. This info is more precise for the issue. Please update the commit message when you push the change. With the commit message updated, reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On

Re: [edk2-devel] [PATCH 1/4] MinPlatformPkg: Auto configure Fsp*BaseAddress PCD

2019-07-30 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Monday, July 29, 2019 4:07 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH 1/4] MinPlatformPkg: Auto configure Fsp*BaseAddress PCD REF:

Re: [edk2-devel] [PATCH 2/4] Platform/Intel: Auto configure Fsp*BaseAddress PCD

2019-07-30 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Monday, July 29, 2019 4:07 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-devel] [PATCH 2/4] Platform/Intel: Auto configure

Re: [edk2-devel] [PATCH 3/4] KabylakeOpenBoardPkg: Auto configure Fsp*BaseAddress PCD

2019-07-30 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Monday, July 29, 2019 4:07 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-devel] [PATCH 3/4] KabylakeOpenBoardPkg: Auto

Re: [edk2-devel] [PATCH 4/4] ClevoOpenBoardPkg: Auto configure Fsp*BaseAddress PCD

2019-07-30 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Monday, July 29, 2019 4:07 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Sinha, Ankit ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-devel] [PATCH 4/4]

[edk2-devel] [PATCH v2 0/1] Add support for HKDF

2019-07-30 Thread Gary West
*** BLURB HERE *** Gary West (1): CryptoPkg/BaseCryptLib: Wrap OpenSSL HKDF algorithm .../Library/BaseCryptLib/BaseCryptLib.inf | 1 + .../Library/BaseCryptLib/PeiCryptLib.inf | 4 +- .../Library/BaseCryptLib/RuntimeCryptLib.inf | 1 + .../Library/BaseCryptLib/SmmCryptLib.inf

[edk2-devel] [PATCH v2 1/1] CryptoPkg/BaseCryptLib: Wrap OpenSSL HKDF algorithm

2019-07-30 Thread Gary West
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1928 1. Implement OpenSSL HKDF wrapped function in CryptHkdf.c file. 2. Implement stub implementation function in CryptHkdfNull.c file. 3. Add wrapped HKDF function declaration to BaseCryptLib.h file. 4. Add CryptHkdf.c to module information

Re: [edk2-devel] [edk2-non-osi/devel-MinPlatform][PATCH] Added cpuid 806EA microcode binary

2019-07-30 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Agyeman, Prince Sent: Monday, July 29, 2019 11:05 AM To: devel@edk2.groups.io Cc: Sinha, Ankit ; Desimone, Nathaniel L ; Kubacki, Michael A ; Kinney, Michael D ; Yao, Jiewen Subject: [edk2-non-osi/devel-MinPlatform][PATCH] Added

Re: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Add display support

2019-07-30 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Agyeman, Prince Sent: Friday, July 26, 2019 8:40 AM To: devel@edk2.groups.io Cc: Gao, Liming ; Sinha, Ankit ; Desimone, Nathaniel L ; Kubacki, Michael A ; Chiu, Chasel ; Agyeman, Prince Subject:

Re: [edk2-devel] [edk2-non-osi] [PATCH 6/6] Cleanup maintainers, contributions, and licenses

2019-07-30 Thread Nate DeSimone
Hi Mike, No need to send a V2 patch series. Thank you for the help! Nate -Original Message- From: Kinney, Michael D Sent: Monday, July 29, 2019 1:19 PM To: devel@edk2.groups.io; leif.lindh...@linaro.org; Desimone, Nathaniel L ; Kinney, Michael D Cc: Andrew Fish ; Laszlo Ersek ;

Re: [edk2-devel] [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from UefiCpuPkg to MdePkg

2019-07-30 Thread Michael D Kinney
Liming, Yes. That would be the correct include statement for a module/lib that depends on MdePkg. I know we have modules/libs that use the UefiCpuPkg and use #include . If we want to provide compatibility with all consumers of the UefiCpuPkg, the Cpuid.h file in the UefiCpuPkg can updated to

Re: [edk2-devel] [PATCH 1/3] UefiCpuPkg/PiSmmCpu: Add Internal function IsStaticPageTableEnabled

2019-07-30 Thread Ni, Ray
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Monday, July 29, 2019 7:33 PM > To: devel@edk2.groups.io; Ni, Ray > Subject: Re: [edk2-devel] [PATCH 1/3] UefiCpuPkg/PiSmmCpu: Add Internal > function IsStaticPageTableEnabled > > Hi Ray, > > On

[edk2-devel] Upcoming Event: TianoCore Design / Bug Triage - EMEA - Wed, 07/31/2019 8:00am-9:00am #cal-reminder

2019-07-30 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design / Bug Triage - EMEA *When:* Wednesday, 31 July 2019, 8:00am to 9:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/695893389 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=502933 ) *Organizer:* Stephano Cetola

Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h

2019-07-30 Thread Laszlo Ersek
On 07/30/19 10:37, Zhang, Shenglei wrote: > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Shenglei Zhang > --- > UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h > b/UefiCpuPkg/PiSmmCpuDxeSmm/SmmMp.h

Re: [edk2-devel] [PATCH 0/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors

2019-07-30 Thread Philippe Mathieu-Daudé
On 7/30/19 4:01 PM, Leif Lindholm wrote: > On Mon, Jul 29, 2019 at 08:03:19PM +0200, Philippe Mathieu-Daude wrote: >> Hi, >> >> This series completes the cleanup from commit 1fce963d89f3 ("ArmPkg: >> DebugPeCoffExtraActionLib: debugger commands are not errors", from >> 2015-03-02), on

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments consistent with code

2019-07-30 Thread Laszlo Ersek
On 07/30/19 08:40, shenglei wrote: > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Shenglei Zhang > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff

Re: [edk2-devel] [Patch 00/11 V4] Enable multiple process AutoGen

2019-07-30 Thread Laszlo Ersek
On 07/30/19 09:31, Feng, Bob C wrote: > Hi Laszlo, > > 1. Question#1 > I did not receive any except yours about the LogQ MaxSize. 2#-6# are > introduced based on my testing result. They can be seen as bugfixes for > regression issues. OK, thanks. This information is very helpful. Please

Re: [edk2-devel] [PATCH 0/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors

2019-07-30 Thread Leif Lindholm
On Mon, Jul 29, 2019 at 08:03:19PM +0200, Philippe Mathieu-Daude wrote: > Hi, > > This series completes the cleanup from commit 1fce963d89f3 ("ArmPkg: > DebugPeCoffExtraActionLib: debugger commands are not errors", from > 2015-03-02), on PeCoffLoaderUnloadImageExtraAction(). > > This solves an

Re: [edk2-devel] [Patch 00/10 V3] Enable multiple process AutoGen

2019-07-30 Thread Bob Feng
Hi Laszlo, Thanks a lot for your testing. V4 and the future V5 change patch 4#, 5# and 10#. For the items you did not test, I tested python3, the "--genfds-multi-thread" option. I think Steven Shi tested the "--hash" option and the "--binary-destination" / "--binary-source" options I think

Re: [edk2-devel] [PATCH 2/2] ArmPkg: DebugPeCoffExtraActionLib: fix trivial typos

2019-07-30 Thread Laszlo Ersek
On 07/29/19 20:03, Philippe Mathieu-Daude wrote: > Fix a pair of trivial typos by inserting a space. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Philippe Mathieu-Daude > --- > .../DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c | 4 ++-- > 1 file changed, 2

Re: [edk2-devel] [PATCH 1/2] ArmPkg: DebugPeCoffExtraActionLib: debugger commands are not errors

2019-07-30 Thread Laszlo Ersek
On 07/29/19 20:03, Philippe Mathieu-Daude wrote: > In commit 1fce963d89f3e we reduced the level of information printed > by PeCoffLoaderRelocateImageExtraAction() but we did not update the > similar PeCoffLoaderUnloadImageExtraAction() function. > > PeCoffLoaderUnloadImageExtraAction() prints

Re: [edk2-devel] [PATCH v4 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-07-30 Thread Laszlo Ersek
Hi Anthony, On 07/29/19 17:39, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git > br.platform-xen-pvh-v4 > > Changes in v4: > - patch "OvmfPkg/XenPlatformPei: Reserve hvmloader's memory only when it has > run" was

Re: [edk2-devel] [PATCH v4 34/35] OvmfPkg: Move XenRealTimeClockLib from ArmVirtPkg

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > Move XenRealTimeClockLib from ArmVirtPkg to OvmfPkg so it can be used > from the OvmfPkg by the following patch, "OvmfPkg/OvmfXen: use > RealTimeClockRuntimeDxe from EmbeddedPkg" > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 >

Re: [edk2-devel] [PATCH v4 33/35] OvmfPkg: Introduce XenIoPvhDxe to initialize Grant Tables

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > XenIoPvhDxe use XenIoMmioLib to reserve some space to be use by the > Grant Tables. > > The call is only done if it is necessary, we simply detect if the > guest is PVH, as in this case there is currently no PCI bus, and no > PCI Xen platform device

Re: [edk2-devel] [PATCH v4 32/35] OvmfPkg: Introduce PcdXenGrantFrames

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > Introduce PcdXenGrantFrames to replace a define in XenBusDxe and allow > the same value to be used in a different module. > > The reason for the number of page to be 4 doesn't exist anymore, so > simply remove the comment. > > Signed-off-by: Anthony

Re: [edk2-devel] [Patch 02/11] BaseTools: Split WorkspaceAutoGen._InitWorker into multiple functions

2019-07-30 Thread Philippe Mathieu-Daudé
On 7/30/19 4:10 AM, Feng, Bob C wrote: > Hi Phil, > > Thanks for your comments. I agree it will be easier to review if this patch > is split into multiple smaller ones. > Since the later patches in Multiple-process autogen patch series are based on > this patch. It will be bigger effort to

Re: [edk2-devel] [PATCH v4 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git > br.platform-xen-pvh-v4 > > Changes in v4: > - patch "OvmfPkg/XenPlatformPei: Reserve hvmloader's memory only when it has > run" was removed, and

Re: [edk2-devel] [PATCH v4 31/35] OvmfPkg/PlatformBootManagerLib: Use a Xen console for ConOut/ConIn

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > On a Xen PVH guest, none of the existing serial or console interface > works, so we add a new one, based on XenConsoleSerialPortLib, and > implemented via SerialDxe. > > That is a simple console implementation that can works on both PVH > guest and HVM

Re: [edk2-devel] [PATCH v4 30/35] OvmfPkg/OvmfXen: Introduce XenTimerDxe

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > "OvmfPkg/8254TimerDxe" is replaced with a Xen-specific > EFI_TIMER_ARCH_PROTOCOL implementation. Also remove > 8259InterruptControllerDxe as it is not used anymore. > > This Timer uses the local APIC timer as time source as it can work on > both a Xen

Re: [edk2-devel] [PATCH v4 23/35] OvmfPkg/XenPlatformPei: Rework memory detection

2019-07-30 Thread Laszlo Ersek
On 07/30/19 13:45, Laszlo Ersek wrote: > On 07/29/19 17:39, Anthony PERARD wrote: >> When running as a Xen PVH guest, there is no CMOS to read the memory >> size from. Rework GetSystemMemorySize(Below|Above)4gb() so they can >> work without CMOS by reading the e820 table. >> >> Rework

Re: [edk2-devel] [PATCH v4 23/35] OvmfPkg/XenPlatformPei: Rework memory detection

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > When running as a Xen PVH guest, there is no CMOS to read the memory > size from. Rework GetSystemMemorySize(Below|Above)4gb() so they can > work without CMOS by reading the e820 table. > > Rework XenPublishRamRegions to also care for the reserved and

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add periods

2019-07-30 Thread Philippe Mathieu-Daudé
On 7/30/19 10:37 AM, Zhang, Shenglei wrote: > para in Presentation.c is spelled incorrectly. 'param' > Add periods in CapsuleLib.h and Presentation.c. > > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Shenglei Zhang > --- > MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 ++-- >

Re: [edk2-devel] [PATCH v4 13/35] OvmfPkg/Library/XenPlatformLib: New library

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > The purpose of XenPlatformLib is to regroup the few functions that are > used in several places to detect if Xen is detected, and to get the > XenInfo HOB. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD >

Re: [edk2-devel] [PATCH v4 09/35] OvmfPkg/OvmfXen: use a TimerLib instance that depends only on the CPU

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > The ACPI Timer isn't present in a PVH guest, but local APIC works on > both PVH and HVM. > > Note that the use of SecPeiDxeTimerLibCpu might be an issue with a > driver of type DXE_RUNTIME_DRIVER. I've attempted to find out which of > the

Re: [edk2-devel] [PATCH v4 06/35] OvmfPkg/XenResetVector: Add new entry point for Xen PVH

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > Add a new entry point for Xen PVH that enter directly in 32bits. > > Information on the expected state of the machine when this entry point > is used can be found at: > https://xenbits.xenproject.org/docs/unstable/misc/pvh.html > > Also, compare to the

Re: [edk2-devel] [PATCH v4 05/35] OvmfPkg/OvmfXen: Creating an ELF header

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > This patch changes the flash device image of OvmfXen to make it look > like it's an ELF. For this, we replace the empty embedded variable store > by a binary array, which is a ELF file header. > > The ELF header explain to a loader to load the binary at

Re: [edk2-devel] [PATCH v4 04/35] OvmfPkg: Introduce XenPlatformPei

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > Introduce XenPlatformPei, a copy of OvmfPkg/PlatformPei without some > of QEMU specific initialization, Xen does not support QemuFwCfg. > > This new module will be adjusted to accommodate Xen PVH. > > fw_cfg dependents that have been removed, which are

Re: [edk2-devel] [PATCH v4 03/35] OvmfPkg: Introduce XenResetVector

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > Introduce XenResetVector, a copy of OvmfPkg/ResetVector, with one > changes: > - SEC_DEFAULT_CR0: enable cache (bit 30 or CD set to 0) > > Xen copies the OVMF code to RAM, there is no need to disable cache. > > This new module will later be modified

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add periods

2019-07-30 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Tuesday, July 30, 2019 4:38 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg:

Re: [edk2-devel] [PATCH v4 02/35] OvmfPkg: Create platform OvmfXen

2019-07-30 Thread Laszlo Ersek
On 07/29/19 17:39, Anthony PERARD wrote: > OvmfXen is a copy of OvmfX64, removing VirtIO and some SMM. > > This new platform will be changed to make it works on two types of Xen > guest: HVM and PVH. > > Compare to OvmfX64, this patch: > > - changed: PLATFORM_GUID, OUTPUT_DIRECTORY,

Re: [edk2-devel] [PATCH 2/3] SecurityPkg/FvReportPei: Change HashAlgoId to HashAlgId

2019-07-30 Thread Wang, Jian J
Thanks for the fix. Reviewed-by: Jian J Wang > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, July 30, 2019 4:38 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J > ; Zhang, Chao B > Subject: [PATCH 2/3] SecurityPkg/FvReportPei: Change HashAlgoId to >

Re: [edk2-devel] [PATCH v3 00/35] Specific platform to run OVMF in Xen PVH and HVM guests

2019-07-30 Thread Laszlo Ersek
On 07/23/19 13:37, Anthony PERARD wrote: > This is a simple test of email configuration, and how the line ending > survive the different MTAs. (There should only be CRLFs in the hunk, and > LFs everywhere else.) > > --- > Readme.md | 9 + > 1 file changed, 9 insertions(+) > > diff --git

[edk2-devel] [PATCH 1/3] MdeModulePkg: Fix typos and add periods

2019-07-30 Thread Zhang, Shenglei
para in Presentation.c is spelled incorrectly. Add periods in CapsuleLib.h and Presentation.c. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Shenglei Zhang --- MdeModulePkg/Universal/SetupBrowserDxe/Presentation.c | 4 ++-- MdeModulePkg/Include/Library/CapsuleLib.h | 2 +- 2 files

[edk2-devel] [PATCH 2/3] SecurityPkg/FvReportPei: Change HashAlgoId to HashAlgId

2019-07-30 Thread Zhang, Shenglei
Cc: Jiewen Yao Cc: Jian Wang Cc: Chao Zhang Signed-off-by: Shenglei Zhang --- SecurityPkg/FvReportPei/FvReportPei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/SecurityPkg/FvReportPei/FvReportPei.c b/SecurityPkg/FvReportPei/FvReportPei.c index

[edk2-devel] [PATCH 0/3] Fix coding style issues

2019-07-30 Thread Zhang, Shenglei
Cc: Hao A Wu Cc: Jiewen Yao Cc: Jian Wang Cc: Chao Zhang Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Shenglei Zhang (3): MdeModulePkg: Fix typos and add periods SecurityPkg/FvReportPei: Change HashAlgoId to HashAlgId UefiCpuPkg/PiSmmCpuDxeSmm: Remove trailing white space in SmmMp.h

[edk2-devel] [edk2-platforms] [PATCH v2 1/6] Vlv2TbltDevicePkg: Adjust the device priority

2019-07-30 Thread Gary Lin
In BootOptionPriority(), the higher number implies the lower boot priority. This commit lowers the priority of network booting and raises the priority of the local devices. Besides, SD and EMMC are also added to BootOptionPriority() since Minnowboard comes with a SD card slot. v2: Also match

[edk2-devel] [edk2-platforms] [PATCH v2 2/6] Vlv2TbltDevicePkg: Add the missing BootManagerMenuApp

2019-07-30 Thread Gary Lin
* BootManagerMenuApp wasn't imported so the Boot Device Menu never showed correctly. * Also fix the description of UiApp. In the "Rule.Common.UEFI_APPLICATION.UI" section, it intends to change the description of UiApp to "Enter Setup" to make the boot option self-explaining in the Boot

[edk2-devel] [edk2-platforms] [PATCH v2 4/6] Vlv2TbltDevicePkg: Clean up the unused variables and function

2019-07-30 Thread Gary Lin
In PlatformBootOption.c: * mContinueBoot and mBootMenuBoot were assigned as "!EnterSetup" before being used. However, EnterSetup is always "FALSE", so it's meaningless to keep those variables. * mPxeBoot is defined but never used. * DetectKeypressCallback() is never used. So we can remove

[edk2-devel] [edk2-platforms] [PATCH v2 3/6] Vlv2TbltDevicePkg: Only sort boot options when necessary

2019-07-30 Thread Gary Lin
* PlatformBootManagerAfterConsole() always sorted the boot options at the end, and this would invalidate the BootOrder created by the user. Besides, the current implementation would sort the boot options twice, and this is not efficient. We should just sort the boot options once at the end

[edk2-devel] [edk2-platforms] [PATCH v2 0/6] Fix the boot order, SMBIOS, and capsule GUIDs of Minnowboard

2019-07-30 Thread Gary Lin
After switching to MdeModulePkg BdsDxe, the boot option created by OS was always put at the end of BootOrder after reboot. Besides, the PXE boot options were always the first boot options. The 1st to 3rd patches fix the priority of boot options and stop sorting the boot options after the first

Re: [edk2-devel] [PATCH edk2-platforms 0/4] Fix the boot order and the boot menu

2019-07-30 Thread Gary Lin
On Fri, Jul 26, 2019 at 07:06:35AM +, Gary Lin wrote: > After switching to MdeModulePkg BdsDxe, the boot option created by OS > was always put at the end of BootOrder after reboot. Besides, the PXE > boot options were always the first boot options. > > This series fixes the priority of boot

Re: [edk2-devel] [PATCH v2 0/3] add DwMmcHcDxe driver

2019-07-30 Thread Haojian Zhuang
On Wed, Jul 24, 2019 at 05:26:03PM +0800, tien.hock@intel.com wrote: > From: "Tien Hock, Loh" > > Changelog: > v3: > * Fix an issue in NonDiscoverableDeviceDxe driver where it did not > invalidate > cache before copying the memory. > v2: > *Split DwMmcHcDxe driver into two patches.

Re: [edk2-devel] [Patch 00/11 V4] Enable multiple process AutoGen

2019-07-30 Thread Bob Feng
Hi Laszlo, 1. Question#1 I did not receive any except yours about the LogQ MaxSize. 2#-6# are introduced based on my testing result. They can be seen as bugfixes for regression issues. 2. Request#2 Yes. I can restructure the patch series and sent out V5. I created a separate 11/11 patch

[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Make comments consistent with code

2019-07-30 Thread Zhang, Shenglei
Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang --- UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c