Re: [edk2-devel] [PATCH V2 00/10] Multiple Controllers Support solution

2019-08-11 Thread Liming Gao
Eric: Can you list the difference compared to version 1? Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Eric >Jin >Sent: Monday, August 12, 2019 9:46 AM >To: devel@edk2.groups.io >Subject: [edk2-devel] [PATCH V2 00/10] Multiple

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header files in INF files

2019-08-11 Thread Zhang, Shenglei
> -Original Message- > From: Wu, Hao A > Sent: Monday, August 12, 2019 10:00 AM > To: devel@edk2.groups.io; Zhang, Shenglei > Cc: Wang, Jian J ; Gao, Liming > > Subject: RE: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header > files in INF files > > > -Original

Re: [edk2-devel] [PATCH v4 00/15] MdeModulePkg: Transfer reset data

2019-08-11 Thread Liming Gao
Zhichao: The change looks good. I have one comment to add more descriptions for new introduced two guids. If so, the developer knows how to use them. Besides, if this patch is for 201908 stable tag, please send RFC for this feature to annou...@edk2.groups.io and devel@edk2.groups.io to

Re: [edk2-devel] [Patch] MdeModulePkg DxeCore: Fix for missing MAT update

2019-08-11 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Saturday, August 10, 2019 10:10 PM > To: devel@edk2.groups.io > Cc: Mike Turner ; Wang, Jian J > ; Wu, Hao A ; Bi, Dandan > > Subject:

Re: [edk2-devel] [Patch] MdeModulePkg/RegularExpressionDxe: Add two missing null pointer checks

2019-08-11 Thread Wu, Hao A
> -Original Message- > From: Gao, Liming > Sent: Monday, August 12, 2019 10:52 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A > Subject: [Patch] MdeModulePkg/RegularExpressionDxe: Add two missing > null pointer checks > > After update Oniguruma from v6.9.0 to v6.9.3, two null

Re: [edk2-devel][edk2-platfoms][PATCH v2 06/22] Platform/CoreDxeInclude.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Gao, Zhichao > Sent: Monday, August 12, 2019 11:05 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm > ; Kinney, Michael D ; > Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject:

[edk2-devel] [PATCH v4 15/15] MdePkg/UefiRuntimeLib: Change the comment

2019-08-11 Thread Gao, Zhichao
Change the comment of EfiResetSystem base on the UEFI spec 2.8 Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao --- MdePkg/Library/UefiRuntimeLib/RuntimeLib.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MdePkg/Library/UefiRuntimeLib/RuntimeLib.c

[edk2-devel] [PATCH v4 09/15] OvmfPkg/OvmfPkgX64.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Liming Gao Signed-off-by: Zhichao Gao --- OvmfPkg/OvmfPkgX64.dsc | 2 ++ 1 file

[edk2-devel] [PATCH v4 11/15] UefiPayloadPkg: Add ResetUtilityLib to UefiPayloadPkgIa32X64.dsc

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Cc: Liming Gao Signed-off-by: Zhichao Gao Reviewed-by: Maurice Ma ---

[edk2-devel] [PATCH v4 10/15] UefiPayloadPkg/UefiPayloadPkgIa32.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Cc: Liming Gao Signed-off-by: Zhichao Gao Reviewed-by: Maurice Ma ---

[edk2-devel] [PATCH v4 14/15] MdePkg/UefiRuntimeLib.h: Change the comment

2019-08-11 Thread Gao, Zhichao
Change the comment of EfiResetSystem base on the UEFI spec 2.8 Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao --- MdePkg/Include/Library/UefiRuntimeLib.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MdePkg/Include/Library/UefiRuntimeLib.h

[edk2-devel] [PATCH v4 08/15] OvmfPkg/OvmfPkgIa32X64.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Liming Gao Signed-off-by: Zhichao Gao --- OvmfPkg/OvmfPkgIa32X64.dsc | 1 + 1 file

[edk2-devel] [PATCH v4 07/15] OvmfPkg/OvmfPkgIa32.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Liming Gao Signed-off-by: Zhichao Gao --- OvmfPkg/OvmfPkgIa32.dsc | 2 ++ 1 file

[edk2-devel] [PATCH v4 00/15] MdeModulePkg: Transfer reset data

2019-08-11 Thread Gao, Zhichao
Indicate two guids gCapsuleArmedResetGuid and gCapsuleUpdateCompleteResetGuid for capsule update. And define a struct which start with a null string and followed by a EFI_GUID. V2: Add prefix Edkii to the new guids. Move the new struct definition to ResetSystemLib.h. Fix the wrong reset data to

[edk2-devel] [PATCH v4 02/15] MdeModulePkg: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Signed-off-by: Zhichao Gao --- MdeModulePkg/MdeModulePkg.dsc | 1 + 1

[edk2-devel] [PATCH v4 06/15] EmulatorPkg/EmulatorPkg.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Cc: Liming Gao Signed-off-by: Zhichao Gao --- EmulatorPkg/EmulatorPkg.dsc | 1 + 1 file

[edk2-devel] [PATCH v4 01/15] MdeModulePkg: Add guids for capsule update

2019-08-11 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 And add two guids gEdkiiCapsuleArmedResetGuid and gEdkiiCapsuleUpdateCompleteResetGuid for capsule Update. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner

[edk2-devel] [PATCH v4 04/15] ArmVritPkg/ArmVirtQemuKernel.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Liming Gao Signed-off-by: Zhichao Gao --- ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 +

[edk2-devel][edk2-platfoms][PATCH v2 11/22] Platform/HiKey.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao --- Platform/Hisilicon/HiKey/HiKey.dsc |

[edk2-devel][edk2-platfoms][PATCH v2 18/22] Platform/QuarkMin.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Kelly Steele Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 20/22] Platform/RPi3.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao --- Platform/RaspberryPi/RPi3/RPi3.dsc |

[edk2-devel][edk2-platfoms][PATCH v2 09/22] Platform/D06.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao --- Platform/Hisilicon/D06/D06.dsc | 2

[edk2-devel][edk2-platfoms][PATCH v2 13/22] Platform/Overdrive1000Board.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 17/22] Platform/Quark.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Kelly Steele Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 15/22] Platform: Add ResetUtilityLib to vlv2 PlatformPkgIA32.dsc

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Zailiang Sun Cc: Yi Qian Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 06/22] Platform/CoreDxeInclude.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao

[edk2-devel][edk2-platfoms][PATCH v2 12/22] Platform/HiKey960.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 19/22] Platform/RDKQemu.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao --- Platform/Comcast/RDKQemu/RDKQemu.dsc

[edk2-devel][edk2-platfoms][PATCH v2 21/22] Platform/SgiPlatform.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao --- Platform/ARM/SgiPkg/SgiPlatform.dsc

[edk2-devel][edk2-platfoms][PATCH v2 14/22] Platform/OverdriveBoard.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 16/22] Platform: Add ResetUtilityLib to vlv2 PlatformPkgX64.dsc

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Zailiang Sun Cc: Yi Qian Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 04/22] Platform/BeagleBoardPkg.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 02/22] Platform/ArmVExpress-CTA15-A7.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 22/22] Platform/SynQuacerEvalBoard.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 00/22] Add ResetUtilityLib to dsc files that contian CapsuleRuntimeDxe

2019-08-11 Thread Gao, Zhichao
The ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it to the related platform dsc files. V2: Update the git config to show the specific [LibraryClasses.$(ARCH)] section for every patch. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Chasel

[edk2-devel][edk2-platfoms][PATCH v2 10/22] Platform/DeveloperBox.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 08/22] Platform/D05.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao --- Platform/Hisilicon/D05/D05.dsc | 2

[edk2-devel][edk2-platfoms][PATCH v2 03/22] Platform/ArmVExpress-FVP-AArch64.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 05/22] Platform/CelloBoard.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao ---

[edk2-devel][edk2-platfoms][PATCH v2 01/22] Platform/ARM/JunoPkg/ArmJuno.dsc: Add ResetUtilityLib to dsc file

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772 ResetUtilityLib would be consumed by CapsuleRuntimeDxe. So add it for the platform dsc file. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Zhichao Gao --- Platform/ARM/JunoPkg/ArmJuno.dsc | 2

[edk2-devel] [Patch] MdeModulePkg/RegularExpressionDxe: Add two missing null pointer checks

2019-08-11 Thread Liming Gao
After update Oniguruma from v6.9.0 to v6.9.3, two null pointer check should be added. This change bases on the patch https://edk2.groups.io/g/devel/message/45183. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Liming Gao --- MdeModulePkg/Universal/RegularExpressionDxe/Oniguruma/regparse.c | 2 ++

Re: [edk2-devel] [PATCHv3 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to support platform specific programming of UFS host controllers

2019-08-11 Thread Wu, Hao A
> -Original Message- > From: Albecki, Mateusz > Sent: Friday, August 09, 2019 10:36 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A > Subject: [PATCHv3 0/4] Add EDKII_UFS_HC_PLATFORM_PROTOCOL to > support platform specific programming of UFS host controllers > > To cover

Re: [edk2-devel] [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic

2019-08-11 Thread Gary Lin
On Fri, Aug 09, 2019 at 02:23:48PM -0700, Kinney, Michael D wrote: > VS2017 builds for X64 are failing due to the use of the > memset intrinsic. The local variable GopVersion is an > array that is initialied in the declaration. Update to > use ZeroMem() to intialize GopVersion. > Looks

Re: [edk2-devel] [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression

2019-08-11 Thread Gary Lin
On Fri, Aug 09, 2019 at 12:34:03PM -0700, Kinney, Michael D wrote: > The following commit removed the call to SetupInfo() from > SystemConfigExtractConfig(). This caused the BIOS, Processor, > Platform, and Memory information strings from being filled > in with their proper values. > >

Re: [edk2-devel] [edk2-platforms][PATCH] Vlv2TbltDevicePkg/FmpDeviceLib: Implement new APIs

2019-08-11 Thread Sun, Zailiang
Reviewed-by: Zailiang Sun > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Eric Jin > Sent: Monday, August 12, 2019 9:45 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi ; > Kinney, Michael D ; Gao, Liming > > Subject:

Re: [edk2-devel] [Patch V3 4/4] EmulatorPkg: Add support for NOOPT target

2019-08-11 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Saturday, August 10, 2019 6:44 AM > To: devel@edk2.groups.io > Cc: Justen, Jordan L; Andrew Fish; Ni, Ray > Subject: [edk2-devel] [Patch V3 4/4] EmulatorPkg: Add support

[edk2-devel] [Patch] Readme.md: Remove tag release from Readme

2019-08-11 Thread Liming Gao
The latest tag release can be found in Release Planning. They are not required to be listed here. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Liming Gao --- Readme.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/Readme.md b/Readme.md index

Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build.

2019-08-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Nate DeSimone > Sent: Friday, August 9, 2019 8:47 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-devel] [edk2-platforms]

[edk2-devel] [PATCH V2 09/10] FmpDevicePkg/FmpDxe: Add PcdFmpDeviceStorageAccessEnable

2019-08-11 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 Add PCD PcdFmpDeviceStorageAccessEnable. If this PCD is TRUE, then the Firmware Management Protocol supports access to the firmware storage device. This is the default setting. If FALSE, then Firmware Management Protocol services that

[edk2-devel] [PATCH V2 10/10] FmpDevicePkg/FmpDxe: Remove use of CatSprint()

2019-08-11 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 The size overhead for CatSPrint() is large. This function is only used to generate variable names with HardwareInstance value appended. Use UnicodeValueToStringS() instead that is much smaller. Cc: Sean Brogan Cc: Bret Barkelew Cc:

[edk2-devel] [PATCH V2 08/10] FmpDevicePkg/FmpDxe: Add PcdFmpDeviceImageTypeIdGuid

2019-08-11 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 Add PCD PcdFmpDeviceImageTypeIdGuid that contains an Image Type ID GUID value that is used if one is not provided by FmpDeviceLib. If this PCD is not a valid GUID value, then gEfiCallerIdGuid is used. Update FmpDevicePkg DSC to use

[edk2-devel] [PATCH V2 07/10] FmpDevicePkg/FmpDxe: Improve all DEBUG() messages

2019-08-11 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 Update all DEBUG() messages to include the name of the FMP device from PcdFmpDeviceImageIdName. Based on content from the following commit, but expanded to cover all DEBUG() messages.

[edk2-devel] [PATCH V2 06/10] FmpDevicePkg: Add Capsule Update Policy Protocol

2019-08-11 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 * Add Capsule Update Policy Protocol to FmpDevicePkg * Add CapsuleUpdatePolicyLib instance that uses the services of the Capsule Update Policy Protocol * Add module that produces the Capsule Update Policy Protocol using the services of

[edk2-devel] [PATCH V2 05/10] FmpDevicePkg/FmpDxe: Different variable for each FMP Descriptor

2019-08-11 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 Cc: Sean Brogan Cc: Bret Barkelew Cc: Liming Gao Signed-off-by: Michael D Kinney Signed-off-by: Eric Jin --- FmpDevicePkg/FmpDxe/FmpDxe.c | 124 +++- FmpDevicePkg/FmpDxe/FmpDxe.h | 8 +-

[edk2-devel] [PATCH V2 03/10] FmpDEvicePkg/FmpDeviceLibNull: Implement new APIs

2019-08-11 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 Cc: Sean Brogan Cc: Bret Barkelew Cc: Liming Gao Signed-off-by: Michael D Kinney Reviewed-by: Eric Jin --- .../Library/FmpDeviceLibNull/FmpDeviceLib.c | 93 ++- 1 file changed, 92 insertions(+), 1 deletion(-) diff

[edk2-devel] [PATCH V2 04/10] FmpDevicePkg/FmpDxe: Use new FmpDeviceLib APIs

2019-08-11 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 Update FmpDxe to support multiple controllers and use new FmpDeviceLib APIs to support Stop/Unload and to set the context for the worker functions in the FmpDeviceLib. Cc: Sean Brogan Cc: Bret Barkelew Cc: Liming Gao Signed-off-by:

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing header files in INF files

2019-08-11 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zhang, Shenglei > Sent: Thursday, August 08, 2019 2:25 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Gao, Liming > Subject: [edk2-devel] [PATCH 1/3] MdeModulePkg: Add missing

[edk2-devel] [PATCH V2 02/10] FmpDevicePkg: Add APIs to FmpDeviceLib

2019-08-11 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 Add new APIs to FmpDevideLib to support multiple controllers * RegisterFmpUninstaller() * FmpDeviceSetContext() * FmpDeviceGetHardwareInstance() Cc: Sean Brogan Cc: Bret Barkelew Cc: Liming Gao Signed-off-by: Michael D Kinney

Re: [edk2-devel] [PATCH] SourceLevelDebugPkg DebugCommLibUsb3: Address NULL ptr dereference case

2019-08-11 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zeng, Star > Sent: Friday, August 09, 2019 9:54 AM > To: devel@edk2.groups.io > Cc: Zeng, Star; Wu, Hao A > Subject: [edk2-devel] [PATCH] SourceLevelDebugPkg DebugCommLibUsb3: > Address NULL ptr

[edk2-devel] [PATCH V2 01/10] FmpDevicePkg: Add UEFI_DRIVER support

2019-08-11 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 Allow libs to be used with modules of type UEFI_DRIVE. Cc: Sean Brogan Cc: Bret Barkelew Cc: Liming Gao Signed-off-by: Michael D Kinney Reviewed-by: Eric Jin --- FmpDevicePkg/Library/FmpDeviceLibNull/FmpDeviceLibNull.inf| 4 ++--

[edk2-devel] [PATCH V2 00/10] Multiple Controllers Support solution

2019-08-11 Thread Eric Jin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1525 The patch set is to support drivers that manage multiple controllers and also provide a firmware update capability to each managed controller. The following modules are related to Multiple Controllers Support solution

[edk2-devel] [edk2-platforms][PATCH] Vlv2TbltDevicePkg/FmpDeviceLib: Implement new APIs

2019-08-11 Thread Eric Jin
Implement new APIs defined in FmpDeviceLib * RegisterFmpUninstaller() * FmpDeviceSetContext() * FmpDeviceGetHardwareInstance() Cc: Zailiang Sun Cc: Yi Qian Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Eric Jin --- .../Library/FmpDeviceLib/FmpDeviceLib.c | 95 ++

Re: [edk2-devel] [edk2-platforms] [PATCH v2] Platform/Intel: Update Readme.md to point to edk2-non-osi master branch

2019-08-11 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, August 12, 2019 7:45 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Laszlo Ersek ; Leif > Lindholm ; Kinney, Michael D > ; Kubacki, Michael A > ; Sinha, Ankit ; Chiu, > Chasel > Subject:

[edk2-devel] [PATCH] ShellPkg/UefiShellLevel2CommansLib: Pointer Resonse should be checked

2019-08-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2049 ShellPkg\Library\UefiShellLevel2CommandsLib\Cp.c line 104 and ShellPkg\Library\UefiShellLevel2CommandsLib\Mv.c line 640, the pointer variable Response may be a NULL pointer. So we should make sure that it isn't NULL before dereference it.

[edk2-devel] gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate definition confusion?

2019-08-11 Thread Andrew Fish via Groups.Io
I was tracking down a Platform C state bug and I noticed the platform code was using this definition [1] for PcdCpuApTargetCstate and wrote that actual value used for Mwait. But the MpInitLIb seems to assume that PcdCpuApTargetCstate is eax[7:4] and it shifts the data left. This ends up with

Re: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Remove batch build scripts

2019-08-11 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Agyeman, Prince Sent: Friday, August 9, 2019 9:35 AM To: devel@edk2.groups.io Subject: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Remove batch build scripts Ref:

Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel/KabylakeOpenBoardPkg: Fix build.

2019-08-11 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/84627927fa195703752c7fd5ab4437f87c547b87 -Original Message- From: Kubacki, Michael A Sent: Friday, August 9, 2019 11:13 AM To: devel@edk2.groups.io; Desimone, Nathaniel L Cc: Chiu, Chasel Subject: RE: [edk2-devel]

Re: [edk2-devel] [edk2-platforms] [PATCH] Platform/Intel: Update Readme.md to point to edk2-non-osi master branch

2019-08-11 Thread Nate DeSimone
Hi Leif, > I am well aware that there are platform-specific steps required to achieve > the final firmware image for some > systems. But we need to work to address that. There have been discussions > about implementing support for > hooking pre/post-build python scripts into the .dsc format -

[edk2-devel] [edk2-platforms] [PATCH v2] Platform/Intel: Update Readme.md to point to edk2-non-osi master branch

2019-08-11 Thread Nate DeSimone
Updated Platform/Intel/Readme.md to point to master branch on edk2-non-osi instead of devel-MinPlatform Updated edk2-platforms/Readme.md to point to Platform/Intel/Readme.md for build instructions on Intel based Minimum Platforms Added a link to the EDK II Minimum Platform Draft Specification to

Re: [edk2-devel] [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic

2019-08-11 Thread Sun, Zailiang
Reviewed-by: Zailiang Sun > -Original Message- > From: Kinney, Michael D > Sent: Saturday, August 10, 2019 5:24 AM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Gary Lin > Subject: [Patch] Vlv2TbltDevicePkg/VlvPlatformInitDxe: Avoid memset instrinsic > > VS2017 builds for X64 are

Re: [edk2-devel] [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression

2019-08-11 Thread Sun, Zailiang
Reviewed-by: Zailiang Sun -Original Message- From: Kinney, Michael D Sent: Saturday, August 10, 2019 3:34 AM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Gary Lin Subject: [Patch] Vlv2Tbl2DevicePkg/PlatformSetupDxe: Fix setup info regression The following commit removed the call to