Re: [edk2-devel] [PATCH v5 1/4] MdePkg: Implement SCSI commands for Security Protocol In/Out

Hello, Sorry for top-posting. I was thinking to make the parameters interface match between the UefiScsiLib API and the EFI Storage Security Command Protocol service, since the implementation of the SSC protocol will directly call the UefiScsiLib API. More specifically, for UefiScsiLib API:

Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

Hi All, It is possible to use git send-email with an exchange server by using DavMail as a relay. I would recommend that we encourage those whom work at a company which does not allow outbound SMTP connections to send their edk2 patches using this method.

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

Mike, as you mentioned we have been working towards enabling a practical and extensible CI for Edk2 using Azure dev ops and the recently added edk2-pytool infrastructure. We have been using similar CI for Project Mu for the last few years. Our approach is a little different in that we focus

[edk2-devel] [edk2-platforms] ClevoOpenBoardPkg: Update board gpios

Updated board GPIOS Cc: Liming Gao Cc: David Y Wei Cc: Michael Kubacki Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Agyeman --- .../Library/BoardInitLib/N1xxWUGpioTable.c| 329 +- 1 file changed, 165 insertions(+), 164 deletions(-) diff --git

Re: [edk2-devel] [PATCH v5 1/4] MdePkg: Implement SCSI commands for Security Protocol In/Out

I've implemented all the suggested changes except changing the arguments from UINT32 to UINTN. No other functions in UefiScsiLib take UINTN arguments, and since the library is directly packing the CDB, I think it makes sense to force the caller to provide the correct-size length value. That way

Re: [edk2-devel] [edk2-platforms PATCH v3 08/11] SimicsOpenBoardPkg: Remove overridden Drivers

Hi David, I would prefer that the contents of this patch be merged into PATCH 4 through 7 as appropriate. Thanks, Nate -Original Message- From: Wei, David Y Sent: Thursday, August 29, 2019 3:43 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ;

Re: [edk2-devel] [edk2-platforms PATCH v3 11/11] SimicsOpenBoardPkg: update the copyright years in file header

Hi David, I would prefer that the contents of this patch be merged into PATCH 4 through 7 as appropriate. Thanks, Nate -Original Message- From: Wei, David Y Sent: Thursday, August 29, 2019 3:43 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ;

Re: [edk2-devel] [edk2-platforms PATCH v3 09/11] SimicsX58SktPkg: update the copyright years in file header

Hi David, I would prefer that the contents of this patch be merged in to PATCH 01/11. Thanks, Nate -Original Message- From: devel@edk2.groups.io On Behalf Of David Wei Sent: Thursday, August 29, 2019 3:43 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ;

Re: [edk2-devel] [edk2-platforms PATCH v3 10/11] SimicsIch10Pkg: update the copyright years in file header

Hi David, I would prefer that the contents of this patch be merged in to PATCH 02/11. Thanks, Nate -Original Message- From: Wei, David Y Sent: Thursday, August 29, 2019 3:43 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Kubacki, Michael A

Re: [edk2-devel] [edk2-non-osi PATCH v2 1/1] SimicsICH10SiliconBinPkg: Add UNDI ROM for SIMICS QSP Platform

I don't think there's a strict naming convention but the actual silicon package sent in review is called "SimicsIch10Pkg" which would naturally map to "SimicsIch10BinPkg" how "KabylakeSiliconPkg" uses "KabylakeSiliconBinPkg". This might be more clear but I also think it is fine as is.

Re: [edk2-devel] [edk2-non-osi PATCH v2 1/1] SimicsICH10SiliconBinPkg: Add UNDI ROM for SIMICS QSP Platform

Reviewed-by: Nate DeSimone -Original Message- From: Wei, David Y Sent: Tuesday, August 27, 2019 5:41 PM To: devel@edk2.groups.io Cc: Wu, Hao A ; Gao, Liming ; Sinha, Ankit ; Agyeman, Prince ; Kubacki, Michael A ; Desimone, Nathaniel L ; Kinney, Michael D Subject: [edk2-non-osi PATCH

Re: [edk2-devel] [PATCH] CoffeelakeSiliconPkg: Add a needed ZeroMem ()

In the future, the subject should include [edk2-platforms] for patches in the repo. Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nate > DeSimone > Sent: Thursday, August 29, 2019 4:00 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ;

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

Hi Michael, would it make sense to run SCT (using UnixHost and/or qemu) to verify the high level logic or do you think that would be too much to do for each PR? Also, do we want to run all these checks for each commit in the PR to verify that they pass at each point in the git history? Thanks

[edk2-devel] [PATCH] CoffeelakeSiliconPkg: Add a needed ZeroMem ()

AddComponentConfigBlocks () should ZeroMem () the Config Block Header before using it. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Sai Chaganty Signed-off-by: Nate DeSimone --- .../Library/BaseSiConfigBlockLib/BaseSiConfigBlockLib.c | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2-devel] [edk2-platforms PATCH v3 11/11] SimicsOpenBoardPkg: update the copyright years in file header

update the copyright years in file header and cleanup the codes to follow the EDK2 coding style Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Signed-off-by: David Wei ---

[edk2-devel] [edk2-platforms PATCH v3 10/11] SimicsIch10Pkg: update the copyright years in file header

update the copyright years in file header and cleanup the codes to follow the EDK2 coding style Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Signed-off-by: David Wei ---

[edk2-devel] [edk2-platforms PATCH v3 06/11] SimicsOpenBoardPkg/BoardX58Ich10: Add board module for QSP Build tip

Add BoardX58ICH10 module for QSP Build tip Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Signed-off-by: David Wei --- .../Library/BoardInitLib/PeiBoardInitPostMemLib.c | 44 +++

[edk2-devel] [edk2-platforms PATCH v3 00/11] Add Initial QSP MinPlatform Pkg for SIMICS

Create the SimicsOpenBoardPkg and its silicon Pkg to provide the support for SIMICS quick start platform. it uses X58/ICH10 and emulated by SIMICS model. Different from V2: Remove overridden drivers under SimicsOpenBoardPkg Add Intel copyright and update copyright years in file header

[edk2-devel] [edk2-platforms PATCH v3 07/11] Platform/Intel: Add build option for SIMICS QSP Platform

Add build option in build script for SIMICS QSP Platform Add Maintainers of Simics QSP related packages Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Signed-off-by: David Wei --- Maintainers.txt |

[edk2-devel] [edk2-platforms PATCH v3 08/11] SimicsOpenBoardPkg: Remove overridden Drivers

Remove overridden Drivers, rename them and relocate underSimicsOpenBoardPkg Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Signed-off-by: David Wei --- .../MinPlatformAcpiTables}/AcpiPlatform.c | 2 +-

[edk2-devel] [edk2-platforms PATCH v3 01/11] SimicsX58SktPkg: Add CPU Pkg for SimicsX58

Add CPU Pkg for SimicsX58. It is added for simics QSP project support Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Signed-off-by: David Wei --- .../SimicsX58SktPkg/Smm/Access/SmmAccess2Dxe.c | 148 +

[edk2-devel] [edk2-platforms PATCH v3 04/11] SimicsOpenBoardPkg: Add DXE driver for Legacy Sio

Add DXE driver for Legacy Sio support Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Signed-off-by: David Wei --- .../LegacySioDxe/ComponentName.c | 173 ++

[edk2-devel] [edk2-platforms PATCH v3 09/11] SimicsX58SktPkg: update the copyright years in file header

update the copyright years in file header and cleanup the codes to follow the EDK2 coding style Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Cc: Michael D Kinney Signed-off-by: David Wei ---

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

Hi Michael, SCTs are in scope. It is only deciding when they get run and how much pre-commit execution time developers are willing to wait for a pass/fail result. The on-demand testing feature is one place we can add extra testing to help improve the quality of commits. The Daily and Weekly

[edk2-devel] [RFC] EDK II Continuous Integration Phase 1

Hello, This is a proposal for a first step towards continuous integration for all TianoCore repositories to help improve to quality of commits and automate testing and release processes for all EDK II packages and platforms. This is based on work from a number of EDK II community members that

[edk2-devel] Cancelled Event: TianoCore Community Meeting - APAC/NAMO - Thursday, 5 September 2019 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.14...@groups.io DTSTAMP:20190829T195017Z ORGANIZER;CN=Stephano Cetola:mailto:stephano.cet...@intel.com

[edk2-devel] Cancelled Event: TianoCore Community Meeting - EMEA/NAMO - Thursday, 5 September 2019 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.14...@groups.io DTSTAMP:20190829T194940Z ORGANIZER;CN=Stephano Cetola:mailto:stephano.cet...@intel.com

[edk2-devel] Subject: [PATCH v2] MdePkg/DxeHstiLib: Added checks to improve error handling.

Hi Liming, per your recommendation, Please review the below [PATCH v2] and the commit can be found in: g...@github.com:JayRaghuram/edk2.git (https://github.com/JayRaghuram/edk2) REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2138

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

On 08/27/19 20:31, Igor Mammedov wrote: > On Sat, 24 Aug 2019 01:48:09 + > "Yao, Jiewen" wrote: >> (05) Host CPU: (OS) Port 0xB2 write, all CPUs enter SMM (NOTE: New CPU >> will not enter CPU because SMI is disabled) > I think only CPU that does the write will enter SMM That used to be

Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Thursday, August 29, 2019 7:24 AM > To: Leif Lindholm ; Ni, Ray > Cc: Gao, Liming ; Cetola, Stephano > ; Kinney, Michael D > ; jayanth.raghu...@dell.com; 'Andrew Fish > (af...@apple.com)' ; >

Re: [edk2-devel] [edk2-platforms:PATCH v5] IntelSiliconPkg/Feature Implement SmmAccess

Reviewed-by: Ray Ni > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Marc W > > Chen > > Sent: Tuesday, August 27, 2019 4:56 PM > > To: devel@edk2.groups.io > > Cc: Chen, Marc W ; Ni, Ray ; > > Chaganty, Rangasai V > > Subject: [edk2-devel] [edk2-platforms:PATCH v5]

Re: [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

On 08/28/19 14:01, Igor Mammedov wrote: > On Tue, 27 Aug 2019 22:11:15 +0200 > Laszlo Ersek wrote: > >> On 08/27/19 18:23, Igor Mammedov wrote: >>> On Mon, 26 Aug 2019 17:30:43 +0200 >>> Laszlo Ersek wrote: >>> On 08/23/19 17:25, Kinney, Michael D wrote: > Hi Jiewen, > > If a

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: Fixed regression issue for building !x86 builds

Laszlo: > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Thursday, August 29, 2019 10:33 PM > To: devel@edk2.groups.io; Feng, Bob C ; Kinney, Michael > D ; Gao, Liming > ; Leif Lindholm > Cc: af...@apple.com > Subject: Re: [edk2-devel]

Re: [edk2-devel] [edk2-platforms: PATCH v2 1/1] Platform/Rpi3: Add compatible property to the "usb" Device Tree node

Hi Leif, On 2019.08.29 14:54, Leif Lindholm wrote: On Fri, Aug 23, 2019 at 01:20:50PM +0100, Pete Batard wrote: Some Linux kernels (e.g. Debian) require "bcm,bcm2835-usb" to be present in Is the typo here or in the code? ('bcm,' vs. 'brcm,') Sorry, should have been 'brcm,bcm2835-usb'

Re: [edk2-devel] [Patch] UefiCpuPkg/SecCore: get AllSecPpiList after SecPlatformMain.

Hi Laszlo, I based on current code logic to adjust the code position. I agree it's a good enhancement for the commit message. I will add it when I push the change. Also I will push the change after the code freeze done. Thanks, Eric > -Original Message- > From: Laszlo Ersek

Re: [edk2-devel] [Patch][edk2-stable201908] BaseTools: Fixed regression issue for building !x86 builds

Bob, On 08/29/19 05:15, Bob Feng wrote: > Pushed at 37eef91017ad042035090cae46557f9d6e2d5917 If I understand correctly, it remains the case that the BaseTools behavior -- which has now been restored, with this commit -- does not match the priority order for lib class resolutions in the DSC

Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

Jayanth: Thanks for your update commit message. But, edk2 project doesn't use pull request. You can send https://github.com/JayRaghuram/edk2 and say your patch is in this tree. Leif gives the option. You need copy the patch content into the mail, then send this mail to

Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

On 08/29/19 11:49, Leif Lindholm wrote: > On Wed, Aug 28, 2019 at 05:33:28PM +, Ni, Ray wrote: >> With the existence of mail attachments capability in new groups.io >> system, can we accept such kind of patch submission? Or any side >> effect you see if allowing mail attachments? > >

Re: [edk2-devel] [edk2-platforms: PATCH v2 1/1] Platform/Rpi3: Add compatible property to the "usb" Device Tree node

On Fri, Aug 23, 2019 at 01:20:50PM +0100, Pete Batard wrote: > Some Linux kernels (e.g. Debian) require "bcm,bcm2835-usb" to be present in Is the typo here or in the code? ('bcm,' vs. 'brcm,') If here, I can fix up on committing. / Leif > the list of compatible properties for the "usb"

Re: [edk2-devel] [Patch] UefiCpuPkg/SecCore: get AllSecPpiList after SecPlatformMain.

Hi Eric, On 08/28/19 08:50, Eric Dong wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2136 > > SecPlatformMain is a platform hook function which let platform does > some update. Some platform may adjust SecCoreData->PeiTemporaryRamBase > which caused former saved AllSecPpiList

Re: [edk2-devel] Getting Synchronous Exception while run avocado-vt tests

(+Drew) On 08/28/19 08:12, Guoheyi wrote: > Hi Ard, Laszlo, > > Greetings and thanks for your time to help investigate the issue. > Finally we found it is caused by KVM and fixed by this patch: > >

Re: edk2-stable201908 Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: fix !x86 builds (more)

On 08/27/19 21:41, Leif Lindholm wrote: > On Tue, Aug 27, 2019 at 09:28:50PM +0200, Laszlo Ersek wrote: >> On 08/27/19 17:50, Leif Lindholm wrote: >>> Apologies, forgot to tag the subject for stable release (although I >>> did remember to cc the stewards). >> >> Understood, thus far... (And I

Re: [edk2-devel] [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.

On Wed, Aug 28, 2019 at 05:33:28PM +, Ni, Ray wrote: > Liming, Stephano and all stewards, > My understanding is the requirement of embedding patch into the mail > body is due to a limitation in old system (01.org). That system > couldn't support mail attachments. Oh, it could. I think it was