Re: [edk2-devel] Subject: [PATCH v2] MdePkg/DxeHstiLib: Added checks to improve error handling.

2019-09-01 Thread Liming Gao
This change is good to me. Reviewed-by: Liming Gao From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of jayanth.raghu...@dell.com Sent: Friday, August 30, 2019 12:32 AM To: devel@edk2.groups.io Subject: [edk2-devel] Subject: [PATCH v2] MdePkg/DxeHstiLib: Added checks to

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: UefiLib: Add a function to check if a language is supported

2019-09-01 Thread Liming Gao
Tom: New API IsLanguageSupported() only supports RFC 4646 language code for the Unicode string. If you think ISO 639-2 language code is obsolete, and don't plan to support it any longer. Please update IsLanguageSupported() function description to clarify this API for RFC 4646 language

Re: [edk2-devel] [PATCH v5 1/4] MdePkg: Implement SCSI commands for Security Protocol In/Out

2019-09-01 Thread Wu, Hao A
> -Original Message- > From: Gao, Liming > Sent: Monday, September 02, 2019 9:47 AM > To: Wu, Hao A; Zurcher, Christopher J; devel@edk2.groups.io; Kinney, > Michael D > Cc: Yao, Jiewen; Wang, Jian J > Subject: RE: [edk2-devel] [PATCH v5 1/4] MdePkg: Implement SCSI > commands for Security

Re: [edk2-devel] [PATCH] BaseTools: Support more file types in build cache

2019-09-01 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Shi, Steven > Sent: Tuesday, August 27, 2019 1:17 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C ; > Shi, Steven > Subject: [PATCH] BaseTools: Support more file types in build cache > > From: "Shi, Steven" > > BZ:

Re: [edk2-devel] [PATCH v5 1/4] MdePkg: Implement SCSI commands for Security Protocol In/Out

2019-09-01 Thread Liming Gao
Hao: I add my comments. Thanks Liming > -Original Message- > From: Wu, Hao A > Sent: Monday, September 2, 2019 9:11 AM > To: Gao, Liming ; Zurcher, Christopher J > ; devel@edk2.groups.io; Kinney, > Michael D > Cc: Yao, Jiewen ; Wang, Jian J > Subject: RE: [edk2-devel] [PATCH v5 1/4]

[edk2-devel] [Patch] BaseTools: Update GenFw tool to support -e -z option together

2019-09-01 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1727 -e -z option is to generate EFI image with zero debug entry. It can be used to check the EFI image in DEBUG build. Signed-off-by: Liming Gao Cc: Bob Feng --- BaseTools/Source/C/GenFw/GenFw.c | 17 +++-- 1 file changed, 15

Re: [edk2-devel] [PATCH v5 1/4] MdePkg: Implement SCSI commands for Security Protocol In/Out

2019-09-01 Thread Wu, Hao A
> -Original Message- > From: Gao, Liming > Sent: Friday, August 30, 2019 5:15 PM > To: Wu, Hao A; Zurcher, Christopher J; devel@edk2.groups.io; Kinney, > Michael D > Cc: Yao, Jiewen; Wang, Jian J; Gao, Liming > Subject: RE: [edk2-devel] [PATCH v5 1/4] MdePkg: Implement SCSI > commands for

[edk2-devel] [PATCH v3 1/1] ShellPkg/Pci.c: Update supported link speed to PCI5.0

2019-09-01 Thread Gao, Zhichao
From: "Gao, Zhichao" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1955 Refer to PCI express base specification Reversion 5.0, Version 1.0, Table 7-33, Supported Link Speeds Vector bit 3 indicate the speed 16 GT/s and bit 4 indicate the speed 32 GT/s. Add the support to shell command 'pci