Re: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-04 Thread Zhang, Shenglei
It works after I apply the change according to your advice. And that makes the code more clean. Thanks for your advice. I'll sent out a v2 patch. Best Regards, Shenglei > -Original Message- > From: Chiu, Chasel > Sent: Thursday, September 5, 2019 10:54 AM > To: Zhang, Shenglei ;

Re: [edk2-devel] [edk2] [Patch 32/33] BaseTools: ECC tool Python3 adaption

2019-09-04 Thread Bob Feng
Hi Leif, Would you try to install antlr4-python3-runtime on debian. pip install antlr4-python3-runtime I think python3 + antlr3 would not be a good combination, since the antlr3 for python3 is still in beta and has not been update for 7 years. And I think there is no ECC test for such

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Zeng, Star
Reviewed-by: Star Zeng > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Chiu, Chasel > Sent: Thursday, September 5, 2019 12:27 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject: [edk2-devel] [PATCH v2]

Re: [edk2-devel] [patch 2/3] MdeModulePkg: Unload image on EFI_SECURITY_VIOLATION

2019-09-04 Thread Wu, Hao A
> -Original Message- > From: Bi, Dandan > Sent: Wednesday, September 04, 2019 4:26 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Gao, Liming; Laszlo Ersek > Subject: [patch 2/3] MdeModulePkg: Unload image on > EFI_SECURITY_VIOLATION > > For the LoadImage() boot

Re: [edk2-devel] [edk2-platforms] [PATCH v2] ClevoOpenBoardPkg: Fix GCC5 build issue

2019-09-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Wednesday, September 4, 2019 11:48 PM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Sinha, Ankit > ; Desimone, Nathaniel L > ; Kubacki, Michael A > ; Chiu, Chasel ; Bi, > Dandan > Subject:

Re: [edk2-devel] [edk2-platforms] [PATCH v3 1/1] MinPlatformPkg/Acpi: MADT NMI default flag set to Edge-Triggered

2019-09-04 Thread Chiu, Chasel
I do not see change on top of V2, why we need V3? Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sinha, > Ankit > Sent: Thursday, September 5, 2019 6:18 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone,

[edk2-devel] [patch] MdeModulePkg: Remove gEfiFormBrowserExProtocolGuid

2019-09-04 Thread Dandan Bi
gEfiFormBrowserExProtocolGuid is not used in edk2, and it can be replaced by gEdkiiFormBrowserExProtocolGuid. So remove gEfiFormBrowserExProtocolGuid to avoid confusion. Cc: Eric Dong Cc: Liming Gao REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2145 Signed-off-by: Dandan Bi ---

[edk2-devel] [PATCH v2] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2153 Current logic will skip searching EFI_PEI_CORE_FV_LOCATION_PPI when the PPI in PpiList having EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST flag, but platform may pass single PPI in PpiList that should be supported. Changed the logic to verify

[edk2-devel] [Patch 2/2] BaseTools: Enable --genfds-multi-thread to default build

2019-09-04 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1302 This patch enable --genfds-multi-thread to default build. This patch keep --genfds-multi-thread build option for compatibility and also add a new build option to disable genfds-multi-thread as --no-genfds-multi-thread. Cc: Liming Gao

[edk2-devel] [Patch 0/2] Enable --genfds-multi-thread to default build

2019-09-04 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1302 Enable --genfds-multi-thread as default build behavior can improve build performance but will not bring nagtive impact. Feng, Bob C (2): BaseTools: Fixed the build fail on Linux with --genfds-multi-thread BaseTools: Enable

[edk2-devel] [Patch 1/2] BaseTools: Fixed the build fail on Linux with --genfds-multi-thread

2019-09-04 Thread Bob Feng
If GenSec input file not exist, the related command will fail and make will stop on Linux. GenSec input file is allow to be non-existent. This patch is to let "make" continue if gensec input file not exist. Cc: Liming Gao Signed-off-by: Bob Feng ---

Re: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-04 Thread Chiu, Chasel
Thanks for explanations. So looks like the intention is to support X64 build scenarios, I think TopOfTemporaryRam should be defined as UINTN from beginning so it can hold 64bits address in X64 build. Please evaluate if we could make these changes. Thanks! Chasel > -Original Message-

Re: [edk2-devel] [patch 3/3] ShellPkg: Unload image on EFI_SECURITY_VIOLATION

2019-09-04 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao > -Original Message- > From: Bi, Dandan > Sent: Wednesday, September 4, 2019 4:26 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; > Laszlo Ersek > Subject: [patch 3/3] ShellPkg: Unload image on EFI_SECURITY_VIOLATION > > For the LoadImage() boot

Re: [edk2-devel] [PATCH] ShellPkg/ShellPkg.dsc AARCH64: enable stack protector

2019-09-04 Thread Gao, Zhichao
Acked-by: Zhichao Gao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Thursday, September 5, 2019 12:38 AM > To: Ard Biesheuvel > Cc: devel@edk2.groups.io; Carsey, Jaben ; Ni, Ray > ; Gao, Zhichao ; Gao, Liming > >

Re: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-04 Thread Zhang, Shenglei
Hi chasel, > -Original Message- > From: Chiu, Chasel > Sent: Wednesday, September 4, 2019 8:13 PM > To: devel@edk2.groups.io; Zhang, Shenglei > Cc: Kubacki, Michael A ; Desimone, Nathaniel > L ; Gao, Liming > Subject: RE: [edk2-devel] [PATCH] >

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other NSIDs for Admin commands

2019-09-04 Thread Wu, Hao A
Hello Tyler, Some inline comments below. Best Regards, Hao Wu From: Tyler J Erickson [mailto:tyler.j.erick...@seagate.com] Sent: Wednesday, September 04, 2019 11:07 PM To: Wu, Hao A Cc: devel@edk2.groups.io; Ni, Ray Subject: Re: [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other NSIDs for

[edk2-devel] [PATCH 13/15] [platforms/devel-riscv-v2]: U500Pkg/PlatformPei: Platform initialization PEIM

2019-09-04 Thread Gilbert Chen
This is the platform-implementation specific library which is executed in early PEI phase for platform initialization. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- .../SiFive/U500Pkg/Universal/Pei/PlatformPei/Fv.c | 55

[edk2-devel] [PATCH 08/15] [platforms/devel-riscv-v2]: U500Pkg/Include: Header files of SiFive U500 platform

2019-09-04 Thread Gilbert Chen
The initial header file commit for SiFive U5-MC Coreplex and U500 Core Local interrupt definitions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- .../SiFive/U500Pkg/Include/SiFiveU5MCCoreplex.h| 57 ++

[edk2-devel] [PATCH 12/15] [platforms/devel-riscv-v2]: U500Pkg/TimerDxe: Platform Timer DXE driver

2019-09-04 Thread Gilbert Chen
Timer DXE driver for U500 platform based U500 platform implementation specifc timer registers. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- .../SiFive/U500Pkg/Universal/Dxe/TimerDxe/Timer.c | 317 +

[edk2-devel] [PATCH 10/15] [platforms/devel-riscv-v2]: U500Pkg/Library: Library instances of U500 platform library.

2019-09-04 Thread Gilbert Chen
OpneSbiPlatformLib - In order to reduce the dependencies with RISC-V OpenSBI project (https://github.com/riscv/opensbi) and less burdens to EDK2 build process, the implementation of RISC-V EDK2 platform is leverage platform source code from OpenSBI code tree. The "platform.c" under

[edk2-devel] [PATCH 15/15] [platforms/devel-riscv-v2]: U500Pkg: Update Readme.md

2019-09-04 Thread Gilbert Chen
Update Readme.md follow sample platform readme guidance. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- Platform/RiscV/SiFive/U500Pkg/Readme.md | 32 1 file changed, 32 insertions(+) diff --git

[edk2-devel] [PATCH 09/15] [platforms/devel-riscv-v2]: U500Pkg/Library: Initial version of PlatformBootManagerLib

2019-09-04 Thread Gilbert Chen
SiFive RISC-V U500 Platform Boot Manager library. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- .../Library/PlatformBootManagerLib/MemoryTest.c| 689 + .../PlatformBootManagerLib/PlatformBootManager.c | 280 +

[edk2-devel] [PATCH 05/15] [platforms/devel-riscv-v2]: RiscV/Library: Initial version of libraries introduced in RISC-V platform package

2019-09-04 Thread Gilbert Chen
FirmwareContextProcessorSpecificLib - Common library to consume EFI_RISCV_FIRMWARE_CONTEXT_HART_SPECIFIC and build up processor specific data HOB. RealTimClockLibNull - NULL instance of Real Time Clock library. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen

[edk2-devel] [PATCH 14/15] [platforms/devel-riscv-v2]: Platforms: Readme file updates

2019-09-04 Thread Gilbert Chen
Update Readme.md and Maintainers.txt for RISV-V platforms. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- Maintainers.txt | 9 + Readme.md | 11 +++ 2 files changed, 20 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt

[edk2-devel] [PATCH 11/15] [platforms/devel-riscv-v2]: U500Pkg/RamFvbServiceruntimeDxe: FVB driver for EFI variable.

2019-09-04 Thread Gilbert Chen
Firmware Volume Block driver instance for ram based EFI variable on U500 platform. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- .../Dxe/RamFvbServicesRuntimeDxe/FvbInfo.c | 133 +++ .../FvbServicesRuntimeDxe.inf | 88 ++

[edk2-devel] [PATCH 07/15] [platforms/devel-riscv-v2]: RiscV/SiFive: Initial version of SiFive U500 platform package

2019-09-04 Thread Gilbert Chen
The initial version of SiFive U500 platform package. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- Platform/RiscV/SiFive/U500Pkg/Readme.md| 30 ++ Platform/RiscV/SiFive/U500Pkg/U500.dec | 40 ++ Platform/RiscV/SiFive/U500Pkg/U500.dsc

[edk2-devel] [PATCH 02/15] [platforms/devel-riscv-v2]: Silicon/SiFive: Add library module of SiFive RISC-V cores

2019-09-04 Thread Gilbert Chen
Initial version of SiFive RISC-V core libraries. Library of each core creates processor core SMBIOS data hob for building SMBIOS records in DXE phase. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- .../E51/Library/PeiCoreInfoHobLib/CoreInfoHob.c|

[edk2-devel] [PATCH 06/15] [platforms/devel-riscv-v2]: RiscV/Universal: Initial version of common RISC-V SEC module

2019-09-04 Thread Gilbert Chen
Common RISC-V SEC module for RISC-V platforms. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- Platform/RiscV/Universal/Sec/Riscv64/SecEntry.s | 439 Platform/RiscV/Universal/Sec/SecMain.c | 529

[edk2-devel] [PATCH 00/15] [platforms/devel-riscv-v2]: Add SiFive U500 VC707 FPGA Platform

2019-09-04 Thread Gilbert Chen
"devel-riscv-v2" is a new branch created for reviewing code changes of SiFive U500 VC707 FPGA platform EDK2 port. Compare to old "devel-riscv" branch, the patches sent to "devel-riscv-v2" branch are made based on the most recent edk2/master. The corresponding patches of edk2 code changes were

[edk2-devel] [PATCH 04/15] [platforms/devel-riscv-v2]: RiscV/Include: Initial version of header files in RISC-V platform package

2019-09-04 Thread Gilbert Chen
FirmwareContextProcessorSpecificLib.h - The difinitions of Firmware Context EDK2 implementaion based on RISC-V OpenSBI. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- .../Library/FirmwareContextProcessorSpecificLib.h | 47 ++ 1 file

[edk2-devel] [PATCH 01/15] [platforms/devel-riscv-v2]: Silicon/SiFive: Initial version of SiFive silicon package

2019-09-04 Thread Gilbert Chen
Add SiFive silicon EDK2 metafile and header files of SiFive RISC-V cores. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- Silicon/SiFive/Include/Library/SiFiveE51.h | 66 ++ Silicon/SiFive/Include/Library/SiFiveU54.h |

[edk2-devel] [PATCH 03/15] [platforms/devel-riscv-v2]: platforms/RiscV: Initial version of RISC-V platform package

2019-09-04 Thread Gilbert Chen
Initial version of RISC-V platform package which provides the common libraries, drivers, PCD and etc. for RISC-V platform development. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Gilbert Chen --- Platform/RiscV/Readme.md | 89

Re: [edk2-devel] [PATCH] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Chiu, Chasel
> -Original Message- > From: Ni, Ray > Sent: Thursday, September 5, 2019 2:04 AM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Dong, Eric ; Laszlo Ersek > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: support single > EFI_PEI_CORE_FV_LOCATION_PPI in PpiList > > > -Original

Re: [edk2-devel] Mappings and StdLib

2019-09-04 Thread Andrew Fish via Groups.Io
Tim, I don't know about the plans with the StdLib, but I do remember a long time ago with the old shell there was a protocol that let you translate volume names (mappings) into handles and device paths. So you could write a simple library that has 2 styles of APIs: 1) Handle + FilePath in

[edk2-devel] Mappings and StdLib

2019-09-04 Thread Tim Lewis
Following up on my last e-mail, I guess I had the wrong assumption: there doesn't appear to be a way to resolve mappings within StdLib. Are there any plans here? Thanks, Tim -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-rfc] [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-04 Thread rebecca
On 2019-09-03 10:41, Ni, Ray wrote: > Can we change the process a bit? > 1. maintainers created pull requests on behave of the patch owners > 2. patch owners can be notified automatically if pull requests fail > 3. patch owners update the pull requests > (I am not familiar to pull requests. I

[edk2-devel] [PATCH] ArmVirtPkg/ArmVirtPrePiUniCoreRelocatable: revert to PIE linking

2019-09-04 Thread Ard Biesheuvel
In some cases, the CLANG38 toolchain profile in LTO mode emits GOT based relocations in spite of our attempts to avoid this, by using hidden visibility, -Bsymbolic etc. On AARCH64, we managed to work around this by processing the GOT based relocations in GenFw. As it turns out, the same issue

[edk2-devel] [edk2-platforms] [PATCH v3 1/1] MinPlatformPkg/Acpi: MADT NMI default flag set to Edge-Triggered

2019-09-04 Thread Sinha, Ankit
1. Default APIC NMI structure in MADT changed to expose Level-Triggered interrupts. 2. x2APIC NMI structure won't be exposed to OS if x2APIC is not enabled. Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Ankit Sinha ---

[edk2-devel] Q: StdLib and mappings

2019-09-04 Thread Tim Lewis
When using StdLib, I found that access and open have difficulty if the mapping name is not the same case as the mapping name in the path. I have traced this down to a line in DevSearch.c (line 68) if(wcsncmp(DevName, WorkNode->DevName, wcslen(WorkNode->DevName)) == 0) { It

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported

2019-09-04 Thread Heinrich Schuchardt
It is allowable that a system does not support EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.SetState(). For instance a serial console would not allow to set toggle keys. In this case do not expect the function to check its arguments. It will typically directly return EFI_UNSUPPORTED. Signed-off-by: Heinrich

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 6/22]: MdePkg/BaseCacheMaintenanceLib: RISC-V cache maintenance implementation.

2019-09-04 Thread Leif Lindholm
On Wed, Sep 04, 2019 at 06:43:01PM +0800, Abner Chang wrote: > Implement RISC-V cache maintenance functions in BaseCacheMaintenanceLib. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Abner Chang > --- > .../BaseCacheMaintenanceLib.inf| 4 + >

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 04/22]: MdePkg/Include: RISC-V definitions.

2019-09-04 Thread Leif Lindholm
On Wed, Sep 04, 2019 at 06:42:59PM +0800, Abner Chang wrote: > Add RISC-V processor related definitions. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Abner Chang > --- > MdePkg/Include/IndustryStandard/PeImage.h | 14 +- > MdePkg/Include/Library/BaseLib.h

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 03/22]: MdePkg: RISC-V sections in DEC file.

2019-09-04 Thread Leif Lindholm
On Wed, Sep 04, 2019 at 06:42:58PM +0800, Abner Chang wrote: > Add RISC-V sections in MdePkg.dec. This can be included whenever the respective include directories are created. > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Abner Chang > --- > MdePkg/MdePkg.dec | 9

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 02/22]: RiscVPkg/Include: Add header files of RISC-V CPU package

2019-09-04 Thread Leif Lindholm
On Wed, Sep 04, 2019 at 06:42:57PM +0800, Abner Chang wrote: > RISC-V package library definitions. > > RiscV.h > -Add RiscV.h which conform with RISC-V Privilege Spec v1.10. > > sbi.h > sbi_bits.h > sbi_types.h > - Add definitions for RISC-V OpenSBI EDK2 port. A web search suggests this refers

Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg/NvmExpressDxe: Allow other NSIDs for Admin commands

2019-09-04 Thread Tyler J Erickson via Groups.Io
Hi Hao, I tried making both the NamespaceID and NSID values the same when calling the passthru function for these admin commands and it didn't work. I think that is due to another place in the passthru code filtering the NamespaceId input values on line 517-520. The NamespaceId parameter is being

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Race condition between APHandler's release of Busy spinlock and user-triggered SmmStartupThisAP's

2019-09-04 Thread Rusocki, Krzysztof
From: Ni, Ray Sent: Tuesday, September 3, 2019 6:56 PM > 1. can we directly call AcquireSpinLock()? *OrFail() can be removed IMO. > 2. It's a patch to change the behavior of SmmStartupThisAP(). So that to > reduce the potential bugs in caller's code. Patch title is a bit mis-leading. The way I

Re: [edk2-devel] [PATCH V2] ShellPkg/UefiHandleParsingLib: Fix incorrect reallocate pool

2019-09-04 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gao, Zhichao > Sent: Monday, September 2, 2019 1:51 AM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Carsey, Jaben ; Ni, Ray ; > Andrew Fish > Subject: RE: [edk2-devel] [PATCH V2] ShellPkg/UefiHandleParsingLib: Fix > incorrect

Re: [edk2-devel] [PATCH] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Ni, Ray
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, Chasel > Sent: Wednesday, September 4, 2019 1:56 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject: [edk2-devel] [PATCH] UefiCpuPkg: support single > EFI_PEI_CORE_FV_LOCATION_PPI in

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package.

2019-09-04 Thread Leif Lindholm
Hi Abner, On Wed, Sep 04, 2019 at 06:42:56PM +0800, Abner Chang wrote: > - Add RiscVPkg package which provides RISC-V processor related drivers and > libraries. > - Support RISC-V OpenSBI and RISC-V platforms > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Abner

Re: [edk2-devel] [patch 1/3] EmbeddedPkg: Unload image on EFI_SECURITY_VIOLATION

2019-09-04 Thread Ard Biesheuvel
On Wed, 4 Sep 2019 at 01:26, Dandan Bi wrote: > > For the LoadImage() boot service, with EFI_SECURITY_VIOLATION retval, > the Image was loaded and an ImageHandle was created with a valid > EFI_LOADED_IMAGE_PROTOCOL, but the image can not be started right now. > This follows UEFI Spec. > > But if

Re: [edk2-devel] [PATCH] ShellPkg/ShellPkg.dsc AARCH64: enable stack protector

2019-09-04 Thread Leif Lindholm
On Wed, Sep 04, 2019 at 09:34:34AM -0700, Ard Biesheuvel wrote: > Incorporate the stack protector library into the AARCH64 build of > the Shell binaries as a NULL library resolution, to avoid build > errors when the compiler injects stack integrity checks. > > Signed-off-by: Ard Biesheuvel

[edk2-devel] [PATCH] ShellPkg/ShellPkg.dsc AARCH64: enable stack protector

2019-09-04 Thread Ard Biesheuvel
Incorporate the stack protector library into the AARCH64 build of the Shell binaries as a NULL library resolution, to avoid build errors when the compiler injects stack integrity checks. Signed-off-by: Ard Biesheuvel --- ShellPkg/ShellPkg.dsc | 5 + 1 file changed, 1 insertion(+), 4

Re: [edk2-devel] [PATCH] BaseTools/GenFw AARCH64: fix up GOT based relative relocations

2019-09-04 Thread Ard Biesheuvel
On Wed, 4 Sep 2019 at 08:37, Leif Lindholm wrote: > > On Wed, Sep 04, 2019 at 05:01:58AM -0700, Ard Biesheuvel wrote: > > On Wed, 4 Sep 2019 at 04:49, Leif Lindholm wrote: > > > > > > On Tue, Sep 03, 2019 at 09:17:33PM -0700, Ard Biesheuvel wrote: > > > > We take great care to avoid GOT based

[edk2-devel] [edk2-platforms] [PATCH v2] ClevoOpenBoardPkg: Fix GCC5 build issue

2019-09-04 Thread Agyeman, Prince
From: Agyeman Fixed GPIO table missing curly brackets Cc: Ankit Sinha Cc: Nate DeSimone Cc: Michael Kubacki Cc: Chasel Chiu CC: Dandan Bi Signed-off-by: Agyeman --- .../N1xxWU/Library/BoardInitLib/N1xxWUGpioTable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [edk2-devel] [PATCH] BaseTools/GenFw AARCH64: fix up GOT based relative relocations

2019-09-04 Thread Leif Lindholm
On Wed, Sep 04, 2019 at 05:01:58AM -0700, Ard Biesheuvel wrote: > On Wed, 4 Sep 2019 at 04:49, Leif Lindholm wrote: > > > > On Tue, Sep 03, 2019 at 09:17:33PM -0700, Ard Biesheuvel wrote: > > > We take great care to avoid GOT based relocations in EDK2 executables, > > > primarily because they are

Re: [edk2-devel] [PATCH] UefiCpuPkg: support single EFI_PEI_CORE_FV_LOCATION_PPI in PpiList

2019-09-04 Thread Dong, Eric
Hi Chasel, Thanks for your quick fix. Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chiu, > Chasel > Sent: Wednesday, September 4, 2019 4:56 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ;

Re: [edk2-devel] [PATCH] BaseTools/GenFw AARCH64: fix up GOT based relative relocations

2019-09-04 Thread Liming Gao
Ack-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard > Biesheuvel > Sent: Wednesday, September 4, 2019 10:22 PM > To: Leif Lindholm > Cc: edk2-devel-groups-io ; Gao, Liming > > Subject: Re: [edk2-devel] [PATCH]

Re: [edk2-devel] [edk2-staging/RISC-V PATCH v1 1/14]: BaseTools: Update EDK2 build tool for RISC-V platform

2019-09-04 Thread Jonathan Cameron
On Wed, 4 Sep 2019 11:18:40 + Abner Chang wrote: > Hi Jonathan, I created a new branch "RISC-V-V2" on edk2-staging which is > based on most recent EDK2 master and sent the patches based on it. > This is easier for reviewers to review the changes for RISC-V EDK2 port. The > original

Re: [edk2-devel] [PATCH] BaseTools/GenFw AARCH64: fix up GOT based relative relocations

2019-09-04 Thread Ard Biesheuvel
On Wed, 4 Sep 2019 at 05:01, Ard Biesheuvel wrote: > > On Wed, 4 Sep 2019 at 04:49, Leif Lindholm wrote: > > > > On Tue, Sep 03, 2019 at 09:17:33PM -0700, Ard Biesheuvel wrote: > > > We take great care to avoid GOT based relocations in EDK2 executables, > > > primarily because they are pointless

Re: [edk2-devel] [PATCH] ArmVirtPkg/PlatformBootManagerLib: unload image on EFI_SECURITY_VIOLATION

2019-09-04 Thread Philippe Mathieu-Daudé
On 9/3/19 6:38 PM, Laszlo Ersek wrote: > The LoadImage() boot service is a bit unusual in that it allocates > resources in a particular failure case; namely, it produces a valid > "ImageHandle" when it returns EFI_SECURITY_VIOLATION. This is supposed to > happen e.g. when Secure Boot verification

Re: [edk2-devel] [PATCH v3 1/1] MdePkg: UefiLib: Add a function to check if a language is supported

2019-09-04 Thread Liming Gao
Tom: Thanks for your update function header with RFC 4646 Languages. Please remove function name CompareIso639LanguageCode() in function header. Because this API is UefiLib internal function, It is not defined in UefiLib.h. With this update, Reviewed-by: Liming Gao Thanks Liming >

Re: [edk2-devel] [PATCH 1/1] Platform: Intel: Update licenses to SPDX and update clock settings

2019-09-04 Thread Ard Biesheuvel
On Tue, 3 Sep 2019 at 22:36, wrote: > > From: "Tien Hock, Loh" > > Update all license to SPDX. Also update UART clock to be calculated instead > of hardcoded, removed some unused packages, and updated maintainers. > Please split this into 4 patches > Signed-off-by: "Tien Hock, Loh" >

Re: [edk2-devel] [PATCH v2] OvmfPkg/EnrollDefaultKeys: clean up Base64Decode() retval handling

2019-09-04 Thread Ard Biesheuvel
On Wed, 4 Sep 2019 at 00:52, Laszlo Ersek wrote: > > Since commit 35e242b698cd ("MdePkg/BaseLib: rewrite Base64Decode()", > 2019-07-16), Base64Decode() guarantees that DestinationSize is larger on > output than it was on input if RETURN_BUFFER_TOO_SMALL is returned. Clean > up the retval handling

[edk2-devel] [edk2-platforms PATCH 0/2] Platform/RPi3: PlatformSmbios improvements

2019-09-04 Thread Pete Batard
This series of patches improves the data reported by the firmware for SMB queries. This is achieved by first introducing new calls in RpiFirmwareDxe and then cleaning up the existing PlatformSmbiosDxe code. These modifications should ensure that the drivers can be reused on other Raspberry Pi

[edk2-devel] [edk2-platforms PATCH 2/2] Platform/RPi3: Improve the population of PlatformSmbiosDxe elements

2019-09-04 Thread Pete Batard
This patch cleans up the population SMBIOS entries by removing elements that we don't have data for, as well as properly filling the ones for which we do, through the newly added queries from RpiFirmwareDxe. String parsing code is also added to BIOSInfoUpdateSmbiosType0() so that any numeric

[edk2-devel] [edk2-platforms PATCH 1/2] Platform/RPi3: Add more query functions in RpiFirmwareDxe

2019-09-04 Thread Pete Batard
This patch introduces the capability to also query the Model Name/ Manufacturer Name/CPU Name/Firmware Revision using the RpiFirmware protocol. This is aims at making the driver more suitable to cater for platforms other than the Raspberry Pi 3 as well as simplifying the population of entries in

Re: [edk2-devel] [PATCH] MinPlatformPkg/SecFspWrapperPlatformSecLib: Change TopOfTemporaryRam type

2019-09-04 Thread Chiu, Chasel
Hi Shenglei, Would you please elaborate a little on how casting to UINTN can resolve the overflow scenario and why 64bits OS will affect this code? Thanks! Chasel > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, > Shenglei > Sent: Monday, September 2, 2019 8:35

Re: [edk2-devel] [PATCH] BaseTools/GenFw AARCH64: fix up GOT based relative relocations

2019-09-04 Thread Ard Biesheuvel
On Wed, 4 Sep 2019 at 04:49, Leif Lindholm wrote: > > On Tue, Sep 03, 2019 at 09:17:33PM -0700, Ard Biesheuvel wrote: > > We take great care to avoid GOT based relocations in EDK2 executables, > > primarily because they are pointless - we don't care about things like > > the CoW footprint or

Re: [edk2-devel] [PATCH] BaseTools/GenFw AARCH64: fix up GOT based relative relocations

2019-09-04 Thread Leif Lindholm
On Tue, Sep 03, 2019 at 09:17:33PM -0700, Ard Biesheuvel wrote: > We take great care to avoid GOT based relocations in EDK2 executables, > primarily because they are pointless - we don't care about things like > the CoW footprint or relocations that target read-only sections, and so > GOT entries

Re: [edk2-devel] [edk2-platforms] [PATCH] ClevoOpenBoardPkg: Fix GCC5 build issue

2019-09-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Agyeman, > Prince > Sent: Wednesday, September 4, 2019 2:18 AM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Sinha, Ankit > ; Desimone, Nathaniel L > ; Kubacki, Michael A > ; Chiu, Chasel ;

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Remove unneeded MdeModulePkg dependency

2019-09-04 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, September 4, 2019 2:18 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [edk2-devel] [PATCH] IntelFsp2WrapperPkg:

Re: [edk2-devel] [edk2-staging/RISC-V PATCH v1 1/14]: BaseTools: Update EDK2 build tool for RISC-V platform

2019-09-04 Thread Abner Chang
Hi Jonathan, I created a new branch "RISC-V-V2" on edk2-staging which is based on most recent EDK2 master and sent the patches based on it. This is easier for reviewers to review the changes for RISC-V EDK2 port. The original "RISC-V" branch has some stale implementation and may confuse people.

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 22/22]: BaseTools/Scripts

2019-09-04 Thread Abner Chang
Add RISC-V specific LD scripts. ."rela(INFO)" in the latest GccBase.lds causes PE32 relocation error. This is the temporaty solution untill we find the root casue. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- BaseTools/Scripts/GccBaseRiscV.lds | 71

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 07/22]: MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions.

2019-09-04 Thread Abner Chang
RISC-V MMIO library instance. RISC-V only supports memory map I/O. However the first implementation of RISC-V EDK2 port uses PC/AT as the RISC-V platform spec. We have to keep the I/O functions as the temporary solution. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by:

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 21/22]: NetworkPkg

2019-09-04 Thread Abner Chang
Add RISCV64 Arch. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- NetworkPkg/Network.dsc.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/Network.dsc.inc b/NetworkPkg/Network.dsc.inc index c7f4328..b484f9b 100644 ---

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 15/22]: RiscVPkg/RealTimeClockRuntimeDxe: Add RISC-V RTC Runtime Driver

2019-09-04 Thread Abner Chang
This is the abstract driver which incorporate with platform level RTC library (RealTimeClockLib) to provide Real Time Clock Architecture Protocol. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- .../RealTimeClockRuntimeDxe/RealTimeClock.c| 157

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 09/22]: MdePkg/BaseCpuLib: RISC-V Base CPU library implementation.

2019-09-04 Thread Abner Chang
Implement RISC-V CPU related functions in BaseCpuLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 4 MdePkg/Library/BaseCpuLib/RiscV/Cpu.s| 25 + 2 files changed, 29

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 19/22]: MdeModulePkg/DxeIplPeim:RISC-V platform DXEIPL.

2019-09-04 Thread Abner Chang
- Implement RISC-V DxeIpl. - Provide DxeIpl platform implementation-specifc library for RISC-V platform. Two libraries are provided in this commit, * Defualt library which simply switch stack and transfer control to DXE core. * Switch stack, privilege mode and then transfer control to

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 05/22]: MdeModulePkg/CapsuleRuntimeDxe: Add RISC-V arch.

2019-09-04 Thread Abner Chang
Add RISC-V in INF for building CapsuleRuntimeDxe RISC-V image. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- MdeModulePkg/Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 17/22]: RiscVPkg/SmbiosDxe: RISC-V platform generic SMBIOS DXE driver

2019-09-04 Thread Abner Chang
RISC-V generic SMBIOS DXE driver for building up SMBIOS type 4, type 7 and type 44 records. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- RiscVPkg/Universal/SmbiosDxe/RiscVSmbiosDxe.c | 343 +

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 03/22]: MdePkg: RISC-V sections in DEC file.

2019-09-04 Thread Abner Chang
Add RISC-V sections in MdePkg.dec. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- MdePkg/MdePkg.dec | 9 + 1 file changed, 9 insertions(+) diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index 3fd7d16..9673c3c 100644 --- a/MdePkg/MdePkg.dec

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 13/22]: MdePkg/Include: Update SmBios header file.

2019-09-04 Thread Abner Chang
Update SmBios header file to conform with SMBIOS v3.3.0. The major update is to add definitions of SMBIOS Type 44h record. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- MdePkg/Include/IndustryStandard/SmBios.h | 74 +++- 1

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 01/22]: RiscVPkg: RISC-V processor package.

2019-09-04 Thread Abner Chang
- Add RiscVPkg package which provides RISC-V processor related drivers and libraries. - Support RISC-V OpenSBI and RISC-V platforms Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- RiscVPkg/RiscVPkg.dec | 57

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 11/22]: BaseTools: BaseTools changes for RISC-V platform.

2019-09-04 Thread Abner Chang
BaseTools changes for building EDK2 RISC-V platform. The changes made to build_rule.template is to avoid build errors cause by GCC711RISCV tool chain. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- BaseTools/Conf/build_rule.template |

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 18/22]: RiscVPkg/Library: Add/Update/Remove Library instances for RISC-V platform

2019-09-04 Thread Abner Chang
RiscVCpuLib: Add RISC-V CPU Library. - This library provides CSR assembly functions to read/write RISC-V specific Control and Status registers. RiscVDxeIplHandoffLib RiscVDxeIplHandoffOpenSbiLib - Provide DxeIpl platform implementation-specifc library for RISC-V platform. Two libraries are

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 16/22]: RiscVPkg/CpuDxe: Add RISC-V CPU DXE driver.

2019-09-04 Thread Abner Chang
The driver produces RISC-V EFI_CPU_ARCH_PROTOCOL and use RISC-V platform level timer library Due to RISC-V timer CSR is platform implementation specific, RISC-V CPU DXE driver invokes platform level timer library to access to timer CSRs. Contributed-under: TianoCore Contribution Agreement 1.0

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 20/22]: MdeModulePkg/Logo

2019-09-04 Thread Abner Chang
Add RISCV64 Arch. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- MdeModulePkg/Logo/Logo.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Logo/Logo.inf b/MdeModulePkg/Logo/Logo.inf index 0182025..243748c 100644 ---

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 14/22]: RiscVPkg/opesbi: Add opensbi-HOWTO.txt

2019-09-04 Thread Abner Chang
Add opensbi-HOWTO.txt for users to build RISC-V platform with RISC-V OpenSBI library. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- RiscVPkg/opensbi/opensbi-HOWTO.txt | 17 + 1 file changed, 17 insertions(+) create mode 100644

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 12/22]: MdePkg/BaseLib: BaseLib for RISC-V RV64 Processor.

2019-09-04 Thread Abner Chang
Add RISC-V processor binding and RISC-V processor specific definitions and macros. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- MdePkg/Library/BaseLib/BaseLib.inf | 18 +- MdePkg/Library/BaseLib/RiscV64/CpuBreakpoint.c | 33 ++

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 02/22]: RiscVPkg/Include: Add header files of RISC-V CPU package

2019-09-04 Thread Abner Chang
RISC-V package library definitions. RiscV.h -Add RiscV.h which conform with RISC-V Privilege Spec v1.10. sbi.h sbi_bits.h sbi_types.h - Add definitions for RISC-V OpenSBI EDK2 port. RealTimeClockLib.h - Header file of platform level Real Time Clock library. SbiFirmwareContext.h - Header file

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 08/22]: MdePkg/BasePeCoff: Add RISC-V PE/Coff related code.

2019-09-04 Thread Abner Chang
Support RISC-V image relocation. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 3 +- MdePkg/Library/BasePeCoffLib/BasePeCoffLib.inf | 5 + MdePkg/Library/BasePeCoffLib/BasePeCoffLib.uni |

[edk2-devel] [PATCH 00/22] RISC-V EDK2 Port on edk2-staging/RISC-V-V2 branch

2019-09-04 Thread Abner Chang
This branch "RISC-V-V2" is used to contribute RISC-V architecture on EDK2. Compare to the old branch "RISC-V", this branch "RISC-V-V2" is created based on the most recent edk2/master @37eef910. This is easier for reviewers to have clear ideas of edk2 code changes for RISC-V EDK2 implementation.

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 10/22]: MdePkg/BaseSynchronizationLib: RISC-V cache related code.

2019-09-04 Thread Abner Chang
Support RISC-V cache related functions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- .../BaseSynchronizationLib.inf | 6 + .../RiscV64/Synchronization.c | 189 +

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 6/22]: MdePkg/BaseCacheMaintenanceLib: RISC-V cache maintenance implementation.

2019-09-04 Thread Abner Chang
Implement RISC-V cache maintenance functions in BaseCacheMaintenanceLib. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- .../BaseCacheMaintenanceLib.inf| 4 + .../Library/BaseCacheMaintenanceLib/RiscVCache.c | 242

[edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 04/22]: MdePkg/Include: RISC-V definitions.

2019-09-04 Thread Abner Chang
Add RISC-V processor related definitions. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Abner Chang --- MdePkg/Include/IndustryStandard/PeImage.h | 14 +- MdePkg/Include/Library/BaseLib.h | 67 ++ MdePkg/Include/Protocol/DebugSupport.h| 55 +

[edk2-devel] [PATCH] BaseTools:ECC need to handle lower case 'static'

2019-09-04 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1778 We are going to add keyword (lower case) 'static' for functions and global variables which are not referenced outside their current C file. However, the ECC tool only recognizes upper case 'STATIC' at this moment. This will lead to issue

Re: [Qemu-devel] [edk2-rfc] [edk2-devel] CPU hotplug using SMM with QEMU+OVMF

2019-09-04 Thread Igor Mammedov
On Tue, 3 Sep 2019 19:20:25 +0200 Laszlo Ersek wrote: > On 09/03/19 16:53, Igor Mammedov wrote: > > On Mon, 2 Sep 2019 21:09:58 +0200 > > Laszlo Ersek wrote: > > > >> On 09/02/19 10:45, Igor Mammedov wrote: > >>> On Fri, 30 Aug 2019 20:46:14 +0200 > >>> Laszlo Ersek wrote: > >>> >

Re: [edk2-devel] [edk2] [Patch 32/33] BaseTools: ECC tool Python3 adaption

2019-09-04 Thread Leif Lindholm
Hi Bob, On Wed, Sep 04, 2019 at 09:12:30AM +, Feng, Bob C wrote: > The CLexer.py and CParser.py under CParser3 were generated with > antlr3.0.1 > (https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool) . I > think API version error may be due to antlr-python-runtime on > Debian has

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: SNP Statistics may be unsupported

2019-09-04 Thread Heinrich Schuchardt
If EFI_SIMPLE_NETWORK.Statistics() is not supported, it will return EFI_UNSUPPORTED. In this case do not expect input parameters to be checked for conformance. Signed-off-by: Heinrich Schuchardt --- .../SimpleNetworkBBTestConformance.c | 112 +++--- 1 file changed, 72

Re: [edk2-devel] [edk2] [Patch 32/33] BaseTools: ECC tool Python3 adaption

2019-09-04 Thread Bob Feng
Hi Leif, The CLexer.py and CParser.py under CParser3 were generated with antlr3.0.1 (https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool) . I think API version error may be due to antlr-python-runtime on Debian has different version. What's the antlr-python-runtime on Debian?

  1   2   >