[edk2-devel] [PATCH V2 1/9] MdeModulePkg/Variable: Consolidate common parsing functions

2019-09-27 Thread Kubacki, Michael A
This change moves the following functions into a dedicated file so they may be used in other variable files as needed. Furthermore, it reduces the overall size of the common Variable.c file. * DataSizeOfVariable () * FindVariableEx () * GetEndPointer () * GetNextVariablePtr () *

[edk2-devel] [PATCH V2 5/9] MdeModulePkg/Variable: Add a file for NV variable functions

2019-09-27 Thread Kubacki, Michael A
This change adds a dedicated file for variable operations specific to non-volatile variables. This decreases the overall length of the relatively large Variable.c file. Cc: Dandan Bi Cc: Ard Biesheuvel Cc: Eric Dong Cc: Laszlo Ersek Cc: Liming Gao Cc: Michael D Kinney Cc: Ray Ni Cc: Jian J

[edk2-devel] [PATCH V2 9/9] MdeModulePkg/VariableSmm: Remove unused SMI handler functions

2019-09-27 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220 Since Runtime Services GetVariable() and GetNextVariableName() no longer trigger a SW SMI, this change removes the code for handling those requests from VariableSmm.c. The following SMM communicate functions are removed from

[edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-09-27 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220 This change reduces SMIs for GetVariable () by maintaining a UEFI variable cache in Runtime DXE in addition to the pre- existing cache in SMRAM. When the Runtime Service GetVariable() is invoked, a Runtime DXE cache is used instead of

[edk2-devel] [PATCH V2 3/9] MdeModulePkg/Variable: Parameterize VARIABLE_INFO_ENTRY buffer

2019-09-27 Thread Kubacki, Michael A
UpdateVariableInfo () currently accepts parameters regarding updates to be made to a global variable of type VARIABLE_INFO_ENTRY. This change passes the structure by pointer to UpdateVariableInfo () so structures can be updated outside the fixed global variable. Cc: Dandan Bi Cc: Ard Biesheuvel

[edk2-devel] [PATCH V2 0/9] UEFI Variable SMI Reduction

2019-09-27 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220 V2 Changes: Patch #1 in V1 both moved functions to VariableParsing.c and modified some functionality in those functions. In V2, the functions are first moved and then functionality is modified in subsequent patches. This resulted in the

[edk2-devel] [PATCH V2 2/9] MdeModulePkg/Variable: Parameterize GetNextVariableEx() store list

2019-09-27 Thread Kubacki, Michael A
The majority of logic related to GetNextVariableName () is currently implemented in VariableServiceGetNextVariableInternal (). The list of variable stores to search for the given variable name and variable GUID is defined in the function body. This change renames the function to GetNextVariableEx

[edk2-devel] [PATCH V2 6/9] MdeModulePkg VariableInfo: Always consider RT DXE and SMM stats

2019-09-27 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220 The current VariableInfo application only checks for variable statistics from SMM if the variable information entries are not present in the UEFI System Configuration table as published by the DXE UEFI variable driver (VariableRuntimeDxe).

[edk2-devel] [PATCH V2 8/9] MdeModulePkg/Variable: Add RT GetNextVariableName() cache support

2019-09-27 Thread Kubacki, Michael A
https://bugzilla.tianocore.org/show_bug.cgi?id=2220 This change implements the Runtime Service GetNextVariableName() using the Runtime Cache in VariableSmmRuntimeDxe. Runtime Service calls to GetNextVariableName() will no longer trigger a SW SMI. Overall system performance and stability will be

[edk2-devel] [PATCH V2 4/9] MdeModulePkg/Variable: Add local auth status in VariableParsing

2019-09-27 Thread Kubacki, Michael A
The file VariableParsing.c provides generic functionality related to parsing variable related structures and information. In order to calculate offsets for certain operations, the functions must know if authenticated variables are enabled as this increases the size of variable headers. This

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements

2019-09-27 Thread Pete Batard
Try this after making sure that you have edk2/, edk2-platforms/ and edk-non-osi/ in /home/phil/source: cd /home/phil/source export GCC5_AARCH64_PREFIX=aarch64-linux-gnu- export WORKSPACE=$PWD export PACKAGES_PATH=$WORKSPACE/edk2:$WORKSPACE/edk2-platforms:$WORKSPACE/edk2-non-osi source

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements

2019-09-27 Thread Philippe Mathieu-Daudé
On 9/27/19 7:49 PM, Leif Lindholm wrote: > On Fri, Sep 27, 2019 at 06:38:07PM +0200, Philippe Mathieu-Daudé wrote: >> Hi Pete, >> >> On 9/27/19 11:20 AM, Pete Batard wrote: >>> From: Andrei Warkentin >>> >>> The Pi GPU decouples requested resolution from actual physical resolution >>> and can

Re: [edk2-devel] [edk2-platforms PATCH 2/2] Platform/RPi3: Improve the population of PlatformSmbiosDxe elements

2019-09-27 Thread Leif Lindholm
On Wed, Sep 04, 2019 at 01:14:18PM +0100, Pete Batard wrote: > This patch cleans up the population SMBIOS entries by removing elements > that we don't have data for, as well as properly filling the ones for > which we do, through the newly added queries from RpiFirmwareDxe. > > String parsing

[edk2-devel] Edk2 SmbusHc Protocol

2019-09-27 Thread MinhQuan Tran
Hi, I am trying to write to a device on the SMBus using the SmbusHc Protocol and would like to understand what happens behind the "EfiSmbusWriteBlock". Where can I find the definition for this? Thank you, Minh Quan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

Re: [edk2-devel] [edk2-platforms PATCH 1/2] Platform/RPi3: Add more query functions in RpiFirmwareDxe

2019-09-27 Thread Leif Lindholm
On Wed, Sep 04, 2019 at 01:14:17PM +0100, Pete Batard wrote: > This patch introduces the capability to also query the Model Name/ > Manufacturer Name/CPU Name/Firmware Revision using the RpiFirmware > protocol. This is aims at making the driver more suitable to cater > for platforms other than the

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements

2019-09-27 Thread Pete Batard
Hi Philippe, On 2019.09.27 17:38, Philippe Mathieu-Daudé wrote: Hi Pete, On 9/27/19 11:20 AM, Pete Batard wrote: From: Andrei Warkentin The Pi GPU decouples requested resolution from actual physical resolution and can perform scaling of virtual resolutions. This enables platform users to do

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements

2019-09-27 Thread Leif Lindholm
On Fri, Sep 27, 2019 at 06:38:07PM +0200, Philippe Mathieu-Daudé wrote: > Hi Pete, > > On 9/27/19 11:20 AM, Pete Batard wrote: > > From: Andrei Warkentin > > > > The Pi GPU decouples requested resolution from actual physical resolution > > and can perform scaling of virtual resolutions. This

Re: [edk2-devel] [PATCH V1 1/5] MdeModulePkg/Variable: Consolidate common parsing functions

2019-09-27 Thread Kubacki, Michael A
Hi Hao, Thanks for the feedback. I left my replies inline. Thanks, Michael > -Original Message- > From: Wu, Hao A > Sent: Friday, September 27, 2019 1:18 AM > To: devel@edk2.groups.io; Kubacki, Michael A > > Cc: Bi, Dandan ; Ard Biesheuvel > ; Dong, Eric ; Laszlo Ersek > ; Gao, Liming

Re: [edk2-devel] [edk2-platforms: PATCH 0/2] Armada 7k8k SPI flash driver improvements

2019-09-27 Thread Patryk Duda
Hi, Do you have any remarks to the patchset? Best regards, Patryk wt., 10 wrz 2019 o 08:23 Marcin Wojtas napisał(a): > pon., 9 wrz 2019 o 17:52 Patryk Duda napisał(a): > > > > Hi, > > > > This patchset contains progress bar implementation for MvSpiFlash driver > and > > small fix in

Re: [edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: MvPhyDxe: Fill MdioIndex field in PhyDev

2019-09-27 Thread Patryk Duda
Hi, Do you have any remarks to this patch? Best Regards, Patryk wt., 10 wrz 2019 o 08:24 Marcin Wojtas napisał(a): > pon., 9 wrz 2019 o 17:53 Patryk Duda napisał(a): > > > > This patch fixes missing MdioIndex copying during initialization. > > This bug appeared as inability to communicate

Re: [edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements

2019-09-27 Thread Philippe Mathieu-Daudé
Hi Pete, On 9/27/19 11:20 AM, Pete Batard wrote: > From: Andrei Warkentin > > The Pi GPU decouples requested resolution from actual physical resolution > and can perform scaling of virtual resolutions. This enables platform users > to do something like ask for 1024x768 and get a framebuffer of

[edk2-devel] [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Use new enums for SD card initialization

2019-09-27 Thread Marcin Wojtas
MdeModulePkg/SdMmcHcDxe update to use rev 3 of SdMmcOverrideProtocol reworked SD card initialization and added new enums describing lower speeds. Include this in XenonDxe, which fixes Armada70x0Db SD interface. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.c

Re: [edk2-devel] [PATCH 0/1] Fix eMMC bus timing switch issue

2019-09-27 Thread Marcin Wojtas
Thanks! Everything keep working on my boards: Tested-by: Marcin Wojtas Best regards, Marcin pt., 27 wrz 2019 o 03:38 Wu, Hao A napisał(a): > Hello Marcin, > > > > I have uploaded the V2 series to my fork. > > You can get the patch at: > > https://github.com/hwu25/edk2/tree/emmc_busmode_v2 >

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix the lib order in static_library_files.lst

2019-09-27 Thread dann frazier
On Fri, Sep 27, 2019 at 5:35 AM Feng, Bob C wrote: > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2216 > > This patch is going to fix the lib order in static_library_files.lst. > This issue is introduced by commit 673d09a2dd. > Before 673d09a2dd, build tool apply build rule for the

Re: [edk2-devel] [PATCH wave 1 00/10] support QEMU's "SMRAM at default SMBASE" feature

2019-09-27 Thread Igor Mammedov
On Tue, 24 Sep 2019 13:34:55 +0200 "Laszlo Ersek" wrote: > Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=1512 > Repo: https://github.com/lersek/edk2.git > Branch: smram_at_default_smbase_bz_1512_wave_1 > > This is the firmware-side patch series for the QEMU feature that Igor is >

[edk2-devel] [Patch 1/1] BaseTools: Fix the lib order in static_library_files.lst

2019-09-27 Thread Bob Feng
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2216 This patch is going to fix the lib order in static_library_files.lst. This issue is introduced by commit 673d09a2dd. Before 673d09a2dd, build tool apply build rule for the module's library firstly and then apply build rule for module

Re: [edk2-devel] [Patch 03/12] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

2019-09-27 Thread Philippe Mathieu-Daudé
On 9/27/19 9:46 AM, Liming Gao wrote: > Signed-off-by: Liming Gao > --- > BaseTools/Source/C/GenFw/GenFw.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/BaseTools/Source/C/GenFw/GenFw.c > b/BaseTools/Source/C/GenFw/GenFw.c > index c99782b78e..d8d3360c24

Re: [edk2-devel] [Patch 02/12] BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image

2019-09-27 Thread Philippe Mathieu-Daudé
Hi Liming, On 9/27/19 9:46 AM, Liming Gao wrote: > Signed-off-by: Liming Gao > --- > BaseTools/Conf/build_rule.template | 26 +-- > BaseTools/Conf/tools_def.template | 102 > + > 2 files changed, 118 insertions(+), 10

Re: [edk2-devel] [PATCH 1/1] BaseTools: use stdint.h for GCC ProcessorBind.h typedefs

2019-09-27 Thread Philippe Mathieu-Daudé
On 9/26/19 9:28 PM, Leif Lindholm wrote: > The AArch64 definitions of UINT64/INT64 differ from the X64 ones. > Since this is on the tool side, doing like X64 and picking the > definitions from stdint.h feels like a better idea than hardcoding > them. So copy the pattern from X64/ProcesorBind.h.

Re: [edk2-devel] [Patch 1/1] BaseTools: Fix a bug of genffs command generation

2019-09-27 Thread Philippe Mathieu-Daudé
On 9/27/19 4:30 AM, Bob Feng wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2221 > > The command used by multiple thread genffs feature in makefile > for testing if file exist is generated based on the toolchain family. > It should be based on the OS type. > > Cc: Liming Gao >

Re: [edk2-devel] [Patch v2] Maintainers.txt: Move ShellBin maintainers to EDK II Releases section

2019-09-27 Thread Philippe Mathieu-Daudé
On 9/27/19 2:23 AM, Liming Gao wrote: > ShellBinPkg is generated for each edk2 stable tag release. > > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc: Michael D Kinney > Signed-off-by: Liming Gao > --- > In v2, use real URL for edk2 release > Maintainers.txt | 15

[edk2-devel] [edk2-platforms PATCH 1/1] Platforms/RPi3: DisplayDxe virtual resolution improvements

2019-09-27 Thread Pete Batard
From: Andrei Warkentin The Pi GPU decouples requested resolution from actual physical resolution and can perform scaling of virtual resolutions. This enables platform users to do something like ask for 1024x768 and get a framebuffer of that size, regardless of the actual output (which could be a

Re: [edk2-devel] [Patch 09/12] CryptoPkg IntrinsicLib: Make _fltused always be used

2019-09-27 Thread Yao, Jiewen
Hi +int GLOBAL_USED _fltused = 1; May I know what is the use of GLOBAL_USED? Only for compiler stub symbol? If so, why we add __GNUC__ here? Any other usage? +#if defined(__GNUC__) || defined(__clang__) + #define GLOBAL_USED __attribute__((used)) +#else + #define GLOBAL_USED +#endif >

Re: [edk2-devel] [Patch 00/12] New Cross OS tool chain CLANG9

2019-09-27 Thread Yao, Jiewen
Thank you Liming. That is cool feature. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Friday, September 27, 2019 3:46 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Shi, Steven ; > Justen, Jordan L ; Laszlo Ersek > ; Andrew

Re: [edk2-devel] [PATCH V1 1/5] MdeModulePkg/Variable: Consolidate common parsing functions

2019-09-27 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Thursday, September 26, 2019 12:51 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney, > Michael D; Ni, Ray;

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix bus timing switch sequence

2019-09-27 Thread Wu, Hao A
> -Original Message- > From: Albecki, Mateusz > Sent: Thursday, September 26, 2019 9:29 PM > To: Wu, Hao A; devel@edk2.groups.io > Cc: Marcin Wojtas > Subject: RE: [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix bus timing > switch sequence > > > > > -Original Message- > > From: Wu,

Re: [edk2-devel] BaseTools --hash malfunction after migrate from stable201905 to stable201908

2019-09-27 Thread Lin, Derek (HPS SW)
Hi Steven, Thanks for the fix! I've tried your patch with a minor fix as attached. 1            2           3                4 Build Duration:        00:05:51  00:03:47  00:05:15  00:04:31 AutoGen Duration:  00:03:32  00:03:08  00:03:14  00:03:16 Make Duration:       00:01:50  00:00:16  00:01:29 

Re: [edk2-devel] [PATCH 1/1] BaseTools: use stdint.h for GCC ProcessorBind.h typedefs

2019-09-27 Thread Ard Biesheuvel
On Thu, 26 Sep 2019 at 21:28, Leif Lindholm wrote: > > The AArch64 definitions of UINT64/INT64 differ from the X64 ones. > Since this is on the tool side, doing like X64 and picking the > definitions from stdint.h feels like a better idea than hardcoding > them. So copy the pattern from

[edk2-devel] [PATCH v3] MdeModulePkg: Enable/Disable S3BootScript dynamically.

2019-09-27 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2212 In binary model the same binary may have to support both S3 enabled and disabled scenarios, however not all DXE drivers linking PiDxeS3BootScriptLib can return error to invoke library DESTRUCTOR for releasing resource. To support this

Re: [edk2-devel] [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow keys support

2019-09-27 Thread Liming Gao
Push @e86664d2b03d0a84b8b952f3d5111424b3e9c916 >-Original Message- >From: Ni, Ray >Sent: Friday, September 27, 2019 9:12 AM >To: Gao, Zhichao ; devel@edk2.groups.io >Cc: Wang, Jian J ; Wu, Hao A ; >Gao, Liming >Subject: RE: [PATCH V2] MdeModulePkg/TerminalDxe: Enhance the arrow >keys

[edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

2019-09-27 Thread Liming Gao
1. Apply CLANG9 Linker option. 2. Add -mno-mmx -mno-sse compiler option Signed-off-by: Liming Gao --- OvmfPkg/OvmfPkgIa32.dsc| 4 +++- OvmfPkg/OvmfPkgIa32X64.dsc | 4 +++- OvmfPkg/OvmfPkgX64.dsc | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git

[edk2-devel] [Patch 00/12] New Cross OS tool chain CLANG9

2019-09-27 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603 Code: https://github.com/lgao4/edk2/tree/CLANG9 Wiki: https://github.com/lgao4/edk2/wiki/CLANG9-Tools-Chain CLANG9 tool chain is added to directly generate PE/COFF image (EFI image). This tool chain uses LLVM clang C compiler and lld linker,

[edk2-devel] [Patch 02/12] BaseTools tools_def: Add CLANG9 tool chain to directly generate PE image

2019-09-27 Thread Liming Gao
Signed-off-by: Liming Gao --- BaseTools/Conf/build_rule.template | 26 +-- BaseTools/Conf/tools_def.template | 102 + 2 files changed, 118 insertions(+), 10 deletions(-) diff --git a/BaseTools/Conf/build_rule.template

[edk2-devel] [Patch 10/12] EmulatorPkg: Enable CLANG9 tool chain

2019-09-27 Thread Liming Gao
1. Append CLANG CC and LINK flags to generate windows HOST. 2. Modify WinHost to move PCD getting in the late position Signed-off-by: Liming Gao --- EmulatorPkg/Win/Host/WinHost.c | 11 +++ EmulatorPkg/EmulatorPkg.dsc | 8 ++-- EmulatorPkg/EmulatorPkg.fdf | 2 +-

[edk2-devel] [Patch 03/12] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

2019-09-27 Thread Liming Gao
Signed-off-by: Liming Gao --- BaseTools/Source/C/GenFw/GenFw.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/GenFw.c index c99782b78e..d8d3360c24 100644 --- a/BaseTools/Source/C/GenFw/GenFw.c +++

[edk2-devel] [Patch 08/12] CryptoPkg: Append options to make CLANG9 tool chain pass build

2019-09-27 Thread Liming Gao
Disable warning reported from CLANG9. Signed-off-by: Liming Gao --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 + CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 + CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf |

[edk2-devel] [Patch 06/12] MdeModulePkg LzmaCustomDecompressLib: Update macro to be same in CLANG tool

2019-09-27 Thread Liming Gao
Define the same macro in the different OS. It can make CLANG generate the same image in the different host OS. Signed-off-by: Liming Gao --- MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [Patch 12/12] OvmfPkg SecMain: Add build option "-fno-omit-frame-pointer" for CLANG9 X64

2019-09-27 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2024 Signed-off-by: Liming Gao --- OvmfPkg/Sec/SecMain.inf | 4 1 file changed, 4 insertions(+) diff --git a/OvmfPkg/Sec/SecMain.inf b/OvmfPkg/Sec/SecMain.inf index 63ba4cb555..cd765cac25 100644 --- a/OvmfPkg/Sec/SecMain.inf +++

[edk2-devel] [Patch 01/12] BaseTools tools_def.template: Remove unnecessary $(DEST_DIR_DEBUG) path

2019-09-27 Thread Liming Gao
$(DEST_DIR_DEBUG) path is in Include directory. It is not required to be specified again. Signed-off-by: Liming Gao --- BaseTools/Conf/tools_def.template | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/BaseTools/Conf/tools_def.template

[edk2-devel] [Patch 04/12] MdePkg Base.h: Add definition for CLANG9 tool chain

2019-09-27 Thread Liming Gao
CLANG9 tool chain defines __clang__ macro only, doesn't define __GNUC__ macro. But, it uses some same definitions with GCC. So, update base definition for CLANG9 tool chain. Signed-off-by: Liming Gao --- MdePkg/Include/Base.h | 6 +++--- MdePkg/Include/Ia32/ProcessorBind.h | 4

[edk2-devel] [Patch 07/12] MdeModulePkg RegularExpressionDxe: Disable warning for CLANG9 tool chain

2019-09-27 Thread Liming Gao
Signed-off-by: Liming Gao --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf

[edk2-devel] [Patch 09/12] CryptoPkg IntrinsicLib: Make _fltused always be used

2019-09-27 Thread Liming Gao
With this change, global variable _fltused will not be removed by LTO Signed-off-by: Liming Gao --- CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c

[edk2-devel] [Patch 05/12] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-09-27 Thread Liming Gao
__inline__ attribute will make the functions not be exposed as the library interface. It will cause CLANG9 compiler fail. Signed-off-by: Liming Gao --- MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 -- 1 file changed, 6 deletions(-) diff --git

Re: [edk2-devel] [PATCH v2] MdeModulePkg: Enable/Disable S3BootScript dynamically.

2019-09-27 Thread Chiu, Chasel
> -Original Message- > From: Laszlo Ersek > Sent: Thursday, September 26, 2019 9:58 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Wu, Hao A ; Dong, Eric ; > Desimone, Nathaniel L ; Gao, Liming > > Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg: Enable/Disable > S3BootScript

Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Add MediaPresentSupported check

2019-09-27 Thread Eric Jin
Thank you for the confirmation, Heinrich. If no objection, I will commit it 36 hours later. Reviewed-by: Eric Jin -Original Message- From: Heinrich Schuchardt Sent: Friday, September 27, 2019 2:00 PM To: Liu, XianhuiX ; devel@edk2.groups.io Cc: Supreeth Venkatesh ; Jin, Eric

Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Add MediaPresentSupported check

2019-09-27 Thread Heinrich Schuchardt
On 9/27/19 4:01 AM, Liu, XianhuiX wrote: Hi Heinrich, Any concern about it? Thanks. Your patch is correct. It is preceded by: SctPrint (L"\nPlease disconnect the machine from the LAN, press any key within 10 seconds\n"); If MediaPresentSupported is false you cannot detect if the user removed