Evelyn,
Your patch is too big. Can you create separate patches with each addressing one
purpose?
Based on your commit message, I can see at least 4 patches.
Detailed comments:
1. Usually the data structure for HOB is put under header files in
Include/Guid/ directory.
How about
Mike,
I don't think the library needs to cache the boot media type for RT and SMM.
RT and SMM modules can have a module local variable to cache the boot media
type.
It simplifies the implementation of this library and also the platform DSC
because there is no need to choose different library
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Abner Chang
> Sent: Tuesday, October 15, 2019 12:03 PM
> To: devel@edk2.groups.io; leif.lindh...@linaro.org
> Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 10/29]
>
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, October 1, 2019 2:31 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 15/29]
> RiscVPkg/Library: RISC-V CPU
The two library instances work within the constraints of PEI, DXE, Runtime DXE,
and SMM.
I cannot find how a single instance can support all these environments (in as
clean a manner) as
is done with the two instances.
Relevant constraints:
* PEI: Cannot write to global variable
* Runtime DXE /
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Thursday, September 26, 2019 9:40 AM
> To: devel@edk2.groups.io; Agrawal, Sachin
> Cc: Ni, Ray
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThru : Fix UFS
> flag read
Reviewed-by: Ray Ni
Mike,
Thanks for reducing the API.
For the other comments I raised (single library instance usable for PEI and
DXE), do you have any comments?
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 15, 2019 5:26 AM
> To: devel@edk2.groups.io
>
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, October 1, 2019 4:04 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 18/29]
> RiscVPkg/Library: Add EDK2
Hello,
Sorry for the delayed response.
For the PEI changes, I found that when using the function IoMmuFreeBuffer() to
free the first/last unaligned page(s), the below operations related to
'Mapping':
>| Status = mIoMmu->SetAttribute (mIoMmu, Mapping, 0);
>| Status = mIoMmu->Unmap (mIoMmu,
Michael:
I add this feature into edk2-stable2019011 tag planning. Is it ok to you?
Thanks
Liming
>-Original Message-
>From: Kubacki, Michael A
>Sent: Tuesday, October 15, 2019 7:30 AM
>To: devel@edk2.groups.io
>Cc: Bi, Dandan ; Ard Biesheuvel
>; Dong, Eric ; Laszlo Ersek
>; Gao, Liming
With this change, global variable _fltused will not be removed by LTO
Signed-off-by: Liming Gao
---
CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c
Signed-off-by: Liming Gao
---
MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
b/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf
Signed-off-by: Liming Gao
---
BaseTools/Source/C/GenFw/GenFw.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/GenFw.c
index c99782b78e..d8d3360c24 100644
--- a/BaseTools/Source/C/GenFw/GenFw.c
+++
__inline__ has no functional difference effect with the GCC48 / GCC49 / GCC5
toolchains, but it breaks the build with CLANG9. Remove __inline__.
Signed-off-by: Liming Gao
Acked-by: Laszlo Ersek
---
MdePkg/Library/BaseIoLibIntrinsic/IoLibGcc.c | 6 --
1 file changed, 6 deletions(-)
diff
$(DEST_DIR_DEBUG) path is in Include directory.
It is not required to be specified again.
Signed-off-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/BaseTools/Conf/tools_def.template
1. Apply CLANG9 Linker option.
2. Exclude -mno-mmx -mno-sse compiler option for CLANG9
These two options will cause CLANG Linker crush.
Signed-off-by: Liming Gao
Reviewed-by: Laszlo Ersek
---
OvmfPkg/OvmfPkgIa32.dsc| 4 +++-
OvmfPkg/OvmfPkgIa32X64.dsc | 4 +++-
OvmfPkg/OvmfPkgX64.dsc |
Disable warning reported from CLANG9.
Signed-off-by: Liming Gao
---
CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 +
CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 +
CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 +
CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf |
1. Append CLANG CC and LINK flags to generate windows HOST.
2. Modify WinHost to move PCD getting in the late position
Signed-off-by: Liming Gao
---
EmulatorPkg/Win/Host/WinHost.c | 11 +++
EmulatorPkg/EmulatorPkg.dsc | 8 ++--
EmulatorPkg/EmulatorPkg.fdf | 2 +-
Signed-off-by: Liming Gao
---
BaseTools/Conf/build_rule.template | 26 ++
BaseTools/Conf/tools_def.template | 102 +
2 files changed, 118 insertions(+), 10 deletions(-)
diff --git a/BaseTools/Conf/build_rule.template
Define the same macro in the different OS. It can make CLANG generate the same
image in the different host OS.
Signed-off-by: Liming Gao
---
MdeModulePkg/Library/LzmaCustomDecompressLib/Sdk/C/7zTypes.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
In v2, drop patch 12, and update commit message for 5 & 11.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1603
Code: https://github.com/lgao4/edk2/tree/CLANG9
Wiki: https://github.com/lgao4/edk2/wiki/CLANG9-Tools-Chain
CLANG9 tool chain is added to directly generate PE/COFF image (EFI
CLANG9 tool chain defines __clang__ macro only,
doesn't define __GNUC__ macro. But, it uses some same definitions with GCC.
So, update base definition for CLANG9 tool chain.
Signed-off-by: Liming Gao
---
MdePkg/Include/Base.h | 6 +++---
MdePkg/Include/Ia32/ProcessorBind.h | 4
As you know, FitGen is used to generate firmware interface table. This table is
defined in public specification.
Can you let me whether this new entry is defined in the latest FitGen spec?
Thanks
Liming
>-Original Message-
>From: Agrawal, Sachin
>Sent: Tuesday, October 15, 2019 7:24 AM
Update, and push @4d05a4b709ce52d4649698f887a1358246fa4437
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Laszlo Ersek
>Sent: Monday, October 14, 2019 10:45 PM
>To: Gao, Liming ; Pete Batard
>Cc: devel@edk2.groups.io; af...@apple.com
>Subject:
The majority of logic related to GetNextVariableName () is currently
implemented in VariableServiceGetNextVariableInternal (). The list
of variable stores to search for the given variable name and variable
GUID is defined in the function body. This change adds a new parameter
so that the caller
UpdateVariableInfo () currently accepts parameters regarding updates
to be made to a global variable of type VARIABLE_INFO_ENTRY. This
change passes the structure by pointer to UpdateVariableInfo ()
so structures other than the fixed global variable can be updated.
Cc: Dandan Bi
Cc: Ard
This change adds a dedicated file for variable operations specific
to non-volatile variables. This decreases the overall length of the
relatively large Variable.c file.
Cc: Dandan Bi
Cc: Ard Biesheuvel
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Jian J
Sets gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache
to FALSE in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc, and OvmfPkgX64.dsc
so that when SMM_REQUIRE is TRUE, the SMM variable driver will not
use the runtime variable cache.
This is done for OvmfPkg because it currently depends upon a SMM
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
This change reduces SMIs for GetVariable () by maintaining a
UEFI variable cache in Runtime DXE in addition to the pre-
existing cache in SMRAM. When the Runtime Service GetVariable()
is invoked, a Runtime DXE cache is used instead of
This change enables the variable runtime cache by default by setting
gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache in
MdeModulePkg.dec to TRUE.
Cc: Dandan Bi
Cc: Ard Biesheuvel
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Jian J Wang
Cc:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
V4 Changes:
[PATCH V3 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support
* Set gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache to FALSE
by default in MdeModulePkg.dec.
* Added a new patch to set
This change moves the following functions into a dedicated file
so they may be used in other variable files as needed. These are
commonly needed for basic variable data structure parsing
operations. The functions are grouped together in VariableParsing.c
to support cohesiveness for these
https://bugzilla.tianocore.org/show_bug.cgi?id=2220
This change implements the Runtime Service GetNextVariableName()
using the runtime cache in VariableSmmRuntimeDxe. Runtime Service
calls to GetNextVariableName() will no longer trigger a SW SMI
when
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
The current VariableInfo application only checks for variable
statistics from SMM if the variable information entries are
not present in the UEFI System Configuration table as published
by the DXE UEFI variable driver (VariableRuntimeDxe).
REF https://bugzilla.tianocore.org/show_bug.cgi?id=2200
FitGen Tool is responsible for creating FIT table in UEFI BIOS.
A new FIT entry type (FIT Type 0x3) has been allocated for FuSa ACM.
FitGen tool is updated to add support for this FuSa ACM.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by:
Removes the following functions from FirmwareBootMediaLib.h:
* FirmwareBootMediaIsSpi ()
* FirmwareBootMediaIsUfs ()
* FirmwareBootMediaIsEmmc ()
* FirmwareBootMediaIsNvme ()
It is preferred to have a single method to retrieve the firmware
boot media. To reduce overall maintenance effort over
You have a good point with the proposed order for enabling the PCD. I will make
that
update in a V4 later today.
Thanks,
Michael
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Monday, October 14, 2019 11:50 AM
> To: devel@edk2.groups.io; Kubacki,
> On Oct 14, 2019, at 6:11 AM, Laszlo Ersek wrote:
>
> On 10/12/19 08:42, Andrew Fish wrote:
>> Laszlo,
>>
>> For 2) this is very unfortunate. I think the root cause is for those
>> of us who work on x86 hardware day to day we get programed that
>> SEC/PEI is IA32 and DXE is X64, and this
On 10/14/19 20:08, Kubacki, Michael A wrote:
> Sets gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache
> to FALSE in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc, and OvmfPkgX64.dsc
> so that when SMM_REQUIRE is TRUE, the SMM variable driver will not
> use the runtime variable cache.
>
> This is
On 10/14/19 17:03, Pete Batard wrote:
> Changes from previous version:
> - Additional empty comment lines above and below, to keep with existing
> comment
> style
> - Similar logic is applied to ArmVirtPkg/PlatformBootManagerLib, since the
> same
> issue may manifest itself here.
>
> Pete
On Mon, Oct 14, 2019 at 04:47:30PM +, Abner Chang wrote:
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Leif Lindholm
> > Sent: Friday, September 27, 2019 6:57 AM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
Hello Hao,
Were you able to validate the PEI change I sent last week?
Thanks
Ashish
From: Ashish Singhal
Sent: Friday, October 11, 2019 12:07 PM
To: Wu, Hao A ; devel@edk2.groups.io
; Ni, Ray
Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned
NIST 800-193 needs FW Resiliency support. It is to ensure the FW update is
healthy and has a way to roll back to previous version if there was a bad
update. If LSV is changed whenever the update is accomplished (health is not
sure), there will be some difficulties to handle LSV when the update
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2155
Now the test item "EFICompliantTest" will be gen in the XXX.csv.
However, I find most of the SCT user will not know what platform
config they test is, so I think we can independently generate a
file of the "EFICompliantTest" tests, then
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2155
Now the test item "EFICompliantTest" will be gen in the XXX.csv.
However, I find most of the SCT user will not know what platform
config they test is, so I think we can independently generate a
file of the "EFICompliantTest" tests, then
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2155
Now the test item "EFICompliantTest" will be gen in the XXX.csv.
However, I find most of the SCT user will not know what platform
config they test is, so I think we can independently generate a
file of the "EFICompliantTest" tests, then
This change moves the following functions into a dedicated file
so they may be used in other variable files as needed. These are
commonly needed for basic variable data structure parsing
operations. The functions are grouped together in VariableParsing.c
to support cohesiveness for these
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
This change reduces SMIs for GetVariable () by maintaining a
UEFI variable cache in Runtime DXE in addition to the pre-
existing cache in SMRAM. When the Runtime Service GetVariable()
is invoked, a Runtime DXE cache is used instead of
Sets gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache
to FALSE in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc, and OvmfPkgX64.dsc
so that when SMM_REQUIRE is TRUE, the SMM variable driver will not
use the runtime variable cache.
This is done for OvmfPkg because it currently depends upon a SMM
This change adds a dedicated file for variable operations specific
to non-volatile variables. This decreases the overall length of the
relatively large Variable.c file.
Cc: Dandan Bi
Cc: Ard Biesheuvel
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Ray Ni
Cc: Jian J
UpdateVariableInfo () currently accepts parameters regarding updates
to be made to a global variable of type VARIABLE_INFO_ENTRY. This
change passes the structure by pointer to UpdateVariableInfo ()
so structures other than the fixed global variable can be updated.
Cc: Dandan Bi
Cc: Ard
The file VariableParsing.c provides generic functionality related
to parsing variable related structures and information. In order to
calculate offsets for certain operations, the functions must know if
authenticated variables are enabled as this increases the size of
variable headers.
This
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
The current VariableInfo application only checks for variable
statistics from SMM if the variable information entries are
not present in the UEFI System Configuration table as published
by the DXE UEFI variable driver (VariableRuntimeDxe).
The majority of logic related to GetNextVariableName () is currently
implemented in VariableServiceGetNextVariableInternal (). The list
of variable stores to search for the given variable name and variable
GUID is defined in the function body. This change adds a new parameter
so that the caller
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
V3 Changes:
[PATCH V2 1/9] MdeModulePkg/Variable: Consolidate common parsing functions
* Removed GUIDs added to VariableStandaloneMm.inf that are not required.
* Added more details to the commit message describing the criteria of
https://bugzilla.tianocore.org/show_bug.cgi?id=2220
This change implements the Runtime Service GetNextVariableName()
using the runtime cache in VariableSmmRuntimeDxe. Runtime Service
calls to GetNextVariableName() will no longer trigger a SW SMI
when
On Mon, 2019-10-14 at 18:15 +0200, Laszlo Ersek wrote:
> My understanding is that a fix purely in edk2 -- that is, without
> advancing our openssl submodule reference at once
Haha, I love the fact that I am hoist by my own petard on patching
OpenSSL. I evidently did such a good job of
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Leif Lindholm
> Sent: Friday, September 27, 2019 6:57 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2
On 10/14/19 18:15, Laszlo Ersek wrote:
> David: another way to prevent the regression is to commit the current
> patches, but disable them with a BOOLEAN PCD, by default. (This need not
> be a feature PCD; it could even be dynamic.) Then platforms accepting
> the SAN/GEN_IP regression temporarily
On 10/11/19 18:01, David Woodhouse wrote:
> On Fri, 2019-10-11 at 17:36 +0200, Laszlo Ersek wrote:
>> On 10/11/19 13:16, David Woodhouse wrote:
>>> I first started looking at this when it was
>>> reported as such, on the list.
>>
>> I believe you. Can you somehow find that thread? I tried, but I
On 10/14/19 5:03 PM, Pete Batard wrote:
Similar to what we now do for OVMF, we need to consider the possibility
that PlatformBootManagerWaitCallback () may be called with a
PcdPlatformBootTimeOut that was set to zero, in which case the call should
simply return.
Oh I forgot this one, good
On 10/14/19 5:03 PM, Pete Batard wrote:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2266
Independently of how we decide to address other aspects of the regression
introduced with commit 2de1f611be06ded3a59726a4052a9039be7d459b, it doesn't
make much sense to call for a progress update if
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2266
Independently of how we decide to address other aspects of the regression
introduced with commit 2de1f611be06ded3a59726a4052a9039be7d459b, it doesn't
make much sense to call for a progress update if PcdPlatformBootTimeOut is
zero.
Changes from previous version:
- Additional empty comment lines above and below, to keep with existing comment
style
- Similar logic is applied to ArmVirtPkg/PlatformBootManagerLib, since the same
issue may manifest itself here.
Pete Batard (2):
OvmfPkg/PlatformBootManagerLib: Don't update
Similar to what we now do for OVMF, we need to consider the possibility
that PlatformBootManagerWaitCallback () may be called with a
PcdPlatformBootTimeOut that was set to zero, in which case the call should
simply return.
We also change the initial timeout variable name to make the code
There's BZ filed already. I think Q4 stable tag should have it.
https://bugzilla.tianocore.org/show_bug.cgi?id=2226
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> rebe...@bsdio.com
> Sent: Saturday, October 12, 2019 12:13 AM
> To: devel@edk2.groups.io;
Hi Liming,
On 10/12/19 03:44, Gao, Liming wrote:
> Reviewed-by: Liming Gao
can you please add
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2266
to the commit message, before pushing this?
(I'm not giving R-b or A-b myself, because I shouldn't approve code
whose authorship is
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
> Sent: Monday, October 14, 2019 5:39 PM
> To: devel@edk2.groups.io; Gao, Zhichao ; Zhang,
> Shenglei
> Cc: Ni, Ray
> Subject: Re: [edk2-devel] [PATCH v2] ShellPkg/Shell/FileHandleWrappers.c:
> Add check for
Hi Philippe,
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
> Sent: Monday, October 14, 2019 5:35 PM
> To: devel@edk2.groups.io; Zhang, Shenglei
> Cc: Fu, Siyuan ; Wu, Jiaxin ;
> Laszlo Ersek
> Subject: Re: [edk2-devel] [PATCH v2] NetworkPkg/IScsiDxe: Fix
Hi Pete,
thanks for the patch. I have two requests:
On 10/11/19 17:24, Pete Batard wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2266
>
> Independently of how we decide to address other aspects of the regression
> introduced with commit 2de1f611be06ded3a59726a4052a9039be7d459b, it
From: Patryk Duda
This patch implements convenient way of changing strings included
in SMBIOS Table1, Table2, Table3.
Strings can be altered by defining following PCDs:
gMarvellTokenSpaceGuid.PcdProductManufacturer
gMarvellTokenSpaceGuid.PcdProductPlatformName
On 10/12/19 08:42, Andrew Fish wrote:
> Laszlo,
>
> For 2) this is very unfortunate. I think the root cause is for those
> of us who work on x86 hardware day to day we get programed that
> SEC/PEI is IA32 and DXE is X64, and this can lead to some unfortunate
> coding outcomes.
First I was
On 10/11/19 16:35, David Woodhouse wrote:
> On Fri, 2019-10-11 at 16:27 +0200, Laszlo Ersek wrote:
>> On 10/11/19 09:44, Gao, Junhao wrote:
>>> Hi David
>>>
>>>I have found this compiled OVMF-with-csm.fd can support winxp
>>> booting up.
>>>OVMF-with-csm.fd path:
>>>
Patch addresses Bugzilla #1972.
During ExitBootServices stage, drivers should not call any
functions known to use Memory Allocation Services. One of such
functions (as per UEFI spec) is UNDI->Shutdown().
Since UNDI drivers during ExitBootServices phase are expected
to put the adapter to such a
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1974
Removing calls to UNDI->Shutdown() and Stop() functions in ExitBootServices
event notification function. Since SNP event reacting to ExitBootServices
is only calling those two functions, there is no need to create that event
at all.
Adding
On Mon, Oct 14, 2019 at 02:08:10PM +0200, Philippe Mathieu-Daudé wrote:
> On 10/14/19 2:03 PM, Pete Batard wrote:
> > On 2019.10.14 12:53, Philippe Mathieu-Daudé wrote:
> > > On 10/14/19 1:44 PM, Pete Batard wrote:
> > > > Hi Philippe,
> > > >
> > > > On 2019.10.14 11:01, Philippe Mathieu-Daudé
On 10/14/19 2:03 PM, Pete Batard wrote:
On 2019.10.14 12:53, Philippe Mathieu-Daudé wrote:
On 10/14/19 1:44 PM, Pete Batard wrote:
Hi Philippe,
On 2019.10.14 11:01, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 10/11/19 1:07 PM, Pete Batard wrote:
The board revision is the proper channel to use
On 2019.10.14 12:53, Philippe Mathieu-Daudé wrote:
On 10/14/19 1:44 PM, Pete Batard wrote:
Hi Philippe,
On 2019.10.14 11:01, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 10/11/19 1:07 PM, Pete Batard wrote:
The board revision is the proper channel to use to detect the amount of
RAM available
On Mon, Oct 14, 2019 at 11:27:51AM +, Abner Chang wrote:
>
>
> > -Original Message-
> > From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> > Sent: Tuesday, October 1, 2019 6:40 AM
> > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> >
> > Subject: Re:
Hi Philippe,
On 2019.10.14 11:01, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 10/11/19 1:07 PM, Pete Batard wrote:
The board revision is the proper channel to use to detect the amount of
RAM available as bits [20-22] report the effective RAM size for the board
starting with 256 MB (000b) and
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Tuesday, October 1, 2019 6:40 AM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 26/29]
> RiscVPkg/SmbiosDxe: Generic
Hi Pete,
On 10/11/19 1:07 PM, Pete Batard wrote:
The board revision is the proper channel to use to detect the amount of
RAM available as bits [20-22] report the effective RAM size for the board
starting with 256 MB (000b) and doubling in size for each value.
Signed-off-by: Pete Batard
On 10/11/19 1:07 PM, Pete Batard wrote:
This patch introduces the capability to also query the Model Name/
Manufacturer Name/CPU Name/Firmware Revision using the RpiFirmware
protocol. This is aims at making the driver more suitable to cater
for platforms other than the Raspberry Pi 3 as well as
Hi Zhang,
On 10/12/19 9:43 AM, Zhang, Shenglei wrote:
The condition, NET_HEADSPACE(&(Nbuf->BlockOp[Index])) < Len, is meaningless
if Index < 0. So 'Index < 0' should be performed first in the if statement.
Cc: Siyuan Fu
Cc: Jiaxin Wu
Signed-off-by: Shenglei Zhang
---
On 10/14/19 8:35 AM, Gao, Zhichao wrote:
Refer to CSS 5.2.2.6 Always put space before an open parenthesis.
FreePool(AsciiBuffer); should be FreePool (AsciiBuffer);
After address that, Reviewed-by: Zhichao Gao
Thanks,
Zhichao
-Original Message-
From: Zhang, Shenglei
Sent: Monday,
Hi Zhang,
On 10/14/19 5:14 AM, Zhang, Shenglei wrote:
After the expression,
'CopyMem (>TargetUrl, Field->Str, Field->Len);',
the '\0' should be set to TargetUrl[Field->Len] rather than
TargetUrl[Field->Len + 1].
^ This is one change, ...
Besides the boundary check should be more strict.
On Fri, Oct 11, 2019 at 05:20:31PM +0200, Marcin Wojtas wrote:
> Now that the customization of Type1/2/3 SBMIOS
> tables strings is possible, adjust them for all
> supported boards.
>
> Signed-off-by: Marcin Wojtas
Reviewed-by: Leif Lindholm
> ---
>
On Fri, Oct 11, 2019 at 05:20:30PM +0200, Marcin Wojtas wrote:
> From: Patryk Duda
>
> This patch implements convenient way of changing strings included
> in SMBIOS Table1, Table2, Table3.
>
> Strings can be altered by defining following PCDs:
> gMarvellTokenSpaceGuid.PcdProductManufacturer
>
Add prefix [edk2-devel] [edk2-test] in subject
Hi Arvin,
> -Original Message-
> From: Chen, ArvinX
> Sent: Monday, October 14, 2019 3:20 PM
> To: devel@edk2.groups.io
> Cc: Jin, Eric
> Subject: [PATCH] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest".
>
> REF:
Refer to CSS 5.2.2.6 Always put space before an open parenthesis.
FreePool(AsciiBuffer); should be FreePool (AsciiBuffer);
After address that, Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Zhang, Shenglei
> Sent: Monday, October 14, 2019 9:25 AM
> To:
90 matches
Mail list logo
