Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhiguang Liu
>Sent: Monday, November 25, 2019 9:58 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ; Wang, Jian J
>; Wu, Hao A ; Leif Lindholm
>; Philippe Mathieu-Daudé
Reviewed-by: Liming Gao
>-Original Message-
>From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
>Sent: Tuesday, November 26, 2019 6:47 PM
>To: Feng, Bob C ; devel@edk2.groups.io
>Cc: Gao, Liming ; Shi, Steven
>Subject: Re: [Patch V2] GenBiosId: Enable GenBiosId to set timestamp as
Hi Matthew and Jeremiah,
Thanks for your answers.
1. Cool. So platformBuild.py is intent to handle the additional pre-build
and post-build tasks. I think it would be great if there is a document record
how to create a PlatformBuild.py.
2. So the command-line arguments for
On 4/22/19 12:11 PM, Chiu, Chasel wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1730
Internal code quality check failed after this commit:
68d47eea422d64eeb9872b927620f579f4ccfc0f, fixed those
coding style issues.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
Chen:
Please correct the patch style. Some lines are not changed, but they are in
the patch.
Thanks
Liming
>-Original Message-
>From: Chen, Chen A
>Sent: Monday, December 02, 2019 1:52 PM
>To: Gao, Liming ; devel@edk2.groups.io
>Cc: Feng, Bob C
>Subject: RE: [edk2-platform][PATCH]
For this patch set, Reviewed-by: Bob Feng
-Original Message-
From: Shi, Steven
Sent: Tuesday, December 3, 2019 1:17 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [PATCH v2 0/4] BaseTools: Leverage compiler output dependency files
for binary cache
BZ:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2311
Include dependency file in Makefile to enhance
incremental build
Cc: Liming Gao
Cc: Steven Shi
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/GenMake.py| 83 ++
.../Source/Python/AutoGen/IncludesAutoGen.py | 258
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2311
Implement the function in Trim tool to get the included
file list for ASL and ASM file.
Cc: Liming Gao
Cc: Steven Shi
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/Trim/Trim.py | 115 ++-
1 file changed, 95
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2311
Enable the dependent files generation function for compilers
and Trim tool.
Cc: Liming Gao
Cc: Steven Shi
Signed-off-by: Bob Feng
---
BaseTools/Conf/build_rule.template | 94 +-
1 file changed, 52
V3: Change CLANG9 to CLANGPDB according to commit 14672c34bd
V2: Fixed a bug in patch 4/4.
Incremental build reduces the build time by only building
the module that need to update. Edk2 Build system is a Makefile
based build system. The incrememtal build ability is provided by
the Make program.
Binary cache use the OutputFile method to return the module
built output files needed to store in cache, but current
OutputFile implementation doesn't return complete output files.
Enhance the OutputFile method to return more complete output files.
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by:
Enhance the CacheCopyFile method arg names to be more
clear and readable
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Steven Shi
---
BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
Redesign the binary cache and bases on the compiler to
output the dependency header files info for every module.
The binary cache will directly consume the dependency header
files info and doesn't parse the C source code by iteself.
Also redesign the dependency files list format for module
and try
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2353
This patch is based on patch set: https://edk2.groups.io/g/devel/message/50360
You can directly try this patch set in this branch:
https://github.com/shijunjing/edk2/tree/incrmtl_fix_v8
A previous patch set
*Reminder:* TianoCore Community Meeting - APAC/NAMO
*When:* Thursday, 5 December 2019, 7:30pm to 8:30pm, (GMT-08:00) America/Los
Angeles
*Where:* https://bluejeans.com/889357567?src=join_info
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=621250 )
*Organizer:* Brian Richardson
Hi Bob,
Responses to your questions:
1. Yes, PlatformBuild.py could be seen as a template for a
relatively-simple, Pytools platform builder. I am also working on a more
complex example for the Edk2-Platforms Kabylake RVP to demonstrate FSP and FIT
related pre and post build steps. The
Hi Bret,
Thanks for posting this content. Host based unit testing is a very valuable
addition to the CI checks.
I have the following comments:
1. I see that MdePkg adds a dependency on UnitTestPkg. This makes
UnitTestPkg the root package when building and running host based unit tests.
Good day,
I have seen e-mails about this package several times now and got a bit
curious about its purpose and future. As far as I understood it, it aims
to provide an actual full C standard library implementation. Is this
planned to land in edk2 and if so, in what ways will one be encouraged
> On Dec 2, 2019, at 12:29 PM, Li, Jun J wrote:
>
> Hi,
> Could you please help to take a look at the error? Thanks!
>
> : error C0DE: Unknown fatal error when processing
> [c:\src\bios\intel\ServerRasPkg\Library\PlatMemTopoLib\SmmPlatMemTopologyLib.inf
> [X64, VS2015x86, RELEASE]]
>
>
Hi,
Could you please help to take a look at the error? Thanks!
: error C0DE: Unknown fatal error when processing
[c:\src\bios\intel\ServerRasPkg\Library\PlatMemTopoLib\SmmPlatMemTopologyLib.inf
[X64, VS2015x86, RELEASE]]
(Please send email to devel@edk2.groups.io for help, attaching
Hi UEFI community,
I’d like to inform you about an update in the CdePkg branch of edk2-staging.
https://github.com/tianocore/edk2-staging/tree/CdePkg#cdepkg
The goal of the CdePkg is to provide an ANSI C Interface for UEFI POST drivers,
that enables BIOS engineers to (more) easily port standard
On 11/21/19 10:38, Laszlo Ersek via Groups.Io wrote:
> Repo: https://github.com/lersek/edk2.git
> Branch:local_hdrs
> Personal CI build: https://github.com/tianocore/edk2/pull/188
>
> I'm proposing this small set of fixes for edk2-stable201911.
>
> If the consensus is
Hi Laszlo,
Comments below.
Mike
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, November 28, 2019 4:01 AM
> To: Kinney, Michael D ;
> devel@edk2.groups.io; Sean Brogan
> ; Bret Barkelew
> ; Gao, Liming
>
> Subject: Re: [edk2-devel] EDK II Maintainers - EDK II
> CI is now
The following are links to a preview of these wiki changes
https://github.com/mdkinney/edk2/wiki/EDK-II-Continuous-Integration
https://github.com/mdkinney/edk2/wiki/EDK-II-Continuous-Integration-Administration
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of
https://bugzilla.tianocore.org/show_bug.cgi?id=2315
Update wiki pages providing details of the Phase 1
EDK II Continuous Integration features and links to all
supporting documentation. Also provide notes for admins
to configure GitHub, Azure Pipelines, and Mergify.
Cc: Sean Brogan
Cc: Bret
I will work on a patch to variable services and other runtime services that
have centrallized implementations to have them check the value of this variable
during ExitBootServices and then return unsupported if the bit is not set.
Thanks,
Jeff
From: Gao,
On Mon, 2 Dec 2019 at 17:16, Pete Batard wrote:
>
> Changes from v1 (https://edk2.groups.io/g/devel/message/51334):
> - Moved RNG related changes into their own series
> - Fix a whitespace issue in the last patch
>
> Andrei Warkentin (2):
> Platform/RPi/MmcDxe: Factorize SCR call and clean up
ShellParametersProtocol::UpdateArgcArgv() can return
a EFI_INVALID_PARAMETER value. Document it.
Signed-off-by: Philippe Mathieu-Daude
---
ShellPkg/Application/Shell/ShellParametersProtocol.h | 1 +
ShellPkg/Application/Shell/ShellParametersProtocol.c | 1 +
2 files changed, 2 insertions(+)
ShellParametersProtocol::ParseCommandLineToArgs() can return
a EFI_INVALID_PARAMETER value. Document it.
Signed-off-by: Philippe Mathieu-Daude
---
ShellPkg/Application/Shell/ShellParametersProtocol.h | 1 +
ShellPkg/Application/Shell/ShellParametersProtocol.c | 1 +
2 files changed, 2
Complete the list of values the functios ParseCommandLineToArgs()
and UpdateArgcArgv() can return.
The documentation was found to be incomplete while reviewing BZ#2395:
https://edk2.groups.io/g/devel/message/51512
Regards,
Phil.
Philippe Mathieu-Daude (2):
ShellPkg: Document
The following statement produces a SyntaxWarning with Python 3.8:
if str(FdRegion.RegionType) is 'FILE' and self.Platform.VpdToolGuid in
str(FdRegion.RegionDataList):
BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py:168: SyntaxWarning: "is"
with a literal. Did you mean "=="?
Change the
Two other Python 3.8 fixes, similar to the one reported in BZ#2304:
https://bugzilla.tianocore.org/show_bug.cgi?id=2304
Regards,
Phil.
Philippe Mathieu-Daude (2):
BaseTools: Avoid "is" with a literal Python 3.8 warnings
.pytool: Avoid "is" with a literal Python 3.8 warnings in CI plugins
To avoid SyntaxWarning with Python 3.8, change the 'is' operator
by the conventional '==' comparator.
Signed-off-by: Philippe Mathieu-Daude
---
.pytool/Plugin/DscCompleteCheck/DscCompleteCheck.py | 2 +-
.pytool/Plugin/LibraryClassCheck/LibraryClassCheck.py | 2 +-
2 files changed, 2
From: Andrei Warkentin
This is mostly a maintainability improvement for the
InitializeSdMmcDevice () call achieved by factorizing the
code related to SCR execution into a new SdExecuteScr () call.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/MmcDxe/MmcIdentification.c | 105
Changes from v1 (https://edk2.groups.io/g/devel/message/51334):
- Moved RNG related changes into their own series
- Fix a whitespace issue in the last patch
Andrei Warkentin (2):
Platform/RPi/MmcDxe: Factorize SCR call and clean up MMC init
Platform/RPi/MmcDxe: Improve MMC driver stability
From: Samer El-Haj-Mahmoud
The Raspberry Pi 4 has a new SD controller. As a result we must
handle SD routing according to the model, which we perform in
the Config driver by using the GetModelFamily () call that was
recently introduced.
Signed-off-by: Pete Batard
---
From: Andrei Warkentin
For reasons that aren't entirely understood, SCR reads can randomly
fail on the Raspberry Pi 4. It can be on the first boot or during
subsequent reboots.
To alleviate this, and improve the overall behavior of the code,
we modify CheckCardsCallback () to retry
*Reminder:* TianoCore Community Meeting - EMEA/NAMO
*When:* Thursday, 5 December 2019, 9:00am to 10:00am, (GMT-08:00) America/Los
Angeles
*Where:* https://bluejeans.com/889357567?src=join_info
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=621247 )
*Organizer:* Brian Richardson
Hi Ard,
On 2019.12.02 16:03, Ard Biesheuvel wrote:
On Mon, 2 Dec 2019 at 11:55, Pete Batard wrote:
This patch series is targetted at adding support for the Bcm2838
Random Generator Driver, so that it can be used on the Raspberry
Pi 4.
Pete Batard (3):
Silicon/Broadcom/Bcm283x: Rename
On Mon, 2 Dec 2019 at 10:26, Philippe Mathieu-Daudé wrote:
>
> On 11/29/19 11:47 AM, Ard Biesheuvel via Groups.Io wrote:
> > In preparation of adding support for describing the presence of OP-TEE
> > via a SSDT ACPI table, refactor the existing code so we will be able to
> > reuse it more easily.
On Mon, 2 Dec 2019 at 11:55, Pete Batard wrote:
>
> This patch series is targetted at adding support for the Bcm2838
> Random Generator Driver, so that it can be used on the Raspberry
> Pi 4.
>
> Pete Batard (3):
> Silicon/Broadcom/Bcm283x: Rename Bcm2835 RNG driver
>
Bugzilla, https://bugzilla.tianocore.org/show_bug.cgi?id=2321
-Original Message-
From: Gao, Liming
Sent: Monday, December 2, 2019 1:46 PM
To: devel@edk2.groups.io
Cc: Chen, Chen A ; Feng, Bob C
Subject: [edk2-platform][PATCH] Silicon/Tools/FitGen: Add FitGen feature to
support uCode
Add slot mode handling with a header array.
Signed-off-by: Chen A Chen
---
Silicon/Intel/Tools/FitGen/FitGen.c | 183 +---
1 file changed, 129 insertions(+), 54 deletions(-)
diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c
b/Silicon/Intel/Tools/FitGen/FitGen.c
Add slot mode handling with a header array.
Signed-off-by: Chen A Chen
---
Silicon/Intel/Tools/FitGen/FitGen.c | 183 +---
1 file changed, 129 insertions(+), 54 deletions(-)
diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c
b/Silicon/Intel/Tools/FitGen/FitGen.c
Add slot mode handling with a header array.
Signed-off-by: Chen A Chen
---
Silicon/Intel/Tools/FitGen/FitGen.c | 183 +---
1 file changed, 129 insertions(+), 54 deletions(-)
diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c
b/Silicon/Intel/Tools/FitGen/FitGen.c
Add slot mode handling with a header array.
Signed-off-by: Chen A Chen
---
Silicon/Intel/Tools/FitGen/FitGen.c | 183 +---
1 file changed, 129 insertions(+), 54 deletions(-)
diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c
b/Silicon/Intel/Tools/FitGen/FitGen.c
Add slot mode handling with a header array.
Signed-off-by: Chen A Chen
---
Silicon/Intel/Tools/FitGen/FitGen.c | 183 +---
1 file changed, 129 insertions(+), 54 deletions(-)
diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c
b/Silicon/Intel/Tools/FitGen/FitGen.c
Reviewed by Linson Augustine
Regards,
Linson.
-Original Message-
From: Gao, Zhichao
Sent: Monday, December 2, 2019 6:24 AM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Augustine, Linson
Subject: [PATCH] ShellPkg/ShellProtocol: Return error code while fail parsing
cmd-line
REF:
On Mon, 2 Dec 2019 at 13:02, Leif Lindholm wrote:
>
> On Mon, Dec 02, 2019 at 10:58:45 +0100, Ard Biesheuvel wrote:
> > On Fri, 29 Nov 2019 at 13:13, Ard Biesheuvel
> > wrote:
> > >
> > > On Fri, 29 Nov 2019 at 12:29, Leif Lindholm
> > > wrote:
> > > >
> > > > On Fri, Nov 29, 2019 at 11:47:14
On 12/02/19 06:14, Ni, Ray wrote:
>>> Laszlo,
>>> I agree with you to use to PCD for "token count per chunk".
>>> But I suggest the default value of that PCD can be at least 64.
>>> Reasons:
>>> 1. MM_MP is the new MP protocol in SMM environment and we expect
>>> all SMM code start to use the
On 12/2/19 12:55 PM, Pete Batard wrote:
While the Bcm2835 and Bcm2838 RNG appear to share the same register layout,
we prefer moving the RNG specific defines into their own header in case
this assertion doesn't hold true with future RNG drivers.
Also, this should make it clearer to see which
On 12/2/19 12:55 PM, Pete Batard wrote:
The Bcm283x architecture provides multiple implementations of the
Random Number Generator, that have incompatibilities with one
another.
Because we will need to add a new driver for the Bcm2838 RNG we
rename the existing Bcm2835-compatible driver to
On Mon, Dec 02, 2019 at 10:58:45 +0100, Ard Biesheuvel wrote:
> On Fri, 29 Nov 2019 at 13:13, Ard Biesheuvel
> wrote:
> >
> > On Fri, 29 Nov 2019 at 12:29, Leif Lindholm
> > wrote:
> > >
> > > On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote:
> > > > Refactor the platform DXE a bit
This patch series is targetted at adding support for the Bcm2838
Random Generator Driver, so that it can be used on the Raspberry
Pi 4.
Pete Batard (3):
Silicon/Broadcom/Bcm283x: Rename Bcm2835 RNG driver
Silicon/Broadcom/Bcm283x: Move Bcm2835 RNG defines to their own header
While the Bcm2835 and Bcm2838 RNG appear to share the same register layout,
we prefer moving the RNG specific defines into their own header in case
this assertion doesn't hold true with future RNG drivers.
Also, this should make it clearer to see which specific elements apply to
which SoC
The Bcm283x architecture provides multiple implementations of the
Random Number Generator, that have incompatibilities with one
another.
Because we will need to add a new driver for the Bcm2838 RNG we
rename the existing Bcm2835-compatible driver to Bcm2835RngDxe
and update the one platform that
This adds the Bcm2838 Random Number Generator Driver, which
is also the type of RNG that the Bmc2711-based Raspberry Pi 4
uses.
Signed-off-by: Pete Batard
---
Silicon/Broadcom/Bcm283x/Drivers/Bcm2838RngDxe/Bcm2838RngDxe.c | 285
Hi Zhichao,
On 12/2/19 12:04 PM, Gao, Zhichao wrote:
-Original Message-
From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
Sent: Monday, December 2, 2019 6:21 PM
To: devel@edk2.groups.io; Gao, Zhichao
Cc: Ni, Ray ; Augustine, Linson
Subject: Re: [edk2-devel] [PATCH]
> -Original Message-
> From: Philippe Mathieu-Daudé [mailto:phi...@redhat.com]
> Sent: Monday, December 2, 2019 6:21 PM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Ni, Ray ; Augustine, Linson
> Subject: Re: [edk2-devel] [PATCH] ShellPkg/ShellProtocol: Return error code
> while fail
On 11/29/19 11:47 AM, Ard Biesheuvel via Groups.Io wrote:
In preparation of adding support for describing the presence of OP-TEE
via a SSDT ACPI table, refactor the existing code so we will be able to
reuse it more easily.
Signed-off-by: Ard Biesheuvel
---
On 12/2/19 1:53 AM, Gao, Zhichao via Groups.Io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2395
Errors happened in the arguments parsing is not a critical error.
And it would miss the error status code in the release version of shell.
So replace the ASSERT with returning error
On Fri, 29 Nov 2019 at 13:13, Ard Biesheuvel wrote:
>
> On Fri, 29 Nov 2019 at 12:29, Leif Lindholm wrote:
> >
> > On Fri, Nov 29, 2019 at 11:47:14 +0100, Ard Biesheuvel wrote:
> > > Refactor the platform DXE a bit in patch #1 so we can seamlessly drop in
> > > the code in patch #2 to expose a
Hi Michael,
I agree on eliminating the redundant copies Edk2 APIs from Edk2Platform
packages and I also think it can be done without introducing newer dependencies
as indicated in my previous response.
That said, the topic of package dependencies, especially for silicon
initialization code
63 matches
Mail list logo
