> -Original Message-
> From: Wu, Hao A
> Sent: Monday, January 06, 2020 1:32 PM
> To: devel@edk2.groups.io; 'matt.devill...@gmail.com'
> Subject: RE: [edk2-devel] [PATCH v3 1/3] MdeModulePkg/Usb/EfiKey: Fix
> endpoint selection
>
> > -Original Message-
> > From:
Series has been pushed via commits b948a49615..f68cb23c14.
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Monday, January 06, 2020 1:19 PM
> To: Marcin Wojtas
> Cc: Albecki, Mateusz;
Reviewed-by: Liming Gao
-Original Message-
From: Liu, Zhiguang
Sent: 2019年12月20日 16:32
To: devel@edk2.groups.io
Cc: Gao, Liming ; Ni, Ray ; Laszlo
Ersek
Subject: [Patch V2] edksetup.bat: Simplify the step to use CLANGPDB
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2404
Set
I see. Will do that.
> -Original Message-
> From: Wang, Jian J
> Sent: Monday, January 6, 2020 1:58 PM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Zhang, Chao B
> Subject: RE: [PATCH 6/6] SecurityPkg/Tcg2Pei: Add TCG PFP 105 support.
>
> I mean putting all rev0 code in 'else' not
Jiewen,
Just two coding style comments below. With it addressed,
Reviewed-by: Jian J Wang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao, Jiewen
> Sent: Tuesday, December 31, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Zhang, Chao B
>
> Subject:
I mean putting all rev0 code in 'else' not just one line. For rev105, your patch
will initialize FvBlob but never use it at all. It will confuse readers
sometimes.
Regards,
Jian
> -Original Message-
> From: Yao, Jiewen
> Sent: Monday, January 06, 2020 1:53 PM
> To: Wang, Jian J ;
Hi Jian
I purposely put the line there, because I want to group all the rev 0 code
together and rev 105 code together in if statement. I don't want to move that
particular line to else statement.
Thank you
Yao Jiewen
> -Original Message-
> From: Wang, Jian J
> Sent: Monday, January 6,
Jiewen,
Just one minor comment. With it addressed,
Reviewed-by: Jian J Wang
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, December 31, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Zhang, Chao B
>
> Subject: [PATCH 6/6] SecurityPkg/Tcg2Pei: Add TCG PFP 105
Best Regards,
Hao Wu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> MrChromebox
> Sent: Monday, January 06, 2020 12:12 PM
> To: devel@edk2.groups.io
> Cc: Matt DeVillier
> Subject: [edk2-devel] [PATCH v3 3/3]
>
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> MrChromebox
> Sent: Monday, January 06, 2020 12:12 PM
> To: devel@edk2.groups.io
> Cc: Matt DeVillier
> Subject: [edk2-devel] [PATCH v3 1/3] MdeModulePkg/Usb/EfiKey: Fix
> endpoint selection
>
>
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> MrChromebox
> Sent: Monday, January 06, 2020 12:12 PM
> To: devel@edk2.groups.io
> Cc: Matt DeVillier
> Subject: [edk2-devel] [PATCH v3 2/3] MdeModulePkg/Usb/UsbMouse: Fix
> endpoint selection
>
> -Original Message-
> From: Marcin Wojtas [mailto:m...@semihalf.com]
> Sent: Friday, January 03, 2020 7:05 PM
> To: Wu, Hao A
> Cc: Albecki, Mateusz; devel@edk2.groups.io; Gao, Zhichao; Gao, Liming; Ard
> Biesheuvel
> Subject: Re: [PATCH 0/2] MdeModulePkg/SdMmcPciHcDxe: Send the
>
The endpoint selected by the driver needs to not
only be an interrupt type, but have direction IN
as required to set up an asynchronous interrupt transfer.
Currently, the driver assumes that the first INT endpoint
will be of type IN, but that is not true of all devices,
and will silently fail on
---
MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c | 90 +---
1 file changed, 47 insertions(+), 43 deletions(-)
diff --git a/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c
b/MdeModulePkg/Bus/Usb/UsbKbDxe/KeyBoard.c
index 7505951c82..37c9388161 100644
---
The endpoint selected by the driver needs to not
only be an interrupt type, but have direction IN
as required to set up an asynchronous interrupt transfer.
Currently, the driver assumes that the first INT endpoint
will be of type IN, but that is not true of all devices,
and will silently fail on
The endpoint selected by the driver needs to not
only be an interrupt type, but have direction IN
as required to set up an asynchronous interrupt transfer.
Currently, the driver assumes that the first INT endpoint
will be of type IN, but that is not true of all devices,
and will silently fail on
Reviewed-by: Liming Gao
-Original Message-
From: Philippe Mathieu-Daude
Sent: 2020年1月3日 17:07
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Kinney, Michael D
; Gao, Liming ; Philippe
Mathieu-Daude
Subject: [PATCH v2 28/78] MdePkg/Register: Fix various typos
From: Antoine Coeur
Fix
Reviewed-by: Liming Gao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Philippe
Mathieu-Daudé
Sent: 2020年1月3日 17:07
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Kinney, Michael D
; Gao, Liming ; Philippe
Mathieu-Daude
Subject: [edk2-devel] [PATCH v2 27/78] MdePkg/Ppi:
Reviewed-by: Liming Gao
-Original Message-
From: Philippe Mathieu-Daude
Sent: 2020年1月3日 17:07
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Kinney, Michael D
; Gao, Liming ; Philippe
Mathieu-Daude
Subject: [PATCH v2 26/78] MdePkg/Library/Smm: Fix various typos
From: Antoine Coeur
Reviewed-by: Liming Gao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Philippe
Mathieu-Daudé
Sent: 2020年1月3日 17:07
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Kinney, Michael D
; Gao, Liming ; Philippe
Mathieu-Daude
Subject: [edk2-devel] [PATCH v2 25/78]
Reviewed-by: Liming Gao
-Original Message-
From: Philippe Mathieu-Daude
Sent: 2020年1月3日 17:07
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Kinney, Michael D
; Gao, Liming ; Philippe
Mathieu-Daude
Subject: [PATCH v2 24/78] MdePkg/Library/Dxe: Fix various typos
From: Antoine Coeur
Reviewed-by: Liming Gao
-Original Message-
From: Philippe Mathieu-Daude
Sent: 2020年1月3日 17:07
To: devel@edk2.groups.io
Cc: Antoine Coeur ; Kinney, Michael D
; Gao, Liming ; Philippe
Mathieu-Daude
Subject: [PATCH v2 23/78] MdePkg/IndustryStandard: Fix various typos
From: Antoine
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, December 31, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Zhang, Chao B
>
> Subject: [PATCH 1/6] SecurityPkg/Guid: Add TCG 800-155 event GUID definition.
>
> REF:
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, December 31, 2019 2:44 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ;
> Zhang, Chao B
> Subject: [PATCH 4/6] MdeModulePkg/dec: add PcdTcgPfpMeasurementRevision
> PCD
>
>
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, January 02, 2020 8:30 PM
> To: devel@edk2.groups.io
> Cc: K, Pavana ; Wang, Jian J ;
> Feng, Bob C
> Subject: [PATCH 1/1] CryptoPkg: Support for SHA384 & SHA512 RSA signing
> schemes
>
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Philippe Mathieu-Daude
> Sent: Friday, January 03, 2020 5:07 PM
> To: devel@edk2.groups.io
> Cc: Antoine Coeur ; Wang, Jian J ; Lu,
> XiaoyuX ; Philippe Mathieu-Daude
> Subject: [PATCH v2 01/78] CryptoPkg/OpensslLib:
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Saturday, January 04, 2020 4:09 AM
> To: Wu, Hao A; Ni, Ray; Dong, Eric; devel@edk2.groups.io
> Cc: Zeng, Star; Fu, Siyuan; Kinney, Michael D
> Subject: Re: [edk2-devel] [PATCH v5 0/6] Microcode related
Ard:
The changes are good to me. But, I think this change will not be added into
MdePkg until PI1.7 errata A is published.
Thanks
Liming
-Original Message-
From: Ard Biesheuvel
Sent: 2020年1月3日 21:03
To: Ard Biesheuvel
Cc: edk2-devel-groups-io ; Kinney, Michael D
; Leif Lindholm ;
Hi Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Saturday, January 4, 2020 2:11 AM
> To: devel@edk2.groups.io; Ni, Ray ; Dong, Eric
>
> Subject: Re: [edk2-devel] [PATCH v3 2/2] UefiCpuPkg/PiSmmCpuDxeSmm:
> Fix
Thanks, already reviewed-by.
> -Original Message-
> From: Philippe Mathieu-Daude
> Sent: Friday, January 3, 2020 3:23 AM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm ; Kinney, Michael D
> ; Andrew Fish ; Laszlo
> Ersek ; Philippe Mathieu-Daude ;
> Chiu, Chasel
> Subject: [PATCH v3
Retrieve git version info and save as environment variable
These variables can be used in modules to print the vesrion
info when uefi boots.
This helps in identifying the codebase from logs.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Pankaj Bansal
---
Notes:
When i ran PatchCheck.py
31 matches
Mail list logo
