[edk2-devel][edk2-platforms][PATCH v2] IntelSiliconPkg/Feature/SmmAccess/*: Fix incorrect Docygen comment

2020-01-08 Thread Marc W Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2436 Cc: Michael Kubacki Cc: Sai Chaganty Cc: Ray Ni Cc: Liming Gao Cc: Shenglei Zhang Signed-off-by: Marc Chen --- .../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 37 ++-- .../SmmAccess/SmmAccessDxe/SmmAccessDriver.c

Re: [edk2-devel] [PATCH] BaseTools: Retrieve git version info

2020-01-08 Thread Pankaj Bansal
Hi Bob, Thanks for replying. Please see inline -Original Message- From: Feng, Bob C Sent: Thursday, January 9, 2020 11:43 AM To: Pankaj Bansal ; devel@edk2.groups.io Cc: Gao, Liming Subject: RE: [PATCH] BaseTools: Retrieve git version info Hi Pankaj, I would have some questions.

Re: [edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length

2020-01-08 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Philippe Mathieu-Daudé Sent: Thursday, January 2, 2020 8:17 PM To: devel@edk2.groups.io Cc: Philippe Mathieu-Daude ; Gao, Liming ; Justen, Jordan L ; Zhu, Yonghong ; Gao,

[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Add missed comments for parameter.

2020-01-08 Thread Dong, Eric
This issue caused by below change: SHA-1: b948a496150f4ae4f656c0f0ab672608723c80e6 * UefiCpuPkg/PiSmmCpuDxeSmm: Pre-allocate PROCEDURE_TOKEN buffer REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2388 Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Eric Dong ---

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg: acpiview: Update SRAT parser to ACPI 6.3

2020-01-08 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao The logic of the code change is same with the previous patches. I would keep all the R-B in V1 and V2 and the T-B in V2. Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent:

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UefiBootManagerLib: log reserved mem allocation failure

2020-01-08 Thread Ni, Ray
+ Siyuan who originally worked in the HTTP boot functionality. > -Original Message- > From: Laszlo Ersek > Sent: Thursday, January 9, 2020 7:43 AM > To: edk2-devel-groups-io > Cc: Wu, Hao A ; Wang, Jian J ; > Ni, Ray ; Gao, Zhichao > Subject: [PATCH 1/2]

Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: deprecate HmacXxxGetContextSize interface

2020-01-08 Thread Wang, Jian J
Laszlo, > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, January 08, 2020 6:24 PM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Lu, XiaoyuX > Subject: Re: [PATCH] CryptoPkg/BaseCryptLib: deprecate > HmacXxxGetContextSize interface > > On 01/08/20 08:26, Jian J Wang

[edk2-devel] [PATCH v2 2/2] UefiCpuPkg: Shadow microcode patch according to FIT microcode entry.

2020-01-08 Thread Siyuan, Fu
The existing MpInitLib will shadow the microcode update patches from flash to memory and this is done by searching microcode region specified by PCD PcdCpuMicrocodePatchAddress and PcdCpuMicrocodePatchRegionSize. This brings a limition to platform FW that all the microcode patches must be placed

[edk2-devel] [PATCH v2 1/2] MdePkg: Add header file for Firmware Interface Table specification.

2020-01-08 Thread Siyuan, Fu
This patch add FirmwareInterfaceTable.h for the Firmware Interface Table BIOS specification. This is to remove future edk2 dependency on edk2-platforms repo. The file content comes from edk2-platforms\Silicon\Intel\IntelSiliconPkg\Include\IndustryStandard BZ link:

[edk2-devel] [PATCH v2 0/2] Shadow microcode patch according to FIT microcode table.

2020-01-08 Thread Siyuan, Fu
The existing MpInitLib will shadow the microcode update patches from flash to memory and this is done by searching microcode region specified by PCD PcdCpuMicrocodePatchAddress and PcdCpuMicrocodePatchRegionSize. This brings a limition to platform FW that all the microcode patches must be placed

Re: [edk2-devel] [Patch 0/2] Shadow microcode patch according to FIT microcode table.

2020-01-08 Thread Liming Gao
Siyuan: This is new feature, please add it into https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning And, FIT header file is moved from edk2-platform to edk2. After this change, you also need to remove the one in edk2-platform. Right? Thanks Liming -Original

Re: [edk2-devel] [PATCH 4/4] ArmVirtPkg/ArmVirtQemu: add optional support for TPM2 measured boot

2020-01-08 Thread Yao, Jiewen
Hi Comment for the warning: > > WARNING: TPM2 Event log has HashAlg unsupported by PCR bank (0xC) > > WARNING: TPM2 Event log has HashAlg unsupported by PCR bank (0xD) The reason is that: The DSC added all HASH algorithm to the TCG2 driver. (SHA1/SHA256/SHA384/SHA512/SM3). But the current TPM

[edk2-devel] [PATCH 0/2] UefiBootManagerLib, HttpDxe: tweaks for large HTTP(S) downloads

2020-01-08 Thread Laszlo Ersek
Repo: https://github.com/lersek/edk2.git Branch: tweaks_for_large_http This series aims to improve HTTP(S) Boot experience with large (4GiB+) files. Cc: Hao A Wu Cc: Jian J Wang Cc: Jiaxin Wu Cc: Maciej Rabeda Cc: Ray Ni Cc: Siyuan Fu Cc: Zhichao Gao Thanks, Laszlo Laszlo Ersek (2):

[edk2-devel] [PATCH 1/2] MdeModulePkg/UefiBootManagerLib: log reserved mem allocation failure

2020-01-08 Thread Laszlo Ersek
The LoadFile protocol can report such a large buffer size that we cannot allocate enough reserved pages for. This particularly affects HTTP(S) Boot, if the remote file is very large (for example, an ISO image). While the TianoCore wiki mentions this at

[edk2-devel] [PATCH 2/2] NetworkPkg/HttpDxe: fix 32-bit truncation in HTTPS download

2020-01-08 Thread Laszlo Ersek
When downloading over TLS, each TLS message ("APP packet") is returned as a (decrypted) fragment table by EFI_TLS_PROTOCOL.ProcessPacket(). The TlsProcessMessage() function in "NetworkPkg/HttpDxe/HttpsSupport.c" linearizes the fragment table into a single contiguous data block. The resultant flat

Re: [edk2-devel][edk2-platforms][PATCH] IntelSiliconPkg/Feature/SmmAccess/*: Fix incorrect Docygen comment

2020-01-08 Thread Kubacki, Michael A
edk2-platforms\Silicon\Intel\IntelSiliconPkg\Include\Library\SmmAccessLib.h * I think the description would be clearer by making the following change: "An API to install a PEI_MM_ACCESS_PPI PPI for controlling SMM mode memory access basically for S3 resume usage." to "An API to install

Re: [edk2-devel] Interpretation of specification

2020-01-08 Thread James Bottomley
On Wed, 2020-01-08 at 12:24 +0100, Laszlo Ersek wrote: > (+James) > > On 01/07/20 19:13, Eugene Khoruzhenko wrote: > > I think I may have found the problem. I can write the > > file_name.signed created by your scripts in NT32 emulated > > environment and in EDKII on Minnow board that I build

Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: remove EnterS3WithImmediateWake () from ResetSystemLib

2020-01-08 Thread Ard Biesheuvel
On Mon, 6 Jan 2020 at 16:13, Ard Biesheuvel wrote: > > EnterS3WithImmediateWake () no longer has any callers, so remove it > from ResetSystemLib. > > Signed-off-by: Ard Biesheuvel Ping? > --- > MdeModulePkg/Include/Library/ResetSystemLib.h| 11 > --- >

[edk2-devel] [PATCH v3 1/1] ShellPkg: acpiview: Update SRAT parser to ACPI 6.3

2020-01-08 Thread Krzysztof Koch
Add support for revision 3 of System Resource Affinity Table (SRAT). Decode and dump the new Generic Initiator Affinity Structure. Validate the Device Handle Type field inside the Generic Initiator Affinity Structure. Signed-off-by: Krzysztof Koch --- The changes can be seen at:

[edk2-devel] [edk2-platforms][PATCH 1/2] Platform/RPi/SmbiosDxe: Report a more human readable firmware revision

2020-01-08 Thread Pete Batard
The firmware revision that is queried through the VideoCore mailbox is really the 32-bit timestamp of when the VideoCore firmware was generated. To make this more palatable for human reporting, convert it to a YY.MM firmware revision, so that end-users can get an approximative idea of how old

[edk2-devel] [edk2-platforms][PATCH 0/2] Platform/RPi: Smbios reporting improvements

2020-01-08 Thread Pete Batard
This series of patches improves the reporting of the firmware version and platform serial number for the Raspberry Pi platforms. Since there is only so much we can do with 16 bits and the firmware revision reported by the VideoCore mailbox is really a timestamp of when the VC firmware was build,

[edk2-devel] [edk2-platforms][PATCH 2/2] Platform/RPi/RPiFirmwareDxe: Fix serial number population for RPi4

2020-01-08 Thread Pete Batard
Some (all?) Raspbery Pi 4 platforms report 0x1000 as their board serial when queried through the VideoCore mailbox. Fix this by using the MAC address then. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 5 +++-- 1 file changed, 3

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-01-08 Thread Michael D Kinney
Hi Vitaly, Thanks for the additional background. I would like a couple extra day to review the PCD name and the places the PCD might potentially be used. If we find other APIs where ASSERT() behavior is only valuable during dev/debug to quickly identify misuse with trusted data and the API

Re: [edk2-devel] [PATCH 0/2] OvmfPkg: clean up TPM2 related DSC/FDF content

2020-01-08 Thread Philippe Mathieu-Daudé
Cc'ing Marc-André & Stefan, maintainers of "OvmfPkg: TCG- and TPM2-related modules". On 1/8/20 3:38 PM, Ard Biesheuvel wrote: Clean up some issues that Laszlo spotted in OVMF while reviewing TPM2 support for ArmVirtQemu. Ard Biesheuvel (2): OvmfPkg: reorganize TPM2 support in DSC/FDF files

Re: [edk2-devel] [PATCH 4/4] ArmVirtPkg/ArmVirtQemu: add optional support for TPM2 measured boot

2020-01-08 Thread Laszlo Ersek
(CC Marc-André and Jiewen) On 01/08/20 15:13, Ard Biesheuvel wrote: > On Tue, 7 Jan 2020 at 18:37, Laszlo Ersek wrote: >> On 01/07/20 10:48, Ard Biesheuvel wrote: >>> + gEfiSecurityPkgTokenSpaceGuid.PcdTpmBaseAddress|0x0 >>> + gEfiSecurityPkgTokenSpaceGuid.PcdTpm2InitializationPolicy|1 >>> +

Re: [edk2-devel] [PATCH 2/4] ArmVirtPkg/PlatformPeiLib: discover the TPM base address from the DT

2020-01-08 Thread Ard Biesheuvel
On Tue, 7 Jan 2020 at 16:42, Laszlo Ersek wrote: > > On 01/07/20 10:47, Ard Biesheuvel wrote: > > Introduce a boolean PCD that tells us whether TPM support is enabled > > in the build, and if it is, record the TPM base address in the existing > > routine that traverses the device tree in the

[edk2-devel] [PATCH 2/2] OvmfPkg: use HII type PCDs for TPM2 config related variables

2020-01-08 Thread Ard Biesheuvel
The HII pages that are part of Tcg2ConfigDxe expect the following PCDs to be of dynamic HII type, so declare them as such. gEfiSecurityPkgTokenSpaceGuid.PcdTcgPhysicalPresenceInterfaceVer gEfiSecurityPkgTokenSpaceGuid.PcdTpm2AcpiTableRev Currently, the TPM2 ACPI table is not produced, since

[edk2-devel] [PATCH 0/2] OvmfPkg: clean up TPM2 related DSC/FDF content

2020-01-08 Thread Ard Biesheuvel
Clean up some issues that Laszlo spotted in OVMF while reviewing TPM2 support for ArmVirtQemu. Ard Biesheuvel (2): OvmfPkg: reorganize TPM2 support in DSC/FDF files OvmfPkg: use HII type PCDs for TPM2 config related variables OvmfPkg/OvmfPkgIa32.dsc| 15 ---

[edk2-devel] [PATCH 1/2] OvmfPkg: reorganize TPM2 support in DSC/FDF files

2020-01-08 Thread Ard Biesheuvel
Put the TPM2 related DXE modules together in the DSC, and add a TPM2 support header comment while at it. Signed-off-by: Ard Biesheuvel --- OvmfPkg/OvmfPkgIa32.dsc| 9 ++--- OvmfPkg/OvmfPkgIa32X64.dsc | 9 ++--- OvmfPkg/OvmfPkgX64.dsc | 3 +++ OvmfPkg/OvmfPkgIa32.fdf| 3 +++

Re: [edk2-devel] [PATCH v2 03/78] EmbeddedPkg/VirtualKeyboard: Fix few typos

2020-01-08 Thread Philippe Mathieu-Daudé
On 1/8/20 1:42 PM, Ard Biesheuvel wrote: On Fri, 3 Jan 2020 at 10:08, Philippe Mathieu-Daude wrote: From: Antoine Coeur Fix few typos in the documentation. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Antoine Coeur Reviewed-by: Philippe Mathieu-Daude Signed-off-by: Philippe

Re: [edk2-devel] [PATCH 4/4] ArmVirtPkg/ArmVirtQemu: add optional support for TPM2 measured boot

2020-01-08 Thread Ard Biesheuvel
On Tue, 7 Jan 2020 at 18:37, Laszlo Ersek wrote: > > On 01/07/20 10:48, Ard Biesheuvel wrote: > > Duplicate the TPM2_ENABLE and TPM2_CONFIG_ENABLE build time flags that > > already exist in OvmfPkg, and wire them up in the .DSC and .FDF so > > that setting those flags produces a ArmVirtQemu build

Re: [edk2-devel] [Patch 2/2] UefiCpuPkg/CpuCommonFeaturesLib: SMXE bit of CR4 should set

2020-01-08 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gao, Liming > Sent: Monday, December 23, 2019 2:56 PM > To: devel@edk2.groups.io > Cc: Voelz, Jason ; Ni, Ray > Subject: [Patch 2/2] UefiCpuPkg/CpuCommonFeaturesLib: SMXE bit of CR4 should > set > > From: Jason Voelz > > Add code to

Re: [edk2-devel] [Patch 1/2] MdePkg BaseLib.h: Update IA32_CR4 strut to include all public fields

2020-01-08 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gao, Liming > Sent: Monday, December 23, 2019 2:56 PM > To: devel@edk2.groups.io > Cc: Voelz, Jason ; Ni, Ray > Subject: [Patch 1/2] MdePkg BaseLib.h: Update IA32_CR4 strut to include all > public fields > > From: Jason Voelz > >

Re: [edk2-devel] [PATCH v2 03/78] EmbeddedPkg/VirtualKeyboard: Fix few typos

2020-01-08 Thread Ard Biesheuvel
On Fri, 3 Jan 2020 at 10:08, Philippe Mathieu-Daude wrote: > > From: Antoine Coeur > > Fix few typos in the documentation. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Antoine Coeur > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude Reviewed-by:

Re: [edk2-devel] [PATCH v2 02/78] EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER

2020-01-08 Thread Ard Biesheuvel
On Fri, 3 Jan 2020 at 10:08, Philippe Mathieu-Daude wrote: > > Correctly write 'EFI_INVALID_PARAMETER' in documentation. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Philippe Mathieu-Daude > --- > .../VirtualKeyboardDxe/VirtualKeyboard.h | 22 +-- > 1 file

Re: [edk2-devel] [Patch 0/2] Shadow microcode patch according to FIT microcode table.

2020-01-08 Thread Laszlo Ersek
On 01/08/20 11:58, Fu, Siyuan wrote: > Hi, Laszlo > >> -Original Message- >> From: Laszlo Ersek >> Sent: 2020年1月8日 17:43 >> To: Fu, Siyuan ; devel@edk2.groups.io >> Cc: Kinney, Michael D ; Gao, Liming >> ; Dong, Eric ; Ni, Ray >> ; Tom Lendacky >> Subject: Re: [Patch 0/2] Shadow

Re: [edk2-devel] Interpretation of specification

2020-01-08 Thread Laszlo Ersek
(+James) On 01/07/20 19:13, Eugene Khoruzhenko wrote: > I think I may have found the problem. I can write the > file_name.signed created by your scripts in NT32 emulated environment > and in EDKII on Minnow board that I build myself. However, I cannot > write the file_name.signed on a commercial

Re: [edk2-devel] [Patch 0/2] Shadow microcode patch according to FIT microcode table.

2020-01-08 Thread Siyuan, Fu
Hi, Laszlo > -Original Message- > From: Laszlo Ersek > Sent: 2020年1月8日 17:43 > To: Fu, Siyuan ; devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Dong, Eric ; Ni, Ray > ; Tom Lendacky > Subject: Re: [Patch 0/2] Shadow microcode patch according to FIT microcode > table. > >

Re: [edk2-devel] [Patch 0/2] Shadow microcode patch according to FIT microcode table.

2020-01-08 Thread Laszlo Ersek
On 01/08/20 10:42, Laszlo Ersek wrote: > In closing: it seems short-sighted that the FIT specification placed a > "naked" pointer at a fixed offset in flash, rather than a three-field > structure consisting of: > - a GUID, > - preceded by a structure size, > - preceded by the FIT pointer. > >

Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: deprecate HmacXxxGetContextSize interface

2020-01-08 Thread Laszlo Ersek
On 01/08/20 08:26, Jian J Wang wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1792 > > Hmac(Md5|Sha1|Sha256)GetContextSize() use a deprecated macro > HMAC_MAX_MD_CBLOCK defined in openssl. They should be dropped to > avoid misuses in the future. For context allocation and release, >

Re: [edk2-devel] [PATCH 3/4] ArmVirtPkg/PlatformPeiLib: implement Reset2 PPI based on PSCI

2020-01-08 Thread Ard Biesheuvel
On Tue, 7 Jan 2020 at 19:47, Laszlo Ersek wrote: > > On 01/07/20 17:55, Ard Biesheuvel wrote: > > On Tue, 7 Jan 2020 at 17:50, Laszlo Ersek wrote: > >> > >> On 01/07/20 10:47, Ard Biesheuvel wrote: > >>> Extend the existing DT traversal routine in PlatformPeiLib with > >>> discovery of the PSCI

Re: [edk2-devel] [Patch 0/2] Shadow microcode patch according to FIT microcode table.

2020-01-08 Thread Laszlo Ersek
(+Tom) On 01/08/20 05:25, Siyuan Fu wrote: > The existing MpInitLib will shadow the microcode update patches from > flash to memory and this is done by searching microcode region > specified by PCD PcdCpuMicrocodePatchAddress and > PcdCpuMicrocodePatchRegionSize. > This brings a limition to

Re: [edk2-devel] [PATCH v7] MdeModulePkg: Add EDK2 Platform Boot Manager Protocol

2020-01-08 Thread Wang, Jian J
Pushed @ 972d88726410e21b1fff1a528854202c67e97ef1 Regards, Jian From: Ashish Singhal Sent: Wednesday, January 08, 2020 1:18 PM To: Wang, Jian J ; Wu, Hao A ; devel@edk2.groups.io Cc: Spottswood, Jason ; Wang, Sunny (HPS SW) ; Ni, Ray ; Gao, Zhichao ; Kinney, Michael D ; Andrew Fish