Mike:
Yes. Build tool needs to know host OS behavior and get the full include path.
For this patch, it skips some include paths. If this include path also includes
other required header file, it will cause the build break. Can we have the
assumption that all sys header files and other non-sys
Liming,
The build tools would need to know which env var to query for
all OS/host tool chain combinations and how to parse that
information for full paths in an OS specific manner. We should
not build that type of information into the build tools.
The fix I have provided does not need this
Got the point.
With the typo fixed, Reviewed-by: Star Zeng
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, January 2, 2020 11:15 AM
> To: Zeng, Star ; Ray Ni
> ; devel@edk2.groups.io
> Cc: Dong, Eric ; Kinney, Michael D
>
> Subject: RE: [PATCH v2 3/3] UefiCpuPkg/CpuFeature:
Mike:
Another way is to parse INCLUDE env value and add the system PATH into -I
options as the first priority.
Thanks
Liming
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, January 30, 2020 8:46 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
>
Mike:
Sorry. This edk2\BaseTools\get_vsvars.bat can set VS host env.
Thanks
Liming
> -Original Message-
> From: Kinney, Michael D
> Sent: Saturday, February 1, 2020 12:43 AM
> To: Gao, Liming ; devel@edk2.groups.io; Kinney, Michael
> D
> Cc: Feng, Bob C
> Subject: RE: [Patch]
Anthony:
This change is OK to me. But if this PCD is configured as Dynamic, its value
will be got from PCD service. This operation will take some time and cause the
inaccurate time delay. Have you measured its impact?
Thanks
Liming
> -Original Message-
> From: Laszlo Ersek
> Sent:
Got it.
Reviewed-by: Siyuan Fu
> -Original Message-
> From: Wu, Hao A
> Sent: 2020年2月3日 9:03
> To: Fu, Siyuan ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Kinney, Michael D
>
> Subject: RE: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Always get
> CPUID &
> -Original Message-
> From: Fu, Siyuan
> Sent: Monday, February 03, 2020 8:55 AM
> To: devel@edk2.groups.io; Wu, Hao A
> Cc: Dong, Eric; Ni, Ray; Laszlo Ersek; Kinney, Michael D
> Subject: RE: [edk2-devel] [PATCH v1] UefiCpuPkg/MpInitLib: Always get CPUID
> & PlatformID in
Mike:
Can we consider to parse INCLUDE env value and add those path to -I options
as the first priority?
Thanks
Liming
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, January 30, 2020 8:46 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject:
Hi, Hao
If CPUID and PlatformID will always be collected in MicrocodeDetect(), is the
change in 999463 redundant now? Should we remove that code?
Best Regards
Siyuan
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Hao
> A
> Sent: 2020年2月3日 8:35
> To:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2498
Commit fd30b00707 updated the logic in function MicrocodeDetect() that
will directly use the CPUID and PlatformID information from the 'CpuData'
field in the CPU_MP_DATA structure, instead of collecting these
information for each processor
11 matches
Mail list logo
