From: Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2602
Zero the allocated buffer in case GetImageInfo `continue` in the middle of
a loop. This will cause unexpected GetImageInfo failure not clearing the
corresponding entry and lead to GP faults when dereferencing this entry.
Cc:
Yes, I verified the build with this patch by directly referencing the new data
types in a source file.
Thanks
Ashraf
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, March 18, 2020 8:11 AM
> To: Liu, Zhiguang ; Javeed, Ashraf
> ; devel@edk2.groups.io
> Cc: Kinney, Michael D
>
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of TinaX Y Chen
> Sent: Tuesday, March 17, 2020 11:02 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Chaganty, Rangasai V
> ; Chiu, Chasel
> ; Tsao, Ethan
> Subject: [edk2-devel] [edk2-platforms:PATCH] Coffe
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2538
For LzmaCompress or BrotliCompress, the platform may use the different
options and add their batch file, such as LzmaCompressPlatform.
Then, specify it in platform.dsc [BuildOptions] to override the default
one in tools_def.txt.
*_*_*_LZMA_P
Thanks Nishant.
If the platform RPMC driver calls GetRpmcState(), then we should not define it
in UEFI, because the variable driver does not have such knowledge.
I do see the complexity on the counter management requirement. Current API
might be either insufficient or unnecessary.
To keep our
Ashraf:
The change is good. Have you verified the build with this patch?
Reviewed-by: Liming Gao
Thanks
Liming
-Original Message-
From: Liu, Zhiguang
Sent: 2020年3月17日 16:08
To: Javeed, Ashraf ; devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
Subject: RE: [PATCH V2] MdeP
Zhiguang:
This change is good. Reviewed-by: Liming Gao
Thanks
Liming
-Original Message-
From: Liu, Zhiguang
Sent: 2020年3月18日 9:40
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
Subject: [Patch V2] MdePkg DebugLib: Enable FILE NAME as DEBUG ASSERT for CLANG
REF: https
Thanks Jian. Some comments and thought.
1) RPMC spec uses CounterAddress as the indicator. Can we use the same name
instead of CounterId in the API definition?
2) How the caller known which CounterAddress it need to fill?
Do we need an API such as GetValidCounterAddress() ?
3) What is the value
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add null version of VariableKeyLib instance. The full version should be
provided by platforms which supports key generator.
Cc: Jiewen Yao
Cc: Chao Zhang
Cc: Nishant C Mistry
Signed-off-by: Jian J Wang
---
.../VariableKeyLibNull/Variab
> v3: update retval description in RpmcLib.h and RpmcLibNull.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Patch branch:
https://github.com/jwang36/edk2/tree/bz2594-part1-common-interfaces-between-platform-and-edk2-v3
Cc: Jiewen Yao
Cc: Chao Zhang
Cc: Nishant C Mistry
Jian J Wan
> v3: update retval description in RpmcLib.h
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
RpmcLib.h and VariableKeyLib.h are header files required to access RPMC
device and Key generator from platform. They will be used to ensure the
integrity and confidentiality of NV variables.
Cc:
> v3: update retval description in RpmcLibNull.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
Add null version of RpmcLib instance. The full version should be provided
by platform which supports RPMC device.
Cc: Jiewen Yao
Cc: Chao Zhang
Cc: Nishant C Mistry
Signed-off-by: Jian J
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1548
For clang compiler, This change will make the generated image not include the
absolute file path. If so, the generated debug image can be reproduced in the
different root directory. Also, it will reduce the size of debug image size.
To do so,
*Reminder:* TianoCore Bug Triage - APAC / NAMO
*When:* Wednesday, 18 March 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing
*Where:* https://zoom.com.cn/j/493235016
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=752975 )
*Organizer:* Brian Richardson brian.richard...@intel.com
Zhiguang:
Please add more information on macro __FILE_NAME__. This is new macro
supported by CLANG compiler.
Thanks
Liming
-Original Message-
From: Liu, Zhiguang
Sent: 2020年3月17日 15:13
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
Subject: [PATCH] MdePkg DebugLib: En
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Desimone, Ashley
E
Sent: Monday, March 16, 2020 11:17 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C
Subject: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRep
Reviewed-by: Ashley DeSimone
-Original Message-
From: Desimone, Nathaniel L
Sent: Monday, March 16, 2020 10:33 AM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Use /S switch to pass com
Reviewed-by: Ashley DeSimone
-Original Message-
From: Desimone, Nathaniel L
Sent: Monday, March 16, 2020 10:33 AM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Uninstaller does not unin
Reviewed-by: Ashley DeSimone
-Original Message-
From: Desimone, Nathaniel L
Sent: Monday, March 16, 2020 10:33 AM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Installer would lists eve
Ashraf,
Thank you for the prompt response!
My response in below.
(I removed some earlier conversations, but the context is still kept.)
> > I take it as an agree of using the global AUTO. Thanks for that.
> Please note that there is another request of "Do not touch", and I am still
> contemplati
On Wed, Mar 11, 2020 at 16:39:41 +0100, Laszlo Ersek wrote:
> On 03/11/20 16:32, Leif Lindholm wrote:
> > ArmVirtGicArchLib was originally implemented before virtualization
> > emulation was implemented in QEMU, and the GICv2 model implemented only
> > the physical copy of control registers.
> >
>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507
This patch adds support for building the native instruction algorithms for
IA32 and X64 versions of OpensslLib. The process_files.pl script was modified
to parse the .asm file targets from the OpenSSL build config data struct, and
generate th
ASSERT in SetTime_Conf Consistency Test.
SCT Test expect return as Invalid Parameter.
So removed ASSERT().
Signed-off-by: Gaurav Jain
---
Notes:
v3
Removed Time Validity Checks in function SetWakeupTime.
v2
reverted changes related to valid range of years.
EmbeddedPkg/RealTime
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2538
For LzmaCompress or BrotliCompress, the platform may use the different
options and add their batch file, such as LzmaCompressPlatform.
Then, specify it in platform.dsc [BuildOptions] to override the default
one in tools_def.txt.
*_*_*_LZMA_P
Hi, Experts:
I have a question about UEFI MAT / PcdPropertiesTableEnable.
Device protection in Windows Security, standard hardware security requirement
is described as below:
TPM 2.0
Secure Boot Enabled
DEP
UEFI MAT
And UEFI MAT feature is related with PcdPropertiesTableEnable.
But I found the n
Reviewed-by: Xiaoyu Lu
> -Original Message-
> From: Abner Chang [mailto:abner.ch...@hpe.com]
> Sent: Friday, March 6, 2020 1:36 PM
> To: devel@edk2.groups.io
> Cc: abner.ch...@hpe.com; Daniel Schaefer ;
> Wang, Jian J ; Lu, XiaoyuX ;
> Leif Lindholm ; Gilbert Chen
> Subject: [edk2/master
Reviewed-by: Zhiguang Liu
-Original Message-
From: Javeed, Ashraf
Sent: Tuesday, March 17, 2020 4:04 PM
To: devel@edk2.groups.io
Cc: Kinney, Michael D ; Gao, Liming
; Liu, Zhiguang
Subject: [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing
BZ: https://bugzilla.tianocore.org/
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
All registers definition of DVSEC are defined as per the PCI Express Base
Specification 4.0 chapter 7.9.6.
Signed-off-by: Ashraf Javeed
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
V2: fixed the comment section description for D
Kindly ignore this as I have sent only the delta portion of previous patch.
I shall send the whole patch again.
Thanks
Ashraf
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Javeed,
> Ashraf
> Sent: Tuesday, March 17, 2020 1:22 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Mi
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of TinaX Y
> Chen
> Sent: Tuesday, March 17, 2020 11:02 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Chaganty, Rangasai V
> ; Chiu, Chasel ;
> Tsao, Ethan
> Subject: [edk2-devel] [edk2-platforms:PATC
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2598
All registers definition of DVSEC are defined as per the PCI Express Base
Specification 4.0 chapter 7.9.6.
Signed-off-by: Ashraf Javeed
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
V2: fixed the comment section description for D
Hi Zhiguang,
Good catch! I shall fix it as per your suggestion.
Thanks
Ashraf
> -Original Message-
> From: Liu, Zhiguang
> Sent: Tuesday, March 17, 2020 12:46 PM
> To: devel@edk2.groups.io; Javeed, Ashraf
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: RE: [edk2-devel] [PATCH V1] M
My response below.
Thanks
Ashraf
> -Original Message-
> From: Ni, Ray
> Sent: Monday, March 16, 2020 7:30 PM
> To: Javeed, Ashraf ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
>
> Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH
> 05/12] PciBusDxe: Setup sub-phase
Hi Ashraf
I think the code change is good.
But you have put the code inside the below comment block, which is confusing.
/// Based on section 7.7.5 of PCI Express Base Specification 4.0.
///@{
..
///@}
Maybe you can add another comment block to explain which the spec and section
the code ch
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1548
This change will make the generated image not include the absolute file path.
If so, the generated debug image can be reproduced in the different root
directory. Also, it will reduce the size of debug image size.
CC: Michael D Kinney
CC: Li
35 matches
Mail list logo
