This patch introduces several changes for different purposes.
At least I can see:
1. Default PCD value change
2. Consume century value from HW
Can you separate the patches to 2 patches?
For the purpose #2, can you explain more background/reason?
The PcdMinimalValidYear/ PcdMaximalValidYear
I may miss some discussions.
I remember the original discussion output was to create a compiler stub for x86.
Why now we trend to move to BaseLib?
> -Original Message-
> From: Gao, Liming
> Sent: Sunday, April 26, 2020 11:33 PM
> To: Jiang, Guomin ; devel@edk2.groups.io; Ni, Ray
> ;
Hi Gaurav,
Sorry for the late reply. I wanted to test the patch last week but were fixing
a bug in our platform initialization bug that caused MMC to fail, thus I were
unable to test.
I'll test it in a few days.
Thanks!
> -Original Message-
> From: Gaurav Jain
> Sent: Tuesday,
> -Original Message-
> From: Jiang, Guomin
> Sent: Sunday, April 26, 2020 9:05 PM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Wang, Jian J; Ni, Ray
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the
> description table after Reset Device
>
> Add comment inline.
>
> >
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2692
BrotliCompress submodule change for BaseTools causes untracked
files in BaseTools after building. This is regression for git.
Cc: Laszlo Ersek
Cc: Sean Brogan
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.gitmodules |
Hi, Zhichao
The protocol is internal API inside CryptoPkg, and BaseCryptLib is external
API. If you create a patch which made incompatible change of the protocol and
its version number, I suppose you should be the one who also update the DXE
driver and library instance so the external API will
It is a incapability change.
Hi Siyuan/Mike,
Do you know who owns the update of the Crypt DXE driver? I want to get the
suggestion from the owner if we can make this change. Because the consumer of
this binary driver should aware of this change.
Thanks,
Zhichao
> -Original Message-
>
Guomin:
The size impact is small. This solution that moves _fltused to BaseLib is OK
to me.
Thanks
Liming
> -Original Message-
> From: Jiang, Guomin
> Sent: Friday, April 24, 2020 1:08 PM
> To: Gao, Liming ; devel@edk2.groups.io; Ni, Ray
> ; Kinney, Michael D
> ;
> -Original Message-
> From: Bi, Dandan [mailto:dandan...@intel.com]
> Sent: Sunday, April 26, 2020 10:44 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Cc: Chen, Gilbert ; Leif Lindholm
> ; Gao, Liming
> Subject: RE: [edk2-devel] [PATCH v1 3/3]
Add RISCV64 Arch.
Signed-off-by: Abner Chang
Co-authored-by: Gilbert Chen
Reviewed-by: Leif Lindholm
Acked-by: Zhichao Gao
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Leif Lindholm
Cc: Gilbert Chen
---
MdeModulePkg/Logo/Logo.inf | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
Add RISC-V in INF for building CapsuleRuntimeDxe RISCV64 image.
Signed-off-by: Abner Chang
Co-authored-by: Gilbert Chen
Reviewed-by: Leif Lindholm
Acked-by: Hao A Wu
Cc: Hao A Wu
Cc: Liming Gao
Cc: Leif Lindholm
Cc: Gilbert Chen
---
.../Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf
MdeModulePkg modules and definitionsfor RISC-V architecture on edk2.
BZ for entire RISC-V edk2 port,
https://bugzilla.tianocore.org/show_bug.cgi?id=2672
These commits are verified by below PR,
https://github.com/tianocore/edk2/pull/512
Abner Chang (3):
MdeModulePkg/Logo
Add RISCV64 Arch.
Signed-off-by: Abner Chang
Co-authored-by: Gilbert Chen
Reviewed-by: Leif Lindholm
Acked-by: Zhichao Gao
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Leif Lindholm
Cc: Gilbert Chen
---
MdeModulePkg/Logo/Logo.inf | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
Implementation of RISC-V DxeIPL.
Signed-off-by: Abner Chang
Co-authored-by: Gilbert Chen
Reviewed-by: Leif Lindholm
Cc: Dandan Bi
Cc: Liming Gao
Cc: Leif Lindholm
Cc: Gilbert Chen
---
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 6 +-
.../Core/DxeIplPeim/RiscV64/DxeLoadFunc.c |
Hi Abner,
1. What's following definition for? It seems not be used.
typedef
VOID*
(EFIAPI *DXEENTRYPOINT) (
IN VOID *HobStart
);
2. When reviewing this patch, found the RSIC-V switchstack related code are not
in BaseLib in MdePkg.
But then noticed that you have covered them in another
Add comment inline.
> -Original Message-
> From: Wu, Hao A
> Sent: Sunday, April 26, 2020 4:04 PM
> To: Jiang, Guomin ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Ni, Ray
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the
> description table after Reset Device
>
> >
Here is the test PR based on the latest edk2 master with this patch set.
Thanks for reviewing this.
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Sean via
groups.io
Sent: Saturday, April 25, 2020 11:36 AM
To: Chang, Abner (HPS SW/FW Technologist) ;
devel@edk2.groups.io
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Aditya
> Angadi via groups.io
> Sent: 22 April 2020 17:42
> To: devel@edk2.groups.io; Thomas Abraham
> Cc: Ard Biesheuvel ; l...@nuviainc.com
> Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 0/9]Platform/Arm/Sgi:
> Add
> -Original Message-
> From: Jiang, Guomin
> Sent: Sunday, April 26, 2020 2:44 PM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Wang, Jian J; Ni, Ray
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the
> description table after Reset Device
>
> Hi Hao,
>
> Add comments
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2694
When the USB fail and then Reset Device, it should rebuild description.
Signed-off-by: Guomin Jiang
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
---
MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBus.c | 12
1 file changed, 12
You can change the protocol GUID and remote the function from the protocol -
this is an internal protocol. It should not be called by anyone.
> -Original Message-
> From: Gao, Zhichao
> Sent: Sunday, April 26, 2020 2:43 PM
> To: Yao, Jiewen ; Fu, Siyuan ;
> devel@edk2.groups.io
> Cc:
Hi Hao,
Add comments inline.
> -Original Message-
> From: Wu, Hao A
> Sent: Sunday, April 26, 2020 1:12 PM
> To: devel@edk2.groups.io; Wu, Hao A ; Jiang, Guomin
>
> Cc: Wang, Jian J ; Ni, Ray
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the
> description table
Jiewen,
Do you mean remove the definition of the deprecated function and keep the NULL
value in the protocol structure?
I am not sure if that is a good idea. Because that would give the protocol a
chance to call a NULL pointer.
Siyuan,
The binary would be totally different. Does that make
23 matches
Mail list logo
