Thanks. I might go ahead and enable the docs on bsdio.com in the meantime.
In terms of the OVMF and other platform builds, I was thinking something
like https://artifact.ci.freebsd.org/snapshot/head/ where a new build
would be made available to people for each change that's made in the
repo -
Guomin,
Sorry I didn't check carefully on the return type of function
Pkcs7TypeIsOther().
I think BOOLEAN should be more appropriate. INTN looks strange, although it
works. It's actually used to check if the PKCS7 is data or not. Son in this
function
TRUE or FALSE should be returned instead of
Add comments
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Jeremy
> Linton
> Sent: Tuesday, April 28, 2020 10:31 AM
> To: Jiang, Guomin ; Wu, Hao A
> ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Ni, Ray ;
> ard.biesheu...@arm.com; Tian, Feng ; Kinney, Michael
> D
>
Hi,
On 4/27/20 8:14 PM, Jiang, Guomin wrote:
Add stakeholder and link https://edk2.groups.io/g/devel/message/58193
Add discussion history and add comment.
Hi Jeremy,
You can refer https://edk2.groups.io/g/devel/message/58125 for discussion
about this solution.
Oh fun, odd how a bug can
*Reminder:* TianoCore Bug Triage - APAC / NAMO
*When:* Wednesday, 29 April 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing
*Where:* https://zoom.com.cn/j/493235016
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=758254 )
*Organizer:* Brian Richardson
Add stakeholder and link https://edk2.groups.io/g/devel/message/58193
Add discussion history and add comment.
> > Hi Jeremy,
> >
> > You can refer https://edk2.groups.io/g/devel/message/58125 for discussion
> about this solution.
>
> Oh fun, odd how a bug can exist in a code base for years and
Hi Jeremy,
Let move the discussion into https://edk2.groups.io/g/devel/message/58125, and
I will add history in that message.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Jeremy
> Linton
> Sent: Tuesday, April 28, 2020 8:44 AM
> To: Jiang, Guomin ;
Hi,
On 4/26/20 8:36 PM, Wu, Hao A via groups.io wrote:
-Original Message-
From: Jiang, Guomin
Sent: Sunday, April 26, 2020 9:05 PM
To: Wu, Hao A; devel@edk2.groups.io
Cc: Wang, Jian J; Ni, Ray
Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: Rebuild the
description table after
Rebecca,
Those are both good ideas. Have not had time to enable them yet.
Doxygen generated documentation into HTML on a site is possible.
There are some issues with the current CLI tool that does
this where it generates random filename each build. There is a
Doxygen config option to disable
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2539
Microsoft signtool supports creation of attached P7's with any OID payload
via the "/p7co" parameter. It is necessary to check the data before get
the string.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Guomin Jiang
---
Hi!
On 4/27/20 7:15 PM, Jiang, Guomin wrote:
Hi Jeremy,
You can refer https://edk2.groups.io/g/devel/message/58125 for discussion about
this solution.
Oh fun, odd how a bug can exist in a code base for years and then this
happens.. I will move the discussion there.
Thanks,
Two issue I
I was wondering if there are any near-term plans to start generating and
publishing EDK2 Doxygen documentation as part of an Azure build -
perhaps on a nightly or weekly basis?
If not, then I'll work on getting my copy of the docs available again
since I've found them useful in the past.
Hi Jeremy,
You can refer https://edk2.groups.io/g/devel/message/58125 for discussion about
this solution.
Two issue I found:
1. Memory leakage may occur if doing so and I am investigating it.
2. It test pass with OVMF but fail in real platform, and I am figuring out the
flow.
Best Regards
During port reset, the device descriptors should be checked
before attempting to set an endpoint configuration.
In particular this fixes a crash due to
ASSERT(TrsRing != NULL) in XhcSyncTrsRing(). That crash
happens during error recovery on devices attached to XHCI
hosts. This is because the port
I believe I misunderstood the conclusion of which Signed-off-by to
include in the v1 series discussion -
https://edk2.groups.io/g/devel/message/57129.
These patches are taken from a branch on Sean's fork of edk2 as noted in
the cover letter - https://edk2.groups.io/g/devel/message/58114. Sean
Are you using edksetup.bat? I would have expected this code to set the
path for you.
https://github.com/tianocore/edk2/blob/master/BaseTools/toolsetup.bat#L134
So without more logs i don't know.
If you want to use "stuart" (my preferred method) I have a commit here
for EmulatorPkg which
On 4/27/20 3:03 AM, Philippe Mathieu-Daudé wrote:
+#include
+#include
+#include
Don't you need ?
Hmm, you're right. I'm not sure where I got
"IndustryStandard/QemuFwCfg.h" from, though I noticed QemuFwCfg.h itself
includes a nonexistent version in IndustryStandard!
#ifndef
Hi Mike,
I was thinking (for post-conversion) we may end up needing something
like
.git* text eol=lf
in our gitattributes file (which itself unfortunately currently does
not follow that format).
If we were to rename BaseTools/Conf/diff.order and
BaseTools/Conf/gitattributes (to say
Hi Liming,
Thanks!
I'm sorry but I don't know what "PatchCheck CI pipe line can support
the exception." means. I did ask before if there was a way to
bypass that particular test.
Anyway, I created
https://github.com/tianocore/edk2/pull/549
Grateful for any help.
Regards,
LEif
On Mon, Apr 27,
Thanks. That worked!
Jim S.
On Mon, Apr 27, 2020 at 10:34 AM Gao, Liming wrote:
> Please try command " git submodule update --init" to check out the source
> code before you build the packages.
>
>
>
>
>
> *From:* devel@edk2.groups.io * On Behalf Of *jim
> slaughter
> *Sent:* Monday, April
Liming,
Should we update PatchCheck.py to allow LF only for files with
a diff.order extension? We already have exceptions for .sh and
.gitmodules files.
if self.filename.endswith('.sh'):
#
# Do not enforce CR/LF line endings for linux
Hi Liming,
Yes - this is part of
https://docs.python.org/3/library/email.header.html
(or for Python 2,
https://docs.python.org/2/library/email.header.html).
Someone with better python knowledge than me may be able to explain
why the implicit import is required for Python 2 (at least in my
setup)
Guomin,
One more comment.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wang, Jian
> J
> Sent: Monday, April 27, 2020 4:17 PM
> To: Jiang, Guomin ; devel@edk2.groups.io
> Cc: Lu, XiaoyuX
> Subject: Re: [edk2-devel] [PATCH v4] CryptoPkg/Pkcs7: Extend support for other
>
Leif:
I am OK for this change. Reviewed-by: Liming Gao
As you say, this patch doesn't pass patchcheck. I suggest PatchCheck CI pipe
line can support the exception.
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo Ersek
> Sent: Friday, April 24,
Lefi:
Is email.header built-in lib? If this change doesn't require user to install
the additional python library, I am OK with change.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Leif Lindholm
> Sent: Tuesday, April 21, 2020 11:42 PM
> To: devel@edk2.groups.io
>
Reviewed-by: Liming Gao
> -Original Message-
> From: Zhang, Shenglei
> Sent: Monday, April 27, 2020 9:21 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek ; Sean Brogan
> ; Feng, Bob C ; Gao, Liming
>
> Subject: [PATCH] .gitmodules: ignore untracked files in brotli
>
> REF:
Please try command " git submodule update --init" to check out the source code
before you build the packages.
From: devel@edk2.groups.io On Behalf Of jim slaughter
Sent: Monday, April 27, 2020 11:30 PM
To: devel@edk2.groups.io
Subject: [edk2-devel] EDK2 Linux Build, Make Errors on Basetools,
Hello,
I am using Ubuntu (16.04 x86) under WSL.
Error on "make -C BaseTools" found in common instructions document for
linux,
https://github.com/tianocore/tianocore.github.io/wiki/Common-instructions
Using BASH shell.
I have done sudo updates and upgrade. Followed instructions and everything
On 4/27/20 4:54 PM, Aditya Angadi wrote:
Hi Ard,
-Original Message-
From: devel@edk2.groups.io On Behalf Of Ard
Biesheuvel via groups.io
Sent: 27 April 2020 16:32
To: devel@edk2.groups.io; Aditya Angadi
Cc: Thomas Abraham ; l...@nuviainc.com;
Vijayenthiran Subramaniam
Subject: Re:
Hi Ard,
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ard
> Biesheuvel via groups.io
> Sent: 27 April 2020 16:32
> To: devel@edk2.groups.io; Aditya Angadi
> Cc: Thomas Abraham ; l...@nuviainc.com;
> Vijayenthiran Subramaniam
> Subject: Re: [edk2-devel]
On Fri, Apr 24, 2020 at 08:05:53PM +0200, Laszlo Ersek wrote:
> On 04/23/20 11:53, Anthony PERARD wrote:
> > [LibraryClasses.common.SEC]
> >QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgSecLib.inf
> > +!ifdef $(DEBUG_ON_HYPERVISOR_CONSOLE)
> > +
> >
On Fri, Apr 24, 2020 at 07:58:48PM +0200, Laszlo Ersek wrote:
> On 04/23/20 11:53, Anthony PERARD wrote:
> > @@ -24,10 +23,10 @@ [Defines]
> > #
> >
> > [Sources]
> > - DebugIoPortQemu.c
> > + DebugIoPortNocheck.c
> >DebugLib.c
> > - DebugLibDetect.h
> >DebugLibDetectRom.c
> > +
On Fri, Apr 24, 2020 at 14:31:08 -0700, michael.kuba...@outlook.com wrote:
> From: Sean Brogan
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570
>
> Convert workspace root Readme.md to reStructuredText
> ReStructuredText supports building tables with syntax that is easier
> to read in
On Fri, Apr 24, 2020 at 14:31:03 -0700, michael.kuba...@outlook.com wrote:
> From: Sean Brogan
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2570
>
> Add new Azure Pipeline definitions to build and run ArmVirtPkg with:
> * Ubuntu GCC5
> Add PyTool based build of ArmVirtPkg
> Add
On 4/14/20 2:52 PM, Aditya Angadi via groups.io wrote:
Move common platform description entries in platform specific DSDT to
a SSDT that can be reused on all SGI/RD platforms.
Signed-off-by: Aditya Angadi
Reviewed-by: Ard Biesheuvel
---
Platform/ARM/SgiPkg/AcpiTables/RdE1Edge/Dsdt.asl
On 4/14/20 2:52 PM, Aditya Angadi via groups.io wrote:
Move the ACPI helper macros defines related to GIC structure,
distributor, redistributor and ITS to SgiAcpiHeader.h as these are
common across ARM SGI/RD platforms.
Signed-off-by: Aditya Angadi
What else are you changing in Sgi575? Can
On 4/14/20 2:52 PM, Aditya Angadi via groups.io wrote:
From: Vijayenthiran Subramaniam
In preparation for adding support for Reference Design (RD) platforms
that have different base addresses for GIC distributor or redistributor,
create individual platform description files for all SGI/RD
Hi Ray,
The current logic in PcRtc.c will give us WRONG year. (I explained below)
If we only change the PCD Min. value to 2000 and Max. value to 2099. The
current logic will work. But we still have Y3K bug.
That is why we need to read from Hardware.
If any reasons you guys doesn't want to read
Hi,
Thanks for your help.
I am to build base tools and able to generate bin files.
"Build" command is generated.
Later, I am trying to build "EmulatorPkg".
And running into VfrCompile error.
'VfrCompile' is not recognized as an internal or external command,
operable program or batch file.
NMAKE :
Hi Oleksiy,
About this patch set, I gave comments on the third one.
Other patch's code change is fine for me, but may have coding style issue.
Thanks
Zhiguang
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Oleksiy
> Yakovlev
> Sent: Saturday, April 11, 2020 3:58 AM
>
Hi Rebecca,
On 4/24/20 8:29 PM, Rebecca Cran wrote:
Add a null implementation library for QemuFwCfgLib, in order to
support building PciHostBridgeLib for bhyve.
Signed-off-by: Rebecca Cran
---
.../Library/QemuFwCfgLib/QemuFwCfgLibNull.inf | 37
Hi Oleksiy,
I have added my comment inline.
And as I mentioned before, please use ECC check tool or PatchCheck.py to make
sure your patch is align with edk2 coding style. Thanks
You can also refer to
https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C to check
edk2 C code style.
On 4/25/20 12:17 AM, Rebecca Cran wrote:
Signed-off-by: Rebecca Cran
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
---
OvmfPkg/AcpiPlatformDxe/EntryPoint.c | 8 +-
OvmfPkg/AcpiPlatformDxe/PciDecoding.c | 10 +--
OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpi.c | 32
Hi Rebecca,
On 4/25/20 12:55 AM, Rebecca Cran wrote:
This prevents overflow when printing DWORD fields such as the type 17
tables's extended DIMM size.
Similar issue with type 14:
ShellPrintEx(-1,-1,L"ItemType %d: %d\n", Index + 1,
Struct->Type14->Group[Index].ItemType);
Guomin,
A few comments below.
> -Original Message-
> From: Jiang, Guomin
> Sent: Sunday, April 26, 2020 1:40 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX
> Subject: [PATCH v4] CryptoPkg/Pkcs7: Extend support for other OID types
>
> REF:
+ Meenakshi
> -Original Message-
> From: Ard Biesheuvel
> Sent: Monday, April 6, 2020 7:42 PM
> To: Leif Lindholm ; Gaurav Jain
> Cc: devel@edk2.groups.io; Pankaj Bansal ; Haojian
> Zhuang ; Loh, Tien Hock
> Subject: Re: [PATCH 1/1] EmbeddedPkg/MmcDxe: Added MaxBlock Transfer
> Limit
46 matches
Mail list logo
