Hello,
Please help to catch this patch into edk2 202005 stable tag. Thank you
-Original Message-
From: devel@edk2.groups.io On Behalf Of Maggie Chu
Sent: Monday, May 18, 2020 7:42 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Wang, Jian J ;
Zhang, Chao B ; Yao, Jiewen
Subject:
Ashley,
I am confused. Here are the lines from the patch that remove the
skip_submodule parameter.
-def clone_repos(args, workspace_dir, repos_to_clone,
project_client_side_hooks, config, skip_submodule, manifest):
+def clone_repos(args, workspace_dir, repos_to_clone,
Hi Erik,
You have not updated the definition of clone_repos() in
common_repo_functions.py to reflect that you are no longer passing the
skip_submodule parameter which is not set to a default value. Additionally you
have not removed the calls to the previous submodule initialization code from
Hi Erik,
Please see feedback inline below.
Thanks,
Ashley
-Original Message-
From: Bjorge, Erik C
Sent: Saturday, May 16, 2020 6:29 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Desimone, Nathaniel L
; Pandya, Puja ; Bret
Barkelew ; Agyeman, Prince
Subject:
Hi Xiaoyu,
You're correct. But I am not a Perl developer. So I would file a Bugzilla and
assign to someone to make the change for process_files.pl in the future.
Thanks,
Zhichao
> -Original Message-
> From: Lu, XiaoyuX
> Sent: Monday, May 18, 2020 1:37 PM
> To: Gao, Zhichao ;
*Reminder:* TianoCore Bug Triage - APAC / NAMO
*When:* Wednesday, 20 May 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing
*Where:* https://bluejeans.com/889357567?src=join_info
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=805106 )
*Organizer:* Brian Richardson
Anyone?
FWIW I've been doing at least 20 boots a day with this, 200-300 MiB at a time.
Super stable.
This is also tracked now https://bugzilla.tianocore.org/show_bug.cgi?id=2720
A
From: devel@edk2.groups.io on behalf of Andrei Warkentin
via groups.io
Sent:
Oleksiy:
Wei has sent the updated patches for the changes in MdeModulePkg and
SignedCapsulePkg. https://edk2.groups.io/g/devel/message/59652
He bases on your patch and does some updated. Please help review whether it
is ok to you. You don't need to submit this patch set again.
Thanks
Hi Leif,
pon., 18 maj 2020 o 20:16 Leif Lindholm napisał(a):
>
> On Mon, May 18, 2020 at 20:11:49 +0200, Marcin Wojtas wrote:
> > Hi Leif,
> >
> > pon., 18 maj 2020 o 19:12 Leif Lindholm napisał(a):
> > >
> > > On Fri, May 15, 2020 at 23:05:56 +0200, Marcin Wojtas wrote:
> > > > This patch
Pushed: 39c498261c
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C
Sent: Sunday, May 17, 2020 5:51 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Desimone, Nathaniel L
; Pandya, Puja ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-devel]
Reviewed-by: Ashley DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Bjorge, Erik C
Sent: Sunday, May 17, 2020 5:51 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Desimone, Nathaniel L
; Pandya, Puja ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-devel]
Hi Liming.
>From Your comment here I understand that you are waiting for somebody else
>here.
But looking through your comments - I agree with comment 1, but think other two
are incorrect.
So do I need to resubmit 2.8a series?
Regards, Oleksiy.
-Original Message-
From: Gao, Liming
Fixed.
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Andrew Fish via groups.io
> Sent: Monday, May 18, 2020 1:34 PM
> To: edk2-devel-groups-io
> Subject: [edk2-devel] Broken link on:
> https://github.com/tianocore/tianocore.github.io/wiki/C
> ode-Contributions
>
FWIW, I kind of like the idea of having a way to provide an exception
handler in all situations via a library. We use a custom fatal
exception handler which prints extra debugging information. So
currently we have to modify CpuExceptionHandlerLib, or explicitly hook
every exception as early
https://github.com/tianocore/tianocore.github.io/wiki/Code-Contributions link
to https://github.com/tianocore/edk2/blob/master/Readme.md is broken.
Thanks,
Andrew Fish
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#59764):
On Mon, May 18, 2020 at 20:11:49 +0200, Marcin Wojtas wrote:
> Hi Leif,
>
> pon., 18 maj 2020 o 19:12 Leif Lindholm napisał(a):
> >
> > On Fri, May 15, 2020 at 23:05:56 +0200, Marcin Wojtas wrote:
> > > This patch introduce following modifications, allowing to
> > > overcome the instabilities
On Mon, May 18, 2020 at 21:37:24 +0800, Ming Huang wrote:
> There are some boards base on D06, but use RX8900 RTC,
> so upstream the RX8900RealTimeClockLib.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> ---
>
Hi Leif,
pon., 18 maj 2020 o 19:12 Leif Lindholm napisał(a):
>
> On Fri, May 15, 2020 at 23:05:56 +0200, Marcin Wojtas wrote:
> > This patch introduce following modifications, allowing to
> > overcome the instabilities observed with certain USB2.0 endpoints:
> > * Add additional step which
Mike,
Your suggestion sounds ok to me. As long as it is verbose I will not mind its
addition. However, I do not have a good idea of how can it look like. If you
post something I can include it.
Thanks,
Vitaly
> 18 мая 2020 г., в 20:04, Kinney, Michael D
> написал(а):
>
> Vitaly,
>
>
On Mon, May 18, 2020 at 21:37:23 +0800, Ming Huang wrote:
> The functions of acquiring ownership of RTC will be used for other
> RTC library, so move them to RtcHelperLib.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ming Huang
> ---
>
On Mon, May 18, 2020 at 13:46:46 +0100, Sami Mujawar wrote:
> The VS2017 compiler reports 'warning C6326: potential
> comparison of a constant with another constant' when
> a fixed PCD value is compared with a constant value.
>
> The faulting code is as marked by '-->' below:
>
> --> if
On Sat, May 16, 2020 at 19:59:32 +0200, Ard Biesheuvel wrote:
> The 96boards I2C driver currently relies on the platform to connect
> all controllers, or I2C peripherals will not be exposed if they are
> not the active boot target. Since I2C peripherals are not boot targets
> in the first place,
On Fri, May 15, 2020 at 10:32:35 +0200, Ard Biesheuvel wrote:
> Drop the description of the interrupt handling part of the GPIO
> controller, and use a ACPI0013 Generic Event device instead to
> handle the power button event. This way, an OS can handle these
> events without the need for a SoC
On Mon, May 18, 2020 at 19:11:48 +0200, Ard Biesheuvel wrote:
> In the ArmPkg version of PlatformBootManagerLib, we construct a
> serial device path based on the default settings for baud rate,
> parity and the number of stop bits, to ensure that a serial console
> is available even on the very
In the ArmPkg version of PlatformBootManagerLib, we construct a
serial device path based on the default settings for baud rate,
parity and the number of stop bits, to ensure that a serial console
is available even on the very first boot.
This assumes that PcdUartDefaultParity or
On Fri, May 15, 2020 at 23:05:56 +0200, Marcin Wojtas wrote:
> This patch introduce following modifications, allowing to
> overcome the instabilities observed with certain USB2.0 endpoints:
> * Add additional step which enables the Impedance and PLL calibration.
> * Enable old squelch detector
Vitaly,
Reviewed-by: Michael D Kinney
I agree that can go in now for the stable tag.
The only additional comment I have received is if a DEBUG() message
can be added where the ASSERT() was removed. Perhaps only at the
DEBUG_VERBOSE level that is not usually enabled by default. A
developer
On 05/08/20 14:16, Laszlo Ersek wrote:
> Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2706
> Repo: https://pagure.io/lersek/edk2.git
> Branch: memtypeinfo_rework
>
> Please find the problem statement and the solution outline in the
> Bugzilla ticket linked above.
>
> Cc: Ard
Reviewed-by: jiewen@intel.com
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Maggie Chu
> Sent: Monday, May 18, 2020 7:42 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Wang, Jian J ;
> Zhang, Chao B ; Yao, Jiewen
> Subject: [edk2-devel] [PATCH v3] SecurityPkg:
Sami:
Sorry. I miss this patch. The change is good to me. Please create PR request
to verify the change. Seemly, the commit message it too long. Do you verify it
by BaseTools\Scripts\PatchCheck.py?
If the commit message passes RP, you can add my Reviewed-by: Liming Gao
Last, do you
[Bob] https://edk2.groups.io/g/devel/message/58782
I'd prefer the option 2#. I think that is the easiest way to meet the
requirement. Since the aml file is the definite output of asl file, we can use
it to descript the dependency relationship between c source file and asl source
code.
[Pierre]
From: Pierre Gondois
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2425
The AmlToHex script and Posix/WindowsLike wrappers convert
an AML file to a .hex file, containing a C array storing
AML bytecode. This ".hex" file can then be included in a
C file, allowing to access the AML bytecode
From: Pierre Gondois
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2425
The AmlToHex script and Posix/WindowsLike wrappers convert
an AML file to a .hex file, containing a C array storing
AML bytecode. This ".hex" file can then be included in a
C file, allowing to access the AML bytecode
From: Pierre Gondois
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2425
This patch modifies the Makefile generation not to stop
adding Makfile rules when the first final target is found.
E.g.:
If the following rules are described in build_rule.txt:
-[Rule1]: .X files generate .Y and .Z
Following the BZ at https://bugzilla.tianocore.org/show_bug.cgi?id=2425
This patch serie is a another way to solve the dependency
of C files over ASL files. With this new method, the
dependency is resolved at the linking stage.
The last method to solve this dependency was to add
the possibility
There are some boards base on D06, but use RX8900 RTC,
so upstream the RX8900RealTimeClockLib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Silicon/Hisilicon/Library/RX8900RealTimeClockLib/RX8900RealTimeClock.h |
41 ++
The functions of acquiring ownership of RTC will be used for other
RTC library, so move them to RtcHelperLib.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ming Huang
---
Platform/Hisilicon/D06/D06.dsc |
1 +
Main Changes:
1 Extract RtcHelperLib from M41T83RealTimeClockLib;
2 Add RX8900RealTimeClockLib;
Ming Huang (2):
Hisilicon/Library: Move two functions to RtcHelperLib
Silicon/Hisilicon: Add RX8900RealTimeClockLib
Platform/Hisilicon/D06/D06.dsc |
The VS2017 compiler reports 'warning C6326: potential
comparison of a constant with another constant' when
a fixed PCD value is compared with a constant value.
The faulting code is as marked by '-->' below:
--> if (FixedPcdGet32 (PL011UartInteger) != 0) {
Integer = FixedPcdGet32
The VS2017 compiler reports 'warning C4244: '=': conversion
from 'UINT64' to 'UINT32', possible loss of data' for the
calculation of the UART Divisor value.
Fix this warning by adding appropriate typecast and a validation
that ensures that the UART divisor value generated does not exceed
This patch series fixes warnings reported by the VS2017 compiler
when the static code analysis option is enabled.
The issues fixed in this series were identified
by building DynamicTablesPkg/DynamicTablesPkg.dsc
using the VS2017 compiler with the static code
analysis option.
This v3 patch series
Hi Bob, Liming,
Is there anything else needed before this patch can be merged?
Regards,
Sami Mujawar
From: Bret Barkelew
Sent: 07 April 2020 10:49 PM
To: devel@edk2.groups.io; Sami Mujawar
Cc: Sami Mujawar ; bob.c.f...@intel.com;
liming@intel.com; l...@nuviainc.com; Matteo Carlini
;
Hi Bret,
On 5/15/20 5:43 PM, Bret Barkelew via groups.io wrote:
I agree with some of your points, but I don’t believe that this calls for
dependencies at all.
Which points are you disagreeing?
If a PR can pass CI with the changes, it’s functionally unordered.
And if a PR can’t, it
https://bugzilla.tianocore.org/show_bug.cgi?id=2713
In current code, If TCG2_PHYSICAL_PRESENCE_FLAGS_VARIABLE variable
is not exist, code will get default value from two places.
This fix is to make the default value comes from the PCD
gEfiSecurityPkgTokenSpaceGuid.PcdTcg2PhysicalPresenceFlags
44 matches
Mail list logo
