Re: [EXTERNAL] [edk2-devel] [PATCH v5 00/14] Add the VariablePolicy feature

Bump. Now that the stable tag is behind us, I’d like to get this in to have maximum time before the next stable tag. I think the only reviews I’ve seen so far are for the platform integrations (Arm, Ovmf, and Embedded). Need more eyeballs, please and thank you! - Bret From: Bret Barkelew via

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v5 00/14] Add the VariablePolicy feature

Happy to take a look at that, and thanks for all the tips. I had tried to register an email address for groups.io that had a “+edk” so that I could filter the emails to be forwarded differently, but it won’t send from that address so that’s probably causing some confusion. Yes, I would prefer

[edk2-devel] [PATCH] MdeModulePkg: Sets the Cursor to selected BootOption.

Its been observed that in MenuManagerMenuApp when user selects a different BootOption using Up/Down key, the current Cursor position is not chaning. Still points to the old BootOption. This changes first dispalys/redraws the old BootOption followed by new BootOption. Doing so will make current

[edk2-devel] [PATCH v2] MdeModulePkg.dec: Change PCDs for status code.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 Change the following PCDs from [PcdsFeatureFlag] to [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]: PcdStatusCodeUseSerial PcdStatusCodeUseMemory The original plaforms can use PcdsFixedAtBuild in .dsc files. Some

Re: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Tue, 06/09/2020 6:30pm-7:30pm #cal-reminder

New submitted bugs are discussed this week. 2788 EDK2 Code michael.d.kin...@intel.com UNCO --- IntelFsp2Pkg.dsc is missing Fsp22SecCoreS.inf 21:48:48

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data

Hi Ming, Agree the change, the caller should own the responsibility to format the string in the input parameter, driver should not append "\r\n" here. Reviewed-by: Eric Dong Next time, please Cc the Package maintainer when send the patch. The maintainer info can be found in Maintainers.txt

[edk2-devel] [edk2-staging/EdkRepo-Manifest] [PATCH] Intel-MinPlatform: Update FSP repo URL

The FSP repo has moved to the new Intel GitHub group. Updating the URL to the new location. Signed-off-by: Nate DeSimone Cc: Ashley DeSimone Cc: Chasel Chiu Cc: Sai Chaganty Cc: Isaac Oram Cc: Liming Gao Cc: Ray Ni Cc: Prince Agyeman Cc: Puja Pandya ---

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Tue, 06/09/2020 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 9 June 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816011 ) *Organizer:* Brian Richardson

Re: [edk2-devel] [edk2-platform][PATCH v3 1/6] Drivers/ASIX: Create ASIX package

Reviewed-by: Ray Ni > -Original Message- > From: Samer El-Haj-Mahmoud > Sent: Monday, June 8, 2020 9:38 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Leif Lindholm ; Ard > Biesheuvel ; Kinney, > Michael D > Subject: [edk2-platform][PATCH v3 1/6] Drivers/ASIX: Create ASIX package > >

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Fix argument checks in manifest-repos

Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Monday, June 8, 2020 5:18 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince ; Bjorge, Erik C Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Fix argument

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Fix argument checks in manifest-repos

Fixed a logic bug in the argument checking for the manifest-repos command. Signed-off-by: Nate DeSimone Cc: Ashley E Desimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge --- edkrepo/commands/humble/manifest_repos_humble.py | 2 +-

Re: [edk2-devel] [PATCH 0/4] ArmVirtPkg: use PE/COFF metadata for self relocation

Thank you Ard. Good catch on jump-table stuff. Acked-by: Jiewen Yao > -Original Message- > From: Ard Biesheuvel > Sent: Tuesday, June 9, 2020 1:34 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Feng, Bob C > ; Gao, Liming ; Laszlo Ersek > ; Leif Lindholm ; Ilias Apalodimas > ;

Re: [edk2-devel] [RFC edk2 v1] StandaloneMmPkg: Relocatable version for StandAloneMM

On 6/7/20 3:17 AM, Yao, Jiewen wrote: Hi Ilias It seems a good idea to support relocatable StMM. Agreed. Thought on StandaloneMmPkg/Core/StandaloneMmCoreRelocatable.inf Usually we do not add special link option in INF and build a module to be ELF for some special purposes. Things might be

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: check for manifest-repos section in edkrepo_user.cfg

Reviewed-by: Erik Bjorge -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, June 8, 2020 2:52 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince ; Bjorge, Erik C Subject: [edk2-devel]

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: check for manifest-repos section in edkrepo_user.cfg

The manifest-repos command currently does not check for the existance of the 'manifest-repos' section in the edkrepo_user.cfg file. This change adds the check. Signed-off-by: Nate DeSimone Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi/RPi4: Add Asset Tag support

Thanks Andrei. I submitted a v2 with the commit message changes. I will also send a follow-up patch to add examples for RPi3/4 config scripting using the Shell From: devel@edk2.groups.io On Behalf Of Andrei Warkentin via groups.io Sent: Monday, June 8, 2020 11:53 AM To: Samer El-Haj-Mahmoud ;

[edk2-devel] [edk2-platform][PATCH v2 1/1] Platforms/RaspberryPi: Add Asset Tag support

Add support for configuring the Chassis Asset Tag in the UI as well as UEFI Shell, and carry the configured value as the Asset Tag string in SMBIOS Types 2 and 3. To configure using the UEFI Shell, use 'setvar' command to read/write the UEFI variable with GUID = gConfigDxeFormSetGuid and

Re: [edk2-devel] [PATCH edk2-platforms 1/5] Silicon/NXP/LS1043A: Fix the Platform PLL calculation

> -Original Message- > From: Leif Lindholm > Sent: Monday, June 8, 2020 7:52 PM > To: Pankaj Bansal (OSS) > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; devel@edk2.groups.io; Varun Sethi > ; Samer El-Haj-Mahmoud mahm...@arm.com>; Augustine Philips ; Ard > Biesheuvel ; Arokia Samy >

[edk2-devel] [PATCH edk2-platforms v5 3/3] Silicon/NXP: PciHostBridgeLib: Initialize only enabled PCIe controllers

From: Wasim Khan Based on the serdes protocol value in reset configuration word (RCW), different PCIe controllers are enabled. Get SerDes protocol map and initialize only enabled PCIe controllers. Signed-off-by: Wasim Khan Reviewed-by: Leif Lindholm --- Notes: Changes in V5: - No

[edk2-devel] [PATCH edk2-platforms v4 1/3] Silicon/NXP/Library: Implement SerDesHelperLib

From: Wasim Khan Implement SerDesHelperLib to provide helper functions which can be used for SoC specific SerDes configuration. Signed-off-by: Wasim Khan --- Notes: Changes in V4: - No Change Changes in V3: - Change variable name LanePrtc to LaneProtocol Changes in V2:

[edk2-devel] [PATCH edk2-platforms v4 0/3] Add SerDes Support

From: Wasim Khan NXP SoCs supports different Serdes protocols using reset configuration word (RCW). Based on Serdes protocol value in reset configuration word (RCW) different IP blocks gets enabled in HW. This patch series implements SerDesHelperLib and provide SoC specific serdes

[edk2-devel] [PATCH edk2-platforms v5 0/3] Add SerDes Support

From: Wasim Khan NXP SoCs supports different Serdes protocols using reset configuration word (RCW). Based on Serdes protocol value in reset configuration word (RCW) different IP blocks gets enabled in HW. This patch series implements SerDesHelperLib and provide SoC specific serdes

[edk2-devel] [PATCH edk2-platforms v4 3/3] Silicon/NXP: PciHostBridgeLib: Initialize only enabled PCIe controllers

From: Wasim Khan Based on the serdes protocol value in reset configuration word (RCW), different PCIe controllers are enabled. Get SerDes protocol map and initialize only enabled PCIe controllers. Signed-off-by: Wasim Khan Reviewed-by: Leif Lindholm --- Notes: Changes in V4: - No

[edk2-devel] [PATCH edk2-platforms v5 1/3] Silicon/NXP/Library: Implement SerDesHelperLib

From: Wasim Khan Implement SerDesHelperLib to provide helper functions which can be used for SoC specific SerDes configuration. Signed-off-by: Wasim Khan --- Notes: Changes in V5: - No Change Changes in V4: - No Change Changes in V3: - Change variable name LanePrtc

[edk2-devel] [PATCH edk2-platforms v4 2/3] Silicon/NXP: LS1043A: Add SerDes Support

From: Wasim Khan Based on SerDes protocol value in reset configuration word (RCW) different IP blocks gets enabled in HW. Add SoC specific SerDes configuration for LS1043A, which can be used by different IPs to know the enabled interfaces and perform the required initialization. Signed-off-by:

[edk2-devel] [PATCH edk2-platforms v5 2/3] Silicon/NXP: LS1043A: Add SerDes Support

From: Wasim Khan Based on SerDes protocol value in reset configuration word (RCW) different IP blocks gets enabled in HW. Add SoC specific SerDes configuration for LS1043A, which can be used by different IPs to know the enabled interfaces and perform the required initialization. Signed-off-by:

Re: [edk2-devel] [PATCH edk2-platforms v1 2/2] Silicon/Hisilicon/Smbios: Optimize type 9

On Mon, Jun 08, 2020 at 22:09:57 +0800, Ming Huang wrote: > Break down AddSmbiosType9Entry to three funtions for optimizing > Smbios type 9. > > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- > Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 173 >

Re: [edk2-devel] Device and driver

Thanks Tom, I really appreciate your reply, I didn't get 100% but I went through ~3K pages of UEFI specification. I understand a bit of protocols and handles now. Handle is an identifier on which some sort of function pointers (protocol in UEFI world) are installed. Thing which I am trying to

Re: [edk2-devel] [RFC edk2 v1] StandaloneMmPkg: Relocatable version for StandAloneMM

Hi Jiewen, On Sun, Jun 07, 2020 at 01:17:11AM +, Yao, Jiewen wrote: > Hi Ilias > It seems a good idea to support relocatable StMM. > > Thought on StandaloneMmPkg/Core/StandaloneMmCoreRelocatable.inf > Usually we do not add special link option in INF and build a module to be ELF > for some

[edk2-devel] [PATCH edk2-platforms v3 3/3] Silicon/NXP: PciHostBridgeLib: Initialize only enabled PCIe controllers

From: Wasim Khan Based on the serdes protocol value in reset configuration word (RCW), different PCIe controllers are enabled. Get SerDes protocol map and initialize only enabled PCIe controllers. Signed-off-by: Wasim Khan Reviewed-by: Leif Lindholm --- Notes: Changes in V3: - No

[edk2-devel] [PATCH edk2-platforms v3 2/3] Silicon/NXP: LS1043A: Add SerDes Support

From: Wasim Khan Based on SerDes protocol value in reset configuration word (RCW) different IP blocks gets enabled in HW. Add SoC specific SerDes configuration for LS1043A, which can be used by different IPs to know the enabled interfaces and perform the required initialization. Signed-off-by:

[edk2-devel] [PATCH edk2-platforms v3 0/3] Add SerDes Support

From: Wasim Khan NXP SoCs supports different Serdes protocols using reset configuration word (RCW). Based on Serdes protocol value in reset configuration word (RCW) different IP blocks gets enabled in HW. This patch series implements SerDesHelperLib and provide SoC specific serdes

[edk2-devel] [PATCH edk2-platforms v3 1/3] Silicon/NXP/Library: Implement SerDesHelperLib

From: Wasim Khan Implement SerDesHelperLib to provide helper functions which can be used for SoC specific SerDes configuration. Signed-off-by: Wasim Khan --- Notes: Changes in V3: - Change variable name LanePrtc to LaneProtocol Changes in V2: - Addressed review comments for

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi4: reserve/map memory above 4GB when present

On 6/8/20 6:02 PM, Pete Batard wrote: On 2020.06.07 08:20, Andrei Warkentin wrote: This makes all 8GB usable on the Pi 4 8GB variant. Like RAM in the 3-4GB range, this is still gated by the option to limit RAM to 3GB. Tested on 4GB and 8GB boards, with and without 3GB limit. Signed-off-by:

[edk2-devel] [PATCH 4/4] ArmVirtPkg: remove unused files

We no longer use ELF PIE executables to implement the self-relocating PrePi so drop the custom linker script and visibility override header file. Signed-off-by: Ard Biesheuvel --- ArmVirtPkg/Include/Platform/Hidden.h | 22 --- ArmVirtPkg/PrePi/Scripts/PrePi-PIE.lds | 41

[edk2-devel] [PATCH 0/4] ArmVirtPkg: use PE/COFF metadata for self relocation

As suggested by Jiewen in response to Ilias RFC [0], it is better to use the PE/COFF metadata for self-relocating executables than to rely on ELF metadata, given how the latter is only available when using ELF based toolchains. Also, we have had some maintenance issues with this code in the past,

[edk2-devel] [PATCH 1/4] ArmVirtPkg: add FDF rule for self-relocating PrePi

In preparation for making the self-relocating PrePi use the ordinary BasePeCoffLib routines for relocating the image in place in memory at start, add a special FDF rule that builds SEC modules as PE32 images with the relocation metadata preserved. Signed-off-by: Ard Biesheuvel ---

[edk2-devel] [PATCH 2/4] BaseTools/Scripts/GccBase.lds: export image base symbol

To help converted ELF images perform self-relocation, export a symbol 'ElfImageBase' that can be used in the code to discover the start of the image in memory. Note the use of PROVIDE() - this ensures that the symbol is only emitted if a reference to it exists in the code being linked, but no

[edk2-devel] [PATCH 3/4] ArmVirtPkg/PrePi: use standard PeCoff routines for self-relocation

Instead of having a GCC specific routine to perform self-relocation based on ELF metadata, use the PE/COFF metadata and the existing PeCoff library routines. This reduces the amount of bespoke assembler code that is a burden to maintain, and is not portable across the set of toolchains we support.

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Revert don't connect all devices on an ordinary boot

On 2020.06.08 18:10, Ard Biesheuvel wrote: On 6/8/20 7:01 PM, Pete Batard wrote: On 2020.06.08 17:43, Ard Biesheuvel wrote: On 6/8/20 5:51 PM, Pete Batard wrote: This reverts commit c8000e83b728baf04ced2fedb870bc3bc1b3 on account of USB keyboard devices not being detected until after the

Re: [edk2-devel] [PATCH edk2 v2 5/5] Silicon/Hisilicon/FlashFvbDxe: Declare missing GUID dependency

On Wed, May 27, 2020 at 22:33:58 +0800, Ming Huang wrote: > FlashFvbDxe depends on gEfiEventVirtualAddressChangeGuid, but got > away with not declaring it in its INF because of a transitive > dependency. However, this dependency got dropped in core EDK2, > resulting in build failures of the D0x

Re: [edk2-devel] [PATCH edk2 v2 1/5] Silicon/Hisilicon: Change updating dsdt in ready to boot event

On Wed, May 27, 2020 at 22:33:54 +0800, Ming Huang wrote: > The dsdt need be updated before boot to OS, so change the updating > to ready to boot event and can remove the needless dependence. > > Signed-off-by: Ming Huang Reviewed-by: Leif Lindholm > --- >

Re: [edk2-devel] [PATCH edk2 v2 3/5] Silicon/Hisilicon/Acpi: Add update sas address feature

Hi Ming, On Wed, May 27, 2020 at 22:33:56 +0800, Ming Huang wrote: > The updating sas address feature is similar with apdating mac address. > Modify updating dsdt flow for add this feature. > > Signed-off-by: Ming Huang > --- > Silicon/Hisilicon/Drivers/AcpiPlatformDxe/AcpiPlatform.c |

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Revert don't connect all devices on an ordinary boot

On 6/8/20 7:01 PM, Pete Batard wrote: On 2020.06.08 17:43, Ard Biesheuvel wrote: On 6/8/20 5:51 PM, Pete Batard wrote: This reverts commit c8000e83b728baf04ced2fedb870bc3bc1b3 on account of USB keyboard devices not being detected until after the timeout to enter the Setup menu or run the

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Revert don't connect all devices on an ordinary boot

On 2020.06.08 17:43, Ard Biesheuvel wrote: On 6/8/20 5:51 PM, Pete Batard wrote: This reverts commit c8000e83b728baf04ced2fedb870bc3bc1b3 on account of USB keyboard devices not being detected until after the timeout to enter the Setup menu or run the UEFI Shell has expired. The core of the

Re: [edk2-devel] [PATCH edk2-platforms v2 2/3] Silicon/NXP: LS1043A: Add SerDes Support

> -Original Message- > From: Leif Lindholm > Sent: Monday, June 8, 2020 9:00 PM > To: Wasim Khan (OSS) > Cc: devel@edk2.groups.io; Meenakshi Aggarwal > ; Varun Sethi ; > ard.biesheu...@arm.com; Wasim Khan > Subject: Re: [PATCH edk2-platforms v2 2/3] Silicon/NXP: LS1043A: Add SerDes >

Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth

On 6/8/20 4:47 PM, Irene Park via Groups.Io wrote: Hi Ard, I feel bad that I confused you. I'll update the commit message later. SBSA spec doesn't "mandate" that the optional registers such as PID2 are present in a UART compliant to PL011. Therefore this register access to PID2 will generate a

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Revert don't connect all devices on an ordinary boot

On 6/8/20 5:51 PM, Pete Batard wrote: This reverts commit c8000e83b728baf04ced2fedb870bc3bc1b3 on account of USB keyboard devices not being detected until after the timeout to enter the Setup menu or run the UEFI Shell has expired. The core of the issue is that, when

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RPi4: reserve/map memory above 4GB when present

On 2020.06.07 08:20, Andrei Warkentin wrote: This makes all 8GB usable on the Pi 4 8GB variant. Like RAM in the 3-4GB range, this is still gated by the option to limit RAM to 3GB. Tested on 4GB and 8GB boards, with and without 3GB limit. Signed-off-by: Andrei Warkentin --- This is the v2

[edk2-devel] [PATCH edk2-platforms v1 2/2] Silicon/Hisilicon/Smbios: Optimize type 9

Break down AddSmbiosType9Entry to three funtions for optimizing Smbios type 9. Signed-off-by: Ming Huang --- Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 173 +++- 1 file changed, 95 insertions(+), 78 deletions(-) diff --git

[edk2-devel] [PATCH edk2-platforms v1 0/2] Optimize type 9

Break down AddSmbiosType9Entry to three funtions for optimizing Smbios type 9. Ming Huang (2): Silicon/Hisilicon/Smbios: correct coding style issue in type 9 Silicon/Hisilicon/Smbios: Optimize type 9 Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 325

[edk2-devel] [PATCH edk2-platforms v1 1/2] Silicon/Hisilicon/Smbios: correct coding style issue in type 9

This patch is prepare for optimizing Smbios type 9. Signed-off-by: Ming Huang --- Silicon/Hisilicon/Drivers/Smbios/AddSmbiosType9/AddSmbiosType9.c | 286 ++-- 1 file changed, 146 insertions(+), 140 deletions(-) diff --git

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi/RPi4: Add Asset Tag support

Looks good to me aside from minor typos in commit message. Also, note that this applies to Pi 3 as well. Would it be possible to have a follow-up change to amend the readmes for RPi3/RPi4 with this setvar example to set AssetTag? Reviewed-by: Andrei Warkentin

[edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RaspberryPi: Revert don't connect all devices on an ordinary boot

This reverts commit c8000e83b728baf04ced2fedb870bc3bc1b3 on account of USB keyboard devices not being detected until after the timeout to enter the Setup menu or run the UEFI Shell has expired. The core of the issue is that, when EfiBootManagerConnectAll() is not invoked, PCI bus scanning

Re: [edk2-devel] [PATCH edk2-platforms v1 1/2] Silicon/Hisilicon/Smbios: correct coding style issue in type 9

On Mon, Jun 08, 2020 at 22:09:56 +0800, Ming Huang wrote: > This patch is prepare for optimizing Smbios type 9. How? The commit message should describe what the patch does. (Yes, I can see with "git diff -w" that this is mainly whitespace/indentation fixes and wrapping of long lines, but the

Re: [edk2-devel] [PATCH edk2-platforms v2 3/3] Silicon/NXP: PciHostBridgeLib: Initialize only enabled PCIe controllers

On Sun, Jun 07, 2020 at 18:45:50 +0530, Wasim Khan wrote: > From: Wasim Khan > > Based on the serdes protocol value in reset configuration > word (RCW), different PCIe controllers are enabled. > Get SerDes protocol map and initialize only enabled PCIe > controllers. > > Signed-off-by: Wasim

Re: [edk2-devel] [PATCH edk2-platforms v2 2/3] Silicon/NXP: LS1043A: Add SerDes Support

On Sun, Jun 07, 2020 at 18:45:49 +0530, Wasim Khan wrote: > From: Wasim Khan > > Based on SerDes protocol value in reset configuration word (RCW) > different IP blocks gets enabled in HW. > Add SoC specific SerDes configuration for LS1043A, which can be > used by different IPs to know the

Re: [edk2-devel] [PATCH edk2-platforms v2 1/3] Silicon/NXP/Library: Implement SerDesHelperLib

On Sun, Jun 07, 2020 at 18:45:48 +0530, Wasim Khan wrote: > From: Wasim Khan > > Implement SerDesHelperLib to provide helper functions which > can be used for SoC specific SerDes configuration. > > Signed-off-by: Wasim Khan > --- > > Notes: > Changes in V2: > - Addressed review

Re: [edk2-devel] [PATCH V2 2/2] UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB

Hi, Ray, I noticed in this V2 patch, you removed the following line from the DSC file. gEfiMdePkgTokenSpaceGuid.PcdPciExpressBaseAddress|$(PCIE_BASE) It will make the PcdPciExpressBaseAddress become PcdsFixedAtBuild type instead of PcdsDynamicDefault. Is this your intention ? Also this V2

Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth

Hi Ard, I feel bad that I confused you. I'll update the commit message later. SBSA spec doesn't "mandate" that the optional registers such as PID2 are present in a UART compliant to PL011. Therefore this register access to PID2 will generate a fault onto SOC when its UART doesn't provide such

Re: [edk2-devel] [PATCH edk2-platforms 1/5] Silicon/NXP/LS1043A: Fix the Platform PLL calculation

On Fri, Jun 05, 2020 at 17:18:54 +, Pankaj Bansal (OSS) wrote: > > On Tue, Jun 02, 2020 at 18:54:59 +0530, Pankaj Bansal wrote: > > > From: Pankaj Bansal > > > > > > for LS1043A SOC the DCFG registers are read in big endian format. > > > However current Platofmr PLL calculation is being done

Re: [edk2-devel] [PATCH v1 1/3] BaseTools: Generate multiple rules when multiple output files

Hello Bob, Should I modify the patch ? Regards, Pierre -Original Message- From: Pierre Gondois Sent: Tuesday, June 2, 2020 2:04 PM To: Feng, Bob C ; devel@edk2.groups.io Cc: Gao, Liming ; Sami Mujawar ; Tomas Pilar ; nd Subject: RE: [edk2-devel] [PATCH v1 1/3] BaseTools: Generate

[edk2-devel] [edk2-platform][PATCH v3 0/6] Update ASIX USB Networking drivers

This series updates the ASIX USB networking drivers: - Create new Drivers/ASIX/ package - Add new ASIX drivers Ax88179 and Ax88772c to the new ASIX package - Delete old Ax88772 and Ax88772b drivers from OptionRomPkg Code pushed to

[edk2-devel] [edk2-platform][PATCH v3 5/6] Platform/HiSilicon: Switch HiKey USB NIC driver to Ax88772c

Switch the ASIX USB NIC driver used in HiKey to the new Ax88772c. Cc: Ard Biesheuvel Cc: Andrei Warkentin Signed-off-by: Samer El-Haj-Mahmoud --- Platform/Hisilicon/HiKey/HiKey.dsc | 2 +- Platform/Hisilicon/HiKey/HiKey.fdf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-platform][PATCH v3 1/6] Drivers/ASIX: Create ASIX package

Create a new ASIX package for build verification of ASIX USB drivers. Cc: Ray Ni Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D Kinney Signed-off-by: Samer El-Haj-Mahmoud --- Drivers/ASIX/Asix.dec | 30 + Drivers/ASIX/Asix.dsc | 67 2 files changed, 97

[edk2-devel] [edk2-platform][PATCH v3 4/6] Platform/RaspberryPi: Switch RPi3 USB NIC driver to Ax88772c

Switch the ASIX USB NIC driver used in the RPi3 to the new Ax88772c. Cc: Ard Biesheuvel Cc: Pete Batard Cc: Andrei Warkentin Cc: Leif Lindholm Signed-off-by: Samer El-Haj-Mahmoud --- Platform/RaspberryPi/RPi3/RPi3.dsc | 2 +- Platform/RaspberryPi/RPi3/RPi3.fdf | 2 +- 2 files changed, 2

Re: [edk2-devel] [PATCH edk2-platforms 1/2] Silicon/NXP: Add SATA controller initialization driver

Hi Ard, Reply inline. > -Original Message- > From: Ard Biesheuvel > Sent: Friday, June 5, 2020 6:30 PM > To: Meenakshi Aggarwal (OSS) ; > l...@nuviainc.com; michael.d.kin...@intel.com; devel@edk2.groups.io > Cc: Varun Sethi ; Meenakshi Aggarwal > > Subject: Re: [PATCH edk2-platforms

Re: [edk2-devel] Device and driver

Hi, By no means a complete answer but some important points below. There are two important concepts in UEFI that you absolutely need to get comfortable with. These two are Handles and Protocols. You can think of a protocol as an implementation of a well defined API that allows you to do

[edk2-devel] [PATCH 1/2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2787 When output string data through serial port, will not ouput \n\r now. Caller can output several data in one line, and output \n\r when needed. Signed-off-by: Ming Tan --- .../Universal/StatusCodeHandler/Pei/SerialStatusCodeWorker.c|

[edk2-devel] [PATCH 2/2] MdeModulePkg.dec: Change PCDs for status code.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2786 In order to support enable/disable report status code through memory and serial dynamic, change the following PCDs from PcdsFeatureFlag to PcdsDynamic: PcdStatusCodeUseSerial PcdStatusCodeUseMemory Signed-off-by: Ming Tan ---

[edk2-devel] Device and driver

Hi Edk2 expert folks, I am starting on UEFI coming from Linux background, In Linux, There is clear identification of device and driver, platform code adds the device into system and later OS code binds driver for the same. With UEFI driver writer guide, I am bit confused, please help me, how

Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth

On 6/6/20 5:23 AM, Irene Park via groups.io wrote: From: Irene Park PL011UartLib determines its FIFO depth based on the PID2 value but the register PID2 is not mandatory in the SBSA spec. This change adds a new 32bit PCD reference to define a FIFO depth and make PL011UartLib available for the

Re: [edk2-devel] [PATCH] OvmfPkg/X86QemuLoadImageLib: handle EFI_ACCESS_DENIED from LoadImage()

On 6/6/20 1:52 AM, Laszlo Ersek wrote: When an image fails Secure Boot validation, LoadImage() returns EFI_SECURITY_VIOLATION if the platform policy is DEFER_EXECUTE_ON_SECURITY_VIOLATION. If the platform policy is DENY_EXECUTE_ON_SECURITY_VIOLATION, then LoadImage() returns EFI_ACCESS_DENIED

Re: [edk2-devel] IsaBus driver's usage

Hi Nate: Got it. Thanks 发件人: devel@edk2.groups.io 代表 Nate DeSimone 发送时间: 2020年5月29日 15:08 收件人: devel@edk2.groups.io; Tiger Liu(BJ-RD) 主题: Re: [edk2-devel] IsaBus driver's usage Hi Tiger, I believe you are assuming that IsaBusDxe and SioDxe do the same thing, that is not the case. These two

Re: [edk2-devel] [PATCH] MdeModulePkg: Sets the Cursor to selected BootOption.

Hi All, I will push the patch tomorrow if don't get any objection. Thanks, Dandan > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dandan > Bi > Sent: Thursday, May 7, 2020 4:52 PM > To: Abdul Lateef Attar ; devel@edk2.groups.io > Cc: Dong, Eric ; Wang, Jian J ; > Wu, Hao

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update

Hi All, Is there any concern for this patch? I will push this patch tomorrow if don't get any objection? Thanks, Dandan > -Original Message- > From: Li, Walon > Sent: Wednesday, June 3, 2020 6:56 PM > To: Bi, Dandan ; devel@edk2.groups.io; Gao, Liming > > Cc: Wang, Nickle (HPS SW) ;

Re: [edk2-devel] [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth

Hello Ard Biesheuvel, Would you please review this change? Thank you, Irene -Original Message- From: Irene Park Sent: Friday, June 5, 2020 11:23 PM To: devel@edk2.groups.io Cc: Irene Park Subject: [PATCH] ArmPlatformPkg/PL011UartLib: Add PCD for FIFO depth From: Irene Park