[edk2-devel] [PATCH v3] Features/Intel/BeepDebugFeaturePkg: add it.

2020-06-10 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2792 The BeepDebugFeaturePkg include some useful beep debug libraries, such as get beep value from status code and beep. It provide a library BeepStatusCodeHandlerLib used by edk2 StatusCodeHandler.efi, used to do beep if needed. It also provide

Re: [edk2-devel] [PATCH v2] Features/Intel/BeepDebugFeaturePkg: add it.

2020-06-10 Thread Dong, Eric
Hi Ming, > -Original Message- > From: Tan, Ming > Sent: Thursday, June 11, 2020 9:05 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [PATCH v2] Features/Intel/BeepDebugFeaturePkg: add it. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2792 > > The BeepD

Re: [edk2-devel] UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib

2020-06-10 Thread Ni, Ray
UefiCpuLib is in UefiCpuPkg. All consumers are in UefiCpuPkg. I think we can keep its location unchanged. From: Dong, Eric Sent: Thursday, June 11, 2020 9:29 AM To: Ni, Ray ; devel@edk2.groups.io; garrett.kirkend...@amd.com Cc: Laszlo Ersek Subject: RE: UefiCpuPkg: Discuss: Move StandardSignatur

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg: smbiosview - print field values as unsigned integers

2020-06-10 Thread Gao, Zhichao
Reviewed- by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Philippe Mathieu-Daudé > Sent: Thursday, May 7, 2020 2:57 AM > To: Rebecca Cran ; devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao > Subject: Re: [PATCH v2 1/1] ShellPkg: smbiosview - print field values as > unsig

Re: [edk2-devel] [edk2-platforms] [PATCH] KabyLakeSiliconPkg: Bitmask comparison logic bug

2020-06-10 Thread Chaganty, Rangasai V
Good catch. Reviewed-by: Sai Chaganty -Original Message- From: Desimone, Nathaniel L Sent: Tuesday, June 09, 2020 5:31 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V Subject: [edk2-platforms] [PATCH] KabyLakeSiliconPkg: Bitmask comparison logic bug (Cpptv & B_P

Re: [edk2-devel] UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib

2020-06-10 Thread Dong, Eric
This proposal is ok to me. I'm not sure whether it can be added to MdePkg, just like add to CpuLib. I found all the definitions and functions used in StandardSignatureIsAuthenticAMD function defined in MdePkg. If it can be added to MdePkg, all code base can use this function, if it been added

Re: [edk2-devel] UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib

2020-06-10 Thread Ni, Ray
Since all platform DSCs have already listed UefiCpuLib.inf so this change doesn't impact platform DSC. I don't see an issue with this change. Eric, What's your opinion? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kirkendall, > Garrett > Sent: Wednesday,

[edk2-devel] [PATCH v2] Features/Intel/PostCodeDebugFeaturePkg: add it.

2020-06-10 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2478 The PostCodeDebugFeaturePkg include some useful post code debug libraries, such as get post code from status code and show it. It provide a library PostCodeStatusCodeHandlerLib used by edk2 StatusCodeHandler.efi, used to show the post code.

[edk2-devel] [PATCH v2] Features/Intel/BeepDebugFeaturePkg: add it.

2020-06-10 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2792 The BeepDebugFeaturePkg include some useful beep debug libraries, such as get beep value from status code and beep. It provide a library BeepStatusCodeHandlerLib used by edk2 StatusCodeHandler.efi, used to do beep if needed. It also provide

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 0/3] Small fixes to submodule support

2020-06-10 Thread Ashley E Desimone
For the series... Reviewed-by: Ashley DeSimone -Original Message- From: Bjorge, Erik C Sent: Wednesday, June 10, 2020 3:14 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PA

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.

2020-06-10 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: Bjorge, Erik C Sent: Wednesday, June 10, 2020 3:07 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fi

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1 2/2] EdkRepo: Adding backwards compatibility for old pin files

2020-06-10 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: Bjorge, Erik C Sent: Tuesday, June 9, 2020 4:04 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v1 2/2] EdkRepo: A

Re: [edk2-devel] [PATCH v2] MdePkg/BasePrintLib: avoid absolute addresses for error strings

2020-06-10 Thread Michael D Kinney
Ard, Can you add a comment block before each array and explain the hardcoded 25 and 21 values. I assume that is the length of the longest string +1 for the Null-terminator. I assume if a string is added or modified that is longer than the fixed size the compiler will throw an error. So hopeful

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 3/3] EdkRepo: Fix submodule failures when switching combos.

2020-06-10 Thread Bjorge, Erik C
When switching combinations or checking out pins the submodule information may change or have modifications that will cause errors. Before changing to a new combination all submodules should be removed. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyema

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 1/3] EdkRepo: Add force flag when removing submodules

2020-06-10 Thread Bjorge, Erik C
Submodules may generate un-tracked or modify files in the repo. when removing the submodule do so even with modifications. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge --- project_utils/submodule.py

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 2/3] EdkRepo: Adding backwards compatibility for old pin files

2020-06-10 Thread Bjorge, Erik C
Older pin files used the invalid enable_submodule attribute. This has been fixed for new pin files but we need to be able to support older pin files as well. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjor

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v2 0/3] Small fixes to submodule support

2020-06-10 Thread Bjorge, Erik C
Fixed issues when submodule has untracked files and can't be deinitialized. Fixed backwards compatibility issue with old pin files. Fixed issue when switching combos to handle submodule removals. Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc:

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixed missing parameter in error string.

2020-06-10 Thread Bjorge, Erik C
Cc: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Erik Bjorge --- edkrepo/commands/checkout_command.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/edkrepo/commands/checkout_command.py b/edkrep

Re: [edk2-devel] [PATCH 2/4] BaseTools/Scripts/GccBase.lds: export image base symbol

2020-06-10 Thread Ard Biesheuvel
On 6/8/20 7:34 PM, Ard Biesheuvel wrote: To help converted ELF images perform self-relocation, export a symbol 'ElfImageBase' that can be used in the code to discover the start of the image in memory. Note the use of PROVIDE() - this ensures that the symbol is only emitted if a reference to it e

Re: [edk2-devel] [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some PCDs type

2020-06-10 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Tan, Ming Sent: Tuesday, June 09, 2020 4:24 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V Subject: [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some PCDs type REF: https://b

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.

2020-06-10 Thread Nate DeSimone
Please fix copyright year. With that change... Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Tuesday, June 9, 2020 7:33 PM To: devel@edk2.groups.io Cc: Ma, Maurice ; Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Ds

Re: [edk2-devel] [PATCH 0/4] ArmVirtPkg: use PE/COFF metadata for self relocation

2020-06-10 Thread Sami Mujawar
Hi Ard, I have made corresponding changes to the Kvmtool port patch series (that I am working on) and can confirm this patchset works. Not sure if Tested-by would be correct in the context that the Kvmtool port is not yet merged. In either case. Tested-by: Sami Mujawar Acked-by: Sami Mujawar

Re: [edk2-devel] [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some PCDs type

2020-06-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Tan, Ming Sent: Tuesday, June 9, 2020 4:24 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V Subject: [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some PCDs type REF: https://bu

Re: [edk2-devel] [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change some PCDs type

2020-06-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Tan, Ming Sent: Tuesday, June 9, 2020 4:24 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change some PCDs type REF: https://bugzilla.tianocore.org/

Re: [edk2-devel] [PATCH 4/5] Platform/Intel/KabylakeOpenBoardPkg: Change some PCDs type

2020-06-10 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Tan, Ming Sent: Tuesday, June 9, 2020 4:24 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [PATCH 4/5] Platform/Intel/KabylakeOpenBoardPkg: Change some PCDs type REF: https://bugzilla.tianocore.org/show

[edk2-devel] [PATCH v2] MdePkg/BasePrintLib: avoid absolute addresses for error strings

2020-06-10 Thread Ard Biesheuvel
The mStatusString[] array is constructed as an array of pointer-to-char, which means that on X64 or AARCH64, it is emitted as a single linear list of 64-bit quantities, each containing the absolute address of one of the string literals in memory. This means that each string takes up 8 bytes of add

Re: [edk2-devel] [PATCH 4/5] StandaloneMmPkg: generate position independent code for StMM core

2020-06-10 Thread Ard Biesheuvel
On 6/10/20 8:21 PM, Sean Brogan wrote: Ard, I see you are only doing this for GCC? Is it not needed for VS or clang? Are these toolchains not supported for StandaloneMmPkg? This works with Clang as well as GCC (Clang is part of the GCC toolchain family in EDK2) None of the AArch64 platf

Re: [edk2-devel] [PATCH 4/5] StandaloneMmPkg: generate position independent code for StMM core

2020-06-10 Thread Sean
Ard, I see you are only doing this for GCC? Is it not needed for VS or clang? Are these toolchains not supported for StandaloneMmPkg? Not trying to hold up your work and don't expect you to enable every toolchain but also don't like the idea of only building out support for a single toolcha

Re: [edk2-devel] [edk2-platforms][PATCH v1 3/4] Platform/ARM/N1SDP: Implement n1sdp specific PciExpressLib

2020-06-10 Thread Ard Biesheuvel
On 4/24/20 1:58 PM, Pranav Madhu via groups.io wrote: From: Deepak Pandey A slave error is generated when host accesses the config space of non-available device or unimplemented function on a given bus. So implement a n1sdp specific PciExpressLib library with a workaround to return 0x f

Re: [edk2-devel] [edk2-platforms][PATCH v1 2/4] Platform/ARM/N1SDP: Add EDK2 build system files

2020-06-10 Thread Ard Biesheuvel
On 4/24/20 1:58 PM, Pranav Madhu via groups.io wrote: From: Deepak Pandey Add EDK Build system files for Neoverse N1 System Development Platform. Signed-off-by: Pranav Madhu --- Platform/ARM/N1SdpPkg/N1SdpPlatform.dec | 31 +++ Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc | 222 +++

Re: [edk2-devel] [edk2-platforms][PATCH v1 1/4] Platform/ARM/N1SDP: Add platform library implementation

2020-06-10 Thread Ard Biesheuvel
On 4/24/20 1:58 PM, Pranav Madhu via groups.io wrote: From: Deepak Pandey N1SDP (Neoverse N1 System Development Platform) platform library support. This includes the virtual memory map and helper functions for platform intialization. Signed-off-by: Pranav Madhu --- Platform/ARM/N1SdpPkg/Lib

Re: [edk2-devel] [PATCH] ArmPkg/ArmExceptionLib: use static buffer for sp_el0

2020-06-10 Thread Ard Biesheuvel
On 6/9/20 3:26 AM, Heyi Guo wrote: The exception library is also used in DxeMain before memory services are available, and AllocatePages() will fail in this case and cause sp_el0 remains 0. Then if any exception occurs before CpuDxe driver is loaded, a recursive exception will be trigged by page

Re: [edk2-devel] [PATCH 1/5] MdePkg/BasePrintLib: avoid absolute addresses for error strings

2020-06-10 Thread Ard Biesheuvel
On 6/10/20 5:09 PM, Michael D Kinney via groups.io wrote: Hi Ard, The size reduction is very interesting. Would be good to see uncompressed size differences as well because this lib is also used in pre-memory XIP modules that are fixed up by the build tools that handle the relocation fixups.

Re: [edk2-devel] [PATCH 1/5] MdePkg/BasePrintLib: avoid absolute addresses for error strings

2020-06-10 Thread Michael D Kinney
Hi Ard, The size reduction is very interesting. Would be good to see uncompressed size differences as well because this lib is also used in pre-memory XIP modules that are fixed up by the build tools that handle the relocation fixups. The more general concern I have is if there are standard C c

Re: [edk2-devel] [PATCH v9 12/46] OvmfPkg/VmgExitLib: Implement library support for VmgExitLib in OVMF

2020-06-10 Thread Lendacky, Thomas
On 6/10/20 7:26 AM, Laszlo Ersek wrote: > Hi Tom, > > On 06/05/20 15:27, Tom Lendacky wrote: >> The base VmgExitLib library provides a default limited interface. As it >> does not provide full support, create an OVMF version of this library to >> begin the process of providing full support of SEV-

[edk2-devel] UefiCpuPkg: Discuss: Move StandardSignatureIsAuthenticAMD function to BaseUefiCpuLib

2020-06-10 Thread Kirkendall, Garrett
[AMD Public Use] There are currently three instances of StandardSignatureIsAuthenticAMD Function in the below locations. I need to propose another change that will require the same function in PiSmmCpuDxeSmm. I would like to see this function move to a single "LibraryClass" location. I think

Re: [edk2-devel] [PATCH v9 09/46] OvmfPkg: Prepare OvmfPkg to use the VmgExitLib library

2020-06-10 Thread Lendacky, Thomas
On 6/10/20 7:08 AM, Laszlo Ersek wrote: > Hi Tom, > > On 06/05/20 15:27, Tom Lendacky wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7Cae12d2d0f5c94ee905c708d80d3711e6%7C

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Dsc.

2020-06-10 Thread Chiu, Chasel
Thanks Sean and I will correct the copyright typo. We will evaluate Core CI enabling. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sean > Sent: Wednesday, June 10, 2020 2:55 PM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Ma, Maurice ; Desimone, Nathaniel L > ; Zeng,

Re: [edk2-devel] [PATCH v9 16/46] OvmfPkg/VmgExitLib: Add support for MSR_PROT NAE events

2020-06-10 Thread Laszlo Ersek
On 06/05/20 15:27, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a MSR_PROT intercept generates a #VC exception. VMGEXIT must > be used to allow the hypervisor to handle this intercept. > > Add support to construct the required GHCB values to supp

Re: [edk2-devel] [PATCH v9 15/46] OvmfPkg/VmgExitLib: Add support for CPUID NAE events

2020-06-10 Thread Laszlo Ersek
On 06/05/20 15:27, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a CPUID intercept generates a #VC exception. VMGEXIT must be > used to allow the hypervisor to handle this intercept. > > Add support to construct the required GHCB values to support

Re: [edk2-devel] [PATCH v9 14/46] OvmfPkg/VmgExitLib: Support string IO for IOIO_PROT NAE events

2020-06-10 Thread Laszlo Ersek
On 06/05/20 15:27, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Add support to the #VC exception handler to handle string IO. This > requires expanding the IO instruction parsing to recognize string based > IO instructions as well as preparing an un-encrypted b

Re: [edk2-devel] [PATCH v9 13/46] OvmfPkg/VmgExitLib: Add support for IOIO_PROT NAE events

2020-06-10 Thread Laszlo Ersek
On 06/05/20 15:27, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Under SEV-ES, a IOIO_PROT intercept generates a #VC exception. VMGEXIT > must be used to allow the hypervisor to handle this intercept. > > Add support to construct the required GHCB values to sup

Re: [edk2-devel] [PATCH v3 11/17] NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Maciej Rabeda
Reviewed-by: Maciej Rabeda On 10-Jun-20 10:14, Shenglei Zhang wrote: Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Shenglei Zhang --- NetworkPkg/N

Re: [edk2-devel] [PATCH v9 12/46] OvmfPkg/VmgExitLib: Implement library support for VmgExitLib in OVMF

2020-06-10 Thread Laszlo Ersek
Hi Tom, On 06/05/20 15:27, Tom Lendacky wrote: > The base VmgExitLib library provides a default limited interface. As it > does not provide full support, create an OVMF version of this library to > begin the process of providing full support of SEV-ES within OVMF. > > SEV-ES support is only provid

Re: [edk2-devel] [PATCH v9 09/46] OvmfPkg: Prepare OvmfPkg to use the VmgExitLib library

2020-06-10 Thread Laszlo Ersek
Hi Tom, On 06/05/20 15:27, Tom Lendacky wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 > > Various CpuExceptionHandlerLib libraries will updated to use the new > VmgExitLib library. To prevent any build breakage, update the OvmfPkg > DSC files that use a form of the CpuException

[edk2-devel] [PATCH] Features/Intel/BeepDebugFeaturePkg: add it.

2020-06-10 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2792 The BeepDebugFeaturePkg include some useful beep debug libraries, such as get beep value from status code and beep. It provide a library BeepStatusCodeHandlerLib used by edk2 StatusCodeHandler.efi, used to do beep if needed. It also provide

Re: [edk2-devel] [PATCH 0/5] StandaloneMmPkg: make StMM core relocatable

2020-06-10 Thread Ilias Apalodimas
Hi Ard, Tested on QEMU with the op-tee patches i mentioned in my RFC [1] Everything seems to work correctly [1] https://edk2.groups.io/g/devel/message/60835 On Wed, Jun 10, 2020 at 10:17:35AM +0200, Ard Biesheuvel wrote: > It is not always possible to deploy the standalone MM core in a way whe

[edk2-devel] [PATCH edk2-platforms 8/8] Silicon/NXP: LX2160A: Add SocGetSvr API

2020-06-10 Thread Wasim Khan
From: Wasim Khan Add SocGetSvr API to get the System Version Register(SVR) Signed-off-by: Wasim Khan --- Silicon/NXP/LX2160A/Library/SocLib/SocLib.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Silicon/NXP/LX2160A/Library/SocLib/SocLib.c b/Silicon/NXP/LX2160A/Library/So

[edk2-devel] [PATCH edk2-platforms 7/7] Platform/NXP: LX2160aRdbPkg: Enable PCIE support

2020-06-10 Thread Wasim Khan
From: Wasim Khan Enable generic PCIe drivers and Wire up PciHostBridgeLib, PciSegmentLib and PciCpuIo2Dxe. Signed-off-by: Wasim Khan --- Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 9 + Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 7 +++ 2 files changed, 16 insertions(+) diff

[edk2-devel] [PATCH edk2-platforms 2/8] Silicon/NXP: Chassis2: define SVR macros

2020-06-10 Thread Wasim Khan
From: Wasim Khan Define macros to retrieve System Version Register(SVR) related information Signed-off-by: Wasim Khan --- Silicon/NXP/Chassis2/Include/Chassis.h | 4 1 file changed, 4 insertions(+) diff --git a/Silicon/NXP/Chassis2/Include/Chassis.h b/Silicon/NXP/Chassis2/Include/Chassi

[edk2-devel] [PATCH edk2-platforms 5/8] Silicon/NXP: Chassis3V2: Add SVR and DEVDISRn in device configuration

2020-06-10 Thread Wasim Khan
From: Wasim Khan System Version Register(SVR) is used to provide the SoC details like Manufacturer ID, SoC Family, SoC major and minor version etc. DEVDISRn is used to disable unused peripherals. Update Device Configuration structure for SVR and DEVDISRn. Signed-off-by: Wasim Khan --- Silicon

[edk2-devel] [PATCH edk2-platforms 3/8] Silicon/NXP: LS1043A: Define SVR for LS1043A SoC

2020-06-10 Thread Wasim Khan
From: Wasim Khan Define System Version Register(SVR) for LS1043A SoC Signed-off-by: Wasim Khan --- Silicon/NXP/LS1043A/Include/Soc.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Silicon/NXP/LS1043A/Include/Soc.h b/Silicon/NXP/LS1043A/Include/Soc.h index 97a77d3f5da6..21b0dafffe91 10

[edk2-devel] [PATCH edk2-platforms 7/8] Silicon/NXP: LX2160A: Define SVR for LX2160A SoC

2020-06-10 Thread Wasim Khan
From: Wasim Khan Define System Version Register(SVR) for LX2160A SoC Signed-off-by: Wasim Khan --- Silicon/NXP/LX2160A/Include/Soc.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Silicon/NXP/LX2160A/Include/Soc.h b/Silicon/NXP/LX2160A/Include/Soc.h index 52674ee5f32c..6c745d580a6d 10

[edk2-devel] [PATCH edk2-platforms 0/1] Silicon/NXP: LX2160A: Add SerDes Support

2020-06-10 Thread Wasim Khan
From: Wasim Khan NXP SoCs supports different Serdes protocols using reset configuration word (RCW). Based on Serdes protocol value in reset configuration word (RCW) different IP blocks gets enabled in HW. This patch add Serdes support for LX2160A, which has 3 Serdes. This patch has dependency

[edk2-devel] [PATCH edk2-platforms 0/8] Silicon/NXP: Add SVR and DEVDISRn configuration

2020-06-10 Thread Wasim Khan
From: Wasim Khan System Version Register(SVR) is used to provide the SoC details like Manufacturer ID, SoC Family, SoC major and minor version etc. DEVDISRn is used to disable unused peripherals. This patch series update device configuration structure (DCFG) for SVR and DEVDISRn for LS1043A (Cha

[edk2-devel] [PATCH edk2-platforms 4/8] Silicon/NXP: LS1043A: Add SocGetSvr API

2020-06-10 Thread Wasim Khan
From: Wasim Khan Add SocGetSvr API to get the System Version Register(SVR) Signed-off-by: Wasim Khan --- Silicon/NXP/Include/Library/SocLib.h| 7 +++ Silicon/NXP/LS1043A/Library/SocLib/SocLib.c | 14 ++ 2 files changed, 21 insertions(+) diff --git a/Silicon/NXP/Includ

[edk2-devel] [PATCH edk2-platforms 1/7] Platform/NXP: LX2160aRdbPkg: Add PCIe space in VirtualMemoryMap

2020-06-10 Thread Wasim Khan
From: Wasim Khan Add PCIe space in VirtualMemoryMap Signed-off-by: Wasim Khan --- Silicon/NXP/LX2160A/Include/Soc.h | 8 + Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem.c | 38 +++- 2 files changed, 45 insertions(

[edk2-devel] [PATCH edk2-platforms 4/7] Platform/NXP: LX2160aRdbPkg: Enable PlatformDxe driver

2020-06-10 Thread Wasim Khan
From: Wasim Khan Enable PlatformDxe driver for LX2160aRdbPkg Signed-off-by: Wasim Khan --- Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 2 ++ Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 3 +++ 2 files changed, 5 insertions(+) diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc b/P

[edk2-devel] [PATCH edk2-platforms 0/7] NXP: Add PCIe Support for LX2160aRdbPkg

2020-06-10 Thread Wasim Khan
From: Wasim Khan This patch series adds PCIe support for LX2160aRdbPkg. LX2160-Rev1 and LX2160-Rev2 has different PCIe controller. Platform driver checks the SoC version and enable corresponding PCIe controller and its feature using dynamic PCDs. PciHostBridgeLib and PciSegmentLib already has s

[edk2-devel] [PATCH edk2-platforms 1/8] Silicon/NXP: Chassis2: Add SVR and DEVDISRn device configuration

2020-06-10 Thread Wasim Khan
From: Wasim Khan System Version Register(SVR) is used to provide the SoC details like Manufacturer ID, SoC Family, SoC major and minor version etc. DEVDISRn is used to disable unused peripherals. Update Device Configuration structure for SVR and DEVDISRn. Signed-off-by: Wasim Khan --- Silicon

[edk2-devel] [PATCH edk2-platforms 6/7] Platform/NXP: LX2160aRdbPkg: Enable NetworkPkg

2020-06-10 Thread Wasim Khan
From: Wasim Khan Enable NetworkPkg for LX2160aRdbPkg Platform. Signed-off-by: Wasim Khan --- Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 11 +++ Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 5 + 2 files changed, 16 insertions(+) diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160

[edk2-devel] [PATCH edk2-platforms 3/7] Platform/NXP: LX2160aRdbPkg: Add PlatformDxe driver

2020-06-10 Thread Wasim Khan
From: Wasim Khan Add PlatformDxe to do platform specific work. At present it perform platform specific Pci initialization. Signed-off-by: Wasim Khan --- Platform/NXP/LX2160aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf | 35 + Platform/NXP/LX2160aRdbPkg/Drivers/PlatformDxe/PlatformDxe.c

[edk2-devel] [PATCH edk2-platforms 1/1] Silicon/NXP: LX2160A: Add SerDes Support

2020-06-10 Thread Wasim Khan
From: Wasim Khan Based on SerDes protocol value in reset configuration word (RCW) different IP blocks gets enabled in HW. Add SoC specific SerDes configuration for LX2160A, which can be used by different IPs to know the enabled interfaces and perform the required initialization. Signed-off-by: W

[edk2-devel] [PATCH edk2-platforms 5/7] Platform/NXP: LX2160aRdbPkg: Hide Root Port for LX2160A-Rev2

2020-06-10 Thread Wasim Khan
From: Wasim Khan PCIe Layerscape controller in LX2160A-Rev2 is not completely ECAM-compliant. It is non-ECAM only for the root bus (bus 0) and for any other bus underneath the root bus it does support ECAM access. One approach can be to setup the controller in firmware and expose bus[0x1-0xff] to

[edk2-devel] [PATCH edk2-platforms 2/7] Silicon/NXP: LX2160A: Define PCIe related PCDs

2020-06-10 Thread Wasim Khan
From: Wasim Khan Define PCIe related PCDs for LX2160A. Signed-off-by: Wasim Khan --- Silicon/NXP/LX2160A/LX2160A.dsc.inc | 5 + 1 file changed, 5 insertions(+) diff --git a/Silicon/NXP/LX2160A/LX2160A.dsc.inc b/Silicon/NXP/LX2160A/LX2160A.dsc.inc index fe8ed402fc4e..43e361464c8e 100644 -

[edk2-devel] [PATCH edk2-platforms 6/8] Silicon/NXP: Chassis3V2: define SVR macros

2020-06-10 Thread Wasim Khan
From: Wasim Khan Define macros to retrieve System Version Register(SVR) related information Signed-off-by: Wasim Khan --- Silicon/NXP/Chassis3V2/Include/Chassis.h | 4 1 file changed, 4 insertions(+) diff --git a/Silicon/NXP/Chassis3V2/Include/Chassis.h b/Silicon/NXP/Chassis3V2/Include/

Re: [edk2-devel] [PATCH v3 14/14] OvmfPkg: use generic QEMU image loader for secure boot enabled builds

2020-06-10 Thread Ard Biesheuvel
On 6/10/20 11:22 AM, Laszlo Ersek wrote: On 06/09/20 12:45, Ard Biesheuvel wrote: On 6/9/20 11:51 AM, Laszlo Ersek via groups.io wrote: Hi Ard, On 03/05/20 14:46, Ard Biesheuvel wrote: The QemuLoadImageLib implementation we currently use for all OVMF builds copies the behavior of the QEMU loa

Re: [edk2-devel] [PATCH v3 14/14] OvmfPkg: use generic QEMU image loader for secure boot enabled builds

2020-06-10 Thread Laszlo Ersek
On 06/09/20 12:45, Ard Biesheuvel wrote: > On 6/9/20 11:51 AM, Laszlo Ersek via groups.io wrote: >> Hi Ard, >> >> On 03/05/20 14:46, Ard Biesheuvel wrote: >>> The QemuLoadImageLib implementation we currently use for all OVMF >>> builds copies the behavior of the QEMU loader code that precedes it, >

[edk2-devel] [PATCH v3 00/17] Add a pipline to check Ecc issues for edk2 on open ci

2020-06-10 Thread Zhang, Shenglei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 As planed we will enable Ecc check for edk2 on open ci. And they are ready now, but these are V3 series. So I expect that contributors in edk2 community can try using this script when reviewing. And I appreciate receiving feedback and comment

[edk2-devel] [PATCH v2] Features/Intel/PostCodeDebugFeaturePkg: add it.

2020-06-10 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2478 The PostCodeDebugFeaturePkg include some useful post code debug libraries, such as get post code from status code and show it. It provide a library PostCodeStatusCodeHandlerLib used by edk2 StatusCodeHandler.efi, used to show the post code.

Re: [edk2-devel] [PATCH 1/5] MdePkg/BasePrintLib: avoid absolute addresses for error strings

2020-06-10 Thread Ard Biesheuvel
On 6/10/20 10:17 AM, Ard Biesheuvel wrote: The mStatusString[] is constructed as an array of pointer-to-char, which means that on X64 or AARCH64, it is emitted as a single linear list of 64-bit quantities, each containing the absolute address of one of the string literals in memory. This means t

[edk2-devel] [PATCH 1/5] MdePkg/BasePrintLib: avoid absolute addresses for error strings

2020-06-10 Thread Ard Biesheuvel
The mStatusString[] is constructed as an array of pointer-to-char, which means that on X64 or AARCH64, it is emitted as a single linear list of 64-bit quantities, each containing the absolute address of one of the string literals in memory. This means that each string takes up 8 bytes of additiona

[edk2-devel] [PATCH 3/5] StandaloneMmPkg/Core: add missing GUID reference

2020-06-10 Thread Ard Biesheuvel
The Standalone core uses gEfiHobMemoryAllocModuleGuid, but failed to declare this in its INF. Signed-off-by: Ard Biesheuvel --- StandaloneMmPkg/Core/StandaloneMmCore.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.inf b/StandaloneMmPkg/Core/Standalo

[edk2-devel] [PATCH 4/5] StandaloneMmPkg: generate position independent code for StMM core

2020-06-10 Thread Ard Biesheuvel
The standalone MM core runs in a restricted environment that is set up by a higher privilege level, and which may not allow memory regions to be writable and executable at the same time. This means that making the StMM core self-relocatable requires that all the targets of the relocation fixups ar

[edk2-devel] [PATCH 5/5] StandaloneMmPkg/StandaloneMmCoreEntryPoint: relocate StMM core on the fly

2020-06-10 Thread Ard Biesheuvel
Apply PE/COFF fixups when starting up the standalone MM core, so that it can execute at any address regardless of the link time address. Note that this requires the PE/COFF image to be emitted with its relocation section preserved. Special care is taken to ensure that TE images are dealt with corr

[edk2-devel] [PATCH 2/5] StandaloneMmPkg/Core: fix bogus FV pointer in DEBUG string

2020-06-10 Thread Ard Biesheuvel
FvIsBeingProcessed () emits a DEBUG print with the intent to print the memory address of the FV that is being processed, but instead, it prints the contents of an uninitialized stack variable. Signed-off-by: Ard Biesheuvel --- StandaloneMmPkg/Core/Dispatcher.c | 2 +- 1 file changed, 1 insertion

[edk2-devel] [PATCH 0/5] StandaloneMmPkg: make StMM core relocatable

2020-06-10 Thread Ard Biesheuvel
It is not always possible to deploy the standalone MM core in a way where the runtime address is known at build time. This does not matter for most modules, since they are relocated at dispatch time. However, for the MM core itself, it means we need to do some extra work to relocate the image in pl

[edk2-devel] [PATCH v3 12/17] OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Shenglei Zhang --- OvmfPkg/OvmfPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) dif

[edk2-devel] [PATCH v3 14/17] SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Shenglei Zhang --- SecurityPkg/SecurityPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) dif

[edk2-devel] [PATCH v3 16/17] UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang --- UefiCpuPkg/UefiCpuPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --gi

[edk2-devel] [PATCH v3 06/17] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Shenglei Zhang --- CryptoPkg/CryptoPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/CryptoPkg/C

[edk2-devel] [PATCH v3 07/17] EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Shenglei Zhang --- EmulatorPkg/EmulatorPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff

[edk2-devel] [PATCH v3 11/17] NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Shenglei Zhang --- NetworkPkg/NetworkPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff

[edk2-devel] [PATCH v3 17/17] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Shenglei Zhang --- UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 10 ++ 1 file cha

[edk2-devel] [PATCH v3 05/17] ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Shenglei Zhang --- ArmVirtPkg/ArmVirtPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+

[edk2-devel] [PATCH v3 13/17] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Ray Ni Signed-off-by: Shenglei Zhang --- PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/PcAtChipsetPkg/PcAtCh

[edk2-devel] [PATCH v3 08/17] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Ray Ni Signed-off-by: Shenglei Zhang --- FatPkg/FatPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg

[edk2-devel] [PATCH v3 03/17] .azurepiplines: Add a pipline to check ECC issues for commits

2020-06-10 Thread Zhang, Shenglei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 Add a pipeline to run the ECC checks on Azure Pipelines agents for edk2 open ci. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- .azurepipelines/Windows-EccCheck.yml | 38

[edk2-devel] [PATCH v3 09/17] FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Shenglei Zhang --- FmpDevicePkg/FmpDevicePkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a

[edk2-devel] [PATCH v3 10/17] MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- MdePkg/MdePkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MdePkg/MdeP

[edk2-devel] [PATCH v3 15/17] ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Shenglei Zhang --- ShellPkg/ShellPkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ShellPkg/ShellPk

[edk2-devel] [PATCH v3 04/17] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check

2020-06-10 Thread Zhang, Shenglei
Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Shenglei Zhang --- MdeModulePkg/MdeModulePkg.ci.yaml | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MdeMod

[edk2-devel] [PATCH v3 01/17] BaseTools/Scripts: Add EccCheck.py

2020-06-10 Thread Zhang, Shenglei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 EccCheck.py is a tool to report Ecc issues for commits, which will be run on open ci. But note not each kind of issue could be reported out. It can only handle the issues, whose line number in CSV report accurately map with their code in sour

[edk2-devel] [PATCH v3 02/17] pip-requirements.txt: Add Ecc required lib

2020-06-10 Thread Zhang, Shenglei
antlr4-python3-runtime is a lib to support Ecc run with Py3.x. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- pip-requirements.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/pip-requirements.txt b/pip-requirements.txt index 57

[edk2-devel] [PATCH v3 00/17] Add a pipline to check Ecc issues for edk2 on open ci

2020-06-10 Thread Zhang, Shenglei
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61020): https://edk2.groups.io/g/devel/message/61020 Mute This Topic: https://groups.io/mt/74792208/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/

Re: [edk2-devel] [PATCH] OvmfPkg/GenericQemuLoadImageLib: log "Not Found" at INFO level

2020-06-10 Thread Laszlo Ersek
On 06/09/20 12:54, Laszlo Ersek wrote: > gBS->LoadImage() returning EFI_NOT_FOUND is an expected condition; it > means that QEMU wasn't started with "-kernel". Log this status code as > INFO rather than ERROR. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Philippe Mathieu-Daudé > Signed-off-

Re: [edk2-devel] [edk2-staging/EdkRepo-Manifest] [PATCH] Intel-MinPlatform: Update FSP repo URL

2020-06-10 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, June 9, 2020 9:49 AM > To: devel@edk2.groups.io > Cc: Desimone, Ashley E ; Chiu, Chasel > ; Chaganty, Rangasai V > ; Oram, Isaac W ; > Gao, Liming ; Ni, Ray ; Agyeman, > Prince ; Pandya, Puja >