REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2792
The BeepDebugFeaturePkg include some useful beep debug
libraries, such as get beep value from status code and beep.
It provide a library BeepStatusCodeHandlerLib used by edk2
StatusCodeHandler.efi, used to do beep if needed.
It also provide
Hi Ming,
> -Original Message-
> From: Tan, Ming
> Sent: Thursday, June 11, 2020 9:05 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Gao, Liming
> Subject: [PATCH v2] Features/Intel/BeepDebugFeaturePkg: add it.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2792
>
> The BeepD
UefiCpuLib is in UefiCpuPkg.
All consumers are in UefiCpuPkg. I think we can keep its location unchanged.
From: Dong, Eric
Sent: Thursday, June 11, 2020 9:29 AM
To: Ni, Ray ; devel@edk2.groups.io; garrett.kirkend...@amd.com
Cc: Laszlo Ersek
Subject: RE: UefiCpuPkg: Discuss: Move StandardSignatur
Reviewed- by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Philippe Mathieu-Daudé
> Sent: Thursday, May 7, 2020 2:57 AM
> To: Rebecca Cran ; devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Zhichao
> Subject: Re: [PATCH v2 1/1] ShellPkg: smbiosview - print field values as
> unsig
Good catch.
Reviewed-by: Sai Chaganty
-Original Message-
From: Desimone, Nathaniel L
Sent: Tuesday, June 09, 2020 5:31 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Chaganty, Rangasai V
Subject: [edk2-platforms] [PATCH] KabyLakeSiliconPkg: Bitmask comparison logic
bug
(Cpptv & B_P
This proposal is ok to me.
I'm not sure whether it can be added to MdePkg, just like add to CpuLib. I
found all the definitions and functions used in StandardSignatureIsAuthenticAMD
function defined in MdePkg.
If it can be added to MdePkg, all code base can use this function, if it been
added
Since all platform DSCs have already listed UefiCpuLib.inf so this change
doesn't impact platform DSC.
I don't see an issue with this change.
Eric,
What's your opinion?
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kirkendall,
> Garrett
> Sent: Wednesday,
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2478
The PostCodeDebugFeaturePkg include some useful post code debug
libraries, such as get post code from status code and show it.
It provide a library PostCodeStatusCodeHandlerLib used by edk2
StatusCodeHandler.efi, used to show the post code.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2792
The BeepDebugFeaturePkg include some useful beep debug
libraries, such as get beep value from status code and beep.
It provide a library BeepStatusCodeHandlerLib used by edk2
StatusCodeHandler.efi, used to do beep if needed.
It also provide
For the series...
Reviewed-by: Ashley DeSimone
-Original Message-
From: Bjorge, Erik C
Sent: Wednesday, June 10, 2020 3:14 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Desimone, Nathaniel L
; Pandya, Puja ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PA
Reviewed-by: Ashley DeSimone
-Original Message-
From: Bjorge, Erik C
Sent: Wednesday, June 10, 2020 3:07 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Desimone, Nathaniel L
; Pandya, Puja ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fi
Reviewed-by: Ashley DeSimone
-Original Message-
From: Bjorge, Erik C
Sent: Tuesday, June 9, 2020 4:04 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Desimone, Nathaniel L
; Pandya, Puja ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH v1 2/2] EdkRepo: A
Ard,
Can you add a comment block before each array and explain the
hardcoded 25 and 21 values. I assume that is the length of
the longest string +1 for the Null-terminator.
I assume if a string is added or modified that is longer
than the fixed size the compiler will throw an error. So
hopeful
When switching combinations or checking out pins the submodule
information may change or have modifications that will cause errors.
Before changing to a new combination all submodules should be removed.
Cc: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Bret Barkelew
Cc: Prince Agyema
Submodules may generate un-tracked or modify files in the repo. when
removing the submodule do so even with modifications.
Cc: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Bret Barkelew
Cc: Prince Agyeman
Cc: Erik Bjorge
Signed-off-by: Erik Bjorge
---
project_utils/submodule.py
Older pin files used the invalid enable_submodule attribute. This has
been fixed for new pin files but we need to be able to support older pin
files as well.
Cc: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Bret Barkelew
Cc: Prince Agyeman
Cc: Erik Bjorge
Signed-off-by: Erik Bjor
Fixed issues when submodule has untracked files and can't be deinitialized.
Fixed backwards compatibility issue with old pin files.
Fixed issue when switching combos to handle submodule removals.
Cc: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Bret Barkelew
Cc: Prince Agyeman
Cc:
Cc: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Bret Barkelew
Cc: Prince Agyeman
Cc: Erik Bjorge
Signed-off-by: Erik Bjorge
---
edkrepo/commands/checkout_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/checkout_command.py
b/edkrep
On 6/8/20 7:34 PM, Ard Biesheuvel wrote:
To help converted ELF images perform self-relocation, export a symbol
'ElfImageBase' that can be used in the code to discover the start of
the image in memory.
Note the use of PROVIDE() - this ensures that the symbol is only emitted
if a reference to it e
Reviewed-by: Sai Chaganty
-Original Message-
From: Tan, Ming
Sent: Tuesday, June 09, 2020 4:24 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Chaganty, Rangasai V
Subject: [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some PCDs type
REF: https://b
Please fix copyright year. With that change...
Reviewed-by: Nate DeSimone
-Original Message-
From: Chiu, Chasel
Sent: Tuesday, June 9, 2020 7:33 PM
To: devel@edk2.groups.io
Cc: Ma, Maurice ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH] IntelFsp2Pkg: Add Fsp22SecCoreS.inf to Ds
Hi Ard,
I have made corresponding changes to the Kvmtool port patch series (that I am
working on) and can confirm this patchset works.
Not sure if Tested-by would be correct in the context that the Kvmtool port is
not yet merged. In either case.
Tested-by: Sami Mujawar
Acked-by: Sami Mujawar
Reviewed-by: Nate DeSimone
-Original Message-
From: Tan, Ming
Sent: Tuesday, June 9, 2020 4:24 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Chaganty, Rangasai V
Subject: [PATCH 3/5] Platform/Intel/CometlakeOpenBoardPkg: Change some PCDs type
REF: https://bu
Reviewed-by: Nate DeSimone
-Original Message-
From: Tan, Ming
Sent: Tuesday, June 9, 2020 4:24 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
Subject: [PATCH 2/5] Platform/Intel/WhiskeylakeOpenBoardPkg: Change some PCDs
type
REF: https://bugzilla.tianocore.org/
Reviewed-by: Nate DeSimone
-Original Message-
From: Tan, Ming
Sent: Tuesday, June 9, 2020 4:24 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
Subject: [PATCH 4/5] Platform/Intel/KabylakeOpenBoardPkg: Change some PCDs type
REF: https://bugzilla.tianocore.org/show
The mStatusString[] array is constructed as an array of pointer-to-char,
which means that on X64 or AARCH64, it is emitted as a single linear list
of 64-bit quantities, each containing the absolute address of one of the
string literals in memory.
This means that each string takes up 8 bytes of add
On 6/10/20 8:21 PM, Sean Brogan wrote:
Ard,
I see you are only doing this for GCC?
Is it not needed for VS or clang? Are these toolchains not supported for
StandaloneMmPkg?
This works with Clang as well as GCC (Clang is part of the GCC toolchain
family in EDK2)
None of the AArch64 platf
Ard,
I see you are only doing this for GCC?
Is it not needed for VS or clang? Are these toolchains not supported for
StandaloneMmPkg?
Not trying to hold up your work and don't expect you to enable every
toolchain but also don't like the idea of only building out support for
a single toolcha
On 4/24/20 1:58 PM, Pranav Madhu via groups.io wrote:
From: Deepak Pandey
A slave error is generated when host accesses the config space of
non-available device or unimplemented function on a given bus. So
implement a n1sdp specific PciExpressLib library with a workaround to
return 0x f
On 4/24/20 1:58 PM, Pranav Madhu via groups.io wrote:
From: Deepak Pandey
Add EDK Build system files for Neoverse N1 System Development Platform.
Signed-off-by: Pranav Madhu
---
Platform/ARM/N1SdpPkg/N1SdpPlatform.dec | 31 +++
Platform/ARM/N1SdpPkg/N1SdpPlatform.dsc | 222 +++
On 4/24/20 1:58 PM, Pranav Madhu via groups.io wrote:
From: Deepak Pandey
N1SDP (Neoverse N1 System Development Platform) platform library support.
This includes the virtual memory map and helper functions for platform
intialization.
Signed-off-by: Pranav Madhu
---
Platform/ARM/N1SdpPkg/Lib
On 6/9/20 3:26 AM, Heyi Guo wrote:
The exception library is also used in DxeMain before memory services
are available, and AllocatePages() will fail in this case and cause
sp_el0 remains 0. Then if any exception occurs before CpuDxe driver is
loaded, a recursive exception will be trigged by page
On 6/10/20 5:09 PM, Michael D Kinney via groups.io wrote:
Hi Ard,
The size reduction is very interesting. Would be good to
see uncompressed size differences as well because this lib
is also used in pre-memory XIP modules that are fixed up
by the build tools that handle the relocation fixups.
Hi Ard,
The size reduction is very interesting. Would be good to
see uncompressed size differences as well because this lib
is also used in pre-memory XIP modules that are fixed up
by the build tools that handle the relocation fixups.
The more general concern I have is if there are standard
C c
On 6/10/20 7:26 AM, Laszlo Ersek wrote:
> Hi Tom,
>
> On 06/05/20 15:27, Tom Lendacky wrote:
>> The base VmgExitLib library provides a default limited interface. As it
>> does not provide full support, create an OVMF version of this library to
>> begin the process of providing full support of SEV-
[AMD Public Use]
There are currently three instances of StandardSignatureIsAuthenticAMD Function
in the below locations. I need to propose another change that will require the
same function in PiSmmCpuDxeSmm. I would like to see this function move to a
single "LibraryClass" location. I think
On 6/10/20 7:08 AM, Laszlo Ersek wrote:
> Hi Tom,
>
> On 06/05/20 15:27, Tom Lendacky wrote:
>> BZ:
>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D2198&data=02%7C01%7Cthomas.lendacky%40amd.com%7Cae12d2d0f5c94ee905c708d80d3711e6%7C
Thanks Sean and I will correct the copyright typo.
We will evaluate Core CI enabling.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Sean
> Sent: Wednesday, June 10, 2020 2:55 PM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Ma, Maurice ; Desimone, Nathaniel L
> ; Zeng,
On 06/05/20 15:27, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
>
> Under SEV-ES, a MSR_PROT intercept generates a #VC exception. VMGEXIT must
> be used to allow the hypervisor to handle this intercept.
>
> Add support to construct the required GHCB values to supp
On 06/05/20 15:27, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
>
> Under SEV-ES, a CPUID intercept generates a #VC exception. VMGEXIT must be
> used to allow the hypervisor to handle this intercept.
>
> Add support to construct the required GHCB values to support
On 06/05/20 15:27, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
>
> Add support to the #VC exception handler to handle string IO. This
> requires expanding the IO instruction parsing to recognize string based
> IO instructions as well as preparing an un-encrypted b
On 06/05/20 15:27, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
>
> Under SEV-ES, a IOIO_PROT intercept generates a #VC exception. VMGEXIT
> must be used to allow the hypervisor to handle this intercept.
>
> Add support to construct the required GHCB values to sup
Reviewed-by: Maciej Rabeda
On 10-Jun-20 10:14, Shenglei Zhang wrote:
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
---
NetworkPkg/N
Hi Tom,
On 06/05/20 15:27, Tom Lendacky wrote:
> The base VmgExitLib library provides a default limited interface. As it
> does not provide full support, create an OVMF version of this library to
> begin the process of providing full support of SEV-ES within OVMF.
>
> SEV-ES support is only provid
Hi Tom,
On 06/05/20 15:27, Tom Lendacky wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
>
> Various CpuExceptionHandlerLib libraries will updated to use the new
> VmgExitLib library. To prevent any build breakage, update the OvmfPkg
> DSC files that use a form of the CpuException
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2792
The BeepDebugFeaturePkg include some useful beep debug
libraries, such as get beep value from status code and beep.
It provide a library BeepStatusCodeHandlerLib used by edk2
StatusCodeHandler.efi, used to do beep if needed.
It also provide
Hi Ard,
Tested on QEMU with the op-tee patches i mentioned in my RFC [1]
Everything seems to work correctly
[1] https://edk2.groups.io/g/devel/message/60835
On Wed, Jun 10, 2020 at 10:17:35AM +0200, Ard Biesheuvel wrote:
> It is not always possible to deploy the standalone MM core in a way whe
From: Wasim Khan
Add SocGetSvr API to get the System Version Register(SVR)
Signed-off-by: Wasim Khan
---
Silicon/NXP/LX2160A/Library/SocLib/SocLib.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/Silicon/NXP/LX2160A/Library/SocLib/SocLib.c
b/Silicon/NXP/LX2160A/Library/So
From: Wasim Khan
Enable generic PCIe drivers and Wire up PciHostBridgeLib,
PciSegmentLib and PciCpuIo2Dxe.
Signed-off-by: Wasim Khan
---
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 9 +
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 7 +++
2 files changed, 16 insertions(+)
diff
From: Wasim Khan
Define macros to retrieve System Version Register(SVR)
related information
Signed-off-by: Wasim Khan
---
Silicon/NXP/Chassis2/Include/Chassis.h | 4
1 file changed, 4 insertions(+)
diff --git a/Silicon/NXP/Chassis2/Include/Chassis.h
b/Silicon/NXP/Chassis2/Include/Chassi
From: Wasim Khan
System Version Register(SVR) is used to provide the SoC details
like Manufacturer ID, SoC Family, SoC major and minor version
etc.
DEVDISRn is used to disable unused peripherals.
Update Device Configuration structure for SVR and DEVDISRn.
Signed-off-by: Wasim Khan
---
Silicon
From: Wasim Khan
Define System Version Register(SVR) for LS1043A SoC
Signed-off-by: Wasim Khan
---
Silicon/NXP/LS1043A/Include/Soc.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Silicon/NXP/LS1043A/Include/Soc.h
b/Silicon/NXP/LS1043A/Include/Soc.h
index 97a77d3f5da6..21b0dafffe91 10
From: Wasim Khan
Define System Version Register(SVR) for LX2160A SoC
Signed-off-by: Wasim Khan
---
Silicon/NXP/LX2160A/Include/Soc.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Silicon/NXP/LX2160A/Include/Soc.h
b/Silicon/NXP/LX2160A/Include/Soc.h
index 52674ee5f32c..6c745d580a6d 10
From: Wasim Khan
NXP SoCs supports different Serdes protocols using reset
configuration word (RCW).
Based on Serdes protocol value in reset configuration word (RCW)
different IP blocks gets enabled in HW.
This patch add Serdes support for LX2160A, which has 3 Serdes.
This patch has dependency
From: Wasim Khan
System Version Register(SVR) is used to provide the SoC details
like Manufacturer ID, SoC Family, SoC major and minor version
etc.
DEVDISRn is used to disable unused peripherals.
This patch series update device configuration structure (DCFG)
for SVR and DEVDISRn for LS1043A (Cha
From: Wasim Khan
Add SocGetSvr API to get the System Version Register(SVR)
Signed-off-by: Wasim Khan
---
Silicon/NXP/Include/Library/SocLib.h| 7 +++
Silicon/NXP/LS1043A/Library/SocLib/SocLib.c | 14 ++
2 files changed, 21 insertions(+)
diff --git a/Silicon/NXP/Includ
From: Wasim Khan
Add PCIe space in VirtualMemoryMap
Signed-off-by: Wasim Khan
---
Silicon/NXP/LX2160A/Include/Soc.h | 8
+
Platform/NXP/LX2160aRdbPkg/Library/ArmPlatformLib/ArmPlatformLibMem.c | 38
+++-
2 files changed, 45 insertions(
From: Wasim Khan
Enable PlatformDxe driver for LX2160aRdbPkg
Signed-off-by: Wasim Khan
---
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 2 ++
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 3 +++
2 files changed, 5 insertions(+)
diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc
b/P
From: Wasim Khan
This patch series adds PCIe support for LX2160aRdbPkg.
LX2160-Rev1 and LX2160-Rev2 has different PCIe controller. Platform
driver checks the SoC version and enable corresponding PCIe controller
and its feature using dynamic PCDs.
PciHostBridgeLib and PciSegmentLib already has s
From: Wasim Khan
System Version Register(SVR) is used to provide the SoC details
like Manufacturer ID, SoC Family, SoC major and minor version
etc.
DEVDISRn is used to disable unused peripherals.
Update Device Configuration structure for SVR and DEVDISRn.
Signed-off-by: Wasim Khan
---
Silicon
From: Wasim Khan
Enable NetworkPkg for LX2160aRdbPkg Platform.
Signed-off-by: Wasim Khan
---
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 11 +++
Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.fdf | 5 +
2 files changed, 16 insertions(+)
diff --git a/Platform/NXP/LX2160aRdbPkg/LX2160
From: Wasim Khan
Add PlatformDxe to do platform specific work.
At present it perform platform specific Pci initialization.
Signed-off-by: Wasim Khan
---
Platform/NXP/LX2160aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf | 35 +
Platform/NXP/LX2160aRdbPkg/Drivers/PlatformDxe/PlatformDxe.c
From: Wasim Khan
Based on SerDes protocol value in reset configuration word (RCW)
different IP blocks gets enabled in HW.
Add SoC specific SerDes configuration for LX2160A, which can be
used by different IPs to know the enabled interfaces and perform
the required initialization.
Signed-off-by: W
From: Wasim Khan
PCIe Layerscape controller in LX2160A-Rev2 is not completely
ECAM-compliant. It is non-ECAM only for the root bus (bus 0)
and for any other bus underneath the root bus it does support
ECAM access.
One approach can be to setup the controller in firmware and
expose bus[0x1-0xff] to
From: Wasim Khan
Define PCIe related PCDs for LX2160A.
Signed-off-by: Wasim Khan
---
Silicon/NXP/LX2160A/LX2160A.dsc.inc | 5 +
1 file changed, 5 insertions(+)
diff --git a/Silicon/NXP/LX2160A/LX2160A.dsc.inc
b/Silicon/NXP/LX2160A/LX2160A.dsc.inc
index fe8ed402fc4e..43e361464c8e 100644
-
From: Wasim Khan
Define macros to retrieve System Version Register(SVR)
related information
Signed-off-by: Wasim Khan
---
Silicon/NXP/Chassis3V2/Include/Chassis.h | 4
1 file changed, 4 insertions(+)
diff --git a/Silicon/NXP/Chassis3V2/Include/Chassis.h
b/Silicon/NXP/Chassis3V2/Include/
On 6/10/20 11:22 AM, Laszlo Ersek wrote:
On 06/09/20 12:45, Ard Biesheuvel wrote:
On 6/9/20 11:51 AM, Laszlo Ersek via groups.io wrote:
Hi Ard,
On 03/05/20 14:46, Ard Biesheuvel wrote:
The QemuLoadImageLib implementation we currently use for all OVMF
builds copies the behavior of the QEMU loa
On 06/09/20 12:45, Ard Biesheuvel wrote:
> On 6/9/20 11:51 AM, Laszlo Ersek via groups.io wrote:
>> Hi Ard,
>>
>> On 03/05/20 14:46, Ard Biesheuvel wrote:
>>> The QemuLoadImageLib implementation we currently use for all OVMF
>>> builds copies the behavior of the QEMU loader code that precedes it,
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
As planed we will enable Ecc check for edk2 on open ci. And they are
ready now, but these are V3 series. So I expect that contributors in
edk2 community can try using this script when reviewing. And I appreciate
receiving feedback and comment
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2478
The PostCodeDebugFeaturePkg include some useful post code debug
libraries, such as get post code from status code and show it.
It provide a library PostCodeStatusCodeHandlerLib used by edk2
StatusCodeHandler.efi, used to show the post code.
On 6/10/20 10:17 AM, Ard Biesheuvel wrote:
The mStatusString[] is constructed as an array of pointer-to-char, which
means that on X64 or AARCH64, it is emitted as a single linear list of
64-bit quantities, each containing the absolute address of one of the
string literals in memory.
This means t
The mStatusString[] is constructed as an array of pointer-to-char, which
means that on X64 or AARCH64, it is emitted as a single linear list of
64-bit quantities, each containing the absolute address of one of the
string literals in memory.
This means that each string takes up 8 bytes of additiona
The Standalone core uses gEfiHobMemoryAllocModuleGuid, but failed to
declare this in its INF.
Signed-off-by: Ard Biesheuvel
---
StandaloneMmPkg/Core/StandaloneMmCore.inf | 1 +
1 file changed, 1 insertion(+)
diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.inf
b/StandaloneMmPkg/Core/Standalo
The standalone MM core runs in a restricted environment that is set
up by a higher privilege level, and which may not allow memory regions
to be writable and executable at the same time.
This means that making the StMM core self-relocatable requires that
all the targets of the relocation fixups ar
Apply PE/COFF fixups when starting up the standalone MM core, so that
it can execute at any address regardless of the link time address.
Note that this requires the PE/COFF image to be emitted with its
relocation section preserved. Special care is taken to ensure that
TE images are dealt with corr
FvIsBeingProcessed () emits a DEBUG print with the intent to print
the memory address of the FV that is being processed, but instead,
it prints the contents of an uninitialized stack variable.
Signed-off-by: Ard Biesheuvel
---
StandaloneMmPkg/Core/Dispatcher.c | 2 +-
1 file changed, 1 insertion
It is not always possible to deploy the standalone MM core in a way where
the runtime address is known at build time. This does not matter for most
modules, since they are relocated at dispatch time. However, for the MM
core itself, it means we need to do some extra work to relocate the image
in pl
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Shenglei Zhang
---
OvmfPkg/OvmfPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
dif
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Chao Zhang
Signed-off-by: Shenglei Zhang
---
SecurityPkg/SecurityPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
dif
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
---
UefiCpuPkg/UefiCpuPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --gi
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Signed-off-by: Shenglei Zhang
---
CryptoPkg/CryptoPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/CryptoPkg/C
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
EmulatorPkg/EmulatorPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Shenglei Zhang
---
NetworkPkg/NetworkPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
Signed-off-by: Shenglei Zhang
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 10 ++
1 file cha
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Shenglei Zhang
---
ArmVirtPkg/ArmVirtPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/PcAtChipsetPkg/PcAtCh
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Signed-off-by: Shenglei Zhang
---
FatPkg/FatPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/FatPkg/FatPkg.ci.yaml b/FatPkg/FatPkg
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
Add a pipeline to run the ECC checks on Azure Pipelines agents
for edk2 open ci.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.azurepipelines/Windows-EccCheck.yml | 38
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Shenglei Zhang
---
FmpDevicePkg/FmpDevicePkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
MdePkg/MdePkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MdePkg/MdeP
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
---
ShellPkg/ShellPkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/ShellPkg/ShellPk
Add configuration ExceptionList and IgnoreFiles for package config
files. So users can rely on this to ignore some Ecc issues.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Shenglei Zhang
---
MdeModulePkg/MdeModulePkg.ci.yaml | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MdeMod
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606
EccCheck.py is a tool to report Ecc issues for commits, which will
be run on open ci.
But note not each kind of issue could be reported out.
It can only handle the issues, whose line number in CSV report
accurately map with their code in sour
antlr4-python3-runtime is a lib to support Ecc run with Py3.x.
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
pip-requirements.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/pip-requirements.txt b/pip-requirements.txt
index 57
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#61020): https://edk2.groups.io/g/devel/message/61020
Mute This Topic: https://groups.io/mt/74792208/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/
On 06/09/20 12:54, Laszlo Ersek wrote:
> gBS->LoadImage() returning EFI_NOT_FOUND is an expected condition; it
> means that QEMU wasn't started with "-kernel". Log this status code as
> INFO rather than ERROR.
>
> Cc: Ard Biesheuvel
> Cc: Jordan Justen
> Cc: Philippe Mathieu-Daudé
> Signed-off-
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Tuesday, June 9, 2020 9:49 AM
> To: devel@edk2.groups.io
> Cc: Desimone, Ashley E ; Chiu, Chasel
> ; Chaganty, Rangasai V
> ; Oram, Isaac W ;
> Gao, Liming ; Ni, Ray ; Agyeman,
> Prince ; Pandya, Puja
>
97 matches
Mail list logo