Re: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data

2020-06-14 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of Tan, > Ming > Sent: Monday, June 15, 2020 10:04 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: > do not output \n\r for string data > > REF:

Re: [edk2-devel] [PATCH v6] Features/Intel/BeepDebugFeaturePkg: add it.

2020-06-14 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Tan, Ming > Sent: Friday, June 12, 2020 11:41 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [PATCH v6] Features/Intel/BeepDebugFeaturePkg: add it. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2792

Re: [edk2-devel] [PATCH v3] Features/Intel/PostCodeDebugFeaturePkg: add it.

2020-06-14 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Tan, Ming > Sent: Friday, June 12, 2020 11:41 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [PATCH v3] Features/Intel/PostCodeDebugFeaturePkg: add it. > > REF:

[edk2-devel] [PATCH] ShellPkg: Update timezone of 3 cities

2020-06-14 Thread Dorapika Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2780 The timezone of following cities should be updated: Istanbul: UTC+3 Novosibirsk: UTC+7 Georgetown (Guyana): UTC-4 Signed-off-by: Dorapika Wu Reviewed-by: Zhichao Gao --- .../UefiShellLevel2CommandsLib.uni | 12

[edk2-devel] [PATCH 1/1 v2] MdeModulePkg/StatusCodeHandler: do not output \n\r for string data

2020-06-14 Thread Tan, Ming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2787 When output string data through serial port, will not ouput \n\r now. Caller can output several data in one line, and output \n\r when needed. Signed-off-by: Ming Tan --- V2: Make it as a standalone patch.

Re: [edk2-devel] [PATCH edk2-platforms 1/1] SbsaQemu: Build infrastructure for StandaloneMm image

2020-06-14 Thread Masahisa Kojima
> May I suggest that we start with variable support on the secure side? It > should be quite straight-forward to expose part of the secure NOR flash > bank via the existing MM stack for variable services that I ported to > SynQuacer last year. > Thank you for your comment, I will check the secure

[edk2-devel] [Patch 14/15] MdePkg/Include: Add UT_EXPECT_ASSERT_FAILURE() to UnitTestLib

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2801 Add the UT_EXPECT_ASSERT_FAILURE(FunctionCall, Status) macro to the UnitTestLib that can be used to check if a function under test triggers an ASSERT() condition. If an ASSERT() condition is triggered, then the macro returns. If the ASSERT()

[edk2-devel] [Patch 05/15] MdePkg/Library/BaseLib: Add BaseLib instance for host based unit tests

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2800 Add a new version of BaseLib that is safe for use from host based unit test applications. Host based unit test applications may need to provide implementations of some BaseLib functions that provide simple emulation to exercise the code under

[edk2-devel] [Patch 07/15] UnitTestFrameworkPkg: Enable source level debug for host tests

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2804 Optionally enable a feature to support source level debug of a host based unit test. By default, this feature is disabled. Exceptions are caught by the unit test framework and are interpreted as a test failure. When a unit test is under

[edk2-devel] [Patch 12/15] UnitTestFrameworkPkg/UnitTestLib: Add checks for ASSERT()

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2801 Add UnitTestDebugAssertLib that provides the UnitTestDebugAssert() service and the gUnitTestExpectAssertFailureJumpBuffer global variable. This NULL library is linked against all host and target unit test builds. This guarantees that the

[edk2-devel] [Patch 00/15] UnitTestFrameworkPkg: Enhancements and bug fixes

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2797 https://bugzilla.tianocore.org/show_bug.cgi?id=2798 https://bugzilla.tianocore.org/show_bug.cgi?id=2799 https://bugzilla.tianocore.org/show_bug.cgi?id=2800 https://bugzilla.tianocore.org/show_bug.cgi?id=2801

[edk2-devel] [Patch 11/15] UnitTestFrameworkPkg/UnitTestLib: Fix target mode log messages

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2806 Update the log messages generated in target mode to use FileName instead of FunctionName. FunctionName is an empty string so the log messages generated do not provide enough information to know the source of a unit test failure. Using FileName

[edk2-devel] [Patch 13/15] MdePkg/Include: Hook DebugLib _ASSERT() for unit tests

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2801 Update DebugLib.h _ASSERT() macro to check if unit testing is enabled and call UnitTestDebugAssert() instead of DebugAssert() so the an ASSERT() condition that is triggered by a function under test can be handled by the Unit Test Framework. If

[edk2-devel] [Patch 09/15] UnitTestFrameworkPkg: Change target mode DebugLib mapping

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2801 The default DebugLib for target mode was DebugLibNull. This library instance disables all ASSERT() and DEBUG() macros which removes the ability to write unit tests that check for ASSERT() behaviors. The DebugLib is changed to

[edk2-devel] [Patch 06/15] UnitTestFrameworkPkg: Use host libraries from MdePkg

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2800 https://bugzilla.tianocore.org/show_bug.cgi?id=2799 https://bugzilla.tianocore.org/show_bug.cgi?id=2798 Update the default unit test library mappings to use the library instances from the MdePkg that are safe for host based unit tests. Cc: Sean

[edk2-devel] [Patch 15/15] UnitTestFramewokPkg/SampleUnitTest: Use UT_EXPECT_ASSERT_FAILURE()

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2801 Add samples using UT_EXPECT_ASSERT_FAILURE() for both positive test cases where the ASSERT() is triggered and detected correctly and negative test cases where an ASSERT() is never triggered. These new test cases also generate passing test

[edk2-devel] [Patch 03/15] MdePkg/BaseCacheMaintenanceLibNull: Add Null instance for host testing

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2799 The services in CacheMaintenanceLib usually generate exceptions in a unit test host application. Provide a Null instance that can be safely used. This Null instance can also be used as a template for implementing new instances of

[edk2-devel] [Patch 08/15] UnitTestFrameworkPkg: Set host application stack size to 256KB

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2803 The UEFI Specification defines the minimum stack size before ExitBootServices() to be 128KB. When running a host based unit test, there may be additional stack overhead from the host application environment and cmocka. Update the build flags

[edk2-devel] [Patch 10/15] UnitTestFrameworkPkg/UnitTestLib: Move print log into cleanup

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2805 If a unit test fails with an exception or an assert, then the CmockaUnitTestFunctionRunner() is terminated and the logic that follows the invocation of the unit test is skipped. This currently skips the logic that prints log messages. Move the

[edk2-devel] [Patch 01/15] BaseTools/Python: Allow HOST_APPLICATION to use NULL libraries

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2797 Update HOST_APPLICATION module type to use NULL library instances. Cc: Bob Feng Cc: Liming Gao Cc: Sean Brogan Cc: Bret Barkelew Cc: Jiewen Yao Signed-off-by: Michael D Kinney --- BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 4

[edk2-devel] [Patch 04/15] MdePkg/BaseLib: Break out IA32/X64 GCC inline privileged functions

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2800 Break out the IA32/X64 GCC inline functions that can not be used in a unit test host application into their own source file. This does not make any changes to the BaseLib library instance. This is in preparation for a new BaseLib instances

[edk2-devel] [Patch 02/15] MdePkg/BaseCpuLibNull: Add Null version of CpuLib for host testing

2020-06-14 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2798 The services in CpuLib usually generate exceptions in a unit test host application. Provide a Null instance that can be safely used. This Null instance can also be used as a template for implementing new instances of CpuLib. Cc: Liming Gao

Re: [edk2-devel] [PATCH 4/5] StandaloneMmPkg: generate position independent code for StMM core

2020-06-14 Thread Yao, Jiewen
Acked-by: Jiewen Yao I hope GCC expert can review this and double confirm. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Wednesday, June 10, 2020 4:18 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Kinney, Michael D

Re: [edk2-devel] [PATCH 5/5] StandaloneMmPkg/StandaloneMmCoreEntryPoint: relocate StMM core on the fly

2020-06-14 Thread Yao, Jiewen
Acked-by: Jiewen Yao I hope ARM expert can review this to double confirm. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Wednesday, June 10, 2020 4:18 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Kinney, Michael D >

Re: [edk2-devel] [PATCH 3/5] StandaloneMmPkg/Core: add missing GUID reference

2020-06-14 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, June 10, 2020 4:18 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Kinney, Michael D > ; Gao, Liming ; Yao, > Jiewen ; Sami Mujawar ; > Ilias Apalodimas > Subject: [PATCH 3/5]

Re: [edk2-devel] [PATCH 2/5] StandaloneMmPkg/Core: fix bogus FV pointer in DEBUG string

2020-06-14 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Wednesday, June 10, 2020 4:18 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Kinney, Michael D > ; Gao, Liming ; Yao, > Jiewen ; Sami Mujawar ; > Ilias Apalodimas >