Hi Leif,
Sorry for late reply.
Actually I had asked the design team to check this point.
I am waiting for their reply.
I will add comments in code based on their reply and send new version.
Regards,
Pankaj Bansal
> -Original Message-
> From: Leif Lindholm
> Sent: Friday, June 12, 2020
For the series...
Reviewed-by: Nate DeSimone
On 6/18/20, 6:28 AM, "Chiu, Chasel" wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2781
Introduce FSPT_ARCH_UPD and FSPS_ARCH_UPD to support debug events
and multi-phase silicon initialization.
In V2 backward
Hi Garrett,
I create a pull request to verify your changes and it reports some errors for
your changes.
https://github.com/tianocore/edk2/pull/710
please help to resolve these errors before sending your new version changes,
also you can create your PR to verify your new changes.
Thanks,
Eric
Hi, Abner
The patch looks good.
Thanks,
Yuwei
> -Original Message-
> From: Chang, Abner (HPS SW/FW Technologist)
> Sent: Thursday, June 18, 2020 9:41 AM
> To: devel@edk2.groups.io; Chen, Yuwei
> Cc: Feng, Bob C ; Gao, Liming
> ; Schaefer, Daniel (DualStudy)
> ; Leif Lindholm
>
Hi Dandan,
Thanks for your detail explanation, add my comments below.
Thanks,
Eric
From: Bi, Dandan
Sent: Thursday, June 18, 2020 4:39 PM
To: Dong, Eric ; devel@edk2.groups.io
Cc: Gao, Liming
Subject: RE: [patch] MdeModulePkg/DisplayEngine: Add Debug message to show
mismatch menu info
Hi
Thanks Pierre to report this build failure.
The failure is caused by FV size increase when using build parameter "-b NOOPT".
Given this build option would almost double the build size and it is seldom
used, I prefer you update the FDF file to increase the FV size to solve it
locally.
BTW,
I can’t understand why we have LzmaF86Compress.bat that gets copied by the
nmake file.
BaseTools/Conf/tools_def.template
*_*_*_LZMAF86_PATH = LzmaF86Compress
It would work for all toolchains if we did this:
*_*_*_LZMAF86_FLAGS= --f86
*_*_*_LZMAF86_PATH = LzmaCompress
On Tue, Jun 02, 2020 at 18:51:52 +0200, Daniel Schaefer wrote:
> Library provides interfaces to invoke SBI ecalls.
>
> Signed-off-by: Daniel Schaefer
All of my feedback on previous revision addressed - where to actually
*merge* it remains undecided, but for the contents:
Reviewed-by: Leif
On Thu, Jun 18, 2020 at 09:59:28 +, Wasim Khan (OSS) wrote:
>
>
> > -Original Message-
> > From: Leif Lindholm
> > Sent: Wednesday, June 17, 2020 8:24 PM
> > To: Wasim Khan (OSS)
> > Cc: devel@edk2.groups.io; Meenakshi Aggarwal
> > ; Varun Sethi ;
> > ard.biesheu...@arm.com; Wasim
On Wed, Jun 10, 2020 at 03:47:23 +0530, Wasim Khan wrote:
> From: Wasim Khan
>
> This patch series adds PCIe support for LX2160aRdbPkg.
> LX2160-Rev1 and LX2160-Rev2 has different PCIe controller. Platform
> driver checks the SoC version and enable corresponding PCIe controller
> and its feature
AMD processor does not support MSR_IA32_MISC_ENABLE register. Accessing
this register on AMD causes an unhandled exception in SmmEntry.nasm and
a subsequent failure to boot since this is too early in SMM path for the
exception handler to be loaded.
First, to distinguish between AMD and other
Refactor StandardSignatureIsAuthenticAMD into BaseUefiCpuLib from
separate copies in BaseXApicLib, BaseXApicX2ApicLib, and MpInitLib.
This allows for future use of StandarSignatureIsAuthinticAMD without
creating more instances in other modules.
This function allows IA32/X64 code to determine if
AMD does not support MSR_IA32_MISC_ENABLE. Accessing that register
causes and exception on AMD processors. If Execution Disable is
supported, but if the processor is an AMD processor, skip manipulating
MSR_IA32_MISC_ENABLE[34] XD Disable bit.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
On Wed, Jun 10, 2020 at 03:47:29 +0530, Wasim Khan wrote:
> From: Wasim Khan
>
> Enable NetworkPkg for LX2160aRdbPkg Platform.
This is done as part of a pacthset called "enable PCIe support
for...".
Again, I understand why you're doing this, but it is far from obvious.
Please add a note to the
On Thu, Jun 18, 2020 at 10:33:05 +, Wasim Khan (OSS) wrote:
>
>
> > -Original Message-
> > From: Leif Lindholm
> > Sent: Thursday, June 18, 2020 3:38 PM
> > To: Wasim Khan (OSS)
> > Cc: devel@edk2.groups.io; Meenakshi Aggarwal
> > ; Varun Sethi ;
> > ard.biesheu...@arm.com; Wasim
Hello,
I am not actively using this platform, but I wanted to report an error when
building one of the DSC files in the UefiPayloadPkg with the following
configuration:
build -b NOOPT -a IA32 -t VS2017 -p edk2
edk2\UefiPayloadPkg\UefiPayloadPkgIa32.dsc
The following error occurs:
Generating
On 6/18/20 2:43 AM, Dong, Eric wrote:
Hi Tom,
Hi Eric,
We use GCC5 to build the OVMF platform and report below errors, please help to
check and fix it.
That's what I use when I build and have never encountered these errors. I
also ran the patches through the EDK2 CI and didn't get any
Hello Bob,
As discussed, I have created a pull request on the edk2 github. It is available
here:
https://github.com/tianocore/edk2/pull/700
Feel free to delete it.
I have tested the patch set on the following confifurations, with the following
formating for each line:
[DSC file] [Build
From: Pierre Gondois
The AmlToHex script and Posix/WindowsLike wrappers convert
an AML file to a .hex file, containing a C array storing
AML bytecode. This ".hex" file can then be included in a
C file, allowing to access the AML bytecode from this C
file.
The EDK2 build system doesn't allow to
From: Pierre Gondois
Using Python 3.7.2 on win32, when printing a FileBuildRule
instance, the following error occurs:
File "edk2\BaseTools\Source\Python\AutoGen\BuildEngine.py",
line 177, in __str__
DestString = ", ".join(self.DestFileList)
TypeError: sequence item 0: expected str instance,
From: Pierre Gondois
This patch modifies the Makefile generation not to stop
adding Makfile rules when the first final target is found.
E.g.:
If the following rules are described in build_rule.txt:
-[Rule1]: .X files generate .Y and .Z files;
-[Rule2]: .Z files generate .Z1 files.
Currently,
Following the BZ at https://bugzilla.tianocore.org/show_bug.cgi?id=2425
This patch serie is a another way to solve the dependency
of C files over ASL files. With this new method, the
dependency is resolved at the linking stage.
The last method to solve this dependency was to add
the possibility
From: Pierre Gondois
The AmlToHex script and Posix/WindowsLike wrappers convert
an AML file to a .hex file, containing a C array storing
AML bytecode. This ".hex" file can then be included in a
C file, allowing to access the AML bytecode from this C
file.
The EDK2 build system doesn't allow to
On 6/18/20 2:23 AM, Dong, Eric wrote:
> Hi Tom,
>
> When use VS2015 to build this code, it reports below error. Please help to
> fix it.
>
> k:\edk2\UefiCpuPkg\Include\Library/VmgExitLib.h: error C2220: warning treated
> as error - no 'object' file generated
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2781
Introduce FSPT_ARCH_UPD and FSPS_ARCH_UPD to support debug events
and multi-phase silicon initialization.
In V2 backward compatibility support is added, the original
structures are kept and new ARCH_UPD structures will be
included only
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2781
Introduce FSPT_ARCH_UPD and FSPS_ARCH_UPD to support debug events
and multi-phase silicon initialization.
For backward compatibility the original structures are kept and
new ARCH_UPD structures will be included only when UPD header
revision
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2781
Provides sample code to include FSPT_ARCH_UPD initial values with
UPD header revision set to 2.
Cc: Maurice Ma
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
On Wed, Jun 10, 2020 at 03:47:26 +0530, Wasim Khan wrote:
> From: Wasim Khan
>
> Add PlatformDxe to do platform specific work.
> At present it perform platform specific Pci initialization.
> Signed-off-by: Wasim Khan
> ---
> Platform/NXP/LX2160aRdbPkg/Drivers/PlatformDxe/PlatformDxe.inf | 35
On 06/18/20 05:24, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2326
>
> Currently when meet mismatch case for one-of and ordered-list
> menu, just show a popup window to indicate mismatch, no more
> info for debugging. This patch is to add more debug message
> about
On 06/17/20 19:23, Igor Druzhinin wrote:
> On 17/06/2020 17:59, Paolo Bonzini wrote:
>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
>> unless you have verified the sender and know the content is safe.
>>
>> On 17/06/20 17:46, Laszlo Ersek wrote:
That said,
> -Original Message-
> From: Leif Lindholm
> Sent: Thursday, June 18, 2020 3:22 PM
> To: Wasim Khan (OSS)
> Cc: devel@edk2.groups.io; Meenakshi Aggarwal
> ; Varun Sethi ;
> ard.biesheu...@arm.com; Wasim Khan
> Subject: Re: [PATCH edk2-platforms 1/7] Platform/NXP: LX2160aRdbPkg: Add
>
> -Original Message-
> From: Leif Lindholm
> Sent: Thursday, June 18, 2020 3:38 PM
> To: Wasim Khan (OSS)
> Cc: devel@edk2.groups.io; Meenakshi Aggarwal
> ; Varun Sethi ;
> ard.biesheu...@arm.com; Wasim Khan
> Subject: Re: [PATCH edk2-platforms 2/7] Silicon/NXP: LX2160A: Define PCIe
> -Original Message-
> From: Leif Lindholm
> Sent: Wednesday, June 17, 2020 8:24 PM
> To: Wasim Khan (OSS)
> Cc: devel@edk2.groups.io; Meenakshi Aggarwal
> ; Varun Sethi ;
> ard.biesheu...@arm.com; Wasim Khan
> Subject: Re: [PATCH edk2-platforms 2/8] Silicon/NXP: Chassis2: define SVR
On 6/17/20 11:33 PM, Samer El-Haj-Mahmoud wrote:
Port tianocore/edk2@2d233af64b8f73d1b1e138b302e6344f7c2e0f4e
This enables network boot by default on RPi first boot, when all other
boot options fail. This is required for unattended/headless boot cases.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
On 6/17/20 8:22 PM, Samer El-Haj-Mahmoud wrote:
Tested on RPi4 w/ 4GB
Reviewed-by: Samer El-Haj-Mahmoud
Thanks
Pushed as 743f501b66db712d486347ddca781ffc705c1766
-Original Message-
From: Ard Biesheuvel
Sent: Wednesday, June 17, 2020 2:15 PM
To: devel@edk2.groups.io
Cc: Ard
On Wed, Jun 10, 2020 at 03:47:25 +0530, Wasim Khan wrote:
> From: Wasim Khan
>
> Define PCIe related PCDs for LX2160A.
>
> Signed-off-by: Wasim Khan
> ---
> Silicon/NXP/LX2160A/LX2160A.dsc.inc | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/Silicon/NXP/LX2160A/LX2160A.dsc.inc
On Wed, Jun 10, 2020 at 03:47:24 +0530, Wasim Khan wrote:
> From: Wasim Khan
>
> Add PCIe space in VirtualMemoryMap
You appear to be adding six spaces to the memory map, not one.
I may know why, but most people do not. Please describe in the commit
message what the spaces are and why there's
On 06/18/20 10:36, Laszlo Ersek wrote:
> On 06/17/20 19:23, Igor Druzhinin wrote:
>> I will create a BZ ticket as requested.
>
> Thanks -- please follow up with the URL
nevermind, I've found, in my bugmail:
https://bugzilla.tianocore.org/show_bug.cgi?id=2815
Thanks
Laszlo
Hi Eric,
For example:
For one of, if its current value is 4, but there is no option with value 4,
then it will pop up mismatch window and the debug message like below.
[DisplayEngine]: Mismatch Formset: Formset Guid =
9E0C30BC-3F06-4BA6-8288-09179B855DBE.
[DisplayEngine]: Mismatch Form
On 06/17/20 19:23, Igor Druzhinin wrote:
> On 17/06/2020 17:59, Paolo Bonzini wrote:
>> [CAUTION - EXTERNAL EMAIL] DO NOT reply, click links, or open attachments
>> unless you have verified the sender and know the content is safe.
>>
>> On 17/06/20 17:46, Laszlo Ersek wrote:
That said,
Hi Tom,
We use GCC5 to build the OVMF platform and report below errors, please help to
check and fix it.
I/opt/TCAgent/work/f9b29f3e80472c44/Edk2/MdeModulePkg/
-I/opt/TCAgent/work/f9b29f3e80472c44/Edk2/MdeModulePkg/Include/
-I/opt/TCAgent/work/f9b29f3e80472c44/Edk2/UefiCpuPkg/
Hi Tom,
When use VS2015 to build this code, it reports below error. Please help to fix
it.
k:\edk2\UefiCpuPkg\Include\Library/VmgExitLib.h: error C2220: warning treated
as error - no 'object' file generated
k:\edk2\UefiCpuPkg\Include\Library/VmgExitLib.h: warning C4335: Mac file format
Hi All,
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2816
We plan to separate two kinds of NULL class libraries for Memory and serial
handlers from MdeModulePkg/Universal/StatusCodeHandler/.../
StatusCodeHandlerPei/RuntimeDxe/Smm modules.
The benefit we want to gain from this separation
Reviewed-by: Andrei Warkentin
From: Samer El-Haj-Mahmoud
Sent: Wednesday, June 17, 2020 4:33 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Leif Lindholm ;
Andrei Warkentin ; Pete Batard
Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi:
Reviewed-by: Andrei Warkentin
From: Samer El-Haj-Mahmoud
Sent: Wednesday, June 17, 2020 11:22 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Leif Lindholm ;
Andrei Warkentin ; Pete Batard
Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Add
Reviewed-by: Andrei Warkentin
A
From: Samer El-Haj-Mahmoud
Sent: Wednesday, June 17, 2020 11:16 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Leif Lindholm ;
Andrei Warkentin ; Pete Batard
Subject: [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix
Hi Dandan,
It's good to show more info about the mismatch error. Current end user doesn't
know which question need to check if this error appears.
Can you post an example about the error message for one of and for ordered
list? We need to make sure the message is easy to be understood and the
47 matches
Mail list logo
