Hello Ard,
Would you please kindly review this change?
Thank you,
Irene
-Original Message-
From: Samer El-Haj-Mahmoud
Sent: Monday, June 22, 2020 5:01 PM
To: devel@edk2.groups.io; Irene Park ; Ard Biesheuvel
Subject: RE: [edk2-devel] [PATCH v2] ArmPlatformPkg/PL011UartLib: Check PID2 i
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCELLED
CALSCALE:GREGORIAN
BEGIN:VEVENT
UID:g7lq.1578029159272351097.u...@groups.io
DTSTAMP:20200625T043702Z
ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com
DTSTART:20200626T013000Z
DTEND:20200626T023000Z
SUMMARY:Tiano
Liming,
Thank you!
I didn't realize MinPlatformPkg contain an implementation of PciSegmentInfoLib
when adding
missing EFIAPI to the API prototype.
Reviewed-by: Ray Ni
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, June 24, 2020 10:22 PM
> To: devel@edk2.groups.io
> Cc: Ni,
Laszlo,
You are surprised because the issue is related to Redhat, or because
the word "Redhat" should not be mentioned in the Bugzilla?
http://manpages.ubuntu.com/manpages/bionic/man8/mkudffs.8.html
is a tool that creates UDF file system with a compatible MBR table in the
top 32KB specially for Wi
Dandan,
The Status Code Protocol/PPI is the high-level interface which is being
implemented. The ReportStatusCodeRouter module implements this in terms
of the ReportStatusCodeHandler Protocol/PPI. That allows multiple
ReportStatusCodeHandler modules to be used at once, so they can each
reac
On Wed, Jun 24, 2020 at 03:48:46PM +0200, Ard Biesheuvel wrote:
> On 6/24/20 3:41 PM, Andrew Jones wrote:
> > On Wed, Jun 24, 2020 at 03:02:49PM +0200, Philippe Mathieu-Daudé wrote:
> > > On 6/24/20 1:43 PM, Ard Biesheuvel wrote:
> ...
> > > > I wasn't aware that we even expose the flash in the
On Wed, Jun 24, 2020 at 03:02:49PM +0200, Philippe Mathieu-Daudé wrote:
> On 6/24/20 1:43 PM, Ard Biesheuvel wrote:
> > On 6/24/20 1:20 PM, Laszlo Ersek via groups.io wrote:
> >> (CC Drew, Eric)
> >>
> >> On 06/24/20 09:19, Ard Biesheuvel wrote:
> >>
> >>> The arm64 defconfig was recently updated
On 06/24/20 14:19, Ard Biesheuvel wrote:
> On 6/24/20 1:48 PM, Laszlo Ersek wrote:
>> On 06/24/20 13:15, Ard Biesheuvel wrote:
>>> Our UEFI guest firmware takes ownership of the emulated NOR flash in
>>> order to support the variable runtime services, and it does not expect
>>> the OS to interfere
On 06/24/20 20:43, Laszlo Ersek wrote:
> On 06/24/20 16:37, Andrew Jones wrote:
>> On Wed, Jun 24, 2020 at 03:48:46PM +0200, Ard Biesheuvel wrote:
>>> On 6/24/20 3:41 PM, Andrew Jones wrote:
On Wed, Jun 24, 2020 at 03:02:49PM +0200, Philippe Mathieu-Daudé wrote:
> On 6/24/20 1:43 PM, Ard
On 06/24/20 16:37, Andrew Jones wrote:
> On Wed, Jun 24, 2020 at 03:48:46PM +0200, Ard Biesheuvel wrote:
>> On 6/24/20 3:41 PM, Andrew Jones wrote:
>>> On Wed, Jun 24, 2020 at 03:02:49PM +0200, Philippe Mathieu-Daudé wrote:
On 6/24/20 1:43 PM, Ard Biesheuvel wrote:
>> ...
> I wasn't aware
Add definition of EFI_SERIAL_TERMINAL_DEVICE_TYPE_GUID.
It was miseed in "Extend SERIAL_IO with DeviceTypeGuid" patch.
(UEFI 2.8, mantis 1832)
Signed-off-by: Oleksiy Yakovlev
---
MdePkg/Include/Protocol/SerialIo.h | 6 ++
MdePkg/MdePkg.dec | 3 +++
2 files changed, 9 inserti
Reviewed-by: Nate DeSimone
-Original Message-
From: Gao, Liming
Sent: Wednesday, June 24, 2020 7:22 AM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Chiu, Chasel ; Desimone,
Nathaniel L ; Dong, Eric
Subject: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update
GetPciSegmentInfo() API
Upd
Reviewed-by: Nate DeSimone
-Original Message-
From: Desimone, Ashley E
Sent: Friday, June 19, 2020 6:03 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Agyeman,
Prince ; Oram, Isaac W
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Do not writ
Reviewed-by: Nate DeSimone
-Original Message-
From: Desimone, Ashley E
Sent: Friday, June 19, 2020 4:33 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: EdkRepo Sy
Hi Pierre,
There are some build failed in OpenCI. Would you please check it?
https://github.com/tianocore/edk2/pull/727
Thanks,
Bob
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Wednesday, June 24, 2020 5:09 PM
To: devel@edk2.groups.io
Cc: Pierre Gondois
On 6/24/20 3:15 PM, Philippe Mathieu-Daudé wrote:
On 6/24/20 2:19 PM, Ard Biesheuvel wrote:
On 6/24/20 1:48 PM, Laszlo Ersek wrote:
On 06/24/20 13:15, Ard Biesheuvel wrote:
Our UEFI guest firmware takes ownership of the emulated NOR flash in
order to support the variable runtime services, and
Hi Bauer,
Please check latest code, Ray just checked in a patch to remove hardcoded PCIe
base address as below.
commit 3900a63e3a1b9ba9a4105bedead7b986188cec2c
Author: Ray Ni
Date: Wed Jun 17 16:34:29 2020 +0800
UefiPayloadPkg/Pci: Use the PCIE Base Addr stored in AcpiBoardInfo HOB
Tha
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Gao, Liming
> Sent: Wednesday, June 24, 2020 10:22 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Dong, Eric
>
> Subject: [Patch] MinPlatformPkg PciSegmentInfoLibSimple: Update
> GetPciSegme
Reviewed-by: Dong, Guo
Thanks,
Guo
> -Original Message-
> From: Marcello Sylvester Bauer
> Sent: Wednesday, June 24, 2020 2:58 AM
> To: devel@edk2.groups.io
> Cc: Patrick Rudolph ; Christian Walter
> ; Ma, Maurice ;
> Dong, Guo ; You, Benjamin
>
> Subject: [PATCH v2 1/1] UefiPayloadP
One minor comment.
> -Original Message-
> From: Oleksiy Yakovlev
> Sent: Wednesday, June 24, 2020 12:29 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Kinney, Michael D
> ; fel...@ami.com; oleks...@ami.com
> Subject: [PATCH] MdePkg: Add Serial Terminal Device Type Guid
>
> Add defini
Reviewed-by: Liming Gao
> -Original Message-
> From: Laszlo Ersek
> Sent: Wednesday, June 24, 2020 5:27 PM
> To: Oleksiy Yakovlev ; devel@edk2.groups.io
> Cc: Gao, Liming ; Kinney, Michael D
> ; Bi, Dandan ; Ni,
> Ray ; Kumar, Rahul1 ; fel...@ami.com
> Subject: Re: [PATCH V2 1/3] MdePkg
Update GetPciSegmentInfo() API to match its library class definition
Signed-off-by: Liming Gao
Cc: Ray Ni
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Eric Dong
---
.../Pci/Library/PciSegmentInfoLibSimple/PciSegmentInfoLibSimple.c| 1 +
1 file changed, 1 insertion(+)
diff --git
a/Platform
Reviewed-by: Maurice Ma
> -Original Message-
> From: Marcello Sylvester Bauer
> Sent: Wednesday, June 24, 2020 2:58
> To: devel@edk2.groups.io
> Cc: Patrick Rudolph ; Christian Walter
> ; Ma, Maurice ;
> Dong, Guo ; You, Benjamin
> Subject: [PATCH v2 1/1] UefiPayloadPkg: Make TerminalDx
On 6/24/20 3:41 PM, Andrew Jones wrote:
On Wed, Jun 24, 2020 at 03:02:49PM +0200, Philippe Mathieu-Daudé wrote:
On 6/24/20 1:43 PM, Ard Biesheuvel wrote:
...
I wasn't aware that we even expose the flash in the DSDT. In any case,
no driver exists in Linux today that claims the LNRO0015 _HID, a
On Wed, Jun 24, 2020 at 3:42 PM Andrew Jones wrote:
> On Wed, Jun 24, 2020 at 03:02:49PM +0200, Philippe Mathieu-Daudé wrote:
> > On 6/24/20 1:43 PM, Ard Biesheuvel wrote:
> > > On 6/24/20 1:20 PM, Laszlo Ersek via groups.io wrote:
> > >> (CC Drew, Eric)
> > >>
> > >> On 06/24/20 09:19, Ard Bieshe
Kvmtool is a virtual machine manager that enables hosting
KVM guests. Kvmtool emulates certain devices like serial
port, RTC, etc. essentially providing a virtual platform.
This patch adds support for kvmtool virtual platform.
Following is a brief description of the firmware
implementation choice
The BaseSerialPortLib16550 library does not implement
a constructor. This prevents the correct constructor
invocation order for dependent libraries.
e.g. A PlatformHookLib (for the Serial Port) may have
a dependency on retrieving data from a Hob. A Hob
library implementation may configure its initi
The PlatformPeim() in the PlatformPeiLib is invoked
by the PrePiMain() and provides the platform an
opportunity to setup the plaform specific HOBs.
This PlatfromPeiLib initialises the Kvmtool platform
HOBs like the Fdt, 16550BaseAddress, etc.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/K
Kvmtool is a virtual machine manager that enables
hosting KVM guests. It essentially provides a
virtual hardware platform for guest operating
systems.
Kvmtool hands of a device tree containing the
current hardware configuration to the firmware.
A standards-based operating system would use
ACPI to
The BaseSerialPort16550 library invokes the
PlatformHookSerialPortInitialize() implemented as
part of the PlatformHook library, to perform platform
specific initialization required to enable use of the
16550 device. The BaseSerialPort16550 library uses
the PcdSerialRegisterBase to obtain the base a
Kvmtool is a virtual machine manager that enables
hosting KVM guests. Kvmtool allows to vary the
hardware configuration of the virtual platform
it provides to the guest partition. It provides
the current hardware configuration to the firmware
by handing off a device tree containing the hardware
inf
Kvmtool emulates a MC146818 RTC controller in the
MMIO space. To support this the MC146818 RTC driver
PcatRealTimeClockRuntimeDxe has been updated to
support MMIO accesses. PCDs for RTC Index and
Target register base addresses in the MMIO space
have been introduced. The KvmtoolRtcFdtClientLib
reads
Kvmtool is a virtual machine manager that can be used
to launch guest partitions. It additionally emulates
some hardware components e.g. RTC, CFI etc. essentially
providing a virtual platform for a guest operating
system (OS) to run.
A standards-based OS would need UEFI firmware support
for the Kv
Kvmtool is a virtual machine manager that can be used
to launch guest VMs. Support for Kvmtool virtual
platform has been added to ArmVirtPkg.
Add kvmtool to the ArmVirtPkg dictionary to prevent
the CI Spell check plugin from failing.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtPkg.ci.yaml
Initialise serial port early so that the platform
memory map can be logged.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/PrePi/PrePi.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ArmVirtPkg/PrePi/PrePi.c b/ArmVirtPkg/PrePi/PrePi.c
index
4f0c3f98bad63d0682cccd76a
Some virtual machine managers like kvmtool can relocate
the devices in the system memory map. The information
about the devices location in memory is described in the
device tree. Therefore, the CFI memory region and the
associated Non volatile storage variables need to be
adjusted accordingly.
To
Kvmtool is a virtual machine manager that can be used to launch
guest partitions. Kvmtool additionally supports emulation of
hardware like the RTC, CFI etc. essentially providing an
emulated platform for a Guest OS to run.
To boot a standards-based OS one would need UEFI. In this case
it is UEFI a
Introduce a new GUID Hob gEarly16550UartBaseAddressGuid
to cache the base address of the 16550 UART, for when
PCD access is not available.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/ArmVirtPkg.dec | 2 ++
ArmVirtPkg/Include/Guid/Early16550UartBaseAddress.h | 22 +++
Some virtual machine managers like Kvmtool emulate the MC146818
RTC controller in the MMIO space so that architectures that do
not support I/O Mapped I/O can use the RTC. This patch adds MMIO
support to the RTC controller driver.
The PCD PcdRtcUseMmio has been added to select I/O or MMIO support.
Add library that parses the Kvmtool device tree and updates
the dynamic PCDs describing the RTC Memory map.
It also maps the MMIO region used by the RTC as runtime memory
so that the RTC registers are accessible post ExitBootServices.
Since UEFI takes ownership of the RTC hardware disable the RTC
Kvmtool places the base address of the CFI flash in
the device tree it passes to UEFI. This library
parses the kvmtool device tree to read the CFI base
address and initialise the PCDs use by the NOR flash
driver and the variable storage.
UEFI takes ownership of the CFI flash hardware, and
exposes
On 6/24/20 2:19 PM, Ard Biesheuvel wrote:
> On 6/24/20 1:48 PM, Laszlo Ersek wrote:
>> On 06/24/20 13:15, Ard Biesheuvel wrote:
>>> Our UEFI guest firmware takes ownership of the emulated NOR flash in
>>> order to support the variable runtime services, and it does not expect
>>> the OS to interfere
On 6/24/20 1:43 PM, Ard Biesheuvel wrote:
> On 6/24/20 1:20 PM, Laszlo Ersek via groups.io wrote:
>> (CC Drew, Eric)
>>
>> On 06/24/20 09:19, Ard Biesheuvel wrote:
>>
>>> The arm64 defconfig was recently updated with MTD support, and so the
>>> flash banks are now claimed by the CFI flash driver. I
On 6/24/20 1:48 PM, Laszlo Ersek wrote:
On 06/24/20 13:15, Ard Biesheuvel wrote:
Our UEFI guest firmware takes ownership of the emulated NOR flash in
order to support the variable runtime services, and it does not expect
the OS to interfere with the underlying storage directly. So disable
the NO
From: Patrick Rudolph
Signed-off-by: Patrick Rudolph
Signed-off-by: Marcello Sylvester Bauer
Cc: Patrick Rudolph
Cc: Christian Walter
Cc: Maurice Ma
Cc: Nate DeSimone
Cc: Star Zeng
---
UefiPayloadPkg/Include/Guid/AcpiBoardInfoGuid.h | 1 +
UefiPayloadPkg/BlSupportPei/BlSupportPei.c |
From: Patrick Rudolph
* Don't hardcode PCIE_BASE at build time
* Support arbitrary platforms with different or even no MMCONF space
* Fix buffer overflow accessing MMCONF where less than 256 buses are
exposed
* Use PciCfg8 for PCI access in PEI, which is only used for debugging
Signed-off-by:
From: Patrick Rudolph
As the TerminalDxe significantly slows down the boot menu rendering,
add the DISABLE_SERIAL_TERMINAL option to disable it at build time.
Signed-off-by: Patrick Rudolph
Signed-off-by: Marcello Sylvester Bauer
Cc: Patrick Rudolph
Cc: Christian Walter
Cc: Maurice Ma
Cc: G
As the TerminalDxe significantly slows down the boot menu rendering,
add a DISABLE_SERIAL_TERMINAL option to disable it.
Changes in v2:
- do not change the default behaviour and add an option to disable it instead
Patrick Rudolph (1):
UefiPayloadPkg: Make TerminalDxe build time configurable
U
Support arbitrary platforms with different or even no MMCONF space.
This patch series is necessary for debugging coreboot with the edk2
payload on qemu targets.
Patrick Rudolph (2):
UefiPayloadPkg: Store the real size of the MMCONF window
UefiPayloadPkg: Runtime MMCONF
UefiPayloadPkg/UefiPay
On 06/24/20 10:32, Ni, Ray wrote:
> Zhichao,
> Will two BlockIo child devices cover the same range in the ISO after your
> patch?
>
> I don't think that's a valid behavior.
Right; I'm surprised to find the Red Hat reference in both the commit
message and the BZ.
I can't say I understand the iss
On 06/24/20 13:15, Ard Biesheuvel wrote:
> Our UEFI guest firmware takes ownership of the emulated NOR flash in
> order to support the variable runtime services, and it does not expect
> the OS to interfere with the underlying storage directly. So disable
> the NOR flash DT nodes as we discover the
On 6/24/20 1:20 PM, Laszlo Ersek via groups.io wrote:
(CC Drew, Eric)
On 06/24/20 09:19, Ard Biesheuvel wrote:
The arm64 defconfig was recently updated with MTD support, and so the
flash banks are now claimed by the CFI flash driver. I saw the same on
32-bit ARM today, and I am not sure if it
(CC Drew, Eric)
On 06/24/20 09:19, Ard Biesheuvel wrote:
> The arm64 defconfig was recently updated with MTD support, and so the
> flash banks are now claimed by the CFI flash driver. I saw the same on
> 32-bit ARM today, and I am not sure if it is a change there or whether
> it was always like t
Our UEFI guest firmware takes ownership of the emulated NOR flash in
order to support the variable runtime services, and it does not expect
the OS to interfere with the underlying storage directly. So disable
the NOR flash DT nodes as we discover them, in a way similar to how we
disable the PL031 R
On 06/23/20 23:55, Oleksiy Yakovlev wrote:
> Add usage of EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO
> attributes introduced in UEFI 2.8.
> (UEFI 2.8, mantis 1919 and 1872).
> Use attributes bitmasks, defined in MdePkg.
>
> Signed-off-by: Oleksiy Yakovlev
> ---
> UefiCpuPkg/CpuDxe/CpuDxe.c
On 6/24/20 11:00 AM, Laszlo Ersek wrote:
> On 06/24/20 09:19, Ard Biesheuvel wrote:
>> On 6/23/20 10:41 PM, Laszlo Ersek wrote:
>>> On 06/23/20 19:57, Ard Biesheuvel wrote:
Our UEFI guest firmware takes ownership of the emulated NOR flash in
order to support the variable runtime services,
On 06/23/20 23:55, Oleksiy Yakovlev wrote:
> Add usage of EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO
> attributes introduced in UEFI 2.8.
> (UEFI 2.8, mantis 1919 and 1872).
> Use attributes bitmasks, defined in MdePkg.
>
> Signed-off-by: Oleksiy Yakovlev
> ---
> MdeModulePkg/Core/Dxe/Gcd/Gcd.c
On 06/23/20 23:55, Oleksiy Yakovlev wrote:
> Add usage of EFI_MEMORY_SP and EFI_MEMORY_CPU_CRYPTO
> attributes introduced in UEFI 2.8.
> (UEFI 2.8, mantis 1919 and 1872).
> Fix typos in EFI_MEMORY_CPU_CRYPTO description.
> Add attributes bitmasks, grouped by type.
>
> Signed-off-by: Oleksiy Yakovl
From: Pierre Gondois
The AmlToHex script and Posix/WindowsLike wrappers convert
an AML file to a .hex file, containing a C array storing
AML bytecode. This ".hex" file can then be included in a
C file, allowing to access the AML bytecode from this C
file.
The EDK2 build system doesn't allow to a
From: Pierre Gondois
This patch modifies the Makefile generation not to stop
adding Makfile rules when the first final target is found.
E.g.:
If the following rules are described in build_rule.txt:
-[Rule1]: .X files generate .Y and .Z files;
-[Rule2]: .Z files generate .Z1 files.
Currently, if
Following the BZ at https://bugzilla.tianocore.org/show_bug.cgi?id=2425
This patch serie is a another way to solve the dependency
of C files over ASL files. With this new method, the
dependency is resolved at the linking stage.
The last method to solve this dependency was to add
the possibility to
From: Pierre Gondois
The AmlToHex script and Posix/WindowsLike wrappers convert
an AML file to a .hex file, containing a C array storing
AML bytecode. This ".hex" file can then be included in a
C file, allowing to access the AML bytecode from this C
file.
The EDK2 build system doesn't allow to a
From: Pierre Gondois
Using Python 3.7.2 on win32, when printing a FileBuildRule
instance, the following error occurs:
File "edk2\BaseTools\Source\Python\AutoGen\BuildEngine.py",
line 177, in __str__
DestString = ", ".join(self.DestFileList)
TypeError: sequence item 0: expected str instance, P
On 06/24/20 09:19, Ard Biesheuvel wrote:
> On 6/23/20 10:41 PM, Laszlo Ersek wrote:
>> On 06/23/20 19:57, Ard Biesheuvel wrote:
>>> Our UEFI guest firmware takes ownership of the emulated NOR flash in
>>> order to support the variable runtime services, and it does not expect
>>> the OS to interfere
On 06/24/20 03:04, Kirkendall, Garrett wrote:
> [AMD Public Use]
>
> Is there anything else needed from me for this patch at this time?
I think we still have an open question here:
https://edk2.groups.io/g/devel/message/61583
To clarify: I'm not suggesting that we should fix that issue. I'm s
Zhichao,
Will two BlockIo child devices cover the same range in the ISO after your patch?
I don't think that's a valid behavior.
Thanks,
Ray
> -Original Message-
> From: Gao, Zhichao
> Sent: Wednesday, June 24, 2020 1:56 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Ni, Ray ; Wang, Ji
On 6/23/20 10:41 PM, Laszlo Ersek wrote:
On 06/23/20 19:57, Ard Biesheuvel wrote:
Our UEFI guest firmware takes ownership of the emulated NOR flash in
order to support the variable runtime services, and it does not expect
the OS to interfere with the underlying storage directly. So disable
the N
67 matches
Mail list logo
