Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file.

2020-08-03 Thread Yao, Jiewen
The code is already pushed after review. Please take a look the latest one. If it does not work, then you can file a new BZ. Thank you Yao Jiewen From: Bret Barkelew Sent: Tuesday, August 4, 2020 1:05 PM To: Yao, Jiewen ; devel@edk2.groups.io; Zhang, Qi1 ; Bret Barkelew Cc: Wang, Jian J

Re: [edk2-devel] [PATCH 1/6] SecurityPkg/TcgPpi: Add TcgPpi header file.

2020-08-03 Thread Bret Barkelew via groups.io
The more I think about it, the more I like your idea of registering early and allowing a PPI notification callback. Is that something we could get in this change, or would it be best to open a new BZ to track that request? Thanks! - Bret From:

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, 4 August 2020 #cal-cancelled

2020-08-03 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VEVENT UID:mlda.1580078539586725120.r...@groups.io DTSTAMP:20200804T014910Z ORGANIZER;CN=Brian Richardson:mailto:brian.richard...@intel.com DTSTART:20200805T013000Z

[edk2-devel] [edk2-wiki][PATCH] Update the Boot Guard TOCTOU wiki page.

2020-08-03 Thread Guomin Jiang
The Boot Guard TOCTOU have been migrated into edk2/master. Update the document to meet the change. Signed-off-by: Guomin Jiang Cc: Jian J Wang Cc: Liming Gao --- Boot-Guard-TOCTOU-Vulnerability-Mitigation.md | 28 ++- 1 file changed, 8 insertions(+), 20 deletions(-) diff

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: smbiosview - Change some type 17 field values format

2020-08-03 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Samer El-Haj-Mahmoud > Sent: Tuesday, July 21, 2020 3:33 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao ; Sami > Mujawar > Subject: [PATCH v1 1/1] ShellPkg: smbiosview - Change some type 17 field >

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 08/04/2020 6:30pm-7:30pm #cal-reminder

2020-08-03 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 4 August 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816384 ) *Organizer:* Brian Richardson

Re: [edk2-devel] [PATCH V3] Maintainers.txt: Add reviewer for serial and disk

2020-08-03 Thread Gao, Zhichao
Sure. I would keep all the R-B because there is no other changes except the order and subject. Thanks, Zhichao > -Original Message- > From: Wu, Hao A > Sent: Tuesday, August 4, 2020 9:02 AM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wang, Jian J ; Gao, Liming ; > Ni, Ray ; Bi,

Re: [edk2-devel] [PATCH V3] Maintainers.txt: Add reviewer for serial and disk

2020-08-03 Thread Wu, Hao A
> -Original Message- > From: Gao, Zhichao > Sent: Monday, August 3, 2020 2:05 PM > To: devel@edk2.groups.io > Cc: Gao, Zhichao ; Wang, Jian J > ; Wu, Hao A ; Gao, Liming > ; Ni, Ray ; Bi, Dandan > ; Zeng, Star > Subject: [PATCH V3] Maintainers.txt: Add reviewer for serial and disk

[edk2-devel] [PATCH v2 0/2] CryptoPkg/OpensslLib: Add native instruction support for X64

2020-08-03 Thread Zurcher, Christopher J
V2 Changes: Limit scope of assembly config to SHA and AES functions. Removed IA32 native support (reduced config was causing build failure and can be added in a later patch). Removed XMM instructions from assembly generation. Added automatic copyright header porting for generated

[edk2-devel] [PATCH v2 1/2] CryptoPkg/OpensslLib: Add native instruction support for X64

2020-08-03 Thread Zurcher, Christopher J
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2507 Adding OpensslLibX64.inf and modifying process_files.pl to process this file and generate the necessary assembly files. ApiHooks.c contains a stub function for a Windows API call. uefi-asm.conf contains the limited assembly configurations

Re: [edk2-devel] [EXTERNAL] [PATCH v2 1/1] .pytool/Plugin/HostUnitTestCompilerPlugin: Enable BUILDREPORT on host tests

2020-08-03 Thread Bret Barkelew via groups.io
Second version (ignore the title) of this coming soon to update the regular builds and collect the artifacts. - Bret From: Bret Barkelew Sent: Monday, August 3, 2020 3:50 PM To: devel@edk2.groups.io Cc: Sean

[edk2-devel] [PATCH v2 1/1] .pytool/Plugin/HostUnitTestCompilerPlugin: Enable BUILDREPORT on host tests

2020-08-03 Thread Bret Barkelew
Update the CI invocable that builds host-based unit tests to make sure that BUILDREPORT is built for all tests. This is useful for determining which libraries were consumed in the build. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Bret Barkelew ---

Re: [edk2-devel] [PATCH v3 0/3] Use RngLib instead of TimerLib for OpensslLib

2020-08-03 Thread Michael D Kinney
Hi Sean, Use of BaseCryptLibNull and TlsLibNull in packages other than CryptoPkg does reduce build times for package verification builds. So that sounds like a good idea to reduce CI overhead. I would add that platform packages that build bootable FW images should not use the Null instances.

Re: [edk2-devel] Propose on enabling TLSv1.3

2020-08-03 Thread Michael D Kinney
Hi Mathew, There are a couple Tianocore Bugzillas open on this topic https://bugzilla.tianocore.org/show_bug.cgi?id=2424 https://bugzilla.tianocore.org/show_bug.cgi?id=2541 I recommend you review these and comment on the current proposals. Best regards, Mike From: devel@edk2.groups.io On

[edk2-devel] Propose on enabling TLSv1.3

2020-08-03 Thread Huang, Matthew (HPS SW)
Hi: It's Matthew from HPE UEFI team. There is no TLSv1.3 support under current EDK2 releases, and I'm working on enabling TLSv1.3 under UEFI and the result looks promising. OpenSSL have already made RFC8446 happens in late 2018, the submodule we're having on the master branch is more than

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixing inconsistent win32 HOME path mapping

2020-08-03 Thread Ashley E Desimone
Reviewed-by: Ashley DeSimone -Original Message- From: Bjorge, Erik C Sent: Wednesday, July 29, 2020 6:10 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo:

Re: [edk2-devel] [PATCH v3 0/3] Use RngLib instead of TimerLib for OpensslLib

2020-08-03 Thread Sean
I would rather see the the BaseCryptLib and TlsLib instance in all packages other than CryptoPkg should use the NULL instance of the libs. This would avoid the dependency. Any concerns of going this route? Thanks Sean On 8/3/2020 12:03 AM, Liming Gao wrote: Hi Matt: With this change,

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] Platforms/RaspberryPi: Fix RPi4 GICC PMU PPI

2020-08-03 Thread Pete Batard
Adding a tested-by, since these are values that could potentially trip the custom handling that Windows seems to have of MADT, and I hadn't tested that yet. Testing shows that Windows is happy with these new values, so with this: On 2020.07.31 08:55, Pete Batard via groups.io wrote: On

Re: [edk2-devel] [PATCH v4 0/2] refine TPM2 operation pull down list

2020-08-03 Thread Wang, Jian J
Qi, Please remove Chao Zhang from Cc list when you compose final push patch files. His address not valid any more. Regards, Jian > -Original Message- > From: Zhang, Qi1 > Sent: Tuesday, July 28, 2020 4:21 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Wang, Jian J ;

Re: [edk2-devel] [PATCH v4 1/2] SecurityPkg/Tpm2CommandLib: add a new function

2020-08-03 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Qi Zhang > Sent: Tuesday, July 28, 2020 4:21 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Wang, Jian J ; Chao Zhang ; > Kumar, Rahul1 > Subject: [edk2-devel]

Re: [edk2-devel] [PATCH v4 2/2] SecurityPkg/Tcg2Config: remove TPM2_ChangEPS if it is not supported.

2020-08-03 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Qi Zhang > Sent: Tuesday, July 28, 2020 4:21 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Yao, Jiewen ; > Wang, Jian J ; Chao Zhang ; > Kumar, Rahul1 > Subject: [edk2-devel]

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] Platforms/RaspberryPi: Fix BIOS Release Date and System Manufacturer

2020-08-03 Thread Leif Lindholm
On Mon, Aug 03, 2020 at 13:14:26 +0100, Pete Batard wrote: > Per SMBIOS specs, The Type 0 BIOS Release Date is not a free form field but > must be specified in a US middle-endian format (mm/dd/), so make sure > we populate it accordingly by using the recently introduced TimeBaseLib > macros.

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/TimeBaseLib: Add macros to get build year/month/day

2020-08-03 Thread Leif Lindholm
Hi Pete, On Mon, Aug 03, 2020 at 13:21:41 +0100, Pete Batard wrote: > On 2020.08.03 13:09, Leif Lindholm wrote: > > Hi Pete, > > > > Well prodded (off-list). > > > > I expect I saw that arrive, expected the corresponding RPi > > resubmission to arrive shortly afterwards for me to test with and

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/TimeBaseLib: Add macros to get build year/month/day

2020-08-03 Thread Pete Batard
Hi Leif, On 2020.08.03 13:09, Leif Lindholm wrote: Hi Pete, Well prodded (off-list). I expect I saw that arrive, expected the corresponding RPi resubmission to arrive shortly afterwards for me to test with and put it soundly at the back of my mind. Presumably you were waiting for this to be

[edk2-devel] [edk2-platforms][PATCH v2 1/1] Platforms/RaspberryPi: Fix BIOS Release Date and System Manufacturer

2020-08-03 Thread Pete Batard
Per SMBIOS specs, The Type 0 BIOS Release Date is not a free form field but must be specified in a US middle-endian format (mm/dd/), so make sure we populate it accordingly by using the recently introduced TimeBaseLib macros. This is required for platforms like Windows, that fail to parse the

[edk2-devel] [edk2-platforms][PATCH v2 0/1] Platforms/RaspberryPi: Fix BIOS Release Date and System Manufacturer

2020-08-03 Thread Pete Batard
Changes from v1: * Use the newly introduced EmbeddedPkg/Include/Library/TimeBaseLib.h macros. Pete Batard (1): Platforms/RaspberryPi: Fix BIOS Release Date and System Manufacturer Platform/RaspberryPi/Drivers/PlatformSmbiosDxe/PlatformSmbiosDxe.c | 12 ++-- 1 file changed, 10

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/TimeBaseLib: Add macros to get build year/month/day

2020-08-03 Thread Leif Lindholm
Hi Pete, Well prodded (off-list). I expect I saw that arrive, expected the corresponding RPi resubmission to arrive shortly afterwards for me to test with and put it soundly at the back of my mind. Presumably you were waiting for this to be merged before resubmitting that one? Anyway:

Re: [edk2-devel] [PATCH] MdePkg: Remove code wrapped by DISABLE_NEW_DEPRECATED_INTERFACES

2020-08-03 Thread Pete Batard
And done for RPi in https://edk2.groups.io/g/devel/message/63661 Regards, /Pete On 2020.07.31 16:56, Marcin Wojtas wrote: Hi Ard, pt., 31 lip 2020 o 10:27 Ard Biesheuvel napisał(a): The reason PcdSet## was deprecated in the first place was because it cannot signal failure, whereas

[edk2-devel] [edk2-platforms][PATCH v2 1/1] Platforms/RaspberryPi: Switch to PcdSet##S

2020-08-03 Thread Pete Batard
According to the bug: https://bugzilla.tianocore.org/show_bug.cgi?id=2777 the deprecated code under DISABLE_NEW_DEPRECATED_INTERFACES will be removed, which will result in compilation breakage of the Raspberry Pi platforms. Prevent that by switching to the different PcdSet API. Signed-off-by:

Re: [edk2-devel] [PATCH v3 0/3] Use RngLib instead of TimerLib for OpensslLib

2020-08-03 Thread Liming Gao
Hi Matt: With this change, which library instance should be used for the platform? BaseRngLibTimerLib? And, this patch introduces the dependency for RngLib. Then, NetworkPkg and FmpDevicePkg package level build will break. Will you update them? Thanks Liming -Original Message-

Re: [edk2-devel] [PATCH V3] Maintainers.txt: Add reviewer for serial and disk

2020-08-03 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: devel@edk2.groups.io On Behalf Of Gao, Zhichao Sent: 2020年8月3日 14:05 To: devel@edk2.groups.io Cc: Gao, Zhichao ; Wang, Jian J ; Wu, Hao A ; Gao, Liming ; Ni, Ray ; Bi, Dandan ; Zeng, Star Subject: [edk2-devel] [PATCH V3]

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Fixing inconsistent win32 HOME path mapping

2020-08-03 Thread Nate DeSimone
Reviewed-by: Nate DeSimone On 7/29/20, 6:10 PM, "Bjorge, Erik C" wrote: In Python 3.8.x the method of mapping the users home path was changed to look at USERPROFILE and then HOMEDRIVE\HOMEPATH. This change removed the check of HOME generated by git BASH based on

[edk2-devel] [PATCH V3] Maintainers.txt: Add reviewer for serial and disk

2020-08-03 Thread Gao, Zhichao
From: "Gao, Zhichao" Signed-off-by: Zhichao Gao Cc: Jian J Wang Cc: Hao A Wu Cc: Liming Gao Cc: Ray Ni Cc: Dandan Bi Cc: Star Zeng --- V2: Forget to remove the *SerailPort*.h from the common device section in V1. Fix it in V2. V3: Add the missing ':' in V2 for Disk mdoules. Add one more