Re: [EXTERNAL] [edk2-devel] [PATCH v4 0/8] Need add a FSP binary measurement

Awesome. That gives me a little time. Thanks, Jiewen! And thanks for tracking the issue. - Bret From: Yao, Jiewen Sent: Thursday, August 20, 2020 11:16 PM To: devel@edk2.groups.io; Bret Barkelew; Zhang

Re: [EXTERNAL] [edk2-devel] [PATCH v4 0/8] Need add a FSP binary measurement

We are in SFF. I posted to https://github.com/jyao1/edk2/tree/FspManifestNew temporarily. Please let us know if you have any feedback. I plan to post after the 202008 stable tag. Thank you Yao Jiewen From: devel@edk2.groups.io On Behalf Of Bret Barkelew via groups.io Sent: Friday, August 21,

Re: [EXTERNAL] [edk2-devel] [PATCH v4 0/8] Need add a FSP binary measurement

Does this live in a branch somewhere? I'd like to take a look at it and make sure it fully replaces our current custom solution. Thanks! - Bret From: devel@edk2.groups.io on behalf of Qi Zhang via groups.io Sent: Monday, August 17, 2020 11:26 PM To: devel@ed

Re: [edk2-devel] [PATCH v2 2/6] FmpDevicePkg: Add LastAttemptStatus.h

Hi Michael, I guess I might not understand the exact use cases for the enum. It seems like the meaning of the error codes you only want to be known within FmpDevicePkg, but it appears to me that the error code values could traverse to drivers outside this package, is that correct? Thanks, Nate

Re: [edk2-devel] [PATCH v2 3/4] Platform/RaspberryPi: Add entry for user fan control

Hi, On 8/20/20 11:15 AM, Andrei Warkentin wrote: Hi Jeremy, Overall, great idea. An improvement on your implementation would be to use LocateAndInstallAcpiFromFvConditional (which will call your call back on every table, so you can allow/disallow/patch) instead of calling LocateAndInstallAcp

Re: [edk2-devel] Patch List for 202008 stable tag

Ok. Thanks. Just make sure someone will help to merge it. Abner From: Gao, Liming [mailto:liming@intel.com] Sent: Friday, August 21, 2020 12:12 PM To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) ; Leif Lindholm ; Laszlo Ersek ; af...@apple.com; Kinney, Michael D ; Guptha, S

Re: [edk2-devel] Patch List for 202008 stable tag

Abner: I plan to wait 1~2 days and collect the feedback about delay 202008 stable tag. If no objection, I will help merge this change. Thanks Liming From: devel@edk2.groups.io On Behalf Of Abner Chang Sent: 2020年8月21日 11:22 To: Gao, Liming ; Leif Lindholm ; Laszlo Ersek ; af...@apple.com; Kinn

Re: [edk2-devel] Patch List for 202008 stable tag

Hi Liming, I didn't see https://edk2.groups.io/g/devel/message/63767 [PATCH] EmbeddedPkg/libfdt: Add strncmp macro to use AsciiStrnCmp push to edk2 master and today is 8/12. Could you please help to push this commit? Thanks Abner From: Gao, Liming

Re: [edk2-devel] [PATCH v3 0/6] Extend Last Attempt Status Usage

Michael, #1 I would suggest calling out the sub-range 0x10A0 | 0x17FF -- Free for Library Implementations of FmpDevicePkg I also might suggest splitting FmpDependencyLib and FmpDependencyCheckLib ranges just to show a consistent pattern of how each library instance within FmpDevicePkg gets a

Re: [edk2-devel] [PATCH v3 0/6] Extend Last Attempt Status Usage

Hi Mike, 1) Yes, we can certainly leave more of the unsuccessful vendor range available for future expansion. I believe we can also reduce the FMP reserved range. How about a length of 0x800 for both? The ranges would then be defined as follows: START | END | Usage

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable

Tested-by: Liming Gao -Original Message- From: Dong, Eric Sent: 2020年8月21日 8:39 To: devel@edk2.groups.io; thomas.lenda...@amd.com Cc: Gao, Liming ; Ni, Ray ; Laszlo Ersek ; Kumar, Rahul1 Subject: RE: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable

Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Lendacky, Thomas > Sent: Thursday, August 20, 2020 10:53 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Dong, Eric ; > Ni, Ray ; Laszlo Ersek ; Kumar, > Rahul1 > Subject: [edk2-devel] [PATCH v2 1/

Re: [edk2-devel] [PATCH v8 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

Thank you Mike and Ard, I'll definitely run ECC and resolve the code nits as well as the other suggestions. So the previous RNG code in OpenSSL just had a 10-microsecond delay in between every 2 bytes. We could go back to that and match the behavior of before but as Mike pointed out, this approac

Re: [edk2-devel] [PATCH v2 3/4] Platform/RaspberryPi: Add entry for user fan control

Hi Jeremy, Overall, great idea. An improvement on your implementation would be to use LocateAndInstallAcpiFromFvConditional (which will call your call back on every table, so you can allow/disallow/patch) instead of calling LocateAndInstallAcpiFromFv and the locating the SSDT manually. A _

Re: [edk2-devel] [Patch ] IP is getting Configured when IP Configuration is disabled

Hi Siva, If you want to propose a patch for review, please follow the process: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers I do not think my

Re: [edk2-devel] Patch List for 202008 stable tag

Hi Gao, > -Original Message- > From: Tom Lendacky > Sent: Thursday, August 20, 2020 5:44 AM > To: Gao, Liming ; Leif Lindholm ; > Laszlo Ersek ; af...@apple.com; Kinney, Michael D > ; Guptha, Soumya K > ; Chang, Abner (HPS SW/FW Technologist) > ; Vladimir Olovyannikov > > Cc: devel@edk2.

Re: [edk2-devel] [PATCH v8 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

Hi Matt, Some comments inline below. I also see come comments from Ard on this series about code style. I did not provide feedback on the code style issues here (except for a function header comment block style). There is a tool called ECC (EFI Code Checker) that is now enabled in EDK II CI. Pl

Re: [edk2-devel] [Patch ] IP is getting Configured when IP Configuration is disabled

Jiaxin: Did you get chance to review the patch? -Siva From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Sivaraman Nainar Sent: Thursday, August 13, 2020 12:21 PM To: devel@edk2.groups.io Cc: liming@intel.com; jiaxin...@intel.com Subject: [edk2-devel] [Patch ] IP is gettin

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, 21 August 2020 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VEVENT UID:g7lq.1578029159272351097.u...@groups.io DTSTAMP:20200820T151357Z ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com DTSTART:20200821T013000Z DTEND:20200821T023000Z SUMMARY:Tiano

[edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable

From: Tom Lendacky REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2901 The DoDecrement variable in ApWakeupFunction () wasn't always being initialized. Update the code to always fully initialize it. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Tom Lendacky

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: Always initialize the DoDecrement variable

Hi Liming, It didn't feel quite right to keep your Tested-by: and Reviewed-by: for the change in v2 that I'm about to send. So please re-test / re-review. Thanks, Tom On 8/19/20 2:08 AM, Gao, Liming wrote: Tested-by: Liming Gao Reviewed-by: Liming Gao -Original Message- From: Tom

Re: [edk2-devel] [PATCH v2 1/4] Platform/RaspberryPi4: Add a basic thermal zone

Hi, On 8/20/20 2:59 AM, Ard Biesheuvel wrote: On 8/20/20 6:42 AM, Jeremy Linton wrote: Rather than exporting the temp sensor or mailbox in ACPI land we can wrap them in AML and use the default ACPI drivers provided by the OS. This enables the use of "sensors" in linux to report the SOC temp. T

Re: [edk2-devel] [PATCH v1] NetworkPkg/UefiPxeBcDxe: Fix PXE_BOOT_SERVERS usage in boot info parse flow

On 20/08/2020 11:44, Maciej Rabeda wrote: @Michael I am now wondering whether bit 3 is actually relevant to server choice. Bit 3: == 0 -> prompt user to choose a boot file. Which means to me: show minimal menu with prompt (tag 10 - PXE_MENU_PROMPT) and options (tag 9 - PXE_BOOT_MENU). == 1 ->

Re: [edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2

It might be worth mentioning that this patch fixes the build issue with commit https://github.com/tianocore/edk2-platforms/commit/e8fe2026dd7936c8c1661ec9289766f3b0c6d382 Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Ard Biesheuvel Sent: 20 August 2020 09:1

Re: [edk2-devel] Patch List for 202008 stable tag

Oh, I didn't realize you were waiting on another version of the bug fix. I'll send a v2 with the change over to: DoDecrement = (BOOLEAN) (CpuMpData->InitFlag == ApInitConfig); Thanks, Tom On 8/20/20 6:30 AM, Gao, Liming wrote: Hi Stewards and all:   I collect current patch lists in devel

Re: [edk2-devel] [PATCH edk2-platforms 0/7] Add ACPI tables support for SbsaQemu

Thanks. All done reviewing. On the whole, it looks good, but there are some minor things left to clean up. So please send out a v2 based on the comments I made. Best Regards, Leif On Wed, Aug 19, 2020 at 19:59:58 +0530, Tanmay Jagdale wrote: > This patch series adds ACPI tables support for the

Re: [edk2-devel] [PATCH edk2-platforms 7/7] SbsaQemu: AcpiTables: Add DBG2 Table

On Wed, Aug 19, 2020 at 20:00:05 +0530, Tanmay Jagdale wrote: > Signed-off-by: Tanmay Jagdale > --- > .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 + > Silicon/Qemu/SbsaQemu/AcpiTables/Dbg2.aslc| 68 +++ > 2 files changed, 69 insertions(+) > create mode 100644 Silicon/Q

Re: [edk2-devel] [PATCH edk2-platforms 6/7] SbsaQemu: AcpiDxe: Create PPTT table at runtime

On Wed, Aug 19, 2020 at 20:00:04 +0530, Tanmay Jagdale wrote: > Add support to create Processor Properties Topology Table at > runtime. The cache topology of each CPU is as follows: > > CPU N > > | | > | |

Re: [edk2-devel] [PATCH edk2-platforms 5/7] SbsaQemu: AcpiDxe: Create SSDT table at runtime

On Wed, Aug 19, 2020 at 20:00:03 +0530, Tanmay Jagdale wrote: > - Add support to create SSDT table at runtime. Since SSDT > table is a data table, added a few helper macros to create > the AML entries. > - Also added a function to calculate the length of Packages. > > Signed-off-by: Tanmay Jag

Re: [edk2-devel] [PATCH edk2-platforms 4/7] SbsaQemu: AcpiDxe: Create MADT table at runtime

On Wed, Aug 19, 2020 at 20:00:02 +0530, Tanmay Jagdale wrote: > - Add support to create MADT table at runtime. > - Included a macro for GIC Redistributor structure initialisation. > > Signed-off-by: Tanmay Jagdale > --- > .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 159 ++ >

Re: [edk2-devel] [PATCH edk2-platforms 3/7] SbsaQemu: Add new ACPI driver and FDT parser to count CPUs

On Wed, Aug 19, 2020 at 20:00:01 +0530, Tanmay Jagdale wrote: > - Add a new ACPI driver for the SbsaQemu platform which would > handle any modifications needed for the ACPI tables. > > - Move FdtLib from LibraryClasses.common.PEIM to LibraryClasses.common > so that SbsaQemuAcpiDxe driver can u

Re: [edk2-devel] [PATCH edk2-platforms 2/7] SbsaQemu: AcpiTables: Add PCI support and MCFG Table

On Wed, Aug 19, 2020 at 20:00:00 +0530, Tanmay Jagdale wrote: > Add PCI related entries to DSDT table along with the routing > entries. Also add the MCFG table. > > Co-authored-by: Graeme Gregory > Signed-off-by: Tanmay Jagdale > --- > .../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 + > Si

Re: [edk2-devel] [PATCH edk2-platforms 1/7] SbsaQemu: Initial support for static ACPI tables

On Wed, Aug 19, 2020 at 19:59:59 +0530, Tanmay Jagdale wrote: > - Add the following ACPI tables for SbsaQemu platform > DSDT, FADT, GTDT, SPCR > - Created an Include directory to hold common header files. > - Also included the Acpiview shell utility. > > Co-authored-by: Graeme Gregory > Co-au

[edk2-devel] Patch List for 202008 stable tag

Hi Stewards and all: I collect current patch lists in devel mail list. Those patch contributors request to add them for 202008 stable tag. Because we have enter into Soft Feature Freeze, I want to collect your feedback for them. If any patches are missing, please reply this mail to add them.

Re: [edk2-devel] [PATCH v5 2/3] MdePkg: PciExpressLib support variable size MMCONF

Thanks for your updates. This version is good to me. Reviewed-by: Liming Gao -Original Message- From: Marcello Sylvester Bauer Sent: 2020年8月18日 16:24 To: devel@edk2.groups.io Cc: Patrick Rudolph ; Christian Walter ; Kinney, Michael D ; Gao, Liming Subject: [PATCH v5 2/3] MdePkg: Pci

Re: [edk2-devel] [PATCH v1] NetworkPkg/UefiPxeBcDxe: Fix PXE_BOOT_SERVERS usage in boot info parse flow

@Laszlo Thanks for regression test! I need to correct the typo in commit msg, (bit 3 -> bit 2). Code logic is not affected. @Michael I am now wondering whether bit 3 is actually relevant to server choice. Bit 3: == 0 -> prompt user to choose a boot file. Which means to me: show minimal menu wi

Re: [edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2

On Wed, Aug 19, 2020 at 20:23:43 +0530, Vijayenthiran Subramaniam wrote: > PcdChipCount constant is used to define the maximum number chips > included in the multi-chip configuration. Add this constant to the > RDN1EdgeX2 ACPI tables build information (INF) file to allow this > constant to be used

Re: [edk2-devel] UefiPayloadPkg: Slimboot assign PCIe resource above 4GB. but not supported in UEFIPayload

would you be able to update me when this will be in some sort of state and ready for testing on my side ? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#64489): https://edk2.groups.io/g/devel/message/64489 Mute This Topic: https://groups

Re: [edk2-devel] [PATCH] SgiPkg: Add chip count PCD to build information file for rdn1edgex2

(+ Sami) On 8/19/20 4:53 PM, Vijayenthiran Subramaniam wrote: PcdChipCount constant is used to define the maximum number chips included in the multi-chip configuration. Add this constant to the RDN1EdgeX2 ACPI tables build information (INF) file to allow this constant to be used in the RDN1EdgeX

Re: [edk2-devel] [PATCH v8 2/5] MdePkg: BaseRngLibDxe: Add RngLib that uses RngDxe

On 8/19/20 9:37 PM, matthewfcarl...@gmail.com wrote: From: Matthew Carlson This adds a RngLib that uses the RngProtocol to provide randomness. This means that the RngLib is meant to be used with DXE_DRIVERS. Ref: https://github.com/tianocore/edk2/pull/845 Ref: https://bugzilla.tianocore.org/sh

Re: [edk2-devel] [PATCH v8 1/5] MdePkg: TimerRngLib: Added RngLib that uses TimerLib

On 8/19/20 9:37 PM, matthewfcarl...@gmail.com wrote: From: Matthew Carlson Added a new RngLib that provides random numbers from the TimerLib using the performance counter. This is meant to be used for OpenSSL to replicate past behavior. This should not be used in production as a real source of

Re: [edk2-devel] [PATCH v2 1/4] Platform/RaspberryPi4: Add a basic thermal zone

On 8/20/20 6:42 AM, Jeremy Linton wrote: Rather than exporting the temp sensor or mailbox in ACPI land we can wrap them in AML and use the default ACPI drivers provided by the OS. This enables the use of "sensors" in linux to report the SOC temp. This commit also adds a basic passive cooling ACP