Re: [edk2-devel] Http redirection handling using HttpDxe driver

2020-08-28 Thread Sean
I think this is the similar to issue 1674 which was reported in early 2019. https://bugzilla.tianocore.org/show_bug.cgi?id=1674 I'll check internally to find out what we ended up doing to work around it. I think we closed the socket and opened a new one. This was less than ideal and is not

Re: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-28 Thread Yao, Jiewen
My understanding is that if it is something NOT related to EFI, then we use RETURN_XXX. The best example is the BaseLib - StrCpyS, PciLib If we know it is related to EFI, then we use EFI_XXX. E.g. the DxeServiceLib, UefiLib However, there are some gray area. For example: -- UnitTestLib uses

Re: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-28 Thread Bret Barkelew via groups.io
Question (since it’s been brought up): when *wouldn’t* you use EFI_*? They’re clearly superior in every way. I mean, they’ve got EFI right in the name. - Bret From: Yao, Jiewen via groups.io Sent: Friday, August 28, 2020 5:20 PM To: Laszlo

Re: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-28 Thread Yao, Jiewen
Laszlo Good feedback. > The reason is that this change actually requires us to change the lib > class header too. Consider: the whole motivation for the patch is that a > client module that is more primitive than either a PEIM or a DXE_DRIVER > wants to consume the lib instance. That requires

Re: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-28 Thread Laszlo Ersek
On 08/28/20 19:17, Laszlo Ersek wrote: > On 08/28/20 08:15, Qi Zhang wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940 >> >> TpmMeasurementLib includes DxeTpmMeasurementLib and PeiTpmMeasurementLib. >> So need to change TpmMeasurementLibNull to BASE library to avoid build >>

[edk2-devel] [PATCH v3 1/5] Platform/RaspberryPi4: Add a basic thermal zone

2020-08-28 Thread Jeremy Linton
Rather than exporting the temp sensor or mailbox in ACPI land we can wrap them in AML and use the default ACPI drivers provided by the OS. This enables the use of "sensors" in linux to report the SOC temp. As a first pass add a basic passive cooling ACPI thermalzone with trip points for passive

[edk2-devel] [PATCH v3 0/5] Platform/RasberryPi: Thermal zone

2020-08-28 Thread Jeremy Linton
This set creates a basic thermal zone, which reads the SOC temp via a direct register read in AML. It also adds an active cooling policy using a GPIO pin for fan control that can optionally be enabled/disabled on either GPIO18 (commercial fan shim board) or GPIO19 by the user from the BDS. it

[edk2-devel] [PATCH v3 2/5] Platform/RaspberryPi: Monitor ACPI Table installs

2020-08-28 Thread Jeremy Linton
Hook the ACPI table install sequence and add some basic conditional and AML NameOp update logic. If a table has a non-zero PCD declared that pcd is checked for a non-zero value before allowing the table to be installed. We also add a table of NameOp to PCD's which will be written into a DSDT/SSDT

[edk2-devel] [PATCH v3 5/5] Platform/RaspberryPi: Trivial whitespace cleanup

2020-08-28 Thread Jeremy Linton
Pete's review pointed out some whitespace issues in the context of a previous patch. Since there are a number of similar errors in the file lets fix them separately. Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Cc: Samer El-Haj-Mahmoud Signed-off-by: Jeremy

[edk2-devel] [PATCH v3 3/5] Platform/RaspberryPi: Add entry for user fan control

2020-08-28 Thread Jeremy Linton
Add a menu item that allows the user to enable GPIO based fan control via SSDT and the previous NameObj replacement commit. This should only be seen/enabled on RPI4 because that is what its been tested with. Given GPIO pin current limitations its likely that a bit of additional circuitry is

[edk2-devel] [PATCH v3 4/5] Platform/RaspberryPi4: Create ACPI fan object

2020-08-28 Thread Jeremy Linton
Now that we have a thermal zone we can add active cooling by specifying active cooling points (_ACx) which can be tied to fan objects that turn fans on/off using GPIO pins. Cc: Leif Lindholm Cc: Pete Batard Cc: Andrei Warkentin Cc: Ard Biesheuvel Cc: Samer El-Haj-Mahmoud Signed-off-by:

Re: [edk2-devel] [PATCH v3 0/6] Extend Last Attempt Status Usage

2020-08-28 Thread Michael D Kinney
Hi Michael, There are implementations of FMpDeviceLib in edk2-platforms. So the challenge is how to prepare a set of patch series to edk2 and edk2-platforms where there are no intermediate states that break builds. Adding new APIs and later removing the old APIs is one way to meet this

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

2020-08-28 Thread Paul
[AMD Public Use] * I'm new with this process. I believe the next steps are in your hands? Please let me know if you need anything from me to proceed.  Thanks, Paul -Original Message- From: Grimes, Paul Sent: Friday, August 28, 2020 12:09 PM To: gaoliming ; devel@edk2.groups.io;

Re: [edk2-devel] [PATCH v3 0/6] Extend Last Attempt Status Usage

2020-08-28 Thread Michael Kubacki
Hi Mike, We've stated a few reasons we prefer to change the library API now. Do you find that acceptable for v4? Thanks, Michael On 8/21/2020 2:25 PM, Michael Kubacki wrote: Hi Sean, Thanks for the feedback. #1 - I will include both suggestions in v4. Thanks, Michael On 8/20/2020 7:37

Re: [edk2-devel] intel: EDK2 Build failure for Quark/Gallileo

2020-08-28 Thread Michael D Kinney
Hi, I have send a patch series for review that resolves the EDK2 Quark build failures. https://edk2.groups.io/g/devel/message/64769 Please try this patch series and let me know if it resolves your issues. There does appear to be a regression in BaseTools in the use of a RuleOverride in an

Re: [edk2-devel] [edk2-platforms][Patch 1/3] QuarkSocPkg/RuntimeQNCAccessLib: Add missing GUID

2020-08-28 Thread Steele, Kelly
Reviewed-by: Kelly Steele > -Original Message- > From: Kinney, Michael D > Sent: Friday, August 28, 2020 12:14 PM > To: devel@edk2.groups.io > Cc: Steele, Kelly > Subject: [edk2-platforms][Patch 1/3] QuarkSocPkg/RuntimeQNCAccessLib: > Add missing GUID > > Add missing

Re: [edk2-devel] [edk2-platforms][Patch 0/3] Fix Quark build issues

2020-08-28 Thread Steele, Kelly
Reviewed-by: Kelly Steele > -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael > D Kinney > Sent: Friday, August 28, 2020 12:14 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms][Patch 0/3] Fix Quark build issues > > Fix issues that are

Re: [edk2-devel] [edk2-platforms][Patch 3/3] QuarkPlatformPkg: Remove use of TIANOCOMPRESSED RuleOverride

2020-08-28 Thread Steele, Kelly
Reviewed-by: Kelly Steele > -Original Message- > From: Kinney, Michael D > Sent: Friday, August 28, 2020 12:14 PM > To: devel@edk2.groups.io > Cc: Steele, Kelly > Subject: [edk2-platforms][Patch 3/3] QuarkPlatformPkg: Remove use of > TIANOCOMPRESSED RuleOverride > > Temporarily

Re: [edk2-devel] [edk2-platforms][Patch 2/3] QuarkPlatformPkg: Removed reference to retired PCD

2020-08-28 Thread Steele, Kelly
Reviewed-by: Kelly Steele > -Original Message- > From: Kinney, Michael D > Sent: Friday, August 28, 2020 12:14 PM > To: devel@edk2.groups.io > Cc: Steele, Kelly > Subject: [edk2-platforms][Patch 2/3] QuarkPlatformPkg: Removed reference > to retired PCD > > Remove all references to

Re: [edk2-devel] [PATCH V2 2/2] BaseTools: Factorize GCC flags

2020-08-28 Thread Leif Lindholm
On Fri, Aug 28, 2020 at 18:56:45 +0200, Laszlo Ersek wrote: > >> Leif, please comment! > > > > I did propose reverting it. But I asked for Ard's feedback on the > > reason for why we had the break in the flags-chain, in case he > > remembered (and he was on holiday at the time). > > > >

[edk2-devel] [edk2-platforms][Patch 3/3] QuarkPlatformPkg: Remove use of TIANOCOMPRESSED RuleOverride

2020-08-28 Thread Michael D Kinney
Temporarily disable use of TIANOCOMPRESSED RuleOverride. This is causing a build break and appears to be a regression in BaseTools. Once BaseTools issue is resolved, this change can be reverted. Cc: Kelly Steele Signed-off-by: Michael D Kinney --- Platform/Intel/QuarkPlatformPkg/Quark.fdf | 2

[edk2-devel] [edk2-platforms][Patch 2/3] QuarkPlatformPkg: Removed reference to retired PCD

2020-08-28 Thread Michael D Kinney
Remove all references to the following PCD that has been retired: gEfiMdeModulePkgTokenSpaceGuid.PcdRealTimeClockUpdateTimeout Cc: Kelly Steele Signed-off-by: Michael D Kinney --- Platform/Intel/QuarkPlatformPkg/Quark.dsc| 5 + Platform/Intel/QuarkPlatformPkg/QuarkMin.dsc | 5 + 2

[edk2-devel] [edk2-platforms][Patch 0/3] Fix Quark build issues

2020-08-28 Thread Michael D Kinney
Fix issues that are generating build breaks for Quark: * Missing GUID in INF * References to a retired PCD * Use of TIANOCOMPRESS RuleOverride that appears to be a BaseTools regression. Michael D Kinney (3): QuarkSocPkg/RuntimeQNCAccessLib: Add missing GUID QuarkPlatformPkg: Removed

[edk2-devel] [edk2-platforms][Patch 1/3] QuarkSocPkg/RuntimeQNCAccessLib: Add missing GUID

2020-08-28 Thread Michael D Kinney
Add missing gEfiEventVirtualAddressChangeGuid to the [Guids] section. Cc: Kelly Steele Signed-off-by: Michael D Kinney --- .../Library/QNCAccessLib/RuntimeQNCAccessLib.inf | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

2020-08-28 Thread Paul
[AMD Public Use] Thanks, Liming. I'll proceed with the commit. Thanks, Paul -Original Message- From: gaoliming Sent: Thursday, August 27, 2020 5:58 PM To: devel@edk2.groups.io; Grimes, Paul ; 'Leif Lindholm' ; 'Laszlo Ersek' ; af...@apple.com; 'Michael D Kinney' Cc: 'Michael D

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

2020-08-28 Thread Paul
[AMD Public Use] Thanks for the feedback, Lazlo. I agree with your point on the optimal format for these #defines. I think it would be best to submit the current patch as is given that the same feedback could (should?) be applied to various other #defines in the file, eg:

[edk2-devel] [PATCH 1/1] NetworkPkg: Fix possible infinite loop in HTTP msg body parser

2020-08-28 Thread Vladimir Olovyannikov via groups.io
When an HTTP server sends a non-chunked body data with no Content-Length header, the HttpParserMessageBody in DxeHttpLib gets confused and never sets the Char pointer beyond the body start. This causes "for" loop to never break because the condition of "Char >= Body + BodyLength" is never

Re: [edk2-devel] [PATCH v2 2/6] FmpDevicePkg: Add LastAttemptStatus.h

2020-08-28 Thread Michael Kubacki
Hi Nate, Bumping this mail in case you missed it. Thanks, Michael On 8/24/2020 5:30 PM, Michael Kubacki wrote: Can you provide an example of how you expect the namespace identifier/error code token to be used? Thanks, Michael On 8/24/2020 10:22 AM, Desimone, Nathaniel L wrote: Ah

[edk2-devel] [PATCH v8 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-28 Thread Vladimir Olovyannikov via groups.io
Introduce an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from http/https servers. HTTP download speed is usually faster than tftp. The client is based on the same approach as tftp dynamic command, and uses the same UEFI Shell command line parameters. This makes it

[edk2-devel] [PATCH v8 0/1] ShellPkg/DynamicCommand: add HttpDynamicCommand

2020-08-28 Thread Vladimir Olovyannikov via groups.io
Signed-off-by: Vladimir Olovyannikov Cc: Zhichao Gao Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Ray Ni Cc: Liming Gao Cc: Nd Cc: Laszlo Ersek Cc: Samer El-Haj-Mahmoud This patchset introduces an http client utilizing EDK2 HTTP protocol, to allow fast image downloading from

Re: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-28 Thread Laszlo Ersek
On 08/28/20 08:15, Qi Zhang wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940 > > TpmMeasurementLib includes DxeTpmMeasurementLib and PeiTpmMeasurementLib. > So need to change TpmMeasurementLibNull to BASE library to avoid build > error in some platform. > > Signed-off-by: Qi

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Correcting EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT definition

2020-08-28 Thread Laszlo Ersek
On 08/27/20 22:40, Paul wrote: > In Acpi10.h, EFI_ACPI_DMA_TRANSFER_TYPE_16_BIT is defined as 0x10, > but should be 0x02 per the ACPI Specification. > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2937 > > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Signed-off-by: Paul G

Re: [edk2-devel] Http redirection handling using HttpDxe driver

2020-08-28 Thread Vladimir Olovyannikov via groups.io
> -Original Message- > From: Rabeda, Maciej > Sent: Friday, August 28, 2020 8:27 AM > To: Vladimir Olovyannikov > Cc: devel@edk2.groups.io > Subject: Re: Http redirection handling using HttpDxe driver > > Hi Vladimir, > > I got your message, I will look into it next week. > Have a great

Re: [edk2-devel] [PATCH V2 2/2] BaseTools: Factorize GCC flags

2020-08-28 Thread Laszlo Ersek
On 08/27/20 17:25, Leif Lindholm wrote: > On Thu, Aug 27, 2020 at 16:55:11 +0200, Laszlo Ersek wrote: >> On 08/27/20 10:32, Pierre Gondois wrote: >>> Hello Laszlo, >>> I thought Leif wanted to revert this modification. Should I apply >> your requested changes, or should this patch be reverted? >>

[edk2-devel] [edk2-platforms][PATCH v3 0/3] Revise Readme for RISC-V updates

2020-08-28 Thread Abner Chang
Update below Readme.md, - edk2-platforms/Readme.md - Platform/RISC-V/PlatformPkg/Readme.md - Platform/SiFive/U5SeriesPkg/Readme.md Abner Chang (3): edk2-platforms: Revise Readme.md RISC-V/PlatformPkg: Revise Readme.md Platform/U5SeriesPkg: Revise Readme.md

[edk2-devel] [edk2-platforms][PATCH v3 3/3] Platform/U5SeriesPkg: Revise Readme.md

2020-08-28 Thread Abner Chang
Update RISC-V U5SeriesPkg Readme.md to align with the latest implementation. Signed-off-by: Abner Chang Co-authored-by: Daniel Schaefer Reviewed-by: Daniel Schaefer Cc: Leif Lindholm Cc: Michael D Kinney Cc: Daniel Schaefer --- Platform/SiFive/U5SeriesPkg/Readme.md | 124

[edk2-devel] [edk2-platforms][PATCH v3 2/3] RISC-V/PlatformPkg: Revise Readme.md

2020-08-28 Thread Abner Chang
Update RISC-V PlatformPkg Readme.md to align with the latest implementation. Signed-off-by: Abner Chang Co-authored-by: Daniel Schaefer Reviewed-by: Daniel Schaefer Cc: Leif Lindholm Cc: Michael D Kinney Cc: Daniel Schaefer --- Platform/RISC-V/PlatformPkg/Readme.md | 88

[edk2-devel] [edk2-platforms][PATCH v3 1/3] edk2-platforms: Revise Readme.md

2020-08-28 Thread Abner Chang
Mention to update submodule under for edk2-platforms. It is for RISC-V OpenSBI library. Signed-off-by: Abner Chang Co-authored-by: Daniel Schaefer Reviewed-by: Leif Lindholm Cc: Leif Lindholm Cc: Michael D Kinney --- Readme.md | 1 + 1 file changed, 1 insertion(+) diff --git a/Readme.md

Re: [edk2-devel] Http redirection handling using HttpDxe driver

2020-08-28 Thread Maciej Rabeda
Hi Vladimir, I got your message, I will look into it next week. Have a great weekend! Maciej On 27-Aug-20 21:23, Vladimir Olovyannikov wrote: Hi Maciej, I would like to get your input (and the HttpDxe driver guys) on the issue I see with Http redirection (using HttpDynamicCommand) Basically,

Re: [edk2-devel] [PATCH v2] Platform/Intel/MinPlatformPkg: add Fsp measurement lib to dsc

2020-08-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Qi Zhang > Sent: Friday, August 28, 2020 4:38 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Chiu, Chasel ; > Desimone, Nathaniel L ; Liming Gao > ; Dong, Eric > Subject: [edk2-devel] [PATCH

Re: [edk2-devel] [edk2-platforms][PATCH v2 3/3] Platform/U5SeriesPkg: Revise Readme.md

2020-08-28 Thread Daniel Schaefer
On 8/28/20 11:25 AM, Daniel Schaefer wrote: Looks good now, however like in the other patch you also made the lines longer again. Please wrap them, as Leif suggested. I'm sure your editor can do that for you. Since that won't change the content meaningfully, Reviewed-By: Daniel Schaefer

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/3] RISC-V/PlatformPkg: Revise Readme.md

2020-08-28 Thread Daniel Schaefer
Single small thing below, then Reviewed-By: Daniel Schaefer On 8/27/20 5:43 PM, Abner Chang wrote: Update RISC-V PlatformPkg Readme.md to align with the latest implementation. Signed-off-by: Abner Chang Co-authored-by: Daniel Schaefer Cc: Leif Lindholm Cc: Michael D Kinney Cc: Daniel

Re: [edk2-devel] [edk2-platforms][PATCH v2 3/3] Platform/U5SeriesPkg: Revise Readme.md

2020-08-28 Thread Daniel Schaefer
Looks good now, however like in the other patch you also made the lines longer again. Please wrap them, as Leif suggested. I'm sure your editor can do that for you. On 8/27/20 5:43 PM, Abner Chang wrote: Update RISC-V U5SeriesPkg Readme.md to align with the latest implementation.

[edk2-devel] [PATCH v2] Platform/Intel/MinPlatformPkg: add Fsp measurement lib to dsc

2020-08-28 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2939 Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Qi Zhang --- Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 4 1 file changed, 4 insertions(+) diff --git

[edk2-devel] Hard Feature Freeze starts now for edk2-stable202008

2020-08-28 Thread gaoliming
Hi, all Today, we enter into Hard Feature Freeze phase until edk2-stable202008 tag is created at 2020-09-04. In this phase, there is no feature to be pushed. The critical bug fix is still allowed. So far, I know two patches need to catch this stable tag. Their impact is low. And, they both

Re: [edk2-devel] [PATCH 0/3] add ibrary for Fsp measurement to OpenBoardPkg.

2020-08-28 Thread Qi Zhang
Thanks Liming. I will update patch. > -Original Message- > From: gaoliming > Sent: Friday, August 28, 2020 3:54 PM > To: devel@edk2.groups.io; Zhang, Qi1 > Cc: Chiu, Chasel ; Yao, Jiewen ; > Desimone, Nathaniel L ; Chaganty, Rangasai > V ; Kethi Reddy, Deepika > ; Esakkithevar,

回复: [edk2-devel] [PATCH 0/3] add ibrary for Fsp measurement to OpenBoardPkg.

2020-08-28 Thread gaoliming
This change is for edk2-platform. Now, there is no stable tag for edk2-platforms. For this patch, can new library instances be added into MinPlatformPkg common dsc? If so, you don't need to modify each platform DSC files. These two library instances are added into

Re: [edk2-devel] [PATCH] MdeModulePkg/UsbBusDxe: some USB PenDisk fails enumeration.

2020-08-28 Thread Wu, Hao A
Hello, After looking into the proposed patch, I think it is reasonable to add enhanced error handling for such USB device that will fail the 2nd Device Descriptor request. The flow of the current proposal is: 1. First Port Reset 2. First Device Descriptor Request for bMaxPacketSize0 3. Second

Re: [edk2-devel] [PATCH 1/3] Platform/Intel/CometlakeOpenBoardPkg: add ibrary for Fsp measurement.

2020-08-28 Thread Kathappan Esakkithevar
Reviewed-by: Kathappan Esakkithevar > -Original Message- > From: Chiu, Chasel > Sent: Friday, August 28, 2020 12:07 PM > To: Zhang, Qi1 ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Chaganty, > Rangasai V ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan > > Subject: RE: [PATCH

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

2020-08-28 Thread Yao, Jiewen
Apology that I did not say clearly. I mean you should not modify any code to perform an attack. I am not asking you to exploit the system. Attack here just means: to cause system hang or buffer overflow. That is enough. But you cannot modify code to remove any existing checker. Thank you Yao

Re: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-28 Thread Qi Zhang
Hi, Jian & Hao Could you please review this change as well? Thanks! Qi Zhang > -Original Message- > From: Yao, Jiewen > Sent: Friday, August 28, 2020 2:17 PM > To: Zhang, Qi1 ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > Subject: RE: [PATCH] MdeModulePkg/Library: change

Re: [edk2-devel] [PATCH 2/3] Platform/Intel/KabylakeOpenBoardPkg: add ibrary for Fsp measurement.

2020-08-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 28, 2020 2:33 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Chiu, Chasel ; > Desimone, Nathaniel L ; Jeremy Soller > > Subject: [PATCH 2/3] Platform/Intel/KabylakeOpenBoardPkg: add ibrary for

Re: [edk2-devel] [PATCH 0/3] add ibrary for Fsp measurement to OpenBoardPkg.

2020-08-28 Thread Qi Zhang
Hi, Liming I also request these serial patches to catch stable tag 202008. Thanks! > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 28, 2020 2:33 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Chiu, Chasel ; > Yao, Jiewen ; Desimone, Nathaniel L > ; Chaganty, Rangasai V

Re: [edk2-devel] [PATCH 1/3] Platform/Intel/CometlakeOpenBoardPkg: add ibrary for Fsp measurement.

2020-08-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 28, 2020 2:33 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Chiu, Chasel ; > Desimone, Nathaniel L ; Chaganty, > Rangasai V ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan > > Subject: [PATCH

Re: [edk2-devel] [PATCH 3/3] Platform/Intel/WhiskeylakeOpenBoardPkg: add ibrary for Fsp measurement.

2020-08-28 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 28, 2020 2:33 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Chiu, Chasel ; > Desimone, Nathaniel L > Subject: [PATCH 3/3] Platform/Intel/WhiskeylakeOpenBoardPkg: add ibrary > for Fsp

Re: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-28 Thread Qi Zhang
Yes. This fix is for build error of intel OpenBoardPkg in edk2-platform . > -Original Message- > From: gaoliming > Sent: Friday, August 28, 2020 2:31 PM > To: devel@edk2.groups.io; Yao, Jiewen ; Zhang, Qi1 > > Cc: Wang, Jian J ; Wu, Hao A > Subject: 回复: [edk2-devel] [PATCH]

[edk2-devel] [PATCH 0/3] add ibrary for Fsp measurement to OpenBoardPkg.

2020-08-28 Thread Qi Zhang
These patches also depends on one fix of edk2: https://bugzilla.tianocore.org/show_bug.cgi?id=2939. Cc: Chasel Chiu Cc: Jiewen Yao Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Cc: Jeremy Soller Qi Zhang (3):

[edk2-devel] [PATCH 3/3] Platform/Intel/WhiskeylakeOpenBoardPkg: add ibrary for Fsp measurement.

2020-08-28 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2939 Signed-off-by: Qi Zhang Cc: Chasel Chiu Cc: Nate DeSimone --- .../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 2 ++ .../WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc| 2 ++ 2 files changed, 4

[edk2-devel] [PATCH 1/3] Platform/Intel/CometlakeOpenBoardPkg: add ibrary for Fsp measurement.

2020-08-28 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2939 Signed-off-by: Qi Zhang Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar --- .../Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 2 ++ 1 file changed, 2

[edk2-devel] [PATCH 2/3] Platform/Intel/KabylakeOpenBoardPkg: add ibrary for Fsp measurement.

2020-08-28 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2939 Signed-off-by: Qi Zhang Cc: Chasel Chiu Cc: Nate DeSimone Cc: Jeremy Soller --- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 2 ++ .../Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc| 2 ++ 2 files

回复: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-28 Thread gaoliming
Qi: This is a bug fix. Do you request to catch it into this stable tag 202008? Thanks Liming > -邮件原件- > 发件人: bounce+27952+64729+4905953+8761...@groups.io > 代表 Yao, Jiewen > 发送时间: 2020年8月28日 14:17 > 收件人: Zhang, Qi1 ; devel@edk2.groups.io > 抄送: Wang, Jian J ; Wu, Hao A > > 主题: Re:

Re: [edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-28 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Zhang, Qi1 > Sent: Friday, August 28, 2020 2:15 PM > To: devel@edk2.groups.io > Cc: Zhang, Qi1 ; Wang, Jian J ; > Wu, Hao A ; Yao, Jiewen > Subject: [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to > BASE library. > >

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

2020-08-28 Thread wenyi,xie via groups.io
Hi,Jiewen, I don't really get the meaning "create a case that bypass all checks in PeCoffLib", do you mean I need to create a PE file that can bypass all check in PeCoffLib without modify any code and then cause the problem in DxeImageVerificationLib, or just modify some code in PeCoffLib to

[edk2-devel] [PATCH] MdeModulePkg/Library: change TpmMeasurementLibNull to BASE library.

2020-08-28 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2940 TpmMeasurementLib includes DxeTpmMeasurementLib and PeiTpmMeasurementLib. So need to change TpmMeasurementLibNull to BASE library to avoid build error in some platform. Signed-off-by: Qi Zhang Cc: Jian J Wang Cc: Hao A Wu Cc: Jiewen