Re: [edk2-devel] Tianocore community page on who we are - please review

Some other thought is about maintainer's role definition: The role of a maintainer is to: 1. Maintainer assignments to packages and source file name patterns are provided in the "Maintainers.txt" file. 2. Subscribe to the

Re: [edk2-devel] Tianocore community page on who we are - please review

Thanks Soumya. I think this is a good start. Recently we are discussing the maintainer's work in EDKII mailing list, with title "more development process failure". I feel the process mentioned in https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process is not clear

Re: [EXTERNAL] [edk2-devel] ECC: Won't somebody PLEASE think of the... test structures.

Bret, Details aside this ECC issue got me thinking it might be useful to some how tag code that follows different, subsetted, or alternate rules, or uses different build environments. I was kind of thinking of doing something like how we tag the licenses in the header comments [1]. I would say

[edk2-devel] [PATCH v4 6/6] FmpDevicePkg/FmpDeviceLib: Add Last Attempt Status to Check/Set API

From: Michael Kubacki Provides the ability for a given FMP device library instance to return a Last Attempt Status code during check image and set image operations with FmpDeviceCheckImageEx() and FmpDeviceSetImageEx(). Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu

[edk2-devel] [PATCH v4 3/6] FmpDevicePkg/FmpDxe: Add check image path Last Attempt Status capability

From: Michael Kubacki CheckTheImage() is currently used to provide the CheckImage() implementation for the EFI_FIRMWARE_MANAGEMENT_PROTOCOL instance produced by FmpDxe in addition to being called internally in the SetImage() path. Since CheckTheImage() plays a major role in determining the

[edk2-devel] [PATCH v4 2/6] FmpDevicePkg: Add Last Attempt Status header files

From: Michael Kubacki Introduces a public and a private header file to define more granular usage of the UEFI Specification defined unsuccessful vendor range for Last Attempt Status codes. The unsuccessful vendor range is described in UEFI Specification 2.8A section 23.4. The public header file

[edk2-devel] [PATCH v4 5/6] FmpDevicePkg: Add Last Attempt Status support to dependency libs

From: Michael Kubacki The FMP dependency libraries are leveraged during firmware update to check for dependencies required to update the image. This change adds granular Last Attempt Status code support to these services so failures can be more easily observed during the firmware update process

[edk2-devel] [PATCH v4 4/6] FmpDevicePkg/FmpDxe: Improve set image path Last Attempt Status granularity

From: Michael Kubacki Increases the level of granularity for Last Attempt Status codes returned from SetTheImage() in FmpDxe. This allows better identification of the error that occurred in the set image operation using Last Attempt Status codes. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin

[edk2-devel] [PATCH v4 1/6] MdePkg/SystemResourceTable.h: Add vendor range values

From: Michael Kubacki Adds the following macros to define the unsuccessful vendor range min and max (defined in UEFI Specification 2.8): 1. LAST_ATTEMPT_STATUS_ERROR_UNSUCCESSFUL_VENDOR_RANGE_MIN 2. LAST_ATTEMPT_STATUS_ERROR_UNSUCCESSFUL_VENDOR_RANGE_MAX Cc: Liming Gao Cc: Michael D Kinney

[edk2-devel] [PATCH v4 0/6] Extend Last Attempt Status Usage

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2802 This patch series adds more granularity to Last Attempt Status codes reported during FMP check image and set image operations that greatly improve precision of the status codes. The unsuccessful vendor range (0x1000

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH V3] EdkRepo: Return exit codes in edkrepo_entry_point.py

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Ashley E Desimone Sent: Wednesday, September 9, 2020 2:42 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince ; Bjorge, Erik C Subject:

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 2/2] EdkRepo: Add support for subst drives

get_workspace_path() now converts a virtual drive path to a real path before any git repo operations are done. Cc: Ashley E Desimone Cc: Puja Pandya Cc: Bret Barkelew Cc: Prince Agyeman Cc: Erik Bjorge Signed-off-by: Nate DeSimone --- edkrepo/commands/clone_command.py | 8

[edk2-devel] [edk2-staging/EdkRepo] [PATCH V3 0/2] EdkRepo: Add support for SUBST drives

Changes in V3: - Changed loop for finding subst drive to single if statement Changes in V2: - Changed get_subst_drive_list() to get_subst_drive_dict() EdkRepo currently does not handle virtual drives created using the SUBST command. Specifically, when cloning or syncing a project to a subst

Re: [edk2-devel] more development process failure [was: UefiPayloadPkg: Runtime MMCONF]

Sorry to have a long email thread since my merge and thanks all for the comments. In general, I still feel current process is a little complicated for the maintainers who don't daily work on EDK2 like me. I have less than %5 of time spent on open source EDK2 UefiPayloadPkg since I focus on

[edk2-devel] Tianocore community page on who we are - please review

Dear Community members, I have drafted a document "who we are", explaining Tianocore community structure, members of the community, their role and the current development process. I have drafted this document with the help of the Tianocore Stewards. We view this as a living document, as our

[edk2-devel] [Patch V3 1/2] EmulatorPkg: Add CI build for SECURE_BOOT_ENABLE

https://bugzilla.tianocore.org/show_bug.cgi?id=2979 Add EmulatorPkg CI builds for SECURE_BOOT_ENABLE=TRUE for IA32/X64 and DEBUG/RELEASE/NOOPT. Label these as FULL builds, so if additional build options are added in the future, they can be added to these FULL builds. Cc: Jordan Justen Cc:

[edk2-devel] [Patch V3 0/2] EmulatorPkg: Add CI build for SECURE_BOOT_ENABLE

https://bugzilla.tianocore.org/show_bug.cgi?id=2979 Add EmulatorPkg CI builds for SECURE_BOOT_ENABLE=TRUE for IA32/X64 and DEBUG/RELEASE/NOOPT and update add these to the CI build status in Readme.rst. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Cc: Divneil Rai Wadhawan Cc: Sean Brogan

[edk2-devel] [Patch V3 2/2] Readme.rst: Add EmulatorPkg SECURE_BOOT_ENABLE CI status

https://bugzilla.tianocore.org/show_bug.cgi?id=2979 Add CI status badges for the EmulatorPkg CI builds with SECURE_BOOT_ENABLE=TRUE for IA32/X64 and DEBUG/RELEASE/NOOPT. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Cc: Divneil Rai Wadhawan Cc: Sean Brogan Signed-off-by: Michael D Kinney

Re: [edk2-devel] [Patch V2] EmulatorPkg: Add CI build for SECURE_BOOT_ENABLE

Hi Sean, Appreciate the review since the change was based on your suggestions. I agree. I can split out the Readme.rst changes into its own commit. Mike > -Original Message- > From: Sean Brogan > Sent: Friday, September 25, 2020 1:46 PM > To: devel@edk2.groups.io; Kinney, Michael D

Re: [edk2-devel] [Patch V2] EmulatorPkg: Add CI build for SECURE_BOOT_ENABLE

I give my reviewed by for all changes for what it is worth. One question: Should the EmulatorPkg change be in its own commit just to keep sereration. I know in Mu we split the edk2 repository and it is nice that nearly all commits only touch a single "package". Reviewed-by: Sean Brogan

[edk2-devel] [Patch V2] EmulatorPkg: Add CI build for SECURE_BOOT_ENABLE

https://bugzilla.tianocore.org/show_bug.cgi?id=2979 Add EmulatorPkg CI builds for SECURE_BOOT_ENABLE=TRUE for IA32/X64 and DEBUG/RELEASE/NOOPT. Label these as FULL builds, so if additional build options are added in the future, they can be added to these FULL builds. Cc: Jordan Justen Cc:

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

On 9/25/20 11:09 AM, Brian J. Johnson wrote: On 9/24/20 1:22 AM, Laszlo Ersek wrote: - I don't remember if it's required that the APIC ID space be densely populated. For example, if we have a topology with 7 possible (= maximum) logical CPUs, I'm unsure if a spec forbids any of those CPUs from

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/MpInitLib: Reduce reset vector memory pressure

On 9/24/20 1:22 AM, Laszlo Ersek wrote: - I don't remember if it's required that the APIC ID space be densely populated. For example, if we have a topology with 7 possible (= maximum) logical CPUs, I'm unsure if a spec forbids any of those CPUs from having APIC ID 7. That could cause a problem

Re: [edk2-devel] who can help restore the iBFT spec link to working state?

I see what i can find. Thanks for pointing this out. On 9/25/2020 7:20 AM, Laszlo Ersek wrote: Hi, the iBFT spec link http://www.microsoft.com/whdc/system/platform/firmware/ibft.mspx as shown at https://uefi.org/acpi does not work (it has not worked since at least August 13th,

[edk2-devel] who can help restore the iBFT spec link to working state?

Hi, the iBFT spec link http://www.microsoft.com/whdc/system/platform/firmware/ibft.mspx as shown at https://uefi.org/acpi does not work (it has not worked since at least August 13th, which is when I first reported this issue on the ASWG mailing list). Who from Microsoft can please help

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Remove PEI/DXE instances of CpuTimerLib.

A little surprised by "Average time taken to find CpuCrystalFrequencyHob: about 2000 ns". It depends on the hob is built early or late? Seemingly, NanoSecondDelay() will always have some deviation. Thanks, Star -Original Message- From: devel@edk2.groups.io On Behalf Of Laszlo Ersek

[edk2-devel] [PATCH v2 0/2] Support for dynamic CMN-600 AML generation

The 'Generic ACPI for Arm Components 1.0 Platform Design Document' provides a standard description for an 'Arm CoreLink CMN-600 Coherent Mesh Network'. This patch series adds: - definition for extended interrupt flags. - support for generating SSDT table(s) describing the CMN-600 mesh(es)

[edk2-devel] [PATCH v2 2/2] DynamicTablesPkg: Add SSDT CMN-600 Table generator

From: Pierre Gondois The Generic ACPI for Arm Components 1.0 Platform Design Document, s2.6.4 "ASL code examples" provides information to describe an Arm CoreLink CMN-600 Coherent Mesh Network using an ASL definition block table. The SSDT CMN-600 Table Generator uses the Configuration Manager

[edk2-devel] [PATCH v2 1/2] MdePkg: Definitions for Extended Interrupt Flags

Add Interrupt Vector Flag definitions for Extended Interrupt Descriptor, and macros to test the flags. Ref: ACPI specification 6.4.3.6 Signed-off-by: Sami Mujawar --- Notes: v2 - Updated based on review comments to just define the bit [SAMI] locations. Also dropped the

Re: [edk2-devel] [edk2-platforms 3/4] Silicon/NXP: Implement USB Errata

On Tue, Sep 15, 2020 at 21:59:02 +0530, Meenakshi Aggarwal wrote: > Implement USB errata A009008, A009798, A008997, A009007 > Make USB,SEC and SATA snoopable Somewhat nitpicking, but for both subject and message - can you say "errata workarounds" rather than "errata"? Ideally, I would like to

Re: [edk2-devel] [edk2-platforms 4/4] LS1046aFrwy: Enable USB support for LS1046AFRWY board.

On Tue, Sep 15, 2020 at 21:59:03 +0530, Meenakshi Aggarwal wrote: > Signed-off-by: Meenakshi Aggarwal Reviewed-by: Leif Lindholm > --- > Silicon/NXP/LS1046A/LS1046A.dsc.inc| 3 +++ > Platform/NXP/LS1046aFrwyPkg/LS1046aFrwyPkg.dsc | 2 ++ >

Re: [edk2-devel] [edk2-platforms 2/4] Platform/NXP/LS1046aFrwyPkg: GPIO mux changes for USB

Same comment as for previous patch: Commit messages are not optional. On Tue, Sep 15, 2020 at 21:59:01 +0530, Meenakshi Aggarwal wrote: > Signed-off-by: Pramod Kumar > Signed-off-by: Meenakshi Aggarwal And only the poster can sign off. Please address for all patches in series. > --- >

[edk2-devel] *yet more* development process failure

Hi, so check out this pull request: https://github.com/tianocore/edk2/pull/960 - empty PR description - useless PR title ("pr925") - merges patches for *five* different BZs (2882, 2965, 2880, 2978, 2881) in one go - all of those BZs are still in CONFIRMED state - none of those BZs reference

Re: [edk2-devel] [edk2-platforms 1/4] Silicon/NXP: Add GPIO driver support.

Needs an actual commit message. What GPIO controller? If it does not have an explicit name, what family of devices is it in? On Tue, Sep 15, 2020 at 21:59:00 +0530, Meenakshi Aggarwal wrote: > Signed-off-by: Pramod Kumar > Signed-off-by: Meenakshi Aggarwal Only the poster can sign off that the

[edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Remove PEI/DXE instances of CpuTimerLib.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2832 1. Remove PEI instance(PeiCpuTimerLib). PeiCpuTimerLib is currently designed to save time by getting CPU TSC frequncy from Hob. BaseCpuTimerLib is designed to calculate TSC frequency by using CPUID[15h] each time. The time it takes to

Re: [edk2-devel][PATCH] EmulatorPkg/Unix Prevents the compiler form optimizing unused variable

Jordan, Andrew, I will defer to you to review the patch. Thanks, Ray > -Original Message- > From: LiuYu > Sent: Friday, September 25, 2020 1:49 PM > To: Justen, Jordan L ; af...@apple.com; Ni, Ray > > Cc: devel@edk2.groups.io; LiuYu > Subject: [edk2-devel][PATCH] EmulatorPkg/Unix

回复: [edk2-devel] [PATCH v2 0/2] UEFI memmap workaround for hiding page-access caps from OSes hides SP and CRYPTO caps too

Malgorzata: How do know OS (Windows or Linux) behavior for SP and CRYPTO attribute? Is there the public document to describe this behavior? Thanks Liming > -邮件原件- > 发件人: bounce+27952+65566+4905953+8761...@groups.io > 代表 Malgorzata > Kukiello > 发送时间: 2020年9月24日 18:22 > 收件人:

Re: [edk2-devel] [edk2-test] Contributions.txt still mentions the TianoCore Contribution Agreement

On 09/24/20 23:42, Rebecca Cran wrote: > While working on the SctPkg, I noticed the Contributions.txt file in the > top of the repo still mentions the TianoCore Contribution Agreement. > Does it need updated? > > (CC'ing the other stewards) Most likely so. It's probably best to "replay" (or

Re: [edk2-devel] What is a special documentation block?

On 09/25/20 03:16, Bret Barkelew via groups.io wrote: > Expect a few of these questions as I update 2000+ lines of test code that was > written prior to EccCheck. > > “The function headers should follow Doxygen special documentation blocks in > section 2.3.5†> Doxygen doesn’t have a

Re: [edk2-devel] ECC: main function entry point in host-based unit tests

On 09/25/20 04:38, Bret Barkelew via groups.io wrote: > ERROR - EFI coding style error > ERROR - *Error code: 7001 > ERROR - *There should be no use of int, unsigned, char, void, long in any .c, > .h or .asl files > ERROR - *file: >

Re: [edk2-devel] [PATCH v1 1/2] MdePkg: Definitions for Extended Interrupt Flags

Hi Mike, I will send an updated patch with the suggested changes. I will also drop the IS_xxx macros. Regards, Sami Mujawar -Original Message- From: Kinney, Michael D Sent: 24 September 2020 11:07 PM To: Sami Mujawar ; devel@edk2.groups.io; Kinney, Michael D Cc:

[edk2-devel] [PATCH v2 1/1] BaseTools: Copy PACKED definition from MdePkg Base.h

From: gaoliming BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2938 MdePkg Acpi10.h definition depends on PACKED. When structure PCD refers to Acpi10.h, build will fail, because PACKED definition is missing in BaseTools BaseTypes.h. C source tools include BaseTools BaseTypes.h. They don't

[edk2-devel] [PATCH] BaseTools Build_Rule: Add the missing ASM16_FLAGS for ASM16 source file

Signed-off-by: Liming Gao Cc: Bob Feng Cc: Yuwei Chen --- BaseTools/Conf/build_rule.template | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template index c034869915..1395792cd6 100755 ---

Re: [edk2-devel] ECC: Won't somebody PLEASE think of the... test structures.

On 09/25/20 04:25, Bret Barkelew via groups.io wrote: > So for context, this is a new host-based test that should only run > within a platform OS, so intrinsics aren't the big deal that they > would be in FW code. > > But we do need to figure out how to simultaneously adhere to the > coding

回复: [edk2-devel] ECC: main function entry point in host-based unit tests

Bret: ECC mainly checks the firmware source coding style. Host based unit test code may follow the different rule. I suggest to ignore ECC check result for them. The ignored file or directory can be added into the Package level ci.yaml file. Thanks Liming 发件人:

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Remove PEI/DXE instances of CpuTimerLib.

On 09/25/20 07:25, Ni, Ray wrote: > Reviewed-by: Ray Ni Acked-by: Laszlo Ersek Thanks Laszlo > >> -Original Message- >> From: Lou, Yun >> Sent: Friday, September 25, 2020 11:58 AM >> To: devel@edk2.groups.io >> Cc: Lou, Yun ; Ni, Ray ; Dong, Eric >> ; Laszlo Ersek >> ; Kumar,