That makes sense to move out MinPlatformPkg to under the vendor neutral folder
if it is not Intel specific. On RISC-V, we have Platforms/RISC-V/PlatformPkg
and the vendor neutral folder of RISC-V platform (e.g. Platforms/SiFive) which
could leverage the driver/lib provided by RISC-V
Ah, thanks. I made a wrong assumption about how it works. So I can get
it to fail faster by running "stuart_ci_build -c .pytool/CISettings.py
TOOL_CHAIN_TAG=GCC5 -t NO-TARGET" - i.e. running NO-TARGET without also
running DEBUG,RELEASE,NOOPT too.
It turns out that because of the repo I'm
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2967
When no change in FSP UPD DSC files, GenCfgOpt.py should skip
recreating UPD header and BSF files.
This patch added a check to handle this case.
Cc: Maurice Ma
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
Not sure i follow your first question but running without a "-t"
specified at the command line and "-t NO-TARGET" is two different
things. For edk2 ci you can see the CISettings.py file defines targets
supported as a tuple of all 4 ("DEBUG", "RELEASE", "NO-TARGET", "NOOPT").
Hi Erik,
A separate manifest repository would probably be a good idea. The manifest repo
is used for a lot of EdkRepo's operations so having a smaller repo dedicated
repo could be beneficial from a performance standpoint.
Thanks,
Nate
-Original Message-
From: Bjorge, Erik C
Sent:
Hi Everyone,
This has come up informally a couple of times already, but I do think that it
would be beneficial to move MinPlatformPkg out of the Platform/Intel folder and
into a vendor neutral folder. MinPlatform really isn't Intel specific, it's
just "middleware" that is intended to make it
I am fine with a new repo. This also supports a good workflow to get a tool
that then lets you pull full platforms. In theory you would only ever really
need to clone a single repo manually (assuming reasonable manifest support).
Are you also looking at creating a separate manifest repo as
Is it expected that the EDK2 CI run without errors in NO-TARGET mode -
that is, when "-t" isn't specified?
When I run it locally with "stuart_ci_build -c .pytool/CISettings.py
TOOL_CHAIN_TAG=GCC5 -a X64,AARCH64" I get lots of errors: one in
ArmVirtPkg/PrePi/PrePi.c about a missing comment
Hi Everyone,
Given that EdkRepo has existed in the project for over a year now (in
edk2-staging) I think it is time to get out of staging. I have considered
multiple possible landing zones:
1. edk2
2. edk2-pytool-library
3. A new repository
Edk2 does not seem like a good location as EdkRepo
Reviewed-by: Abner Chang
> -Original Message-
> From: Schaefer, Daniel
> Sent: Wednesday, September 30, 2020 4:50 PM
> To: devel@edk2.groups.io
> Cc: Schaefer, Daniel ; Chang, Abner (HPS
> SW/FW Technologist) ; Leif Lindholm
>
> Subject: [PATCH 1/1] Silicon/SiFive: Handle case of NULL
Agreed.
Reviever or Maintainer can approve a patch. Any Maintainer can push a
patch that has been approved. This can happen either:
- when the designated Maintainer for that patch is
unavailable/unresponsive
- if the patch submitter is also a Maintainer of some other part of
the repo.
No one
Hi Vladimir,
Yes, this must have go past my radar, sorry. Things are becoming more
and more busy out here :/
I will take a look at it by the end of week.
On 24-Sep-20 23:57, Vladimir Olovyannikov via groups.io wrote:
Hi Maciej,
Can you please review this patch?
It is sitting there for a
1. Highlight incompatible change
2. Define Release Maintainer Role
Signed-off-by: Liming Gao
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Guptha Soumya K
---
Who-we-are.md | 28 +---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCELLED
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:Asia/Shanghai
TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai
X-LIC-LOCATION:Asia/Shanghai
BEGIN:STANDARD
TZOFFSETFROM:+0800
TZOFFSETTO:+0800
TZNAME:CST
Jiewen:
Frankly speaking, I don't know this rule that the patch needs to get review
or ack from the maintainer. When the reviewer name is formally added into
maintainers.txt, I think the maintainer has delegated the approval work to
reviewers. So, I think that the reviewer takes the same role
Abort creating the SMBIOS HOBs if there's no firmware context to get the
information from.
Turn SbiLib functions for getting mscratch into VOID since they can never
practically fail.
Signed-off-by: Daniel Schaefer
Cc: Abner Chang
Cc: Leif Lindholm
---
.../Include/Library/RiscVEdk2SbiLib.h
This is a replacement patch of Abner's with title
ProcessorPkg/RiscVEdk2SbiLib: Error handling for locating firmware context
I realized that the error handling wasn't bad but unnecessary. Those
funtions can never return an error, since the SBI call they use also
doesn't.
Tested by booting to
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCELLED
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles
X-LIC-LOCATION:America/Los_Angeles
BEGIN:DAYLIGHT
TZOFFSETFROM:-0800
TZOFFSETTO:-0700
18 matches
Mail list logo
