Re: [edk2-devel] 回复: [Wiki] Add update notes for incomaptible patches that fix typos in SmBios.h

2021-01-31 Thread Zhiguang Liu
Hi Liming, The edk2 commits that fixes the typo has been included using the hyper link. The platforms side's modification doesn't have example to show here. Do you think it is necessary to list all the typo these commits fixed, like below? FirwareVersion -> FirmwareVersion

[edk2-devel] [PATCH v1 1/1] UefiCpuPkg/CpuCacheInfoLib: Add more dependency of CpuCacheInfoLib

2021-01-31 Thread Jason Lou
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3190 Add more dependency to enforce the executability of CpuCacheInfoLib. Signed-off-by: Jason Lou Cc: Ray Ni Cc: Eric Dong Cc: Laszlo Ersek Cc: Rahul Kumar --- UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c | 7 +--

Re: [edk2-devel] [PATCH v6 5/9] OvmfPkg/CpuHotplugSmm: define CPU_HOT_EJECT_DATA

2021-01-31 Thread Laszlo Ersek
On 01/29/21 01:59, Ankur Arora wrote: > Define CPU_HOT_EJECT_DATA and add PCD PcdCpuHotEjectDataAddress, which > will be used to share CPU ejection state between OvmfPkg/CpuHotPlugSmm > and PiSmmCpuDxeSmm. > > Cc: Laszlo Ersek > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Igor Mammedov > Cc:

Re: [edk2-devel] [PATCH v2 RESEND] MdeModulePkg/Library: Add HiiGetStringEx to UefiHiiLib for EDK2 Redfish

2021-01-31 Thread Abner Chang
Thanks for catching this. V3 sent. Abner > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > gaoliming > Sent: Monday, February 1, 2021 10:12 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: 'Dandan Bi' ; 'Eric Dong'

[edk2-devel] [PATCH v3] MdeModulePkg/Library: Add HiiGetStringEx to UefiHiiLib for EDK2 Redfish

2021-01-31 Thread Abner Chang
Add HiiGetStringEx and leveraged by HiiGetString function to support getting string with the best language in optionally. This avoids the string in x-uefi language is misled to the language defined by "PlatformLang" or the "Supported Languages". This change is introduced to support x-uefi keyword

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident

2021-01-31 Thread Abner Chang
Yes, CI is enabled on RedfishPkg. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > gaoliming > Sent: Monday, February 1, 2021 9:54 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: 'Leif Lindholm' ; Wang, Nickle

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Add JsonLoadString function

2021-01-31 Thread Abner Chang
It loads a JSON payload in the format of NULL terminated string to a JSON object. This function is used by either edk2 Redfish client applications or other edk2 modules which manipulate JSON properties. Regards, Abner > -Original Message- > From: gaoliming

Re: [edk2-devel] [PATCH v6 4/9] OvmfPkg/CpuHotplugSmm: introduce UnplugCpus()

2021-01-31 Thread Laszlo Ersek
On 01/29/21 01:59, Ankur Arora wrote: > Introduce UnplugCpus() which maps each APIC ID being unplugged > onto the hardware ID of the processor and informs PiSmmCpuDxeSmm > of removal by calling EFI_SMM_CPU_SERVICE_PROTOCOL.RemoveProcessor(). > > With this change we handle the first phase of unplug

Re: [edk2-devel] [PATCH v6 1/9] OvmfPkg/CpuHotplugSmm: refactor hotplug logic

2021-01-31 Thread Laszlo Ersek
On 01/29/21 01:59, Ankur Arora wrote: > Refactor CpuHotplugMmi() to pull out the CPU hotplug logic into > ProcessHotAddedCpus(). This is in preparation for supporting CPU > hot-unplug. > > Cc: Laszlo Ersek > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Igor Mammedov > Cc: Boris Ostrovsky >

回复: [edk2-devel] [PATCH v2 RESEND] MdeModulePkg/Library: Add HiiGetStringEx to UefiHiiLib for EDK2 Redfish

2021-01-31 Thread gaoliming
Abner: I have two comments for this patch. 1. Please specify new ASSERT in the function header. 2. Please update the function description for the new behavior when TryBestLanguage is FALSE. HiiGetStringEx() function description should be different from HiiGetString(). Thanks Liming >

回复: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Ignore the build error of assignment within conditional expression

2021-01-31 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: bounce+27952+70884+4905953+8761...@groups.io > 代表 Abner Chang > 发送时间: 2021年1月29日 12:20 > 收件人: devel@edk2.groups.io > 抄送: Leif Lindholm ; Nickle Wang > ; Michael D Kinney > 主题: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Ignore the build error of >

回复: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Add JsonLoadString function

2021-01-31 Thread gaoliming
Abner: What's the usage for this new API? Thanks Liming > -邮件原件- > 发件人: bounce+27952+70886+4905953+8761...@groups.io > 代表 Abner Chang > 发送时间: 2021年1月29日 12:20 > 收件人: devel@edk2.groups.io > 抄送: Leif Lindholm ; Nickle Wang > ; Michael D Kinney > 主题: [edk2-devel] [PATCH]

回复: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident

2021-01-31 Thread gaoliming
Reviewed-by: Liming Gao Besides, does CI enable in RedfishPkg? Thanks Liming > -邮件原件- > 发件人: bounce+27952+70885+4905953+8761...@groups.io > 代表 Abner Chang > 发送时间: 2021年1月29日 12:20 > 收件人: devel@edk2.groups.io > 抄送: Leif Lindholm ; Nickle Wang > ; Michael D Kinney > 主题: [edk2-devel]

[edk2-devel] [Patch 1/1] BaseTools: fix the split output files root dir

2021-01-31 Thread Bob Feng
If the output file path is a relative path, the split tool will create the output file under the input file path. But the expected behavior for this case is the output file should be relative to the current directory. This patch will fix this bug. Signed-off-by: Bob Feng Cc: Liming Gao Cc:

Re: [edk2-devel] [PATCH v4 1/1] ShellPkg/AcpiView: HMAT Parser

2021-01-31 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Vijayenthiran > Subramaniam > Sent: Thursday, January 28, 2021 10:04 PM > To: devel@edk2.groups.io; Sami Mujawar > Cc: Ni, Ray ; Gao, Zhichao ; > matteo.carl...@arm.com;

[edk2-devel] [PATCH 40/40] Maintainers.txt: Add TigerlakeSiliconPkg maintainers

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Maintainers.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 56e16fc48c..34f0b58581 100644 --- a/Maintainers.txt +++

[edk2-devel] [PATCH 39/40] TigerlakeSiliconPkg: Add package DSC files

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/SiPkgBuildOption.dsc| 122

[edk2-devel] [PATCH 38/40] TigerlakeSiliconPkg/Fru: Add Fru DSC files

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following DSC files: * Fru/TglCpu * Fru/TglPch Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Fru/TglCpu/CommonLib.dsc | 11 +++

[edk2-devel] [PATCH 37/40] TigerlakeSiliconPkg/SystemAgent: Add SystemAgent modules

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * SystemAgent/SaInit/Dxe * SystemAgent/SaInit/Smm Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/SystemAgent/SaInit/Dxe/SaAcpi.c | 431

[edk2-devel] [PATCH 35/40] TigerlakeSiliconPkg/Fru/TglCpu: Add CpuPcieRp and Vtd library instances

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * Fru/TglCpu/CpuPcieRp/Library/PeiDxeSmmCpuPcieInfoFruLib * Fru/TglCpu/Vtd/LibraryPrivate/DxeVtdInitLib Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 34/40] TigerlakeSiliconPkg/SystemAgent: Add Acpi Tables and library instances

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * SystemAgent/AcpiTables * SystemAgent/Library/DxeSaPolicyLib * SystemAgent/Library/PeiDxeSmmSaPlatformLib Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 33/40] TigerlakeSiliconPkg/Pch: Add Pch private library instances

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * Pch/LibraryPrivate/BaseSiScheduleResetLib * Pch/LibraryPrivate/SmmPchPrivateLib Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 32/40] TigerlakeSiliconPkg/Pch: Add Pch common library instances

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * Pch/Library/BasePchPciBdfLib * Pch/Library/BaseResetSystemLib * Pch/Library/DxePchPolicyLib * Pch/Library/PeiDxeSmmPchCycleDecodingLib * Pch/Library/PeiDxeSmmPchInfoLib Cc: Sai Chaganty Cc: Nate

[edk2-devel] [PATCH 31/40] TigerlakeSiliconPkg/Library: Add package common library instances

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * Library/BasePciSegmentMultiSegLibPci * Library/BaseSiConfigBlockLib * Library/PeiDxeSmmMmPciLib Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 30/40] TigerlakeSiliconPkg/IpBlock: Add Vtd component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Vtd/IncludePrivate * IpBlock/Vtd/Library * IpBlock/Vtd/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 29/40] TigerlakeSiliconPkg/IpBlock: Add Spi component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Spi/IncludePrivate * IpBlock/Spi/Library * IpBlock/Spi/LibraryPrivate * IpBlock/Spi/Smm Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 28/40] TigerlakeSiliconPkg/IpBlock: Add Smbus component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Smbus/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Smbus/IncludePrivate/Register/SmbusRegs.h | 50

[edk2-devel] [PATCH 27/40] TigerlakeSiliconPkg/IpBlock: Add SerialIo component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/SerialIo/IncludePrivate * IpBlock/SerialIo/Library * IpBlock/SerialIo/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 23/40] TigerlakeSiliconPkg/IpBlock: Add PcieRp component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/PcieRp/IncludePrivate * IpBlock/PcieRp/Library * IpBlock/PcieRp/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 26/40] TigerlakeSiliconPkg/IpBlock: Add Sata component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Sata/Library Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Sata/Library/PeiDxeSmmSataLib/PeiDxeSmmSataLibVer2.inf | 32

[edk2-devel] [PATCH 25/40] TigerlakeSiliconPkg/IpBlock: Add Psf component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Psf/IncludePrivate * IpBlock/Psf/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Psf/IncludePrivate/Library/PsfLib.h

[edk2-devel] [PATCH 24/40] TigerlakeSiliconPkg/IpBlock: Add Pmc component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Pmc/IncludePrivate * IpBlock/Pmc/Library * IpBlock/Pmc/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 22/40] TigerlakeSiliconPkg/IpBlock: Add PchDmi component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/PchDmi/IncludePrivate * IpBlock/PchDmi/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 20/40] TigerlakeSiliconPkg/IpBlock: Add HostBridge component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/HostBridge/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/HostBridge/IncludePrivate/HostBridgeDataHob.h | 25

[edk2-devel] [PATCH 21/40] TigerlakeSiliconPkg/IpBlock: Add P2sb component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/P2sb/IncludePrivate * IpBlock/P2sb/Library * IpBlock/P2sb/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 19/40] TigerlakeSiliconPkg/IpBlock: Add Hda component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Hda/IncludePrivate * IpBlock/Hda/Library * IpBlock/Hda/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 16/40] TigerlakeSiliconPkg/IpBlock: Add Gbe component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Gbe/IncludePrivate * IpBlock/Gbe/Library * IpBlock/Gbe/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 15/40] TigerlakeSiliconPkg/IpBlock: Add Espi component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Espi/Library Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Espi/Library/PeiDxeSmmEspiLib/EspiLib.c | 469

[edk2-devel] [PATCH 14/40] TigerlakeSiliconPkg/IpBlock: Add CpuPcieRp component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/CpuPcieRp/Include * IpBlock/CpuPcieRp/IncludePrivate * IpBlock/CpuPcieRp/Library * IpBlock/CpuPcieRp/LibraryPrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo ---

[edk2-devel] [PATCH 13/40] TigerlakeSiliconPkg/IpBlock: Add Cnvi component

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following files: * IpBlock/Cnvi/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Cnvi/IncludePrivate/CnviConfigHob.h | 27 +++ 1

[edk2-devel] [PATCH 12/40] TigerlakeSiliconPkg/Fru: Add TglPch/IncludePrivate headers

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Fru/TglPch/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Fru/TglPch/IncludePrivate/Register/PchPcrRegs.h | 66

[edk2-devel] [PATCH 11/40] TigerlakeSiliconPkg/Fru: Add TglPch/Include headers

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Fru/TglPch/Include Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Fru/TglPch/Include/PchBdfAssignment.h | 326

[edk2-devel] [PATCH 10/40] TigerlakeSiliconPkg/Fru: Add TglCpu/IncludePrivate headers

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Fru/TglCpu/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Fru/TglCpu/IncludePrivate/Library/VtdInitFruLib.h | 18 ++

[edk2-devel] [PATCH 09/40] TigerlakeSiliconPkg/Fru: Add TglCpu/Include headers

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Fru/TglCpu/Include Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Fru/TglCpu/Include/Library/CpuPcieInfoFruLib.h | 57

[edk2-devel] [PATCH 08/40] TigerlakeSiliconPkg/SystemAgent: Add IncludePrivate headers

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * SystemAgent/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/SystemAgent/IncludePrivate/Protocol/SaIotrapSmi.h | 42

[edk2-devel] [PATCH 06/40] TigerlakeSiliconPkg/Pch: Add IncludePrivate headers

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Pch/IncludePrivate Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Pch/IncludePrivate/Library/SiScheduleResetLib.h | 47

[edk2-devel] [PATCH 05/40] TigerlakeSiliconPkg/Pch: Add include headers

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Pch/Include Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Pch/Include/ConfigBlock/FlashProtectionConfig.h | 55

[edk2-devel] [PATCH 04/40] TigerlakeSiliconPkg/Cpu: Add Include headers

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds header files common to CPU modules. Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Cpu/Include/ConfigBlock/CpuConfig.h | 83

[edk2-devel] [PATCH 07/40] TigerlakeSiliconPkg/SystemAgent: Add include headers

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * SystemAgent/Include Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/SystemAgent/Include/ConfigBlock/MemoryDxeConfig.h | 123

[edk2-devel] [PATCH 03/40] TigerlakeSiliconPkg/Include: Add Pins, Register and other include headers

2021-01-31 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3171 Adds the following header files: * Include/Pins * Include/Register * Include/*.h Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Silicon/Intel/TigerlakeSiliconPkg/Include/ConfigBlock.h| 53

回复: [edk2-devel] [PATCH v4 00/20] Extends Support of MM_STANDALONE Type Modules to X64

2021-01-31 Thread gaoliming
Kun: I will merge this patch serial. Can you update the latest version patches with reviewed-by tag into your fork https://github.com/kuqin12? I will refer to it and create pull request. Thanks Liming 发件人: Kun Qin 发送时间: 2021年1月29日 15:56 收件人: devel@edk2.groups.io 抄送: Bob Feng ; Yuwei

回复: [edk2-devel] [PATCH v1 1/1] MdePkg/SmiHandlerProfileLibNull: Add MM_STANDALONE support

2021-01-31 Thread gaoliming
Create PR https://github.com/tianocore/edk2/pull/1394 to merge this patch. Liming > -邮件原件- > 发件人: bounce+27952+70708+4905953+8761...@groups.io > 代表 gaoliming > 发送时间: 2021年1月25日 9:18 > 收件人: devel@edk2.groups.io; mikub...@linux.microsoft.com > 抄送: 'Eric Dong' ; 'Hao A Wu' ; > 'Jian J

Re: [edk2-devel] [PATCH] * ShellPkg: add the support to show Contained Element Count, Contained Element Record Length and Contained Elements

2021-01-31 Thread Gao, Zhichao
Hi Mars, I cannot extract the patch. I don’t what cause this issue. Can you share your branch? Back to the patch. Please remove the ‘*’ in the titile. Don’t define the Index2 in a block scope, it should be defined at the begin of the function. Refer to CCS spec 2.2.1 Section 5.4.1.1: Block

[edk2-devel] [PATCH v7 21/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe

2021-01-31 Thread Rebecca Cran
SmbiosMiscDxe provides SMBIOS tables 0, 1, 2, 3, 13, and 32. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/ArmPkg.dsc | 1 + ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf|

[edk2-devel] [PATCH v7 19/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type32

2021-01-31 Thread Rebecca Cran
This code provides information for the SMBIOS Type 32 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type32/MiscBootInformationData.c | 32 +

[edk2-devel] [PATCH v7 20/21] ArmPkg: Add SMBIOS PCDs to ArmPkg.dec

2021-01-31 Thread Rebecca Cran
Platforms are expected to override these PCDs to provide relevant information to SMBIOS. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm --- ArmPkg/ArmPkg.dec | 17 + 1 file changed, 17 insertions(+) diff --git a/ArmPkg/ArmPkg.dec b/ArmPkg/ArmPkg.dec index

[edk2-devel] [PATCH v7 18/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type13

2021-01-31 Thread Rebecca Cran
This code provides information for the SMBIOS Type 13 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type13/MiscNumberOfInstallableLanguagesData.c | 33

[edk2-devel] [PATCH v7 17/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type03

2021-01-31 Thread Rebecca Cran
This code provides information for the SMBIOS Type 3 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 52 +

[edk2-devel] [PATCH v7 16/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type02

2021-01-31 Thread Rebecca Cran
This code provides information for the SMBIOS Type 2 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerData.c | 46

[edk2-devel] [PATCH v7 15/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type01

2021-01-31 Thread Rebecca Cran
This code provides information for the SMBIOS Type 1 table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufacturerData.c | 36

[edk2-devel] [PATCH v7 14/21] ArmPkg: Add Universal/Smbios/SmbiosMiscDxe/Type00

2021-01-31 Thread Rebecca Cran
This code provides information for the SMBIOS Type 0 table. Signed-off-by: Rebecca Cran Reviewed-by: Samer El-Haj-Mahmoud Reviewed-by: Leif Lindholm --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorData.c | 93 ++

[edk2-devel] [PATCH v7 13/21] ArmPkg: Add Universal/Smbios/ProcessorSubClassDxe

2021-01-31 Thread Rebecca Cran
ProcessorSubClassDxe provides SMBIOS CPU information using generic methods combined with calls into OemMiscLib. Signed-off-by: Rebecca Cran Reviewed-by: Samer El-Haj-Mahmoud --- ArmPkg/ArmPkg.dsc | 2 +

[edk2-devel] [PATCH v7 12/21] ArmPkg: Add Universal/Smbios/OemMiscLibNull

2021-01-31 Thread Rebecca Cran
Add a Null implementation of OemMiscLib. OemMiscLib provides functions that platforms implement to fill in SMBIOS information for the SmbiosMiscDxe and ProcessSubClassDxe drivers. Signed-off-by: Rebecca Cran Acked-by: Leif Lindholm --- ArmPkg/ArmPkg.dsc

[edk2-devel] [PATCH v7 11/21] ArmPkg: Add Library/OemMiscLib.h

2021-01-31 Thread Rebecca Cran
OemMiscLib.h provides the interface which platforms should implement to interact with the SmbiosMiscDxe and ProcessorSubClassDxe drivers to update SMBIOS tables. Signed-off-by: Rebecca Cran Acked-by: Leif Lindholm --- ArmPkg/Include/Library/OemMiscLib.h | 166 1 file

[edk2-devel] [PATCH v7 10/21] ArmPkg: Add helper to read the CCSIDR2 register

2021-01-31 Thread Rebecca Cran
Add helper function to read the CCSIDR2 register. This is used when CCIDX is supported in AARCH32 mode. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm --- ArmPkg/Library/ArmLib/ArmLibPrivate.h | 11 +++ ArmPkg/Library/ArmLib/Arm/ArmLibSupportV7.S | 10 ++

[edk2-devel] [PATCH v7 09/21] ArmPkg: Add helper to read CCIDX status

2021-01-31 Thread Rebecca Cran
Add a helper function to determine CCIDX support. Signed-off-by: Rebecca Cran Reviewed-by: Sami Mujawar Reviewed-by: Leif Lindholm --- ArmPkg/Include/Library/ArmLib.h| 11 +++ ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 19 ++-

[edk2-devel] [PATCH v7 08/21] ArmPkg: Add definition of the maximum cache level in ARMv8-A

2021-01-31 Thread Rebecca Cran
The ARM Architecture Reference Manual for ARMv8-A defines up to seven levels of cache, L1 through L7. Define MAX_ARM_CACHE_LEVEL to be 7. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Include/Library/ArmLib.h | 4 1 file changed, 4

[edk2-devel] [PATCH v7 06/21] ArmPkg: Fix the return type of the ReadCCSIDR function

2021-01-31 Thread Rebecca Cran
When CCIDX is supported, the Current Cache Size ID Register contains data above 32 bits: namely the number of sets. Avoid truncating this by returning a UINTN instead of UINT32. On AARCH32, the expanded number of sets data can be read via the CCSIDR2 register. Also, add Doxygen comments for the

[edk2-devel] [PATCH v7 07/21] ArmPkg: Update ArmLibPrivate.h with cache register definitions

2021-01-31 Thread Rebecca Cran
Update the cache definitions in ArmLibPrivate.h based on current ARMv8 documentation. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Library/ArmLib/ArmLibPrivate.h | 97 1 file changed, 97 insertions(+) diff --git

[edk2-devel] [PATCH v7 05/21] ArmPkg: Add helper function to read the Memory Model Feature Register 4

2021-01-31 Thread Rebecca Cran
In AARCH32, CCIDX support is indicated in the MMFR4 register - unlike under AARCH64 where it's in MMFR2. Add a helper function to read it. Signed-off-by: Rebecca Cran Reviewed-by: Sami Mujawar Reviewed-by: Leif Lindholm --- ArmPkg/Library/ArmLib/Arm/ArmV7Lib.h | 8 ++--

[edk2-devel] [PATCH v7 04/21] ArmPkg: Add helper to read the Memory Model Features Register 2

2021-01-31 Thread Rebecca Cran
Add helper function to read the MMFR2 register. We will need this to determine CCIDX support. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Library/ArmLib/AArch64/AArch64Lib.h | 11 +++ ArmPkg/Library/ArmLib/AArch64/AArch64Support.S |

[edk2-devel] [PATCH v7 01/21] ArmPkg: Add ARM SMC Architecture functions to ArmStdSmc.h

2021-01-31 Thread Rebecca Cran
The ARM SMC Architecture functions were missing from ArmStdSmc.h. Add them, based on the SMC Calling Convention version 1.2 specification. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Include/IndustryStandard/ArmStdSmc.h | 16 1

[edk2-devel] [PATCH v7 03/21] ArmPkg: Add register encoding definition for MMFR2

2021-01-31 Thread Rebecca Cran
Add register encoding definition for Memory Model Feature Register 2. We need to define it here because we build for ARMv8.0, which doesn't have it. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Reviewed-by: Sami Mujawar --- ArmPkg/Include/Chipset/AArch64.h | 4 1 file changed,

[edk2-devel] [PATCH v7 02/21] MdePkg: Update IndustryStandard/SmBios.h with processor status data

2021-01-31 Thread Rebecca Cran
Add a bitfield that describes the structure of the byte in the Status field of the SMBIOS Type 4 Processor Information table. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm Acked-by: Sami Mujawar --- MdePkg/Include/IndustryStandard/SmBios.h | 13 + 1 file changed, 13

[edk2-devel] [PATCH v7 00/21] ArmPkg,MdePkg: Add Universal/Smbios, and related changes

2021-01-31 Thread Rebecca Cran
Much of the data for the SMBIOS tables is generic, and need not be duplicated for each platform. This patch series introduces ArmPkg/Universal/Smbios, which is largely copied from edk2-platforms/Silicon/HiSilicon/Drivers/Smbios and generates SMBIOS tables 0,1,2,3,4,7,13,32 and uses a combination