答复: [edk2-devel] Question about Smm code / StandaloneMmPkg

2021-03-07 Thread Tiger Liu(BJ-RD)
Hi, Laszlo && Kun: Got it. Thanks a lot. Best wishes, 发件人: Kun Qin 发送时间: 2021年3月5日 10:23 收件人: Laszlo Ersek ; devel@edk2.groups.io; Tiger Liu(BJ-RD) ; Kinney, Michael D 抄送: Sean ; michael.kuba...@outlook.com 主题: RE: [edk2-devel] Question about Smm code / StandaloneMmPkg Hi Tiger, Our team

[edk2-devel] [RFC][patch] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access

2021-03-07 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 1.Purpose: Skip port IO/MMIO/MSR access in some emulatoion env. Trace port IO/MMIO/MSR access. 2.Plan to do in Edk2: Filter and trace in low level APIs in BaseIoLibIntrinsic and BaseLib. Add a new library class (RegisterFilterLib)

Re: [edk2-devel] [PATCH v1 1/2] BaseTools: Make undefined VFR macro an error (GCC)

2021-03-07 Thread Daniel Schaefer
It didn't cause any other errors for the huge HPE codebase. Only undefined macros. I don't believe the preprocessor has so many warnings anyways. So -Werror should be fine. From: Feng, Bob C Sent: Monday, March 8, 2021 09:05 To: devel@edk2.groups.io ; Schaefer,

[edk2-devel] [PATCH 1/1] MdePkg/UefiLib: Correct the arguments passed to IsLanguageSupported()

2021-03-07 Thread Chandramohan Akula via groups.io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3211 Correct the arguments passed to the IsLanguageSupported() function in AddUnicodeString2() and LookupUnicodeString2() as expected by the function Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chandramohan Akula ---

Re: 回复: [edk2-devel] New Year, New PR Thread

2021-03-07 Thread Rebecca Cran
It was discussed in the recent Community Meeting last week. Now that the stable tag has been created, I believe it's moving forward as the highest priority task (behind, for example, converting the line endings from Windows to UNIX). -- Rebecca Cran On 3/7/21 7:31 PM, Ni, Ray wrote: It

Re: 回复: [edk2-devel] New Year, New PR Thread

2021-03-07 Thread Ni, Ray
It will be great if PR can replace mail code review. When can we do the move? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca > Cran > Sent: Monday, March 8, 2021 10:21 AM > To: devel@edk2.groups.io; gaolim...@byosoft.com.cn; > bret.barke...@microsoft.com >

Re: [edk2-devel] 回复: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface and Usages

2021-03-07 Thread Kun Qin
Hi Liming, I have drafted a short update note below. This is my first time doing it, please let me know if you have any feedbacks: * VariableSmmRuntimeDxe.inf depends on library class MmUnblockMemoryLib. Platforms supporting variable service through SMM should configure platform DSC in

Re: 回复: [edk2-devel] New Year, New PR Thread

2021-03-07 Thread Rebecca Cran
There's a plan to move away from submitting patches as emails, and to use pull requests for code review instead. -- Rebecca Cran On 3/7/21 6:20 PM, gaoliming wrote: Bret:  What means New Year or New PR Thread?   Now, 202102 stable tag has been done. The code can be merged by PR again.

Re: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Don't allocate Token for SmmStartupThisAp

2021-03-07 Thread Ni, Ray
+ Bug submitter Crystal Lee. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Monday, March 8, 2021 10:17 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Kumar, Rahul1 > Subject: [edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Don't allocate

[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpu: Don't allocate Token for SmmStartupThisAp

2021-03-07 Thread Ni, Ray
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3199 When Token points to mSmmStartupThisApToken, this routine is called from SmmStartupThisAp() in non-blocking mode due to PcdCpuSmmBlockStartupThisAp == FALSE. In this case, caller wants to startup AP procedure in non-blocking mode and

Re: [edk2-devel] [PATCH v3 0/5] UefiCpuPkg/StandaloneMmCpuFeaturesLib: Add Standalone MM support

2021-03-07 Thread Dong, Eric
Reviewed-by: Eric Dong for this serial. -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, February 18, 2021 5:32 AM To: devel@edk2.groups.io Cc: Dong, Eric ; Ni, Ray ; Laszlo Ersek ; Kumar, Rahul1 Subject: [edk2-devel] [PATCH v3 0/5]

Re: [edk2-devel] [PATCH 1/1] BaseTools: Modify struct parser for StructPcd

2021-03-07 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Yuwei Chen Sent: Wednesday, March 3, 2021 11:41 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao Subject: [edk2-devel] [PATCH 1/1] BaseTools: Modify struct parser for StructPcd Currently the

回复: [edk2-devel] [PATCH v6 0/7] Add MmUnblockMemoryLib Interface and Usages

2021-03-07 Thread gaoliming
Kun: This patch set introduces the impact to the platform. Can you provide the update notes for the platform? Then, I will add them into https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning#update-notes Thanks Liming 发件人: devel@edk2.groups.io 代表 Kun Qin 发送时间:

Re: [edk2-devel] [PATCH] BaseTools: Fix build failure of "modules" option

2021-03-07 Thread Bob Feng
This patch looks good to me. Reviewed-by: Bob Feng -Original Message- From: Shi, Steven Sent: Friday, February 26, 2021 2:07 PM To: devel@edk2.groups.io Cc: Shi, Steven ; Feng, Bob C ; Liming Gao Subject: [PATCH] BaseTools: Fix build failure of "modules" option REF:

回复: [edk2-devel] [edk2-platforms][PATCH v1 1/1] MinPlatformPkg/Acpi/AcpiSmm: Add Standalone MM support

2021-03-07 Thread gaoliming
Michael: Can you submit one BZ to track this change? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael > Kubacki > 发送时间: 2021年3月6日 9:38 > 收件人: devel@edk2.groups.io > 抄送: Chasel Chiu ; Nate DeSimone > ; Liming Gao ; > Eric Dong > 主题: [edk2-devel] [edk2-platforms][PATCH v1

回复: [edk2-devel] New Year, New PR Thread

2021-03-07 Thread gaoliming
Bret: What means New Year or New PR Thread? Now, 202102 stable tag has been done. The code can be merged by PR again. Thanks Liming 发件人: devel@edk2.groups.io 代表 Bret Barkelew via groups.io 发送时间: 2021年3月6日 1:11 收件人: devel@edk2.groups.io 主题: [edk2-devel] New Year, New PR Thread

回复: [edk2-devel] [PATCH] BaseTools: Fix build failure of "modules" option

2021-03-07 Thread gaoliming
Steven: With this fix, I find modules, libraries targets both work. Do you verify other build targets? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Steven Shi > 发送时间: 2021年2月26日 14:07 > 收件人: devel@edk2.groups.io > 抄送: Steven Shi ; Bob Feng ; > Liming Gao > 主题: [edk2-devel]

Re: [edk2-devel] [PATCH v1 1/2] BaseTools: Make undefined VFR macro an error (GCC)

2021-03-07 Thread Bob Feng
Hi Derek, -Werror. Make all warnings into errors. Should here be that only treat undef warning as error? Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of Daniel Schaefer Sent: Tuesday, March 2, 2021 4:22 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ;

回复: [edk2-devel] 回复: [PATCH v3 1/1] BaseTools: Update the NASM CI dependency

2021-03-07 Thread gaoliming
Create PR https://github.com/tianocore/edk2/pull/1477 for this patch. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming > 发送时间: 2021年3月2日 9:06 > 收件人: 'Bret Barkelew' ; devel@edk2.groups.io > 抄送: 'Bob Feng' ; 'Yuwei Chen' > > 主题: [edk2-devel] 回复: [PATCH v3 1/1] BaseTools:

[edk2-devel] [edk2-platforms][PATCH] Platform/Sgi: add platform documentation

2021-03-07 Thread Thomas Abraham
Add a document that provides information about the platforms supported by the package 'SgiPkg', the build environment, links to additional documentation and corresponding platform fvp. Signed-off-by: Thomas Abraham Change-Id: If59c06b0ab2e4445f1c59499e43c544ba4ea40a2 ---