> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> gaoliming
> Sent: Monday, March 15, 2021 10:41 AM
> To: devel@edk2.groups.io; a...@kernel.org
> Cc: ler...@redhat.com; liming@intel.com; j...@solid-run.com;
> l...@nuviainc.com
> Subject: 回复: [edk2-devel] [PATCH 1/1]
>
Reviewed-by: Nickle Wang
Thanks,
Nickle
> -Original Message-
> From: Dandan Bi
> Sent: Monday, March 15, 2021 11:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner (HPS SW/FW Technologist) ;
> Wang, Nickle (HPS SW)
> Subject: [patch 18/28] RedfishPkg: Consume RegisterFilterLibNull
Reviewed-by: Abner Chang
> -Original Message-
> From: Dandan Bi [mailto:dandan...@intel.com]
> Sent: Monday, March 15, 2021 11:59 AM
> To: devel@edk2.groups.io
> Cc: Chang, Abner (HPS SW/FW Technologist) ;
> Wang, Nickle (HPS SW)
> Subject: [patch 18/28] RedfishPkg: Consume
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Dandan Bi
> Sent: Monday, March 15, 2021 11:58 AM
> To: devel@edk2.groups.io
> Cc: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu
> Subject: [edk2-devel] [patch 01/28] MdePkg: Add
Hi Kun,
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Thomas
> Abraham via groups.io
> Sent: Thursday, March 11, 2021 11:39 AM
> To: devel@edk2.groups.io; kuqi...@gmail.com
> Cc: Chasel Chiu ; Nate DeSimone
> ; Liming Gao ;
> Eric Dong ; Michael D Kinney
> ; Kelly Steele
Hi Greg,
Please use BaseTools\Scripts\PatchCheck.py to check this patch. There are some
lines code format invalid.
The logic looks good to me.
Yunhua, could you please double check, I remember you have concerns about the
previous version of this patch.
Thanks,
Bob
-Original Message-
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, March 15, 2021 11:58 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [patch 11/28] IntelFsp2Pkg: Consume RegisterFilterLibNull instance
>
> REF:
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Bi, Dandan
> Sent: Monday, March 15, 2021 11:58 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Star
> Subject: [patch 12/28] IntelFsp2WrapperPkg: Consume RegisterFilterLibNull
> instance
>
> REF:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Dandan Bi
---
.../BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 3 +-
.../BaseIoLibIntrinsicArmVirt.inf | 3 +-
.../BaseIoLibIntrinsicInternal.h
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Dandan Bi
---
MdePkg/Library/BaseLib/BaseLib.inf | 5 ++-
MdePkg/Library/BaseLib/Ia32/GccInlinePriv.c | 36 --
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Michael D Kinney
Cc: Sean Brogan
Cc: Bret Barkelew
---
UnitTestFrameworkPkg/UnitTestFrameworkPkgTarget.dsc.inc | 1 +
1 file changed, 1 insertion(+)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Maurice Ma
Cc: Guo Dong
Cc: Benjamin You
Signed-off-by: Dandan Bi
---
UefiPayloadPkg/UefiPayloadPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Ard Biesheuvel
Cc: Sami Mujawar
Cc: Jiewen Yao
Cc: Supreeth Venkatesh
Signed-off-by: Dandan Bi
---
StandaloneMmPkg/StandaloneMmPkg.dsc | 1 +
1 file
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Cc: Rahul Kumar
Signed-off-by: Dandan Bi
---
UefiCpuPkg/UefiCpuPkg.dsc | 1 +
1 file changed, 1 insertion(+)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Jian J Wang
---
SignedCapsulePkg/SignedCapsulePkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Hao A Wu
Signed-off-by: Dandan Bi
---
SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Dandan Bi
---
ShellPkg/ShellPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/ShellPkg/ShellPkg.dsc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Dandan Bi
---
RedfishPkg/RedfishPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Ray Ni
Signed-off-by: Dandan Bi
---
PcAtChipsetPkg/PcAtChipsetPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Jiewen Yao
Cc: Jian J Wang
Signed-off-by: Dandan Bi
---
SecurityPkg/SecurityPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Dandan Bi
---
NetworkPkg/NetworkPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Jordan Justen
Signed-off-by: Dandan Bi
---
OvmfPkg/OvmfPkgIa32.dsc| 1 +
OvmfPkg/OvmfPkgIa32X64.dsc | 1 +
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Jian J Wang
Cc: Hao A Wu
Signed-off-by: Dandan Bi
---
MdeModulePkg/MdeModulePkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Dandan Bi
---
MdePkg/MdePkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
---
IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: Dandan Bi
---
FmpDevicePkg/FmpDevicePkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Dandan Bi
---
IntelFsp2Pkg/IntelFsp2Pkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Dandan Bi
---
EmulatorPkg/EmulatorPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Ray Ni
Signed-off-by: Dandan Bi
---
FatPkg/FatPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/FatPkg/FatPkg.dsc b/FatPkg/FatPkg.dsc
index
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Dandan Bi
---
DynamicTablesPkg/DynamicTablesPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Dandan Bi
---
EmbeddedPkg/EmbeddedPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Dandan Bi
---
ArmPlatformPkg/ArmPlatformPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Dandan Bi
---
CryptoPkg/CryptoPkg.dsc | 1 +
1 file changed, 1 insertion(+)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Dandan Bi
---
ArmVirtPkg/ArmVirt.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
Add RegisterFilterLibNull in dsc which will be consumed
by IoLib and BaseLib.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Dandan Bi
---
ArmPkg/ArmPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmPkg/ArmPkg.dsc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
1. Add a new library class (RegisterFilterLib) to filter
and trace port IO/MMIO/MSR access.
2. Add a NULL instance (RegisterFilterLibNull) can be used
to keep current behavior.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
RFC: https://edk2.groups.io/g/devel/message/72530
Patch 1 is to add RegisterFilterLib Library Class in edk2 to filter/trace port
IO/MMIO/MSR access and add a RegisterFilterLibNull instance.
Last 2 patches are to update APIs in IoLib and
Laszlo:
I agree your comments. I will update the patch to include the comments in
code and commit message.
Thanks
Liming
> -邮件原件-
> 发件人: Laszlo Ersek
> 发送时间: 2021年3月12日 1:22
> 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn
> 抄送: Jian J Wang ; Hao A Wu
> ; ser...@posteo.net
> 主题:
Ard:
Thanks for your fix. Reviewed-by: Liming Gao
Can you include BZ into the commit message? BZ can mention the correct
conversion solution. Other modules should follow the same way to convert FVB
protocol VA.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Ard
> Biesheuvel
This patch looks good to me.
After you remove the duplicated arm copyright, Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of PierreGondois
Sent: Wednesday, March 10, 2021 12:17 AM
To: devel@edk2.groups.io; Feng, Bob C ;
gaolim...@byosoft.com.cn; Chen,
Pierre:
I see. This change is good to me. Reviewed-by: Liming Gao
Thanks
Liming
发件人: PierreGondois
发送时间: 2021年3月11日 17:26
收件人: gaoliming ; devel@edk2.groups.io
主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH v1 1/1] BaseTools/Ecc: Make Ecc
only check first include guard
Hello Liming,
Zhiguang:
I see QuarkPlatformPkg uses PCD gQuarkPlatformTokenSpaceGuid.PcdBootState
to decide whether current boot is the first boot or not.
This PCD is configured as DynamicHiiPcd, and be set in
Platform\Intel\QuarkPlatformPkg\Library\PlatformBootManagerLib\PlatformBootM
anager.c
Can you
From: VincentX Ke
Bugzilla: 3262 (https://bugzilla.tianocore.org/show_bug.cgi?id=3262)
Adding error handle while CapabilityId is 0x
Signed-off-by: VincentX Ke
---
ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
43 matches
Mail list logo
