Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: avoid printing debug messages in AP

2021-03-16 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Ni, Ray Sent: Tuesday, March 16, 2021 9:52 AM To: devel@edk2.groups.io Cc: Dong, Eric ; Laszlo Ersek ; Kumar, Rahul1 Subject: [PATCH v2] UefiCpuPkg/MpInitLib: avoid printing debug messages in AP MpInitLib contains a function

Re: [edk2-devel] [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox

2021-03-16 Thread Yao, Jiewen
Thank you Qi. i recommend we file a bugzilla on the scope of the problem After the scope is agreed, then you can send the patch. For example, I can ask why not remove the sha1supported field at all? I hope the community can reach consensus on the problem statement at first. thank you!

Re: [edk2-devel] 回复: [Patch edk2-platforms V2] Intel/BoardModulePkg: sort load option in the first boot

2021-03-16 Thread Ni, Ray
Liming, Using HII PCDs introduces too many software layers that may cause potential bugs if any layer is not proper implemented (Imaging a case when a platform forgets to include the mdeModule.dsc.inc). Variable used here is very straightforward. That was also the reason when I redesigned the

Re: [edk2-devel] 回复: [PATCH] MdePkg: use CpuPause() in CpuDeadLoop()

2021-03-16 Thread Ankur Arora
On 2021-03-16 6:08 p.m., gaoliming wrote: Ankur: Can you give the detail usage for the lower power state when enter into CpuDeadLoop()? I'm not really familiar with ARM and RiscV, both of which also have implementations for CpuPause(), for the details for X86 variants are below. From

回复: [edk2-devel] [PATCH 1/1] MdeModulePkg/VariableRuntimeDxe: avoid double VA conversion of FVB protocol

2021-03-16 Thread gaoliming
Ard: > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Laszlo Ersek > 发送时间: 2021年3月16日 23:58 > 收件人: Ard Biesheuvel ; devel@edk2.groups.io > 抄送: liming@intel.com; j...@solid-run.com; l...@nuviainc.com > 主题: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/VariableRuntimeDxe: > avoid double VA

回复: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance

2021-03-16 Thread gaoliming
Ard and Dandan: > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Ard > Biesheuvel > 发送时间: 2021年3月16日 23:01 > 收件人: devel@edk2.groups.io; dandan...@intel.com; Laszlo Ersek > ; Andrew Fish > 抄送: Leif Lindholm ; Michael D Kinney > ; Liming Gao > 主题: Re: [edk2-devel] [edk2-platforms] [patch 00/35]

回复: [edk2-devel] 回复: [Patch edk2-platforms V2] Intel/BoardModulePkg: sort load option in the first boot

2021-03-16 Thread gaoliming
Zhiguang: This is the common platform usage. I suggest to apply the same solution. My solution is to define this PCD PcdBootState in MdeModulePkg.dec, and add MdeModule.dsc.inc file that defines this PCD as DynamicHii PCD, platform DSC includes MdeModule.dsc.inc file, platform modules consume

[edk2-devel] [PATCH] SecurityPkg/Tcg2Config: hide PCR Bank SHA1 checkbox

2021-03-16 Thread Qi Zhang
wrap SHA1 related by DISABLE_SHA1_DEPRECATED_INTERFACES. Cc: Jiewen Yao Cc: Jian J Wang Cc: Qi Zhang Cc: Rahul Kumar Signed-off-by: Qi Zhang --- SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigImpl.c

Re: [edk2-devel] [PATCH] ShellPkg/Library: Fix bug in Pci.c

2021-03-16 Thread Gao, Zhichao
Hi Ian/Vincent, Sorry, I just notice the NextCapabilityOffset starts from base address of the PCI config space. So the comment I give in previous patch is incorrect. And refer the PCIe spec, its valid value should be 0x100 to (0x1000 - sizeof (PCI_EXP_EXT_HDR)) or 0x0 (to terminate the list of

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard

2021-03-16 Thread Ni, Ray
> (1) I think "mGdtTemplate" would be a better name than "gGdtTemplate". I > think the "g" prefix is used when an object is identical for all > firmware modules (such as named GUIDs, for example). Agree! I will change in v2. > > (2) I think the last hunk does not belong in this patch -- more >

回复: [edk2-devel] 回复: [PATCH 1/1] MdePkg/UefiLib: Correct the arguments passed to IsLanguageSupported()

2021-03-16 Thread gaoliming
Create PR https://github.com/tianocore/edk2/pull/1495 Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 gaoliming > 发送时间: 2021年3月9日 9:31 > 收件人: 'Chandramohan Akula' ; > devel@edk2.groups.io > 抄送: 'Michael D Kinney' ; 'Zhiguang Liu' > > 主题: [edk2-devel] 回复: [PATCH 1/1]

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 03/16/2021 6:30pm-7:30pm #cal-reminder

2021-03-16 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 16 March 2021, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://meetingsamer34.webex.com/meetingsamer34/j.php?MTID=mb96c5bd411bd010e1e6d43a6f6c65f45 View Event (

[edk2-devel] 回复: [PATCH] MdePkg: use CpuPause() in CpuDeadLoop()

2021-03-16 Thread gaoliming
Ankur: Can you give the detail usage for the lower power state when enter into CpuDeadLoop()? Thanks Liming > -邮件原件- > 发件人: Ankur Arora > 发送时间: 2021年3月17日 6:59 > 收件人: devel@edk2.groups.io > 抄送: Ankur Arora ; Liming Gao > ; Michael D Kinney > > 主题: [PATCH] MdePkg: use CpuPause() in

Re: [edk2-devel] [edk2-discuss] Google Summer of Code Interested Student

2021-03-16 Thread Nate DeSimone
Hi Laszlo, > -Original Message- > From: disc...@edk2.groups.io On Behalf Of > Laszlo Ersek > Sent: Tuesday, March 16, 2021 8:24 AM > To: Desimone, Nathaniel L > Cc: disc...@edk2.groups.io; cadenkli...@gmail.com; edk2-devel-groups-io > ; Ard Biesheuvel (TianoCore) > ; Leif Lindholm

[edk2-devel] [PATCH] MdePkg: use CpuPause() in CpuDeadLoop()

2021-03-16 Thread Ankur Arora
Use CpuPause() to allow the CPU to go into a lower power state state while we spin wait. Cc: Liming Gao Signed-off-by: Ankur Arora Reviewed-by: Michael D Kinney --- MdePkg/Library/BaseLib/CpuDeadLoop.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg: fix guid for PrePiHobLib

2021-03-16 Thread Ard Biesheuvel
On Tue, 16 Mar 2021 at 20:53, Matthew Carlson wrote: > > Currently there is a duplicate GUID shared by two INFs. > This rolls the INF for the PrePiHobLib. > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2381 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: devel@edk2.groups.io > >

[edk2-devel] [PATCH v2 1/1] EmbeddedPkg: fix guid for PrePiHobLib

2021-03-16 Thread Matthew Carlson
Currently there is a duplicate GUID shared by two INFs. This rolls the INF for the PrePiHobLib. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2381 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: devel@edk2.groups.io Signed-off-by: Matthew Carlson ---

[edk2-devel] [PATCH v2 0/1] Fix GUID in PrePiHobLib

2021-03-16 Thread Matthew Carlson
Currently there is a duplicate GUID shared by two INFs. This rolls the INF for the PrePiHobLib. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2381 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: devel@edk2.groups.io Matthew Carlson (1): EmbeddedPkg: fix guid for PrePiHobLib

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/VariableRuntimeDxe: avoid double VA conversion of FVB protocol

2021-03-16 Thread Samer El-Haj-Mahmoud
Late to the party, but I confirm that this fixes the SetVariable() runtime calls on Solid Run Honeycomb LX2 (confirmed from multiple distros) Tested-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek via groups.io > Sent: Tuesday,

Re: [edk2-devel] [RFC PATCH 00/14] Firmware Support for Fast Live Migration for AMD SEV

2021-03-16 Thread Singh, Brijesh
[AMD Official Use Only - Internal Distribution Only] Hi Yao, In the current proposal the accelerated migration does not involve the PSP. I will let Tobin and Dov comment on how things works in current prototype. If PSP was involved in the migration, then flow would be like this: - During the

[edk2-devel] [edk2-platforms][PATCH v2 5/5] Socionext: DeveloperBox DSC File: Added library for VariableSmmRuntimeDxe

2021-03-16 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 This change added NULL MmUnblockMemoryLib instance in DeveloperBox.dsc to resolve new dependency by VariableSmmRuntimeDxe. The library interface is consumed by variable module to better support variable runtime cache feature. Cc: Ard

[edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv2TbltDevicePkg: PlatformPkg DSC: Added library for VariableSmmRuntimeDxe

2021-03-16 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 This change added NULL MmUnblockMemoryLib instance in PlatformPkg dsc file to resolve new dependency by VariableSmmRuntimeDxe. The library interface is consumed by variable module to better support variable runtime cache feature. Cc:

[edk2-devel] [edk2-platforms][PATCH v2 0/5] Resolve dependency from MmUnblockMemoryLib

2021-03-16 Thread Kun Qin
This patch series is a follow up of previous submission: https://edk2.groups.io/g/devel/message/72645 v2 patches mainly focus on feedback for reviewed commits in v1 patches, including: a. Adding "Reviewed-by" tags for applicable patch; b. Updating cc list include critical reviewers; Patch v2

[edk2-devel] [edk2-platforms][PATCH v2 3/5] QuarkPlatformPkg: Quark DSC File: Added new library for VariableSmmRuntimeDxe

2021-03-16 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 This change added NULL MmUnblockMemoryLib instance in Quark.dsc to resolve new dependency by VariableSmmRuntimeDxe. The library interface is consumed by variable module to better support variable runtime cache feature. Cc: Michael D Kinney

[edk2-devel] [edk2-platforms][PATCH v2 2/5] MinPlatformPkg: Core Include Files: Added Tcg2Acpi driver after separation

2021-03-16 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3251 This change follows the commit that separates the original Tcg2Smm driver into Tcg2Acpi and Tcg2 MM based on functionality in DXE and MM. The new Tcg2Acpi driver now will be responsible for patching and publishing ACPI table from DXE, and

[edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: CoreCommonLib: Added new library for VariableSmmRuntimeDxe

2021-03-16 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 This change added NULL MmUnblockMemoryLib instance in dsc files of CoreCommonLib to resolve newly introduced dependency. The library interface is consumed by VariableSmmRuntimeDxe to better support variable runtime cache feature. Cc:

Re: [edk2-devel] [PATCH v9 00/10] support CPU hot-unplug

2021-03-16 Thread Ankur Arora
On 2021-03-16 7:07 a.m., Laszlo Ersek wrote: On 03/12/21 07:26, Ankur Arora wrote: Hi, This series adds OVMF support for CPU hot-unplug. QEMU secureboot hot-unplug logic corresponding to this is in upstream. Also posted here:

Re: [edk2-devel] [RFC PATCH 00/14] Firmware Support for Fast Live Migration for AMD SEV

2021-03-16 Thread Tobin Feldman-Fitzthum
On 3/12/21 9:32 PM, Yao, Jiewen wrote: Hi We discuss the patch internally. We do see PROs and CONs with this approach. The advantage is that it is very simple. In-VM migration can save lots of effort on security context restore. On the other hand, we feel not so comfortable to reserve a

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: avoid printing debug messages in AP

2021-03-16 Thread Laszlo Ersek
On 03/16/21 02:52, Ray Ni wrote: > MpInitLib contains a function MicrocodeDetect() which is called by > all threads as an AP procedure. > Today this function contains below code: > > if (CurrentRevision != LatestRevision) { > AcquireSpinLock(>MpLock); > DEBUG (( >

Re: [edk2-devel] [patch 24/28] UefiCpuPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Laszlo Ersek
On 03/15/21 04:58, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > Add RegisterFilterLibNull in dsc which will be consumed > by IoLib and BaseLib. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Signed-off-by: Dandan Bi > --- >

Re: [edk2-devel] [patch 16/28] OvmfPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Laszlo Ersek
On 03/15/21 04:58, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > Add RegisterFilterLibNull in dsc which will be consumed > by IoLib and BaseLib. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > Signed-off-by: Dandan Bi > --- >

Re: [edk2-devel] [patch 04/28] ArmVirtPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Laszlo Ersek
Hi Dandan, On 03/15/21 04:58, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > Add RegisterFilterLibNull in dsc which will be consumed > by IoLib and BaseLib. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Dandan Bi > --- >

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuDxe: Guarantee GDT is below 4GB

2021-03-16 Thread Laszlo Ersek
On 03/16/21 04:33, Ray Ni wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3233 > > GDT needs to be allocated below 4GB in 64bit environment > because AP needs it for entering to protected mode. > CPU running in big real mode cannot access above 4GB GDT. > > But CpuDxe driver

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard

2021-03-16 Thread Laszlo Ersek
On 03/16/21 04:33, Ray Ni wrote: > The change doesn't impact any functionality. > > Signed-off-by: Ray Ni > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Rahul Kumar > --- > UefiCpuPkg/CpuDxe/CpuGdt.c | 27 +-- > 1 file changed, 13 insertions(+), 14 deletions(-) > > diff

Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance

2021-03-16 Thread Laszlo Ersek
On 03/16/21 16:00, Ard Biesheuvel wrote: > On Tue, 16 Mar 2021 at 15:56, Dandan Bi wrote: >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 >> RFC: https://edk2.groups.io/g/devel/message/72530 >> >> >> Add RegisterFilterLibNull in dsc files in edk2-platforms repo, >> which will be

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg/CpuCacheInfoLib: Collect cache associative type

2021-03-16 Thread Laszlo Ersek
On 03/15/21 09:04, Jason wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3265 > > Support collecting cache associative type in CpuCacheInfoLib. > This prevents the user from using additional code to obtain the > same information. > > Signed-off-by: Jason Lou > Cc: Ray Ni > Cc:

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/VariableRuntimeDxe: avoid double VA conversion of FVB protocol

2021-03-16 Thread Laszlo Ersek
On 03/13/21 00:05, Ard Biesheuvel wrote: > For historical reasons, the VariableRuntimeDxe performs virtual address > conversion on the FVB protocol member pointers of the protocol instance > that backs the EFI variable store. However, the driver that produces the > actual instance should be doing

Re: [edk2-devel] [edk2-discuss] Google Summer of Code Interested Student

2021-03-16 Thread Laszlo Ersek
Hi Nate, (adding Leif and Ard) On 03/13/21 03:52, Desimone, Nathaniel L wrote: > I've created a new wiki page for this task with all the information I > have gathered thus far. I've done some more experimentation and found > that there are several newer terminal emulators that don't support >

Re: [edk2-devel] [edk2-platforms] [patch 28/35] Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Steele, Kelly
Reviewed-by: Kelly Steele > -Original Message- > From: Bi, Dandan > Sent: Tuesday, March 16, 2021 7:54 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Steele, Kelly > > Subject: [edk2-platforms] [patch 28/35] Silicon/QuarkSocPkg: Consume > RegisterFilterLibNull instance > >

Re: [edk2-devel] [edk2-platforms] [patch 15/35] Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Steele, Kelly
Reviewed-by: Kelly Steele > -Original Message- > From: Bi, Dandan > Sent: Tuesday, March 16, 2021 7:54 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Steele, Kelly > > Subject: [edk2-platforms] [patch 15/35] Platform/QuarkPlatformPkg: > Consume RegisterFilterLibNull instance

Re: [edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance

2021-03-16 Thread Ard Biesheuvel
On Tue, 16 Mar 2021 at 15:56, Dandan Bi wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > RFC: https://edk2.groups.io/g/devel/message/72530 > > > Add RegisterFilterLibNull in dsc files in edk2-platforms repo, > which will be consumed by IoLib and BaseLib. > > This is the

[edk2-devel] [edk2-platforms] [patch 30/35] Silicon/Marvell: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Marcin Wojtas Cc: Leif Lindholm Signed-off-by: Dandan Bi --- Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff

[edk2-devel] [edk2-platforms] [patch 34/35] Silicon/Synopsys/DesignWare: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Dandan Bi --- Silicon/Synopsys/DesignWare/DesignWare.dsc | 1 + 1 file changed, 1 insertion(+) diff

[edk2-devel] [edk2-platforms] [patch 32/35] Silicon/Openmoko: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Dandan Bi --- Silicon/Openmoko/Openmoko.dsc | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2-devel] [edk2-platforms] [patch 35/35] Silicon/TexasInstruments: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Dandan Bi --- Silicon/TexasInstruments/Omap35xxPkg/Omap35xxPkg.dsc | 1 + 1 file changed, 1 insertion(+)

[edk2-devel] [edk2-platforms] [patch 33/35] Silicon/RISC_V: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Abner Chang Cc: Daniel Schaefer Cc: Gilbert Chen Signed-off-by: Dandan Bi --- Silicon/RISC-V/ProcessorPkg/RiscVProcessorPkg.dsc | 1 + 1 file changed, 1

[edk2-devel] [edk2-platforms] [patch 29/35] Silicon/TigerlakeSiliconPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Dandan Bi --- Silicon/Intel/TigerlakeSiliconPkg/TigerlakeSiliconPkg.dsc | 1 + 1 file

[edk2-devel] [edk2-platforms] [patch 28/35] Silicon/QuarkSocPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Michael D Kinney Cc: Kelly Steele Signed-off-by: Dandan Bi --- Silicon/Intel/QuarkSocPkg/QuarkSocPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1

[edk2-devel] [edk2-platforms] [patch 31/35] Silicon/NXP: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Leif Lindholm Cc: Meenakshi Aggarwal Signed-off-by: Dandan Bi --- Silicon/NXP/NxpQoriqLs.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2-devel] [edk2-platforms] [patch 24/35] Silicon/Hisilicon: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Wenyi Xie Signed-off-by: Dandan Bi --- Silicon/Hisilicon/Hisilicon.dsc.inc | 1 + 1 file changed, 1 insertion(+)

[edk2-devel] [edk2-platforms] [patch 27/35] Silicon/KabylakeSiliconPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Dandan Bi --- Silicon/Intel/KabylakeSiliconPkg/KabylakeSiliconPkg.dsc | 3 ++- 1 file changed, 2

[edk2-devel] [edk2-platforms] [patch 23/35] Platform/SoftIron: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Dandan Bi --- Platform/SoftIron/Overdrive1000Board/Overdrive1000Board.dsc | 1 + 1 file changed, 1

[edk2-devel] [edk2-platforms] [patch 26/35] Silicon/IntelSiliconPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Dandan Bi --- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1

[edk2-devel] [edk2-platforms] [patch 22/35] Platform/Socionext: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Dandan Bi --- Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 +

[edk2-devel] [edk2-platforms] [patch 25/35] Silicon/CoffeelakeSiliconPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Chasel Chiu Cc: Sai Chaganty Signed-off-by: Dandan Bi --- Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 1 + 1 file changed, 1

[edk2-devel] [edk2-platforms] [patch 20/35] Platform/RISC-V: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Abner Chang Cc: Daniel Schaefer Cc: Gilbert Chen Signed-off-by: Dandan Bi --- Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dsc | 1 + 1 file changed, 1

[edk2-devel] [edk2-platforms] [patch 21/35] Platform/SiFive: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Abner Chang Cc: Daniel Schaefer Cc: Gilbert Chen Signed-off-by: Dandan Bi --- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 +

[edk2-devel] [edk2-platforms] [patch 16/35] Platform/Vlv2TbltDevicePkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Michael D Kinney Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Dandan Bi --- Platform/Intel/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 3 ++-

[edk2-devel] [edk2-platforms] [patch 04/35] Features/Debugging: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Dandan Bi --- .../Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc | 3 ++-

[edk2-devel] [edk2-platforms] [patch 19/35] Platform/RaspberryPi: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Pete Batard Signed-off-by: Dandan Bi --- Platform/RaspberryPi/RPi3/RPi3.dsc | 3 ++-

[edk2-devel] [edk2-platforms] [patch 18/35] Platform/Qemu: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Graeme Gregory Cc: Radoslaw Biernacki Signed-off-by: Dandan Bi --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 + 1

[edk2-devel] [edk2-platforms] [patch 17/35] Platform/LeMaker: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Dandan Bi --- Platform/LeMaker/CelloBoard/CelloBoard.dsc | 1 + 1 file changed, 1 insertion(+) diff

[edk2-devel] [edk2-platforms] [patch 15/35] Platform/QuarkPlatformPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Michael D Kinney Cc: Kelly Steele Signed-off-by: Dandan Bi --- Platform/Intel/QuarkPlatformPkg/Quark.dsc| 1 +

[edk2-devel] [edk2-platforms] [patch 14/35] Platform/MinPlatformPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Dandan Bi --- Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 3

[edk2-devel] [edk2-platforms] [patch 13/35] Platform/BoardModulePkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Eric Dong Cc: Liming Gao Signed-off-by: Dandan Bi --- Platform/Intel/BoardModulePkg/BoardModulePkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1

[edk2-devel] [edk2-platforms] [patch 12/35] Platform/BeagleBoard: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Dandan Bi --- Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 3 ++- 1 file changed, 2

[edk2-devel] [edk2-platforms] [patch 11/35] Platform/ARM: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ard Biesheuvel Cc: Thomas Abraham Cc: Sami Mujawar Signed-off-by: Dandan Bi --- Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 1 +

[edk2-devel] [edk2-platforms] [patch 10/35] Platform/AMD: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Dandan Bi --- Platform/AMD/OverdriveBoard/OverdriveBoard.dsc | 1 + 1 file changed, 1 insertion(+) diff

[edk2-devel] [edk2-platforms] [patch 09/35] Features/UserInterface: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Liming Gao Signed-off-by: Dandan Bi --- .../Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc | 3 ++-

[edk2-devel] [edk2-platforms] [patch 08/35] Features/SystemInformation: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Liming Gao Signed-off-by: Dandan Bi --- .../SmbiosFeaturePkg/Include/SmbiosFeature.dsc | 3 ++- 1 file changed, 2 insertions(+), 1

[edk2-devel] [edk2-platforms] [patch 07/35] Features/PowerManagement: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Liming Gao Signed-off-by: Dandan Bi --- .../Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 3 ++- 1 file changed, 2 insertions(+), 1

[edk2-devel] [edk2-platforms] [patch 05/35] Features/Network: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Liming Gao Signed-off-by: Dandan Bi --- .../Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc | 3 ++- 1 file changed, 2 insertions(+), 1

[edk2-devel] [edk2-platforms] [patch 02/35] Drivers/DisplayLink: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Andy Hayes Signed-off-by: Dandan Bi --- Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkPkg.dsc | 1 + 1 file

[edk2-devel] [edk2-platforms] [patch 06/35] Features/OutOfBandManagement: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Liming Gao Signed-off-by: Dandan Bi --- .../OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc | 3 ++-

[edk2-devel] [edk2-platforms] [patch 03/35] Drivers/OptionRomPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Ray Ni Signed-off-by: Dandan Bi --- Drivers/OptionRomPkg/OptionRomPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [edk2-platforms] [patch 01/35] Drivers/ASIX: Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 Add RegisterFilterLibNull in dsc which will be consumed by IoLib and BaseLib. Cc: Samer El-Haj-Mahmoud Cc: Ray Ni Signed-off-by: Dandan Bi --- Drivers/ASIX/Asix.dsc | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2-devel] [edk2-platforms] [patch 00/35] Consume RegisterFilterLibNull instance

2021-03-16 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 RFC: https://edk2.groups.io/g/devel/message/72530 Add RegisterFilterLibNull in dsc files in edk2-platforms repo, which will be consumed by IoLib and BaseLib. This is the following update in edk2-platforms repo for the change in edk2,

Re: [edk2-devel] [PATCH v9 00/10] support CPU hot-unplug

2021-03-16 Thread Laszlo Ersek
On 03/12/21 07:26, Ankur Arora wrote: > Hi, > > This series adds OVMF support for CPU hot-unplug. > > QEMU secureboot hot-unplug logic corresponding to this is in upstream. > Also posted here: > > https://lore.kernel.org/qemu-devel/20201207140739.3829993-1-imamm...@redhat.com/ > > Testing (with

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg/CpuCacheInfoLib: Collect cache associative type

2021-03-16 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Lou, Yun Sent: Monday, March 15, 2021 9:49 PM To: devel@edk2.groups.io Cc: Lou, Yun ; Ni, Ray ; Dong, Eric ; Laszlo Ersek ; Kumar, Rahul1 Subject: [PATCH v2 1/1] UefiCpuPkg/CpuCacheInfoLib: Collect cache associative type REF:

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/CpuDxe: Guarantee GDT is below 4GB

2021-03-16 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Ni, Ray Sent: Tuesday, March 16, 2021 11:34 AM To: devel@edk2.groups.io Cc: Dong, Eric ; Laszlo Ersek ; Kumar, Rahul1 Subject: [PATCH 2/2] UefiCpuPkg/CpuDxe: Guarantee GDT is below 4GB REF:

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard

2021-03-16 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Ni, Ray Sent: Tuesday, March 16, 2021 11:34 AM To: devel@edk2.groups.io Cc: Dong, Eric ; Laszlo Ersek ; Kumar, Rahul1 Subject: [PATCH 1/2] UefiCpuPkg/CpuDxe: Rename variables to follow EDKII coding standard The change doesn't impact

Re: [edk2-devel] [edk2-platforms] Intel/MinPlatformPkg: resolve MmUnblockMemoryLib

2021-03-16 Thread Zhiguang Liu
Hi Kun, Your patch is ok for me. Please keep this change in your patch series. Hi All, Please ignore this patch since the same solution is already included in Kun's patch serials. Thanks Zhiguang > -Original Message- > From: Kun Qin > Sent: Tuesday, March 16, 2021 5:18 PM > To:

Re: [edk2-devel] [PATCH v9 09/10] OvmfPkg/CpuHotplugSmm: do actual CPU hot-eject

2021-03-16 Thread Laszlo Ersek
On 03/12/21 07:26, Ankur Arora wrote: > @@ -214,6 +243,83 @@ EjectCpu ( > { >UINT64 QemuSelector; > > + if (CheckIfBsp ()) { > +UINT32 Idx; > + > +for (Idx = 0; Idx < mCpuHotEjectData->ArrayLength; Idx++) { > + UINT64 QemuSelector; Visual Studio warns that the inner

Re: [edk2-devel] [PATCH v9 10/10] OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug

2021-03-16 Thread Laszlo Ersek
On 03/12/21 07:26, Ankur Arora wrote: > Advertise OVMF support for CPU hot-unplug and negotiate it > if QEMU requests the feature. > > Cc: Laszlo Ersek > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Igor Mammedov > Cc: Boris Ostrovsky > Cc: Aaron Young > Ref:

Re: [edk2-devel] [PATCH v9 09/10] OvmfPkg/CpuHotplugSmm: do actual CPU hot-eject

2021-03-16 Thread Laszlo Ersek
On 03/12/21 07:26, Ankur Arora wrote: > Add logic in EjectCpu() to do the actual the CPU ejection. > > On the BSP, ejection happens by first selecting the CPU via > its QemuSelector and then sending the QEMU "eject" command. > QEMU in-turn signals the remote VCPU thread which context-switches >

Re: [edk2-devel] [PATCH v9 08/10] OvmfPkg/CpuHotplugSmm: add EjectCpu()

2021-03-16 Thread Laszlo Ersek
On 03/12/21 07:26, Ankur Arora wrote: > Add EjectCpu(), which handles the CPU ejection, and provides a holding > area for said CPUs. It is called via SmmCpuFeaturesRendezvousExit(), > at the tail end of the SMI handling. > > Also UnplugCpus() now stashes QEMU Selectors of CPUs which need to be >

Re: [edk2-devel] [PATCH v9 07/10] OvmfPkg/SmmCpuFeaturesLib: call CPU hot-eject handler

2021-03-16 Thread Laszlo Ersek
On 03/12/21 07:26, Ankur Arora wrote: > Call the CPU hot-eject handler if one is installed. The condition for > installation is (PcdCpuMaxLogicalProcessorNumber > 1), and there's > a hot-unplug request. > > The handler is called from SmmCpuFeaturesRendezvousExit(), which is > in-turn called at

Re: [edk2-devel] [PATCH v9 06/10] OvmfPkg/SmmCpuFeaturesLib: init CPU ejection state

2021-03-16 Thread Laszlo Ersek
On 03/12/21 07:26, Ankur Arora wrote: > Init CPU_HOT_EJECT_DATA, which will be used to share CPU ejection > state between SmmCpuFeaturesLib (via PiSmmCpuDxeSmm) and CpuHotPlugSmm. > > The init happens via SmmCpuFeaturesSmmRelocationComplete(), and so it > will run as part of the PiSmmCpuDxeSmm

Re: [edk2-devel] [PATCH v9 05/10] OvmfPkg: define CPU_HOT_EJECT_DATA

2021-03-16 Thread Laszlo Ersek
On 03/12/21 07:26, Ankur Arora wrote: > Define CPU_HOT_EJECT_DATA and add PCD PcdCpuHotEjectDataAddress, which > will be used to share CPU ejection state between OvmfPkg/CpuHotPlugSmm > and PiSmmCpuDxeSmm. > > Cc: Laszlo Ersek > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Igor Mammedov > Cc:

Re: [edk2-devel] [PATCH v9 02/10] OvmfPkg/CpuHotplugSmm: collect hot-unplug events

2021-03-16 Thread Laszlo Ersek
On 03/12/21 07:26, Ankur Arora wrote: > Process fw_remove events in QemuCpuhpCollectApicIds(), and collect APIC IDs > and QEMU CPU Selectors for CPUs being hot-unplugged. > > In addition, we now ignore CPUs which only have remove set. These > CPUs haven't been processed by OSPM yet. > > This is

[edk2-devel] [PATCH] ShellPkg/Library: Fix bug in Pci.c

2021-03-16 Thread IanX Kuo
From: VincentX Ke Bugzilla: 3262 (https://bugzilla.tianocore.org/show_bug.cgi?id=3262) No need to print PCIe details while CapabilityId is 0x. Limit the NextCapabilityOffset value to AllocatePool() memory. Signed-off-by: VincentX Ke --- ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c |

Re: [edk2-devel] [edk2-platforms] Intel/MinPlatformPkg: resolve MmUnblockMemoryLib

2021-03-16 Thread Kun Qin
Hi Zhiguang, I have already sent this patch series to resolve dependencies in edk2-platform (although the change is slightly different): https://edk2.groups.io/g/devel/message/72645 Specifically: https://edk2.groups.io/g/devel/message/72646 Could you please let me know if the change above

[edk2-devel] [edk2-platforms] Intel/MinPlatformPkg: resolve MmUnblockMemoryLib

2021-03-16 Thread Zhiguang Liu
The below Edk2 patch makes VariableSmmRuntimeDxe begin to consume MmUnblockMemoryLib. It cause multiple platforms build failure. f463dbadede138dc96a66dae6f361c54f0b3093c MdeModulePkg: VariableSmmRuntimeDxe: Added request unblock memory interface This change added NULL MmUnblockMemoryLib

Re: [edk2-devel] [patch 20/28] ShellPkg: Consume RegisterFilterLibNull instance

2021-03-16 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Bi, Dandan > Sent: Monday, March 15, 2021 11:59 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao > Subject: [patch 20/28] ShellPkg: Consume RegisterFilterLibNull instance > > REF:

Re: [edk2-devel] [PATCH] ShellPkg/Library: Error handle while CapabilityId is 0xFFFF

2021-03-16 Thread Gao, Zhichao
Hi Ian/Vincent, It is a bug fix for parsing PCI extended config space. But there is one more place can be enhanced. if (ExtHdr->NextCapabilityOffset != 0) { You can see the above condition to check next capability info. But it doesn't check the length. If the value is 0xfff, it would put the