Another option is to put the protocol definition in MdeModulePkg and mark it
with the EDKII_ prefix. For my last “code first” UEFI spec contribution I did
this with the PPI that added up getting added.
Thanks,
Nate
From: on behalf of "Andrew Fish via groups.io"
Reply-To: "devel@edk2.groups.i
Hi Ethin,
I’m not quite sure what happened but I loaded it up again and the text shown
now makes a lot more sense, thank you for your application!
Nate
From: on behalf of Ethin Probst
Reply-To: "devel@edk2.groups.io" ,
"harlydavid...@gmail.com"
Date: Tuesday, March 30, 2021 at 7:41 AM
To: "
Hi,
In UefiSpec.h, we define the UEFI version 2.7 in system table.
#define EFI_2_70_SYSTEM_TABLE_REVISION (( 2 << 16 ) | ( 70 ))
#define EFI_SYSTEM_TABLE_REVISION EFI_2_70_SYSTEM_TABLE_REVISION
#define EFI_SPECIFICATION_VERSION EFI_SYSTEM_TABLE_REVISION
#define EFI_RUNTIME_SERVICES_REVISION EFI_S
> On Mar 30, 2021, at 5:01 PM, Ethin Probst wrote:
>
> I'm wondering where exactly I should add the VirtIO sound protocol. I
> just familiarized myself with the build system and am about to test it
> by building OVMF if possible, but I'm wondering where I should
> actually put the protocol and a
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Zhiguang Liu
> Sent: Tuesday, March 30, 2021 4:45 PM
> To: devel@edk2.groups.io
> Cc: Dong, Guo ; You, Benjamin
> ; Park, Aiden ; Ma,
> Maurice
> Subject: [edk2-devel] [PATCH] UefiPayloadPkg: UefiPayloa
Thanks the comments, I will refine the patch according the feedback.
> -Original Message-
> From: Yao, Jiewen
> Sent: Wednesday, March 31, 2021 10:20 AM
> To: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Wu, Jiaxin
>
> Cc: Kinney, Michael D ; Liu, Zhiguang
> ; Zhang, Hongbin1
> Sub
Hi Dandan,
On Sun, Mar 28, 2021 at 06:12 AM, Dandan Bi wrote:
>
> diff --git a/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc
> b/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc
> index 5c87a0ca9b..d9dfa7c4ae 100644
> --- a/Platform/ARM/SgiPkg/RdN1EdgeX2/RdN1EdgeX2.dsc
> +++ b/Platform/ARM/SgiPkg/R
Agree with Liming.
For IA32, you get parameter from stack -
mov edx, [esp + 12]
mov eax, [esp + 8]
mov ecx, [esp + 4]
For X64, you get parameter from GP register - RCX, RDX, R8, R9 for the first 4
parameter. They are on the stack since the 5th parameter.
The code may be
Add OemMiscLib calls to allow platforms to provide the following
information about the chassis:
o Bootup state
o Power supply/supplies state
o Thermal state
o Security state
o Chassis height (in RMU)
o Number of power cords
Signed-off-by: Rebecca Cran
---
ArmPkg/Include/Library/OemMiscLib.h
Add a new function to OemMiscLib to allow platforms to report their boot
status into the Type32 SMBIOS table.
Signed-off-by: Rebecca Cran
---
ArmPkg/Include/Library/OemMiscLib.h|
10 ++
ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
Add the set of improvements requested during the initial series to move
closer to a full/proper implementation, fix the
chassis SKU number string, and fix a typo in a comment.
This is a breaking change wrt SbsaQemu in edk2-platforms.
Rebecca Cran (5):
ArmPkg: Allow platforms to override PCI sup
'Manufacturer' was spelled wrongly in a comment in
MiscChassisManufacturerData.c.
Signed-off-by: Rebecca Cran
---
ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type03/MiscChassisManufacturerData.c | 2
+-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/ArmPkg/Universal/Smbios/SmbiosMiscDxe
The calculation of the chassis SKU number field was being calculated
incorrectly, forgetting that there's one element already present in
the structure.
Fix the calculation and improve code readability by introducing a
SkuNumberField variable.
Signed-off-by: Rebecca Cran
---
ArmPkg/Universal/Smbi
Not all platforms support PCI, so introduce a PCD to allow platforms to
specify whether they support it.
Signed-off-by: Rebecca Cran
---
ArmPkg/ArmPkg.dec | 1 +
ArmPkg/Universal/Smbios/SmbiosMiscDxe/SmbiosMiscDxe.inf | 1 +
ArmPk
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kun Qin
> Sent: Tuesday, March 16, 2021 11:11 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang ; Qian, Yi ;
> Kinney, Michael D
> Subject: [edk2-devel] [edk2-platforms][PATCH v2 4/5] Vlv
Jiaxin:
32bit function and 64bit function have the different calling convention.
Their assembly function can't be shared.
This new API interface is same to AsmWriteMsr64(). You can refer
AsmWriteMsr64() implementation in BaseLib.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代
Liming,
GCC can detect redefinition of same type.
typedef int foo;
typedef int foo;
int main (int argc, char *argv[]) {
return 0;
}
gcc a.c -Wpedantic -std=c99
a.c:2:13: warning: redefinition of typedef ‘foo’ [-Wpedantic]
typedef int foo;
The SystemEnclosureTypeTable in QueryTable.c contained a couple
of errors: value 0x10 is "Lunch Box" not "Main Server Chassis", and
the Sub Notebook value was repeated as 0x13 when that entry is for
"SubChassis". The entries in-between needed adjusted.
Signed-off-by: Rebecca Cran
---
ShellPkg/Li
Actually, the implementation under ia32 should be also workable for X64, I just
put it under ia32.
Liming, do you have suggestion where can we place the code?
Thanks,
Jiaxin
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of gaoliming
> Sent: Wednesday, March 31, 2021 9:51
Where is X64 implementation for this new API?
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Wu, Jiaxin
> 发送时间: 2021年3月31日 9:20
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu ; Zhang
> Hongbin1
> 主题: [edk2-devel] [PATCH v1] MdePkg: Support Extended Control
> Re
https://bugzilla.tianocore.org/show_bug.cgi?id=3284
This patch is to support Extended Control Register(XCR) Read
and Write.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Zhang Hongbin1
Signed-off-by: Jiaxin Wu
---
MdePkg/Include/Library/BaseLib.h | 46
Mike:
The change is good. Reviewed-by: Liming Gao
Besides, which compiler option can detect this warning?
Thanks
Liming
> -邮件原件-
> 发件人: Michael D Kinney
> 发送时间: 2021年3月31日 7:04
> 收件人: devel@edk2.groups.io
> 抄送: Liming Gao ; Zhiguang Liu
> ; Jiewen Yao ; Jian J Wang
> ; Xiaoyu Lu ; G
*Reminder:* TianoCore Bug Triage - APAC / NAMO
*When:* Tuesday, 30 March 2021, 6:30pm to 7:30pm, (GMT-07:00) America/Los
Angeles
*Where:*
https://meetingsamer34.webex.com/meetingsamer34/j.php?MTID=mb96c5bd411bd010e1e6d43a6f6c65f45
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1
Hi Sami Mujawar,
Thanks for catching that.
I will add them.
Thanks,
Dandan
From: devel@edk2.groups.io On Behalf Of Sami Mujawar
Sent: Wednesday, March 31, 2021 12:48 AM
To: Bi, Dandan ; devel@edk2.groups.io
Subject: Re: [edk2-devel] [patch V4 28/29] MdePkg/IoLib: Filter/trace port
IO/MMIO acce
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3288
Simplify the DSC file by using the library mappings from
UnitTestFrameworkPkgTarget.dsc.inc to build the CryptoPkg
target based unit tests that run from the UEFI Shell.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Cc: B
I'm wondering where exactly I should add the VirtIO sound protocol. I
just familiarized myself with the build system and am about to test it
by building OVMF if possible, but I'm wondering where I should
actually put the protocol and all that stuff. Maybe there's
documentation I've missed as well.
Hi all,
This may be my first time participating in GSoC and contributing to TianoCore.
I'm looking to complete the MinPlatform board port task for an Acer Aspire
VN7-572G laptop, which is a Skylake-U platform supported by the Kabylake FSP.
I have previously written a coreboot port for the same b
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Michael D Kinney
> Sent: Wednesday, March 31, 2021 7:04 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; Wang, Jian J ;
> Lu, XiaoyuX ; Jiang, Guomin
> Subject: [Patch 3/3] CryptoPkg/Private/Protocol/Crypto.h: Remove duplicate
> func
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3287
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3286
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3285
Remove duplicate declarations of the following types that may
generate compiler warnings or errors:
* EFI_HII_POPUP_PROTOCOL
*
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3286
Remove duplicate declaration of structure type
EFI_RESET_NOTIFICATION_PROTOCOL from ResetNotification.h. The
forward declaration of the top of this file already declared
this type.
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Michael D
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3287
Remove duplicate declaration of the function prototype
EDKII_CRYPTO_RSA_GET_PUBLIC_KEY_FROM_X509.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Michael D Kinney
---
CryptoPkg/Private/Protocol/Crypto.h |
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3285
Remove duplicate declaration of structure type
EFI_HII_POPUP_PROTOCOL from HiiPopup.h. The forward
declaration of the top of this file already declared
this type.
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Michael D Kinney
---
MdeP
I agree. Plus, it gives me a chance to finally learn the EDK2 build
system and how it works! I've been working on a hobby OS as a side
project and, though learning from other code examples from OSes is
fun, I have to say that learning from the firmware code like from
SeaBIOS has been some of the mo
This would be amazing so people can continue my work related to
accessibility at BIOS. Something desired by the blind people since the 90's
Just for reference, this is what I have done:
https://github.com/RafaelRMachado/Msc_UefiHda_PreOs_Accessibility
Thanks
Rafael
Em seg, 29 de mar de 2021 20:2
Hi Dandan,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Dandan Bi
Sent: 28 March 2021 01:02 PM
To: devel@edk2.groups.io
Cc: Ard Biesheuvel ; Sami Mujawar
; Jiewen Yao ; Supreeth Venkatesh
Subject: [patch V4 24/29] Standalon
Hi Dandan,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: devel@edk2.groups.io On Behalf Of Dandan Bi via
groups.io
Sent: 28 March 2021 01:02 PM
To: devel@edk2.groups.io
Cc: Leif Lindholm ; Ard Biesheuvel
Subject: [edk2-devel]
Hi Dandan,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: devel@edk2.groups.io On Behalf Of Dandan Bi via
groups.io
Sent: 28 March 2021 01:02 PM
To: devel@edk2.groups.io
Cc: Leif Lindholm ; Ard Biesheuvel
Subject: [edk2-devel]
Hi Dandan,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: Dandan Bi
Sent: 28 March 2021 01:02 PM
To: devel@edk2.groups.io
Cc: Sami Mujawar ; Alexei Fedorov
Subject: [patch V4 07/29] DynamicTablesPkg: Consume MdeLibs.dsc.inc for
Hi Chandni,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#73538): https://edk2.groups.io/g/devel/message/73538
Mute This Topic: https://groups.io/mt/81730224/
The link for GCC toolchain is no longer valid. Update
GCC toolchain to point to the latest link available.
Signed-off-by: Chandni Cherukuri
---
Readme.md | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/Readme.md b/Readme.md
index d00600d35018..cfdb3a15a282 10064
Hi Dandan,
On Sun, Mar 28, 2021 at 05:03 AM, Dandan Bi wrote:
>
> + Flag = FilterBeforeMmIoRead (FilterWidth8, Address, &Value);
> + if (Flag {
There is a missing closing bracket here and at other places in
MdePkg/Library/BaseIoLibIntrinsic/IoLibNoIo.c. Can you check, please?
>
> + Value = *
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3253
SctPrint() requires that %d refers to an UINTN parameter.
SimpleTextOutBBTestFunction_uefi.c has a lot of
StandardLib->RecordAssertion() calls where an INT32 is passed
as argument for a '%d' print code.
This leads to incorrect output like:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3257
SctPrint() requires that %x and %d refers to an UINTN parameter.
SimpleNetworkBBTestFunction.c tries to print INT32 using %x, %d without
converting to UINTN resulting in corrupted output like:
SimpleNetworkBBTestFunction.c:891:
Status - Un
Hi Nate,
I appreciate the feedback, but I'm quite confused on exactly what questions
I've failed to answer? I didn't include my other contact information but I'm
not sure what else might be missing from my proposal.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this
niedz., 28 mar 2021 o 15:12 Dandan Bi napisał(a):
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.
niedz., 28 mar 2021 o 15:12 Dandan Bi napisał(a):
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.
Hi All,
I plan to submit this dsc changes in edk2-platform tomorrow afternoon with R-B
got from Mike, and some pkg maintainers.
Please let me know if you have any concern.
Following dependent changes in edk2 have been submitted.
https://github.com/tianocore/edk2/commit/1c11e7a2142b1406ccff5e0af0
Hi All,
Thank you for the patch review.
I have submitted patch 1 &2 via following commits.
https://github.com/tianocore/edk2/commit/1c11e7a2142b1406ccff5e0af0893c94472871c8
https://github.com/tianocore/edk2/commit/98ff7e3c6373d3e0590f953459b6234ab12edce6
I plan to submit dsc changes tomorrow afte
Looks good to me. Same comment as the patches 1/5 and 2/5.
Reviewed-by: Sunny Wang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Daniel Schaefer
Sent: Thursday, March 4, 2021 11:21 AM
To: devel@edk2.groups.io
Cc: G Edhaya Chandran ; Barton Gao
; Samer El-Haj-Mahmoud ;
Eric
Hi Daniel,
If my understanding is correct, the build flags below will be used for all the
architectures. However, it looks like the compiler options "-ffreestanding
-nostdinc -nostdlib" are not common enough for all the architectures. For ARM,
this change is ok. However, this may not be ok for
Looks good to me.
Same comment as patch 1/5. This only affects RISCV. Therefore, as long as you
build and run SCT on the RISCV platform, this change should be fine.
Reviewed-by: Sunny Wang
-Original Message-
From: Schaefer, Daniel
Sent: Thursday, March 4, 2021 11:21 AM
To: devel@edk2.gr
Looks good to me. This only affects RISCV. Therefore, as long as you build and
run SCT on the RISCV platform, this change should be fine.
Reviewed-by: Sunny Wang
Best Regards,
Sunny Wang
-Original Message-
From: Schaefer, Daniel
Sent: Thursday, March 4, 2021 11:21 AM
To: devel@edk2.gro
UefiPayload parse gPldPciRootBridgeInfoGuid Guid Hob to retrieve PCI root
bridges
information. gPldPciRootBridgeInfoGuid Guid Hob should be created by Bootloader.
Cc: Guo Dong
Cc: Benjamin You
Signed-off-by: Aiden Park
Signed-off-by: Maurice Ma
Signed-off-by: Zhiguang Liu
---
UefiPayloadPkg
Reviewed-by: Sai Chaganty
-Original Message-
From: Ni, Ray
Sent: Friday, March 26, 2021 12:36 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V
Subject: [PATCH 1/3] IntelSiliconPkg: Define PCDs for microcode location in
flash
3 PCDs are defined assuming that microcode is put in th
54 matches
Mail list logo
